From nobody Sat Jul 25 02:43:22 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAAA13E8C5B for ; Mon, 20 Jul 2026 10:59:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784545183; cv=none; b=J9G5f4Xo8R8WuCssn0RqJMUihDYRCLJDvmKVHgHO6V8HgWOAhEEU/c6vKrdESGkKgvZ55TYYjbfXFyW2lXAmy82BNiYrqLAsPUTHnCkTu7dpdcTN2JTzplN7OKhMgYJTBQ0eBqaPgMzDAXi5kylbKIYWYNqGo1M0i1zcKUDGHX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784545183; c=relaxed/simple; bh=oKXHF3XjraT7FxFjMK5cRcVCMYuhQ36vN3Ypojf5Ruw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Dic0lnZ3mTHUlMUn+sYN2/m8EcWjKiwAJoeZqwSkwEzTXw2DOJ9iRJEzX/nKvNsiOpvDZzCbpcmtrLIcMuUv8bUwx9InPraSJGW4BaPVcH6TFxMtp1puWUB+zc62Yhz2MiNa+srTaqbugCUxMXItEMCanxya60yj1nJndH9/x/0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EYimtF1D; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EYimtF1D" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-3811f512167so9813130a91.3 for ; Mon, 20 Jul 2026 03:59:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784545182; x=1785149982; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ZV0+ypWR5eWOjDptrYRPRCC2LyTiXygbKgh7rcUs85M=; b=EYimtF1DW3w+TV5YMSiqwmUyEX2eWd+0nJ1wt8gmKrffoPwsBHgc0ts2FDaeaR5Qmo mfC2c+bBK4Uo8SwwcxUKnPYB/j1rL5lVkoAGGjY86lodKiaUd2s1vD6AfPxeSiJA88LZ gtKnarz1NponP+2kVxCHvrdn1DNbMy4CX9Fkvuf90xDpMa0WyxTJifCIzbJNXIr8ph91 ZQ5vE5ZRCCLK6ekg9oEMTe9P7jyj0e8CAlbtqP1sDiBHP5ygikVQbQEJumTdWxQlCTgE kA78yBQnm4YCrfOEigw28MZS15gx88F3HgLXKu8EkBLBmq8icZUD88uVmGyc98gVZaAD Eu7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784545182; x=1785149982; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZV0+ypWR5eWOjDptrYRPRCC2LyTiXygbKgh7rcUs85M=; b=dqgYOp5+RAY7fEse8MU972gVX3g7v1cUxK4Ss9oljZ4dlbPmQA7t/XRYbwEamuRebZ qeNrEysUe5dw/BhxLpEGv24JVC/yl6DOg9GC0G7+k/+tbHSR66l/b8hO02W//MJQrIgz r9Q0nESUiVNSfmfPXe367fnpK1vJ56xlU6pBgKKQ111Xb7btpA2ZwekFGlUcMNKvEutH q3EOOG3psIkCtK0TCaeBtJO+6XYuw5IodWPY9rSj/MBgMSxKd3/EwqXuSCCGxNljreIA I4rZHPXCttUGQL7rQxbEKjFy0j9WastUhW65BxDE52H4uBRVm4CPTPol1lpd3nVHzFL9 QNWw== X-Forwarded-Encrypted: i=1; AHgh+RoUV87qHgtvX6WHEHEyrcRHuWbLn8rO6WerLTOa2v/v78VsaOnOIhYaM3Kn82+/jcH6U57tDsv3lX/96JA=@vger.kernel.org X-Gm-Message-State: AOJu0YwSDgaJA01kSlr26udipvsHwB5HzMDJazj1dFg/Z2qB5FV/I9j6 /swOvLl7UoGIExRRxAW0PNjNsxIrxgbxsg/8ts2Gw0mvFA8e4T8nUy8B X-Gm-Gg: AfdE7cm9Uct3zmg36+YIRAGhEFMQjfMB5LZMT7dTDlDx7pin9C6m3e05/9O+KSIqHoc XlRlCai5ZNf1ZIfuF2OobBuh47yEh0h3gx8LLdwFknrqLQTvi4npe5F8LDj2RRqF8d+SsoqLi5P kkazOfD7cSMrOokS09tD00UUQ1PNynpZe04Agc3FJa9O1/lEvcWkQdEjBEshNXupyryFDL2ud4c tfE/iY1hoqnNEOjVArFTYpxsWmS2Iug8yyk7CeA37rXq8nEoND9Yy+PQLF71SHpyG6nd404QFGE dEiGUFbYK+wJt74sObHm84yRnOiIYBxjtnRzI7O5vYJPWKnoXKmyYEX8gm+rQC0kOcCpHZ3lp2o ALS3eJi6g7iw9k6xgSgWCXxaSG+jHX/ahq6Fpvx4421mTVlzEdaoyrVCn7P2/BVznh8MERdu6S2 l0HGh/P0zJr2p3TUZQ25K+bC1+FDpiSUdQRrIuJYqlAVspc1tESlW1+vQ/MwurBOY= X-Received: by 2002:a05:6300:2289:b0:3c0:9c19:6590 with SMTP id adf61e73a8af0-3c3ada1f55cmr13543033637.74.1784545181852; Mon, 20 Jul 2026 03:59:41 -0700 (PDT) Received: from steellegend.taila75641.ts.net ([2405:201:304b:4973:59cd:5c84:346b:aa8e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9bcccsm40175574eec.4.2026.07.20.03.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 03:59:41 -0700 (PDT) From: Uday Khare To: sakari.ailus@linux.intel.com, jacopo@jmondi.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Khare Subject: [PATCH] media: i2c: mt9t112: fix missing IS_ERR() check before PTR_ERR() Date: Mon, 20 Jul 2026 16:29:35 +0530 Message-ID: <20260720105935.16894-1-udaykhare77@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In mt9t112_probe(), the -ENOENT check after devm_v4l2_sensor_clk_get() is missing an IS_ERR() guard. Without IS_ERR(), PTR_ERR(priv->clk) is executed unconditionally, including on successful clock lookups where priv->clk points to a valid struct clk pointer. Calling PTR_ERR() on a valid pointer reinterprets its address as a signed long integer; the result is arbitrary and leads to an invalid comparison against -ENOENT. Fix this by nesting the -ENOENT check inside an IS_ERR() guard block. Fixes: 6a26f141bf62 ("media: i2c: mt9t112: Remove soc_camera dependencies") Signed-off-by: Uday Khare --- drivers/media/i2c/mt9t112.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/mt9t112.c b/drivers/media/i2c/mt9t112.c index a8e2a3cf3456..56b7c8910112 100644 --- a/drivers/media/i2c/mt9t112.c +++ b/drivers/media/i2c/mt9t112.c @@ -1079,10 +1079,12 @@ static int mt9t112_probe(struct i2c_client *client) v4l2_i2c_subdev_init(&priv->subdev, client, &mt9t112_subdev_ops); =20 priv->clk =3D devm_v4l2_sensor_clk_get(&client->dev, "extclk"); - if (PTR_ERR(priv->clk) =3D=3D -ENOENT) - priv->clk =3D NULL; - else if (IS_ERR(priv->clk)) - return dev_err_probe(&client->dev, PTR_ERR(priv->clk), - "Unable to get clock \"extclk\"\n"); + if (IS_ERR(priv->clk)) { + if (PTR_ERR(priv->clk) =3D=3D -ENOENT) + priv->clk =3D NULL; + else + return dev_err_probe(&client->dev, PTR_ERR(priv->clk), + "Unable to get clock \"extclk\"\n"); + } =20 priv->standby_gpio =3D devm_gpiod_get_optional(&client->dev, "standby", --=20 2.55.0