From nobody Sat Jul 25 02:43:22 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 801423DB62D for ; Mon, 20 Jul 2026 10:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544188; cv=none; b=RWK+hB5lhCutB0baTAzg79PHykaqpXAVfIfibnPUusnWnsgF7cPfCMyjy6LnamMArZmEtdya750WGc0+enqSPxy3pZNFxX27YxCM6z4Gn/+9uOZKGYWCvcQTWWbOXh8AMjGnhrD15zPpAA7yMosnwEi/KZczSh2cIZDVH0JSbec= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544188; c=relaxed/simple; bh=q9TywrSfOvDxQhCpYgON3acXzWKDA5d1VFIKRMAsVO8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CwQjZHyXemQKJpNScllxzaTNHp4O5DwuJR4OdstCWKlw95U4TR/QfrFADrQjG9yATvBzWYsjRIeKM0Z44S9wPEJ+qA0K17dEUpJTZmncinq93Qu6juWhmyJn64f3UNSupn1g88Ln84550dCtvR1cJYg+ckyR1I1roRS54DbLMYg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ab0sl3eA; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ab0sl3eA" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-ca97d139d5fso6962872a12.0 for ; Mon, 20 Jul 2026 03:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784544183; x=1785148983; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Tz5mpOBL94RaDjJZ5VQIfWGLSNj5Yiy/M8U+BOtLdTc=; b=Ab0sl3eADj7WrT3DGcG+Xn2bs/mtWQRmQZUGyEPZNnqTNdDhQnrxJS3JDcULDBZvKY UvC2RqwEan3l1u3CGW2iDFElhMgtH84/iMArsB/KR5PxkyNxgDUgo5XHUFEMDpBBdjQH pZaiMh657FOpzJ89b+jhz1FCyFKCdYIdsEg4p0Vo/BjCicIJg1xQWI8NXtCo67gieVrt 5vQ+yVaG9HgQ4yci86PDZ8zWsZMuEW+1170uFqyh/N3oKtuJMDMYFF8TrwFhqgD9ySFG ngmb7PGgjQmvd2K8dWVfBb4sFAv+fhtw+/BuKfhWmbJ/uYqmOsf7O++D0OssIzH6PAHc 2TMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784544183; x=1785148983; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Tz5mpOBL94RaDjJZ5VQIfWGLSNj5Yiy/M8U+BOtLdTc=; b=lX+EL0K6xJznoS9LN86e5rFc7w+5zIIAvDD7JUh+/2dc+6Rf0J9k5O77EejGLO30Q/ oT60T3AlQttSEiLPqYvmWI1Jes3qJjfRwym2uQbFuORA/Qw+57+CZSPdIVAgG9xvN5iW vk5+XZuIW5DP/x2vKj+FDArF4qq7vvPkyay0/yYu+8vHBrel5igDdmZlrqYRHQSAZ9ZB 7bl2NHU4C0OZ7I+OMtd1xSgX5+MhQc0Q6M6zD3nB8u7ywrcAPYzy3M7ubcUnKXK2+qug Xp1SMUk/Wt+eGzNoNeMRhDF0v2mKio+ue8ESkR3a9FossG7ET1C1GHIVK+ZFO6IKcJfa HHvw== X-Forwarded-Encrypted: i=1; AHgh+RpHoAxODw0b53zXuDvpqHctZOzfck0iFZI2lNJxjnMDjCKXXkPrlkgsTuYr82YnXvDze3JXIW3AMpTQPlc=@vger.kernel.org X-Gm-Message-State: AOJu0YxZNLuoUUxBYLQcvmUgAhYZAspGGJRIAw80HBlRCQB/ySMCWD8k YEChiPDPeauJ8P4HMWWjR8mtAEbA8nxkubzGnN8R4SwQ5TVq13Iayk1v X-Gm-Gg: AfdE7cnbY5AhDKRvr9NZtGHtFjvDa1Y/I3ilXGoP3z/yWBFehIzVlTSkY8E6TxBGNdo 23h60mzTXa07+CwrhC0LEh0JJBKFBRy4eAEO7AGC/QNnlS13iiqgxbHhN92If5q9/F6YoY+zmQZ Dnxo/euBJ5Jbv1O26vL53z5IuJ9FL0t4PjQDraPxZ/xSOAEeLhUIU/l66yj68jYP6G/WgZgmthp u2NyBRjqchsViwXzx0ZDq6X1F5+WD8cpsr+VZ6qk1AdYCksTSXYIzXkTn/ln1DUROmiTxxYsMTg ry6O33Jo2gR+qHzP1XKON/1llWLNcDdtMfSiq+GxZprIopp0qEFYPaedFGl9UMZcajL1spw7T4g 6NEgJIHufPSrUbEmrBBgwiDVTBxvKNRuHcGMlgSi0K+ppaejOKXplSOJrW1pIevCxaua06S5vQ2 9hGuPbs+UVvj0HPb66MD7JP9dpCJ9JFtXBkgfOpXtKYL420pyognHbEDzVXC7EB8OOqvYCDKDQ4 g== X-Received: by 2002:a05:6a20:9145:b0:3b4:b340:411d with SMTP id adf61e73a8af0-3c3ad64da60mr14537972637.24.1784544182664; Mon, 20 Jul 2026 03:43:02 -0700 (PDT) Received: from steellegend.taila75641.ts.net ([2405:201:304b:4973:59cd:5c84:346b:aa8e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429fe1014sm35266781eec.7.2026.07.20.03.42.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 03:43:02 -0700 (PDT) From: Uday Khare To: lgirdwood@gmail.com, broonie@kernel.org Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Khare Subject: [PATCH] ASoC: max98090: fix missing IS_ERR() before PTR_ERR() on mclk lookup Date: Mon, 20 Jul 2026 16:12:54 +0530 Message-ID: <20260720104254.14948-1-udaykhare77@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In max98090_probe(), the -EPROBE_DEFER check after devm_clk_get() is broken due to a missing IS_ERR() guard. The code intends to return -EPROBE_DEFER only when the clock lookup fails with that specific error. However, without IS_ERR() the check: if (PTR_ERR(max98090->mclk) =3D=3D -EPROBE_DEFER) is called unconditionally, including when devm_clk_get() succeeds and returns a valid pointer. Calling PTR_ERR() on a valid pointer reinterprets its address as a signed long; the result is arbitrary and is almost never equal to -EPROBE_DEFER, so the check silently does nothing in the success case. When devm_clk_get() fails with any error other than -EPROBE_DEFER the check is also skipped, leaving max98090->mclk holding an error pointer with no indication to the caller. This means a deferred probe will never actually be triggered for this device, and any non-EPROBE_DEFER clock error is silently swallowed with the error pointer left in the mclk field. Fix this by adding the missing IS_ERR() guard around the PTR_ERR() call, matching the pattern already used in the sibling max98088 and wm8960 drivers. Fixes: b10ab7b838bd ("ASoC: max98090: Add master clock handling") Signed-off-by: Uday Khare --- sound/soc/codecs/max98090.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index 8c9d09c21e64..720ea85e0bf5 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -2423,8 +2423,9 @@ static int max98090_probe(struct snd_soc_component *c= omponent) dev_dbg(component->dev, "max98090_probe\n"); =20 max98090->mclk =3D devm_clk_get(component->dev, "mclk"); - if (PTR_ERR(max98090->mclk) =3D=3D -EPROBE_DEFER) - return -EPROBE_DEFER; + if (IS_ERR(max98090->mclk)) + if (PTR_ERR(max98090->mclk) =3D=3D -EPROBE_DEFER) + return -EPROBE_DEFER; =20 max98090->component =3D component; =20 --=20 2.55.0