From nobody Sat Jul 25 03:03:28 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012006.outbound.protection.outlook.com [40.107.75.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EFB23064B5; Mon, 20 Jul 2026 08:46:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537172; cv=fail; b=myYqnCcqoDp8At7+w2X0EVhQjYdYoFTPmiJUUiadvCBk2kCBHblv6tSVQ7nlaT41MpitbP8s7rwybzlnhY5BGIqvtaWOtKSQFaAP0tKVWmj8cKpb7Vk8OlpgozJOpvVzrkregxBR7TjXiAi6yzpiU38W2L0LGjRbHZu6KtGQQ+Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537172; c=relaxed/simple; bh=TtxmLylGg+mWIZp54YOFDXRNvQSEr3Pr0KsyhB9EzKk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Uxb1qMjS3Bn/R1UveK7nLAUaFr9s8O0wk1PRIS5Sw87zfLDGlEM1RzzNP5WUSgOMtf6JhaspixIMC5Q5zKHXXvnJWNdgiUl6W3WqdVWWt465He7N6XSubYZXUyZ6mNoLYWvz0ncyHeUSSwB+45jT/fbnlNCz4oNzKsSML/ozdh0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=M/AD2NPh; arc=fail smtp.client-ip=40.107.75.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="M/AD2NPh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R+JX5igbTkB+bkj+FLOlS+35t4Ej0b/iKCqqSZJwC2GudlyHcrBs6kO0gp1OV1d64XD66yMcD7s/ZXExYnewh+nOB45dIw1Co297DvAoUxnc71K8X9IK9rnjw/RA6OqpwZQE0TG27/gq+H+nf5j3ql6nA5w86TgQDRjFPyW3SFINuVfRdi0GSpTeZ2n03dy3x+UBiR2M0eqdiGRjVSXH3gsZeRktNz+wtRVTPPWKpsiQeM7SG+k7pU+EI8+1MG/r39vBadqQbjdmKbtAgKTXzqRgEtK54QYvuk7hkaJSku5JdGMsXBDxSfJ+NbMWshjELgopy0vvAMgZxQ3BJIXy7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yQ0f+Q73Vpbgmn/LSlawgc4pp4DtMdL+sTzKqAaWlNA=; b=PvG7R5vLhhS+LE7ecA+6m3JHq4Z9qyXJgvdOCoLCzNqfk2GEPGlIPOvTaJVxcfkLy4HjhVitkAG7sav8ezHeJKGBnLLKbGFbsP9nz9DVAUjW4K+qkluq09QaJ1wqlKW5pes0yfRO3y2yBkeBXBcEWx2lsS0XwgRbqa62c/wzjSVuL8sefhjlO0jf06ibB7uqHQ32JmOXUOvx17s8o4COAeH9ijcoLLwVMRnMTi3oNxgIciGVSodb2ibYvCrQVtDKagM0MXzXpu4phiYOBbZtMGT3dWOuRc+M6JUs0LNcMYiLCcGYc+4gyltQt8J1zJvqANb7sLAGYuGI8dGMschuhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yQ0f+Q73Vpbgmn/LSlawgc4pp4DtMdL+sTzKqAaWlNA=; b=M/AD2NPh6xFZoDTPIvsux8BxEAbvvnou9ZAyaRJJsCzEurw6QDmIXqrCwoBDk99jx7D1Qf9qAgz/1aLFiYGpWY/A3XdJWmWWQwgqfhFhIiTVlKlywTFFZoEtvIOMfIg+DDDbhu7rMj9wgWrj8+jrEau6N8GjWndbGD612tKZMmSPN3hXPiFn9jxKIAQxekcuZUvyfWmN0W3hmDmfxVf1TKFBj6JQdW2WJRpaWBlKmhD6usSuddDOAfNygFhYy5NN9CEfVHEVKz1yhiVXmIEG6ry4XJdDqHb7/lnn/GeAknDqu4wYo5qkYDVSzY8xslqQo7ciY7VBkGA30xEmkfCyUQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KL1PR06MB6044.apcprd06.prod.outlook.com (2603:1096:820:d2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Mon, 20 Jul 2026 08:46:02 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.015; Mon, 20 Jul 2026 08:46:02 +0000 From: Pan Chuang To: Basavaraj Natikar , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org (open list:AMD SENSOR FUSION HUB DRIVER), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang , Basavaraj Natikar Subject: [PATCH v3 1/4] HID: amd_sfh: Remove redundant dev_err() Date: Mon, 20 Jul 2026 16:42:59 +0800 Message-Id: <20260720084310.210976-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260720084310.210976-1-panchuang@vivo.com> References: <20260720084310.210976-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4P301CA0018.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:2b1::16) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KL1PR06MB6044:EE_ X-MS-Office365-Filtering-Correlation-Id: 21eb8390-4f79-4c7e-33cf-08dee63b53fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|23010399003|366016|38350700014|6133799003|18002099003|22082099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: n0SFqPzuLPSxc12I1QkHW8S9vRe6zGWPEJs2HpDE4C+v7SdoROdeqWZf3sJB+TLv5CRUR69TcgDpf/22ztN6u/n/3ittghL4YBekMKF/GBde3v2djcTOAohBzdRwUUe4/3HF0sQW+5KNgZPa6QKAQoW+vEZqWBhlZn4gacCnpyg8h6ZoL0FWs14z/sZuWop0Nnv/PtiaEpuUZSdY6By4YECXN0KmQA6mcbFsLZ3R2E7zan1TkPBG/o7IdH8Ro4kAM1H+EBxGs1c+BHAGCW0toHlak2Y2jjj4hEj9GLYsradn8L0l0+Xw3NU0H27XpYixvHTAs/3ockrhpN462spAl1UMZqlCgp6IE1qYk7OdYlFkjfWVIvFtiCeSso6YV7qcorFFLkH3jeK8VtqC2PM9gUpn2PhzI+4j68LZAyXe0ec2AvdXn2Esr0kO+FDriwskz1AAmHCnni954GRF8IU0gAOv8WPE/0KXxT26OOxCcRmOwwt6EkCARI9bC3ABMMmqNcgH/Swq2DbUxTaj6o84tyVSZdUxuApDnLOSv6fFwk+Zq12FD4SzLIPO2fVMW2HKYffaVxpypde3hgqRg5NLbIbUo5R0OPGO9ptnvgJ0b9RfuOJUgX0Y3jjMudEdd7ULsPJfx/f+XTt4z8Zq7CRwCgM3aa+Lz7gcKRWHaBfIu/H34Dq8V+BOTa+StRTVSdbtTpxK7C7P1rRvld0dFYLgA8btvCQnqUBifD7x54JVIuw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(23010399003)(366016)(38350700014)(6133799003)(18002099003)(22082099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sZjUW0sgIQNElExi9MtqWsmWf1bkoPufLtdq25ScxTzK7izpTPbh2ZdrDY5S?= =?us-ascii?Q?rHKvPi+xIJUUj5RpuE6g53mpW08WeejCxIHQZcFzQ76jyZso8siQkRzKZur9?= =?us-ascii?Q?kyELpmic41EpuS7hRcQvKGE1K8n0mLnMEBEkmBxGrqGl9prKiLZ46IdIwcW1?= =?us-ascii?Q?qiO3qiKu4GR2vqPe7HObuYndIi0RMV74uyE9GDoeHMYx8oAgcBELLQcbKi3x?= =?us-ascii?Q?9DeZlEog2+QkaUVPuEDt4A92VkvS3qftHYuSCid+vldtkenffqHqiA5GIGeB?= =?us-ascii?Q?w0566iGpidaG76aKGLRqCagTu57RhTUpYxbB/cup1Vf/FAIc5H8WDe9/vEXi?= =?us-ascii?Q?Fi/zRUSUsKUYZSt3sUcHlQrO2+jWQU8cBSo85/X6QWQmE6R+gaGaY6/952es?= =?us-ascii?Q?9a4asUoDuKw5lgnbvUZpmG58CMXDpaEhd8u1O857Jvs55PmLaoZJGrF9mWck?= =?us-ascii?Q?qrlc32sPPEqvByG/GOttpzqiDMDm6ruB2/E7XzjHr/cqjcP7gT6oIlyXBsz5?= =?us-ascii?Q?71BPdnehobGzkSaQoI2ZhyRXAT0hDWra60b+mHLxIgA2Plqe5WH4FgRCbE/k?= =?us-ascii?Q?wSifd0BC/a0HD/yLZiSPVR6+fDLr7Po8YYbnG4D32z7GqGA/oTNABw0S1smS?= =?us-ascii?Q?JslObO00qIbAQyJizpGCpSYy14ZR3SOrB+4zAhdT5KXFcRrqWxIkARvMT3/N?= =?us-ascii?Q?TeXLC5g1Y2BT/O2BXpEHIZqpweWJ0wWsb9EQXJbxdZ5iv06+UB/XG2F+i+6l?= =?us-ascii?Q?BOH8OoI2ODkzrxyDkyH9lhrrL366r/5aJ11NEVWIXYBA4K1vuAZebAdiCc9R?= =?us-ascii?Q?NRCyqFcSRvPv8BU7llKe1gk8BQkuOB53UMD6Irv7lskpfvj1qyDSRQVF838n?= =?us-ascii?Q?+sQbmhGD3vjRDxpUhQPAS+dt7giCBUWTRjZV8W/eEO31/Xs4jAFp9CNYktas?= =?us-ascii?Q?zIULGBt9NsbSlCOldtn2LGbp/id6teAcmqIdX+E8hD5LSberQmc18fXU3p0v?= =?us-ascii?Q?5e0hnJXv9+UXIm5Y94UFircFw0zydQB5BnM/PuIddvb5nclbpPSbPDdjD1IR?= =?us-ascii?Q?gwx6TcLKW/AlZxJWjk+cqkc7g6OHG4g00aJEfAAQLMmN9Xn7Zt2T1z3j4W0x?= =?us-ascii?Q?hTyem2yHz+pzz9/h3UUb6s0a266YpEp7WSxwSZFIKGz1JAGYfEXHDUkGI1Lb?= =?us-ascii?Q?8j+Ql+zUeafTebq1dzy1QyT/eFgJqVYui7s7uso27g0mWqCOOEyKF0ttztW5?= =?us-ascii?Q?YwYTTYJT72GloDgItdYtLia0ZMZhQZl9RsBNG3Nt3tWHYVUOe7AgE/SZUqe4?= =?us-ascii?Q?tBZCdnqJXk4LsRKTtVfko8vCr/sYvo/PC/4gd2ZumOE3qzRqzE9IhuLEmAZJ?= =?us-ascii?Q?NgBMQJrdGzhpubw2Isjip9EINlIVyXzvc60uwA+pJ2b+n3yIp1ncV8hXQUTY?= =?us-ascii?Q?A7nf+TkVBlZL+36OBllN8yyRChZ9N6ikhToSaLAdn770a22unTBVx8nLR3sl?= =?us-ascii?Q?kPif1h4aRZHVkK8Fr6WWZVrKYpNFWH/rWiexBrrTen6t7ZVdexPmNcZDMZZZ?= =?us-ascii?Q?L97jMB/8J76phsgB9eiecuh0gTlMcNZ26gD5XKLfUZCP65tSy872tvcJo5/h?= =?us-ascii?Q?QiGrHR1TQiuIqY9duPmmsi3CSLV4F1cAfOgLTFXR8Y1Gb+SlBBw4nMLI3QeJ?= =?us-ascii?Q?iQsJxusfKcP+t/9GW7irQGQiofb1rFUsZCJomJChdiFspess2Gm9wunPtcOt?= =?us-ascii?Q?+mDix0QNjQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21eb8390-4f79-4c7e-33cf-08dee63b53fb X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2026 08:46:02.1621 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2WapNnQrajI/iE9Os/JvBvFDciTxSthLQtXHI9FpWiruKlmE2MCjM8LfkSL2SD441r6gIJMJDUStf2Mtkk24zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6044 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Acked-by: Basavaraj Natikar --- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-h= id/amd_sfh_pcie.c index 4b81cebdc335..4d0a95fbc4e4 100644 --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c @@ -122,19 +122,10 @@ static irqreturn_t amd_sfh_irq_handler(int irq, void = *data) =20 int amd_sfh_irq_init_v2(struct amd_mp2_dev *privdata) { - int rc; - pcim_intx(privdata->pdev, true); =20 - rc =3D devm_request_irq(&privdata->pdev->dev, privdata->pdev->irq, - amd_sfh_irq_handler, 0, DRIVER_NAME, privdata); - if (rc) { - dev_err(&privdata->pdev->dev, "failed to request irq %d err=3D%d\n", - privdata->pdev->irq, rc); - return rc; - } - - return 0; + return devm_request_irq(&privdata->pdev->dev, privdata->pdev->irq, + amd_sfh_irq_handler, 0, DRIVER_NAME, privdata); } =20 static int amd_sfh_dis_sts_v2(struct amd_mp2_dev *privdata) --=20 2.34.1 From nobody Sat Jul 25 03:03:28 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012006.outbound.protection.outlook.com [40.107.75.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BBF23B42C3; Mon, 20 Jul 2026 08:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537176; cv=fail; b=odsQ/IQolwm1CcRfw2rkgA+2w+2w6wKIc+SaoZfcgGAivx/GjiQ5nGCa+0enrRNChMJDtAyEoohFMCCfh40xJsnWJDHPq3fIsEmLCgKA1M3flpS0VF5uY+4gOhMf9MY4lNKH6Zktdz8SGQ6F/TzP0pZ9pDOocNSrqRY+l6oJQKU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537176; c=relaxed/simple; bh=rIdSxrmPhyt64WfWTi1bnO/7CwhCQBD2XFj2nPwLVy8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=l56+5DaWdWOt+6sKDIVjzFKvymfC9iaNegHLe9lqBciKTIVvfsAYLwjuwAVLjhg5LmrFI5aMKME/9CDvvfs4xv162eXoadpxrtIzN+yqSAhkTLgrfRlC4AcAuXygm6e5PUvYZFimbqAYImBjL3ZLNi5VZ3obGRRnBE0kxfQqLNs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=PhUlU3EX; arc=fail smtp.client-ip=40.107.75.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="PhUlU3EX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GXBAVvZTeXZbnpUrsrlfyynxbG5Bq5zinqrWXG6UTcfLqlHJj1tQ52T/UHz62L3lvzQs1Tl7MBgX0F5PubjPzQ/RwX2+vHLcOKDoYE36CSM1d3/m2zoW8RPPVh4N/wW0BFEIZKZwqIsWz6oVJ6dw5FUnSdIfw6hFGTHnJtUlRWxfQP2UyQzdCJbK0z2/LQAsre+0KqCNPIYJVfGQYqc5okseInNnDfwQsjFaJpoH3E4P27NLb0yqvTy7rLV1rXiCt4+u94L047JvY12FTdz4tQR8JF+Gw/aQrolhrm0cA6qREwuelj9K4wTnbXO7QscUnK/jm3eORopXT7d9nwv6cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aOIz0Y84zgTrTYEevf2IWr3s7kOaVhK/8JS8Wy6vp44=; b=IJiQ3EifejtfSnwwiQOUGDFGhNilcA8wHmkqY2tgZTe8zDUMD7uortSS454WBkdnWUd7nKc/Y6kmjqvE2rhHWAl6+qhlSWIwXDaS7EsHAq+WSagCZMvjy5V/FInnN6fTekztvE/M3ZACXrDgHXlmQolpm4ljsaoODhFpg0rNL/8ZIrQsMxfztCqxRcllogmKBXzSnbIPT9SqhRD1jLAwjsCq+gB1U/GpAuf/cr1Qk27jnuou9M3mI1WqmFlOMuJxEIIt6Yh93TxgBd9jFPjWUOYvvWPYa7pWCTFh4j5zZdeNLu41jyDXldqWqq+YUlxlTuVHvKqTrcUwyDW+GfqvWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aOIz0Y84zgTrTYEevf2IWr3s7kOaVhK/8JS8Wy6vp44=; b=PhUlU3EXjQiR508gTPwdBIVpJJMoDAN6dB2t9d8lTEMm8bMO2Osx0QigRtjzGvdkaF9BKeLdFR86e8ANuGqs/4rYp51HQccQYZFoST0mKnvOm2w0LORqgvSeVezRtYeXwDGXQmms6I+2VO1CmLKPoRDKse2UEXKiJk0PItQEQHp3FpeVzZ/Dq4n57ODW6vcxILSo/A1fRujMuZ+5POgt2P2H2955fTFoU69QRhM7hi6Xr22FbS1lT01SDrO4rbC0MTt8uz8IffYeLKipwsVqSmRl/kfi6w2wZhSdnRZzhBwvnIFIKDBtnjuri4WqKuUi7NjevnbHZgtOFkmhzZegDQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KL1PR06MB6044.apcprd06.prod.outlook.com (2603:1096:820:d2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Mon, 20 Jul 2026 08:46:03 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.015; Mon, 20 Jul 2026 08:46:03 +0000 From: Pan Chuang To: Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org (open list:HID CORE LAYER), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH v3 2/4] HID: hid-goodix: Remove redundant dev_err() Date: Mon, 20 Jul 2026 16:43:00 +0800 Message-Id: <20260720084310.210976-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260720084310.210976-1-panchuang@vivo.com> References: <20260720084310.210976-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4P301CA0018.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:2b1::16) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KL1PR06MB6044:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e34fbb3-2f1b-40c6-67f3-08dee63b54bf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|23010399003|366016|38350700014|6133799003|18002099003|22082099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: hM4Lc5h5IxtUH1XF8shYd8f5StJMWFc+85zWACDh0aYzltMMNVsoyBSic4QkQBW2/z/2NUyZfoaYjEulUDxqXOvziTdg9W9y8Z236wQILDeep2R8abMYM+n3zDeqmd/ekqZKD+xjAT3yYsmB+l79kQXerxqJx3huaUv3aySFrYbl+Yf5RG3Lgvn/JpHrqaYajZqY0LLZpHv7zrU75uEYAZkVkWFWBt72YtrK8EyuGMTjFSf1x6zaD05MoZ7pCEz++ryFEvT/Ml1B+1I6PG9eL4ZchAYzvrrN6LOsGWxadD1YOE3L31cCgYTDG5xRPAXMYkLpwlDDcT+lorBQGF+fQh7Q6Arz1xuInsly8erSz+jhTzDo8G2/bqT5e9VLgKJxA+WmCuDcryEY5C9ipRmGHbVCYfWwTavFHDUC6HqTAvJXDF66FVMNMeDqW7v7WZZf8rg2TUp3RA34qcE3+C4CQF5c3/uNkQpt7eI0e2nWn38xuAR9PRZkYDgirkRt4zLw0aIxG/SJTvidrjO1xhLco4S/dH0Tdhn13D++lK/x7nAfI3EQY1WpE5oYzXuHdcal5i1p9QT071E7mjWlkMBCUlhBTXDWfiz9AorT1FynqqhHIqSBcQxp88TDoJ7lo7z09WsNrwSVe/tCQoHW0WGa/GQhLsDDirvmJk7kj7uytJCLC/qE9ZIlMj8oBwMwkNEzlkiQGQPn05MOzrGblz30BQo+63R/WlxMXCN+WZNPmQw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(23010399003)(366016)(38350700014)(6133799003)(18002099003)(22082099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vzPpy4Mp6IhkO1PIRzl6wgn06hSgayq96BGvSFfDy5E2Zv2PSrZDiuSWlBDH?= =?us-ascii?Q?DYo42i27DrsFd79jYArKI0QtYEaOcRtByGZwgkw8ER1xprc83cyg/6CJeUOt?= =?us-ascii?Q?bMNLvD43FWsOHrS1MzT65KsjQNmUIxIIKBvIpk0oSb124JRQ8e7MV/kRfHea?= =?us-ascii?Q?LPqUq4DMCNE1Lm8MJojrx+y03CygZPth7/wpogxaI27p9T1i7vU7TPYKwfRW?= =?us-ascii?Q?d6L9fvJJNi9gsJZHPf1pi0PugXyB9EHq8KF3FgFyXJiZQgl+foahc8ocQczj?= =?us-ascii?Q?CP4veCtI23gb7MR5b6vv0MTS/Bx8t0EU77u0K7p91QEB1Tkfy1Ss+r7h09Q+?= =?us-ascii?Q?4q/jkUAt6vxFe5/e6g2aW1XE4oUDDk8avSmODwBU5/05yxnb9zFCKIlJg4HW?= =?us-ascii?Q?ak08USiyyzRgmjvQ9W02CULleiealIA6cr7pCG+CYBMleJvsZiPFZ3yz7RqB?= =?us-ascii?Q?74UMMq95LpM7Wu0M3R2FG1rYBnHds78yH3+OvzuEDRgPGbIDt3DR2OGl4ch1?= =?us-ascii?Q?4Gh/jQv66poISXG6b2XPrvaAvUP2hxbLpIDzJP6yj6h35eKdoMrtAwG1jf3G?= =?us-ascii?Q?iq+OewWmot/EtpJRrQHrcjlK/M6E/AL3Qi0LTQXa/UBP8JknlMX2of1YJpvH?= =?us-ascii?Q?HsdiOetlfygZspi63XdSXmXMQFXfUCQX9C+4XqRcPhjFIXP0SrtK+rE3wH6J?= =?us-ascii?Q?eeG4zU4YVj8LnPbuO1a3z65coDCepR9BS+og9dZEIQEPZIWMJvFZd6uOdIN9?= =?us-ascii?Q?CeaTrcrxZFtvLieEOps0VxYVf/faoQv5afJ6inYOYqn/OM+0Qf6GdymHGhh9?= =?us-ascii?Q?cxEZXQuhPG0QikqNCUsYYWMyEyMUR6gD/dazJLH+i48uYFjumrYQFer/SmMW?= =?us-ascii?Q?2Xyl3dswktKYxBk4J1wbMUrvscQrmI9fZmEPLv9ZvblnZ3ZRAOJqSL6kq8X2?= =?us-ascii?Q?+izm+oc9cZdivR/ttQpqtX7u0n5W2fx/tg4vBU/3G1Ysjf9MYmsLiyUunhDK?= =?us-ascii?Q?Ilo407jcq37aRlHdhVMdL7IDxySiSbS7CKyDnDbxAmH4bAODmKZrXK2jt2TC?= =?us-ascii?Q?gmvFz26HIu0xrcpF1rC4THyfGO0CFtGSzxX821Z8yyphQzUZ2QE2h/lAbVgX?= =?us-ascii?Q?B+68WOuNq+fRnaq7B1tfrkT2N9jWyGXmzI5jfBdsbMta3LIPon/ciQKLb6qA?= =?us-ascii?Q?MB212c+Yz7mHfr+XoNBEsltMTjMqIeNvmzK0NVSVKZlmPEv/+y3jVNeQyYUh?= =?us-ascii?Q?6C2/64/22ZGASPmnTR2bxayVG0pzPqBpa1tYIvFT0a1xfzEq/TchzK+srk5/?= =?us-ascii?Q?81t9AjTpCUhUF8k99hGq+Rff9s3Oc3DCMxfjlzYNdOZkOJeQwWYnlpFSIMoS?= =?us-ascii?Q?I9b30Inq6M3pJt2LjWBv6UaImdIG0mpIbBNXX6F0MGFXtiX1XC7ZpK2AS88m?= =?us-ascii?Q?t+owUwurrGQWg3ayyfXBjyIX75v2Hk8YzMpmXrnV2JMMgefaEFfm/0ssxSY3?= =?us-ascii?Q?LluE+jYfAMrrDaG0Hvty15ErCFhjGa+/3UcSrDVGmCZ0czvCtFVgr5nmoE6z?= =?us-ascii?Q?PsUkZfECLBo4QWbWSQFrHj74kGxWWID7y7XMPA6qVz8045EhbWg5U4ZZI06W?= =?us-ascii?Q?tmpOcd38SQftXHfUvRaHfSJlrXwzarOGtColp/Z1I+9lBRHz9akln9a7/DZx?= =?us-ascii?Q?VAI/vI6pEk2VTh6GkAXShMQMo6uzR/DdZrW7IoRw5xTHF5baqLYAKnraGjEU?= =?us-ascii?Q?dAurZUWuHA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e34fbb3-2f1b-40c6-67f3-08dee63b54bf X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2026 08:46:03.4760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4sZncF+uGEG5oWOtLGLOzOCp5CA4TkxKUp5wXbD4nJkXMCqrQMrkn1JNh5SAw1gwV1GzPV5wFzbsUx3H/+Q/Uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6044 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/hid/hid-goodix-spi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hid/hid-goodix-spi.c b/drivers/hid/hid-goodix-spi.c index 288cb827e9d6..03d549efbdce 100644 --- a/drivers/hid/hid-goodix-spi.c +++ b/drivers/hid/hid-goodix-spi.c @@ -722,11 +722,8 @@ static int goodix_spi_probe(struct spi_device *spi) error =3D devm_request_threaded_irq(&ts->spi->dev, ts->spi->irq, NULL, goodix_hid_irq, IRQF_ONESHOT, "goodix_spi_hid", ts); - if (error) { - dev_err(ts->dev, "could not register interrupt, irq =3D %d, %d", - ts->spi->irq, error); + if (error) goto err_destroy_hid; - } =20 return 0; =20 --=20 2.34.1 From nobody Sat Jul 25 03:03:28 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012006.outbound.protection.outlook.com [40.107.75.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 696913B6BF3; Mon, 20 Jul 2026 08:46:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537179; cv=fail; b=MW4VOS+m+Oh9rTXrnj3iUD4G/lZRzIoMpUEUSzDpGyZM3eKy+mqX06hIxfgjB3XpAES4sFymDDEBQXk6FIt4WGuqIZkWtvCLgxpRTnIgrchfKwm4LTIqTxmcbqwbtEmxpgZpFYsKx31TSuJHLSbYYLPQxghwf1pM4tzY4xWTjoo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537179; c=relaxed/simple; bh=ZcNcckda1dnWUwD9TdPwawLmDQnlGaq6LY8VZt+uOaM=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=uAL3Ba6sDy7hb059IcNnVJQYr05IhatUY2klKE0u0O1tOXgIfHATcBumNxwi7l0+tsMzDCfiRhzqyswgkJrfa6Xa+IpMV+CgI8MYuYWvPY/zexB+TtT1Vu158C/phsTf1QHNhTIPhX1F1T9ERuUm/E9yH0ZnEIkKidkeVovCkqE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=NEtSLf/j; arc=fail smtp.client-ip=40.107.75.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="NEtSLf/j" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EdoEffqY/z3d/kHdjSQxN3ecPqIMOSNsMSv4GnrUj+GPROdzxgbcv4/LHR05lmhYN6HMk5qkvp6sNwymNQG+mCFquG1Z3+uJ8u5MraLhsV0yv/VfIeFcRN5x5hzOv8KlJhWWENB/aYLMaeEA83nAEJMZr1E282uY+jVTn5GFUU+CpUD4ZSfZDgS7ea+abpac+ecL8TIOOr0GJRLFddViwXR+jZxq541lSVl1dS66gBbr+V8DS3utdsVJND5aSlHYdBRThBtNL+b2jM8pjRi214Y7UKaIkoO0x6md63y1pAn8b5i2K1xBXjfoa0cuJxVhukpSd3aGggmH60/KPuaSEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KQqnkSRd4zAYbwzlRhVgThpJ44dUYWW6LZsP71AaZCU=; b=sxVyDsngTQqhXXFHkO9NthyQnNfWZuIzXk9YNUAPIoF+58fxSkSE90JleaJkz7kWaJp5a+ugv1ipz82VigMN2woiRbmkZI6iXVEXuhYPWs3J3KrbTBLNlzaMjLK22dzEBRm7PG0MiyTbrm55U2sDnO1pJ4GsCfe+8mlYYd0owudcxrdmt7l+Zv6mJ8l2T8GxMvJjRHydgsOWe8mBjboHFcL4x5UltEoURe7Xw/X7oTgTo8Esc9SHKhZkMi/2pJPIeTv20n7LF5ipz61GA5giUoTK+DM2HAdA7tDogVrKavZSIPk3Ca9U5zluAc1Uth/E8d+D1O7TjBCSBN3fePREkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KQqnkSRd4zAYbwzlRhVgThpJ44dUYWW6LZsP71AaZCU=; b=NEtSLf/jBICQ5kjh5bgifQC61Gb/RUoPSO1+qpv5RQELSd4er8N3u0kVGKdwg/W4jczwt46Q56g+pG9oQ8Spk0Py9GstP1cb92Smnaj6VpDpD8lGbsmzN/Ov+Z4FxfLvAQD0pILSPkkZH7OnvT29P1qtx44paSUCsDB1/sUodtmN1kFviYq5HT0Li8SvoPt6+BOMkiZBVg90ZyGdiXcqYeEiWr4XDtNdwCpY0QD2URUCHfUlyHO2LbulPgBWgl0Cxl83YDZbA8FcDuL7bhibZKMZXCzT03i94rqKSZmikKjFnIs30E6lsHOswMfyG3lWaCveqKey1O93/sDiwH6jhQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KL1PR06MB6044.apcprd06.prod.outlook.com (2603:1096:820:d2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Mon, 20 Jul 2026 08:46:07 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.015; Mon, 20 Jul 2026 08:46:07 +0000 From: Pan Chuang To: Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Zhang Lixu , Andy Shevchenko , Pan Chuang , Vineeth Pillai , linux-input@vger.kernel.org (open list:INTEL INTEGRATED SENSOR HUB DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 3/4] HID: intel-ish-hid: ipc: Remove redundant dev_err() Date: Mon, 20 Jul 2026 16:43:01 +0800 Message-Id: <20260720084310.210976-4-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260720084310.210976-1-panchuang@vivo.com> References: <20260720084310.210976-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4P301CA0018.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:2b1::16) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KL1PR06MB6044:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e00312a-e4e7-4686-0e8f-08dee63b5731 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|23010399003|366016|38350700014|6133799003|18002099003|22082099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: YUk//l5mRzmuw3SvunEHSLeA2dwpk2yTc24Np1MJara1DpnbgzYBsq17qDDoiVR71kSIKWrycFfswV+r/g54TL3/5EkbW0goYcuM/3zXmU3YHy8IB5UUzJggPqxAHTnnyXjAwYbhelDvVBc43OrOvBmLIA6UWLjQ0I1vdLeuEqqE98Ot+GL9/IMucVHiVh4yGoQxgRVGfE6cSULoi22aLUmvrMCezjJDNtcIicKakmFo+oh3NGXJ4A2aeY05H/QAUJhfdUj4Vvcrfk1xfFGLomq/lUevG5qaHxehNncpxNt9juqngqeNz3ZCEDiHK+sOsz9MdDq8ospNcRtA8dZRx2+D3B9DLFsOmkalh6vPhuIK5FC/lKHLY9TZXW7gjx7BMpdLRk1Ps/5f8xsXFjsc9keySp3ZtFsz3ce6vqqkYgtF5Sa8xG+GQwsryoPbg8em3VlKQ/j6qWefdI153ECpekvbSFEsB3tP4O0L7yF5DcvoeJ4nUoYKvI5YVg/VfZtV80XNaGHCvi2ttyCUgCvV7/ZBktF0zv0UCY3UCZqk2WFcsHMnkXQzOzAbzS3kzvl3rOA+ABQR10V7qEC/6coQtc/IZr0kar9HT6PpNXXiwTffH5EEG0HntWR3nR//1hGjl+1z1Sw74VGCqv4s/a4teGioO/eIMYHu7Lz2a1of8UHfMapKTX3QgmhEbr5peLb68cQUkofqa9gplqDp0RbLl+QzhP9zFadzxim+AaFrG/Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(23010399003)(366016)(38350700014)(6133799003)(18002099003)(22082099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Gdy3D/DRbWq0jKEgEHJc99P/+7YLDwtHchwpTSIB7JuJ7kozp4yvRweI2+WR?= =?us-ascii?Q?9jNXOs4egVE4JdymbPoAdqgAMj+C6LaR4QctpPJvL04n2TxwL+nidgdyDE71?= =?us-ascii?Q?db21D2aVF+80EIhLwFWYA7ySSf8WAlTCtnUAirqCyKuseIaipaFZVxVnXcme?= =?us-ascii?Q?77nVueW/u8NpcC2QGmbtn4QnIfILzOMIPYy8PPI9uvMqdD/kX0FayQwYYkBs?= =?us-ascii?Q?4L9mSs6rAFKKFYoI5S0FSu83tBEVG+rnAVDinxAkk7KzRVvc7ORi56zmI9a4?= =?us-ascii?Q?mu3omD+I1eWuvaF/LMVFfXv7DVKA9wDHZ6i6JBFFjKdZeNkKY+ZWzlCjL3Ey?= =?us-ascii?Q?oTbGmPfzySgFMlYYhTjqMQqOmIVgc7/2Xv5f86kt/O0wyOX3YJMr4WdqH0o4?= =?us-ascii?Q?EjLB5i3yPPrs8Ba0FK9zrS0DMa1Kh6oNd8MQlaM9G8aF1TnE7L2JHFhx9Ngt?= =?us-ascii?Q?ET2JsS2pgj+Ppr6cQ7HoYDu4cBA4TwxoYkwTmZxPhao7pQHwH0I/rkPC5R0D?= =?us-ascii?Q?9ShKMTL1/f/PRziVirb9d+yfsokZxdnfsvZnPCtE0iqoy5nwGSaYzKzMfmrQ?= =?us-ascii?Q?vFj8OGDgxpcH+9VKiQ1JwSvHe57/vFxYbG+FFNAPaBAQsPNu0mrMW/bYFJkG?= =?us-ascii?Q?h5p9ALMgmrU+rrTT+qHDJLQqPkuhuadsx2Vgu9MjZ+exszzK57RYzpKlCX0H?= =?us-ascii?Q?CcvL0QRe0SntU8sdDefx3i2geV8VxXOLlLxceH/e2mFL2WeahLF4LEsIUSgA?= =?us-ascii?Q?HTW4Ovq6lFiSBRQxBPzENYNfdC0YexM6n+GNIeBBCTfEFYYyOUg2AfLGkdd7?= =?us-ascii?Q?j4U8PkJydcUZjllbgXbiyV0/d50EZEzLk0p/t3z1nu/tW+4a/w06xJyhwllH?= =?us-ascii?Q?gfnTTRKGLXxRwXQ0sWsA6VtJ1wcwGCpCAgs1rXkdYy/4Z9K4MsrEbokL9Ope?= =?us-ascii?Q?p3KxF047BeVTDMaIqNwcgvAbjNBFB6gTjyDoO2yPJCusWsxapiGsWTmIhC/J?= =?us-ascii?Q?ZX6pcKKn+Pvv+ww6balkh75aDmu1biv8bNOKZWAWMyO6rgNJVAazoYarYhyN?= =?us-ascii?Q?EhTTWHkuELKXQc07CPFI57wHbFlfWHkeHtveb7ZzTpZxy5OcMviLuw5eRwCJ?= =?us-ascii?Q?BMlRCmLpPEAMD74JXszSSQXlM+YveXkkUtHG2LIfl0RTrooz93VY5x4ofBRf?= =?us-ascii?Q?IWAKjzsOql9kebBoYyfb6F7qu5f5O4lExQOzglcUlF8WonMalchBek7VsUzJ?= =?us-ascii?Q?pUpocgXppYpOcfzGW6ojncBiBl8BCuVjVS0cqJEoxypT51fN7hOU1MiKpBS+?= =?us-ascii?Q?cVXfeA1yz9cv9mX2Ut27lZfUzC1z7J5bKStl5oxlP5CB2hEYGRtr4pH3g0Dm?= =?us-ascii?Q?ptEV+11fv0o42JGux2TM7/sJQRKTJJ8roOHBnT7ldj+fGPDjUTBpqvodefwT?= =?us-ascii?Q?J7vss50+4R6srd4AK7a2MCnhhga+K48EUDlcoePdKPPiFfuK9tXsN3o/nG4r?= =?us-ascii?Q?3YOTk9VS+7jr+y80dapP/Q2Q16whTTbFeB2GHXcq3aSxpkbiKO0ehu87dOpm?= =?us-ascii?Q?WQkGthiMtDvT20J+KlryFR52752GG3WhVomk8SATJYYvSwQuk1e7/Bqc4nVv?= =?us-ascii?Q?421lXyMqMv9Nqc4+okK9mOM3bcuophIsuMoRUfVU8lstvnk63468WPa26/7X?= =?us-ascii?Q?SnMrGnh5Q/aDEk9UN8wra+T1AbzL1La+hy4WCqp4802Q6twG5MlMQJFOuiIg?= =?us-ascii?Q?1zIDOU1GIA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e00312a-e4e7-4686-0e8f-08dee63b5731 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2026 08:46:07.6155 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7J8DoevBMchzlzuStNPbzRIitfIC/PPS6HhyQ0C1jSBqV/nFyqV8UajjrnWlKGmVxvjc7MdIuHzwJ4l15r9NpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6044 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Reviewed-by: Andy Shevchenko --- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-is= h-hid/ipc/pci-ish.c index 8d36ae96a3ee..e7196e429c8b 100644 --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c @@ -232,10 +232,8 @@ static int ish_probe(struct pci_dev *pdev, const struc= t pci_device_id *ent) =20 ret =3D devm_request_irq(dev, pdev->irq, ish_irq_handler, irq_flag, KBUILD_MODNAME, ishtp); - if (ret) { - dev_err(dev, "ISH: request IRQ %d failed\n", pdev->irq); + if (ret) return ret; - } =20 dev_set_drvdata(ishtp->devc, ishtp); =20 --=20 2.34.1 From nobody Sat Jul 25 03:03:28 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012006.outbound.protection.outlook.com [40.107.75.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 163C13B71B8; Mon, 20 Jul 2026 08:46:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537183; cv=fail; b=Xx/WGkHn9aAp6RsX4w4rYzD4jMcPJ1HaBZK/Do16AgHZiIXES2JcMaQyUlIbKmFPhtO2EgewM7dYHXwW+v7gujtz9zBMMibRLLvcKFQ/Qk+nodaZbitX2aa+MrTZesby3zlLPVeHu4nHXoSTouVF8qF28TyNf/3BLzHhgsrn5Kg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537183; c=relaxed/simple; bh=bpQesPniBc959fOUDprdxjOtf/kg5AxJxIkoPCCCj+8=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=gGX0B8NAs+UULMPGOvU160748V5H8KFtTXRXtFkrpsElMeWS6WUzD+zFGBJjxP/77GV3qgfGB0h0+mE9rKlKtiuzNdADMkATrbqKdF7JdI4ZygHSnDKLp9yjcOu2Qf1pBlT7bQCO4JkbfaJK8T5iNL2mwKMT+0aobZPx2IX1ZZg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=Rv5YxffW; arc=fail smtp.client-ip=40.107.75.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="Rv5YxffW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HdyNXFOb6FgfkNWafIPdSrlcD/V+NKWpdQGtF2qCmdfHHC0Nv/KeAa8JdM58bc1BBLzOrscpzrziIiry3VpyeMuSuMtgpaG+KRK0UCn0HURjE2iZWAEFLfAn6VYKkQOgRR+gecxQKDp0jIHk+2jD3LD81LjHAMsDSPpKRib1C23TZwYXg0I4rS5RemDqIzpQCnkguwwGw9RRnEB+D4YDxPkcZKoOuPiK5YTdZXAKWGwR5qO0hdczS4904UdEzvqEZM1g1pEHdxafJ+4D64z2TSDoJ6ekqNwGsi1KzkUuBZe76Jo4m5JL7nACdANpPyKAx0rxHa1MuHUiPCXWOCPLaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+MpT7Z1a9HCh6JJYH8kxwAOGMnO6pCC60VVCihz2l/M=; b=Qi6Q+MEqzXiUNGa38kmZ2M9L07buATsWDWBvoi01RLK81sILDJs+7+Vc0AewU03WPs2hYPo90QL73mJFWXDmRRfVB5ZnHuQfKn4bJgLetFCUfxKQsiwjj6uodl30B+w/SiSxngZL4nPxgxXcXyeAFiUvR6o3p19mJD7mtGoBxe3aEKRI+xOSh3uy2MA0hyyCZrj+PF4tks/V7KUJIUvuTQw6Rcdx/6alWeSlZpkQ34YtXgDNP69AkQoKeJdS4DKQJdCLZVrNFGTVzOtPtS3hm/cEcNGLSeSAHb6ckI6a+ywkFcSnhtTjMFRGcrbmYH8dhaAIh+TQxR55yjlZubYRYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+MpT7Z1a9HCh6JJYH8kxwAOGMnO6pCC60VVCihz2l/M=; b=Rv5YxffWwqbPoPAioKXsLf+LkRRjLgQGMy5y1it+xte3O0+kaNxyEnPq6JaqP92tcUgeDsdB4I8BVW5Kx/RkXpqcaE/HxnJJoGth4nX+9pS6G55qvB6CSvoIYRlWg4KiZ/M/mSTCZjmKI2Ca33zncTRevKgaUPQ7VYJwc3ZmqwS9lXfoGKMQvh9p5F0055yZS8YMdDbKFCOnLHikujn6YOqt98klIbppUvTKjApFNP9zP4xLdOCdO5niNVjqyah1dpdQ9+tAI5Vd8UGMkQxO3RFLjqMiSLx4Fmj7KB04/eaLlnrFNpWoi/OyaNNJ7IsVBifww6BygL3AY1LGP+zupw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KL1PR06MB6044.apcprd06.prod.outlook.com (2603:1096:820:d2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Mon, 20 Jul 2026 08:46:14 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.015; Mon, 20 Jul 2026 08:46:14 +0000 From: Pan Chuang To: Even Xu , Xinpeng Sun , Jiri Kosina , Benjamin Tissoires , Sakari Ailus , Pan Chuang , "Danny D." , Abhishek Tamboli , linux-input@vger.kernel.org (open list:HID CORE LAYER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 4/4] HID: Intel-thc-hid: Remove redundant dev_err() Date: Mon, 20 Jul 2026 16:43:02 +0800 Message-Id: <20260720084310.210976-5-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260720084310.210976-1-panchuang@vivo.com> References: <20260720084310.210976-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4P301CA0018.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:2b1::16) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KL1PR06MB6044:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a2dc7df-1899-47f5-88f9-08dee63b5b25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|23010399003|366016|921020|38350700014|6133799003|18002099003|22082099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: UjXiX1FGK+zm0yoMs8zPQHQCR1YBNgz1HJjFf9UHFdQ05kmCZYygA2+o07Vx9yevImkSawH/LY7xU6xFu2GqK0/4hC5q7YrZJ+GVP3pWu9ZKB/+HDB3najXXmmUzCwdg2PI+cnwdcSvrNbmafMJYB7+3RhkrHykSx4uyNQNzZ02RcuSP03aeP39KkOWJ9HYAKbiAuqnXOy82TaqEoRXIMcONraSo81xMLYGOuyF4pq6xQ5Y0yFxCl3Vj5dxJcRX0+CsqJ2W/MQCh+Ib3yo4J+Q4GaPZXxzjq8RtsBxIsgrBirzl6tmyAYbw5WaIUWkO8LBjlIJzCld6WiOEtj+Binxseg29WDia9hnRe3rG2DKS791l6jPwSvcrKKeR0BVJRPsFZlPYEvruz1rx8h+vbs5A352nL5+Jc7DHV0Ouv79CjApBEeRKULeSG+YSUMkRn9f5tMKBcvjyuuAWbk9zbDUb0KtHBO3Jsh8c4Pdv5ocPiOtIXpkX8TUhupSqXLLdR8uQyY2UHhU0iYVsgqF6F2ooTCAkTilkCrN5e6T91DYHgjuqeeXl3SEnnqD+jwlFloA8zVnBPcowx8sejT2b9DXkN/ONev84tw8p+f1CVey+ZhuEfJxhkmRINLn2ons1RlFq+2yXjMc04I0zHd7tV96/3E0uwhDqjY3UKS8fFBzIeq+zKCQ/cGPyf9V+tI3hdaeJKkWQfbtDK4K6x63PHA0XJykJMwTz7NSNT4wbYyiPRxjnFp+HRf//cN87AYxdG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(23010399003)(366016)(921020)(38350700014)(6133799003)(18002099003)(22082099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wMi5H+H6htI2aJm6hcsfYOBnrXDGIv09R9isJCBFJH5XPK1x8b//NLb1QpVW?= =?us-ascii?Q?sHodvnYgxvhGUOdyyO8Tn6y9nVtvu+l/f30BexTWNRBsvbxULdE/PRF3h+Za?= =?us-ascii?Q?HqWcVO5j0naL7Y/832RsHaGaUzVVs8jDXdo2FYt+EwzUFPQ+3rGduOKsCv3u?= =?us-ascii?Q?Wo1tKL1OgjYARm+sIirD/dq1s97ZrgekOu8cNvaNvj87rN9v90Dp7hS6HH3e?= =?us-ascii?Q?Z3Jg8PCyoICnEZSFiiYEDb8risb+6Ugvn9ZIUrE7VUOsy5E5jlAvnmAQGC+7?= =?us-ascii?Q?amrZ3jcYLs8hliHMErhEZQJzYRSEflSxfa09bKW/bTnOGwAXDSLCG9AzbKU6?= =?us-ascii?Q?L0Yrhj/+Rx7w6t/fyRv6ewNWskD4IUobr9OhYGpuVErAt80sEmHYMCDSzgVu?= =?us-ascii?Q?P5Bw2FPBS81nM8An3gpBZJkUytdS6Cys8kDoUhk0+Yxgm0JW5Iz5A8wH8x38?= =?us-ascii?Q?Ln8wbPGwzL+BSZv397sQsL1YNod3rYFNhQvJ/CEN5HrQ95ly1zytT4vNzq22?= =?us-ascii?Q?XaYVXi/WOofYYhnsr2LiQeJvo4UWBOSaWLIXWLtOuunJ/2Ataqd6Dp6nPqbh?= =?us-ascii?Q?ETWGZMXgaqjGa3aBcdVjv9Zayvun5yesPeR6RmLoLd7RFRL1xgxzCyAh2kOY?= =?us-ascii?Q?7uQKqzhNUo8e581Loq2Px7XKBzetJ3iUVZ9FgXghnw7ovSK6b/BjukiDD9XV?= =?us-ascii?Q?y4UmNudYET8dbprGvCXKoMUP0k2TvABDTGHBRPCgWdQPMtSJ4WAWDc1ok8Fx?= =?us-ascii?Q?6JrgtCCOplRY4ZAIAJXC74e82aqDe9hO9LdxlbaTDk+rkCf8uLoqB8MOjBJQ?= =?us-ascii?Q?zuI2mvjKBcInpkN+HfBeZRt46ClkjboQ47Ue4iknyc0Z7J8rJcypHxOBANTK?= =?us-ascii?Q?sQrD5WytSwbUVAK8pNbTmh64hSLUWiecwursF/3jH6xaLKpO7x7t+HUXvsOP?= =?us-ascii?Q?nUcfnwwrdk3WtngHgEzI0eN7NTuGkau52KC4IR7/mvONPya5mV9JF5JC5QAO?= =?us-ascii?Q?8e1Gwku3/iiaDL2fIRPDUAS5LqLkowFh2t94mNlaqrkNVcqtkcRXd6nqZX5Y?= =?us-ascii?Q?2QAv+9cCr0ucOE7WPLbu0WjK/YbvMPhDP6dnnekNtmwzxFJpEoyBesun8vmj?= =?us-ascii?Q?8rmRrfABU7iBIQSz3hCqpusWnarMEGLDbSeniEDfGXJ6HCT3BiLsQcPGRxta?= =?us-ascii?Q?6l6ILPa83NQLUgIEt2fJX84UEu/jLyNwuSuL8Ktcg/OLMzI21zdqOa36+BQh?= =?us-ascii?Q?rEQMrzqAUEd2xszgbMQzQjO7ZqHLD3DqvaCzPltPX4+wL18vec6fPN4Ag1Pj?= =?us-ascii?Q?dSW85W7et+4uImDzFxy29F3HyC7SSgc56o+s6LrVUF8UOq0+kIJGCw0Ihbgq?= =?us-ascii?Q?S9i/3kx2IUQWay4crLqynM1aQTyyNU49nPNcK0PJguuBD8vVWM7vrOVIx5M7?= =?us-ascii?Q?cIwFm1ZeFlksQMzOhGOlDt2HrxayaInF3c1y6TRl9m4mFBWisJGGNuGpxuXU?= =?us-ascii?Q?QAvGI3rlS5gUFBLMi794kSHNxlpJapdBI2mQ8OBygIy5vIf8hzsK45M+dcAZ?= =?us-ascii?Q?Ul0kbettZ1NE5ALoHt6HuGvOjl6frVPZk4HbLno+a1//CIf0yC/Wl+cxgENP?= =?us-ascii?Q?VUaPzC9OwQu3vESY+buVoTwLU2FkxgmD+HI4SdQY0SnnpK8dxf7SLItwPcLa?= =?us-ascii?Q?TRXNJJCFmuHx0rXgpNlp7VMKKZ/xNn4YevyuKtK9xqjtkezk9VkVbHhNr79j?= =?us-ascii?Q?3q/pOy8gOA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a2dc7df-1899-47f5-88f9-08dee63b5b25 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2026 08:46:14.1673 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GsdcqOBwOZmZ+QbBh5deHiylG/aErSAEBYrAHybj1ZOL8IK1AzfF5dMDMi5UEwIQoaGFQwqzWbqOz99g7mPWDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6044 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Reviewed-by: Even Xu --- drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 5 +---- drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c b/driv= ers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c index 46d3e9a01999..59f500345acb 100644 --- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c @@ -682,11 +682,8 @@ static int quicki2c_probe(struct pci_dev *pdev, const = struct pci_device_id *id) quicki2c_irq_thread_handler, IRQF_ONESHOT, KBUILD_MODNAME, qcdev); - if (ret) { - dev_err_once(&pdev->dev, - "Failed to request threaded IRQ, irq =3D %d.\n", pdev->irq); + if (ret) goto dev_deinit; - } =20 ret =3D quicki2c_get_device_descriptor(qcdev); if (ret) { diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c b/driv= ers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c index 4ae2e1718b30..504ef3c842ab 100644 --- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c @@ -636,11 +636,8 @@ static int quickspi_probe(struct pci_dev *pdev, quickspi_irq_thread_handler, IRQF_ONESHOT, KBUILD_MODNAME, qsdev); - if (ret) { - dev_err(&pdev->dev, - "Failed to request threaded IRQ, irq =3D %d.\n", pdev->irq); + if (ret) goto dev_deinit; - } =20 ret =3D reset_tic(qsdev); if (ret) { --=20 2.34.1