From nobody Sat Jul 25 03:03:45 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B6AA3B3C03 for ; Mon, 20 Jul 2026 08:08:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784534902; cv=none; b=LboUjhuOGVjCOOnibo1yrC8KYN7YIxjFhCrhKwedMcacTarVdNls0TmzdS/N40NdTw6sjjcho02JmTqrI4uiX0i/EqZ0sgnvy1ncBIhKJ5sPeTpF6JiWgBoEbhQQ8WcBqR7yZMSnHChHWZ5Mg2ei2PADPCRcXFkxgRAgN4fv2ts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784534902; c=relaxed/simple; bh=rFESBZS8oBmN4KtDEnetLPMoMiqN5IoQHsJGinzOPDs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=g21jMjxWMixnA9LwkdFfQ4DNqHxFzkMjfmkkbYhIXHqaGjdEWT4IH72pTIEyB276+VnqYg+SwSpksoEizG1gUyxbgWVeyPPCxfFngTBnUN1Whiba9UjZPCdndur7ptV0IrtkLqRu85mcg3aHtEJRpZPQher6m/T480HMarPBCUM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=phdyIkX3; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="phdyIkX3" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-49556f97a9dso7129745e9.1 for ; Mon, 20 Jul 2026 01:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784534898; x=1785139698; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=glqO23LkKusi1AVKCVzG0fh87YP7xeFRRIHwWTTcU78=; b=phdyIkX3SxaVTdSMhY9b4a+w0+ABiFc38mBXVxMnXEPRmWWia62bGrNbrZ3iMkfVrT HxL9ttWYfoI98Oxa63xOcKjJRXj9ZynKPexdPLv7BrlhG7bAF6aWCdOKU4GkUswMpH/T 8BLdWUXvHxwKdHWGRVhRkqTP6W2q+Igy9US65M3o9hh1AHmRFaObzsX0giqvgHLR0GGR 7Rw873LiPicHOCzpqQHcH58mN2AoZrQL1bXLo8OiVZqZv4MHPcrr1LKXucetMMKK4ISf JuqnI/qjpkAKUB6UY2msalW2RD7PC8b9M2U73kE/LpUAdoPFM7p7mU7Zq9vqNo+OKa9g EOKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784534898; x=1785139698; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=glqO23LkKusi1AVKCVzG0fh87YP7xeFRRIHwWTTcU78=; b=fLIjjGYDBEY7Ybm0oDHxkkF1eYuQFiBGUjSql3btIaQ1cNXFc6cC/pIyktYkDM6zmm WXSRfUoGrCz9OEqtC7z116uneHlRfiNDGZal/KsZoLMaQ4aB30eDeAYOTauaZ2w3Lhzj mAprt8VL+9EzDVytTvRrjDnXu5RyqWkn+0Gb7dShsF49g7h0wLyP3xZotN1Us5V6BuaV q8YE73pLG2JpmQvfrzG0EE5Tjw+yABYj7dE/T1RkxlwLXyZ9Ym84ParFh0MaDaY5Boey G3YA9dYAOALUrOxjdc6LQ1PeFlqzj9Ec1ufiPHSfNyTeYD1Cic4t1FourZX0skJwrkYW PnRg== X-Gm-Message-State: AOJu0YzS+xSuUdDgWs4OQM7sHGX0gkNQEEzKEMkxkb8N2pXq597/6uf+ x9BU5iglZm7YX9yU4nsEVbm5/+rIiTwH+cGarh6lqsm300IwwPcUKYdUmqNvKiIFsWI= X-Gm-Gg: AfdE7cno2SbHPpD+zFOvrPUwgSBtNEnMQSnAFHB2Zmw2BvaxkDh9UuIb87SLohV1xB7 onEIURqU+ryUwuynvKQhbpJOKFqhRnEj8fOHoxykBsXfOnqbNI9Qr5KVHnEnwCtL/4lrSrUmo/X 2tMqrZSz5jn2hSjwvFPp+6j65tDeYCkNhqUa+LWO3O7UkgYESo4haMPbdJPZ29dxXCEvgm6foDv oZQt8j2h/Klq7wsDR4LN9ckSDSdDRvxm0bDaPWtAEFeIkUvR7xs5K71KP/TfbKoleHZuGWkVdOH QKLozqh1LDHN8hkvRYQLBL+FcHrG8LI3BHiSEgTJ0tpMSHakD5npN5Gv9Tsai09udditROewqls lKmJ4BVmwP5muWr8YIOiCluZh94ekCyi0E5knazXrYim957avy63Z/4rWwkFB8xSRZKTT5UGCC+ 2qxzHM0vMiAc6hL7ybePo2uZ1FmO5K6l8tv6uOyibyE4If+dyz797g+H9aFqIzuSNrmw== X-Received: by 2002:a05:600c:1906:b0:495:58fc:ec0e with SMTP id 5b1f17b1804b1-49558fcf831mr60436695e9.23.1784534898382; Mon, 20 Jul 2026 01:08:18 -0700 (PDT) Received: from localhost (p200300f65f47db048587886ecb5b26b2.dip0.t-ipconnect.de. [2003:f6:5f47:db04:8587:886e:cb5b:26b2]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4954a2edbe4sm281923235e9.12.2026.07.20.01.08.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 01:08:17 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Hugo Villeneuve Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH] serial: 8250_hub6: Fix double definition for hub6_match_port() Date: Mon, 20 Jul 2026 10:08:12 +0200 Message-ID: <20260720080812.1223096-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.55.0.11.g153666a7d9bb Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1359; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=rFESBZS8oBmN4KtDEnetLPMoMiqN5IoQHsJGinzOPDs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqXdds5bsGFYbJtaRlsFDhXY48HyxIPtvAHRR7s Ix39RESGTCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCal3XbAAKCRCPgPtYfRL+ TqXfCACi1799LIO2MZHO4ArEYpeM/4zZJwTZXyCEPQpNBq2jIcM/l4EcISZVbJ+VgXnV/BW3Zck h01rbtzSbxoHKyQ5mpOCp0X3P0O6jR0MUEWukPh0gIt9p/3QUJ54HJmmZucXV1y0t0h8D2dtr39 bzeIM+WhhH92ea4zLR1XNwZoTxnDuy/0NyE+hMnuOtUwYSCO6LiI0o6ZfwxEmbTkCeAbQU+MYo5 5icVKNJBq42Skemaaiiudyp7RXgbi2VogKl93o/HE7o7OYYgkJVdy8FEVuPbCnJMDc0mu9JMxoq j/X4Z1DNLwezX8s0w9V3X2EKuVHNkWUASb7HF8BPYLTqcSQx X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable With CONFIG_SERIAL_8250_HUB6 configured as module (CONFIG_SERIAL_8250_HUB6=3Dm) the cpp symbol CONFIG_SERIAL_8250_HUB6 isn't defined (only CONFIG_SERIAL_8250_HUB6_MODULE is). In this case hub6_match_port() is defined in drivers/tty/serial/8250/8250.h as static inline and in drivers/tty/serial/8250/8250_hub6.c as normal function. Use IS_ENABLED() to also handle the modular case correctly. Fixes: 3d406299d882 ("serial: 8250_hub6: add hub6_match_port()") Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- drivers/tty/serial/8250/8250.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h index 9d1068d0489d..fb9a7117d145 100644 --- a/drivers/tty/serial/8250/8250.h +++ b/drivers/tty/serial/8250/8250.h @@ -334,7 +334,7 @@ int fintek_8250_probe(struct uart_8250_port *uart); static inline int fintek_8250_probe(struct uart_8250_port *uart) { return = 0; } #endif =20 -#ifdef CONFIG_SERIAL_8250_HUB6 +#if IS_ENABLED(CONFIG_SERIAL_8250_HUB6) bool hub6_match_port(const struct uart_port *port1, const struct uart_port= *port2); #else static inline bool hub6_match_port(const struct uart_port *port1, const st= ruct uart_port *port2) base-commit: 0718283ab28bc3907e10b61a6b4be6fefa1cbb2f --=20 2.55.0.11.g153666a7d9bb