From nobody Sat Jul 25 02:57:28 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8B773C4154 for ; Mon, 20 Jul 2026 07:41:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533273; cv=none; b=Io6/3MlaTktEFNZnkwFdSrmOTiaFuJz3sZeWYo8BSjiNy4QzP+gyxyRT+BNe7bVsTmR6r8TG2SalgDQ006BpmSuae/16JPe0Bsf+9Cy6QMiARNRxYyLrsEN6dVTCFhkgyvqqXbmQh0HaJzuWyspWRhc03B1x8aGRFjU9relfuBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533273; c=relaxed/simple; bh=u88Le1fV0hlOGZ81Qp53coKrtVP9bOQJkZkhQ+nRmbM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N3/FRGrZx5VzAO/pepluJwijq0gPy7k1pJBevnRnv+O9zRTaBXg69ciXUAoWW7Wun5/Al26tM4VGDFSz2hY3144Awgm4U4Ce0IprW9lxj4egxaMRsgU4nTH81YsVbJbtCrb4WUnlI6bhU6zqxbyCSaES3BujSTKynTWf35KksfM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kxv7zBoR; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kxv7zBoR" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38dd55ad76cso2563644a91.1 for ; Mon, 20 Jul 2026 00:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784533272; x=1785138072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=scpaRJrlW34d2i0T3LPzlbqHWj1iPSwqpLVD8tv+N3k=; b=kxv7zBoR7+Ghvd6kBVkeLk98iml4R872qxdY+UpoHurMnNk7rtvenZ9YRFLXZj9QY5 ZbKTQyKQu7F96wh+RrUmG2Lre3e07CzrABZ1APEsOe3KF0Q8k3havYeA+CzgV7hAqe5A 9CewQKSoTkJ+DY1XQr5YT/yiEmz/psiCS2VBKKYTwkzi7/9U5oUcWJyaoCABjowepO/p VPryEJ3zfN9UOPiRjyH5hqeFultpB7tYvC9lNX/FqCj2t3wb683uKn7RI5Uuflf2bKhQ qCBZibxpM/9/lMSG9bFqMuoPUPYI9YnPRLNP9UwwZHmwEf847Ranxx1XAOAN42HK7PjF v41w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784533272; x=1785138072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=scpaRJrlW34d2i0T3LPzlbqHWj1iPSwqpLVD8tv+N3k=; b=SkCrtRR3bCMy/h3sWvVSyTL3EgKtaShGZfcnPohlugyjw3Gw3O0V2oJ1AB/vedrHsF Inkj+Dkvm065rS2P7HTKTFl7q9utM4R4k48qlzEx/PZv39aEHguLPItMX1yjUmbvmFfs CK7Ej+9jVAMwW3+7CtAmRv5rAhS9U3hgaoTtIRu4hf5VcjisZpkh/IXDnyJkqlecujT1 bp0APnmvrQElh9JtMrtYcMPbjFFmsLo4TKwJCLK4/gERg2y+Xg+ke7gfkCga+A8ksYpp 0hR3hOsgx+fb9zq71OGpMwH+jGMerjVQMYLLmscdgOLz7T7CgiqdnqrysTWgQQZ0luee nMVw== X-Forwarded-Encrypted: i=1; AHgh+RqOjFmqlk4BhKOeyQk+vy5yTnOTvc7pEK7muCC/+p0R0emN6FNjsyUO7OdO4bclj8LcK7HiymvEw1lR6Vo=@vger.kernel.org X-Gm-Message-State: AOJu0YxKvRLcfwgTrCKOdd/jO/VMX6ikqP5Xe1yjFUVJAo1i+AJ9tIH2 31FESloBA3RAjUaXbQXImZz4fAT8SV0MMISdCJ2qWy2T47obgb44ToCH X-Gm-Gg: AfdE7ckMEWAe8xJhCuclxakFjMupvzhYZCOq0bqxEClJ7O7jZUk3wrVADvBK4CTFSZL zmIp3bYhlXjUv9ffbPOkB8QcLO8oT4GOojkQZTejFrFbVZw9PSs81YanTpvoImcHwXTmdmLWAZh 5babA6MStbGHVE7PEBX5AiU8sIEv007fQCnUTNOB+g5EByQ6n73c83H2A2/f8GkiGubnyWnIo3R 7dER6YQhL8x5LLgEemAEkDZ0JcXAroGWvvI5RHfPBOR/DRBzQjgbUGqXODdi++FFrDDxbb4aEen Q9Kk+zJsyPce3iGCyQ3I/mXXdahYU1XMApmIS4S0OY5H7m5q0B95R/Q43tt6hObNzTjLqcFW49G RYSLvKbr3GyC6NgfCjQCtsDf8ErdIHeYxMczhs46RPpUSXyFjj2MZxT4MF0MDH4ZtmKmU2ZmTxC MufvVEq9HMRi+yYR1g5eXTrNeR9sjXOXzcmV86 X-Received: by 2002:a17:90b:1d48:b0:37f:9e21:91d6 with SMTP id 98e67ed59e1d1-38e4b610362mr11098900a91.13.1784533271902; Mon, 20 Jul 2026 00:41:11 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e60cc2ad5sm470171a91.4.2026.07.20.00.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 00:41:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue Cc: linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 1/4] ASoC: stm: stm32_adfsdm: Drop redundant error message Date: Mon, 20 Jul 2026 14:40:40 +0700 Message-ID: <20260720074044.87528-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720074044.87528-1-phucduc.bui@gmail.com> References: <20260720074044.87528-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc devm_snd_soc_register_component() already logs the failure internally. Drop the redundant error message and return the original error directly. Signed-off-by: bui duc phuc --- sound/soc/stm/stm32_adfsdm.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/soc/stm/stm32_adfsdm.c b/sound/soc/stm/stm32_adfsdm.c index 66efb9a0acb9..73c6460a6327 100644 --- a/sound/soc/stm/stm32_adfsdm.c +++ b/sound/soc/stm/stm32_adfsdm.c @@ -360,11 +360,8 @@ static int stm32_adfsdm_probe(struct platform_device *= pdev) ret =3D devm_snd_soc_register_component(&pdev->dev, &stm32_adfsdm_soc_platform, NULL, 0); - if (ret < 0) { - dev_err(&pdev->dev, "%s: Failed to register PCM platform\n", - __func__); + if (ret < 0) return ret; - } =20 pm_runtime_enable(&pdev->dev); =20 --=20 2.43.0 From nobody Sat Jul 25 02:57:28 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4DDE3C4154 for ; Mon, 20 Jul 2026 07:41:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533278; cv=none; b=I2ClTiOZjGFA9l8fL7XyvANPqTGsUSJzWqVclO7hC+Q4b5jbE6SXtPKU7M76drjLoRzvNvQbxVolpIj5e6i0T/PVBXhP4o+PlcleUEU+4r7OMb855Qu1Y3CxN00ajepkjZb9b1k+T3C3R5kV0Kpoi8ayAzBCnnwqMkYjYeQlp88= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533278; c=relaxed/simple; bh=P1BWBCuSMBkPDa2NFAGSAPxJ5vbk5UKLN1ndBku1mkg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r9j44gQHiBSJBZAYDGOA9PUKx0sgle9xf+4zsFlvW26kyPu5rqt/7rghY2Eo2qwSWkIg9Q8/yQ4183AdAe7tTSNnhK+P8jP7rmIanljf40suLJJk1U4pRkahDTIRBsNWK5GkF8urLiebLVBcS4n0J1eLYCTVRmNJqRsJJxAsgco= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O9YnZYyR; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O9YnZYyR" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-385ea3ce80dso9811936a91.2 for ; Mon, 20 Jul 2026 00:41:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784533276; x=1785138076; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QGaNvrdWrI81wJxxoSDN2zk2fUww4x2xHVeZ5hAGgN8=; b=O9YnZYyRXRUChOi7WWYT15R1/zG6Ga87DpXMUqSx0T//ouOVcZnoxwQ21kaT9sjEge 5hsFW1XJxSxqNRn1RYicgAFSi4vYB2UMIZSlcWmjN/Kk+cfVDA3njzSu/fMhWHsFYtZg cd6GCrNjmSfipIn1+JnwXWniHm+LEREXSnBO++zemBo3YmwuRCnj8axKuv54sXQ+DZd6 hQS+foYmB9UY6mW6hWH9QJJPbbDlLkH09AWyJ5XhcDKOP3RXqXin2JaAc/UHRFClmW1t QPQTJ2yyemQy2kgmcshYtC6kO16tfg5JdqJM84URNNVE5a+2DYiaOIZpQr//zQ2NJ+3t 5GHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784533276; x=1785138076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QGaNvrdWrI81wJxxoSDN2zk2fUww4x2xHVeZ5hAGgN8=; b=A+sEZO6T80d43rwVjE5nTBHwpyqOxqG3Hy+hPznJUTZ3IkATDRDdup9tyqbu6HBwH5 0Yaz8Fckq9Iz9uReKDvM4ACh44CTFatEBIRKTz0wcL0yO80T9zLNaANRUpND7bNIkWci woKc8Gy/6AUvK6NmAWGcCE+K6BgWrGZI1uyXuPcLLP7KocIYpy+1oa/CVlpOLbOb9oGV nJYkC4cPMRW3PJzXDKBv+Q/YAxa/gK8m5QHQ/aXd7IfYHTJ1MMobVKFXjQM1HcFGh+01 K9XGtXa5lfvAv50LtfRNHJ5DuY3TFJwGjvmOaCONF45ZDEU8qjRCowkaXuTTWYMjhqYx K+tg== X-Forwarded-Encrypted: i=1; AHgh+RrLBIcycGbq717o2R2Gi+0NrPheOIzTIg/36QmouGfAxZwHwzvL3tMHELDQ4NPfk3VwAwI558RHtsWMrck=@vger.kernel.org X-Gm-Message-State: AOJu0YxTVldnhGLxa5ruxAJR/JtzqRAzp7AkRUKRzQ4V9EnzJGFnDIf4 eOztpxTK0LWeD+92NfEbJaVB2v1y4q+HnOJt1brbCoOqKo4JnTvejwos X-Gm-Gg: AfdE7clhtU3UC35cat4O3eFT+2sbts43Lvvr1bDuSw/UbN9eha6fPb29M16gNjUagS+ FxLwNiHT5oOwnBeSSVddB3eW5Aws30onMXieYOf8t4/+FuVMrH3MOJpseCw3C5oXesUdQHovA+k V9Cvn0aHtmFG1EavV6vS+jT+lY3NwU8IW+gU/i9wNeIAOHtXflIJSV8BsEZkcbHU89C5k0dkgo+ dqVcfrrMjs1MIz9V31vcwrbozzXYwAsU47pHL0X73SsFB25FROmPbLqVZ/eBh09DxvnauDnX1PG RTrXl2XJ3voZvYcEIDUB4flbyfSR17v3zd4rDrH2Yh5LSXIYQjJLXafGvpjn+CAweegy+fIwTKb +L17HE4Z/iaE5sNCQlZY1LYeUVPi5KtJ1s2TsYkmH5jSBOeKe3j/6tOBkOK73/L/epEotDuzdMN kC7kYDQjdHpZ2+Bx3y4L+Mxy911J37Vjjxi6T+ X-Received: by 2002:a17:90b:52c4:b0:381:85c0:1d88 with SMTP id 98e67ed59e1d1-38e4b417454mr14266360a91.9.1784533276029; Mon, 20 Jul 2026 00:41:16 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e60cc2ad5sm470171a91.4.2026.07.20.00.41.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 00:41:15 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue Cc: linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 2/4] ASoC: stm: stm32_i2s: Drop redundant error messages Date: Mon, 20 Jul 2026 14:40:41 +0700 Message-ID: <20260720074044.87528-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720074044.87528-1-phucduc.bui@gmail.com> References: <20260720074044.87528-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Both devm_request_irq() and snd_dmaengine_pcm_register() already log failures internally. Drop the redundant error messages and return the original errors directly. Signed-off-by: bui duc phuc --- sound/soc/stm/stm32_i2s.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/stm/stm32_i2s.c b/sound/soc/stm/stm32_i2s.c index ae9e25657f3f..83b51893b37c 100644 --- a/sound/soc/stm/stm32_i2s.c +++ b/sound/soc/stm/stm32_i2s.c @@ -1238,10 +1238,8 @@ static int stm32_i2s_parse_dt(struct platform_device= *pdev, =20 ret =3D devm_request_irq(&pdev->dev, irq, stm32_i2s_isr, 0, dev_name(&pdev->dev), i2s); - if (ret) { - dev_err(&pdev->dev, "irq request returned %d\n", ret); + if (ret) return ret; - } =20 /* Reset */ rst =3D devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); @@ -1295,7 +1293,7 @@ static int stm32_i2s_probe(struct platform_device *pd= ev) =20 ret =3D snd_dmaengine_pcm_register(&pdev->dev, &stm32_i2s_pcm_config, 0); if (ret) - return dev_err_probe(&pdev->dev, ret, "PCM DMA register error\n"); + return ret; =20 ret =3D snd_soc_register_component(&pdev->dev, &stm32_i2s_component, i2s->dai_drv, 1); --=20 2.43.0 From nobody Sat Jul 25 02:57:28 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD7863C76BC for ; Mon, 20 Jul 2026 07:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533282; cv=none; b=fJHdOt0g/jEMQpokNiyMyDSkk+q7o5AoaqV9ckRdTqGF2jdb98FWHpqHcEcdHp6RxBvP4VH+atLf9iuFjYP4zKo3wFuRZY+4QlCm+bnXCXWSgEjplpNP+E9b6EQ6zc3G9kd2aNFWgu2Gw4FrHsB2fRs1jd1VbSkXPdP50RIKySw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533282; c=relaxed/simple; bh=uU/o0TswUq/66Qz0zFVbdmHPyge1I5a2IDbU3kIpFK0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=td4yqam0G6q8IWc+nHBcmbVCLkrgfY7XnRaiG5VtCSvZ6BRnzvQD3/iu9c55Llo/v01DtMLcjT0XHQykPQXQzFCmJBzs7DwKFGbUHq9McdiLzEBQ8oyUi9xORDoANFZszSwPKK3rxtGWz2Mpzbk/xILriO8cCM6K8cHhUgvSV0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P9JPF3rW; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P9JPF3rW" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38759bcd877so8433479a91.2 for ; Mon, 20 Jul 2026 00:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784533280; x=1785138080; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PAdxUjfA4mlAH5vwcdO3zwF53s9GTPaw5wLgiyMnbFI=; b=P9JPF3rWh5EzEdDwRumFPPc4WxCCYscoHctnnNHHcnESXeOoiO6nZckQsjUH6hz1wx 2MXXKPzDHuYMyPPrfJKZhdmMc94Zs2yokjdyK1LaAY3d95ggEE2GkFj+IE+V2ugF+ajG ZbaewrnpfUWdW6fwg4vXw4JnIx2PGbC2WyDSDKCTQj99Z3+j813m/5UdmD+6TZvmJc3t LB3MDa4IpdETp+wgVHihWHq4M7USLuajE2allu8MWez200t3CjDYlMSbZ1ziVOX/9IjT WCgFw+X92dYVSURk6dbvObA51gLlRBcpiHJbfJVtYmmrRoySUYItToC0NFEptky+Ip4/ GbMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784533280; x=1785138080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PAdxUjfA4mlAH5vwcdO3zwF53s9GTPaw5wLgiyMnbFI=; b=Cm/evI03tTl2ex1GqZC+XsuHoD5azCEQD6qmgcSKkVlGCQU7487aQi3n3TFR/nahG8 72v+G1om3dQglzlhDrl16X9i7UxiTC6DPU1wspsltzVdqIQ7uSUKBseEuYllqEkROksy YQQnsoxdhp+njSow13lI6IAY6y2zUaHw2nuU8TkGHvFr3RGdkb6+KSF/eX3t5iLlamKP EIh65sX6OZrX8eioSr30qBlkJJk1DNs2S6kvs88gt4BRsjlwuZXeqg039/1fqTaVhQ5T j3+/TwBiVaJJ3UGIR+vJXKT1ta1Js+S2O3rNYJu7Osm7CLdjgSriravRL6X4cyZZ5+Yv 9J1Q== X-Forwarded-Encrypted: i=1; AHgh+RpeVQphewyTUqjF8gdmAFvylmRseCrkbl7jMAh5Ol8MHY7sCZJQWtlU55kdUxMNqyV1aKqq3Y+z3O6EAbk=@vger.kernel.org X-Gm-Message-State: AOJu0YxRkkbWodL4ZtW5aleEqiP7QZzbCWP/EssJQzn2Tx/uM8Q6oHnx 9NggPFflsRFUDebnlvkMUc+dkBUB2ts/ecIrG8kPqiSqxPTdQb/iDmjq X-Gm-Gg: AfdE7cniVlHRtur6XwR9Otj81Quz/g4aFVckqWKdX9DjY30d0FNLkC885AeZjLiwHDb yAFlcb6safNBr7IipPIBO+hINLlXyI9z+UVuy0+i9vtiOaBk8+iWOjBrPk2qOWJVqcrn0mZ7Xh9 Cne+mK9eBAP9rJeIyqpUiXuvQt9ANXc13uMDBw9qmji9wE6QPFiyIL5R4WnMf4zQTew0Ehqbeft qXqi82LR+9iXxyRfXzXav3ThLj0DBiY0VX54rPByO7xdXAA9XAvFqd7gV3+Mwmxf4S4HhlyrgU8 qK3Wax8UwvB06m9Ynk/mNOHyoogrvtAn+yO3bK/p4kjR9eFB0XVAMQG70sWC+NmUlrJhVYEyfBB yTqSleN4E0OxRgGVpshqwW1H7ZkpAW2l+qT3gT0MHElqQ+RtYJoBI21iSHxlup0VjCGuMmjdPvu U2Ew+eQxgov1ITLzsPRFrardSFkuLSoAaTCh6I3OuX9YfJ90M= X-Received: by 2002:a17:90b:4d01:b0:37f:f8c5:93c2 with SMTP id 98e67ed59e1d1-38e4b56d65cmr13606083a91.21.1784533280225; Mon, 20 Jul 2026 00:41:20 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e60cc2ad5sm470171a91.4.2026.07.20.00.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 00:41:19 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue Cc: linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 3/4] ASoC: stm: stm32_sai_sub: Drop redundant error messages Date: Mon, 20 Jul 2026 14:40:42 +0700 Message-ID: <20260720074044.87528-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720074044.87528-1-phucduc.bui@gmail.com> References: <20260720074044.87528-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Both devm_request_irq() and snd_dmaengine_pcm_register() already log failures internally. Drop the redundant error messages and return the original errors directly. Signed-off-by: bui duc phuc --- sound/soc/stm/stm32_sai_sub.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index ea9e8bddd63f..9a201bdb306f 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -1696,19 +1696,15 @@ static int stm32_sai_sub_probe(struct platform_devi= ce *pdev) =20 ret =3D devm_request_irq(&pdev->dev, sai->pdata->irq, stm32_sai_isr, IRQF_SHARED, dev_name(&pdev->dev), sai); - if (ret) { - dev_err(&pdev->dev, "IRQ request returned %d\n", ret); + if (ret) goto err_unprepare_pclk; - } =20 if (STM_SAI_PROTOCOL_IS_SPDIF(sai)) conf =3D &stm32_sai_pcm_config_spdif; =20 ret =3D snd_dmaengine_pcm_register(&pdev->dev, conf, 0); - if (ret) { - ret =3D dev_err_probe(&pdev->dev, ret, "Could not register pcm dma\n"); + if (ret) goto err_unprepare_pclk; - } =20 ret =3D snd_soc_register_component(&pdev->dev, &stm32_component, &sai->cpu_dai_drv, 1); --=20 2.43.0 From nobody Sat Jul 25 02:57:28 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C54533C7DE1 for ; Mon, 20 Jul 2026 07:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533287; cv=none; b=M7tqhqGdxWXuzprsWdIl2rLAbtPGuQvVX4A3QdOcVU1whCbVhtFtUvv5LqMOCYLsTxqmhKduLbnHyX9bLGWMgNGOnCLCUh/oB1j75Gxb8PLhvw74EEb6nqIf0uN4grpU1uTk5u5N0FVVVyNDlBSO8Ue1b8ZTbgUZTUhx4OgRFdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533287; c=relaxed/simple; bh=+vs1BDGdDM58TuXDdX1LP1xFHTn/ZKSHj4D+LcB/aA8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VkKLIAcf8y/6Z5lUELgRaM4/+IexJtTSMUQjhyDgBJCVjDeGwLbdwKgSL0SRVBw0BnOM6zuZpMV1XqMSWGJ0fkiFhn7X5avUST2vxfJF1USOFR6A5VlOPvhNmvPPyt5QYFYWXAjhQrVOGqtdB5oxNHXGqEOYZiWxkXtDnBTPF/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KgR2kzfL; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KgR2kzfL" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-384c94c9414so5382082a91.3 for ; Mon, 20 Jul 2026 00:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784533285; x=1785138085; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BxfhfVFXLPGi+jPTouqRSV9wQYObASU5W++hCoymJqs=; b=KgR2kzfLfeZ9PtV3tlECR58RnnfufgIw+jVxlaOomeXc5T8gmWtNPGu16R1yta1gah qP4+OUm6CWnNyEX/q0qYekkBcc8TCFunQVuHMMsh81mP/xgeI3J0l+E6AFFnzxfl1Qly GKNLSGCO+9MJ8vAFoRmPXSQS3Jz4gp991Sqlj2KF4yI4HC2oEOQINWKjEFANxum6+iBE PaJj0KawcIm12bcybAL8xPU4G19m+7yrRpvNFRrP10ur2geeUlSh3KoL5cox2vINP6rc AnqAr4jAcTy2/cnX/d5IMj14ZkjCKMl3KlzerwFOX4jpBAchC5/12W301Q1X7CvvBraT D+7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784533285; x=1785138085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BxfhfVFXLPGi+jPTouqRSV9wQYObASU5W++hCoymJqs=; b=EFO0Ny4+P9ZqVvWY+3ibtLywCox/YYkGtot6WdXeH90Rk8/FUr8SMtmHQUd54nfmy/ vDy60n6JdwqotjAtfFh9wHWrkRj74owyUC5iBQPO984oRlMtMfyUF5bZUpk+ciB5M9OU /4uRQjc/cj8vK4d3WvJr3nPFqBvUp60KtvlJPWxGN/adyTK9V+jsdeGWZMwRI1eyD2IU lN9jxiEya4tz46zpQzaIqhDYSZ8b8T3zexGlhUQnxiWPOSb2QBmsjJSlvyOKzLtZpCHc 9GxY0q61acJEpFQNFgFjUtNt7uBc3N1fKqNpSOjw2eWJreWwtaryFLI3TClXvDD6riYi 9W/Q== X-Forwarded-Encrypted: i=1; AHgh+Rr9X3PaPeyRFxQvdLJ3SQKpi4aecVil1sJ+ErkTcZZ7eTb4SifNhNbJiwKqhde7A37ZBvDEqlAPLkoamBU=@vger.kernel.org X-Gm-Message-State: AOJu0YwLI4bxEA4Mpus3VZFQhSKGBRjFKHkJa8CtvhAoimapPnyTnIMx hv+g3/Yoc2GLeEQvxteIzdzXM9fEMM0zJNxx/sepBAAL8drmq4qL3AWF X-Gm-Gg: AfdE7cnIXhqA0lanztvynracclM8UFHi3USSjywHVE7Ggh68K90Jc2IiMtS/wN9NVob TFbQ6VxpuFADndkZY86IF3UUhta7rJYBDuCIVp1qjC+xLPRoKf9scVsIk2Ul4UXvTmb6Tsq2yMC WriAXrniCAcRJxpmVe46kpJMnn4l+RD77zqNC1OfzJ02nyW6QCUEvCF2St2wYmPYw5VU4/n1IMp 1UVfM9gy8hNA+zSE+cjzEn2NU9uaR2FFsJbS69LGsBuJ4CQgwBwRsiRj86CEZMhl+dNm6Y3H4U4 3Bxh2TsSxjoI6KbXsux8m2ARR8VIWaJ5DrUB5R24gt3ZYSXYmSrrDratAsrq30DiIb+FGK6opjM p28AZ8q4e8DXUHiW+N0vFU1eHDSlFjZkL349tVwKzdpN45NgJKrMth9YeyoPrEkyUziAdqaXi4H mYTkykAbO3WegWdGku2rR+ZnkKTf1cczocUy+Z X-Received: by 2002:a17:90b:57ee:b0:383:f52b:d616 with SMTP id 98e67ed59e1d1-38e4b40292cmr13847602a91.10.1784533285047; Mon, 20 Jul 2026 00:41:25 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e60cc2ad5sm470171a91.4.2026.07.20.00.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 00:41:24 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue Cc: linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 4/4] ASoC: stm: stm32_spdifrx: Drop redundant error messages Date: Mon, 20 Jul 2026 14:40:43 +0700 Message-ID: <20260720074044.87528-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720074044.87528-1-phucduc.bui@gmail.com> References: <20260720074044.87528-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Both devm_request_irq() and snd_dmaengine_pcm_register() already log failures internally. Drop the redundant error messages and return the original errors directly. Signed-off-by: bui duc phuc --- sound/soc/stm/stm32_spdifrx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/stm/stm32_spdifrx.c b/sound/soc/stm/stm32_spdifrx.c index 2f83ca989e68..e0fef47a227e 100644 --- a/sound/soc/stm/stm32_spdifrx.c +++ b/sound/soc/stm/stm32_spdifrx.c @@ -970,10 +970,8 @@ static int stm32_spdifrx_probe(struct platform_device = *pdev) =20 ret =3D devm_request_irq(&pdev->dev, spdifrx->irq, stm32_spdifrx_isr, 0, dev_name(&pdev->dev), spdifrx); - if (ret) { - dev_err(&pdev->dev, "IRQ request returned %d\n", ret); + if (ret) return ret; - } =20 rst =3D devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); if (IS_ERR(rst)) @@ -987,7 +985,7 @@ static int stm32_spdifrx_probe(struct platform_device *= pdev) pcm_config =3D &stm32_spdifrx_pcm_config; ret =3D snd_dmaengine_pcm_register(&pdev->dev, pcm_config, 0); if (ret) - return dev_err_probe(&pdev->dev, ret, "PCM DMA register error\n"); + return ret; =20 ret =3D snd_soc_register_component(&pdev->dev, &stm32_spdifrx_component, --=20 2.43.0