From nobody Sat Jul 25 02:58:38 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB7143B8D50 for ; Mon, 20 Jul 2026 07:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784532169; cv=none; b=gi5i4y0M+Bw/YqY51yzJ1OYH62qIl+P8y9JxtVdrrtLWb+KItqKwj7hxhdXQgt9bojKasj4HCM7nGhgnRJfioxA4ndOilGgc0gIe+urpTR5os/8gVP+oWDEMpHdnZkpR2b3HTKpmRwRSPicQdFI6zHvZxXReIclUcWQi4EeJwD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784532169; c=relaxed/simple; bh=OOTKP4pnSAz8xHGhbXtlqxKf0IRGK3PLKQEbgiMxO9Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nEHhadxV98nYjvVQMu9/7un7Ot+M/zgdpln2zSzUUod9j+tNhMhsgrsrtFU6jQ1LbYoXmPq9l0Bd+8fDwYiVbD5fy9KqywqXrHzpfbWDKldcMGc7GItGT/tvy4uwV0RFbvcYL7WOeM+FKViQev2oq/Qt5yTUVWP0hbEKc06oqZY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dTk5rB2g; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dTk5rB2g" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c96bfabc8d4so3781976a12.3 for ; Mon, 20 Jul 2026 00:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784532165; x=1785136965; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IL4Hj7AEoE4Tzg2meurW+8WK6UP5mdpnN7tRwvqUA8A=; b=dTk5rB2gD/Ih8l1aEpFtjkX3Yf9iXQddBOAQhMIAWQJxL2clVGgdK4zLS0T0wDyhdB kvLLLSEisXudEj32hhAit6t8s1manzzLNozKKcvjaBiwtzsZWg8dq4YGrxt5A4Mj6MeL 3D9Do65nOPHk9glI+am9sgytgP7J0Os/KztQvXS/UhFigZXvwMpeY/EQa30e0Q1TyOzY ZbRJnA8hzbNT3HFMY0XCRptAmixIi6TdEXiuFCPJIGjXstuTDzaNOfNTkZIItXFxpRMR SdriiTjLJtHeU0eOfEV2HXvZKlXgDmmb9m9qM2U8T4HZmVE2L6QHev3ZsZB4M59evpBX Elrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784532165; x=1785136965; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IL4Hj7AEoE4Tzg2meurW+8WK6UP5mdpnN7tRwvqUA8A=; b=aGvKCiQB+pK/IK1TwQImyqfmUAE8Zze7kiGKY51O1OdAAOUzxyyauOsPyvYSflHaQU iCdaO72JEGgi+kMqNQ/JPAI94UbO7lRM5IHBVuuuSxN70MErYd6C9vwlYnNle3kjxrCh h36Y/WJ6JgjiNdqYr/oG5gBga0lFGz5LeHNrPjHgaIPpTMoLxu44NztggWEv8mmK4p1k loSmpRipnX7h01FpNetehXUyXMBRbBiy+SdwbCbgMLutIrZTfxNJ8ap8Cb8QDifVysKQ KnlMbO5UmVvU0zVrm+7wzxZPzgr9fYTI/Jietg6gYPL0CohfyDs/lD2XJ2S9DFbj7twH c4zQ== X-Forwarded-Encrypted: i=1; AHgh+RpyGtxcGOFw2flyXCkcpCqmNSvGb5hVesbzomQp5BDLP5xrcuxGq6V6cxhB++HCvHMvoi2etpo6QlRPnMo=@vger.kernel.org X-Gm-Message-State: AOJu0YzSAdf3Op646eV4fhaZ4eObjuYzC0OJaqwFnI6H+CbqK0Q5I39/ Mx9vbgljjbewqybEuri/84rs/R82Z3yWmhkBL0s5tcbksWs5YC+8EAx/ X-Gm-Gg: AfdE7ckywuAbwC24YTKDYWl4f1R2bLPgo6c1zTasXxah/GJrGbBzxFNOS7jfnjMj6uL v9EQ25Ae6LYMn9jhcP7eKqRkF/Bkr83NUNSI1QVTzmbNJ+CCKcsD/BwXLDsVUx0rTOnclZI0DQM w/1S3/ymIbVnNREeleLOy1+vfdM17vviVga5lJact3Vddg87zwpujTbE8TKWUJ8jIqRLlaDJgMe JcbO3z7Gd2+fSVbg8lMFMGy+Lb1SEdSwzO21BICSZvHI/flxd3Yxbljnbex3qtcHrWvSbGEX4yJ bR1a51yOsloIHgujOiW4NMEsDyvwOzReJlitXMFnRJJsbvsAT+ZKWlxdg8p8q55Rs02ZfEbUjmd bozTRngXUZ2NdnwjMy02lwMyNlmKZUrT7dmgYhkARY8Js9edqXhAu1JPuvHBnCjHPEfFQ88W50m U/gu+zCq1b99nI+i9jTQNLgFkX6Sx52aee//kOwn2oFS1oi7yuWCFxfZpSRfUIKTQIm7DuSurnQ yWX1Up0DEgH1/4QId1E8VaHy5iwmvADIlF9jKudsar5Od9JKMyxZRFwSAVngMZsNHoc2yO70rul yOTv2BtYnHOpjq0= X-Received: by 2002:a05:6a21:a8b:b0:3bf:6ac8:8d29 with SMTP id adf61e73a8af0-3c3ad7a8ed5mr14170724637.21.1784532164879; Mon, 20 Jul 2026 00:22:44 -0700 (PDT) Received: from cs-1047136853211-default.asia-southeast1-b.c.z168d0f9edf9bc766-tp.internal (43.173.126.34.bc.googleusercontent.com. [34.126.173.43]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb519de26a5sm4064176a12.22.2026.07.20.00.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 00:22:44 -0700 (PDT) From: Aditya Prakash Srivastava To: Jens Axboe , Christian Brauner , Alexander Viro Cc: Jan Kara , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Aditya Prakash Srivastava Subject: [PATCH 1/2] fs: make listxattr and removexattr helpers non-static Date: Mon, 20 Jul 2026 07:22:12 +0000 Message-ID: <20260720072213.2719-2-aditya.ansh182@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720072213.2719-1-aditya.ansh182@gmail.com> References: <20260720072213.2719-1-aditya.ansh182@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for adding IORING_OP_REMOVEXATTR, FREMOVEXATTR, LISTXATTR, and FLISTXATTR support in io_uring, we need to invoke the respective VFS-layer list/remove helpers from within io_uring. Make the following four helpers non-static and declare them in fs/internal.h: - file_listxattr() - filename_listxattr() - file_removexattr() - filename_removexattr() No functional change is introduced. Signed-off-by: Aditya Prakash Srivastava --- fs/internal.h | 7 +++++++ fs/xattr.c | 8 +++----- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/fs/internal.h b/fs/internal.h index 355d93f92208..1294424431f3 100644 --- a/fs/internal.h +++ b/fs/internal.h @@ -297,6 +297,13 @@ int filename_setxattr(int dfd, struct filename *filena= me, unsigned int lookup_flags, struct kernel_xattr_ctx *ctx); int setxattr_copy(const char __user *name, struct kernel_xattr_ctx *ctx); int import_xattr_name(struct xattr_name *kname, const char __user *name); +ssize_t file_listxattr(struct file *f, char __user *list, size_t size); +ssize_t filename_listxattr(int dfd, struct filename *filename, + unsigned int lookup_flags, + char __user *list, size_t size); +int file_removexattr(struct file *f, struct xattr_name *kname); +int filename_removexattr(int dfd, struct filename *filename, + unsigned int lookup_flags, struct xattr_name *kname); =20 int may_write_xattr(struct mnt_idmap *idmap, struct inode *inode); =20 diff --git a/fs/xattr.c b/fs/xattr.c index d58979115200..1004b1d22cc4 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -953,14 +953,12 @@ listxattr(struct dentry *d, char __user *list, size_t= size) return error; } =20 -static ssize_t file_listxattr(struct file *f, char __user *list, size_t size) { audit_file(f); return listxattr(f->f_path.dentry, list, size); } =20 -static ssize_t filename_listxattr(int dfd, struct filename *filename, unsigned int lookup_flags, char __user *list, size_t size) @@ -1036,7 +1034,7 @@ removexattr(struct mnt_idmap *idmap, struct dentry *d= , const char *name) return vfs_removexattr(idmap, d, name); } =20 -static int file_removexattr(struct file *f, struct xattr_name *kname) +int file_removexattr(struct file *f, struct xattr_name *kname) { int error =3D mnt_want_write_file(f); =20 @@ -1049,8 +1047,8 @@ static int file_removexattr(struct file *f, struct xa= ttr_name *kname) return error; } =20 -static int filename_removexattr(int dfd, struct filename *filename, - unsigned int lookup_flags, struct xattr_name *kname) +int filename_removexattr(int dfd, struct filename *filename, + unsigned int lookup_flags, struct xattr_name *kname) { struct path path; int error; --=20 2.47.3 From nobody Sat Jul 25 02:58:38 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CC6B3B8BB9 for ; Mon, 20 Jul 2026 07:22:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784532177; cv=none; b=ZAW+ZjGw7V774E7YQt6fH4HZYgLPSBSz83hP/xLJOTsnGiwDDSiNuxeXy2OnorlcsKI3IdUObqeuqslffAqXgBcWbVVfaiHNwLMWp5LArjX/h/lyC0PvyGHL0aydRNVoW0k1OHsLMsQbs9XmV4kCNL2z+MF7ggOQ7nwgV9w5V6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784532177; c=relaxed/simple; bh=B6Ck4tcZ+553hbfzb7ngKWwlSDjfayHx3mTtuH76Yvw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oXAuWICKgCyhPqgUtZmnhfDbFZQ/NLmQvXGc39z6cY4LDSLXIp+9Ut5dEflbdRTF2sl6fgV8xrf7n+V5WF5UmHfY5JlTo77mLCzDRBSIA1GHS0crzlXtizIth/V5vDoBnYqHE6p7QvGY1D6F6e+AOIxfmBF1dRYPT+3P0vAmkUQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nJBjAZVT; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nJBjAZVT" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-848743155bcso2390534b3a.0 for ; Mon, 20 Jul 2026 00:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784532172; x=1785136972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5WeY2WU1XyNykLdBTFGvVVw8jQPcGyVoj+YOIRoHbN8=; b=nJBjAZVTWADg4JKylspaLEyQb+gE+8W09WRY0Xttfs+3YxGifhIGKh2CE5EIrIltkM BBYz2NgBLhK2zbdHTK9XVQuET7CS9Y4lAs+QBmHcJ4wCdYLo/W+u9mUNaQ9b8xrhQX8z GohLj91OyzdwGxZG0yC46Msu9WdmflGcUf2kBJOAnwbw4uhIFyH+CurshbHuXEmAqxjw Y/Gygbofckeap8wrsMCVBkixSkPwcbttLQ4GEBZR0WvfX9MwEUdOzblOv4DOD/ZX5WRj Ls8Y60Ix2Io0EaCDsC6Rb2XeqBfOgWNUFDbCIhAYJ8botakOHBqHoB4WwYmBR0eZksru zB3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784532172; x=1785136972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5WeY2WU1XyNykLdBTFGvVVw8jQPcGyVoj+YOIRoHbN8=; b=VA2MWgXT9o+4GhKpqFoqhMDYAoglJxeyJv1RCwqD2WsX/AvmWGvn8TSVgX5DpJZN2f By6HBGbBgELr145v/Y3/M0uO/lYgn2kPeG5YnQk4WDwiBYyc6N5qVABm/EUAuB25GoIS lv2pKq4hRsyO/gqeFzWLIPwIfLZL4ZIjL36bD+9no8B3jgjolPboEqdiFBa1K6weR6aN a4GS+sBLMFR4RB2DyrIcTusq+jhciFs/dcgTmoSzWx5KrUmRz9Zg5GRrcqnru9mTMZeU dr3+ivDSSn7Uw3zlv8nREavCSC+RSltJMLCZcWlTysAsic0eiRNjLCIJJdyg940I8FPI yoCQ== X-Forwarded-Encrypted: i=1; AHgh+Rqlwb2HE+YKmA219cczWefits+qj4J5vpiCTTBolK3tRau6yEI8LQ762EsJ0jlzEgAsRK9WO1c3AvHxEOQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkeei4kQmaTDHeK7HkRVES4wGUMKm2W4iPcxGO4784A7nRVaV1 HFPrXgCDm3cVMCaGvrS883+K818rRpe1Jgl3+dNdBQ3Yf3qCBze8wa93 X-Gm-Gg: AfdE7cmhPyFZtbdceIq3IAJHJv/vR9CS7jkRCkxdaLKKeapK4Q3fap4qUbf1h6grW9B BV0zFr8kH4hv+zekje91AdrQvtjGxYIGyUxHu3JSrEkjtwOpFuxcwENdnEswDAwWhfJXPrjzkU3 z6AXDL/6AYH/8vwUA7iOphn+jCUBrW9KnFO3Jmsksg7JBkctkYhZak7tLoCLAVMrP6WkmO2qesX YkgcF5cmz2AFNlIm2rxxJwUI/UFO0If9LcS199d+b9yWbT6GCZIWauGU3XLtOSmpZhF5YCyB3Mp ewPX4Dl2qL5J00D3ajH34aI27TQoJGSQN8hfj58J3Oh44p90b9OC+9D5QNxvEqUk0kYV92rl7Ib lg08YuPyL3QwX2XIUEDsy2d1B8HGyEZiTlKb78K3TAB1BCcCOIsnFuEVvVKdow6j448/LjNOruy KuStQb8GkNYeBu8JU8fhaLbpeFsSoqMR0MjZ/LAd9u040j1rHPIrKUg/t+nkezjrNI3Bx7NIsHu b1kxx92AmIDMQLahjQA5Xqq8GcuHlnJcu/JxWhZbjbHOcy4jBbMxU/w9STkk6/zW5odKq30iuGj Uvi3JG4vkvuQ2Cc= X-Received: by 2002:a05:6a00:10cd:b0:845:dfef:75b8 with SMTP id d2e1a72fcca58-84c29263072mr12458423b3a.15.1784532171867; Mon, 20 Jul 2026 00:22:51 -0700 (PDT) Received: from cs-1047136853211-default.asia-southeast1-b.c.z168d0f9edf9bc766-tp.internal (43.173.126.34.bc.googleusercontent.com. [34.126.173.43]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb519de26a5sm4064176a12.22.2026.07.20.00.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 00:22:51 -0700 (PDT) From: Aditya Prakash Srivastava To: Jens Axboe , Christian Brauner , Alexander Viro Cc: Jan Kara , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Aditya Prakash Srivastava Subject: [PATCH 2/2] io_uring: add removexattr and listxattr support Date: Mon, 20 Jul 2026 07:22:13 +0000 Message-ID: <20260720072213.2719-3-aditya.ansh182@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720072213.2719-1-aditya.ansh182@gmail.com> References: <20260720072213.2719-1-aditya.ansh182@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for the following four xattr operations to complete io_uring's xattr feature parity: - IORING_OP_REMOVEXATTR - IORING_OP_FREMOVEXATTR - IORING_OP_LISTXATTR - IORING_OP_FLISTXATTR The implementation invokes the newly exported non-static VFS helpers: file_removexattr(), filename_removexattr(), file_listxattr(), and filename_listxattr(). We reuse the existing 'struct io_xattr' and 'io_xattr_cleanup()' to cleanly handle allocation/cleanup flow, with delayed filename handling, proper variable scoping, and 100% style compliance. Signed-off-by: Aditya Prakash Srivastava --- include/uapi/linux/io_uring.h | 4 + io_uring/opdef.c | 34 +++++++ io_uring/xattr.c | 151 ++++++++++++++++++++++++++++ io_uring/xattr.h | 12 +++ tools/include/uapi/linux/io_uring.h | 15 +++ 5 files changed, 216 insertions(+) diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h index 909fb7aea638..528c394b71a5 100644 --- a/include/uapi/linux/io_uring.h +++ b/include/uapi/linux/io_uring.h @@ -318,6 +318,10 @@ enum io_uring_op { IORING_OP_PIPE, IORING_OP_NOP128, IORING_OP_URING_CMD128, + IORING_OP_REMOVEXATTR, + IORING_OP_FREMOVEXATTR, + IORING_OP_LISTXATTR, + IORING_OP_FLISTXATTR, =20 /* this goes last, obviously */ IORING_OP_LAST, diff --git a/io_uring/opdef.c b/io_uring/opdef.c index 4e58eb1344ea..318f53a8a023 100644 --- a/io_uring/opdef.c +++ b/io_uring/opdef.c @@ -591,6 +591,24 @@ const struct io_issue_def io_issue_defs[] =3D { .prep =3D io_uring_cmd_prep, .issue =3D io_uring_cmd, }, + [IORING_OP_REMOVEXATTR] =3D { + .prep =3D io_removexattr_prep, + .issue =3D io_removexattr, + }, + [IORING_OP_FREMOVEXATTR] =3D { + .needs_file =3D 1, + .prep =3D io_fremovexattr_prep, + .issue =3D io_fremovexattr, + }, + [IORING_OP_LISTXATTR] =3D { + .prep =3D io_listxattr_prep, + .issue =3D io_listxattr, + }, + [IORING_OP_FLISTXATTR] =3D { + .needs_file =3D 1, + .prep =3D io_flistxattr_prep, + .issue =3D io_flistxattr, + }, }; =20 const struct io_cold_def io_cold_defs[] =3D { @@ -849,6 +867,22 @@ const struct io_cold_def io_cold_defs[] =3D { .sqe_copy =3D io_uring_cmd_sqe_copy, .cleanup =3D io_uring_cmd_cleanup, }, + [IORING_OP_REMOVEXATTR] =3D { + .name =3D "REMOVEXATTR", + .cleanup =3D io_xattr_cleanup, + }, + [IORING_OP_FREMOVEXATTR] =3D { + .name =3D "FREMOVEXATTR", + .cleanup =3D io_xattr_cleanup, + }, + [IORING_OP_LISTXATTR] =3D { + .name =3D "LISTXATTR", + .cleanup =3D io_xattr_cleanup, + }, + [IORING_OP_FLISTXATTR] =3D { + .name =3D "FLISTXATTR", + .cleanup =3D io_xattr_cleanup, + }, }; =20 const char *io_uring_get_opcode(u8 opcode) diff --git a/io_uring/xattr.c b/io_uring/xattr.c index 5303df3f247f..614996455ce9 100644 --- a/io_uring/xattr.c +++ b/io_uring/xattr.c @@ -195,3 +195,154 @@ int io_setxattr(struct io_kiocb *req, unsigned int is= sue_flags) io_xattr_finish(req, ret); return IOU_COMPLETE; } + +static int __io_removexattr_prep(struct io_kiocb *req, + const struct io_uring_sqe *sqe) +{ + struct io_xattr *ix =3D io_kiocb_to_cmd(req, struct io_xattr); + const char __user *name; + int ret; + + INIT_DELAYED_FILENAME(&ix->filename); + name =3D u64_to_user_ptr(READ_ONCE(sqe->addr)); + + if (READ_ONCE(sqe->addr2) || READ_ONCE(sqe->len) || READ_ONCE(sqe->xattr_= flags)) + return -EINVAL; + + ix->ctx.kname =3D kmalloc_obj(*ix->ctx.kname); + if (!ix->ctx.kname) + return -ENOMEM; + + ret =3D import_xattr_name(ix->ctx.kname, name); + if (ret) { + kfree(ix->ctx.kname); + return ret; + } + + req->flags |=3D REQ_F_NEED_CLEANUP; + req->flags |=3D REQ_F_FORCE_ASYNC; + return 0; +} + +int io_fremovexattr_prep(struct io_kiocb *req, const struct io_uring_sqe *= sqe) +{ + return __io_removexattr_prep(req, sqe); +} + +int io_removexattr_prep(struct io_kiocb *req, const struct io_uring_sqe *s= qe) +{ + struct io_xattr *ix =3D io_kiocb_to_cmd(req, struct io_xattr); + const char __user *path; + int ret; + + if (unlikely(req->flags & REQ_F_FIXED_FILE)) + return -EBADF; + + ret =3D __io_removexattr_prep(req, sqe); + if (ret) + return ret; + + path =3D u64_to_user_ptr(READ_ONCE(sqe->addr3)); + + return delayed_getname(&ix->filename, path); +} + +int io_fremovexattr(struct io_kiocb *req, unsigned int issue_flags) +{ + struct io_xattr *ix =3D io_kiocb_to_cmd(req, struct io_xattr); + int ret; + + WARN_ON_ONCE(issue_flags & IO_URING_F_NONBLOCK); + + ret =3D file_removexattr(req->file, ix->ctx.kname); + io_xattr_finish(req, ret); + return IOU_COMPLETE; +} + +int io_removexattr(struct io_kiocb *req, unsigned int issue_flags) +{ + struct io_xattr *ix =3D io_kiocb_to_cmd(req, struct io_xattr); + int ret; + + CLASS(filename_complete_delayed, name)(&ix->filename); + + WARN_ON_ONCE(issue_flags & IO_URING_F_NONBLOCK); + + ret =3D filename_removexattr(AT_FDCWD, name, LOOKUP_FOLLOW, ix->ctx.kname= ); + io_xattr_finish(req, ret); + return IOU_COMPLETE; +} + +static int __io_listxattr_prep(struct io_kiocb *req, + const struct io_uring_sqe *sqe) +{ + struct io_xattr *ix =3D io_kiocb_to_cmd(req, struct io_xattr); + + INIT_DELAYED_FILENAME(&ix->filename); + ix->ctx.kname =3D NULL; + ix->ctx.kvalue =3D NULL; + + if (READ_ONCE(sqe->addr)) + return -EINVAL; + + ix->ctx.value =3D u64_to_user_ptr(READ_ONCE(sqe->addr2)); + ix->ctx.size =3D READ_ONCE(sqe->len); + ix->ctx.flags =3D READ_ONCE(sqe->xattr_flags); + + if (ix->ctx.flags) + return -EINVAL; + + req->flags |=3D REQ_F_NEED_CLEANUP; + req->flags |=3D REQ_F_FORCE_ASYNC; + return 0; +} + +int io_flistxattr_prep(struct io_kiocb *req, const struct io_uring_sqe *sq= e) +{ + return __io_listxattr_prep(req, sqe); +} + +int io_listxattr_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) +{ + struct io_xattr *ix =3D io_kiocb_to_cmd(req, struct io_xattr); + const char __user *path; + int ret; + + if (unlikely(req->flags & REQ_F_FIXED_FILE)) + return -EBADF; + + ret =3D __io_listxattr_prep(req, sqe); + if (ret) + return ret; + + path =3D u64_to_user_ptr(READ_ONCE(sqe->addr3)); + + return delayed_getname(&ix->filename, path); +} + +int io_flistxattr(struct io_kiocb *req, unsigned int issue_flags) +{ + struct io_xattr *ix =3D io_kiocb_to_cmd(req, struct io_xattr); + int ret; + + WARN_ON_ONCE(issue_flags & IO_URING_F_NONBLOCK); + + ret =3D file_listxattr(req->file, ix->ctx.value, ix->ctx.size); + io_xattr_finish(req, ret); + return IOU_COMPLETE; +} + +int io_listxattr(struct io_kiocb *req, unsigned int issue_flags) +{ + struct io_xattr *ix =3D io_kiocb_to_cmd(req, struct io_xattr); + int ret; + + CLASS(filename_complete_delayed, name)(&ix->filename); + + WARN_ON_ONCE(issue_flags & IO_URING_F_NONBLOCK); + + ret =3D filename_listxattr(AT_FDCWD, name, LOOKUP_FOLLOW, + ix->ctx.value, ix->ctx.size); + io_xattr_finish(req, ret); + return IOU_COMPLETE; +} diff --git a/io_uring/xattr.h b/io_uring/xattr.h index 9b459d2ae90c..c3845d00fecc 100644 --- a/io_uring/xattr.h +++ b/io_uring/xattr.h @@ -13,3 +13,15 @@ int io_fgetxattr(struct io_kiocb *req, unsigned int issu= e_flags); =20 int io_getxattr_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe); int io_getxattr(struct io_kiocb *req, unsigned int issue_flags); + +int io_fremovexattr_prep(struct io_kiocb *req, const struct io_uring_sqe *= sqe); +int io_fremovexattr(struct io_kiocb *req, unsigned int issue_flags); + +int io_removexattr_prep(struct io_kiocb *req, const struct io_uring_sqe *s= qe); +int io_removexattr(struct io_kiocb *req, unsigned int issue_flags); + +int io_flistxattr_prep(struct io_kiocb *req, const struct io_uring_sqe *sq= e); +int io_flistxattr(struct io_kiocb *req, unsigned int issue_flags); + +int io_listxattr_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe= ); +int io_listxattr(struct io_kiocb *req, unsigned int issue_flags); diff --git a/tools/include/uapi/linux/io_uring.h b/tools/include/uapi/linux= /io_uring.h index f1c16f817742..7b083c1b14d2 100644 --- a/tools/include/uapi/linux/io_uring.h +++ b/tools/include/uapi/linux/io_uring.h @@ -253,6 +253,21 @@ enum io_uring_op { IORING_OP_FUTEX_WAIT, IORING_OP_FUTEX_WAKE, IORING_OP_FUTEX_WAITV, + IORING_OP_FIXED_FD_INSTALL, + IORING_OP_FTRUNCATE, + IORING_OP_BIND, + IORING_OP_LISTEN, + IORING_OP_RECV_ZC, + IORING_OP_EPOLL_WAIT, + IORING_OP_READV_FIXED, + IORING_OP_WRITEV_FIXED, + IORING_OP_PIPE, + IORING_OP_NOP128, + IORING_OP_URING_CMD128, + IORING_OP_REMOVEXATTR, + IORING_OP_FREMOVEXATTR, + IORING_OP_LISTXATTR, + IORING_OP_FLISTXATTR, =20 /* this goes last, obviously */ IORING_OP_LAST, --=20 2.47.3