From nobody Sat Jul 25 03:04:03 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D985E2E1EE0; Mon, 20 Jul 2026 06:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784529386; cv=none; b=GcccKM6860yGI8Q8r64Oa8ry8AdmKC+DtzE+7vx/H3CWEYr4h7Pu7Hx59hGwEZsOlA7wFUqAD1ESfsbyPbDku1IUZ0y6YhPnhmmlq8vNbHRbXQ64RgUGD8y/FJEuTVSsxdvO23nHHPoXe7b7s1jgcTYnkOV1kwfrgu0muQJUT4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784529386; c=relaxed/simple; bh=LlUJW5gnhWRkR/8AjLmw2WSjTYywnYDK7zbnKJW3eXw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ma27j0ttKEtSBk75mhkLog/bwBHScabkkDpwouj8SQ1zTjfCSMfoD+kS78CcCorRPGohx51qnC1wn5kVBaGRannJe87kcDz+qIcT6lOcLG+rl+8lOSkVOSJypqw34gckRUcZYqv5lcSEJxvnLQAlwGIUgnudG3hcSTlBL7vpmTY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 205018d2840511f1aa26b74ffac11d73-20260720 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:08f8d55b-20bc-4b56-a8a8-59fc8f6e86f1,IP:0,U RL:0,TC:0,Content:0,EDM:-25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-25 X-CID-META: VersionHash:e7bac3a,CLOUDID:92fcc3ce54c709c00faa8cfc420ba7f9,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|136|850|865|898,TC:nil,Content:0|15| 50,EDM:2,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0, OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 205018d2840511f1aa26b74ffac11d73-20260720 X-User: yanlonglong@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1449243044; Mon, 20 Jul 2026 14:34:57 +0800 From: longlong yan To: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: longlong yan Subject: [PATCH] selftests/mm: use MAP_FAILED for mmap error check Date: Mon, 20 Jul 2026 14:34:39 +0800 Message-ID: <20260720063439.522-1-yanlonglong@kylinos.cn> X-Mailer: git-send-email 2.47.1.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the direct comparison with (void *)-1 with the standard MAP_FAILED macro when checking mmap() Signed-off-by: longlong yan Acked-by: David Hildenbrand (Arm) Reviewed-by: Lorenzo Stoakes (ARM) --- tools/testing/selftests/mm/mseal_test.c | 106 ++++++++++++------------ 1 file changed, 53 insertions(+), 53 deletions(-) diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selfte= sts/mm/mseal_test.c index faad4833366a..93c2e13094d4 100644 --- a/tools/testing/selftests/mm/mseal_test.c +++ b/tools/testing/selftests/mm/mseal_test.c @@ -234,7 +234,7 @@ static void test_seal_addseal(void) unsigned long size =3D 4 * page_size; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 ret =3D sys_mseal(ptr, size); FAIL_TEST_IF_FALSE(!ret); @@ -250,7 +250,7 @@ static void test_seal_unmapped_start(void) unsigned long size =3D 4 * page_size; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* munmap 2 pages from ptr. */ ret =3D sys_munmap(ptr, 2 * page_size); @@ -278,7 +278,7 @@ static void test_seal_unmapped_middle(void) unsigned long size =3D 4 * page_size; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* munmap 2 pages from ptr + page. */ ret =3D sys_munmap(ptr + page_size, 2 * page_size); @@ -310,7 +310,7 @@ static void test_seal_unmapped_end(void) unsigned long size =3D 4 * page_size; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* unmap last 2 pages. */ ret =3D sys_munmap(ptr + 2 * page_size, 2 * page_size); @@ -339,7 +339,7 @@ static void test_seal_multiple_vmas(void) unsigned long size =3D 4 * page_size; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* use mprotect to split the vma into 3. */ ret =3D sys_mprotect(ptr + page_size, 2 * page_size, @@ -370,7 +370,7 @@ static void test_seal_split_start(void) unsigned long size =3D 4 * page_size; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* use mprotect to split at middle */ ret =3D sys_mprotect(ptr, 2 * page_size, PROT_READ | PROT_WRITE); @@ -395,7 +395,7 @@ static void test_seal_split_end(void) unsigned long size =3D 4 * page_size; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* use mprotect to split at middle */ ret =3D sys_mprotect(ptr, 2 * page_size, PROT_READ | PROT_WRITE); @@ -420,7 +420,7 @@ static void test_seal_invalid_input(void) int ret; =20 setup_single_address(8 * page_size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); ret =3D clean_single_address(ptr + 4 * page_size, 4 * page_size); FAIL_TEST_IF_FALSE(!ret); =20 @@ -455,7 +455,7 @@ static void test_seal_zero_length(void) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 ret =3D sys_mprotect(ptr, 0, PROT_READ | PROT_WRITE); FAIL_TEST_IF_FALSE(!ret); @@ -505,7 +505,7 @@ static void test_seal_twice(void) unsigned long size =3D 4 * page_size; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 ret =3D sys_mseal(ptr, size); FAIL_TEST_IF_FALSE(!ret); @@ -525,7 +525,7 @@ static void test_seal_mprotect(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D seal_single_address(ptr, size); @@ -549,7 +549,7 @@ static void test_seal_start_mprotect(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D seal_single_address(ptr, page_size); @@ -579,7 +579,7 @@ static void test_seal_end_mprotect(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D seal_single_address(ptr + page_size, 3 * page_size); @@ -609,7 +609,7 @@ static void test_seal_mprotect_unalign_len(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D seal_single_address(ptr, page_size * 2 - 1); @@ -638,7 +638,7 @@ static void test_seal_mprotect_unalign_len_variant_2(bo= ol seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); if (seal) { ret =3D seal_single_address(ptr, page_size * 2 + 1); FAIL_TEST_IF_FALSE(!ret); @@ -666,7 +666,7 @@ static void test_seal_mprotect_two_vma(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* use mprotect to split */ ret =3D sys_mprotect(ptr, page_size * 2, PROT_READ | PROT_WRITE); @@ -701,7 +701,7 @@ static void test_seal_mprotect_two_vma_with_split(bool = seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* use mprotect to split as two vma. */ ret =3D sys_mprotect(ptr, page_size * 2, PROT_READ | PROT_WRITE); @@ -748,7 +748,7 @@ static void test_seal_mprotect_partial_mprotect(bool se= al) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* seal one page. */ if (seal) { @@ -780,7 +780,7 @@ static void test_seal_mprotect_partial_mprotect_tail(bo= ol seal) */ =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr + page_size, page_size); @@ -810,7 +810,7 @@ static void test_seal_mprotect_two_vma_with_gap(void) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* use mprotect to split. */ ret =3D sys_mprotect(ptr, page_size, PROT_READ | PROT_WRITE); @@ -853,7 +853,7 @@ static void test_seal_mprotect_split(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* use mprotect to split. */ ret =3D sys_mprotect(ptr, page_size, PROT_READ | PROT_WRITE); @@ -890,7 +890,7 @@ static void test_seal_mprotect_merge(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* use mprotect to split one page. */ ret =3D sys_mprotect(ptr, page_size, PROT_READ | PROT_WRITE); @@ -924,7 +924,7 @@ static void test_seal_munmap(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr, size); @@ -955,7 +955,7 @@ static void test_seal_munmap_two_vma(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* use mprotect to split */ ret =3D sys_mprotect(ptr, page_size * 2, PROT_READ | PROT_WRITE); @@ -996,7 +996,7 @@ static void test_seal_munmap_vma_with_gap(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 ret =3D sys_munmap(ptr + page_size, page_size * 2); FAIL_TEST_IF_FALSE(!ret); @@ -1028,7 +1028,7 @@ static void test_seal_munmap_partial_across_vmas(bool= seal) int prot; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr + page_size, page_size); @@ -1058,7 +1058,7 @@ static void test_munmap_start_freed(bool seal) int prot; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* unmap the first page. */ ret =3D sys_munmap(ptr, page_size); @@ -1097,7 +1097,7 @@ static void test_munmap_end_freed(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* unmap last page. */ ret =3D sys_munmap(ptr + page_size * 3, page_size); @@ -1128,7 +1128,7 @@ static void test_munmap_middle_freed(bool seal) int prot; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* unmap 2 pages in the middle. */ ret =3D sys_munmap(ptr + page_size, page_size * 2); @@ -1172,7 +1172,7 @@ static void test_seal_mremap_shrink(bool seal) void *ret2; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr, size); @@ -1201,7 +1201,7 @@ static void test_seal_mremap_expand(bool seal) void *ret2; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); /* ummap last 2 pages. */ ret =3D sys_munmap(ptr + 2 * page_size, 2 * page_size); FAIL_TEST_IF_FALSE(!ret); @@ -1233,9 +1233,9 @@ static void test_seal_mremap_move(bool seal) void *ret2; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); setup_single_address(size, &newPtr); - FAIL_TEST_IF_FALSE(newPtr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(newPtr !=3D MAP_FAILED); ret =3D clean_single_address(newPtr, size); FAIL_TEST_IF_FALSE(!ret); =20 @@ -1266,7 +1266,7 @@ static void test_seal_mmap_overwrite_prot(bool seal) void *ret2; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr, size); @@ -1294,7 +1294,7 @@ static void test_seal_mmap_expand(bool seal) void *ret2; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); /* ummap last 4 pages. */ ret =3D sys_munmap(ptr + 8 * page_size, 4 * page_size); FAIL_TEST_IF_FALSE(!ret); @@ -1325,7 +1325,7 @@ static void test_seal_mmap_shrink(bool seal) void *ret2; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr, size); @@ -1354,9 +1354,9 @@ static void test_seal_mremap_shrink_fixed(bool seal) void *ret2; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); setup_single_address(size, &newAddr); - FAIL_TEST_IF_FALSE(newAddr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(newAddr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr, size); @@ -1385,9 +1385,9 @@ static void test_seal_mremap_expand_fixed(bool seal) void *ret2; =20 setup_single_address(page_size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); setup_single_address(size, &newAddr); - FAIL_TEST_IF_FALSE(newAddr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(newAddr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(newAddr, size); @@ -1416,9 +1416,9 @@ static void test_seal_mremap_move_fixed(bool seal) void *ret2; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); setup_single_address(size, &newAddr); - FAIL_TEST_IF_FALSE(newAddr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(newAddr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(newAddr, size); @@ -1445,7 +1445,7 @@ static void test_seal_mremap_move_fixed_zero(bool sea= l) void *ret2; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr, size); @@ -1476,7 +1476,7 @@ static void test_seal_mremap_move_dontunmap(bool seal) void *ret2; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr, size); @@ -1505,7 +1505,7 @@ static void test_seal_mremap_move_dontunmap_anyaddr(b= ool seal) void *ret2; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr, size); @@ -1517,7 +1517,7 @@ static void test_seal_mremap_move_dontunmap_anyaddr(b= ool seal) * use allocate/free to similate that. */ setup_single_address(size, &ptr2); - FAIL_TEST_IF_FALSE(ptr2 !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr2 !=3D MAP_FAILED); ret =3D sys_munmap(ptr2, size); FAIL_TEST_IF_FALSE(!ret); =20 @@ -1547,7 +1547,7 @@ static void test_seal_merge_and_split(void) =20 /* (24 RO) */ setup_single_address(24 * page_size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 /* use mprotect(NONE) to set out boundary */ /* (1 NONE) (22 RO) (1 NONE) */ @@ -1637,7 +1637,7 @@ static void test_seal_discard_ro_anon_on_rw(bool seal) int ret; =20 setup_single_address_rw(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr, size); @@ -1669,7 +1669,7 @@ static void test_seal_discard_ro_anon_on_pkey(bool se= al) SKIP_TEST_IF_FALSE(pkey_supported()); =20 setup_single_address_rw(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 pkey =3D sys_pkey_alloc(0, PKEY_UNRESTRICTED); FAIL_TEST_IF_FALSE(pkey > 0); @@ -1751,7 +1751,7 @@ static void test_seal_discard_ro_anon_on_shared(bool = seal) unsigned long mapflags =3D MAP_ANONYMOUS | MAP_SHARED; =20 ptr =3D mmap(NULL, size, PROT_READ, mapflags, -1, 0); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D sys_mseal(ptr, size); @@ -1779,7 +1779,7 @@ static void test_seal_discard_ro_anon(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D seal_single_address(ptr, size); @@ -1809,7 +1809,7 @@ static void test_seal_discard_across_vmas(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D seal_single_address(ptr + page_size, page_size); @@ -1840,7 +1840,7 @@ static void test_seal_madvise_nodiscard(bool seal) int ret; =20 setup_single_address(size, &ptr); - FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + FAIL_TEST_IF_FALSE(ptr !=3D MAP_FAILED); =20 if (seal) { ret =3D seal_single_address(ptr, size); --=20 2.43.0