From nobody Sat Jul 25 03:20:12 2026 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A83027D786 for ; Mon, 20 Jul 2026 02:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784513353; cv=none; b=e1xx8NhCJ5ftHtAbURd0b93u4YWVjz1+ByGmaLXPDpv3ITOe6u/rtdxwgF4NnJBlvPd8wHbmPFk14zqSMqjyjm92p4gH0OsNpFe268yb5oiNFP7b0yLhgymfuWmSihGunCAAPcnMLn1SiXYwKRZOZ2/HuAt/ESFZ/WCfYZMQUOA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784513353; c=relaxed/simple; bh=Qp+8v8xeLdewqRc7DicuCMBj15mpz4wfB6nsfukV+7Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Wca6zxUTfZx9D1oCgHIAGLYk7GMw2wpfOx0oMD/CqB5VSXyqv64LYCTLKGnAvhq3eQgy4STP30VEZnon7wMc192zAd3m4T0B7KiPOyRpGcDRxXjLIfU9RGByY4Ox/FJCc97b/P+l1YozDUpMdh88W4RkChj6ZGkEN0dqd+IuKko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KkpO/hsf; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KkpO/hsf" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-9061a795d76so66157906d6.3 for ; Sun, 19 Jul 2026 19:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784513350; x=1785118150; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=SaPW5A1Sk4IueK0qNz7OPYuFBk9omXY8zTZ0G2a4L5g=; b=KkpO/hsfJMCxfs90hoWlZj+LlAo77/7V2MCcY1IT6JYw3lfMFNyAcBdefCwzy+BwIc 6qCRcpKOuRlrAccAJWsR3Nyx0/K6BjY+K9V0AWq/+cwmfWj90sW+UuDHvYT3LGaOkWHk 7ftjCZMOAEzddw2kwXKzuixrtQU8s400f3HR5KOsgrrV6nkL/w4GrdG803PYP8eMSMjX R4QV3F6nwprm+AUbHJLEoSuy5Ew/HQXIlt0AFW50PeO4ESETuQEFxU+MPpIkNcl1t1+v Ac6YZPDYZ7DU0/8Xl5pII7p0x9JVSYzr+cJ68qK+0IuHl8cpBfhLRblnmw8ebQbvPbmT XsRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784513350; x=1785118150; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SaPW5A1Sk4IueK0qNz7OPYuFBk9omXY8zTZ0G2a4L5g=; b=Tr/q3TfZ/mWICTAYxW3Hbcw6KnamtPpjHyzLv2yJ+zK+ifaBCegC+xuD+8986KHVZB wxUlkPH191lHWloKPWo5F4Xd8pN22cQw6sg+0cSCJnuxpjWfuguAssjGgjb3Q+TaTDer fEvDbzMiDlVMXMtA6JoGe5VaJ2pp6qc9kBAQROyfgu6JXPHBcUOl0xQWvi4w4199eShF Z1vfuuaZmM4J0nh2kZ3eCQD1sxH5V2I1c/q1losI3QHEzf4uGeHViausRUeqRKhY924W JV1Sy10EOzB1vYRpkCSUtUrde/VWITp8MXRAkGcdZIZK/MUjG7VwqcgrrItN4qB/AL2h 5Meg== X-Forwarded-Encrypted: i=1; AHgh+RrjTA6pHDk0crCwcT/MEJqPsIeUR+//ZINf/AdFQl7KhaPEXr/xZ6ikXpQQkz+9UEU5nUGeLfPahJtJyN4=@vger.kernel.org X-Gm-Message-State: AOJu0YwFpPVz2thi6BzhO9jN8/vmKufZm57s9RqxjxCAB7f2TdfYvGxu 5J0Mx5VVQ4o+JpXe79CjvK17Nyjx672E1W5RN1NMYRaB98DbOGnFFhfO X-Gm-Gg: AfdE7cm68uEi+l9g19wnKFV2NGaOhH5AAbtCdL9F//h64UtmVaPwxa+/Fp4tsDzksOS YCkr3numq5Lu22+5zuk+BSD6ww9/tYV1x1HKN8lQPAJBEGw69udjLG8/d3WQ+6DSV34dGMybmtA GvD3jTfC4/hCwQP/ybXYD8uXWEqtzD80j94tKoeZ64or7q5k1Y0WVI+nXXYNuiWH+5qVJQCkBef 23gbjoEdkWzBra7SSQw35I+BFZi47KQ6luICCDEaGk4xYvJnkxLyHZQk6jLkbuSaqakA0uWa3z6 Sj3qknHwL7JZHXv+og3hKqrlfw0HO+AXXlD3+4dkDiqDI/2iwgYNdizc0Z0pwtDJ5YWyS67Q7L5 llGN2NJ+i4Pr9/dlmkjVvmB2kc4YhRAC5vLbWFf0g/q+gAxjGeF0VSLkk+6jzlzqN1HNpdVpaLD A8n7K+oNTaO0W3i9uHs2TZzMsD9cUZeRq4C22qrDDuNZrayxS9mK5av1kjc/6wISkexC6L24EdR gfd78HXUNx7UXNGMZzy+2o89b+TE4PopCuBbO1Q5/h19Uzv4OLvS1Q= X-Received: by 2002:a05:6214:212c:b0:8ec:a010:9af5 with SMTP id 6a1803df08f44-90778310af9mr134021156d6.10.1784513350415; Sun, 19 Jul 2026 19:09:10 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9077856a9e8sm79969766d6.17.2026.07.19.19.09.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 19:09:09 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ata: pata_ep93xx: fix incorrect return value in data_xfer Date: Sun, 19 Jul 2026 19:09:07 -0700 Message-ID: <20260720020907.2004063-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The while (words--) loop post-decrements words, so it underflows from 0 to UINT_MAX on exit. The function then returns "words << 1", which is either 0 (for odd-length transfers after words++) or 0xFFFFFFFE (for even-length transfers). Callers like __atapi_pio_bytes() depend on the correct byte count to manage scatter-gather progress; a wrong value causes ATAPI PIO transfer errors. Fix by returning ALIGN(buflen, 2) instead of the corrupted words counter, matching what ata_sff_data_xfer() effectively returns via its words counter. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/pata_ep93xx.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c index 21d7261f537e..97dda6213878 100644 --- a/drivers/ata/pata_ep93xx.c +++ b/drivers/ata/pata_ep93xx.c @@ -502,15 +502,13 @@ static unsigned int ep93xx_pata_data_xfer(struct ata_= queued_cmd *qc, if (unlikely(buflen & 0x01)) { buf +=3D buflen - 1; =20 - if (rw =3D=3D READ) { + if (rw =3D=3D READ) *buf =3D ep93xx_pata_read_data(drv_data, IDECTRL_ADDR_DATA); - } else { + else ep93xx_pata_write_data(drv_data, *buf, IDECTRL_ADDR_DATA); - } - words++; } =20 - return words << 1; + return ALIGN(buflen, 2); } =20 /* Note: original code is ata_devchk */ --=20 2.55.0