From nobody Sat Jul 25 03:20:11 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC016DDCD for ; Mon, 20 Jul 2026 00:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784506175; cv=none; b=R9oJlE6epqasWMqCON9VteLlE4ji/7ljm6XtxBP7zWm/anK5osb+Qg/S1VWQ9SD1YQd6uRVTSZQJC8eSZB5surO++HpCvtFwYmSolEXnlkRTddGUR28WHWLGIekh/xmgvoWnUt02Qhc4BMQAc7See1rfTP3iJ/9GpFkHmFSz4AI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784506175; c=relaxed/simple; bh=1B5nx6Zi3n99efkcbz8SAb5twJXQTnwPAszDbfWLjgk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WMHNFxrjX0RvhAxUaKcE5YRWIJhxXmxTl9evw0uVyf1bf/pKdeIcDYCcN3Ln0YOl+FWM6zwATmThbCIXRboe1XbH09Wc+SgUxHkvqnviQ4/bhcZxYykT3V8cjn/HRkjYizt9AColGRt1qGaBHIAQCul7Kb39fiOoucR36iQFiyQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MJmJJGIX; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MJmJJGIX" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2caced6038eso44100595ad.0 for ; Sun, 19 Jul 2026 17:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784506173; x=1785110973; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=1MTXEfjCsGKySnmNhd6yyr4V6U2qE/6o/lYlOr1lRnA=; b=MJmJJGIXAJYMYx83V7aeyEBcXTgRIT29/Cr45bknA6ADXf1/tOilgabW1cC6qajT+T gM/4XPMpi0dtnJ47uEyk1vzr3qxSemC8cqHRx/DZgsFddaFTc7nsSYNuySvUABWDLfEX gxPInPZAD+kHhyKTPXqjp42ToxR22yr+lSLUch4VNCIcilsbbtVg74yHvRdsoqfH0wTe kxcGu3XxnjM1fiZTOvyITeexjUQJks5oL49+TSiSEd2p+7mYMiwMZtZUAhavNnGQlteB izFagLtgBglsVys/av4cgh+2yhanZjv7jRIT86PBt9HbKnZ7vtvNSRbRPZTUhJJ7VWis /XUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784506173; x=1785110973; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1MTXEfjCsGKySnmNhd6yyr4V6U2qE/6o/lYlOr1lRnA=; b=EVkhZn5RdLNh0Fsq3NXgLD9fEq25hI0V/crusIJH69Y/rjftlscLYw1bOR0JgA37Lh RQ8b9pYgaEXBY/zrWXHp3Y04zgSvmM3VjsXcR8lvp9xvRYVBwhWskQVc3V0qU+37cem6 23c2+WYXfi9j6gv1IrpgJsKl2Gp88mZmds+rQ8VlWVlDfk9HFEHmUv3iYnXhXXvJBlhQ dmhzJrP8bQjICbOA0SbTjVTnNDf4QTTUIW5lEDwKfUGHCcWzkFK7h873wfjtuZyM1S+R nXywRFO8FKpKWbUgup1JTBvHod8yL/on35iS9y6ZVri3ZoEiT0S/J5MmZ2v3kLGrgUFV ckww== X-Forwarded-Encrypted: i=1; AHgh+Rr5T/hDXj5euPRLxWq71PlsIhwBuHMOjBgWOyeubpndJqggzzbbffDxyOxKfmi6oyP+fJy4txiWgaCyWsw=@vger.kernel.org X-Gm-Message-State: AOJu0YxthOeyuZHwrCMhB2OxPuQSB0aSDfxkknRX2+1FSQkT5x/jrOGV blOU87036w9f+WcOvF555mhXCCsaM2bPNlSWr7yFhsyuPB+Top2PBHRP X-Gm-Gg: AfdE7ckVEnoTmhHoJ29jeT9Bv6FKgn91HLUdCbqBAMh47KGnSo8XXXEMrD+kJPgMTUz iakLKyhWXabBPVhcg202cqHL5k8Yzy3UGde4q7Iu2r5utQXU06e0pDazTBvRLP2LtcTEeGdxcWh rFUKvJg2dN+vdKueYxnV7yMn4I/noxHa5u6sNo7vP7AbhdTh9WLGiTDMX878iz0XdaAR3g74hUh TWBImGqgqeEoM61dMAX5KEBsTwiOh7cwkakPQ2naATv3r3nriae10q5avHI1o9FCm+smm+2nUMB FA0K+h55wQ0ksTeWU9idg6GCCBgXhJH707oKBKo02fB5L/Yaf950+4F5jsK277hOjb6lDnN1a2J ZKhxLaW0vd968TUf21q6HnnbQ3bLNvGMBY+SjBmjW9xbwFLvaZ6ycTJQXtmjIyf8wku2PcQdVJC X5061lUSJx2v9mYdh7+OjNZJPdIPXaf6LVp3IDxbG+MJkxXkrFAHVU50nbXLlltPMF4dqwfyk9U KrW9bV8BQWQS1O0LmTOUjg/YJOraPixltPPQqTHvKJZ9eUzwFe12QU= X-Received: by 2002:a17:902:d501:b0:2c9:d8c5:d55d with SMTP id d9443c01a7336-2cf349bc5e1mr126653745ad.16.1784506173031; Sun, 19 Jul 2026 17:09:33 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf3448f91bsm46716385ad.8.2026.07.19.17.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 17:09:31 -0700 (PDT) From: Rosen Penev To: linux-sound@vger.kernel.org Cc: Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ALSA: sis7019: Use pcim_iomap_region() for MMIO BAR Date: Sun, 19 Jul 2026 17:09:29 -0700 Message-ID: <20260720000929.1432533-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the open-coded pcim_request_all_regions() + devm_ioremap() pair with per-BAR pcim helpers: reserve BAR0 (the I/O port region, used via inl/outl) with pcim_request_region(), and reserve + iomap BAR1 (MMIO) with a single pcim_iomap_region() call. This folds the BAR1 reserve and iomap into one managed call. The error check moves from a NULL test to IS_ERR(), since pcim_iomap_region() returns an IOMEM_ERR_PTR on failure. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- sound/pci/sis7019.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/pci/sis7019.c b/sound/pci/sis7019.c index 4be085d27712..55c1b11a2900 100644 --- a/sound/pci/sis7019.c +++ b/sound/pci/sis7019.c @@ -1260,16 +1260,16 @@ static int sis_chip_create(struct snd_card *card, sis->irq =3D -1; sis->ioport =3D pci_resource_start(pci, 0); =20 - rc =3D pcim_request_all_regions(pci, "SiS7019"); + rc =3D pcim_request_region(pci, 0, "SiS7019"); if (rc) { - dev_err(&pci->dev, "unable request regions\n"); + dev_err(&pci->dev, "unable request I/O region\n"); return rc; } =20 - sis->ioaddr =3D devm_ioremap(&pci->dev, pci_resource_start(pci, 1), 0x400= 0); - if (!sis->ioaddr) { + sis->ioaddr =3D pcim_iomap_region(pci, 1, "SiS7019"); + if (IS_ERR(sis->ioaddr)) { dev_err(&pci->dev, "unable to remap MMIO, aborting\n"); - return -EIO; + return PTR_ERR(sis->ioaddr); } =20 rc =3D sis_alloc_suspend(sis); --=20 2.55.0