From nobody Sat Jul 25 02:13:31 2026 Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81CD73BFE23 for ; Mon, 20 Jul 2026 15:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.180.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784560088; cv=none; b=uX2AlJKq3/OVhkVKML9VYasPdzFLr0HMWYYDgn7Q498MXHx0GdNgsQ+A8qsCRF2oStjQURfKam9oGO1LDnxVi80t3EFcIKdfwkJf8YZ4z1uPN+p2CrnN0r2hrb5Ws0Oi+q4vg0Pr/w7IiMVfibZ3ff+hBfEObBGveLSJMPvHZPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784560088; c=relaxed/simple; bh=4irHSa+ufzET4GT3muhV/dmV9x7WxdBYM/2KJoqpJ5E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:To:CC; b=mksb5IcpvIz7xDD+WzQkWziXg7VkgiT7jVKbdGMMTYMvAn2yQBewvZrhmSSSK3JIABCbKRjoftkb0t4q/OR+fM8iVMWmFDG2+ZoPISsukEOHJiD5/enygngBK2Y3gT7XDhaVQXqmDcqIK/nBfFX88efMSPRsqUJwlwVlxj/Ec5o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=IhiUS3S6; arc=none smtp.client-ip=185.132.180.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="IhiUS3S6" Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KDqTsj2914173; Mon, 20 Jul 2026 16:07:52 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=dk201812; bh=vzqpkCpOUGBRuMhg8B/LjWE KGEloZQPTeKICH6ENZhs=; b=IhiUS3S654XWMuMXgQrcw1M2FmZpv1p+husUGlb 4B7IWh/D0fr00hil6pM1lFh4NXgeFIDZzLobiiEg3B44Ls5rqYPiOKHLEUGyWyiy 8qK3fSjpDMLBlRG3MjqTJ7pWt+kUqf1ckDUbPUzFhg6OzwYStKhxFGXS3B3xccYC 0agY8f+25u44+6Sm1h7gHn5+gioMuoFMOpR1GKssuymuTWgvI5lyAcdQxSzvC9NU 66GcpJ0nSgIj3lSDXAZOsGU+FW5npXwxD/TH72h5DGUJS6HeDKv4K4UPukiGiTmH vq5qZhwuAuRRvE+xV+8AukyzJb6Fw6xAiNKB6hIwJxAGjNQ== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 4fg1ju9v46-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Jul 2026 16:07:52 +0100 (BST) Received: from NP-A-BELLE.kl.imgtec.org (172.25.4.9) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Mon, 20 Jul 2026 16:07:51 +0100 From: Alessio Belle Date: Mon, 20 Jul 2026 16:07:28 +0100 Subject: [PATCH] drm/imagination: Fix value of HWRT address in pvr_job_create tracepoint Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260720-fix-pvr-job-trace-hwrt-v1-1-b24551802efb@imgtec.com> X-B4-Tracking: v=1; b=H4sIAK85XmoC/x2MSQqAMAwAvyI5G2jril8RD1qjxkNbUlFB/LvF4 8DMPBBJmCJ02QNCJ0f2LoHOM7Db6FZCnhODUaZWjVG48I3hFNz9hIeMlnC75MDCLFVpFVndVpD iIJTMf9wP7/sBYpDIqmgAAAA= X-Change-ID: 20260720-fix-pvr-job-trace-hwrt-32f54c0ec185 To: Luigi Santivetti , Brajesh Gupta , Frank Binns , "Alexandru Dadu" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , "Alessio Belle" X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2606; i=alessio.belle@imgtec.com; s=20260628; h=from:subject:message-id; bh=4irHSa+ufzET4GT3muhV/dmV9x7WxdBYM/2KJoqpJ5E=; b=owGbwMvMwCUm4nVW5aiD4lnG02pJDFlxlsdrp37IXr5Kbvnlrc82rNHn+LVR1uDjhQ0Pc86/7 ma6NHvipI5SFgYxLgZZMUWWD/s2/rfV+1ArxbD9IswcViaQIQxcnAIwkQIVhn8K6uWh5Tcq7qlu fbpfYea5i3pMe84+19F7f9FvU7JiY10ow19JO+0leUnX9jyr+ffl3n+v/DfT81pmV596stA3+MD WFexMAA== X-Developer-Key: i=alessio.belle@imgtec.com; a=openpgp; fpr=F0BEB1FF3D2EF07D1A00B7D1144ACD24C54021CD X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE2NyBTYWx0ZWRfX+ifMnFKZP26t r6OOdpjGiEpHxtkqZxY6lPuPrQLIFxW0lRw42YZJVoaofxYaPP68Z+ngSNWtDhvsTkGIWV1tUbi 0fNfZNvapp6Cb7ZLbmy5OCCL+s3kBNs= X-Authority-Analysis: v=2.4 cv=Ta2mcxQh c=1 sm=1 tr=0 ts=6a5e39c8 cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=rvaOABGgyOwA:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=7RYWX5rxfSByPNLylY2M:22 a=r_1tXGB3AAAA:8 a=bGpNHNAHFwgwU_sQmyUA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 X-Proofpoint-GUID: 9gwEFGdTwN1WWPm1_7DUgKVv-Ax26w87 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE2NyBTYWx0ZWRfX+rJOnTeweNLb 4+Vh3OAuG97m6+eKz/BzqpVwwgUWvNf78jfdP7XP3OCiG5EtaucMSZjrpaUDvl+bBT3fynoCM2F gUQ/CXaaHhb42h5OvQaqvjtGPFgtpfzQUr+skMAAYyBoTV6zLjMKN2YER0Rz/RBagqyvcoMUDls 3I0iuCydZYuuhhUiXCOHtacIvn7qfHGUpBPl27Mw/odzWj4DNcrNdNSI8ISXh1HVZMBAMFwNdVA +qRNEuykeXl4RKEf7GWPT+Kd1fQ+MFDFa3nAgUFGcWfUSQl5S/edDUgJDnnoUFpiqnX5q+bS7FD WGrmtDpApJaHnXV7nEO29uBZ7PFVYpcxZOvSQglGgPMSh75tjXAezCVRucDtcPFSD/OKg7wEFfD msAzc3nYuxEYYFTdpyWA60HRfkx03qvqn++R3pSYpdB31dljOXVtx148ssFmV3oUp5J9gmSG8rq 6KDBHm/TGqhXvQQhBvQ== X-Proofpoint-ORIG-GUID: 9gwEFGdTwN1WWPm1_7DUgKVv-Ax26w87 The pvr_job_create tracepoint was using pvr_fw_object::fw_addr_offset to display the firmware address of the render target structure attached to a job, but that's an offset into the firmware heap, not the expected full address, which is more useful in general e.g. for cross referencing against firmware logs. Use pvr_fw_object_get_fw_addr() to get the full firmware address. Fixes: c1079aebb4de ("drm/imagination: Add support for trace points") Signed-off-by: Alessio Belle Reviewed-by: Brajesh Gupta --- drivers/gpu/drm/imagination/pvr_trace.h | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_trace.h b/drivers/gpu/drm/imag= ination/pvr_trace.h index ffbbde3b2bcc..943d6b2418cb 100644 --- a/drivers/gpu/drm/imagination/pvr_trace.h +++ b/drivers/gpu/drm/imagination/pvr_trace.h @@ -41,6 +41,17 @@ TRACE_EVENT(pvr_job_submit_ioctl, __entry->count) ); =20 +#define PVR_JOB_GET_HWRT_FW_ADDR(job) = \ + ({ = \ + struct pvr_job *_job =3D (job); = \ + u32 _hwrt_fw_addr =3D 0; = \ + \ + if (_job && _job->hwrt) \ + pvr_fw_object_get_fw_addr(_job->hwrt->fw_obj, &_hwrt_fw_addr); \ + \ + _hwrt_fw_addr; \ + }) + #define PVR_JOB_TYPE_TO_STR(val) \ __print_symbolic(val, \ { DRM_PVR_JOB_TYPE_GEOMETRY, "geometry" }, \ @@ -64,9 +75,7 @@ TRACE_EVENT(pvr_job_create, __entry->ctx =3D job->ctx; __entry->fw_obj =3D job->ctx->fw_obj; pvr_fw_object_get_fw_addr(job->ctx->fw_obj, &__entry->fw_addr); - __entry->hwrt_addr =3D job->hwrt ? - job->hwrt->fw_obj->fw_addr_offset : - 0; + __entry->hwrt_addr =3D PVR_JOB_GET_HWRT_FW_ADDR(job); __entry->job =3D job; __entry->job_type =3D job->type; __entry->sync_op_count =3D sync_op_count;), @@ -82,6 +91,7 @@ TRACE_EVENT(pvr_job_create, ); =20 #undef PVR_JOB_TYPE_TO_STR +#undef PVR_JOB_GET_HWRT_FW_ADDR =20 TRACE_EVENT(pvr_job_submit_fw, TP_PROTO(struct pvr_job *job), --- base-commit: 17e2030f37600994440f875dc410615d5c66ee6d change-id: 20260720-fix-pvr-job-trace-hwrt-32f54c0ec185 Best regards, --=20 Alessio Belle