From nobody Sat Jul 25 02:34:54 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EC9A422525 for ; Mon, 20 Jul 2026 13:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784552682; cv=pass; b=NCEjDSpm7pakNopfahImJ1TpjKaAzzoclv0EBjHEVOcOt8uAAjxN5eoOlK3hDlYY7CNicQFBNM/6iculzIZaYPQ1VEGyDq3qSa6d9Unq1lytUYvVRO5O3PBGRcygVD8EU65rNeYvJPVncudv2oWjbCPOQwLyCWgIGvSKYycmxF8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784552682; c=relaxed/simple; bh=RQ1ayTYu8YmCIX6EfVa5wv1ANpbWnl8JwG9AYTD30PI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=BPGdmBFxXUM3pGyyh2ngboTcYmdFoMGHu+4p2z1Fd7YpE/6vQLAhTNG3uH5NhqzppwEc6qVI46P0pETRpk5ukiuOMvqNYMEDdYZAZqBf0g4wh9rOw9IoRK9cMhzae1VAqorEsXzjREvVLQXLuRdCIk8zoV8XyRZILu8wZCfGrdc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=X6t28ym+; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="X6t28ym+" ARC-Seal: i=1; a=rsa-sha256; t=1784552660; cv=none; d=zohomail.com; s=zohoarc; b=ehHzSpYz0V8EqhdM6EaBEumDPGR8sGmdS4JCTGmnlybjizGiVLuY6BG48JZFwiopfrn1xAoX5nMkONF4+4GDcw8YYDC1srZoA31xKfhXN/D49sVE/KBqn69UL0JHIv/9porcqQGi+1ypeeoMnbpSsfQcHzSlBgDd5mNOLRaHlxA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784552660; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=HN6kXcysOJTr101hpnG7NcuN/66ELXnKkFR6JHIY2pk=; b=cKPVZKlH/AhN7djjCHYWlH25lEpgA4afBBKsuDb6hv7wfPnIlYsyzPGzJcBEot2CJ7D1TG+ZSoEq4KF/XDd4GLpAk9JGy611AW9fnpiaL7HIaGYqz5E7LQ6f4f7TSGrA1BqOMqw8wiZtyE7GNZ35aHCOwVK/lqIz6qyRUZmRWVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1784552660; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:To:To:Cc:Cc:Reply-To; bh=HN6kXcysOJTr101hpnG7NcuN/66ELXnKkFR6JHIY2pk=; b=X6t28ym+Q1c2Hgiw1gNAGYOUlvwWeGIMnUZgR5ERmumVio2zJYE5uusYgKFz/nR1 VNH9sr5uv5f1nAz0MJR96qf7hIg2xFmE6m8dBHMHsJJu0DNGMPwW05noTrzFESgEeCg Iml1oMvyDB5i5TCDUCuFtTEdn+WTLRLUOJXLGSrY= Received: by mx.zohomail.com with SMTPS id 1784552658856490.3691525909395; Mon, 20 Jul 2026 06:04:18 -0700 (PDT) From: Nicolas Frattaroli Date: Mon, 20 Jul 2026 15:03:57 +0200 Subject: [PATCH] drm/amd/display: Remove redundant AUTO color format handling in else Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260720-color-format-amdgpu-fix-v1-1-4ec896bb1531@collabora.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/y2NwQqDMBBEf0X23IXVgqK/UnqIyWq3NMZuYhHEf 2+sPb5hZt4GkVU4QldsoPyRKGHKUF4KsA8zjYziMkNFVU1NRWjDKygOQb1JaLwb5wUHWZFaQ9e Sats6A3k9K+f493y7nxyX/sk2HXf/hvJ7ycp01qA3kbPAe0ld4dSjl2hx4jXh4UdqsKzhvu9fs hhtXrcAAAA= X-Change-ID: 20260720-color-format-amdgpu-fix-09a03106c9da To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Daniel Stone , Marius Vlad Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dan Carpenter , kernel@collabora.com, Nicolas Frattaroli X-Mailer: b4 0.15.2 The AUTO connector color format is handled in the earlier branches for both RGB and YUV420. The repeated check in the else branch is therefore redundant. Remove it to make the code less confusing to read. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/alCcJmDeIYEE94Eh@stanley.mountain/ Fixes: 8a0343b03b98 ("drm/amdgpu: Implement "color format" DRM property") Signed-off-by: Nicolas Frattaroli Reviewed-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c b/= drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c index 88f938a8f24f..ea277c991234 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c @@ -854,12 +854,7 @@ static void fill_stream_properties_from_drm_display_mo= de( * error bubbles up to userspace. This way, userspace knows it * needs to make a better choice. */ - if (connector_state->color_format !=3D DRM_CONNECTOR_COLOR_FORMAT_AUTO) - timing_out->pixel_encoding =3D PIXEL_ENCODING_UNDEFINED; - else if (drm_mode_is_420_only(info, mode_in)) - timing_out->pixel_encoding =3D PIXEL_ENCODING_YCBCR420; - else - timing_out->pixel_encoding =3D PIXEL_ENCODING_RGB; + timing_out->pixel_encoding =3D PIXEL_ENCODING_UNDEFINED; } =20 timing_out->timing_3d_format =3D TIMING_3D_FORMAT_NONE; --- base-commit: e6a72e9b927165081566252d972ea1cbbee5bf28 change-id: 20260720-color-format-amdgpu-fix-09a03106c9da Best regards, -- =20 Nicolas Frattaroli