From nobody Sat Jul 25 03:20:13 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 374D91991CB for ; Sun, 19 Jul 2026 22:02:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784498549; cv=none; b=LpFFLzp6i4alnc1nhu/3/eKODggxsASyVPtGCHbcG8eD4FhoPcQ0bcR4p58Jb6oJ++QPPBt2cI4lNA+KdrwACHbNGekzN3i+p8xvuXCVjveMtm+9qzYN7gON21Cz9phrOa5uuO4H8JY6ClJboCLEEtz7CZ15FyP2D9ZmRgTPxRg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784498549; c=relaxed/simple; bh=0w+3lDYbj5Tk1FVUEhvs9fuaoqfoYazTfOE0hL658ps=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D5b/+ClSeanxvZeXsQbnCkx6gRq2UzKmyMGxH52qIgjsxGO91y5LaJSWwv2Nps3uS1wqub73MLKXIqKhSf81aaM4WwRXvrVmvG+yzNqZ0qR57q4/zwj1Gt3qcQUwCYWwfoWWyZnej8r2LUX8nN8Qtb1ohPBeqL6ZtYD1d60omnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZJM3fmfg; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZJM3fmfg" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c9ef3e1337fso6476809a12.2 for ; Sun, 19 Jul 2026 15:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784498548; x=1785103348; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ZfvhkooxWj3CsP9ZhhIe5Neuekb+2Nv4jVoCxZTmOkA=; b=ZJM3fmfgYwHqQWUHphdytUiCB2LMtJBGbKL44OG1RqC104Jk4FQPnZz2D7OSq81aoh swpedFNom5QSmb2aAYc5Ii94fUV75vJ/yctVavIoeQrrJcoZTvYWvGd4cwfoRkVLkjnz VDKFHe/e6i6QwvJCyM7fu6nayNUdvhobnVpa6hk9TYiI/P2xi1LMhAiadx8N8atIwqEu 8Q07gFpBAEZ3BRun4IXHCbfY6D9GnZ8wJyerU5GyE8lGtDVyhH76bKV4pY/V4+nQFDlJ wr8BZVf81egXOEqorGeBTpel/dc5ZFDEMiSaAWJLXtCUWuEm1MkE0ayLrcCL3AWTARxO wVQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784498548; x=1785103348; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZfvhkooxWj3CsP9ZhhIe5Neuekb+2Nv4jVoCxZTmOkA=; b=AQUGafjkMD99zyo7iIDbwMAbO9XXj1h6dzYt8bUbmzATfrIRhfR6Pcrf9tIlczipg2 xG9l4qKCE1A6ts7HZanTsR9f6fZEPagOgOjhc4zFe0nT8pGrtt/MxdhvC3IFd0RF0Gfh zjM09EgArcq+yMofEO6lgXgF1is6+kw/fGZzQXvDueiPtpc2avV51KiadYrPGW7dyb4S CrjNXdU+So+GdAM9pJLhWf7dSZcKun3qC/HXhMCmLJYjGdkyshJB3FehbW/Xm1uVqMue TIpm44L8oogQ3/ndDR9bdUG8AnwKkPGh5sXBQX0hnhaXvVH1GYhynIPZJp622RNI2Ru+ 1Eww== X-Forwarded-Encrypted: i=1; AHgh+RoFSVTBS3WBplEIN0g/PB/elNreaHhyqo9TibrInBAvP7Kk+WEDVy4kW/MYrfUE9PaTuA4M4gmiFGy1Vzs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzcfro7RePmXe7SNQcn9crwh+034sGLF0KlzTmGeaW7RtpMMIUp iw4Jwo5tru9SoBUvF5jR1X1xUidVvW4UzpGawlpHbrwLkik+b8kuVCmF X-Gm-Gg: AfdE7cmjsxRfVP0L8YtdSd8v/Mdx7NPc36rmCr+7gRXgnIpD6fMQMX00ztvUEQrZBjc Nn4ke/SehWWHHQVVFnL7H7f3KutQuGgH65BbvCTcUFUhDFnn8h05GVw7zJkS4v5QwBIi6rTTj8j YMhMNtsdTgOYBlHA0+Z8k16SVXTa0eRwX6Z+0riXNsBBc0662crn1/MiOCQtYzCqmg+m3n7Aiu2 aX7UJro+fq4bCqeHJK7mGNNZ+qYBu8MVi/OhJULK/BZvPuVv3nl14afSKwzoyUFutMgIEKfYefR uBC5b32hQOoQxTKQm/x5pGbkYIVO5pnM5SnQ2ewAV5zmPw554ldu6/u0G4jEJ8oe776sWjh999K w8FYunZjVe9lXt6otC9mPmRkVtYkf8ugjqe6jwueD2BX6ehAvtnAoMw90ZAia4nrETJ+O5gcdGB 4wCyQ= X-Received: by 2002:a05:6a21:a382:b0:3bf:96c6:78a9 with SMTP id adf61e73a8af0-3c3ad665b3fmr11748627637.2.1784498547566; Sun, 19 Jul 2026 15:02:27 -0700 (PDT) Received: from phi.nguyendp ([116.86.160.247]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1de21asm29507484eec.23.2026.07.19.15.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 15:02:27 -0700 (PDT) From: Nguyen Dinh Phi To: Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: Nguyen Dinh Phi , syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] vsock: use sock_error() to consume sk_err after connect timeout Date: Mon, 20 Jul 2026 05:57:47 +0800 Message-ID: <20260719220103.684489-1-phind.uet@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After vsock_connect() exits the wait loop due to sk->sk_err being set, the error was read but not cleared. This left sk->sk_err set for subsequent operations. Switch to sock_error() which atomically reads and clears sk->sk_err, so the error is consumed when returned. Signed-off-by: Nguyen Dinh Phi Reported-by: syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com --- net/vmw_vsock/af_vsock.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 622dbd046799..43eddc33ed12 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c @@ -1847,14 +1847,11 @@ static int vsock_connect(struct socket *sock, struc= t sockaddr_unsized *addr, prepare_to_wait(sk_sleep(sk), &wait, TASK_INTERRUPTIBLE); } =20 - if (sk->sk_err) { - err =3D -sk->sk_err; + err =3D sock_error(sk); + if (err) { sk->sk_state =3D TCP_CLOSE; sock->state =3D SS_UNCONNECTED; - } else { - err =3D 0; } - out_wait: finish_wait(sk_sleep(sk), &wait); out: --=20 2.53.0