From nobody Sat Jul 25 03:20:18 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E08E330CD82 for ; Sun, 19 Jul 2026 21:13:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784495590; cv=none; b=rfGAdrZKmpW43RPJCUxMY2QoQX1ibCAbcDc27TKo0T8/DSQk0AlHZbNMOFcMorWXtNjjcXYcKZi5FAAIJ66WubdGOQTmo6Gs1/ZNywWYS2meBfA+peuIg1Irx1AXVdmvlvnL5gUzJ0Zbiy26GLsR7fyChEzH/wUuAhPBuRtuIyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784495590; c=relaxed/simple; bh=qJO3ZujptMy/7FgWvsc/pn1ZbCWe9KW8wgoakalHQAI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=P4ftUwAvPjmSnlRYV5+s1DNLI36eaqG8GIOYLd4ptcucNna+fcYKiMP/FhgsJuRJANpOqRBwpFizS/HsApAqjPiP0UQJdnCsJJFGlF5kc77WNJ+pFrJi2wy3u1f4yz+drxO9csyskHKQ8RfzKJyljikoj/p09GbO+UP+TW3rNSw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z9u1mJ/S; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z9u1mJ/S" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-8485bd28dd0so11056554b3a.2 for ; Sun, 19 Jul 2026 14:13:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784495588; x=1785100388; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dDp/PKTYk1gWCNiEg+cmFFINBSYDOUDZu2iGc88f5tQ=; b=Z9u1mJ/SfqwdoyFiwW4yO/1Cw/sI07ohOj2asuEDYo6RQdFb5yR/8Z9UxxZOBP7y/F n5pNVO/pjMz7O6MyDl9Y60GAk4KgbPG2dASwDyeXW03m4w/jhuf0wUaJ8a2k38omFYhe R7U7X1fgPXQt80gZ3IBwjGjpwurZHkOYNkDlhqnfFANZhKu6WvXZ6WIARbCk3+Dc6RPt SXuB9bs0sERmV2hhQDov4LJVedHQk8I7Frw1zaS36t+gKvdKBPUMJKv/KRyCecmVXBCB eiuu1FP6sSpriCWCJq4FGjgfPK6XG4wFuJgMxsr14+ehFHVqsLh00fTDK3UN+/bppECz MT0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784495588; x=1785100388; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dDp/PKTYk1gWCNiEg+cmFFINBSYDOUDZu2iGc88f5tQ=; b=J0Q06KN8XiNbPtqggY/h+ECwGZeHF08v+k8vWsDHCYkkcqsbQyxOinGpENI8gkOFVy k4YqiZyTSdW8JHFjFzHdydRMwoZUju6ME0m3/yCxj9brtZPMKH4cHrB5ii+EzmoMN1fX MZS4Pb8PjFikfVYSulcAQFnl0fC76ZRJaBfS7erUqFeDZXoBdmT0XLOg0YrsEs250vpm bHw3jdEqAHnkd+CEtev5X2p79ksnJLO4g0YM0tj2BGuSrV+oBEnZ7WoYT25l10UFBOrd jlYczg2+Wo5Wrfqk47Q1rZRNK8bfKBPMjLLZv6+TgHDpCBF6+2S8nDsqrww1HWOWlDZT kJkA== X-Forwarded-Encrypted: i=1; AHgh+RqYalL6mleEzt+M77fkdE0X2VZh6jYrVHM/MG7tAdkV5MfJs7AtRegaD/l6/yoVg/ouNN7bszJy6Ztg5C4=@vger.kernel.org X-Gm-Message-State: AOJu0YxJyyPnVgCoq/1eXm0yhytyG/awoJ7PDVRh8Ge233ijqXG+mQ/S h4hxvQEKxDYuuhOngRFaXrYx1hKpcHPuI0vkdW8/sZocPlAcfKjF6/MC X-Gm-Gg: AfdE7cmG6Z5+wFSIPLhuU/qpgV/lEgGqyQvvr6pOgSEdr1O8JSshsNjFDkqpTmhGtQo lzaENGb2LMMTA4giZL7LPoJ1j6BEb9Jf55EUpXQKShRB9YojssCB2RHCnWTDgbeFdNszy9E90wR 7zSZXiXVmYSnXAW8HiRZPukGkVxODdscUxvv4wxNM1RHsbTEOxdTozcm874Qd6Y7HdggWWQND+g aX/UeELPTdScsOgh04LqVw6jkCbLfakDxCZPYk5psOlcHgrmc0XT9Q2k0USg33hGW9AZSkpG1Fe uccwazYC8QnG3ilb5t9eiMo6ug/bcx+VE3er4X/5J2Te8GMskv5pBwcTo5IshDY5q7eVCanx6OM pKeGIzoexAWiEKV138XYrTCkEREgxXtRfU71KSh+ugho+ETsFNEyJkIWpr7tmYXY+BsoDFFWHyP 2qxt19i3oYVgfVYAzmo8oFfYJrn+RWqiQfjR+gP9OzqxB6MMr2eziGq0JrxvXibpKf9Gi8roTaW 8uU+1Faal7UhQb/CdyLtM8guf3Cxe/nSLeJCcFOuAC0bblPlyq0Zgg= X-Received: by 2002:a05:6a00:32cd:b0:845:c7f1:29fa with SMTP id d2e1a72fcca58-84c29333c89mr11542970b3a.30.1784495587968; Sun, 19 Jul 2026 14:13:07 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2af30d0dsm4541562b3a.32.2026.07.19.14.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 14:13:07 -0700 (PDT) From: Rosen Penev To: linux-edac@vger.kernel.org Cc: Andre Przywara , Borislav Petkov , Tony Luck , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] EDAC/highbank_l2: manage dci lifetime via devres and simplify ioremap Date: Sun, 19 Jul 2026 14:13:05 -0700 Message-ID: <20260719211305.591496-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the open-coded platform_get_resource() + devm_request_mem_region() + devm_ioremap() sequence with the single helper devm_platform_ioremap_resource(), and move the platform_get_irq() calls earlier, dropping the redundant -ENODEV/-EBUSY/-ENOMEM error paths. (The previous open-coded resource check wrongly used IS_ERR() on platform_get_resource()'s NULL return, which would never trigger.) highbank_l2_err_probe() requests its interrupts with devm_request_irq(), passing dci as the handler context, but highbank_l2_err_remove() frees dci via edac_device_free_ctl_info() before devres releases the IRQs, leaving a use-after-free window in the shared interrupt handler. Register an edac_device_free_ctl_info() callback via devm_add_action_or_reset() right after edac_device_alloc_ctl_info() so dci is owned by devres and freed only after the IRQs are released. Drop the explicit edac_device_free_ctl_info() from both the probe error path and highbank_l2_err_remove(), and remove the now-redundant devres group open/close/release calls. Built for arm (CONFIG_EDAC_HIGHBANK) with LLVM=3D1; drivers/edac/highbank_l2_edac.o compiles cleanly and passes checkpatch --strict. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/edac/highbank_l2_edac.c | 67 +++++++++++++++------------------ 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/drivers/edac/highbank_l2_edac.c b/drivers/edac/highbank_l2_eda= c.c index 24f163ff323f..2436be7a32fe 100644 --- a/drivers/edac/highbank_l2_edac.c +++ b/drivers/edac/highbank_l2_edac.c @@ -45,85 +45,80 @@ static const struct of_device_id hb_l2_err_of_match[] = =3D { }; MODULE_DEVICE_TABLE(of, hb_l2_err_of_match); =20 +static void highbank_l2_edac_free(void *data) +{ + struct edac_device_ctl_info *dci =3D data; + + edac_device_free_ctl_info(dci); +} + static int highbank_l2_err_probe(struct platform_device *pdev) { const struct of_device_id *id; struct edac_device_ctl_info *dci; struct hb_l2_drvdata *drvdata; - struct resource *r; - int res =3D 0; + void __iomem *base; + int db_irq; + int sb_irq; + int res; + + base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(base)) + return PTR_ERR(base); + + db_irq =3D platform_get_irq(pdev, 0); + if (db_irq < 0) + return db_irq; + + sb_irq =3D platform_get_irq(pdev, 1); + if (sb_irq < 0) + return sb_irq; =20 dci =3D edac_device_alloc_ctl_info(sizeof(*drvdata), "cpu", 1, "L", 1, 2, 0); if (!dci) return -ENOMEM; =20 + if (devm_add_action_or_reset(&pdev->dev, highbank_l2_edac_free, dci)) + return -ENOMEM; + drvdata =3D dci->pvt_info; dci->dev =3D &pdev->dev; platform_set_drvdata(pdev, dci); =20 - if (!devres_open_group(&pdev->dev, NULL, GFP_KERNEL)) - return -ENOMEM; - - r =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) { - dev_err(&pdev->dev, "Unable to get mem resource\n"); - res =3D -ENODEV; - goto err; - } - - if (!devm_request_mem_region(&pdev->dev, r->start, - resource_size(r), dev_name(&pdev->dev))) { - dev_err(&pdev->dev, "Error while requesting mem region\n"); - res =3D -EBUSY; - goto err; - } - - drvdata->base =3D devm_ioremap(&pdev->dev, r->start, resource_size(r)); - if (!drvdata->base) { - dev_err(&pdev->dev, "Unable to map regs\n"); - res =3D -ENOMEM; - goto err; - } - id =3D of_match_device(hb_l2_err_of_match, &pdev->dev); dci->mod_name =3D pdev->dev.driver->name; dci->ctl_name =3D id ? id->compatible : "unknown"; dci->dev_name =3D dev_name(&pdev->dev); =20 if (edac_device_add_device(dci)) - goto err; + return 0; + + drvdata->base =3D base; + drvdata->db_irq =3D db_irq; + drvdata->sb_irq =3D sb_irq; =20 - drvdata->db_irq =3D platform_get_irq(pdev, 0); res =3D devm_request_irq(&pdev->dev, drvdata->db_irq, highbank_l2_err_handler, 0, dev_name(&pdev->dev), dci); if (res < 0) goto err2; =20 - drvdata->sb_irq =3D platform_get_irq(pdev, 1); res =3D devm_request_irq(&pdev->dev, drvdata->sb_irq, highbank_l2_err_handler, 0, dev_name(&pdev->dev), dci); if (res < 0) goto err2; =20 - devres_close_group(&pdev->dev, NULL); return 0; err2: edac_device_del_device(&pdev->dev); -err: - devres_release_group(&pdev->dev, NULL); - edac_device_free_ctl_info(dci); return res; } =20 static void highbank_l2_err_remove(struct platform_device *pdev) { - struct edac_device_ctl_info *dci =3D platform_get_drvdata(pdev); - edac_device_del_device(&pdev->dev); - edac_device_free_ctl_info(dci); } =20 static struct platform_driver highbank_l2_edac_driver =3D { --=20 2.55.0