From nobody Sat Jul 25 03:20:32 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 656C830CD82 for ; Sun, 19 Jul 2026 21:12:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784495562; cv=none; b=PeGQpwILE/rmvy3wFHlcSggAR8Zs/kty93YSAiVgHDMnTJc7TgHc5QcUACpsu+PWmbXjjVP1zqZHYYmB8iTIb3olM3Y7J16aT7hZTA0HTglicplL5Z/p3GjL3eocH/aclTwjtlRMmIvdsGOl87UCWkMNr/50hglSs76Y3HqqimQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784495562; c=relaxed/simple; bh=kski0H7sdbKvfS+ROd9mCLlYX8Xx1mFCSVlEBupSDN0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WYy4hukMvfHupQPNHqowsqALBde1V75yVdPZcKYL9CDm1BSIAJC6DvYJlOQy0msdV95fD7UyuvqwoL0nFHEE6gIoPuRfg2w0bGS6TQdsxcp5MzviAr68XWbtnybsY4ArLtU3+ZOftDqwhcnRBWqvt38pqPTbXgu7EcMEqxMczqs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ln4RSJhk; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ln4RSJhk" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ceb096e675so91376815ad.0 for ; Sun, 19 Jul 2026 14:12:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784495561; x=1785100361; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=gNHYVkmjlUEXhs1RgPaHE20c67yry/MBZs5gDBfneWw=; b=ln4RSJhkxIX+ZDB/GrAFeea/eGo1zQuzZVucCwL47P8XFGK24+QYZ1w7aYowXDQxA1 qpz2+hUDZdx1Q53upgvnVxu2KYcLcv9HZYgJ4RNUdzk/iexjU6ezHELMX3YEWmbAizPC X6TgonjlDICwQxieMs5SXZtIxtzYv7SoVTzYfkFzSORsU1to1aalEUl3sezGpeHLxBUW ZZhMvwIQFCtUaxavG/30V/wXjWZxOzW5Jv09u4is6bxIabizCWU53KAOt6hDpI5N0Yti PkilmRVlA6ZfK38mCQ1QM98w0OOSuO1Id5yGoZhSF4kZMocdeXSVI8FYsl0ofsX0x+uQ jTfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784495561; x=1785100361; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gNHYVkmjlUEXhs1RgPaHE20c67yry/MBZs5gDBfneWw=; b=bOLZx39Q6YtIJmD7fQMJNPGGsGu7IgtFgxCuu30SevGLKelxZS0rnYfmlyNpZ3TfIr cF9S9O4GTktungLoCDBYhy5MSLm4gvsUJS82fa9H5vFVknbtsPDup7bamhYwhAgv2/61 ALdw7N5C307gyLwuvntV+w88dus6DvwD7pnFBLgWDYPGXI4LTI44FIBXTno9/r2nvyq2 XjvGFZgWoYLW6ULGJuC9NoZ908BvWvaqI0tfAQhp3jkgN4nbzOadREgAylx4vVMee9/V LO42wBCeuIns4WQWSFWM27U90+cjtagXIYZT+iyJ/ZNBIr+R5nD8XACMaUz+cjKM3M5s DFdw== X-Forwarded-Encrypted: i=1; AHgh+RrYM0bGHyu+5MCFpG0QwjT0dS05zgCh13w+mwxHu8VmXXKZV75PKdNBv27dY4qb+SVnYbDCePfkbkgj8Dg=@vger.kernel.org X-Gm-Message-State: AOJu0YzQZ7Un+yz2TeeRqmCOC/i3L7Vy3hweHMGok0OLK3e7HXfRTssi hSz/fBIpSfb2kfnyT0mTFPQCnfm3zF08RxsOYphQyB6SRTkkKqi4zdoi X-Gm-Gg: AfdE7ckVebThKcwTp3bcQn66G7D1rNEqWL2kbNIO94xbFHSm4uvpTbsV0tT5Nk3PW50 rL9XraHZWdwxFShPFkBQZHlT/BTEcFaFJEkpM4nXWy68Wo6sbDUzEup+6EXbI4K2QjXWn4ygu26 vDUmX5GxYPT0ezUBFsDgADqB+h7Sml5PI2/aWjO5975ge9GLF2poUy3XVbz3J6V/8V1xy8IzPNs g8PxuoJwQ7ANZBOHDyqeh8U0aj0rF4R/ET0VNxCxk5kwswwjjZdVxmPQwC9Ab8fpAyzzSMR8jt9 PSSEBy43Fsgt/9+kRHXHOml81W2HTJVdRmzo6+iCj+FmlJbDTebRsCHKJYxIt8rZyeVq/tdniqw wmJKo7ymMp6O/97qxxuG9AegAeiP0/FxeKOFdn7rhSGaN/jW8r/gGhLcBZJaFIEzljGVmSWbwwO VrAM3hag/1O3qDcjX0EvZTtV8/+NCDs5PZs1/hEoG0hacd9CjSm2EXe8l4xNVQTdQI3A3rtq3Br Vr9WaMNIZn3eiHeEN0B7QY5jfe2VaVBulFoAH//t72voIWyfBIBUOY= X-Received: by 2002:a17:903:2ec5:b0:2cc:77f3:a927 with SMTP id d9443c01a7336-2cf34961e63mr147312725ad.26.1784495560785; Sun, 19 Jul 2026 14:12:40 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf3448ee77sm45106575ad.4.2026.07.19.14.12.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 14:12:40 -0700 (PDT) From: Rosen Penev To: linux-edac@vger.kernel.org Cc: Dinh Nguyen , Borislav Petkov , Tony Luck , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] EDAC/altera: manage dci lifetime via devres and simplify ioremap Date: Sun, 19 Jul 2026 14:12:38 -0700 Message-ID: <20260719211238.589402-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the open-coded platform_get_resource() + devm_request_mem_region() + devm_ioremap() sequence with the single helper devm_platform_ioremap_resource(), and move the platform_get_irq() calls earlier, dropping the redundant -ENODEV/-EBUSY/-ENOMEM error paths. Also drop the now-orphaned devres_close_group() call left in the success path after the devres group open/release calls were removed. altr_edac_device_probe() requests its interrupts with devm_request_irq(), passing dci as the handler context, but altr_edac_device_remove() frees dci via edac_device_free_ctl_info() before devres releases the IRQs, leaving a use-after-free window in the shared interrupt handler. Register an edac_device_free_ctl_info() callback via devm_add_action_or_reset() right after edac_device_alloc_ctl_info() so dci is owned by devres and freed only after the IRQs are released. Drop the explicit edac_device_free_ctl_info() from both the probe error path and altr_edac_device_remove(). Built for arm (CONFIG_EDAC_ALTERA) with LLVM=3D1; drivers/edac/altera_edac.o compiles cleanly and passes checkpatch --strict. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/edac/altera_edac.c | 76 ++++++++++++++++---------------------- 1 file changed, 31 insertions(+), 45 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 68846f583eee..1d0d3c99c91b 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -703,37 +703,37 @@ MODULE_DEVICE_TABLE(of, altr_edac_device_of_match); * Module specific initialization is done by passing the * function index in the device tree. */ + +static void altr_edac_device_free(void *data) +{ + struct edac_device_ctl_info *dci =3D data; + + edac_device_free_ctl_info(dci); +} + static int altr_edac_device_probe(struct platform_device *pdev) { struct edac_device_ctl_info *dci; struct altr_edac_device_dev *drvdata; - struct resource *r; + void __iomem *base; + int db_irq; + int sb_irq; int res =3D 0; struct device_node *np =3D pdev->dev.of_node; char *ecc_name =3D (char *)np->name; static int dev_instance; =20 - if (!devres_open_group(&pdev->dev, NULL, GFP_KERNEL)) { - edac_printk(KERN_ERR, EDAC_DEVICE, - "Unable to open devm\n"); - return -ENOMEM; - } + base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(base)) + return PTR_ERR(base); =20 - r =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) { - edac_printk(KERN_ERR, EDAC_DEVICE, - "Unable to get mem resource\n"); - res =3D -ENODEV; - goto fail; - } + sb_irq =3D platform_get_irq(pdev, 0); + if (sb_irq < 0) + return sb_irq; =20 - if (!devm_request_mem_region(&pdev->dev, r->start, resource_size(r), - dev_name(&pdev->dev))) { - edac_printk(KERN_ERR, EDAC_DEVICE, - "%s:Error requesting mem region\n", ecc_name); - res =3D -EBUSY; - goto fail; - } + db_irq =3D platform_get_irq(pdev, 1); + if (db_irq < 0) + return db_irq; =20 dci =3D edac_device_alloc_ctl_info(sizeof(*drvdata), ecc_name, 1, ecc_name, 1, 0, dev_instance++); @@ -741,20 +741,18 @@ static int altr_edac_device_probe(struct platform_dev= ice *pdev) if (!dci) { edac_printk(KERN_ERR, EDAC_DEVICE, "%s: Unable to allocate EDAC device\n", ecc_name); - res =3D -ENOMEM; - goto fail; + return -ENOMEM; } =20 + if (devm_add_action_or_reset(&pdev->dev, altr_edac_device_free, dci)) + return -ENOMEM; + drvdata =3D dci->pvt_info; dci->dev =3D &pdev->dev; platform_set_drvdata(pdev, dci); drvdata->edac_dev_name =3D ecc_name; =20 - drvdata->base =3D devm_ioremap(&pdev->dev, r->start, resource_size(r)); - if (!drvdata->base) { - res =3D -ENOMEM; - goto fail1; - } + drvdata->base =3D base; =20 /* Get driver specific data for this EDAC device */ drvdata->data =3D of_match_node(altr_edac_device_of_match, np)->data; @@ -763,44 +761,33 @@ static int altr_edac_device_probe(struct platform_dev= ice *pdev) if (drvdata->data->setup) { res =3D drvdata->data->setup(drvdata); if (res) - goto fail1; + return res; } =20 - drvdata->sb_irq =3D platform_get_irq(pdev, 0); + drvdata->sb_irq =3D sb_irq; res =3D devm_request_irq(&pdev->dev, drvdata->sb_irq, altr_edac_device_handler, 0, dev_name(&pdev->dev), dci); if (res) - goto fail1; + return res; =20 - drvdata->db_irq =3D platform_get_irq(pdev, 1); + drvdata->db_irq =3D db_irq; res =3D devm_request_irq(&pdev->dev, drvdata->db_irq, altr_edac_device_handler, 0, dev_name(&pdev->dev), dci); if (res) - goto fail1; + return res; =20 dci->mod_name =3D "Altera ECC Manager"; dci->dev_name =3D drvdata->edac_dev_name; =20 res =3D edac_device_add_device(dci); if (res) - goto fail1; + return res; =20 altr_create_edacdev_dbgfs(dci, drvdata->data); =20 - devres_close_group(&pdev->dev, NULL); - return 0; - -fail1: - edac_device_free_ctl_info(dci); -fail: - devres_release_group(&pdev->dev, NULL); - edac_printk(KERN_ERR, EDAC_DEVICE, - "%s:Error setting up EDAC device: %d\n", ecc_name, res); - - return res; } =20 static void altr_edac_device_remove(struct platform_device *pdev) @@ -810,7 +797,6 @@ static void altr_edac_device_remove(struct platform_dev= ice *pdev) =20 debugfs_remove_recursive(drvdata->debugfs_dir); edac_device_del_device(&pdev->dev); - edac_device_free_ctl_info(dci); } =20 static struct platform_driver altr_edac_device_driver =3D { --=20 2.55.0