From nobody Sat Jul 25 03:20:17 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 216812AE68 for ; Sun, 19 Jul 2026 21:11:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784495515; cv=none; b=oFZQ0DVmy5lHfNDkadnp/pRst2uQM3TrX7ziEf7AlITLlvlHA/isz1jYUSfiK8W+ru9Nv2Hxue+b33l0KmYiB1mfKZkApESx4nkk4kbF+iJYj0u+RfPuRbM9aJxwyyAdU203M9gr6jEoulGj+zsIqvrghhkT3/FFGEjQEat5K74= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784495515; c=relaxed/simple; bh=DOKnoD2ZG6zgxm9ONXHYuwTCKZ2S9eKZLkwhANYRJf0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BDvMuQ565EVgZ2WcnriwzOl4KpXew5JhvKj1svDcFhNz3jY6WCtqKFKZmZuxA7fDgQwuyi0US3xqYKfSSLeiNAxeRpV53F5ltJr6Z7RlzV5459K6gtRRygMjL/L3jlw6kWnYT9rGQWum5jmYTHqcGImsjfAQXSE5YVWknZws56k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j0wCRFjw; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j0wCRFjw" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38dfe910e9dso6411813a91.3 for ; Sun, 19 Jul 2026 14:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784495513; x=1785100313; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=gl8awQyGmjiKwuQWENOHzgNB58UOmcAca1xDTxmcvg8=; b=j0wCRFjwXQjxkONzfRzgu4jAto7cP8gjEGVeUeHvi2AUD/ORB5oMHJOnQHXVxEi55Z s3Yt33oysitKSk1w2u10hCIwLxP6AGNqpKFwfta2yhoi7cwcUYPfhqtNUHSDg5Vct4nb PUGp0YOrGddOjdjeQPed9brufE6EKSyAb7rAqj8KI+7/zm6eVoeMFgx38FCoiVUB78Kq W001AFShSp+jG2gYmaWaoXWjmYDBbxus3iw3liSLgD+e2zwGuQH8erhEwHZviQHtEcs/ ma3e9EJgCVkNF1SIJ7xL7tpThAifosxHm6JF59fK4N3oEjXiP7hSZYyGXq+r26Al7LHE rLLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784495513; x=1785100313; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gl8awQyGmjiKwuQWENOHzgNB58UOmcAca1xDTxmcvg8=; b=YqhoriH5LzxDwH+i/jyvYaXfbZvJmU7my5ZDOvvIgakWs7n6oLZfIVTH2Xh/4fPY1K ydxqWSfMNLOKJtMq0/fHTnkIVzM4goIgZrKZXB3oZRgetOJ9vSkWruxYe7+Nw1bADsCO GtdCTiIqgtmsZvWQ3JnT3TcEPCfdqCesoyCgpQUFoEAhHtW7O13ABVsc1nQBq63UbT/e LykNuVypiFxerYERjmIaVemwyGvaGRklXcDABiZC+rhgf68+jnN1qb3GudPjYu58AQc9 p0MbPaL630pp9/gS/Egxslj/5or7Az6pTpOpLHCM/s8PLRcL7oDfhxaftvI3O5kH7Tmc RQXQ== X-Forwarded-Encrypted: i=1; AHgh+Ro9kGVjyyUbeVhUy+t4haseYtbEW+Ec59yJZvm2g2rrs1Kub8SJJVC47AIPnEx3bVarpUpWWN/G2V9v+Z0=@vger.kernel.org X-Gm-Message-State: AOJu0YwDTW/sDc34EnKtofSSw14XuR0qIyg29W145XQWp9rQok8wytrE QW70DAtASrVGPVy9d6XnU3CiKlz+L6hboKJuklaTHDhejiPw694/8QnN X-Gm-Gg: AfdE7clLZ98wnccoV90rVGFeMALs8hUtDQehx0byxGiHeGbtbAd25LkU4Zsos0c9mSQ POOmgLRs5t+KA26kPzzEZPGZi5n8n6wBdsbK5F1Df8Ih9Vl3pUpsGqk7FNdtlTSxBg9rIa6rJ68 iKxjuPDSIVciFSeEu2Uo2XM+Gjz2KxYNs5+aacx3tu30bqSfNJmqGFoFnicdUxgXTjnQjzL6IYW FcEEsLjAIrqK/Kqu9xfkJtXKNTu/lW4MADFp2NM0hzmqTiUaUPMPavbNBIl9HjF80ROaINse//l j2iflE6EhWAeQljdcK5ZzVpkMUlH3Kx9GM9oxXy34tmdSiqTgIkI8xZKn+g2tkJ24ZEtBTRn7U6 2lUyRnzNjEqut72apwpzI4RY63u4Vg6Qu608SQmxg9V1f4g+v1g3fu4qx5cxH9BHyvh2e+kWo3a umIlfKK7SKp+s7qoSy+e0rNm75CLLqoh/YszEDlh/BZLcu0q/Z4kEnXe7a2EjYElqm5vYlPx/PB xLJ/1lWUBi0VwsNScCUWdUh4rmJPZv+pVJPRWCgIFnCSx2XuNc7dDs= X-Received: by 2002:a17:90b:58ee:b0:38d:56aa:6f32 with SMTP id 98e67ed59e1d1-38e4b588b44mr10793158a91.38.1784495513390; Sun, 19 Jul 2026 14:11:53 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e4b22bf63sm4614307a91.15.2026.07.19.14.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 14:11:52 -0700 (PDT) From: Rosen Penev To: linux-edac@vger.kernel.org Cc: Khuong Dinh , Borislav Petkov , Tony Luck , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] EDAC/xgene: use devm_platform_ioremap_resource in probe Date: Sun, 19 Jul 2026 14:11:50 -0700 Message-ID: <20260719211150.585626-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the open-coded platform_get_resource() + devm_ioremap_resource() pair in xgene_edac_probe() with the single helper devm_platform_ioremap_resource(), fetching the PCP CSR mapping up front and assigning it to edac->pcp_csr after the edac context is allocated. The redundant struct resource and the late re-ioremap are dropped. Built for arm64 (CONFIG_EDAC_XGENE) with LLVM=3D1; drivers/edac/xgene_edac.o compiles cleanly and passes checkpatch --strict. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/edac/xgene_edac.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c index 9955396c9a52..92d1f15bdf30 100644 --- a/drivers/edac/xgene_edac.c +++ b/drivers/edac/xgene_edac.c @@ -1844,9 +1844,13 @@ static int xgene_edac_probe(struct platform_device *= pdev) { struct xgene_edac *edac; struct device_node *child; - struct resource *res; + void __iomem *pcp_csr; int rc; =20 + pcp_csr =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(pcp_csr)) + return PTR_ERR(pcp_csr); + edac =3D devm_kzalloc(&pdev->dev, sizeof(*edac), GFP_KERNEL); if (!edac) return -ENOMEM; @@ -1902,13 +1906,7 @@ static int xgene_edac_probe(struct platform_device *= pdev) edac->rb_map =3D NULL; } =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - edac->pcp_csr =3D devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(edac->pcp_csr)) { - dev_err(&pdev->dev, "no PCP resource address\n"); - rc =3D PTR_ERR(edac->pcp_csr); - goto out_err; - } + edac->pcp_csr =3D pcp_csr; =20 if (edac_op_state =3D=3D EDAC_OPSTATE_INT) { int irq; --=20 2.55.0