From nobody Sat Jul 25 03:46:49 2026 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6C4138D3F8 for ; Sun, 19 Jul 2026 14:09:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784470177; cv=none; b=HDSGRzrTAXo+FizKMSx6JuclER/Ndt+obp5IaVru7DohkQw5kO9oCWFs2k/raHc/uAk7GGbWozRMk/srvWvnY2HKWHXrgsMXazliaRVu3gopbwNizQc+1tX+gNLLy9EDTXI3pEOtZWfyd0YOGNnBSUiniBkhH3L0KvbpG8Pao0g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784470177; c=relaxed/simple; bh=VyoYZX2D8OpDlEMmDS96qc0SFFUHyp553K5Y3reG7BU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qVoxDgNubal7GmmH//knypzM2edW0XSdjXLVEyie+FtK2uzBHzfe7L8/uLkiPjhSRIIAXnUJcGHbqp5/bHemqN+M7FxJPgDqDlm19Hch9kdPNK+GHiAKZvYqEgqxxBMzH7Z1/5s/GiiWNBwrH9tKvmwUbAKl7PiJGbzyv5H/X9s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kYJSSaGB; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kYJSSaGB" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-ca957432c7fso6408576a12.1 for ; Sun, 19 Jul 2026 07:09:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784470176; x=1785074976; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/VsDwgGBi6jRNk4FQjDctfybeowX+5DSAIGnbjWlZPo=; b=kYJSSaGBOHv5hVaMNYe/m8Whq5DhxMbYr2RmTOU1BZjYOEHgU6/aM4Bqla0SZNzhnm MEdJj4i5Bb7Igq3YjAFV8Gop9+G187AxgywRsmkQIgWYO886KJ2FNazcmxGz97bFgoXM Z0Y0mo/VCYv3quymJk06JnpYhJbi/E2AAdX+CwXRlK+wFyTtVYUJ9aBPzmEarw3RWZtt gc83vwjfy6W9ohacCgeU0Z8c4p3+NqlL/suNuT+rX8dus8QgxRUbghZdntVJ9+6FccYa tRBJaq4Ysnv+VXtpihuvXcYdJ/JsohudYk0mFazTR9To8pxDUzq3dZgjNB9nPyYEGEcV I0XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784470176; x=1785074976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/VsDwgGBi6jRNk4FQjDctfybeowX+5DSAIGnbjWlZPo=; b=bAINS/Y+oo+aRN5hbPOC8VEfAO2s/lresChU0Q6fe6eNM51KPx7iZnofocHkYZxDh5 V7Y5rGiT+aiCx9LPIjiEiBrU2QS2zlq5B1mvENO4lX3YdnAuXlhlEVGzrPyL4jIpzpb6 6/ew96gKkE4ucCN4dxk3TT2lEB55zzFiV+Lid0G+pqVx5d14qYyX9E+7S9FR/S6aJKVs JmZqfC/T1y2pcIUWqpA6VryZ4KOJY/EbIippYGAhZ9JafIpAUUlVuUQA7scuQaM5Fh0I ZHf5Ub6GA2iMLU6WATRn7BWHVgAkX2AiIePXRqsBXp0JiTh5QIbvp3igKR4eMpLWsaPD CNlQ== X-Forwarded-Encrypted: i=1; AHgh+Roett4W7vmciQN704zP6FHGPtUvP190iWLTLCS0ssXDCEEKIRNDDLxJTjq9qSgRzoysCNgpi4xUO0yINsU=@vger.kernel.org X-Gm-Message-State: AOJu0YxsLESZPA9MLlWb48Ib+jLiLas3iisLttnu3M+V1ADXRJKHkMly iOICvJRqPVF38CbozDf5qdzV/n7KCBEvzB/Hyl8zV8npWONfVEJB/CU1 X-Gm-Gg: AfdE7cmYlVjW0ewwA1zbAbeMn03Cj2PPkrDDIMjJvWLYGOUQNB1+TS+/w5SuyfRIZJd 0sSsWO07rppL3mAPb2Pn6etIvlDzOuPz1szTSm1BN2phbI5U4iV+X+ki7hAR5V44x4E8XM7jcrW tObk1GKdYVRkRWOQJph0DYFhJCCQA5u62SVBD5SvYxryqH+1xVlOFNmy8DH4i6JpxsMKZSnliKy 6l1ENi+9+GfkFZx+q61cfimXeTVRu9JCuVH2dfgN4pZgLzMMz3WyLpXEJeuH+nPuns6cI+DKU8h GQRS6C61F73uWcdLOsLdRhBvuabdyRqy63Ys1V1fvV404sWtK92TopkxBC55U6TeYXtpsPoCxQN JAnt/PO4jRT2LNLdidON7K3hCNHoC2saiebtVa/6Qs/zHaqc09X+m2qeDIh5jPDdp3uMgpKTmqx d9ZlTZV8YXw03l1fAe8sFLPDhvH6TEl8KVk5lihTgQdzcOPw== X-Received: by 2002:a05:6a20:9397:b0:3bf:82c5:ed13 with SMTP id adf61e73a8af0-3c3ad8eccf3mr10908276637.38.1784470175969; Sun, 19 Jul 2026 07:09:35 -0700 (PDT) Received: from UbuntuOS.. ([49.34.211.33]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a20bf96sm26738331eec.28.2026.07.19.07.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 07:09:35 -0700 (PDT) From: Prajval Chaudhary To: Hans de Goede , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: Andy Shevchenko , Sakari Ailus , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Prajval Chaudhary Subject: [PATCH 1/2] staging: media: atomisp: Remove unused and unwanted debug module parameters Date: Sun, 19 Jul 2026 19:33:49 +0530 Message-Id: <20260719140350.8266-2-prajvalchaudhari733@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260719140350.8266-1-prajvalchaudhari733@gmail.com> References: <20260719140350.8266-1-prajvalchaudhari733@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the unused module parameters 'dbg_level' and 'dbg_func'. Additionally, remove the 'pad_w' and 'pad_h' module parameters to prevent userspace from overriding internal ISP hardware padding boundaries, leaving them as internal driver constants. This addresses the 'Remove unnecessary/unwanted module parameters' task in the driver's TODO file. Signed-off-by: Prajval Chaudhary --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/sta= ging/media/atomisp/pci/atomisp_v4l2.c index 812230397409..5c2f5996a03f 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -44,17 +44,6 @@ /* G-Min addition: pull this in from intel_mid_pm.h */ #define CSTATE_EXIT_LATENCY_C1 1 =20 -/* cross component debug message flag */ -int dbg_level; -module_param(dbg_level, int, 0644); -MODULE_PARM_DESC(dbg_level, "debug message level (default:0)"); - -/* log function switch */ -int dbg_func =3D 1; -module_param(dbg_func, int, 0644); -MODULE_PARM_DESC(dbg_func, - "log function switch non/printk (default:printk)"); - /* * Set to 16x16 since this is the amount of lines and pixels the sensor * exports extra. If these are kept at the 10x8 that they were on, in yuv @@ -65,12 +54,8 @@ MODULE_PARM_DESC(dbg_func, * the chosen solution is the next best thing. */ int pad_w =3D 16; -module_param(pad_w, int, 0644); -MODULE_PARM_DESC(pad_w, "extra data for ISP processing"); =20 int pad_h =3D 16; -module_param(pad_h, int, 0644); -MODULE_PARM_DESC(pad_h, "extra data for ISP processing"); =20 /* * FIXME: this is a hack to make easier to support ISP2401 variant. --=20 2.34.1 From nobody Sat Jul 25 03:46:49 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7192390222 for ; Sun, 19 Jul 2026 14:09:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784470185; cv=none; b=RIxsxBbN68BMak/eote24Nd+FRZsh3s2xmfBoFFb96dx1Kgt5wNJv/qDWneaKYfq4phBBoiyyxMfE6TObFBvPYCiztIZ4kTZHX7sfXafLnM6IcLx+X4qphZH51fpaCRhegx1ZQapfGJU43u3ntOEtWTzWLwb2/KB4iqlStDUITA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784470185; c=relaxed/simple; bh=JT5pBunVOED5YNd5Y/C35r+p54dGIHbbwJ/3rtqdFAc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iWLKFvM9nB3UcEOkB6WzJfIznFFhtyO+IW5FaqyNb7XHEqP/rYG4BkMxzKqLV+WtkJyraAcTkD5wCkuBrMcAgRhxzGHNfRAazW63bOs9+wAn+5Fl3HqwdRN3wy1Ma8fEJoN9hpFJNnxwiZx+auxCzjkYiCOe6Ca2O+sT574Qvr0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gulyygag; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gulyygag" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-ca7bea5e5b3so6627637a12.1 for ; Sun, 19 Jul 2026 07:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784470183; x=1785074983; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BvODTp626G7ayt7G642HB6l/p2dvUiPvXuiviwmOFoA=; b=gulyygagGZPmOKgsvLvfd089hgzymNc9NRLzUl0APKjO9Of0YZzzK/Xqzwrx0lnEbQ PNOy6xMaVsIkhBYX6N3+TvnaJYa2NUgeI7uDB7IE6zwGLx+wYrhYP2BttVkfhqdaGS2Z xoVUpdDQzOQKiGRa0Fgl6Oy8ViJgOedA8IFMIyHs6R0e6J4VG47QJnmnmHQ2BbjdtBw5 txfUe2X/Ghy+bkmwsY/yC29oPdX+zP3Mk+bJWDGdC9SMQOvo2f0hFmJwxx2es429dbOn IjW9QivT9PFTJt6sJsJkOHCucHw8F8CTVz716rz9UMiHxfO8/FhGZ6Ox4XIMl2MfUg3d kp1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784470183; x=1785074983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BvODTp626G7ayt7G642HB6l/p2dvUiPvXuiviwmOFoA=; b=EHAvEE5fLu69dbyjCqbIS0QIguTNyE4rhdZLOvztt3Y1ncldiYYKDWZox53RzRWm/L THnYAXpBQ6B99HSEpBf8q0+T6aDXfRo/Aauh+Hltz6bn86Q5+ATepawHjK86mxII8sMG IQItWhp38cggeItHszDcJStqYvVnTcnl/HLvZKmSdX/hcSIaL4wMGtJPSaRd1Cxwj8aV 8vF9q/ZzXE1Lf6w8r3qJdZ2Q+W0VUYJbnPV9GQZCWwOq6G0OsJh/KVNTFeu25Xlitwbp Nqhts3wFh0CUePUXSwk8BNHnSf1QRwhd42shgvH9PXZL6epBeOL0Sm0RsMf19qRWnH8M stkw== X-Forwarded-Encrypted: i=1; AHgh+Rq6okk9qq0NX89MISZu2Ey3rbkjJx3rBJTtqZ7GCkWpoeJITuzM2uP/J3f28FdNYjEsE1nDhmR5VHOsLNw=@vger.kernel.org X-Gm-Message-State: AOJu0YxUCVSVrstTB1OtPGituwDJ5DLHtvzwJmdfQjmTUH1NVIGVayf2 6coQk9L1lr+bBaNe5CQDIkuvhQ0Kp5DscFhK1tvc2GfIMR2B5moxl7ld X-Gm-Gg: AfdE7ckJgoygMz44fY1ca9y+TKLZorfdAvZVkV5s2Yqxe6cr2y4C3nJP5uVqZUy2aiE 2N/VJesTQraaFF+fBM68iF7Hg7PARdg3XZd6cufPGSTqS3j3NWlhbGXb+VvQw3imowRHcvNj3Mr uhrZrc/2TCofZzN15xx4AYpECS1EUWywl6KDvUYhH1zX/GG/igBs0lBHN9oH3ZzpJQ43gFE/AJO H2/QLHFdWcM0/xTHdb6KP2ALKsxfoilBKU22SmtNIfu2i1+C0r2p/BrJdgQsnQs1TPV7L6+sxZi d4DnAkg3Z+eh9WYapcKkYiwrA6fPDve54T7IRTmHQ49YL9PCFE95bwMYhxCTngORmkOoVU60XsD Y4PPuJRUhxlRTZpkyneEPJCgo+xhU38wqUWmP7UHYGHka01f+RWtoXXucHvVdS61wn5o8IxzZTv +nP/BdYmtbgjZ5ny6aJoEqjvD0 X-Received: by 2002:a05:6a21:7d06:b0:3bf:e24e:3afe with SMTP id adf61e73a8af0-3c3ad949d5dmr11182254637.43.1784470183117; Sun, 19 Jul 2026 07:09:43 -0700 (PDT) Received: from UbuntuOS.. ([49.34.211.33]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a20bf96sm26738331eec.28.2026.07.19.07.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 07:09:42 -0700 (PDT) From: Prajval Chaudhary To: Hans de Goede , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: Andy Shevchenko , Sakari Ailus , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Prajval Chaudhary Subject: [PATCH 2/2] staging: media: atomisp: Mark pad_w and pad_h as const constants Date: Sun, 19 Jul 2026 19:33:50 +0530 Message-Id: <20260719140350.8266-3-prajvalchaudhari733@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260719140350.8266-1-prajvalchaudhari733@gmail.com> References: <20260719140350.8266-1-prajvalchaudhari733@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now that the user-facing module parameters for pad_w and pad_h have been removed, these variables are strictly internal driver configurations. Mark them as const to prevent accidental runtime modification and allow compiler optimization. This completes the internal cleanup follow-up resulting from addressing the driver's module parameter TODO item. Signed-off-by: Prajval Chaudhary --- drivers/staging/media/atomisp/pci/atomisp_common.h | 6 ++---- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_common.h b/drivers/s= taging/media/atomisp/pci/atomisp_common.h index a2462fc306fb..aa230c3708dd 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_common.h +++ b/drivers/staging/media/atomisp/pci/atomisp_common.h @@ -20,10 +20,8 @@ =20 #include "ia_css.h" =20 -extern int dbg_level; -extern int dbg_func; -extern int pad_w; -extern int pad_h; +extern const int pad_w; +extern const int pad_h; =20 /* Minimum padding requirements for ISP2400 (BYT) */ #define ISP2400_MIN_PAD_W 12 diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/sta= ging/media/atomisp/pci/atomisp_v4l2.c index 5c2f5996a03f..5ca7e79fd1e5 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -53,9 +53,9 @@ * output res, and isp output res. however since we do not have this yet, * the chosen solution is the next best thing. */ -int pad_w =3D 16; +const int pad_w =3D 16; =20 -int pad_h =3D 16; +const int pad_h =3D 16; =20 /* * FIXME: this is a hack to make easier to support ISP2401 variant. --=20 2.34.1