From nobody Sat Jul 25 03:45:45 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA49E390CAD for ; Sun, 19 Jul 2026 11:56:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784462208; cv=none; b=YQQUoA1Ggn0aIsV9AAEdP07rdxsq55VM++8NwnrQ6Y0QEs+xYgwJ2Ljs4AGnQsO2LYAYCTh5g4U2M7Wc+wh244LlTFnniTa8wRqFJGZpMpNF2XzABrtfqvVc6eO2ZJR2sLukFKfMEVyHl6mc78FbCqp3Gdt5YsXmbzS00Yj/d2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784462208; c=relaxed/simple; bh=OSjl4EX/3fDrkQvG1N0m9s/1XtrtQQCpeffXTsvZW1E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k6VOviXT9o91HR//zDugQnT3f+K6X2BZpPr1M7DRt+6PKriFout0cnFm0SVP9p3idYwFr93eEHx8lQQGOxVSzaeXJDQ1NB19XPsUncVAaK4F7levMXPDImsZBInP5viTpoEsK6pKCNOtQXSGDHHt7YnJYYth8pWV138/V5wchY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k4Jn3QlA; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k4Jn3QlA" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-495590ba856so3463915e9.2 for ; Sun, 19 Jul 2026 04:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784462204; x=1785067004; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6AGiODBO1Z6yEmoanwrRsQvRkT2fbNTWXorZsTOj6so=; b=k4Jn3QlAFNulb2nDe7VOsppIoxr90pJynMrRZWoCP1NFg+u8vHxcmNpmmL0wvQ7Uow k/PIaABTejBME1Wm2eysiKerHLoWPLq+SDfMkogIH2vjfHbFRhgwp0OtFAL6VUpXG3to 3pFu7VkwIbwofUmHcZtfzXHDERqsV01u+m4NH3DoXMsgMW73FQno+nPyqAYa5rsfl77i dfDIsdry9ZkV4xCdV+pl9B1pJLB4DvYu/9p1+zy8vymq0sMDpiz+vFFkMAvjVL9CpPIz PHqlQ6JLHwIL77aO12gtd3fa5n//V568/ASJgvC/saSaOIy3Xf/pq6NxIUYy0TBQog5/ 2Lpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784462204; x=1785067004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6AGiODBO1Z6yEmoanwrRsQvRkT2fbNTWXorZsTOj6so=; b=bV59UYgzZu+hT0NGqZpo9ZhCaQlI4AJoUCwCdbntiPLHROUD1Up9noP+IcsgXNP6Dj vWUFkKpF6zMtxP+lhegvYQe52LS7UiX304gEl1+L2VXrzYfCtc6R092LnRcd3LtySJAv TurX5FiHk+hyZbnFB2nkxm+E58gXrXsZVnsSj6q62sw3fKecXk10S3dzDy+k0LHW9OUQ PDBPGebEpkVej925BDHn4iDSRBH7qeHuZ1N4TfXSulclw3MB54hNv1fdNEQB8JYl0dS9 SuiNVCQQ9hD1B1aPbM0WTXndQA4pXKRklGNp792yeC2nIa7cRMFIcY/KBpcSuAr1joZb /Mvg== X-Forwarded-Encrypted: i=1; AHgh+Ro8wqEVFhqzq6gXZW3zthSxG3DmWOSauOTdhP563ZJELSX89KWB/HSjdiScdXEeasNHCn6BklXwgUkNnqI=@vger.kernel.org X-Gm-Message-State: AOJu0YxQhas47d+ExMFO+ZkoRFjYzXYjOxvJh32GSz78xDc7sAQA2LBx U/CL0ALHiArYLPCIWjySBsb54+6oHct2EKKf6cCrpoMHGRIwE8l7Snj3/HBN1aKLFJw= X-Gm-Gg: AfdE7cksJo+sGd/1roE7iZPzZBTmOmNtRNV/C5x9MJaSmqQtX8T5BxKSjJ9mGpdJ14l 3TYU2hG7BtUd0ye3hgY6VELkokVW0itKRy5R/NBK+HqQp1ig+acPNXvcA5jBqaX3RIPkS6lv8wH pZXWzAqyQnan8T9gNi4yrMRiWPw6noQnFKI4i6zZWkx93zGEu0rI4mjO87kRuBJwht8dwiNiwWj I6ltijggo7BWJC0gb3ijJhJiRU/nrceMUde5F39Mmw/9ydLzpOYcIyA0b43vzoUuZVIQq8gEqSq u7f5kcooCwJ0sqxxLpRI4H/jopbqlI/23GIzRwro/JzqkVDYdvvjqqHjKev6YjpA1liwEHmWDD/ fWeeVnpHCRbGM9WkTXNi4QcIi4hdt3E5/kSnIV1G/qX8pxe4duMpJSNsru+wtJZZ4H8iDxup1KF aI5H6siVoocch85c4ZBib/5M/xNcwZy1+CJ+cHa79wCy4blAZ4PZu8P4fnvzwT+jmiDyA= X-Received: by 2002:a05:600c:5247:b0:495:573e:1c54 with SMTP id 5b1f17b1804b1-495573e1da1mr41005745e9.9.1784462203846; Sun, 19 Jul 2026 04:56:43 -0700 (PDT) Received: from koolguy.fritz.box (dslb-088-074-245-227.088.074.pools.vodafone-ip.de. [88.74.245.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49549a35830sm199719265e9.3.2026.07.19.04.56.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 04:56:43 -0700 (PDT) From: Dalvin-Ehinoma Noah Aiguobas To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dalvin-Ehinoma Noah Aiguobas Subject: [PATCH 1/3] staging: rtl8723bs: remove unnecessary whitespace Date: Sun, 19 Jul 2026 11:54:49 +0000 Message-ID: <20260719115451.4401-2-fliegbert2@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260719115451.4401-1-fliegbert2@gmail.com> References: <20260719115451.4401-1-fliegbert2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unnecessary whitespace to improve readability and coding style consistency. No functional changes are intended in this patch. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 154 +++++++++--------- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- .../staging/rtl8723bs/include/wlan_bssdef.h | 56 +++---- 3 files changed, 106 insertions(+), 106 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 7a232daf5c56..cd6c7cbade9b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -39,13 +39,13 @@ static void rtw_init_mlme_timer(struct adapter *padapte= r) _rtw_set_scan_deny_timer_hdl, 0); } =20 -int rtw_init_mlme_priv(struct adapter *padapter) +int rtw_init_mlme_priv(struct adapter *padapter) { - int i; + int i; u8 *pbuf; - struct wlan_network *pnetwork; - struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - int res =3D _SUCCESS; + struct wlan_network *pnetwork; + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + int res =3D _SUCCESS; =20 pmlmepriv->nic_hdl =3D (u8 *)padapter; =20 @@ -137,9 +137,9 @@ void _rtw_free_mlme_priv(struct mlme_priv *pmlmepriv) } } =20 -struct wlan_network *rtw_alloc_network(struct mlme_priv *pmlmepriv) +struct wlan_network *rtw_alloc_network(struct mlme_priv *pmlmepriv) { - struct wlan_network *pnetwork; + struct wlan_network *pnetwork; struct __queue *free_queue =3D &pmlmepriv->free_bss_pool; struct list_head *plist =3D NULL; =20 @@ -167,7 +167,7 @@ struct wlan_network *rtw_alloc_network(struct mlme_priv= *pmlmepriv) return pnetwork; } =20 -void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *p= network, u8 isfreeall) +void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *p= network, u8 isfreeall) { unsigned int delta_time; u32 lifetime =3D SCANQUEUE_LIFETIME; @@ -198,7 +198,7 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, str= uct wlan_network *pnetwor spin_unlock_bh(&free_queue->lock); } =20 -void _rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_net= work *pnetwork) +void _rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_net= work *pnetwork) { struct __queue *free_queue =3D &pmlmepriv->free_bss_pool; =20 @@ -220,8 +220,8 @@ void _rtw_free_network_nolock(struct mlme_priv *pmlmepr= iv, struct wlan_network * */ struct wlan_network *_rtw_find_network(struct __queue *scanned_queue, u8 *= addr) { - struct list_head *phead, *plist; - struct wlan_network *pnetwork =3D NULL; + struct list_head *phead, *plist; + struct wlan_network *pnetwork =3D NULL; =20 if (is_zero_ether_addr(addr)) { pnetwork =3D NULL; @@ -319,9 +319,9 @@ void rtw_free_network_nolock(struct adapter *padapter, = struct wlan_network *pnet * * Shall be called under atomic context... to avoid possible racing condit= ion... */ -struct wlan_network *rtw_find_network(struct __queue *scanned_queue, u8 *a= ddr) +struct wlan_network *rtw_find_network(struct __queue *scanned_queue, u8 *a= ddr) { - struct wlan_network *pnetwork =3D _rtw_find_network(scanned_queue, addr); + struct wlan_network *pnetwork =3D _rtw_find_network(scanned_queue, addr); =20 return pnetwork; } @@ -385,12 +385,12 @@ struct wlan_network *_rtw_find_same_network(struct __= queue *scanned_queue, struc return found; } =20 -struct wlan_network *rtw_get_oldest_wlan_network(struct __queue *scanned_q= ueue) +struct wlan_network *rtw_get_oldest_wlan_network(struct __queue *scanned_q= ueue) { - struct list_head *plist, *phead; + struct list_head *plist, *phead; =20 - struct wlan_network *pwlan =3D NULL; - struct wlan_network *oldest =3D NULL; + struct wlan_network *pwlan =3D NULL; + struct wlan_network *oldest =3D NULL; =20 phead =3D get_list_head(scanned_queue); =20 @@ -467,12 +467,12 @@ static void update_current_network(struct adapter *ad= apter, struct wlan_bssid_ex /* Caller must hold pmlmepriv->lock first. */ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid= _ex *target) { - struct list_head *plist, *phead; + struct list_head *plist, *phead; u32 bssid_ex_sz; struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; - struct __queue *queue =3D &pmlmepriv->scanned_queue; - struct wlan_network *pnetwork =3D NULL; - struct wlan_network *oldest =3D NULL; + struct __queue *queue =3D &pmlmepriv->scanned_queue; + struct wlan_network *pnetwork =3D NULL; + struct wlan_network *oldest =3D NULL; int target_find =3D 0; u8 feature =3D 0; =20 @@ -632,11 +632,11 @@ static bool rtw_is_desired_network(struct adapter *ad= apter, struct wlan_network return bselected; } =20 -void rtw_survey_event_callback(struct adapter *adapter, u8 *pbuf) +void rtw_survey_event_callback(struct adapter *adapter, u8 *pbuf) { u32 len; struct wlan_bssid_ex *pnetwork; - struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 pnetwork =3D (struct wlan_bssid_ex *)pbuf; =20 @@ -675,9 +675,9 @@ void rtw_survey_event_callback(struct adapter *adapter,= u8 *pbuf) spin_unlock_bh(&pmlmepriv->lock); } =20 -void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) +void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) { - struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 spin_lock_bh(&pmlmepriv->lock); if (pmlmepriv->wps_probe_req_ie) { @@ -704,7 +704,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else { u8 ret =3D _SUCCESS; - struct wlan_bssid_ex *pdev_network =3D &adapter->registrypriv.dev_= network; + struct wlan_bssid_ex *pdev_network =3D &adapter->registrypriv.dev_net= work; u8 *pibss =3D adapter->registrypriv.dev_network.mac_address; =20 /* pmlmepriv->fw_state ^=3D _FW_UNDER_SURVEY;because don't set assoc_= timer */ @@ -782,11 +782,11 @@ void rtw_fwdbg_event_callback(struct adapter *adapter= , u8 *pbuf) { } =20 -static void free_scanqueue(struct mlme_priv *pmlmepriv) +static void free_scanqueue(struct mlme_priv *pmlmepriv) { struct __queue *free_queue =3D &pmlmepriv->free_bss_pool; struct __queue *scan_queue =3D &pmlmepriv->scanned_queue; - struct list_head *plist, *phead, *ptemp; + struct list_head *plist, *phead, *ptemp; =20 spin_lock_bh(&scan_queue->lock); spin_lock_bh(&free_queue->lock); @@ -808,7 +808,7 @@ static void free_scanqueue(struct mlme_priv *pmlmepriv) static void find_network(struct adapter *adapter) { struct wlan_network *pwlan =3D NULL; - struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; struct wlan_network *tgt_network =3D &pmlmepriv->cur_network; =20 pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->networ= k.mac_address); @@ -825,14 +825,14 @@ static void find_network(struct adapter *adapter) /* rtw_free_assoc_resources: the caller has to lock pmlmepriv->lock */ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_qu= eue) { - struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; struct wlan_network *tgt_network =3D &pmlmepriv->cur_network; =20 if (check_fwstate(pmlmepriv, WIFI_STATION_STATE | WIFI_AP_STATE)) { struct sta_info *psta; =20 psta =3D rtw_get_stainfo(&adapter->stapriv, tgt_network->network.mac_add= ress); - rtw_free_stainfo(adapter, psta); + rtw_free_stainfo(adapter, psta); } =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE | WIFI_ADHOC_MASTER_STATE |= WIFI_AP_STATE)) { @@ -954,7 +954,7 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str =20 if (psta) { /* update ptarget_sta */ =20 - psta->aid =3D pnetwork->join_res; + psta->aid =3D pnetwork->join_res; =20 update_sta_info(padapter, psta); =20 @@ -1024,10 +1024,10 @@ static struct sta_info *rtw_joinbss_update_stainfo(= struct adapter *padapter, str =20 /* pnetwork : returns from rtw_joinbss_event_callback */ /* ptarget_wlan: found from scanned_queue */ -static void rtw_joinbss_update_network(struct adapter *padapter, struct wl= an_network *ptarget_wlan, struct wlan_network *pnetwork) +static void rtw_joinbss_update_network(struct adapter *padapter, struct wl= an_network *ptarget_wlan, struct wlan_network *pnetwork) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct wlan_network *cur_network =3D &pmlmepriv->cur_network; + struct wlan_network *cur_network =3D &pmlmepriv->cur_network; =20 /* why not use ptarget_wlan?? */ memcpy(&cur_network->network, &pnetwork->network, pnetwork->network.lengt= h); @@ -1073,7 +1073,7 @@ static void rtw_joinbss_update_network(struct adapter= *padapter, struct wlan_net rtw_update_ht_cap(padapter, cur_network->network.ies, cur_network->networ= k.ie_length, (u8) cur_network->network.configuration.ds_config); } =20 -static struct rt_pmkid_list backupPMKIDList[NUM_PMKID_CACHE]; +static struct rt_pmkid_list backupPMKIDList[NUM_PMKID_CACHE]; void rtw_reset_securitypriv(struct adapter *adapter) { u8 backupPMKIDIndex =3D 0; @@ -1141,12 +1141,12 @@ void rtw_reset_securitypriv(struct adapter *adapter) void rtw_joinbss_event_prehandle(struct adapter *adapter, u8 *pbuf) { struct sta_info *ptarget_sta =3D NULL, *pcur_sta =3D NULL; - struct sta_priv *pstapriv =3D &adapter->stapriv; - struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; - struct wlan_network *pnetwork =3D (struct wlan_network *)pbuf; - struct wlan_network *cur_network =3D &pmlmepriv->cur_network; - struct wlan_network *pcur_wlan =3D NULL, *ptarget_wlan =3D NULL; - unsigned int the_same_macaddr =3D false; + struct sta_priv *pstapriv =3D &adapter->stapriv; + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; + struct wlan_network *pnetwork =3D (struct wlan_network *)pbuf; + struct wlan_network *cur_network =3D &pmlmepriv->cur_network; + struct wlan_network *pcur_wlan =3D NULL, *ptarget_wlan =3D NULL; + unsigned int the_same_macaddr =3D false; =20 the_same_macaddr =3D !memcmp(pnetwork->network.mac_address, cur_network->= network.mac_address, ETH_ALEN); =20 @@ -1248,7 +1248,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) =20 void rtw_joinbss_event_callback(struct adapter *adapter, u8 *pbuf) { - struct wlan_network *pnetwork =3D (struct wlan_network *)pbuf; + struct wlan_network *pnetwork =3D (struct wlan_network *)pbuf; =20 mlmeext_joinbss_event_callback(adapter, pnetwork->join_res); =20 @@ -1271,9 +1271,9 @@ void rtw_stassoc_event_callback(struct adapter *adapt= er, u8 *pbuf) { struct sta_info *psta; struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; - struct stassoc_event *pstassoc =3D (struct stassoc_event *)pbuf; - struct wlan_network *cur_network =3D &pmlmepriv->cur_network; - struct wlan_network *ptarget_wlan =3D NULL; + struct stassoc_event *pstassoc =3D (struct stassoc_event *)pbuf; + struct wlan_network *cur_network =3D &pmlmepriv->cur_network; + struct wlan_network *ptarget_wlan =3D NULL; =20 if (!rtw_access_ctrl(adapter, pstassoc->macaddr)) return; @@ -1365,8 +1365,8 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) struct wlan_network *pwlan =3D NULL; struct wlan_bssid_ex *pdev_network =3D NULL; u8 *pibss =3D NULL; - struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; - struct stadel_event *pstadel =3D (struct stadel_event *)pbuf; + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; + struct stadel_event *pstadel =3D (struct stadel_event *)pbuf; struct wlan_network *tgt_network =3D &pmlmepriv->cur_network; struct mlme_ext_priv *pmlmeext =3D &adapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; @@ -1435,7 +1435,7 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { - rtw_free_stainfo(adapter, psta); + rtw_free_stainfo(adapter, psta); =20 if (adapter->stapriv.asoc_sta_count =3D=3D 1) {/* a sta + bc/mc_stainfo = (not Ibss_stainfo) */ u8 ret =3D _SUCCESS; @@ -1497,7 +1497,7 @@ void _rtw_join_timeout_handler(struct timer_list *t) { struct adapter *adapter =3D timer_container_of(adapter, t, mlmepriv.assoc_timer); - struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 if (adapter->bDriverStopped || adapter->bSurpriseRemoved) return; @@ -1540,7 +1540,7 @@ void rtw_scan_timeout_handler(struct timer_list *t) { struct adapter *adapter =3D timer_container_of(adapter, t, mlmepriv.scan_to_timer); - struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 spin_lock_bh(&pmlmepriv->lock); =20 @@ -1696,10 +1696,10 @@ static int rtw_check_roaming_candidate(struct mlme_= priv *mlme int rtw_select_roaming_candidate(struct mlme_priv *mlme) { int ret =3D _FAIL; - struct list_head *phead; - struct __queue *queue =3D &mlme->scanned_queue; - struct wlan_network *pnetwork =3D NULL; - struct wlan_network *candidate =3D NULL; + struct list_head *phead; + struct __queue *queue =3D &mlme->scanned_queue; + struct wlan_network *pnetwork =3D NULL; + struct wlan_network *candidate =3D NULL; =20 if (!mlme->cur_network_scanned) { WARN_ON(1); @@ -1787,11 +1787,11 @@ static int rtw_check_join_candidate(struct mlme_pri= v *mlme int rtw_select_and_join_from_scanned_queue(struct mlme_priv *pmlmepriv) { int ret; - struct list_head *phead; + struct list_head *phead; struct adapter *adapter; - struct __queue *queue =3D &pmlmepriv->scanned_queue; - struct wlan_network *pnetwork =3D NULL; - struct wlan_network *candidate =3D NULL; + struct __queue *queue =3D &pmlmepriv->scanned_queue; + struct wlan_network *pnetwork =3D NULL; + struct wlan_network *candidate =3D NULL; =20 adapter =3D (struct adapter *)pmlmepriv->nic_hdl; =20 @@ -1837,10 +1837,10 @@ int rtw_select_and_join_from_scanned_queue(struct m= lme_priv *pmlmepriv) =20 signed int rtw_set_auth(struct adapter *adapter, struct security_priv *pse= curitypriv) { - struct cmd_obj *pcmd; - struct setauth_parm *psetauthparm; - struct cmd_priv *pcmdpriv =3D &adapter->cmdpriv; - signed int res =3D _SUCCESS; + struct cmd_obj *pcmd; + struct setauth_parm *psetauthparm; + struct cmd_priv *pcmdpriv =3D &adapter->cmdpriv; + signed int res =3D _SUCCESS; =20 pcmd =3D kzalloc_obj(*pcmd); if (!pcmd) { @@ -1859,7 +1859,7 @@ signed int rtw_set_auth(struct adapter *adapter, stru= ct security_priv *psecurity =20 pcmd->cmdcode =3D SET_AUTH_CMD; pcmd->parmbuf =3D (unsigned char *)psetauthparm; - pcmd->cmdsz =3D (sizeof(struct setauth_parm)); + pcmd->cmdsz =3D (sizeof(struct setauth_parm)); pcmd->rsp =3D NULL; pcmd->rspsz =3D 0; =20 @@ -1875,9 +1875,9 @@ signed int rtw_set_key(struct adapter *adapter, struc= t security_priv *psecurityp { u8 keylen; struct cmd_obj *pcmd; - struct setkey_parm *psetkeyparm; + struct setkey_parm *psetkeyparm; struct cmd_priv *pcmdpriv =3D &adapter->cmdpriv; - signed int res =3D _SUCCESS; + signed int res =3D _SUCCESS; =20 psetkeyparm =3D kzalloc_obj(*psetkeyparm); if (!psetkeyparm) { @@ -1930,7 +1930,7 @@ signed int rtw_set_key(struct adapter *adapter, struc= t security_priv *psecurityp =20 pcmd->cmdcode =3D SET_KEY_CMD; pcmd->parmbuf =3D (u8 *)psetkeyparm; - pcmd->cmdsz =3D (sizeof(struct setkey_parm)); + pcmd->cmdsz =3D (sizeof(struct setkey_parm)); pcmd->rsp =3D NULL; pcmd->rspsz =3D 0; =20 @@ -1948,7 +1948,7 @@ signed int rtw_set_key(struct adapter *adapter, struc= t security_priv *psecurityp /* adjust ies for rtw_joinbss_cmd in WMM */ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, ui= nt in_len, uint initial_out_len) { - unsigned int ielength =3D 0; + unsigned int ielength =3D 0; unsigned int i, j; =20 i =3D 12; /* after the fixed IE */ @@ -2025,7 +2025,7 @@ static int rtw_append_pmkid(struct adapter *Adapter, = int iEntry, u8 *ie, uint ie =20 static void rtw_report_sec_ie(struct adapter *adapter, u8 authmode, u8 *se= c_ie) { - uint len; + uint len; u8 *buff, *p; union iwreq_data wrqu; =20 @@ -2059,12 +2059,12 @@ static void rtw_report_sec_ie(struct adapter *adapt= er, u8 authmode, u8 *sec_ie) signed int rtw_restruct_sec_ie(struct adapter *adapter, u8 *in_ie, u8 *out= _ie, uint in_len) { u8 authmode =3D 0x0; - uint ielength; + uint ielength; int iEntry; =20 struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; struct security_priv *psecuritypriv =3D &adapter->securitypriv; - uint ndisauthmode =3D psecuritypriv->ndisauthtype; + uint ndisauthmode =3D psecuritypriv->ndisauthtype; =20 /* copy fixed ie only */ memcpy(out_ie, in_ie, 12); @@ -2099,7 +2099,7 @@ void rtw_init_registrypriv_dev_network(struct adapter= *adapter) { struct registry_priv *pregistrypriv =3D &adapter->registrypriv; struct eeprom_priv *peepriv =3D &adapter->eeprompriv; - struct wlan_bssid_ex *pdev_network =3D &pregistrypriv->dev_network; + struct wlan_bssid_ex *pdev_network =3D &pregistrypriv->dev_network; u8 *myhwaddr =3D myid(peepriv); =20 memcpy(pdev_network->mac_address, myhwaddr, ETH_ALEN); @@ -2114,9 +2114,9 @@ void rtw_update_registrypriv_dev_network(struct adapt= er *adapter) { int sz =3D 0; struct registry_priv *pregistrypriv =3D &adapter->registrypriv; - struct wlan_bssid_ex *pdev_network =3D &pregistrypriv->dev_network; - struct security_priv *psecuritypriv =3D &adapter->securitypriv; - struct wlan_network *cur_network =3D &adapter->mlmepriv.cur_network; + struct wlan_bssid_ex *pdev_network =3D &pregistrypriv->dev_network; + struct security_priv *psecuritypriv =3D &adapter->securitypriv; + struct wlan_network *cur_network =3D &adapter->mlmepriv.cur_network; =20 pdev_network->privacy =3D (psecuritypriv->dot11_privacy_algrthm > 0 ? 1 := 0) ; /* adhoc no 802.1x */ =20 @@ -2137,7 +2137,7 @@ void rtw_update_registrypriv_dev_network(struct adapt= er *adapter) =20 pdev_network->ie_length =3D sz; =20 - pdev_network->length =3D get_wlan_bssid_ex_sz((struct wlan_bssid_ex *)pd= ev_network); + pdev_network->length =3D get_wlan_bssid_ex_sz((struct wlan_bssid_ex *)pde= v_network); =20 /* notes: translate ie_length & length after assign the length to cmdsz i= n createbss_cmd(); */ /* pdev_network->ie_length =3D cpu_to_le32(sz); */ @@ -2178,8 +2178,8 @@ void rtw_ht_use_default_setting(struct adapter *padap= ter) struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; struct registry_priv *pregistrypriv =3D &padapter->registrypriv; - bool bHwLDPCSupport =3D false, bHwSTBCSupport =3D false; - bool bHwSupportBeamformer =3D false, bHwSupportBeamformee =3D false; + bool bHwLDPCSupport =3D false, bHwSTBCSupport =3D false; + bool bHwSupportBeamformer =3D false, bHwSupportBeamformee =3D false; =20 if (pregistrypriv->wifi_spec) phtpriv->bss_coexist =3D 1; diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging= /rtl8723bs/core/rtw_sta_mgt.c index aea660f27959..6d014bf8fa96 100644 --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c @@ -454,7 +454,7 @@ void rtw_free_all_stainfo(struct adapter *padapter) /* any station allocated can be searched by hash list */ struct sta_info *rtw_get_stainfo(struct sta_priv *pstapriv, u8 *hwaddr) { - struct list_head *plist, *phead; + struct list_head *plist, *phead; struct sta_info *psta =3D NULL; u32 index; u8 *addr; diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/stag= ing/rtl8723bs/include/wlan_bssdef.h index 6da157914925..f4c1456f1476 100644 --- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h +++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h @@ -19,8 +19,8 @@ typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LEN= GTH_RATES]; /* typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];= /* Set of 16 data rates */ =20 struct ndis_802_11_ssid { - u32 ssid_length; - u8 ssid[32]; + u32 ssid_length; + u8 ssid[32]; }; =20 /* @@ -35,15 +35,15 @@ struct ndis_802_11_conf { }; =20 struct ndis_802_11_fix_ie { - u8 time_stamp[8]; - u16 beacon_interval; - u16 capabilities; + u8 time_stamp[8]; + u16 beacon_interval; + u16 capabilities; }; =20 struct ndis_80211_var_ie { - u8 element_id; - u8 length; - u8 data[]; + u8 element_id; + u8 length; + u8 data[]; }; =20 /* Length is the 4 bytes multiples of the sum of @@ -126,7 +126,7 @@ struct wlan_bcn_info { int is_8021x; =20 /* bwmode 20/40 and ch_offset UP/LOW */ - unsigned short ht_cap_info; + unsigned short ht_cap_info; unsigned char ht_info_infos_0; }; =20 @@ -134,18 +134,18 @@ struct wlan_bcn_info { * struct wlan_bssid_ex and get_wlan_bssid_ex_sz() */ struct wlan_bssid_ex { - u32 length; + u32 length; u8 mac_address[ETH_ALEN]; - u8 reserved[2];/* 0]: IS beacon frame */ - struct ndis_802_11_ssid ssid; - u32 privacy; - long rssi;/* in dBM, raw data , get from PHY) */ - struct ndis_802_11_conf configuration; - enum nl80211_iftype infrastructure_mode; - NDIS_802_11_RATES_EX supported_rates; + u8 reserved[2];/* 0]: IS beacon frame */ + struct ndis_802_11_ssid ssid; + u32 privacy; + long rssi;/* in dBM, raw data , get from PHY) */ + struct ndis_802_11_conf configuration; + enum nl80211_iftype infrastructure_mode; + NDIS_802_11_RATES_EX supported_rates; struct wlan_phy_info phy_info; - u32 ie_length; - u8 ies[MAX_IE_SZ]; /* timestamp, beacon interval, and capability informa= tion) */ + u32 ie_length; + u8 ies[MAX_IE_SZ]; /* timestamp, beacon interval, and capability informat= ion) */ } __packed; =20 static inline uint get_wlan_bssid_ex_sz(struct wlan_bssid_ex *bss) @@ -153,15 +153,15 @@ static inline uint get_wlan_bssid_ex_sz(struct wlan_b= ssid_ex *bss) return (sizeof(struct wlan_bssid_ex) - MAX_IE_SZ + bss->ie_length); } =20 -struct wlan_network { - struct list_head list; - int network_type; /* refer to ieee80211.h for WIRELESS_11A/B/G */ - int fixed; /* set to fixed when not to be removed as site-surveying */ - unsigned long last_scanned; /* timestamp for the network */ - int aid; /* will only be valid when a BSS is joinned. */ - int join_res; - struct wlan_bssid_ex network; /* must be the last item */ - struct wlan_bcn_info bcn_info; +struct wlan_network { + struct list_head list; + int network_type; /* refer to ieee80211.h for WIRELESS_11A/B/G */ + int fixed; /* set to fixed when not to be removed as site-surveying */ + unsigned long last_scanned; /* timestamp for the network */ + int aid; /* will only be valid when a BSS is joinned. */ + int join_res; + struct wlan_bssid_ex network; /* must be the last item */ + struct wlan_bcn_info bcn_info; }; =20 enum { --=20 2.54.0 From nobody Sat Jul 25 03:45:45 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75B183914EB for ; Sun, 19 Jul 2026 11:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784462207; cv=none; b=e6bJrWXbKEJJuKJuUVAYWc2kf+eRQgPDKPlK6tmcV/5fUWW/WdWBm4HsvAbhOK/KX6fhE2J9/BBso8ez8S78iKh+J/T7O2pB/9iW+nYutP//dJyo1Tqpg3v1qcFSRmcRnGmQS9IpMQqWK9my4eu9WPmV4k2pmlzhK3tOITqBvAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784462207; c=relaxed/simple; bh=xgYkmaC4sywYYEtk8AKTdFSt5A/jhYykhfeOWVd/JzM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eWXheCizRWtkCa4qDOeqqN9WLK+9QDofIXrQN1kOHTCTJcW5htyxe7fnoipvNW2ecHX7ewi0yipA8ehNy/zNrThk67LXQBI/eMZ8gtrrDBFDYZBlcK1sT6cpebow8Ay6iEqV13XsYWVLnO4Stf7pkRA0HwqTxbE06GmQi+w3SjI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pP6UqVpp; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pP6UqVpp" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4954c0833b4so10863475e9.1 for ; Sun, 19 Jul 2026 04:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784462204; x=1785067004; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9QNVQF5gPTGrVogrPIbv9TDS9kiYitCyuOPlWplw+DI=; b=pP6UqVpp+wAdB8m03wu4caSS7OPS1q6VEwRUd33s81H1jQ01Y1owxvplyh/yh7y7f3 rNyYjJIRZZNyQTmmZaqTPDGGxI2mq4AYVJY37cbjagu1/YWs2kPvCIaxvdY68qoTiEcB 5VnMCGqoMVj1qp0oYD2lKyg7qIk2HWvOHfLp42rzlOjQka2WW4Gv6jJnX7MlcupzA7LF lNwfljVKU0V2Jrk25mpknwDDiR/rypuNl+HbI0issuk53cULt/FMxIvq+6/HIxqFr9fN 5kZjYYoJIZnGYuCCoxi70oVrd66Bjq5k5i9YX6XbeAuGS2wKio0ZfDa92+2RlWENcXvs 0DiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784462204; x=1785067004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9QNVQF5gPTGrVogrPIbv9TDS9kiYitCyuOPlWplw+DI=; b=W6SCwR/NnPROds0k7K0qt1mTWuv4zsIp8j6gkFw33+9vg7+r6GDoh2GVSivrxtp1xF NwQAZ5ue4Cax3D0Zv73M/pijazNJlgI1hGTL5EmxaxSu1dnEEcEhnSicKBCzzQrgLwVY J4fy0UZVjkbGz5Efl23Pm7/uvPBmQ3g0E7TJnd+i6+SxnCitIhC4xzzYBljUo3q9UbHL LefrsTOUjN3lqnfDtC5hgCPHKb0h1+mtu5FeGf1tXSOt/PnBxJagZOzwlqfrKYwn20ch s+zin7A5GNmzvfEc7RF1iLH1DGZ9VF6bAHFSyBEvvwOXfWHY34xFXOmO7XohRk1Qp0RM F5aw== X-Forwarded-Encrypted: i=1; AHgh+Rr5KkJe5SlQbnzwecVkA+4buUWQuNR2ogY69rxW19mqG0PREXilEL1/IwrtBuP/DijhVhJ/MRu8rrYjfvA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0UMg6dILJDxkbJAhpAcCUcpBZ11hQUTIKyAXRuK9ou6tInIdq 3CRvrz2XPDDlhJOuuZebZ1MexLDV780j3ew0KIW5G56o6f53AhRSxAz4 X-Gm-Gg: AfdE7cnx2MU8S4mwaDi0AwSBNHnovAMQ13gam76DMRsT/A+4s9ktxKLsQEbEzg5tiWP h+jkVM+hZ80EedsIR5G3s8nj3LkX4/r6Sx0ny371buEu7mnngMeA5LBM2vJvIDLVyu/QMwVqOEc F8KNUq8ME+Cj2tCD43PNQNju2TTFk1PsJvaTV0Bm7TLyKhHToid67xq4a3lirAn4efRuF8+0qyj rN1tqQ6latlz/UiBAdVecocMGL9EAeQKh1AImJ/qLCLbSn4ipvb89DxWTc97fYnoCYqI7UnETyj U6rXFnrS10s013wjq+zMWrjFZLtdxiep503oVIUmnDAmQghrh11grMZ1NO1/DaROEbnEZg/OyyN FXccVYwknO+UCuBHCCoxJPH60bUdb/sjLISpRK+QTBVweHhKOpVcC+cpSn3WQsyCPu4qYXyXXyI mORuI0dmxIF9LqD9LGMpHnnPNYma0GM66EOVvC98Or76JBJk4a40x+I2L6sWscqVaHn/zKQFsZm 0Y8pQ== X-Received: by 2002:a05:600c:4503:b0:493:c84c:2b57 with SMTP id 5b1f17b1804b1-4954a513f99mr103759975e9.29.1784462204487; Sun, 19 Jul 2026 04:56:44 -0700 (PDT) Received: from koolguy.fritz.box (dslb-088-074-245-227.088.074.pools.vodafone-ip.de. [88.74.245.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49549a35830sm199719265e9.3.2026.07.19.04.56.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 04:56:44 -0700 (PDT) From: Dalvin-Ehinoma Noah Aiguobas To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dalvin-Ehinoma Noah Aiguobas Subject: [PATCH 2/3] staging: rtl8723bs: wrap line over 100 characters Date: Sun, 19 Jul 2026 11:54:50 +0000 Message-ID: <20260719115451.4401-3-fliegbert2@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260719115451.4401-1-fliegbert2@gmail.com> References: <20260719115451.4401-1-fliegbert2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch warning by wrapping the lines. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index cd6c7cbade9b..114deeecc80f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -704,13 +704,16 @@ void rtw_surveydone_event_callback(struct adapter *ad= apter, u8 *pbuf) _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else { u8 ret =3D _SUCCESS; - struct wlan_bssid_ex *pdev_network =3D &adapter->registrypriv.dev_net= work; + struct wlan_bssid_ex *pdev_network =3D + &adapter->registrypriv.dev_network; + u8 *pibss =3D adapter->registrypriv.dev_network.mac_address; =20 /* pmlmepriv->fw_state ^=3D _FW_UNDER_SURVEY;because don't set assoc_= timer */ _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY); =20 - memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndi= s_802_11_ssid)); + memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, + sizeof(struct ndis_802_11_ssid)); =20 rtw_update_registrypriv_dev_network(adapter); rtw_generate_random_ibss(pibss); @@ -1024,7 +1027,8 @@ static struct sta_info *rtw_joinbss_update_stainfo(st= ruct adapter *padapter, str =20 /* pnetwork : returns from rtw_joinbss_event_callback */ /* ptarget_wlan: found from scanned_queue */ -static void rtw_joinbss_update_network(struct adapter *padapter, struct wl= an_network *ptarget_wlan, struct wlan_network *pnetwork) +static void rtw_joinbss_update_network(struct adapter *padapter, struct wl= an_network *ptarget_wlan, + struct wlan_network *pnetwork) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct wlan_network *cur_network =3D &pmlmepriv->cur_network; --=20 2.54.0 From nobody Sat Jul 25 03:45:45 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB886391501 for ; Sun, 19 Jul 2026 11:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784462210; cv=none; b=RyXP9DXMmFpHFp5WT+TlTGCe+LhEoWSieZ02d2XHhrWB7QhUNuZW8j7gFS+TTya7Bnefsp+C/pWPsx5rgC4L98cW7bRi3u2HI/Y6HVvqHJpFjtLg0N0r53cgArTdYndlWHHjnpVIkBzZJoZ0vGCK03Gyrc3fw9frIA6UUFH2yX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784462210; c=relaxed/simple; bh=aT8WjfevnvQnjKEbBzJVfhDy2wMuzZXUG18aOn86CRI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eHRFqhmU0ApOjUbfp1DPMvcw9iVNBdCo/TBw3QwyXOhFRSuaJO5F96iZF3dceevXo2iU4sy1v0aEgYi23NKCkIk8HN8MPMdDFiVchPR3pUxVbvMNgHbTIaCMY8Hl/RGEaX2yhfHwCruRB+ifzHvZz64Strj+7M0dkPmayrEsAzE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NJFzJBzF; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NJFzJBzF" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so71248885e9.0 for ; Sun, 19 Jul 2026 04:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784462205; x=1785067005; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IV1qrWNsywXanbaou7CIYryBIVcu0WcT7k41OagbRXk=; b=NJFzJBzFyizaUco/m1sE9EE5NhVlViA8U5GuPUOaPZgT+EMLgwr1VaTeLqUG7DjDQe T0raF+8X/tjykBiKO+Bo63XmuvYW8L5ITjKlv8pi10h5C5w1/wAEpgpBfEm+Advfk9nK ZwkA/TQvhcLOQjNkRCgOed0GiR5XS8f9Hr2jTH/VFrLAEBCpl1ejw3CS7bQkkVdIV1jh gJUZXGpoxBAwVRt8H1UsY+34Astss3RPal51GF4V84NSea7K7A45GgsNrovKIYO/R1Yb /ZI1geeJ+SyZ+HrYiY0vX5+7kDWikyCj/NPO/jv66pRgfW2Z4VN6IReC5H/v9E/EO8oe EAqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784462205; x=1785067005; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IV1qrWNsywXanbaou7CIYryBIVcu0WcT7k41OagbRXk=; b=lao9+ylkTh+MKd0aXNrdbJjE9uHxoJc1rvs5Ay9rtIMzNH8zWcZK47UXraABBsbJLJ Cma9HXyfATddB59dYBFXg00+iUZAnPcLuLnpyZcSRQ51Oy9Kp3m4seXYa8JBOquz3m9f jfyr+LRHp7UhIvbRInatglq3RNkojUw4wRyXZRF/pCiKmpU4bA2SZ012bI7X0MY1tjN7 yZZeojB0bkLPyOYKcm1q95e24I0C4CX7kZOhSTT5kykSA/yXDw6ITkUop1jvkru52VE9 QWceAO+RnknSatwUWaI0PQxHovB1s0EpuAcCjPcM3EeiUW1zmec2vEhae1m12VMO0cXa AfNA== X-Forwarded-Encrypted: i=1; AHgh+RquBR6yKWOVLzKH8ZZoF4dt1mYWRRA0mcbV2yIZQMkm1IA27ksl9q3ylvlXgZ+3RHCrLOboGDfvMU+kqG4=@vger.kernel.org X-Gm-Message-State: AOJu0Yym64mWhNoDHT1I8MPRFJ6ALtKNYYtQMkRHLpdDXV0VbqdXzZNh EDWkg8NHptqReKAqvAaddIWrhbx2lHXEgAiJE4cg2B4fcYKAmSaq4o3t X-Gm-Gg: AfdE7cndVgp7//2UkzgWbG9ks+mIboFL8zbbBcgXf7leMueS/AammonOE5QXk0kiQO0 gbLr1G8BszlEJloIbS6I+iBuYxFtjrxkWtV+fH6EaX7PIZMyW3/RD7f96rRyw2LdGZn1hV6f0ir +g0gOZb/LeQSmKhQkkTZx4zRGRZHNKofObyOZb7AinehS/1F9vfuQwrPjx/98ayCEkkJkXKeKgo OOfsrDuIN+l1/EFaEwy7hUiUJbUUbOD1Qy2slP/q505LFV3sh6W1sWJK/f/A/oQ9N910V+fowGy nugqvOw8YC5/RL2ckqO3d7K+9z3Mgwj8DB1iwZP2DKgGFU+lroF0gIv8VQjzslkDAcrQ/WctFA1 kpi3YIqX0SF7HQH6SlbsdQakyazSxpGHrwAhy2zZI321qIED/7lgn6KCaGxCBODxwSeNK72qENg +XwhVGRrhlYaZlGLSIkLUhCgMYbdOoKGxfEoi51ThS3y3oGPi9h6sY/t7LWA0SnnxM+Dg= X-Received: by 2002:a05:600c:6d82:b0:495:4072:4194 with SMTP id 5b1f17b1804b1-4954a40c4acmr72912765e9.28.1784462205277; Sun, 19 Jul 2026 04:56:45 -0700 (PDT) Received: from koolguy.fritz.box (dslb-088-074-245-227.088.074.pools.vodafone-ip.de. [88.74.245.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49549a35830sm199719265e9.3.2026.07.19.04.56.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 04:56:44 -0700 (PDT) From: Dalvin-Ehinoma Noah Aiguobas To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dalvin-Ehinoma Noah Aiguobas Subject: [PATCH 3/3] staging: rtl8723bs: Renaming variables with type prefix Date: Sun, 19 Jul 2026 11:54:51 +0000 Message-ID: <20260719115451.4401-4-fliegbert2@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260719115451.4401-1-fliegbert2@gmail.com> References: <20260719115451.4401-1-fliegbert2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Renaming deprecated variable names which use prefixes as type indicators to conform to the styleguide and for improved readability. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 152 +++++++++++----------- 1 file changed, 76 insertions(+), 76 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 114deeecc80f..7e3be8cbc829 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -675,52 +675,52 @@ void rtw_survey_event_callback(struct adapter *adapte= r, u8 *pbuf) spin_unlock_bh(&pmlmepriv->lock); } =20 -void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) +void rtw_surveydone_event_callback(struct adapter *adapter, u8 *buf) { - struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; + struct mlme_priv *mlme_priv =3D &adapter->mlmepriv; =20 - spin_lock_bh(&pmlmepriv->lock); - if (pmlmepriv->wps_probe_req_ie) { - pmlmepriv->wps_probe_req_ie_len =3D 0; - kfree(pmlmepriv->wps_probe_req_ie); - pmlmepriv->wps_probe_req_ie =3D NULL; + spin_lock_bh(&mlme_priv->lock); + if (mlme_priv->wps_probe_req_ie) { + mlme_priv->wps_probe_req_ie_len =3D 0; + kfree(mlme_priv->wps_probe_req_ie); + mlme_priv->wps_probe_req_ie =3D NULL; } =20 - if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) { - spin_unlock_bh(&pmlmepriv->lock); - timer_delete_sync(&pmlmepriv->scan_to_timer); - spin_lock_bh(&pmlmepriv->lock); - _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY); + if (check_fwstate(mlme_priv, _FW_UNDER_SURVEY)) { + spin_unlock_bh(&mlme_priv->lock); + timer_delete_sync(&mlme_priv->scan_to_timer); + spin_lock_bh(&mlme_priv->lock); + _clr_fwstate_(mlme_priv, _FW_UNDER_SURVEY); } =20 rtw_set_signal_stat_timer(&adapter->recvpriv); =20 - if (pmlmepriv->to_join) { - if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { - if (!check_fwstate(pmlmepriv, _FW_LINKED)) { - set_fwstate(pmlmepriv, _FW_UNDER_LINKING); + if (mlme_priv->to_join) { + if (check_fwstate(mlme_priv, WIFI_ADHOC_STATE)) { + if (!check_fwstate(mlme_priv, _FW_LINKED)) { + set_fwstate(mlme_priv, _FW_UNDER_LINKING); =20 - if (rtw_select_and_join_from_scanned_queue(pmlmepriv) =3D=3D _SUCCESS)= { - _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); + if (rtw_select_and_join_from_scanned_queue(mlme_priv) =3D=3D _SUCCESS)= { + _set_timer(&mlme_priv->assoc_timer, MAX_JOIN_TIMEOUT); } else { u8 ret =3D _SUCCESS; - struct wlan_bssid_ex *pdev_network =3D + struct wlan_bssid_ex *dev_network =3D &adapter->registrypriv.dev_network; =20 - u8 *pibss =3D adapter->registrypriv.dev_network.mac_address; + u8 *ibss =3D adapter->registrypriv.dev_network.mac_address; =20 - /* pmlmepriv->fw_state ^=3D _FW_UNDER_SURVEY;because don't set assoc_= timer */ - _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY); + /* mlme_priv->fw_state ^=3D _FW_UNDER_SURVEY;because don't set assoc_= timer */ + _clr_fwstate_(mlme_priv, _FW_UNDER_SURVEY); =20 - memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, + memcpy(&dev_network->ssid, &mlme_priv->assoc_ssid, sizeof(struct ndis_802_11_ssid)); =20 rtw_update_registrypriv_dev_network(adapter); - rtw_generate_random_ibss(pibss); + rtw_generate_random_ibss(ibss); =20 - pmlmepriv->fw_state =3D WIFI_ADHOC_MASTER_STATE; + mlme_priv->fw_state =3D WIFI_ADHOC_MASTER_STATE; =20 - pmlmepriv->to_join =3D false; + mlme_priv->to_join =3D false; =20 ret =3D rtw_createbss_cmd(adapter); if (ret !=3D _SUCCESS) @@ -730,37 +730,37 @@ void rtw_surveydone_event_callback(struct adapter *ad= apter, u8 *pbuf) } else { int s_ret; =20 - set_fwstate(pmlmepriv, _FW_UNDER_LINKING); - pmlmepriv->to_join =3D false; - s_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); + set_fwstate(mlme_priv, _FW_UNDER_LINKING); + mlme_priv->to_join =3D false; + s_ret =3D rtw_select_and_join_from_scanned_queue(mlme_priv); if (s_ret =3D=3D _SUCCESS) { - _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); + _set_timer(&mlme_priv->assoc_timer, MAX_JOIN_TIMEOUT); } else if (s_ret =3D=3D 2) {/* there is no need to wait for join */ - _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); + _clr_fwstate_(mlme_priv, _FW_UNDER_LINKING); rtw_indicate_connect(adapter); } else { if (rtw_to_roam(adapter) !=3D 0) { if (rtw_dec_to_roam(adapter) =3D=3D 0 || - rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid, + rtw_sitesurvey_cmd(adapter, &mlme_priv->assoc_ssid, 1, NULL, 0) !=3D _SUCCESS) { rtw_set_to_roam(adapter, 0); rtw_free_assoc_resources(adapter, 1); rtw_indicate_disconnect(adapter); } else { - pmlmepriv->to_join =3D true; + mlme_priv->to_join =3D true; } } else { rtw_indicate_disconnect(adapter); } - _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); + _clr_fwstate_(mlme_priv, _FW_UNDER_LINKING); } } } else { if (rtw_chk_roam_flags(adapter, RTW_ROAM_ACTIVE)) { - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) && - check_fwstate(pmlmepriv, _FW_LINKED)) { - if (rtw_select_roaming_candidate(pmlmepriv) =3D=3D _SUCCESS) { - receive_disconnect(adapter, pmlmepriv->cur_network.network.mac_address + if (check_fwstate(mlme_priv, WIFI_STATION_STATE) && + check_fwstate(mlme_priv, _FW_LINKED)) { + if (rtw_select_roaming_candidate(mlme_priv) =3D=3D _SUCCESS) { + receive_disconnect(adapter, mlme_priv->cur_network.network.mac_address , WLAN_REASON_ACTIVE_ROAM); } } @@ -768,7 +768,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) } =20 unlock: - spin_unlock_bh(&pmlmepriv->lock); + spin_unlock_bh(&mlme_priv->lock); =20 rtw_os_xmit_schedule(adapter); =20 @@ -2177,57 +2177,57 @@ void rtw_joinbss_reset(struct adapter *padapter) } } =20 -void rtw_ht_use_default_setting(struct adapter *padapter) +void rtw_ht_use_default_setting(struct adapter *adapter) { - struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; - struct registry_priv *pregistrypriv =3D &padapter->registrypriv; - bool bHwLDPCSupport =3D false, bHwSTBCSupport =3D false; - bool bHwSupportBeamformer =3D false, bHwSupportBeamformee =3D false; + struct mlme_priv *mlme_priv =3D &adapter->mlmepriv; + struct ht_priv *ht_priv =3D &mlme_priv->htpriv; + struct registry_priv *registry_priv =3D &adapter->registrypriv; + bool hw_ldpc_support =3D false, hw_stbc_support =3D false; + bool hw_support_beamformer =3D false, hw_support_beamformee =3D false; =20 - if (pregistrypriv->wifi_spec) - phtpriv->bss_coexist =3D 1; + if (registry_priv->wifi_spec) + ht_priv->bss_coexist =3D 1; else - phtpriv->bss_coexist =3D 0; + ht_priv->bss_coexist =3D 0; =20 - phtpriv->sgi_40m =3D TEST_FLAG(pregistrypriv->short_gi, BIT(1)) ? true : = false; - phtpriv->sgi_20m =3D TEST_FLAG(pregistrypriv->short_gi, BIT(0)) ? true : = false; + ht_priv->sgi_40m =3D TEST_FLAG(registry_priv->short_gi, BIT(1)) ? true : = false; + ht_priv->sgi_20m =3D TEST_FLAG(registry_priv->short_gi, BIT(0)) ? true : = false; =20 /* LDPC support */ - rtw_hal_get_def_var(padapter, HAL_DEF_RX_LDPC, (u8 *)&bHwLDPCSupport); - CLEAR_FLAGS(phtpriv->ldpc_cap); - if (bHwLDPCSupport) { - if (TEST_FLAG(pregistrypriv->ldpc_cap, BIT(4))) - SET_FLAG(phtpriv->ldpc_cap, LDPC_HT_ENABLE_RX); + rtw_hal_get_def_var(adapter, HAL_DEF_RX_LDPC, (u8 *)&hw_ldpc_support); + CLEAR_FLAGS(ht_priv->ldpc_cap); + if (hw_ldpc_support) { + if (TEST_FLAG(registry_priv->ldpc_cap, BIT(4))) + SET_FLAG(ht_priv->ldpc_cap, LDPC_HT_ENABLE_RX); } - rtw_hal_get_def_var(padapter, HAL_DEF_TX_LDPC, (u8 *)&bHwLDPCSupport); - if (bHwLDPCSupport) { - if (TEST_FLAG(pregistrypriv->ldpc_cap, BIT(5))) - SET_FLAG(phtpriv->ldpc_cap, LDPC_HT_ENABLE_TX); + rtw_hal_get_def_var(adapter, HAL_DEF_TX_LDPC, (u8 *)&hw_ldpc_support); + if (hw_ldpc_support) { + if (TEST_FLAG(registry_priv->ldpc_cap, BIT(5))) + SET_FLAG(ht_priv->ldpc_cap, LDPC_HT_ENABLE_TX); } =20 /* STBC */ - rtw_hal_get_def_var(padapter, HAL_DEF_TX_STBC, (u8 *)&bHwSTBCSupport); - CLEAR_FLAGS(phtpriv->stbc_cap); - if (bHwSTBCSupport) { - if (TEST_FLAG(pregistrypriv->stbc_cap, BIT(5))) - SET_FLAG(phtpriv->stbc_cap, STBC_HT_ENABLE_TX); + rtw_hal_get_def_var(adapter, HAL_DEF_TX_STBC, (u8 *)&hw_stbc_support); + CLEAR_FLAGS(ht_priv->stbc_cap); + if (hw_stbc_support) { + if (TEST_FLAG(registry_priv->stbc_cap, BIT(5))) + SET_FLAG(ht_priv->stbc_cap, STBC_HT_ENABLE_TX); } - rtw_hal_get_def_var(padapter, HAL_DEF_RX_STBC, (u8 *)&bHwSTBCSupport); - if (bHwSTBCSupport) { - if (TEST_FLAG(pregistrypriv->stbc_cap, BIT(4))) - SET_FLAG(phtpriv->stbc_cap, STBC_HT_ENABLE_RX); + rtw_hal_get_def_var(adapter, HAL_DEF_RX_STBC, (u8 *)&hw_stbc_support); + if (hw_stbc_support) { + if (TEST_FLAG(registry_priv->stbc_cap, BIT(4))) + SET_FLAG(ht_priv->stbc_cap, STBC_HT_ENABLE_RX); } =20 /* Beamforming setting */ - rtw_hal_get_def_var(padapter, HAL_DEF_EXPLICIT_BEAMFORMER, (u8 *)&bHwSupp= ortBeamformer); - rtw_hal_get_def_var(padapter, HAL_DEF_EXPLICIT_BEAMFORMEE, (u8 *)&bHwSupp= ortBeamformee); - CLEAR_FLAGS(phtpriv->beamform_cap); - if (TEST_FLAG(pregistrypriv->beamform_cap, BIT(4)) && bHwSupportBeamforme= r) - SET_FLAG(phtpriv->beamform_cap, BEAMFORMING_HT_BEAMFORMER_ENABLE); - - if (TEST_FLAG(pregistrypriv->beamform_cap, BIT(5)) && bHwSupportBeamforme= e) - SET_FLAG(phtpriv->beamform_cap, BEAMFORMING_HT_BEAMFORMEE_ENABLE); + rtw_hal_get_def_var(adapter, HAL_DEF_EXPLICIT_BEAMFORMER, (u8 *)&hw_suppo= rt_beamformer); + rtw_hal_get_def_var(adapter, HAL_DEF_EXPLICIT_BEAMFORMEE, (u8 *)&hw_suppo= rt_beamformee); + CLEAR_FLAGS(ht_priv->beamform_cap); + if (TEST_FLAG(registry_priv->beamform_cap, BIT(4)) && hw_support_beamform= er) + SET_FLAG(ht_priv->beamform_cap, BEAMFORMING_HT_BEAMFORMER_ENABLE); + + if (TEST_FLAG(registry_priv->beamform_cap, BIT(5)) && hw_support_beamform= ee) + SET_FLAG(ht_priv->beamform_cap, BEAMFORMING_HT_BEAMFORMEE_ENABLE); } =20 void rtw_build_wmm_ie_ht(struct adapter *padapter, u8 *out_ie, uint *pout_= len) --=20 2.54.0