From nobody Sat Jul 25 04:17:40 2026 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012036.outbound.protection.outlook.com [52.101.48.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B5AC331EDD; Sat, 18 Jul 2026 17:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.36 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394951; cv=fail; b=ZrVfTCM8anBf3pLdIYGadKmUnkjObmdaD78hjGlJh8Hv5gc6xYZ6uhMjisRo5HzJD//QfA/+T4Zy8BMZj+euznRoKao3stdg/8HY8EElhNYWhiKEzIjMf41YB0d0x3zP+rJrRzdqk6j2DSUJroDhkLuc7bH59e7V0XFFSm9vNYM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394951; c=relaxed/simple; bh=bdVN+9SCE+WKLTbQMY3xrVsnPeXF7kpGlue4ZLS8IYM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=UvYKJkswmn9be9mY53KHF19sR7HF2iR9oNrjGuqfvCedWu0ppd8om+Rhj0bJ82kEGOtjFpfXWUAu3ui9JRXjQxl3PG4c6IlEJ3NDwqe54pae/KTCqPcfjspGzeNxakTXUz55Jlzb2l0Nk67fvgatSQubZOoiyFUBY/QRtQm+/Mg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=MQLe7WDk; arc=fail smtp.client-ip=52.101.48.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="MQLe7WDk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tyulq2JPRopySWkl2po2UxoSLL3x58n1V2GpORVrXZaID0DRE2C+qGdyARpCKmkkIwC2k9OOxMjIk55LTRf3umej/N40bxo9mnjqIgUfXuP5ICakr1yR+vkIpnFPLIN23zb4hF6nH10TeFfMqyMEN3Db9xBzrB9pji/gOOxmzbr6Zeq/KzGx2oMYJoczQyMCvkfjFnqfyn1OoVED89yqEI9IgYDWmHr/IgzfzneJwr5JXQxrf9z4jC1z0wzjJMt2msc0+nKUOiJHxOPSASOlo0w0fuNmM86DnCwkfCJX9WJdmjmZg9H1r6afRIQKFPRYXAd9TYLcCIUHV9a3nsj/+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BcLIXrmPKru1fxO4fA2mob+wBFLvuLJK5CJdRBNcNV4=; b=HQz9sVVi+E7KwWO1rwexB9Dt+93FSK4qRkXgFEz4ucOSGOn9peSdvSJc0YBimlcFoPO9vcMXNBxMb0tXguFT3HkZiB8fbkiV6bSRYL9XCjsdugA30jD1mv3jv4A6NOUAIirHhVw2yGCCwhXfwMWL/uWi9/CIhQvQNeJBHK7wnmpPzmaIXLfL00N6JlgJvcW+vTnxPxuxbNfQ09gcHabsUNQ0OzWUVtIDywNfXxBRPP4awGpJlQzj09HlmKwBBk6vo7c8EFSLYTE9iKRfMetTa8TURG6Myse8Nq/OTbwF5pWbTse8gPZpttBKTnn5X6cKK+7j4ibNQYbiVYFVAqCWTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BcLIXrmPKru1fxO4fA2mob+wBFLvuLJK5CJdRBNcNV4=; b=MQLe7WDkRsGzblBN/Bwm/EOJWZYkrXHq53+ugd0gs7Fzpb3II8bNx4MhLcY1iLGeANckU4LhfE27mtw2v3h5asJUPYWy48njq9qlZV0pVQKjCQc/TPa3lME/EN8BCdNGQGQQPuqNEDbmsHTQQB1+cmMCO3vKbo76BJgu2YFGcVvLbFRVD+vgzO8egDhR3PcUTmaBVYo3crqMErFIYjWD+3neTnTudNCXXjfZ7xfxnaBNJAIQWmk7ZIx9pgyYp5C9w30/dTynnrhKMdsWTFM2QhflCqIFwssCztMkmeWA3+kiIsbA5N5BDIE9ubKO95doSQZbZLNNAQhXN6HYPh08iA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB7276.namprd12.prod.outlook.com (2603:10b6:806:2af::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.13; Sat, 18 Jul 2026 17:15:46 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%6]) with mapi id 15.21.0223.012; Sat, 18 Jul 2026 17:15:46 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org, "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang Cc: rcu@vger.kernel.org Subject: [PATCH v1 1/6] rcu: Remove unused expedited_need_qs field from rcu_state Date: Sat, 18 Jul 2026 13:15:32 -0400 Message-Id: <20260718171539.3781595-2-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260718171539.3781595-1-joelagnelf@nvidia.com> References: <20260718171539.3781595-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0P223CA0015.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:52b::9) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB7276:EE_ X-MS-Office365-Filtering-Correlation-Id: e78f7f40-41a6-4461-de1c-08dee4f034d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|7416014|1800799024|18002099003|22082099003|921020|10067099003|56012099006|5023799004|11063799006; X-Microsoft-Antispam-Message-Info: 7EmVZWC+HjyYTJ19997od4K79lhDMXMbSEVQAHqyDrm9fiSFZFHPZShbgzZHzGDRsDwQdOS4znFgBZx6EdoGfaqRxV28ZJkOzxydr1mSXkA91vVV8pqVqGNthhdO2JYC3fjP67I38c+K14eVaW3MNNpZqJZgPMmQZ1xZyH32Veb7AhbA11xS7OJjLTJEWwgBklw/ALYU8NIxkqjPneEfnYM3VIog3BNzZ6AcQUdfwpNH0G2qT2h0Doi5eiNr0BLgDL1HPGk5QQYXtA8E2wyusi66s4jowYEkFC69dnleIMiko3mF1uF2V1LmsrIk6eYZfqnuHjKijNSQTG7l/gIU3GIzR79HEm5HS4HF9+UxiMj3d8MmiuW1UTGQqPAV0wqBNBonOkMR+nvt2dZT+al8F5tZJdhGJrySf9SofCoo+56LBIU9O7UrKWeHN856ScEvvPPTHj3Xk3W4U5f8teQXAnuc57ux0h4I7FKlb7jMGup5GSHsCPjjCm3RVF4cncuNPwZh1gmJnYMdPwPrAl2hvkr5zk3XC9EsEGPSgfGRbbOHY6WlXNlYkhhWUeC5yGLDjUdShYXwXbOaFbKXBtkrejnGF0NQFnfqicCSKebCMBWT8JFf5dV1oaJnUmTdHy8sz9c7vkiNJ7GKx0zHB2DwFVo6LAOdpHNWmuHLzenUvEZUKvTYgckaa9zx6SSG/tYWvzBALmipf+9+YvPv/bnMDw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(7416014)(1800799024)(18002099003)(22082099003)(921020)(10067099003)(56012099006)(5023799004)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?T2G+i5acIGGiKS6Ar9dQRCCEU4OmiLUlURjCiwKDw6KtDpu8oq9c04jyX2Xt?= =?us-ascii?Q?zX+CDexkycFWZ+dxp7aG1I9EAT5qzWVP0NX8LLfaj29NKt2NwcBAV3R7uL5a?= =?us-ascii?Q?bXQgHodBJhBovN0SJY5Oakl5RSwKCAp1TpUv8OvdP8V2klUXF/dxmue/OZ0k?= =?us-ascii?Q?CqLoK/euW97/TTqeMlvTQpaJVOXDra8s4apoHIBoOLdQAatQm6H6KizkK6mF?= =?us-ascii?Q?wOUsqpG3xHKNS+qY1u/TnKiMjKfaOt8atIndJcH3HqzrkcVIlqhUyDWLOvwT?= =?us-ascii?Q?wfDV6i282Q68auadsMGPL77Cyt6n08xbr8O8XIij24PvqcUfkMFWscgNxD23?= =?us-ascii?Q?7GWcuEHqCzbhoULn0g3oq/A2B5B0HFAjxUsbGcMDJwOFVQ+rkuJHr/Yg9Be0?= =?us-ascii?Q?OT3gzH22630CbG4LbBvzyCQjWownsVesb4AordHIkZhVEsg5Sx1gVwZizZxM?= =?us-ascii?Q?4OBFCBfvfR20BOFd+t4MtdFbfIPi7nT+fMt1N8potP61dTXXPrmGuKBMeT8j?= =?us-ascii?Q?vIX/RkhOB+1ECK7+AZpbAReahamvE7Dr/J8G6e6H5iUIAjLTuUR50SPo7y1P?= =?us-ascii?Q?4JjHx5G54Kc8TPj3z3v0pHeV1c/vP06pEZGtv/WK/A+F1iNreeLebWa6u6UM?= =?us-ascii?Q?/gaoXkjB5azFHE6Mu3P6OVBDJ1YSqGbKvZSXHlIYKEEABwcQxFbSv1cFqpCa?= =?us-ascii?Q?GLJDFfPg1NjUlMBty7CYyOmeE8+nDafJ8UAQTvIwaeWF6hePeHpFt2MG9wZE?= =?us-ascii?Q?hAV0aOxDP6IIPynYKHeW2imLsxgo6pH/66kQ5elpUL4pFMYYeWAYx+pNzbbM?= =?us-ascii?Q?FvMFhfG/hRNW7N1LnPq5egvvNqCBLDsqWNXrEhI26s8JHWK0cZcKzyrZl0rr?= =?us-ascii?Q?9FCNOaLK+de6fZrPfoJpjV7G33UlQJ7dy3T6VpRjILEZFvOUvuK14CwLs8N3?= =?us-ascii?Q?C5foFnJJFmwL6OXsA9HFfKJ8/VZEWbGzXnOUe+rHPFiW4JUxB8IjRWnw3Ors?= =?us-ascii?Q?yKogWBuYoLFbNKFVu4KyUBi7EUlWYA/o8VOurVi4DF7IojcT6wJVgXdFIleo?= =?us-ascii?Q?C4Q7LdznnOB6HMeYp8/RVKtLqoPinE3x81I2fx8tySzRFzPdCGHWMLB8vCS/?= =?us-ascii?Q?8Y+6TeNT+sJWb+mipmIv65+DfU3Cv1EcxTg7xek+tBzewTH7Y6cV9i4OmBM9?= =?us-ascii?Q?wluw4AJLS/5qp0rrxSBOkJMSrS6rOpuztjuZMhUl9SzQ4WjEsq9unrDa3gHd?= =?us-ascii?Q?EXYNV926UAH9fFohypyYKI30zUl5dfqukPHR2I1mwurUB+q5maqWUwT4Md+g?= =?us-ascii?Q?tUGqOpiatlOn4vvZw71fC7+40qo6RPnueeKP+QOe4bJtSC8IRxtdoFfpfhnR?= =?us-ascii?Q?nFe0AXwXRyMjEQWIZkZvv+qfR4yco8j2FJL3PIZytwALGFRb3DLmaHSntmCw?= =?us-ascii?Q?1RVLtoDM/Dyy/qhASHvv2jkjXo/ooFsINnc9B6Au5tTTXpILufaYstu9729N?= =?us-ascii?Q?SSo0g4IeitfpMs48EFwxYgZFGngQpgbhRTDrvOjwqSXjlgcZUMXs2fFsgXQm?= =?us-ascii?Q?eLyq2lzdHul0HbYu1TzhNCYWlHb9KK0dal/BvIcWDVhmRkVJTuhFBpAbEobx?= =?us-ascii?Q?0Y10GtQme5sT9blfVxRMlRgMe12kowAnuCm+f9beNBS4MOiHE3Hf1knu7tvH?= =?us-ascii?Q?i9m+4CtGq89CMt+BqPQgiW3UkkoK73aoghG4FzaA2NIIcKe0tSLtqURJjJA1?= =?us-ascii?Q?QKdj3+rtZQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: e78f7f40-41a6-4461-de1c-08dee4f034d0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2026 17:15:46.3373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UjFKDBxzFLfJEdSAY46gYAgqqef6SKLDkJ0JI7LN+nO/su4Y3gG8bQ+qxKNK0UDCl2GlkPiIF5n98UbZY8zm6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7276 Content-Type: text/plain; charset="utf-8" The ->expedited_need_qs counter was part of the old expedited grace-period machinery that spun waiting for each CPU to check in. The current implementation instead tracks holdout CPUs via the rcu_node structures' ->expmask fields and waits on the ->exp_wq[] wait queues, so nothing reads or writes ->expedited_need_qs any longer. Remove the field to avoid wasting space in rcu_state and to keep readers of the expedited code from searching for nonexistent users. Signed-off-by: Joel Fernandes --- kernel/rcu/tree.h | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h index 7dfc57e9adb1..beb86e39909a 100644 --- a/kernel/rcu/tree.h +++ b/kernel/rcu/tree.h @@ -386,7 +386,6 @@ struct rcu_state { struct mutex exp_mutex; /* Serialize expedited GP. */ struct mutex exp_wake_mutex; /* Serialize wakeup. */ unsigned long expedited_sequence; /* Take a ticket. */ - atomic_t expedited_need_qs; /* # CPUs left to check in. */ struct swait_queue_head expedited_wq; /* Wait for check-ins. */ int ncpus_snap; /* # CPUs seen last time. */ u8 cbovld; /* Callback overload now? */ --=20 2.34.1 From nobody Sat Jul 25 04:17:40 2026 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012036.outbound.protection.outlook.com [52.101.48.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE6CF3E1233; Sat, 18 Jul 2026 17:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.36 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394953; cv=fail; b=qzxA/tif8R56FSZAnSLdHgSVbmVGVAxsmjcZ+ldMUyV9op8Qq2JrnCqdNkT/4hoG5v1SGzDnYuJ39AlWxbDYa1I3e0Mpk6Upj+1TLxoXown4jHBdf9e5r+IMaOoPTvrJ11FaL2BngWf3hnJTpfRlZqV6rb0EFgqFVpA4pGgOqiU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394953; c=relaxed/simple; bh=wuzY3YFToFAq2l2yA4g8WqDqALO4Lh1tSeWNLuAJWjI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=era9M69TIqGxK2i9mUM+ldhM2uDRPQez1bq2w1raePBOg/iAsnmR9tiuE3YLajltw1Ra9dRspqbo6bNLhsOXS+D5OuZ+uHn0qaU6hjHMYIJs/lMgzYMpFdAQ/fj1FjtsUPcPcAV5C08DHHSIJFTj2sFP+RjcMnsXY55L0QIe4D4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=UP8RWJXc; arc=fail smtp.client-ip=52.101.48.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="UP8RWJXc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uJpZVgYUdG6thHXx1pe9WuMOkhCWdvTAt8sE4wiytjNe90rnYabHwZxek/hXLE3V5HBairaDJd0m4YKd6KSR+zokqgcqWr9R5aNd5esrGUYyl9jvAQUeEoeJniD4i+BJlKCZ2OBdFy1fHU2x+oKXG3pqLX/W1+xfFlnS0U0wOFBgWPTk2D314gmypqBAO6AcmjVsjtl3M7Tz23F3pjAsLy2djw2QI4n2tYd9CB6aPCi9RgS+14fvwoix/jrRH2n/do83MtqMubQHCo4dQqLR+R/ZNQeX0LF90foKBeKnBq79Bn1kn2Bntvndf6/9zs6sr0uUH/nthe8zAHuRdr0+Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EJ18QWcKn7v1sJioixXxAbN5zPGbKMft0FiInL+jNV0=; b=ngXXUEKTKw1iwMLjbMPHqgq7FY7lkXm9YW1scykuGTd8IKAi5FDS1zlPluPCzecgFzojqCTW7r6ol9IHUX+ktQv9GbjsXEK5uTsVqd8gYtxhPhNTBFua5xSB68bzCMs9bqdEAB+FAITD6fGJahjJm174ne5FPUCDGqRVa0o5flKYGMKes0MDDjk+R3/c+oFESp8RauOrStDjBFG4acIoUzx64booA4F7Nz3EeGuVoVLlDDE87FLEstW32xw7uGSrpedvzv61o235W2SrsoVXw2iZpglJKidgFHv9Fh+tg7uZRiBmcljGAEbejxBQkFKrV8UnfDTNJT28uuWhHqz0dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EJ18QWcKn7v1sJioixXxAbN5zPGbKMft0FiInL+jNV0=; b=UP8RWJXc5lfXhR48qxxWETfhWZQhKHQuaFhrTDkWXOtMyu1zCB+Od6W7IJnHi/k6Ec/KQc+xIU6HYQ5cXxbjjAZuO5C3y7HSL05kaSbRYFpPFwtIspG2eRNNHaArxy0srhGeqKeq95GqAghWCxuQF8tbss3hCSaiF9FS6t9MIKIWx7PnwPOKW1QMeJHeSWfS4DQcrQqbFkc/l0uR07IYkbF8IIjo7mv54lxty004UFsAzF2nty/+EwaaJrSwFz07/awiTmQ7z8SBB9RphLJNJEDG+YBuRpOQXLM18MSyHVOYn+hchR6J34HOt+vOloIDp+oxEok4H9UUyCWuMwHCGQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB7276.namprd12.prod.outlook.com (2603:10b6:806:2af::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.13; Sat, 18 Jul 2026 17:15:48 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%6]) with mapi id 15.21.0223.012; Sat, 18 Jul 2026 17:15:48 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org, "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang Cc: rcu@vger.kernel.org Subject: [PATCH v1 2/6] rcu: Remove unused rdp parameter from trace_rcu_this_gp() Date: Sat, 18 Jul 2026 13:15:33 -0400 Message-Id: <20260718171539.3781595-3-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260718171539.3781595-1-joelagnelf@nvidia.com> References: <20260718171539.3781595-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR03CA0052.namprd03.prod.outlook.com (2603:10b6:208:32d::27) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB7276:EE_ X-MS-Office365-Filtering-Correlation-Id: 007299c6-cd7f-45ab-5324-08dee4f03620 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|7416014|1800799024|18002099003|22082099003|921020|10067099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: kBBF7v4MdndUHG8ZNQC0pKsTXkMFiuVdRR0slyWmLY27EuWFEHJukzs3rVURtapyUFlOplOV2OUHnCHF/KtcaX6VdXHt6VgA05jCS4qpNCt+P0p8hMI25Kg0Sgcp4veywTpoojEh0Z5BKqABYQrRH+hc595/hKortmvnhR2TU6iXDoczRcvkoZRIXenfs6wEB7dM6GM2BAhhQb14FGQ+VOHKZH+wY/o/mxGi0ewoakavvyFfW4yCPG+TURNhmzRsP2eIAl37tnhHqmVbj0qNaaPOQCCZUzvFlI9D0iFV2uoxn/mcbIV/o4B7bvHpgXx9foYmo5fb/BJXoL9yiyjvl3a3gGfMaTObtlL+TUyGDS8cIDpcvc5LHCzY3T38HcDGrhUUmUz52gdCWc1liUymroZ8LlqmKVdo/H+4AEK7hf4Nd6kQ1A3K0CIdOTAE9A/2ZF8fw1LCyVFD82vsO3RZoCMem1Jj7rIPdtXTy5lNcFhXGtKb/1ULczlKxlOtAdXrcfT3wMWQ6XovcFikgrSEP8wQdriUZoaQ8iv7wEQsokaKsvYyMoIexOLFsSwzet4wKpqf+Qrd3jNblY2UhoW8ejTBvV2DNqr4WXQZvfwh/MLPYxH5bgeA+SjR97Im4lOrqusKiPFdPGlKEzLZS/m8i5P9uib9dMEyrp/GFS9SfnW1G85PnTnHfv6fcJUA30zw5uQN+94pT0DbpCk+XY4QcQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(7416014)(1800799024)(18002099003)(22082099003)(921020)(10067099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Pj/4w3dKiVKf0qW4km253QT3hbP26f9lbVUIytG1lND8vVRyDqWenQYew/ZP?= =?us-ascii?Q?B7pLRzH3cZ5+e1/cT4XbGl0iIHuESfNRonhGyxWfHQmHCvW4y3txNw4oRhPg?= =?us-ascii?Q?oX4vHBPZVwp352MIRHVgjGU1cLSxfQLrbfrgYy0YxFGYwkp4nVGATsd7AXAM?= =?us-ascii?Q?nwvQp5/hVWxQg60mcY/86sdrPKanJSzfnQKEKinGRCfk/UooqiInbuZ7DcoA?= =?us-ascii?Q?3DU1Ori2c30Tu2aor4du6musbxT9mPzTce0qJsmg0GW0ev6RqEkW7jQgE8cT?= =?us-ascii?Q?g7WS78IfxbWEGA2PLUbGkG6uP7hSiEKIK3JfyONAi8vkRYQVNf7qyPqKVMto?= =?us-ascii?Q?ZoLNGo4KBkVIwzcUZ6T0C876v0BYTvz2zGiwZG5u0ejHG8IPhlKYdCWCT6QV?= =?us-ascii?Q?fwt1XOlb7LZIxsF/0/ucomRCob+Sf7m+IjeZEZ3jwjvZv6nmr1CQm/WMkMuB?= =?us-ascii?Q?J2x8tO9ckGza1ox7PWr+1ZIZwgeXCN0MrP4Cpnhav+oaLSkepSLaQzNKPjHK?= =?us-ascii?Q?nth61saK2zYzbX1cEOswX1Q0CdHH/wDc1y8e7+fXpltUQPHvWDqCJrdDtmLW?= =?us-ascii?Q?kvg2gasS5EUGE6pJj1Xo27MDR2TzS7IcyMpVUy9JPEvuMXnubi28i1vimKe2?= =?us-ascii?Q?O2jqVvWmcK9mbDyoz2DO+4ZGHMzQ3ZDK5dY30fAakQgu2etxfRFVxXUHrLwS?= =?us-ascii?Q?9IZHUMl4xzzb9U/oreh+NhIhUrSCuX3lRAJhMw7Q7+QDh/Ex9RKGdi4ocUE9?= =?us-ascii?Q?tQK6w4FIyMMm5+9UvjJgBEjVvOsbaX5flBcrRE9SJj9r1XAuqVRXAPFy4WUO?= =?us-ascii?Q?581kweEJ1q/suDJTQrHk5uYyuRAfivZLuUxSTQb/bIU7eq3ktccxYvROPY+N?= =?us-ascii?Q?IIIyXCz2dLI0BdV6KQMhiWLPMEAdSjwZfZIfbdV3A2RoVEeklY4+U0hoJDOR?= =?us-ascii?Q?pqBtMqjMGnbHDQ9l1Cp8zN7QbktKCUvp+s/L/4NbxIWrCGA7yoOrxDbTpQVF?= =?us-ascii?Q?sJp5d8jgcfgUbifUGeqRNLwDgyQJrt4jQhfCF9Fz1HNXwDCqYplI0PVZtd5+?= =?us-ascii?Q?7hTdil9DPlF2lIWPcVWqa9oheM4U1pe4Ds22YO7qB+Y7bSupoZR/nT9lZxb1?= =?us-ascii?Q?p/8GlDykBR3cUssLu8FSZaFSBxtkaa8n8fBYKZbHKnk7+9iVlYPq2dcH3Tks?= =?us-ascii?Q?uwYi04rbhdtXs21EQCmage5BfcZggrWWTVZfHmtnALF1LoMkctr1kWsbia4A?= =?us-ascii?Q?HniBJFN8OQrxDpQIMO4ARKQlr2zTL5MXoxqbXQx2N8e4GR9AuPUIvRkYRkHX?= =?us-ascii?Q?N1wQLLMUU3mncw1QysTbBN96TPnaRWp7B3Jr5+4vQBOM2kLdaaqm31l704iL?= =?us-ascii?Q?Gq7hVfbP8F/kVsPkU0/O9hnShuNWcZrBxBxGVO6hfN1hiEIdwY1OSZi3CR6n?= =?us-ascii?Q?bBWpf0YAM/tgimGEBUK27HGhxntbWsC+O0H7UosrnRs4houzbbO6bOQvFtum?= =?us-ascii?Q?u0o9t4uWD1y4fqlzSHJN3oCZ4a58zVuOAEVfuROGOoAryHUzxsR+QYIFUJVl?= =?us-ascii?Q?1lbL3YcjCdPIixPnOasT/E5DQwUEv6Wo1hzLR/ug1CUa67SJhoDRfi44AnSE?= =?us-ascii?Q?/UHdyHgCZOADTw4cCX4IIQ8UohPr/TXnaundfntihG8UAPfDOFPIi3mHf+Xc?= =?us-ascii?Q?4KE3lY1nkkzhuImEsYBi2XnwigNhmRKon2ycfLCOGyYtqq0+S6ELbzyIEPVU?= =?us-ascii?Q?dEDyq5QwEw=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 007299c6-cd7f-45ab-5324-08dee4f03620 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2026 17:15:48.5366 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YpYMVgnkfCPmvpu6y6Oz05Gx1f6ZWJy24YMa8xyhh7bEI48cI5e6AQBqpih42SLpZ4jkjWs2zrzgbS6SZZZJbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7276 Content-Type: text/plain; charset="utf-8" The trace_rcu_this_gp() wrapper forwards only the rcu_node structure's fields and the requested grace-period sequence number to the rcu_future_grace_period tracepoint. Its rcu_data pointer parameter has no users, but every one of the ten call sites must nevertheless come up with an rcu_data pointer to pass in. Remove the parameter and update all callers. This also allows rcu_future_gp_cleanup() to drop the local rcu_data pointer that existed solely to feed this trace call. No functional change. Signed-off-by: Joel Fernandes --- kernel/rcu/tree.c | 23 ++++++++++------------- kernel/rcu/tree_nocb.h | 4 ++-- 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 03a43d3d2616..ef553189ee24 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -986,8 +986,8 @@ static int rcu_watching_snap_recheck(struct rcu_data *r= dp) } =20 /* Trace-event wrapper function for trace_rcu_future_grace_period. */ -static void trace_rcu_this_gp(struct rcu_node *rnp, struct rcu_data *rdp, - unsigned long gp_seq_req, const char *s) +static void trace_rcu_this_gp(struct rcu_node *rnp, unsigned long gp_seq_r= eq, + const char *s) { trace_rcu_future_grace_period(rcu_state.name, READ_ONCE(rnp->gp_seq), gp_seq_req, rnp->level, @@ -1026,7 +1026,7 @@ static bool rcu_start_this_gp(struct rcu_node *rnp_st= art, struct rcu_data *rdp, * Note that rnp_start->lock must not be released. */ raw_lockdep_assert_held_rcu_node(rnp_start); - trace_rcu_this_gp(rnp_start, rdp, gp_seq_req, TPS("Startleaf")); + trace_rcu_this_gp(rnp_start, gp_seq_req, TPS("Startleaf")); for (rnp =3D rnp_start; 1; rnp =3D rnp->parent) { if (rnp !=3D rnp_start) raw_spin_lock_rcu_node(rnp); @@ -1034,8 +1034,7 @@ static bool rcu_start_this_gp(struct rcu_node *rnp_st= art, struct rcu_data *rdp, rcu_seq_started(&rnp->gp_seq, gp_seq_req) || (rnp !=3D rnp_start && rcu_seq_state(rcu_seq_current(&rnp->gp_seq)))) { - trace_rcu_this_gp(rnp, rdp, gp_seq_req, - TPS("Prestarted")); + trace_rcu_this_gp(rnp, gp_seq_req, TPS("Prestarted")); goto unlock_out; } WRITE_ONCE(rnp->gp_seq_needed, gp_seq_req); @@ -1046,7 +1045,7 @@ static bool rcu_start_this_gp(struct rcu_node *rnp_st= art, struct rcu_data *rdp, * rcu_gp_cleanup() will see the marking. Bail to * reduce contention. */ - trace_rcu_this_gp(rnp_start, rdp, gp_seq_req, + trace_rcu_this_gp(rnp_start, gp_seq_req, TPS("Startedleaf")); goto unlock_out; } @@ -1058,14 +1057,14 @@ static bool rcu_start_this_gp(struct rcu_node *rnp_= start, struct rcu_data *rdp, =20 /* If GP already in progress, just leave, otherwise start one. */ if (rcu_gp_in_progress()) { - trace_rcu_this_gp(rnp, rdp, gp_seq_req, TPS("Startedleafroot")); + trace_rcu_this_gp(rnp, gp_seq_req, TPS("Startedleafroot")); goto unlock_out; } - trace_rcu_this_gp(rnp, rdp, gp_seq_req, TPS("Startedroot")); + trace_rcu_this_gp(rnp, gp_seq_req, TPS("Startedroot")); WRITE_ONCE(rcu_state.gp_flags, rcu_state.gp_flags | RCU_GP_FLAG_INIT); WRITE_ONCE(rcu_state.gp_req_activity, jiffies); if (!READ_ONCE(rcu_state.gp_kthread)) { - trace_rcu_this_gp(rnp, rdp, gp_seq_req, TPS("NoGPkthread")); + trace_rcu_this_gp(rnp, gp_seq_req, TPS("NoGPkthread")); goto unlock_out; } trace_rcu_grace_period(rcu_state.name, data_race(rcu_state.gp_seq), TPS("= newreq")); @@ -1088,12 +1087,11 @@ static bool rcu_start_this_gp(struct rcu_node *rnp_= start, struct rcu_data *rdp, static bool rcu_future_gp_cleanup(struct rcu_node *rnp) { bool needmore; - struct rcu_data *rdp =3D this_cpu_ptr(&rcu_data); =20 needmore =3D ULONG_CMP_LT(rnp->gp_seq, rnp->gp_seq_needed); if (!needmore) rnp->gp_seq_needed =3D rnp->gp_seq; /* Avoid counter wrap. */ - trace_rcu_this_gp(rnp, rdp, rnp->gp_seq, + trace_rcu_this_gp(rnp, rnp->gp_seq, needmore ? TPS("CleanupMore") : TPS("Cleanup")); return needmore; } @@ -2252,8 +2250,7 @@ static noinline void rcu_gp_cleanup(void) /* Check for GP requests since above loop. */ rdp =3D this_cpu_ptr(&rcu_data); if (!needgp && ULONG_CMP_LT(rnp->gp_seq, rnp->gp_seq_needed)) { - trace_rcu_this_gp(rnp, rdp, rnp->gp_seq_needed, - TPS("CleanupMore")); + trace_rcu_this_gp(rnp, rnp->gp_seq_needed, TPS("CleanupMore")); needgp =3D true; } /* Advance CBs to reduce false positives below. */ diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index 373b877cf171..c4a5b4662b3a 100644 --- a/kernel/rcu/tree_nocb.h +++ b/kernel/rcu/tree_nocb.h @@ -802,12 +802,12 @@ static noinline_for_stack void nocb_gp_wait(struct rc= u_data *my_rdp) nocb_gp_sleep(my_rdp, cpu); } else { rnp =3D my_rdp->mynode; - trace_rcu_this_gp(rnp, my_rdp, wait_gp_seq, TPS("StartWait")); + trace_rcu_this_gp(rnp, wait_gp_seq, TPS("StartWait")); swait_event_interruptible_exclusive( rnp->nocb_gp_wq[rcu_seq_ctr(wait_gp_seq) & 0x1], rcu_seq_done(&rnp->gp_seq, wait_gp_seq) || !READ_ONCE(my_rdp->nocb_gp_sleep)); - trace_rcu_this_gp(rnp, my_rdp, wait_gp_seq, TPS("EndWait")); + trace_rcu_this_gp(rnp, wait_gp_seq, TPS("EndWait")); } =20 if (!rcu_nocb_poll) { --=20 2.34.1 From nobody Sat Jul 25 04:17:40 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013001.outbound.protection.outlook.com [40.93.196.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F59525B0A8; Sat, 18 Jul 2026 17:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394955; cv=fail; b=Lw+E4BWp7gvSgUxjDySu6NR3ZXdf+XhWp2/kKG/WletMG/dKDMqpuFYP793/Jp0xQ2AzNpdSEIRarwaJD4ctBhhecD5pjovcjF6uj+h/gTUUXtzaJS+9394CLuTcBhxDHRQC0NegR0yH1Xxq0Z4hfdCIf9ex5RvbIGaDm06/CNc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394955; c=relaxed/simple; bh=PBAy84dMWZhOYbTjFpc0Yxn2uZ9pxYLShLttP+gGge0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=LuDT23jBaC1nnR5EAwfT4t9gfBFjcQHf3gn7DRoyoYVZyhKnUZiKQJvi3FYy7+O9PQk/EgLEkeKfEnJwLrwxEhD9jqqRwTmMdE6oi1jPvZHjyM2mTlYnkWpfT+QQmHguoqDYD/LRdcXgLSZQIrvzGVDCoJMwscyMg7VO5KpvHCw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=kIkZcAlf; arc=fail smtp.client-ip=40.93.196.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="kIkZcAlf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dz5r5D0x8eQ1czM7s++T3h1/sMAI3W1owcF4LVgb09F1Zr706fpyEVuBLLSIx7uJMDgBhdMYDYZRjQ2nQ8BlbRTdh5S6NzQjEKzPz9Qn1WomM1vf76Vr42QkU7XP25kLyLrpDu0yzgLrxca0GUaEKIsAHCqwl9qpbJSspaTMtuYlgGXf7UHTDvG15YB0n37FivoSQxzLmfl6ThCnnMEb3pRpifBSVksRGDKCJvje9oTSQJpXRMMlBOpXoauS8R1e8lO33pTorYJvCWBM5ASliwD80Ng3PyH+u2R4/Rc8iw+Bo8pinufD3tpuOsImMBZsNJq5BbXVH5mtxBin/Qp06g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/VJKC2dEPNA56Bm52vzsOQmmjObCh+OFRvv/Q2pci9I=; b=LW5IGLxANsnJ5MfD/rjZu3qvqZlu3hAb1uk+j39mQQA9TgHtUs80q6QfCgK8hGGE/X2qNuv8SW4NukDDtBt1Tk9tLjDo+oUIHNrek2qnF2VOBVMjbamkBkK90/mJsRmRmNRYRaepilHgVhiSEKWgDcsXUTZl8mNLlcyA7bKj3H/rUPqhSQzFbvoqYvsueu3/hJ9gZBWLN/NzXgkVjbOnqzC+33szy8O6rnBqGAZpan2eKPPuid/+xA3S1Pk9WOYiO6f8lzuu3iYqzAlByrUu2rrOkgOdu1Dct8qCH0n2zalmvieia1BQXqXA37Og642bSdFQ+Uv3F7vCiXP4CkjLjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/VJKC2dEPNA56Bm52vzsOQmmjObCh+OFRvv/Q2pci9I=; b=kIkZcAlfZorWSKjoluWyTZesv4VDGiNH++i7nc9wPMSiodTysFG1UtMdIeFcZQ3Zdd41eiCEYV8+VQ9KuHC4wPdMxX2qt9i+jEAt65klS24X381VfLGyTAqNVx0FqiMsIjzN+Z903gJ150RMFQVEd4/ezv/V9ZYufRSWnlPmDcbsS1+A92M+k6zlbBtZhQ562zn4P2LAJ78eAni7AUDgvvthKNVUUcEJztTC/w1wB1Mx7EPppMPFqTCGQ9JmMiVaJ6rUJmv33gtYC3pzuGYFbAkGkMTz+1KrFyDMssWrKmKVqVuKCHXsJcC2F2ei7j02WP+hLRp7Gi7a6JjRM88cQw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB7276.namprd12.prod.outlook.com (2603:10b6:806:2af::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.13; Sat, 18 Jul 2026 17:15:50 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%6]) with mapi id 15.21.0223.012; Sat, 18 Jul 2026 17:15:50 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org, "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang Cc: rcu@vger.kernel.org Subject: [PATCH v1 3/6] rcu: Remove unused func parameter from callback-enqueue functions Date: Sat, 18 Jul 2026 13:15:34 -0400 Message-Id: <20260718171539.3781595-4-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260718171539.3781595-1-joelagnelf@nvidia.com> References: <20260718171539.3781595-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0PR03CA0014.namprd03.prod.outlook.com (2603:10b6:208:52f::30) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB7276:EE_ X-MS-Office365-Filtering-Correlation-Id: 4351233b-796c-4a7a-3731-08dee4f03770 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|7416014|1800799024|18002099003|22082099003|921020|10067099003|56012099006|5023799004|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: Bgiz3wF/KMW++JjYMbBsXI70y1OTNUnVF4YOLU08tqmM/KKHuVcgqZ6VjVvNFedBywQoGnoMxMNKDBQy8/Z4ZNBeqXd3FpOAdf1aA885BBL6ugGfwCxcCrEcTDwVOgVwZVYTV7+8gKRlGNb/eUlmhwM6cHWCxZJfzXULjqCWq5YxtiKa03z282Bz+9ZY8BCWjwNka3nTKcPFyODKF5Tv855dr+ZXyUE+9iOpJtmWyboEa7TOaXv06NhJQRKVHrsiruHqwgx/9/UbkdEcQ6SNFzkFz9Iq2pMsIHyo0+TTK6o7z59bGkaKzoSJEvJBoaNxNkXm/VrcCkxAaNUelX+Amf+RgrjV7mmCVC1uPl1T7V3k760I2rTQB2XItrfwUcMvrLpqQR9VuyLG5ncHPOuEOYGuOjUH7foKPiT5v3nu6VQyUmdMF4ErnAKkZEC860iAZfrIT7Qfw0W4rMqSKP5lmCwof4Lx1+UTLYuB+IYy8RfUgYywCVstutBiXaxeDjzkKkU8wMXLaSuh9lkhoZfB+QA9LK3fNzgUjBRJ3WtoPWNuxI6lyssOHGz7RIizOKiC3UP/yeEB7e3DBJvAyogMsz4SK7ksOMcJ4EpWehtjGzx9ejKMzUpE1SjKUCzKdvvYyE05bxrq7m1tVLm+6cRWlO1eXgt3yV/l9rD4coKIkwbFFm4apQ//nVY87r5RYJoHu21qIXQ3wr63ZyySya3qBw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(7416014)(1800799024)(18002099003)(22082099003)(921020)(10067099003)(56012099006)(5023799004)(11063799006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9q5ec3EvlfoG1Nt4YPVxNE5h5rzFZJQBDLxMkdWctndcOCIFnEP4REhQNtuF?= =?us-ascii?Q?1TPlrhnhYt9bPa+xJhqILoSkDTDmu8G9bgMLaNJh4Qhr8mIc5O1JgcAMZAN+?= =?us-ascii?Q?NIZw6wurCULYbaRzRSvTgCh1Epayqsz6HWzYg6/7Ob5B3rTWzDkl4mAGlNKL?= =?us-ascii?Q?a11I2fmKC7kZNGXOPUTMDWgtisaQTad3rJn2E+pG1AW4aB73sMKtCGIo3fI6?= =?us-ascii?Q?yweC489WGbXKz7mDctTOvsUrcQ9ZgFwSw9vbQTHo96VJU09VlbrF2SI/Intx?= =?us-ascii?Q?t6dHObwehxBq28fx6vr9Qa17xBJcc5eq8/cEgYiPQ1fW9tLKWjiAdCrPCvz5?= =?us-ascii?Q?zdonO8wkacTC48ztL/8JtH/e+fHnfpnoZnU7D3Qs62z9Wsu4nfYWSkG8SiRe?= =?us-ascii?Q?CxWqIPJdoo0KdeSWN6Rkk5QpZ2kcpQDj0c3o+Zflej+3kPDHlso2tHiMSc8y?= =?us-ascii?Q?rdHUM8LdBYRqRKjy4yAFO/OKUfgk2s0onYRgq8hp2JnWyNbbuzsSvwulq+v5?= =?us-ascii?Q?AjwH3uEcB0cQ86vL1HTISr7HEiL3gb0zG6MHWGd5+EpGTVzLOJbT9COS+n6d?= =?us-ascii?Q?XQHeRDD2vZ9GvwFpSR/5uO7pEjX+NFwKt9Xf7kNDIuqkWvDnf+fniCwdEzSP?= =?us-ascii?Q?GtSOLic8ftypkHjd5f5TMYIPN+uwMZF3iZl+jbkcGXUODJWWHpf+2uvxpEjF?= =?us-ascii?Q?M8rUMJCltpsS+r5mTyZo7ujFLhllRZ0Y7kDL1ka/x9QppojhSht22YGP6Zqm?= =?us-ascii?Q?bSqDZ8d09mkpWHcMy1o23FQ9+67KZGaiXQU9PWz4i4n7Yru6kjNtb1wWV0wu?= =?us-ascii?Q?SwVzMIsn9J727w3sMqkZeianJhfPDH8CHBdLCGZ/FNcGDeAiNL+u+uwJsfim?= =?us-ascii?Q?zHlbq2nOfC9ZX1F3nmovkEY//zX/96+/fD3EjL0uxd6yAsKBvCEN4cMBPkfe?= =?us-ascii?Q?XkVWa+3SM878Q/QbwzvTq3WrVYCyMJkibKejvSlyeBiA0mMtUtkby5S/ZHFV?= =?us-ascii?Q?6Cqq9mB/4fu+t1IkzCdD3/FBbp6c8pgBMjZtQJZloEGy/C8B5dHMIbmy7MgR?= =?us-ascii?Q?8exxxMXcXdiZI1WdjQ0WHxAT76L5v+1NPQmy5QsOPht133bKrZWFtw/omiKl?= =?us-ascii?Q?NUTbWOnoAXwR/2x2DbhvURRkm9OrzixIB0Cz154JhbXb3t5ra79vGNxhqpYl?= =?us-ascii?Q?ImRx5Wvmvq5p2PHf3+l8Bmc2DlCtl/w6PRGh8cukfjKyQn/UO9h2mQmQWzOL?= =?us-ascii?Q?dw/cg5dYS4SgQmhDaRBsE/4dnz6OkGsfBQoNJlJBDbrRT0BMXNczlaZj7qT3?= =?us-ascii?Q?VHPxN+TdqJYNTOiaow7thMrAFCcQU2GujNlYgpP9gktCBr5TIsHdgJk907wA?= =?us-ascii?Q?hahI/TIMPnGDdjSHH9ZfLiiKp7cdQpYoFHwd4cOchM0EXbCd/nMPaOP8kkvH?= =?us-ascii?Q?L3OliwxwlgvB5hXuhkutCDisVG5hvW2rS6056lcrZRcCq2mT3S7EioFadRoW?= =?us-ascii?Q?537S0hZoeNWcrLW+/60wD0QBuwlLyQ/V3U3TfFVYk/3kLg4Til/Gb39RKKqY?= =?us-ascii?Q?ysRA6FguVTFgYUVqELEACmgULGqXyOBvJIS9uPvI/zMgiPJ9kWhQFA0U8AIa?= =?us-ascii?Q?sOYZGk71t6foVLJ4rEOd/mGk5aQ2pFdixlSuJUnsuxJpnmvZ057fd1HASCNG?= =?us-ascii?Q?rv+/YGFX8HZEkKbhbt8gvNT1Rc9MrN11/F27vRiNp24qHsOUgYQDPoT1EDdN?= =?us-ascii?Q?tUaqsJF4fw=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4351233b-796c-4a7a-3731-08dee4f03770 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2026 17:15:50.7497 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RlPvRJgJ5UMluCh/+Hc+0hD33vSVQZwz6HTkV6FUJ9Wt4ze4EheG3gw5yrsXhuKn86ACMMRH3cU6neSVoy3WeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7276 Content-Type: text/plain; charset="utf-8" Ever since the kvfree_rcu() tracing moved out of the callback-enqueue path, rcutree_enqueue() no longer looks at the callback function pointer: By the time it is invoked, __call_rcu_common() has already stored the function into rhp->func, and the enqueue path only adds the rcu_head to the segmented callback list and emits tracepoints that do not take the function pointer. Nevertheless, the function pointer is still threaded through call_rcu_core(), call_rcu_nocb(), and rcutree_enqueue(), forcing each level to carry a dead argument. Remove the parameter from all three functions, from the no-CBs stub, and from the corresponding declarations. Anything needing the callback function can still get it from rhp->func. No functional change. Signed-off-by: Joel Fernandes --- kernel/rcu/tree.c | 10 +++++----- kernel/rcu/tree.h | 2 +- kernel/rcu/tree_nocb.h | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index ef553189ee24..f741654e80e1 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3020,7 +3020,7 @@ static int __init rcu_spawn_core_kthreads(void) return 0; } =20 -static void rcutree_enqueue(struct rcu_data *rdp, struct rcu_head *head, r= cu_callback_t func) +static void rcutree_enqueue(struct rcu_data *rdp, struct rcu_head *head) { rcu_segcblist_enqueue(&rdp->cblist, head); trace_rcu_callback(rcu_state.name, head, @@ -3032,9 +3032,9 @@ static void rcutree_enqueue(struct rcu_data *rdp, str= uct rcu_head *head, rcu_cal * Handle any core-RCU processing required by a call_rcu() invocation. */ static void call_rcu_core(struct rcu_data *rdp, struct rcu_head *head, - rcu_callback_t func, unsigned long flags) + unsigned long flags) { - rcutree_enqueue(rdp, head, func); + rcutree_enqueue(rdp, head); /* * If called from an extended quiescent state, invoke the RCU * core in order to force a re-evaluation of RCU's idleness. @@ -3175,9 +3175,9 @@ __call_rcu_common(struct rcu_head *head, rcu_callback= _t func, bool lazy_in) check_cb_ovld(rdp); =20 if (unlikely(rcu_rdp_is_offloaded(rdp))) - call_rcu_nocb(rdp, head, func, flags, lazy); + call_rcu_nocb(rdp, head, flags, lazy); else - call_rcu_core(rdp, head, func, flags); + call_rcu_core(rdp, head, flags); local_irq_restore(flags); } =20 diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h index beb86e39909a..aaccc57e75b1 100644 --- a/kernel/rcu/tree.h +++ b/kernel/rcu/tree.h @@ -502,7 +502,7 @@ static bool wake_nocb_gp(struct rcu_data *rdp); static bool rcu_nocb_flush_bypass(struct rcu_data *rdp, struct rcu_head *r= hp, unsigned long j, bool lazy); static void call_rcu_nocb(struct rcu_data *rdp, struct rcu_head *head, - rcu_callback_t func, unsigned long flags, bool lazy); + unsigned long flags, bool lazy); static void __maybe_unused __call_rcu_nocb_wake(struct rcu_data *rdp, bool= was_empty, unsigned long flags); static int rcu_nocb_need_deferred_wakeup(struct rcu_data *rdp, int level); diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index c4a5b4662b3a..9e5757e6f875 100644 --- a/kernel/rcu/tree_nocb.h +++ b/kernel/rcu/tree_nocb.h @@ -603,13 +603,13 @@ static void __call_rcu_nocb_wake(struct rcu_data *rdp= , bool was_alldone, } =20 static void call_rcu_nocb(struct rcu_data *rdp, struct rcu_head *head, - rcu_callback_t func, unsigned long flags, bool lazy) + unsigned long flags, bool lazy) { bool was_alldone; =20 if (!rcu_nocb_try_bypass(rdp, head, &was_alldone, flags, lazy)) { /* Not enqueued on bypass but locked, do regular enqueue */ - rcutree_enqueue(rdp, head, func); + rcutree_enqueue(rdp, head); __call_rcu_nocb_wake(rdp, was_alldone, flags); /* unlocks */ } } @@ -1666,7 +1666,7 @@ static bool rcu_nocb_flush_bypass(struct rcu_data *rd= p, struct rcu_head *rhp, } =20 static void call_rcu_nocb(struct rcu_data *rdp, struct rcu_head *head, - rcu_callback_t func, unsigned long flags, bool lazy) + unsigned long flags, bool lazy) { WARN_ON_ONCE(1); /* Should be dead code! */ } --=20 2.34.1 From nobody Sat Jul 25 04:17:40 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013001.outbound.protection.outlook.com [40.93.196.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0950C3E00BD for ; Sat, 18 Jul 2026 17:15:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394957; cv=fail; b=Y9w5DiuHyvSQEtq2vAlxGio95Ee7uEGyAaUeBuzwwiGraaOOAPVx013fBnP5zOOgDBxo8fWycfC32qAh1Q08+564obmvqk0x26zwItY4JFT86t28mM1+AYmnRg3Syf8itmGbe7/GTVQI5R3NDffSAO4Yv92VUoHuj+fpiCOO5cI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394957; c=relaxed/simple; bh=0PcazMoXnEHj/tGBYZQSPqXcy5yvtsCRkmN8HQp+d2Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Y4EEbt5s4uJ2+V/GyXmx2/ByPu+ZanglVehra9X7VX2jERjMZpzO0wUdf4gefY9VrpLkiCBgfmD5G6aaYDpz4q7jVYHwTBuLPdqDaRPKwbSAIfLOMQnto9z7x44Ajx5f7kyCZ7wX6iIZebHN+lJdbyDVSYhnzzN+xgU4KAwgTQ0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=GqoNixGP; arc=fail smtp.client-ip=40.93.196.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="GqoNixGP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iEBq1uGWAG7rJCe/tRGDHWqiS3eerDBaNKMFKbIHBvzYTVeH6GFZlB8T/ime8dXYEZ5Mu+gEptDVmDcl6S9ajy9kK0wfxaiVBHidiul3jvbJP10cITLDgIlwu9CdhIni4sjO6AEini0SMMYKWpFdS43CazLJxj+8NhcQGgCK1rdqkmEnn0kgHe8/0Rm7w0OD20reDGupBP3rQ75TK5FwLxuPe42EiJQKvnEmQPakER1XvWvXXcnRwDX6pa/6bXO6fusA9BBsbv3rJ/WluYW+UY+kIHESTYsnCVloTl5AHLrXhRTcN48d1adzi/s026/nNNVsvnk5oSxK7mW/Re72Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=98sTwwkCp7+UrCTR/JLHPF0xeptGngDtkDwrPHFpo2Q=; b=RfAhJWG6SunDCEEWX6vMnBGKfY0gyQTwrk54syiVgAhbQdUJRG4OIHdSS7W4Q607yqa7pTMl8ECiJ2rEUVIh43u57kSC2y4BB4hhFmyzko+qbg1TEX8kDmS2uJeYkmBn3FMUHy9Nh7iZO7ZtEIUP3MHXMZMIkAkkaCHCHGmVEZyl2be3tPQZF4/VZa9edbCGm+/CK7J74AleMbe6iSHt4LVBFeyCVrIjIKHK3PgNl/tRGGtwh4+A8wS4Bbbt9PGQ0JJq2lodp7ytL9HsoxJHzGpwWr4ZatbV1UwsIU/6etv2rYLSs42ezMm2prGizUjAF9X9tCxMp5aozWOzQl/+Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98sTwwkCp7+UrCTR/JLHPF0xeptGngDtkDwrPHFpo2Q=; b=GqoNixGPapwiIV3z9jcd9ZmSCdhvVQwJ9LBAEFErU4e03SXkJrJWEvQIASxINNbAbfqkLks+ta6bot0gGvxB2wchT7UBdLJRJBFTYR0/Ob+jtgtWGM710yA7x/nzMGkZszva7nButbOI6bUdVhtSwXb5XG2nmZbGPc1rpQS2UZUKgufNRW4ExJD3ac1rACOkHLRXOy9hZgtk0Dr04VmkgAXUSs/x8pxHLB1fbafL/gp5VMGXRuhm9Ak110JhZ1YwagZ8hETKsywU1zcJ2bbcSTl39rGCW6UJZGUKaoMwCqYFT6pj2DLJaXNez7LcnYMsLS+T6zXEztFiWD3p1njD3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB7276.namprd12.prod.outlook.com (2603:10b6:806:2af::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.13; Sat, 18 Jul 2026 17:15:52 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%6]) with mapi id 15.21.0223.012; Sat, 18 Jul 2026 17:15:52 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org, Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett Cc: Joel Fernandes Subject: [PATCH v1 4/6] torture: Don't leak shuffle_tmp_mask when shuffler kthread fails to start Date: Sat, 18 Jul 2026 13:15:35 -0400 Message-Id: <20260718171539.3781595-5-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260718171539.3781595-1-joelagnelf@nvidia.com> References: <20260718171539.3781595-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR03CA0102.namprd03.prod.outlook.com (2603:10b6:208:32a::17) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB7276:EE_ X-MS-Office365-Filtering-Correlation-Id: 448ff060-5e5b-46e6-5c25-08dee4f03884 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|18002099003|22082099003|10067099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: ueiUHp9Ffy+NPj3iqpbgTmxsErvbczr6szyiuv62dn7GV9NMPVHXGVfDKG0otue8HRAeTv0Uq3Qm8CIS20vuMGJdt0nwO214j7U9jgmc2LJjB2N0sKAEmgNtu8GGLJBEdoKmcbNaNxs746SUMNZmlNoxhXrcd6e1sPepc/SInjyGgD5m1iwEg3lsURIkPSUQW9GukT7gDw0cez13KVRhOb6uML+BIpKUrtrJDxS8uM803mn+9ptlbEpDUZmPhljxGZckXu8F2gNUO8sYAYkXu9CSjMZN8CNRbDrEQxFWtdQrdfewvIJ1oFb1OczGzimKaMtG9XfI0TO7pEB4roq+7Wb6WrLaVz/u7LZSKfHiAq3z76Hannw0O8WNrBllcJmGOpyrRD4V/8H5jDCRn6DvdcybQlT9OJruZJmJ0Sd83Aj6IbBNLOY8Y/svTeU/DzlIH85qvOWMX863362f8lNqS259ZoSDv0dz5hOsez0GofdTO5U6Knv3PZvmnGsMOO+nHyBbEjXKr72NVUilvJ9D+Sr7n1VU5CkdFrcqn24TcSGlr4Yfg4CqylN6otE41GyTur+YNcH/DR3E/+JyetqEhHFX4X/5uzT/1DXCpI7f5lUW3PJmQ5zzM2qaclsjPPjoGPVvFzp7Gd2rZrpewrvwV6T4GFg7vvzodP70nebzboU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(18002099003)(22082099003)(10067099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DPRbc/ENmMllqmTkAZGHFsXvhgrPxt2sesBdl0YeyZ9JiRmBqn0dQgCe4GsF?= =?us-ascii?Q?xEbRPuNvEC4KWQZg6WpbpkmasuylQYBZ8xCbLuIAZEftsQvP9PDVoTTv16b+?= =?us-ascii?Q?QbhXYnsZh7j6aW1Jef/P5SVjLN9KSvLwyKcxGyyDOuiAq6jBzmG0t4lsQxrO?= =?us-ascii?Q?w0hZ/vVTGYj6gbAVRg4eti2XTvhJjux+pKw99UJKGBDLSHXdQPJFVhO1PX52?= =?us-ascii?Q?fAjQK7TjNOByxQcx6sz+fWGPliBV92TUXbNZg338ga3GcQuovuMRmGXrEbSi?= =?us-ascii?Q?7Yb2QzRn+WCTD5o8sErpvhGOLmc+OJI/rPN985Pba7hmKmjlfybSArwiQYAm?= =?us-ascii?Q?6RZv1cNN0dlzgp9xaYcV/OoqybqPUTXCqv4WpkhS2T0/ATbnOSqqcCI9vMd+?= =?us-ascii?Q?VU2twXVqEcRGGCZfdUjzmrZqqkNE/Bv2EXVOFUAC6/6EHVLz6Wh8KBPrbxOm?= =?us-ascii?Q?KX/B0hvtatdfDeW8z3MTMP54XtvTkUGzbvF/E4+MxQ6sprSKWU+hzimkfqPu?= =?us-ascii?Q?WkSsvOdX7Z+dtHC91vwbL8FV1ni8UxM8P1pPkjhArOTby1ICOnR28GBBO3j7?= =?us-ascii?Q?ZEG6enJu0KxcPwmSADmA3u9Lua9ikweZGc8wQ5xMhqs+3zSm8CdgJTRzTXa5?= =?us-ascii?Q?hY6GTcR3SQ1YDcBrbasKfqb79nGSbBMVqV0JT8UvTyztNI5HWfNHa0ESaqdJ?= =?us-ascii?Q?rzudb5tRW4nkBOSPg46c6pjx9AhMUSbjeQut9AzhS1WVcw34ndLswUyWWUH9?= =?us-ascii?Q?GgA1p3HFrrHSGpXnIMbJEVqNuKLzeETX/tt22UvrEpR6bcIdjxXFA2OR8GBJ?= =?us-ascii?Q?P0uoeZO+60Tcz076P1e5jARps+nHKmVLC7sncadNtrTAWyOjTIQVvg1OxVmH?= =?us-ascii?Q?PDEzCKTIpDDCt+U1M87RCasqace8kv7rW/vXNqppKO2vqy5JBloNpNDAmVed?= =?us-ascii?Q?jPFA7bKRcWyk1dyuJGgbqGdIlpwa7U3n0JbYyqDvH5f0h5iDajFh802BeMZ+?= =?us-ascii?Q?lPCP22UZzJMe3NAsZNidkAFq011KvrLKKer8aALOpL0gS6qwEdPAlslLjyVw?= =?us-ascii?Q?1GAubskRIa4DHB59piZt/oC9WwpJcrqTB80phcFWXAnZii0nzKCwbi430KxE?= =?us-ascii?Q?29h1fLf6caI0R+FB8k99z/PUXah0nucnm5B5mU5814dGX2ai8sXai9ZobHj3?= =?us-ascii?Q?yx11JbSQrR7dfPYTUGRbYlNnZ0Y4bpBUs5mrn44z6ifrKb9tUCj62eDPpWzv?= =?us-ascii?Q?EVnNz7hS7w+jgecJ9DuE2Mkr8v3+kzpAG5BXyRTP3KHO7J6rtNYCGOW9PQBQ?= =?us-ascii?Q?C0pkRDVyeojxHKEguURGN8fcVJFHCGkp31/1DYaySSb9ceI3U8A5uOau113e?= =?us-ascii?Q?IurOH3GN7tT1gU4c1xfkilNMJRzJEc+Pu9X9cjKv9xADRd4iwH//+W7pd5fh?= =?us-ascii?Q?WsuZMhZyajPfw9vH73D69a1AO7mu3DVFjvQdDQLWyzYHrMGAZmo5rJnjKRjC?= =?us-ascii?Q?WtoeYYJIJM8CTp7y8ftJ8cxCAxQ0HemrJEiP/Cdfh/diYt1fcp8MAhr7lQBn?= =?us-ascii?Q?bC+95mcZpNjuRFzHs714oXoogSBtmf9FM8S46aXvYW6Z9VgH6XVBm/A12Qci?= =?us-ascii?Q?FBGwiCi4K8jQRXiiXpCm6ZwlsUnJxgvfzRRMe6wqnIAfEFa6v5c4uRAFlQ2A?= =?us-ascii?Q?/hxaJ2RW1HJnsxChjSIlWtL/ZXuXwNZlkTZhbBG0ERDgv7H8LoNy67K781Cz?= =?us-ascii?Q?HNOp+A1UnA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 448ff060-5e5b-46e6-5c25-08dee4f03884 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2026 17:15:52.5400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IvNQOrFDLVj2uWR052AlpUEXCqJSmMZBllCCmzL7WjEB/CrLiuUlMoi5RpISYF7nj4cSPi/PBVVAIwKqCF2jrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7276 Content-Type: text/plain; charset="utf-8" If torture_shuffle_init() successfully allocates shuffle_tmp_mask but then fails to create the torture_shuffle kthread, the cpumask is never freed. Free the cpumask directly on the kthread-creation error path. Signed-off-by: Joel Fernandes --- kernel/torture.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/torture.c b/kernel/torture.c index 77cb3589b19f..8c4e6b2fe8ba 100644 --- a/kernel/torture.c +++ b/kernel/torture.c @@ -577,6 +577,8 @@ static int torture_shuffle(void *arg) */ int torture_shuffle_init(long shuffint) { + int ret; + shuffle_interval =3D shuffint; =20 shuffle_idle_cpu =3D -1; @@ -587,7 +589,10 @@ int torture_shuffle_init(long shuffint) } =20 /* Create the shuffler thread */ - return torture_create_kthread(torture_shuffle, NULL, shuffler_task); + ret =3D torture_create_kthread(torture_shuffle, NULL, shuffler_task); + if (ret) + free_cpumask_var(shuffle_tmp_mask); + return ret; } EXPORT_SYMBOL_GPL(torture_shuffle_init); =20 --=20 2.34.1 From nobody Sat Jul 25 04:17:40 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013001.outbound.protection.outlook.com [40.93.196.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 690CF3DD51C for ; Sat, 18 Jul 2026 17:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394958; cv=fail; b=n8jSld7NjvBowiMSEIkZMM+EWBvD7iOQRDQAIdmck/dMnnm5imCEJXxMY8eoTN8a8IVxqEln3N4Ym3PxzrqklxzNZ42KLYyoza/GNLAE0QssHkcnE+XZ1Fg+A90CgxqNfqPhIELDjMHr87uvPSfuWVW9EVqR8/RUlUpxo2oDUlA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394958; c=relaxed/simple; bh=EGhuBsOsB4TTDU9ZDLTcEzmlLcZaUraHPklEhnHQ1EA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=G4p+6FROO3cDIo/d8pgiwmzcT7rU2xOEp8LHJbBK23hrzlHpPTBynX4VpCm8V5AlB4AXxftVUmLYeqVMc3rdNQ5e9TfmSoJQoZLlpGeuUKqRKtOSHYx7+gfjyX4bGlJGh4jPgL0Y0p6GTrzEPGCZKi18yj3bxIDtnnYndMXsolw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=cDp3I2+4; arc=fail smtp.client-ip=40.93.196.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="cDp3I2+4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EBKCuO6l9iLfIQhXZ5JkIXTp05GDvV3bItsrxe77QHWQExly0hjBMC8X0sAnV6Sj46U1kYYMtKBd3Ra3KQSTPerFPoARmIE71ry0U15TrJJM3KctlzjzdAvdDzcM+OkH50yy/XHxtw1nWrqjcISVl84sBn1pfffu3+FOSZ63VxX1MaqAe5CMDkK8/JkFcBW0O8gFJA/eFfJcQF2dNxQ0FITs16R20fOV3uz8EsGwhdoiYEZxcE9PMY0vwf/J1axqJGgbvV5++wEfFOzSsuKzjlnCUvSmLZN+/Ucl0KV6mxkusM14nvSYFtE7SQpERIc9KJK1n+5EvEsaQzFnFtJ1KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZYrv8ss89jcgHEyAIfAQgupentFP4LYXHLspyXmop9w=; b=rvH2p3o6PZPF4levh1xkRMZCXEXSL8/43OlUv/pboDr2820D8jFuwtplOGtgYBA7nPZHrOEK0JCrP+4lU2hLMLes60CPCpALW1GLmo7AugPYFCZ+0dzDp7CsewNICclK+1kJS2hijoL7h8CP7N+zTMMBZI47t9Tf0gj/RoGxvAtftSyp5KpSIpI4DLGuXJye35xmFYDHtept0zG32O9AynqVKqSbY7DHeLikuBr/YdX7N4HW0Ric5Klkb62/sE+MhI5j90ySC+lYxKOFZVsiG4Ov0q4VAVWnjpz2uDOHPEgwlCN+pK19VTNTZzcfwK5Qw5leB1JEMtlDVhYDTgFc1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZYrv8ss89jcgHEyAIfAQgupentFP4LYXHLspyXmop9w=; b=cDp3I2+45LgbZh3ljHEm3lD7SclWUerwh6YveI9y9puqSm2eSddyYfNOSbpIN5KqjhpLM7w5ectP/zF5VCOs8tVYdctSuZrwOOHCeQaJu1MUK4HqWJbVr2y3CjjD/DHxHL34ZFqT8nZdExWx4HRrXb07fN6K4Sz9QsHCKZLZamzDPHUn6qYrCC4233WqbtElp3GAb0fBhve/HxBCJrDoiMrItd4TrbF4EetV/U8Qjey5XZblqVdnY+cMItC+SC5agv5Tz7hSOyDL59EpuV4iDdMmyKVj5io8bWRqO6Rq1o1LLeNwV9vUxBpgQ2LUa2sHc5yjk7Xrn6fPz8cd7ie4Cw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB7276.namprd12.prod.outlook.com (2603:10b6:806:2af::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.13; Sat, 18 Jul 2026 17:15:54 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%6]) with mapi id 15.21.0223.012; Sat, 18 Jul 2026 17:15:54 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Joel Fernandes Subject: [PATCH v1 5/6] scftorture: Count single_rpc offline failures in statistics output Date: Sat, 18 Jul 2026 13:15:36 -0400 Message-Id: <20260718171539.3781595-6-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260718171539.3781595-1-joelagnelf@nvidia.com> References: <20260718171539.3781595-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR05CA0045.namprd05.prod.outlook.com (2603:10b6:208:335::25) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB7276:EE_ X-MS-Office365-Filtering-Correlation-Id: 54923382-ec30-4ceb-2e8f-08dee4f03991 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|18002099003|22082099003|10067099003|56012099006|5023799004|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: T+/5vRJE9JZH8wXgx5ntW87jDPGlOHO+VJBNsQR3AEthDKMpOnVmBDMVah685yBvn0BuagYM99HdMRZgj5vc9Eeg8O2BabAdT1bhoSJjvCs0UATWYpvPJ+fW9ztAuzDxffrcultGVmow1DgXTNm5liJqa6dGKDUjcCaYDINz/hPuR6SUfxoJv0TmzymvG+xYIHymIu3VrqtNgX5+bQYrUXy/XX+3nLbX4kE41faYsJoBk6l5M9WB1qbLDzvSn1zxLe3b3qu9gC+vmV8KozzpP8H1Bs+2kRFMByht+ZaBi/7XqZISTJqQ5OWDgyvDCsxNoUsuxbspeWPwJGpZVz7Bj1liDOGUE+BO/ibqherx07Ino2zW9SrxkFWXRs9aCprdvoF5YcWMasHCKo8pLKeZuoqut8Vh0wuXoBgX35uCDwyc+yNqcxf7BnHPv3Iecf/Qu4TQGkR76ndm9Se8D2kdSYMxBPHHD6wClGVXeZwH/bQdU/icq8hVWvzAJ1CpOheDonDkrQHnBqg490SoQjX3pI56KGyxnXNwKn1/pK3ZBzoJeSH8QYrQVm7VmPOJB1SUUbjmUPsZ4RjFawbGEkQOJ47ZCAm3KnaTrUwazWGth7m82KFkCxdRqYb0wkOk+vnAxHwBE8hOwe6TyeqMKAvOS2EKj/137FCKEBTnDCdIRgw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(18002099003)(22082099003)(10067099003)(56012099006)(5023799004)(11063799006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oGcFbnO3iRA8aHFAShEJS+25PsCG3M/yTO+gLivnMhTa6VFWXJD8v8uPvdaT?= =?us-ascii?Q?JqQpySDihroQRkhVegaC50pJq5py1mUhW24jDVn9GCxxJxiMTz/OEE1R73UE?= =?us-ascii?Q?uBXUSFFuI06A99M++O0b2ybztmllyEO4C5u3yDRLltaZRagR52n9ddYCfsZb?= =?us-ascii?Q?6rcSDed4f9Mi7l5sX0xIw5l48cpyjHEl/AnH/kz9g+ban/pb4e9DB+JczgNX?= =?us-ascii?Q?JK3k+I1ST6UOj20r+/nPy4c/9YBA1GxlFa73elH5vV1D5WTDjNvlAS8w9hUv?= =?us-ascii?Q?1c2woMbe+cV87sgeNrkBmhZ51P3OX6xRpFS41My13Tuua+qKuBJSAEH/Nwfc?= =?us-ascii?Q?M4nYxqqvHjp4ZKCPVl9q3NDZyJap8XdY4/5zvQgy5f79+Eg6TQd2VvUbXR7m?= =?us-ascii?Q?XpnhOO28r3V7heyLIo0X2pRd1c62Ad8sZNNpSmBR4mfvIMVNpyGB/sj7nqGS?= =?us-ascii?Q?wcv175OXjs8IrBCIEwMgFlpUKrp1OVIJp8HHiL2ge6E6QHz8W5XOxAtBO3a7?= =?us-ascii?Q?CQVYsfLkswnCopoXW3eYAwdgRgfuttTDdAcflZt713TXgdwejN+UeXt6W6Vo?= =?us-ascii?Q?m41T5kkpVU3xNTzBh+vB8F4dyBflLvL3nwhTYK9jIGW3HfWmyGWGu2daIrRc?= =?us-ascii?Q?w67p1sIVg58Q0kbRC47PZf0TyCxcLJcjoDQtb0pNMOPUR8tQZbZ8ew1e8+TS?= =?us-ascii?Q?doYNBi1b0iRlUvvpgSQKobdhvFTzvO+4td57UvOZ73Roc2rpFdng307hmSVm?= =?us-ascii?Q?Op2td43sLVpwVmcP984JHLCfGFgYjh0pR93QxyRc6pR2JOyuqXEg5LgU9Ktb?= =?us-ascii?Q?YVVRJtJruJ8OilLpwc/JqrO027AfjiYukVvJuD2qGOlhg579sI3jlxky+x5L?= =?us-ascii?Q?36qdE2SsbKCk72qnQd5C13sEIik9q6eAaVIPw26JXb/vikMH2MORncNwXMNB?= =?us-ascii?Q?R7wZHZmplrQR1c6tr93V8P9NKPsp9G+FRGmWzkz1Zn1DPkd7SyI+0JtytWxh?= =?us-ascii?Q?XD3J/3VBdt5YpXJWLr86Ir+OcYXeOKjRTa+go1XG1A+2z93yeLvb4Br2C4Xv?= =?us-ascii?Q?sJMB5X+KCixfBp5u4/aOzmUKZoL01Bkaf98CMv2i+RDxTwdw6Sp07OL6Ep27?= =?us-ascii?Q?+ARdC8jFW0pjCfsJd6G6x6j1gytz3knzKwsFZCMBrVaLvJMQX5FBLd2g+rb1?= =?us-ascii?Q?qSMBH6bK39uovWtpiecyufOPq0uCAhr6U2tmcAmVT3gf38zHjIihMdlDDPaW?= =?us-ascii?Q?jPfQQRXPVi8UEXGL54WlEZjnzBg4y1QO+5eSGqw9K4pL9U36jLkpY0RvtlGI?= =?us-ascii?Q?Ob1Ij154+u2gmMRmrxeBI/r4Q4MX3k0fHowRpVK/pZMa1p9Qd7+/9GUmbTzz?= =?us-ascii?Q?Z6+EeuKJU07kBGEzbXrdJ9c27ckMEXRdKOEvhZHAQA3FPhoAIGRRDkIUNVwb?= =?us-ascii?Q?/5iriOhLnSqRNqLZL5AnUsgZIJ+aRr5b3x0oYcvVsfvM0gZCZhR8bq0RbG9i?= =?us-ascii?Q?HBvJglXTDTr5QagcSkWqpkDRlHwKS2HRM9xkvfw34dfhJiXBkFk0qpl1QAac?= =?us-ascii?Q?6BBASP0ltzglxeALvo4lAj2Bp2oXIvQxlA2NneItabl7MYp5lVyTnyMdKPzX?= =?us-ascii?Q?8ifBOfvE7R2SDCxeQi0qdVQeLISiHZ/W8MgJo/ALHlDYPJcoh3IHXrmN15X5?= =?us-ascii?Q?UHMhAkWb/ivCfQZcPfoGlW+RfH+iBYMPgOrsbYz9/PyKm69IQZ43yoHp+C4S?= =?us-ascii?Q?1YWNJnj8TQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54923382-ec30-4ceb-2e8f-08dee4f03991 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2026 17:15:54.3003 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vDsz7UMm3OFvLXQUz6DV8eN1uqZWojDMbPIGmChy2vch3ZC2Q5LoUwG5nVSoi7lK6tf6zi8O/5V/GHK/fxY5tQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7276 Content-Type: text/plain; charset="utf-8" scf_torture_stats_print() aggregates each invoker thread's counters into a local scf_statistics structure before printing, but the n_single_rpc_ofl field is missing from the aggregation loop. As a result, the "single_rpc_ofl" value printed in the statistics line is always zero, even when smp_call_function_single() invocations for the RPC test have failed due to offline CPUs and been counted by the invoker threads. Add the missing accumulation so that the printed value reflects the actual counts. Signed-off-by: Joel Fernandes --- kernel/scftorture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/scftorture.c b/kernel/scftorture.c index 327c315f411c..ffd6c83732ee 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -193,6 +193,7 @@ static void scf_torture_stats_print(void) scfs.n_single +=3D scf_stats_p[i].n_single; scfs.n_single_ofl +=3D scf_stats_p[i].n_single_ofl; scfs.n_single_rpc +=3D scf_stats_p[i].n_single_rpc; + scfs.n_single_rpc_ofl +=3D scf_stats_p[i].n_single_rpc_ofl; scfs.n_single_wait +=3D scf_stats_p[i].n_single_wait; scfs.n_single_wait_ofl +=3D scf_stats_p[i].n_single_wait_ofl; scfs.n_many +=3D scf_stats_p[i].n_many; --=20 2.34.1 From nobody Sat Jul 25 04:17:40 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013001.outbound.protection.outlook.com [40.93.196.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B8523E1235 for ; Sat, 18 Jul 2026 17:15:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394964; cv=fail; b=GmdMWVzsU4IpHYqdLuK15soPn86Tg5HSI5fArsxGvSExxl1BAhcmvVrfLXb8OOyabNqDSKzuHgTxwHZvXcchLRWkxK4s750C33IqTJoq9cTKGSFHpZGrgfPCgZpcTMN99I1iUsaIrbOHkJSBF3fXgQRoNKOl38SQhw95zVOwK/0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394964; c=relaxed/simple; bh=tw9yuT8Q7OHCdNDVjXrMUSRDxLaU/LjTBpmehiGzNWQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=E3EO87p5YZZhtRiLe8+K8dCRIQAn5UY2qIJ3XVQGQ6/qsHPTvA75Dl7oI5P7nTm3uWfUjkl/DETSBbOCWBMe+V8MYoP21dH+vXRdl9o3l3uLwZZLQG9mSDvIM9Mr7gfG3BmfXoQeYpOpz/MEgHNB8ZbrzWqeYgrIgWilX4r2Hcs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=QgB0kqVZ; arc=fail smtp.client-ip=40.93.196.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="QgB0kqVZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TQytgZz5Ssr/jdmoIhEZoDMcGJxAF9CSduoCx03xsncUepUtL//9J4Xr8AmLDL6MQ5b4M4XZHajQLLY3KG7/gCe4306NgLbytz4d3xMPnusPCWO7mmFGiMp4sDDGd0xRFlpHnbZueZCM0Nlej4nDuXmLuZnXOvUdww5tMyssw5lIkQ4dr/8N4ilVP+dLo9qtZgm3ry0T+4u8H2qxvk39z4zeYKrNmsG7JIASw2NGGvDCFRuWsJhOdooR2ihdIwGWjMWFm30gn6D4f7+Ar88frYOoT4RRwDFr6h6C9cL+s8Bbw2B5NwGVlDHa/OkZ0AWlL917oHsh3FB04/QauzBQmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J2qBpkye6XHSr2zjnd6iY19pNjAqmS180DIWeVgRTk0=; b=bzz1GbWVrG0+dLHr+vULAmsiJircWmAVzkJKOCP8KJYA1Y6VETOeYhlCBJT39H4Hz8g3i9r9aSyha5eSpKMnXmsiHGLsVwLy8wvVhwTo2qIRjZoqslIbfO+qnCuZVvVM1Q6W1y9YcgaSfFMK/6qoYkZjeSuq7TYPuEdX/cEAv6AKEg6w6oeqfAhnoPnAtCuDT4yAmjlH6JXlxuX/eyl1MLSAniG2aLx5pITjqlEpwB5qS8uOkczDpJ/fYYQ9znQVTh2I/K73PMt5bVOVCVvaWFxoGr+7+1GEOm89JJm6avDkKjfakddM41zahN70MisXVNL8hKK4wghcNSohnghglg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J2qBpkye6XHSr2zjnd6iY19pNjAqmS180DIWeVgRTk0=; b=QgB0kqVZQa/5GX7IuubE9SS1CcpyptnVgvEihiZj7CpS/Pt+wxoBNc0Ma/FAnHfmia+hqC2v2d6LMkJjscteZ8qzT+xohhLU9x5eGBm78Dn3gh4cvuw98xUqZP3x6xfnEbvLB3daIqVvn5IdbMxxwj04DJsSST15kJdAY8IzYexTWhIAW9oBZnPOZLXh0va21T5q0+erKdEEUWAF3rMcaj/Pz8v00UKDdlmhV2yb7DqOz3w1PcEysGF9tNj5dwoHFaLe+hlq+4eRYpjHKRdy4cROqw0WiqfDoWRJKlI4clFwBOdtCjkoC+GW6s5B57eIW8H8bkzwAZX7nnRDkmQWng== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB7276.namprd12.prod.outlook.com (2603:10b6:806:2af::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.13; Sat, 18 Jul 2026 17:15:56 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%6]) with mapi id 15.21.0223.012; Sat, 18 Jul 2026 17:15:56 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Joel Fernandes Subject: [PATCH v1 6/6] scftorture: Make invoker threads actually wait for all threads to start Date: Sat, 18 Jul 2026 13:15:37 -0400 Message-Id: <20260718171539.3781595-7-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260718171539.3781595-1-joelagnelf@nvidia.com> References: <20260718171539.3781595-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0P220CA0027.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:52e::8) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB7276:EE_ X-MS-Office365-Filtering-Correlation-Id: 38e02be7-242b-4c20-0090-08dee4f03a96 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|18002099003|22082099003|10067099003|56012099006|5023799004|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: QzBDQw/sZJkZyVHLb/L7qWTWURJEt5fZLvXEjTVyy/5yWWTAVPQb2QkhygdNFcoCOFTaEXJ3RJ09/O23ZVEWH082ZLaB+NBhCWsJPt7DFIr1D670w2SvPTVhbJST0VSVkl/H5UlZJ6aj6qVD7ZifdiHw3AcPKaPB16vrbIm9yx0wvyYLuAROuAnrMvbo9ANjdpAJhhzFPVWbBHct1iHyjs1Rd8mqXwZG/SPwJHYoBBxjkJqbQE99m26xlFhnAad65etgqlChK/4Kg8FTkCo4mmyBf4d03zKTkCgfM+bJuHQLTRkrWhre5dPVXKBaE3u1U7IEYvkm+d8tJKo41jbI7m7J5bUj+aUNfiZUQVcj7L+hfLLE6lyR020jfX4ER4R+zKk58RrZEbxiQBU9wd6EamB1jQ7JVt7KjYXxao6LSM9MBcdS0QaaRcPuXJIO7cqjgTS1ny3PzTC/OVSDUO9GRdTdIZjP0Hf6Fa9RHheWxIer4satJ3zrf2VnwcnpiR5O3DCtsOIWLhsSM078cKUoMeskJyn+UgsiqQnfUsp+oC2zSxd7vzjggtrJ0BE2duvx+jWr4T5VfZ6kXOPCpJmwJg8Z0AnLTh3+ozC3UkyuioWW9PgLtKIhZbo9epkcsp0CoWw8dJx4h+UTNxjWRmD20tSXEBx3dxh1F6fORJOR5gE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(18002099003)(22082099003)(10067099003)(56012099006)(5023799004)(11063799006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6C2DNHxhEwveuaRtDB/RqosQnXI8LADw1McOPJFsn/m+C8y6tY/1tKMKrvBv?= =?us-ascii?Q?h5NDVqjGfcOsHDqHu5T9f38wrchiLGEmb2nNSRbPsY65lULRgEam/GH2X7VW?= =?us-ascii?Q?48h70JhzMpnPU8RyYrKP29epEOR995S8jLlFKi1Qd0WLmv/46mwIofiSMehN?= =?us-ascii?Q?pgPt6WZ/Lm+IHqwXDiCPc0q/8R8S999R9d3fhZ0v42KjnFFCbBkwTw25PHom?= =?us-ascii?Q?fo60K7UJmudt4dsJ6ly3WmrtMShQWtSq7mlkUfmD74FZ3sJJ6bT+5N+dNL2x?= =?us-ascii?Q?qzo29vmOyefnCuovCIn9HFKrk/Bs1TSy5xvk5VqPXls6SHZy3LZefNILS7DI?= =?us-ascii?Q?nJQqKV9AU02vLosXnJHn79Ox51maBDJ2HGMbo2osrf1Rq275Yy2O/Er5IoFC?= =?us-ascii?Q?3SlehLzbPK6Fynhn4hWaBGQRuwgSnDv5BMAkDNTlJLGhv3kti7bFncxiMZCy?= =?us-ascii?Q?7MX6CzcWpKYzmQVw4Vmuh5kpJ7hP0KllwpEl6CHBvvMaOWagKd3ixLZIQDvt?= =?us-ascii?Q?tKczEtlBLXyPescQ3F6GafFc6+t8pgce5hAWzGsk+pDpvK3NXdLpDivmSnGH?= =?us-ascii?Q?zOGzuat772uiCUsY3w4oHToYmf56U8MniheqDi6k0O88SfGX5xEO12CWs99s?= =?us-ascii?Q?zgSWD/Yfw8BAQtpab4iczsM0FwuRvirlIbMnXGLuuc2R4Vg/n7vw+C8KWoSl?= =?us-ascii?Q?HAVJ2IGlDaXu9+5Y/ImI1pOHvzn3zi5+UlzBk9D/HibEZxwab4kqQsiqpOaL?= =?us-ascii?Q?KWOweQ1OKvDU2shGb89ahYdNM0YzCsZJ/6O10UZBFAvc7GeN+L3TTTq6b7Zl?= =?us-ascii?Q?/zRIgYk3nBHhjNNK5J8bU+WsCS0+ZIsFSJlAIOGFabsaErvNTqDoc4vH48eE?= =?us-ascii?Q?9KfYQ3YrnckYie9gQFNfGPNnLTEjKdnIUv9fdb3lwZBTeuSiOdB4rKjmUktQ?= =?us-ascii?Q?476ZBrOYov0k+wQAbWVMm1JIWBiZoNb4M93iiTSDgWvhPH1FsJMbYdLNOKPn?= =?us-ascii?Q?uITgtm0yMsP7exuWb1ilL+r2gMEARLopY6Fj/zcEr/MBIeYvE1PnJhhkwx2d?= =?us-ascii?Q?urHaFNmJ8/HndTamAHWPCaksHfuqINBKx/E46WQVe0Q2wrEILZiUYcFMLj38?= =?us-ascii?Q?Y+ImSpp3pIRhyNs8ayeDOjz+IXgr0B1i8D1w8Jk/hXVrenUKyyP9GTDlAD4+?= =?us-ascii?Q?E4O1ge2VSDEdIPCAxnuG8ev6uvL4CGH9xLChgMw2XUkA2fkOtdqUwCCm/eCL?= =?us-ascii?Q?3tPUiE7W/ZYn9DAqC08kgKiyWOz6sKVS7mvyfXhDT45PyselfiiS1waPzrmg?= =?us-ascii?Q?eC1UD4VtAStgSWO7T75G6HkvVEXM3IslpZzk//KW5Dsq4bBa9U3fwMWx3GRf?= =?us-ascii?Q?avgpsKcfLgWf/wlfcXJoVTIh6Li73X5WsxvfJwG23dReehufxyBK8VkGj4C2?= =?us-ascii?Q?ImebMjgRrBemGDsVX9jQ48HNttujXPPBEOY38U8nmQbe6nBn767InUr62VaK?= =?us-ascii?Q?cNdgjCWy/3mBeAoSZZ1mQtDCHDQ1bCg0b61zjPTEvRKV4wDUl6yFDeDFRryi?= =?us-ascii?Q?daHvkkdTY14s0L1NrItKfOpq4xSy2/asmwmt+O3APg8ktWREyhz0umvFvGoQ?= =?us-ascii?Q?w/PZXhqp4cnOy0CURXWTSTQQiOaVteiIuCxDvwaNZh1MRjMLWewP8jo/SBwR?= =?us-ascii?Q?3Sx4P45JGkxVaB1/cWmObScrvxd1kd9HhVKlrfuyVFtqoyOfnymLH9GWQBdm?= =?us-ascii?Q?j4gAfYl7vA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38e02be7-242b-4c20-0090-08dee4f03a96 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2026 17:15:56.0166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KEY7J+3mA3JmCkBwO9UE/zD9ACFdSeQ+o0I7WaKzNeTCT27BbW0cwChzWizLIdV556jXNXpO7QCZXd93YyHX0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7276 Content-Type: text/plain; charset="utf-8" Each scftorture_invoker() thread decrements n_started, which is initialized to the number of threads, and is then supposed to wait until all of its siblings have also checked in before starting the test proper. However, the wait loop is guarded by !atomic_dec_return(&n_started), which is true only for the final thread to arrive, and by then n_started is already zero, so the final thread does not wait either. The side-effect (possibly positive) is that no thread ever waits and the start-synchronization barrier is dead code, with early threads beginning to hammer smp_call_function*() while later threads are still being spawned. Invert the test so that every thread other than the last spins until n_started reaches zero, making the threads start testing together as intended. The existing torture_must_stop() check in the wait loop continues to bound the wait during shutdown. We can also drop the spinning entirely if the intent is to leave it as dead code, however for the current intent, this patches fixes the code. Signed-off-by: Joel Fernandes --- kernel/scftorture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/scftorture.c b/kernel/scftorture.c index ffd6c83732ee..392df1b4d4ed 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -497,7 +497,7 @@ static int scftorture_invoker(void *arg) "%s: Wanted CPU %d, running on %d, nr_cpu_ids =3D %d\n", __func__, scfp->cpu, curcpu, nr_cpu_ids); =20 - if (!atomic_dec_return(&n_started)) + if (atomic_dec_return(&n_started)) while (atomic_read_acquire(&n_started)) { if (torture_must_stop()) { VERBOSE_SCFTORTOUT("scftorture_invoker %d ended before starting", scfp= ->cpu); --=20 2.34.1