From nobody Sat Jul 25 04:15:42 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FEA72C3757 for ; Sat, 18 Jul 2026 15:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784388990; cv=none; b=nFfYJXoSfRZkdMkI7zfnke4Bgfd1I68PWoB0Aq8zP1p1GpUsH11px9axzNbFa8ZFHkIOTW3NxCRZXDPHx7U+ZjCWJjm8jQytcEVlhux8pQQVe5GXAUUTDlwV0GcnkpauVAGn6jptGvBhtKxtgu3f1Szvt2e4gX0U/A++T6+Qvhw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784388990; c=relaxed/simple; bh=kGZ4oHn4O2FG8AC20CYrnU3QKzq63ckoS+az9lGJO4c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nNLIai3xgHpAFCvFEEUbpYRPX0pscBwYzyQ3qLxsZcdq1dHBnTnOV2J2uE18mNyBIV7/1RbMfaUn+Mjfhvr6pWkt93tPvSjVXgrHywTkasSQISQg+0FeemW6+3S9zqJhTJLVZySoU/F4rkNAjjNduXGB5qqgsNYp+tIpz5NBUwY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fLyNhLU5; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fLyNhLU5" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-ca7bea5e5b3so6284838a12.1 for ; Sat, 18 Jul 2026 08:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784388988; x=1784993788; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Vo3O4C85dd8u4rAF/3VjEGqMnG6FGHT5+qn329tDhDM=; b=fLyNhLU52WM9qm/6cG3LjzZ7X5N5WNhMEkcX0Rj5JTiQJuPm870F+43x0P+oCJpOzl m94AZh6W3IWlEBWrQNuS2z7Zbc4myu0Fdm7LU5sfpRxQF1jM7iZctB8X1WTsg4L+QimN GQJzgPApOwcWZgUkzPtCcI3zybrh3bgdQv59eEhNGpJtJOSa4jC074oRqTn/R6Frqidc YsYiYjInzK+IYvTYOU/yg4rmTvGy5FCGNKUnHXthIPxmVq8hYkyMjPrNJm5pf2Y0IOm5 7Q6Pi3/EiGhy+NVzbcGR5GyN42BDhWcfA+kVpRUIraEV8e/71P/pwZb+qhd33AdtAqYB s5UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784388988; x=1784993788; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Vo3O4C85dd8u4rAF/3VjEGqMnG6FGHT5+qn329tDhDM=; b=J7DIf29WYFrXpOo7lKQrqc5BGhY9txOE2lGzc/Xtum/NYd9dzfVgsx1M1h8/zpO6Di RH1pQhD7D+5YLgjIZigtahj8AtFfTd1kXDtXoCgvnhAZeIcxHrAV4vYefsafFblY7Co7 W6Up8dn5BjABsuCbjIqC9+OjxZE9Z83+zDMcsNfdwa37h/aHXKWDyj6NzXTihWMcxJaZ vXNRyZXUMDpM6z3feahfmo3Uc7/Zm5o0E9Lc6fY9jrfeQDVGcthhMbvuRrqyrr3VyTiw g/s5a9LQ+K+16oRVVO851vuYFS66elqFtoQYOyvs8K9lAqcT73Ko6LifIy3t0AMLhD0P em/w== X-Forwarded-Encrypted: i=1; AHgh+RoUc6JpFA+wEKSUQsard2uNa9NSfR2cNdYIOlDr8L4zkXOReyHHrTPt6KXO7aVPPIIFvnFOxLz/vdbq4Ho=@vger.kernel.org X-Gm-Message-State: AOJu0YxAXaytQIwJVs3/7t1kIv0h1cultzu7HEHX4S1gpEOHaGKAQARL TDN/o0xVPd3rmpsUa4SAGxQqdTmpf5K00swalsEPV/zbgQ66XNIIQHY5 X-Gm-Gg: AfdE7clDUXS9MqODIBT9sXNuGzFZHgmRnx3wd/MwNIYEOLNRmGrNcs3Z6FBhr0slnhB bXo5ZVczM13kYCbeokRBqw0g9Ai5bBevyTSm7VAK1uvceHFVo2URs8qHHTXep/2YnbH/KUb9cqP 5Jomcm0ue1ck94jh94rNzpey5fBzaelBRQTVN4wxdx0+g/G9CPdny3CUAGtRPAbzn4kw1CU0D74 9cRWnwc11vEK1RSMifl9n0TWfISXIpTcrdPk3+1Ie6UY6MgtATitSaSIxU0Bc/QL6l/64aU48BT 9eTWd1TNXS53MEO981Ho7rzLN13Uob3zfDOHkGQivCooDjJjJLXSrXSRiPhj8rq/VG1bn+QuU8G cj+HQT2fwVZPOLoewUz91bzZUPVMblIaRTmIqX6sANZvW8VjCn92dVW+PBvixBCxJkKjQHykL1S 1tNmA1sxkOdnk= X-Received: by 2002:a05:6300:2703:20b0:3c3:bb40:790 with SMTP id adf61e73a8af0-3c3bb4015femr4507067637.66.1784388988414; Sat, 18 Jul 2026 08:36:28 -0700 (PDT) Received: from 2045L.localdomain ([36.112.122.101]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb5159b11a5sm2235615a12.0.2026.07.18.08.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 08:36:26 -0700 (PDT) From: Guidong Han <2045gemini@gmail.com> To: Anup Patel , Atish Patra Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Guidong Han <2045gemini@gmail.com> Subject: [PATCH] RISC-V: KVM: Fix PMU event info array size overflow Date: Sat, 18 Jul 2026 23:36:20 +0800 Message-ID: <20260718153620.829378-1-2045gemini@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" SBI PMU EVENT_GET_INFO stores guest-controlled num_events * sizeof(*einfo) in an int. On RV64, num_events =3D 0x10000001 makes 0x100000010 truncate to 16. KVM then allocates one entry but loops over the original num_events, causing out-of-bounds reads and writes. A nested guest triggered: BUG: KASAN: slab-out-of-bounds in kvm_riscv_vcpu_pmu_event_info+0xa4/0x142 Read of size 4 at addr ff600000074d46b0 by task init/1 Call Trace: [] kvm_riscv_vcpu_pmu_event_info+0xa4/0x142 [] kvm_sbi_ext_pmu_handler+0xca/0x268 [] kvm_riscv_vcpu_sbi_ecall+0xec/0x1e6 [] kvm_riscv_vcpu_exit+0x48c/0x540 [] kvm_arch_vcpu_ioctl_run+0x37e/0xc80 Allocated by task 1: __kmalloc_noprof+0x19e/0x4b0 kvm_riscv_vcpu_pmu_event_info+0x72/0x142 kvm_sbi_ext_pmu_handler+0xca/0x268 kvm_riscv_vcpu_sbi_ecall+0xec/0x1e6 kvm_riscv_vcpu_exit+0x48c/0x540 kvm_arch_vcpu_ioctl_run+0x37e/0xc80 The buggy address is located 0 bytes to the right of allocated 16-byte region [ff600000074d46a0, ff600000074d46b0) Store the shared-memory size in size_t and reject multiplication overflow. Reject sizes beyond KMALLOC_MAX_SIZE to avoid triggering WARN_ON_ONCE_GFP() for an impossible allocation order. Use an unsigned long loop index to match num_events. Fixes: e309fd113b9f ("RISC-V: KVM: Implement get event info function") Cc: stable@vger.kernel.org Signed-off-by: Guidong Han <2045gemini@gmail.com> --- arch/riscv/kvm/vcpu_pmu.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/riscv/kvm/vcpu_pmu.c b/arch/riscv/kvm/vcpu_pmu.c index bb46dcbfb24d..8b489fc3051f 100644 --- a/arch/riscv/kvm/vcpu_pmu.c +++ b/arch/riscv/kvm/vcpu_pmu.c @@ -12,7 +12,9 @@ #include #include #include +#include #include +#include #include #include #include @@ -479,16 +481,21 @@ int kvm_riscv_vcpu_pmu_event_info(struct kvm_vcpu *vc= pu, unsigned long saddr_low unsigned long flags, struct kvm_vcpu_sbi_return *retdata) { struct riscv_pmu_event_info *einfo =3D NULL; - int shmem_size =3D num_events * sizeof(*einfo); + size_t shmem_size; gpa_t shmem; u32 eidx, etype; u64 econfig; int ret; =20 - if (flags !=3D 0 || (saddr_low & (SZ_16 - 1) || num_events =3D=3D 0)) { + if (flags !=3D 0 || (saddr_low & (SZ_16 - 1)) || num_events =3D=3D 0 || + check_mul_overflow(num_events, sizeof(*einfo), &shmem_size)) { ret =3D SBI_ERR_INVALID_PARAM; goto out; } + if (shmem_size > KMALLOC_MAX_SIZE) { + ret =3D SBI_ERR_FAILURE; + goto out; + } =20 shmem =3D saddr_low; if (saddr_high !=3D 0) { @@ -512,7 +519,7 @@ int kvm_riscv_vcpu_pmu_event_info(struct kvm_vcpu *vcpu= , unsigned long saddr_low goto free_mem; } =20 - for (int i =3D 0; i < num_events; i++) { + for (unsigned long i =3D 0; i < num_events; i++) { eidx =3D einfo[i].event_idx; etype =3D kvm_pmu_get_perf_event_type(eidx); econfig =3D kvm_pmu_get_perf_event_config(eidx, einfo[i].event_data); --=20 2.43.0