From nobody Sat Jul 25 04:29:56 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F1272F6904 for ; Sat, 18 Jul 2026 07:50:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784361039; cv=none; b=ArJcoUvCe5ctZlWe0S0RGYRLuAYF1kRJimIhzUW8/YH73CU2ufItdxWToU4Hna2NYRqpVMcNNdTGgX4+nmRZlB4T06SEf9waLsehER4XpoLIqhQxZHaCrOROkXDq5DEz2KgONllr4Kog+LxW9X0qgq7T6hTTWEzb3XtyuvGqaxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784361039; c=relaxed/simple; bh=1awWxnMm4rgNRolCKrFaDT05Xek0Jwqhh14crlxuQRY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Tt3f960fIcFeQ4MFRIQPk6ocA4aFtN8SK3xoMVq7jNgd1NB8oprGj6jNbi9yesvw9y4ie4EktQP8stVYjeeonSe3mp1Q8057VY7MYv3kp6etot4t6MohT13oiPqm7Gvernfiup/9n71TkuUQMzmgev5qs99UCtznze+6JIQguP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=npbmC64S; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="npbmC64S" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38e58034d05so780131a91.2 for ; Sat, 18 Jul 2026 00:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784361037; x=1784965837; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HB2l2gAUnqKDqPPuaqqN/p88qcc0rf+a8Bqxr4vlSRI=; b=npbmC64STKJ4DaT1b7n2EvTdRfadz4goGT2QZsQQuXUby7nsKAc8BjyqIprVaruuvN Evmu12v2JzfXxkP8SIBIz1qr1PcjBdzAfNnMXd8wWRpku86Ve2Wp8T4wCTprcCtP29JC 5oPyFpYA1VPz99DCb/+x9SSOYF6yBFsxznRimGdIk9Z7VvrpyqUQcjXpTwdFQ8t3hYxm N4vDVpkgBHuRtqZdv2ppWpcnt+fG3u3iGD0z+PVBopCcoA0Krh/tvaxcFKRBNQ2RxPZ5 ahLSzGtF8eeGrc5gm9tJIPOY76P6F6d/MvWjvCOVrQCCm3deGBBWM3qmsVg6N9LRq5Ez sSeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784361037; x=1784965837; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=HB2l2gAUnqKDqPPuaqqN/p88qcc0rf+a8Bqxr4vlSRI=; b=ETfno4tRzBRESGg9191Qnen83c5m4NhrlI1F/mGIeKWhMjwCfa4JWXQQY8zg0qoF7Q NnFNtQ3L0+QwoLzHfeXJKO+6MpoyEtLidWtQH2Hv+wT/XkBO9UJ6+owKrd3RSrCd1nKz bkrqeUpWJZeDvpT7J7Z6cucMgpnHGliKq87B+4NIkpTeamI1vqlgNTMvYeRi6tgWg0vq XmZtS7I4JUvjhwt2bZfwopibiIaKTYyFq3LOo1Q1BpT5EaYD+/x8ufaINAIWID+Fw9q3 kAFa/lW3RpD57gGYkSK3SjHmYtNsdiT3tyK5uuJd+iPqwRvg/NupN731ws7kvF5jorKX 6veA== X-Forwarded-Encrypted: i=1; AHgh+RrNOf/IRxqvYr1jsFmYhhXYMBzw9dMc3T6MXpO6seMBdb80FF0TXQ5zhH3thgt55ZIYF4VGJUCQ7w5ShCQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyxAlc2oqrKG8VnCwJc4PfeHDuz2EHlfYgjMoRlRNGKIYN1+asQ MFL1GPKH3V4NRRO34fvPaiOb5YyOaIAxUQTtX3mEvSGu5hBAGo6hpNyl X-Gm-Gg: AfdE7ck9O2ahWlU4rBw7L77KAOLcZqDf4YxoPQxXRoDh9s7gvxLe+VMSDV9YUvz+obE 8781F3lp+TkAsik1Yll+4xdXQPF6eJ0vSUwchaGzo9/hNrXnTwvibz/KWyV1zOdmRqtr6IhVBdn vayIUgdgDnmDGv376MSBSLKvH4GvqQaoBnzVl5WtvYLWHW+GkdMW51qBx7auVv63FvXX/VdA9RY md2+rtNtSm57Og8VOoScF61ecEg0LXsDxuldQ3yL3bdDr+yh/rI6aSUUKgMd/v1ENJWhIG2vOil le/Da4Cfh44dpBzH4uUvTgw3AhrhnCyMKktsrTehZbHb9wYxmxTOdLj9owdBuIJTWB4BBdYfntB ysiTFtbQG61bJitWN1bMHCgf4a0kB3P64ZkIlwKiOO6zml90rdT5atPvnRPF1OHAPK7GDc6kavV qyYpz4aU3tN/lWS0TYYZNG2rtuLCpwALzBnE/3TUkqPpqkep8XJ4Ey X-Received: by 2002:a05:6a21:4a97:b0:3c3:96dd:9ecc with SMTP id adf61e73a8af0-3c3ad93dd33mr5919063637.57.1784361037377; Sat, 18 Jul 2026 00:50:37 -0700 (PDT) Received: from debian.ari ([152.56.157.145]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a20bf96sm14354220eec.28.2026.07.18.00.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 00:50:36 -0700 (PDT) From: Archit Anant To: jic23@kernel.org Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH 1/3] iio: adc: ti-ads1015: sort headers alphabetically Date: Sat, 18 Jul 2026 13:20:14 +0530 Message-Id: <20260718075016.27750-2-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260718075016.27750-1-architanant5@gmail.com> References: <20260718075016.27750-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reorder include headers alphabetically to comply with the preferred coding style and improve maintainability. No functional changes. Signed-off-by: Archit Anant --- drivers/iio/adc/ti-ads1015.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index 8a272af69f7d..d95efb870bde 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -11,24 +11,24 @@ * * 0x4B - ADDR connected to SCL */ =20 -#include #include +#include +#include #include #include -#include +#include +#include +#include #include #include -#include -#include -#include =20 +#include +#include #include -#include #include -#include -#include -#include #include +#include +#include =20 #define ADS1015_DRV_NAME "ads1015" =20 --=20 2.39.5 From nobody Sat Jul 25 04:29:56 2026 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26576239567 for ; Sat, 18 Jul 2026 07:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784361043; cv=none; b=LzU3SgD/BuDCrNuBTuVkcAAiQ4yZgea09uOPJ824FUJHTk1YZzVijtiY2RR22fgP+RqE4ExpT1l9Ghf8SvcCEFZpl650QJDzIs8OXNB6e6IPllqBH+0A0sJDkflVtK3dwCEzrNWWfbaCvE/f8eZl2Mmm98UavI2MpXnnx9IemdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784361043; c=relaxed/simple; bh=gy8PFLftQdi21+SU+Q3p/8r8TWSzS3vDI9YIvfJSDu4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ISDn/i6ETblWpi7m35+0cJYlLkBGj1OnwQDDwyZFCFuirgibzsw71CCmcHrIUNFm2BBdcgpczmsu3OkPjNtwhMqA/cqXhCRhEuSWTx7zProz0k/3ttshBsf+o4Io5mie9/BR0P6WUWqJ9oCixICxN5WSiusixGXSbyBL3EVbUnk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EhK1+tHj; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EhK1+tHj" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c95d0a54ea5so6294571a12.0 for ; Sat, 18 Jul 2026 00:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784361041; x=1784965841; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PzCo3k1Bxl99xio9k4SN7aS6QcizNh1S7ZH6FAX6MJA=; b=EhK1+tHjhAKKNGTORy0gRqhYaYPcGYjWh6/mrjwGHhLKHTvrLlQOl7RTgmtTvfT1om 33ktr9aj4hqb0MXKxYTt9yS6tow2ApU4INMhZyIgq8iHTnCuxpQdCp+r7gj1iBHiBTIC wMKEvK7Gqh/f+DnCdgPuWX++VG8YYKlXXQ+vlbs0pm6cahqMDVwCccYyyqm3kjwPKE7l OAbbcL4Z5E05Yk+Zrrvo+++CQu4jP0LGpdv9AA1DqXuijvCnr4L2GqA9XWB/GtBTur5k a8K9Uxbip4PVC2ncdKlIbXJ1n9lyvAaKMlym9F8FQsn/zuUFqhWjUSqy9j0OhG+ukLwC x0wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784361041; x=1784965841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PzCo3k1Bxl99xio9k4SN7aS6QcizNh1S7ZH6FAX6MJA=; b=mk2sOovLVwnZQHivPHf3Bpptca/u9rsCVjDLVUfNFIGfdYFVPc+yaamWFsjEsUJsu1 jl37Sz2JvgQbHvAsbxYBJgec2phpWoBYuXgrVSRnm2m24bhaxfqg9HWQgvNHNuDLdenT 3xU5R7c7/+hXR39cDLTJtNPtnpAjMFBIjBptSl9Jb+NfOmZ2/XiCCoEJr51BrqBVqCFI /RuX0yrhO85mY3t9TDOZHFY1DQZSnJL9zjYmNLnKO+LhLJcTPFC6rH4Ajmn4xjEcsSul 8wyxdnOfVx0Fm4QRR9kpUFxIhA7cEWHzDFqxXhba22DXqM5SZPMf6LgE/SBgMLAg1q6d rFiw== X-Forwarded-Encrypted: i=1; AHgh+RqFlrGMiye+B6YPy3NIaLd6uQfq3h+PCPaZeAwoZ6dmWCkWg1SUii3EmiZbvcF6SovK1C+w+VFEq2implc=@vger.kernel.org X-Gm-Message-State: AOJu0YzomEVk3OmElqMA3MdwQKeq43cLtQvrk4gtnhcX+jUlbVHkI1EX nhWdQEPzoccCgEZ9nc6UH8MQm6UuGJGL3zStxUZLfQyI2d5TPMtJnKTU X-Gm-Gg: AfdE7cla6PLqnTIhPq1xflWiEmBadXgeZyBfV0uahbUsEQEgM+CQ8KSkGyeg3pbnOla MdWkIl/fEKGH5Kw2MYyVJzf3/HrHj46PmZGE0LoDuKF2d+vfbT2XpBycZtAeAVQVF3cCCchsArY nKrZUxTiqFT5F3EohahOZw2rv191FNw0CsieWUIfjr7/514Q+Yhw0XA7oUoe/hJsQB9W6sF+kbi K/TPJJrm0N+Gi3e6ZQLrKoMstOsuOSpsvkXVgmcz90XWGvixKDPyh+djEsphefSXOPjRfl5RmIP XZSEPR1pOYrVSgye1dAepbrrO8KVLIecMsbWeD4ev7+nLfC6sxgckba2f+e5G0I9ok/I4LZQegl O7nWZjNNJghmKmY3msTprE/rhPDvZ6vIb3rOOBA2IJTxUHsvL60zNe6rOqr1UJiBSJK8QBMHnx/ aiDac/TI+aaC81s8ogVdWvHtTyuR7Rt4f+KxdmEh1X5DDpd0NOF4DE X-Received: by 2002:a05:6a21:1f8d:b0:3c3:68a5:50b3 with SMTP id adf61e73a8af0-3c3ad9d9809mr6773067637.57.1784361041550; Sat, 18 Jul 2026 00:50:41 -0700 (PDT) Received: from debian.ari ([152.56.157.145]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a20bf96sm14354220eec.28.2026.07.18.00.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 00:50:41 -0700 (PDT) From: Archit Anant To: jic23@kernel.org Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH 2/3] iio: adc: ti-ads1015: use local device pointer in probe Date: Sat, 18 Jul 2026 13:20:15 +0530 Message-Id: <20260718075016.27750-3-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260718075016.27750-1-architanant5@gmail.com> References: <20260718075016.27750-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce a local device pointer 'dev' in ads1015_probe to avoid accessing &client->dev repeatedly. Signed-off-by: Archit Anant --- drivers/iio/adc/ti-ads1015.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index d95efb870bde..0232a4ca2d77 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -937,12 +937,13 @@ static int ads1015_probe(struct i2c_client *client) struct ads1015_data *data; int ret; int i; + struct device *dev =3D &client->dev; =20 chip =3D i2c_get_match_data(client); if (!chip) - return dev_err_probe(&client->dev, -EINVAL, "Unknown chip\n"); + return dev_err_probe(dev, -EINVAL, "Unknown chip\n"); =20 - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; =20 @@ -978,15 +979,15 @@ static int ads1015_probe(struct i2c_client *client) &ads1015_regmap_config : &tla2024_regmap_config); if (IS_ERR(data->regmap)) { - dev_err(&client->dev, "Failed to allocate register map\n"); + dev_err(dev, "Failed to allocate register map\n"); return PTR_ERR(data->regmap); } =20 - ret =3D devm_iio_triggered_buffer_setup(&client->dev, indio_dev, NULL, + ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, ads1015_trigger_handler, &ads1015_buffer_setup_ops); if (ret < 0) { - dev_err(&client->dev, "iio triggered buffer setup failed\n"); + dev_err(dev, "iio triggered buffer setup failed\n"); return ret; } =20 @@ -1018,7 +1019,7 @@ static int ads1015_probe(struct i2c_client *client) if (ret) return ret; =20 - ret =3D devm_request_threaded_irq(&client->dev, client->irq, + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, ads1015_event_handler, irq_trig | IRQF_ONESHOT, client->name, indio_dev); @@ -1032,16 +1033,16 @@ static int ads1015_probe(struct i2c_client *client) =20 data->conv_invalid =3D true; =20 - ret =3D pm_runtime_set_active(&client->dev); + ret =3D pm_runtime_set_active(dev); if (ret) return ret; - pm_runtime_set_autosuspend_delay(&client->dev, ADS1015_SLEEP_DELAY_MS); - pm_runtime_use_autosuspend(&client->dev); - pm_runtime_enable(&client->dev); + pm_runtime_set_autosuspend_delay(dev, ADS1015_SLEEP_DELAY_MS); + pm_runtime_use_autosuspend(dev); + pm_runtime_enable(dev); =20 ret =3D iio_device_register(indio_dev); if (ret < 0) { - dev_err(&client->dev, "Failed to register IIO device\n"); + dev_err(dev, "Failed to register IIO device\n"); return ret; } =20 --=20 2.39.5 From nobody Sat Jul 25 04:29:56 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C65C82C21F1 for ; Sat, 18 Jul 2026 07:50:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784361048; cv=none; b=c3Wt85i8tl395WC+YuSEknZwZnA7ll9OLt4gQ84ZZzljczdeyTTHVuOYr/1b4RPcLEJtDwwkLfRwm2a7teQPzSXdax5EK9EZtTuM5NlBz+dr3V6Nuq5C63/wN9elZ5cV/afCeu9WNEjpKx1oCj1eoboKpZvcD3tfUuMGuCHOGsM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784361048; c=relaxed/simple; bh=axGdFwDRPmHC80+igOjmSxNrGka73suNE+Z56JHacSg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DWP7gs+9B1R2su6ykMeX0qBLxt4dtGxl2KmR3hFKP7pFwuZQoIudNnlArTwrQbEAuiSZQ0ImGVEUyC3PKXODB63PKpwQXRBq5rd9GyvqwPG7JCg+r8VUasP5ihRJ9lm+ij3bLRWeKFKuvWM69Ck1KUGhvgXQcKxlCKK2AqQ8anE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fKPf32Is; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fKPf32Is" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-ca97d139d8dso3198442a12.2 for ; Sat, 18 Jul 2026 00:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784361046; x=1784965846; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZYQz/KYXwf3OLcsAA66MTPAZaZSTmxzDqnf6BrqdGD8=; b=fKPf32IsYhkP0RiFuRI/+PfoRbFfKnJDzi5t8GNgqeI0UP0PnIYd7qvxHb9iv6YKhe E/BwTjpmjlDg29oY+CJ1JciwGTLB93kaNkQC8d19ZmK8hI7J+nfQ1DqPrD4LsTdS1zoe 2cSYUKvXxIdzPvzQmpywj98Ao6wgypm+NPLiJosdJV16T5CTMT2Ynzd/j5NLeAgoBgri 6E6YqaAt69JHBf2HWv/o9xhGUuDhP5fKf42uqF/LEXeJl5KcbmBVNLYfLlaz8TIfzQP/ P7mKrf4pr3bhMMjmleFa3coSrzWyzSpg90eBapLOlU5/IEwA+L7rZ4RJ9Ceeu9tdVkbh Fw9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784361046; x=1784965846; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZYQz/KYXwf3OLcsAA66MTPAZaZSTmxzDqnf6BrqdGD8=; b=VS90clxPTz5H90Hkf2o/BU1GDCIQiFpSKdW4gy3V0YIJZhVmfFCq9lcTQU8Qev9Aln M2pA1tp20ym5uf9w/CdMAdJUTbh6LZr4zYj+kjZ/lQu1r6dch4MrCuMhhbjdvYRHuKWb sbnTBPssuykfJJWQZQXbJ6mp5nSUj96vNTpKUy/TsrTaF/cIZ/attk86fdyYQ8JM3t+r 6fBuSoMPDPnD1dQl4XRfnoJGlv8+aPKAhawhYVhU74ONVt6iphMPJX9Up6AFHEEXriqz mHQbzZRiXG/2pG+drzIiqHiEeTvXYcrksv7sHbdzpwlixUE2Y8bSjY8daxv2vUCY8cCF EGng== X-Forwarded-Encrypted: i=1; AHgh+Rq3OHv1aaLTcCiEOu2zCj5rbv7d6aHDpjrfZ/eFs2vN0zKKXh8Sr1cPpX8c+4+xNUq28wXfOV7fJGgU7Mw=@vger.kernel.org X-Gm-Message-State: AOJu0YybFBvOn0gKQ+a1/eXjQnty1p+zg+kgyLi7LKh1pqCZiEVyfCi2 MhNqW/niKLHsdYrN7Tb9t0VDnsrmgeXwhcqsrm0288dCXZaF/BClCOxL X-Gm-Gg: AfdE7clfWro0KwS78paRKyypof/H9Eyrr0y8svb/ShIr7+LT0OvrCxgGr6PCTPRC1pP wqQ6Ba4ifoVVTWWdP2eBqFBhUEyjONmjsu9TRIKqKhxYDC7DZobG+qbeirW9GG5CFNGjRoycPTd JtWy5hAKX/GaV+3LuXPdKWrCKMGGh8V1PzP/LxhvC4V/3pquzXd5Rh2IbrG4aw/IUGD63jjFNq9 v7XlAbS8/mWtMrLmERnDM4FtVKJOdwZs1GeZPo6IJmfgTR11O6eEK+wG1rCztVXL9vfxxSLDabd iEh2YKbxCQKCGzTs8noW/CTcaUK4KCbsva1Dk9gVo4bRLjPycA3dGLEW/jpQiv5XJTM6w95tl53 OlxYkd8S1OrLkEPaEweIy/cXMgVfz0NTmcpodnhSjU3OIHISj4rlHb7AEPhI/d0YK63hTG81ezk jDgPTvnNfO6M26MOeWqm+6sYwR1UqUWdtnQchyua1LqGfW48mOz9ox X-Received: by 2002:a05:6a21:6b17:b0:3c3:7f8f:88cc with SMTP id adf61e73a8af0-3c3ad963e78mr5739675637.46.1784361046046; Sat, 18 Jul 2026 00:50:46 -0700 (PDT) Received: from debian.ari ([152.56.157.145]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a20bf96sm14354220eec.28.2026.07.18.00.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 00:50:45 -0700 (PDT) From: Archit Anant To: jic23@kernel.org Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH 3/3] iio: adc: ti-ads1015: convert to fully managed resources Date: Sat, 18 Jul 2026 13:20:16 +0530 Message-Id: <20260718075016.27750-4-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260718075016.27750-1-architanant5@gmail.com> References: <20260718075016.27750-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Refactor the driver to use devm_ allocations and power management, allowing for the complete removal of the ads1015_remove() Key changes: - Use devm_add_action_or_reset() to ensure the ADC is safely powered down upon driver removal. - Move to devm_pm_runtime_set_active_enabled() to manage the runtime PM lifecycle. - Update the PM operations to use DEFINE_RUNTIME_DEV_PM_OPS and pm_ptr() for modern compiler saftey. - Convert iio_device_register() and mutex_init() to their devm_ variants. - Remove the thus obsolete ads1015_remove() function. Signed-off-by: Archit Anant --- drivers/iio/adc/ti-ads1015.c | 58 ++++++++++++++++-------------------- 1 file changed, 26 insertions(+), 32 deletions(-) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index 0232a4ca2d77..57e5fa593b31 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -930,6 +930,14 @@ static int ads1015_set_conv_mode(struct ads1015_data *= data, int mode) mode << ADS1015_CFG_MOD_SHIFT); } =20 +static void ads1015_power_off(void *data) +{ + struct ads1015_data *st =3D data; + + /* power down single shot mode */ + ads1015_set_conv_mode(st, ADS1015_SINGLESHOT); +} + static int ads1015_probe(struct i2c_client *client) { const struct ads1015_chip_data *chip; @@ -950,7 +958,9 @@ static int ads1015_probe(struct i2c_client *client) data =3D iio_priv(indio_dev); i2c_set_clientdata(client, indio_dev); =20 - mutex_init(&data->lock); + ret =3D devm_mutex_init(dev, &data->lock); + if (ret) + return ret; =20 indio_dev->name =3D ADS1015_DRV_NAME; indio_dev->modes =3D INDIO_DIRECT_MODE; @@ -1033,38 +1043,23 @@ static int ads1015_probe(struct i2c_client *client) =20 data->conv_invalid =3D true; =20 - ret =3D pm_runtime_set_active(dev); + ret =3D devm_add_action_or_reset(dev, ads1015_power_off, data); if (ret) return ret; - pm_runtime_set_autosuspend_delay(dev, ADS1015_SLEEP_DELAY_MS); - pm_runtime_use_autosuspend(dev); - pm_runtime_enable(dev); =20 - ret =3D iio_device_register(indio_dev); - if (ret < 0) { - dev_err(dev, "Failed to register IIO device\n"); + ret =3D devm_pm_runtime_set_active_enabled(dev); + if (ret) return ret; - } =20 - return 0; -} - -static void ads1015_remove(struct i2c_client *client) -{ - struct iio_dev *indio_dev =3D i2c_get_clientdata(client); - struct ads1015_data *data =3D iio_priv(indio_dev); - int ret; - - iio_device_unregister(indio_dev); - - pm_runtime_disable(&client->dev); - pm_runtime_set_suspended(&client->dev); + pm_runtime_set_autosuspend_delay(dev, ADS1015_SLEEP_DELAY_MS); + pm_runtime_use_autosuspend(dev); =20 - /* power down single shot mode */ - ret =3D ads1015_set_conv_mode(data, ADS1015_SINGLESHOT); + ret =3D devm_iio_device_register(dev, indio_dev); if (ret) - dev_warn(&client->dev, "Failed to power down (%pe)\n", - ERR_PTR(ret)); + return dev_err_probe(dev, ret, + "Failed to register IIO device\n"); + + return 0; } =20 #ifdef CONFIG_PM @@ -1090,10 +1085,10 @@ static int ads1015_runtime_resume(struct device *de= v) } #endif =20 -static const struct dev_pm_ops ads1015_pm_ops =3D { - SET_RUNTIME_PM_OPS(ads1015_runtime_suspend, - ads1015_runtime_resume, NULL) -}; +static DEFINE_RUNTIME_DEV_PM_OPS(ads1015_pm_ops, + ads1015_runtime_suspend, + ads1015_runtime_resume, + NULL); =20 static const struct ads1015_chip_data ads1015_data =3D { .channels =3D ads1015_channels, @@ -1148,10 +1143,9 @@ static struct i2c_driver ads1015_driver =3D { .driver =3D { .name =3D ADS1015_DRV_NAME, .of_match_table =3D ads1015_of_match, - .pm =3D &ads1015_pm_ops, + .pm =3D pm_ptr(&ads1015_pm_ops), }, .probe =3D ads1015_probe, - .remove =3D ads1015_remove, .id_table =3D ads1015_id, }; =20 --=20 2.39.5