From nobody Sat Jul 25 04:31:00 2026 Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 956D82D3ECF for ; Sat, 18 Jul 2026 06:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784355683; cv=none; b=Os36TLR/4T3QeoOWIRjvRDh7sM1ykkFUI7XxCVcMogRuCCISvSxZwPp1u5FMpihyX7f0LfDjKsynlLUO9PIibF1zPTI9YsJcJOnmPwbV+S98V5UEL8gPXtQ6J2et2nPL+uQdXnWip8UrFleJ9GBJp/5BpZ0yE8p5Nst5IKgomZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784355683; c=relaxed/simple; bh=8KMAGVXMXEho8yhK/Y/llg3Pl8qS9CSrbUKC/EW/R5M=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MLmEpJ9jT1ZutgLAw74fgpvrHpqlrvjE/9r0+qIFlZGlu+7iEvPbJOApufFwVHP+VKAbBens/tGYIatAar215jbx3S/pW7d9Fl7mHC9M/j2WNkLyv5spmiFCD3NDOkKQR3tQpsrWXIwThthn8EsVXev/hwRqVz+KAPNUt/BbPFU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=ZuxMljfy; arc=none smtp.client-ip=185.70.43.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="ZuxMljfy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1784355669; x=1784614869; bh=8Il7b6wWmDfdMOETploLySGnbVhq17FaIic7m1Su2uI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ZuxMljfyMiAL37uWwaanneoMymgNbEk0ZsuBiXv0qFPECr3uKYwcPH18x8F7iDo/+ seMX/sOI7ghFJ920VuHhhg0Jpsdusvpz7dbPkBXUSlwzS0pJoeGQ4NH0nimQNRIyL9 bLoHHhik6KSWDkMVHQocPbHPfkKToYxFa6+oP7UEQOXewQhZo7aYzEK8MTc55djUDN YkMXTijUFK/1stZxdH9f7ZwXR1ST7xtGeTIHEhcVScpZz2lvac6ZJFdFfK/56EpBB0 mN8wQqS0SsnkUESj2X/LfYIw0LPrRwnmG6G1BEceJ9PjnUFMWwrXxShT+RTuxhRSFY XC1P7PuNGM+JQ== Date: Sat, 18 Jul 2026 06:21:06 +0000 To: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman From: Nils Lehnen Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nils Lehnen Subject: [PATCH v2 1/2] staging: sm750fb: remove dead VALIDATION_CHIP conditionals Message-ID: <20260718062027.5850-2-nils.lehnen@proton.me> In-Reply-To: <20260718062027.5850-1-nils.lehnen@proton.me> References: <20260718062027.5850-1-nils.lehnen@proton.me> Feedback-ID: 188354734:user:proton X-Pm-Message-ID: 3e35adcd54a191c59064103aeba3f712c30dc9b8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" VALIDATION_CHIP is defined nowhere in the tree and no Makefile passes -DVALIDATION_CHIP, so every #ifdef VALIDATION_CHIP block is dead code and every #ifndef VALIDATION_CHIP condition is always true. Resolve all fourteen conditionals accordingly (dead branches dropped, live branches kept), as the driver TODO asks under "remove unused code". No functional change: the disassembly of all ten sm750fb object files is bit-identical before and after this patch. All English text in this patch (commit message and code comments) was translated from a German draft with the assistance of Claude Fable 5. Assisted-by: Claude:claude-fable-5 sparse unifdef Signed-off-by: Nils Lehnen --- drivers/staging/sm750fb/ddk750_reg.h | 34 -------------------------- drivers/staging/sm750fb/ddk750_chip.c | 4 --- drivers/staging/sm750fb/ddk750_power.c | 6 ----- 3 files changed, 44 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_reg.h b/drivers/staging/sm750fb= /ddk750_reg.h index fe412ead72e5..4bcede37584a 100644 --- a/drivers/staging/sm750fb/ddk750_reg.h +++ b/drivers/staging/sm750fb/ddk750_reg.h @@ -294,29 +294,15 @@ =20 #define CURRENT_GATE 0x000040 #define CURRENT_GATE_MCLK_MASK (0x3 << 14) -#ifdef VALIDATION_CHIP - #define CURRENT_GATE_MCLK_112MHZ (0x0 << 14) - #define CURRENT_GATE_MCLK_84MHZ (0x1 << 14) - #define CURRENT_GATE_MCLK_56MHZ (0x2 << 14) - #define CURRENT_GATE_MCLK_42MHZ (0x3 << 14) -#else #define CURRENT_GATE_MCLK_DIV_3 (0x0 << 14) #define CURRENT_GATE_MCLK_DIV_4 (0x1 << 14) #define CURRENT_GATE_MCLK_DIV_6 (0x2 << 14) #define CURRENT_GATE_MCLK_DIV_8 (0x3 << 14) -#endif #define CURRENT_GATE_M2XCLK_MASK (0x3 << 12) -#ifdef VALIDATION_CHIP - #define CURRENT_GATE_M2XCLK_336MHZ (0x0 << 12) - #define CURRENT_GATE_M2XCLK_168MHZ (0x1 << 12) - #define CURRENT_GATE_M2XCLK_112MHZ (0x2 << 12) - #define CURRENT_GATE_M2XCLK_84MHZ (0x3 << 12) -#else #define CURRENT_GATE_M2XCLK_DIV_1 (0x0 << 12) #define CURRENT_GATE_M2XCLK_DIV_2 (0x1 << 12) #define CURRENT_GATE_M2XCLK_DIV_3 (0x2 << 12) #define CURRENT_GATE_M2XCLK_DIV_4 (0x3 << 12) -#endif #define CURRENT_GATE_VGA BIT(10) #define CURRENT_GATE_PWM BIT(9) #define CURRENT_GATE_I2C BIT(8) @@ -376,9 +362,6 @@ #define MODE1_GATE_DMA BIT(0) =20 #define POWER_MODE_CTRL 0x00004C -#ifdef VALIDATION_CHIP - #define POWER_MODE_CTRL_336CLK BIT(4) -#endif #define POWER_MODE_CTRL_OSC_INPUT BIT(3) #define POWER_MODE_CTRL_ACPI BIT(2) #define POWER_MODE_CTRL_MODE_MASK (0x3 << 0) @@ -400,15 +383,10 @@ #define PLL_CTRL_BYPASS BIT(18) #define PLL_CTRL_POWER BIT(17) #define PLL_CTRL_INPUT BIT(16) -#ifdef VALIDATION_CHIP - #define PLL_CTRL_OD_SHIFT 14 - #define PLL_CTRL_OD_MASK (0x3 << 14) -#else #define PLL_CTRL_POD_SHIFT 14 #define PLL_CTRL_POD_MASK (0x3 << 14) #define PLL_CTRL_OD_SHIFT 12 #define PLL_CTRL_OD_MASK (0x3 << 12) -#endif #define PLL_CTRL_N_SHIFT 8 #define PLL_CTRL_N_MASK (0xf << 8) #define PLL_CTRL_M_SHIFT 0 @@ -422,7 +400,6 @@ =20 #define SCRATCH_DATA 0x00006c =20 -#ifndef VALIDATION_CHIP =20 #define MXCLK_PLL_CTRL 0x000070 =20 @@ -431,7 +408,6 @@ #define VGA_CONFIGURATION_PLL BIT(2) #define VGA_CONFIGURATION_MODE BIT(1) =20 -#endif =20 #define GPIO_DATA 0x010000 #define GPIO_DATA_31 BIT(31) @@ -1020,9 +996,7 @@ #define CRT_DISPLAY_CTRL_CRTSELECT BIT(25) #define CRT_DISPLAY_CTRL_RGBBIT BIT(24) =20 -#ifndef VALIDATION_CHIP #define CRT_DISPLAY_CTRL_CENTERING BIT(24) -#endif #define CRT_DISPLAY_CTRL_LOCK_TIMING BIT(23) #define CRT_DISPLAY_CTRL_EXPANSION BIT(22) #define CRT_DISPLAY_CTRL_VERTICAL_MODE BIT(21) @@ -1121,22 +1095,17 @@ =20 /* This vertical expansion below start at 0x080240 ~ 0x080264 */ #define CRT_VERTICAL_EXPANSION 0x080240 -#ifndef VALIDATION_CHIP #define CRT_VERTICAL_CENTERING_VALUE_MASK (0xff << 24) -#endif #define CRT_VERTICAL_EXPANSION_COMPARE_VALUE_MASK (0xff << 16) #define CRT_VERTICAL_EXPANSION_LINE_BUFFER_MASK (0xf << 12) #define CRT_VERTICAL_EXPANSION_SCALE_FACTOR_MASK 0xfff =20 /* This horizontal expansion below start at 0x080268 ~ 0x08027C */ #define CRT_HORIZONTAL_EXPANSION 0x080268 -#ifndef VALIDATION_CHIP #define CRT_HORIZONTAL_CENTERING_VALUE_MASK (0xff << 24) -#endif #define CRT_HORIZONTAL_EXPANSION_COMPARE_VALUE_MASK (0xff << 16) #define CRT_HORIZONTAL_EXPANSION_SCALE_FACTOR_MASK 0xfff =20 -#ifndef VALIDATION_CHIP /* Auto Centering */ #define CRT_AUTO_CENTERING_TL 0x080280 #define CRT_AUTO_CENTERING_TL_TOP_MASK (0x7ff << 16) @@ -1146,7 +1115,6 @@ #define CRT_AUTO_CENTERING_BR_BOTTOM_MASK (0x7ff << 16) #define CRT_AUTO_CENTERING_BR_BOTTOM_SHIFT 16 #define CRT_AUTO_CENTERING_BR_RIGHT_MASK 0x7ff -#endif =20 /* sm750le new register to control panel output */ #define DISPLAY_CONTROL_750LE 0x80288 @@ -1326,9 +1294,7 @@ #define ZV0_CAPTURE_BUF1_ADDRESS_ADDRESS_MASK 0x3ffffff =20 #define ZV0_CAPTURE_BUF_OFFSET 0x090014 -#ifndef VALIDATION_CHIP #define ZV0_CAPTURE_BUF_OFFSET_YCLIP_ODD_FIELD (0x3ff << 16) -#endif #define ZV0_CAPTURE_BUF_OFFSET_OFFSET_MASK 0xffff =20 #define ZV0_CAPTURE_FIFO_CTRL 0x090018 diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750f= b/ddk750_chip.c index 0bb56bbec43f..ab8b68076dec 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -387,9 +387,7 @@ unsigned int sm750_calc_pll_value(unsigned int request_= orig, =20 unsigned int sm750_format_pll_reg(struct pll_value *p_PLL) { -#ifndef VALIDATION_CHIP unsigned int POD =3D p_PLL->POD; -#endif unsigned int OD =3D p_PLL->OD; unsigned int M =3D p_PLL->M; unsigned int N =3D p_PLL->N; @@ -401,9 +399,7 @@ unsigned int sm750_format_pll_reg(struct pll_value *p_P= LL) * applied to any PLL in the calling function. */ return PLL_CTRL_POWER | -#ifndef VALIDATION_CHIP ((POD << PLL_CTRL_POD_SHIFT) & PLL_CTRL_POD_MASK) | -#endif ((OD << PLL_CTRL_OD_SHIFT) & PLL_CTRL_OD_MASK) | ((N << PLL_CTRL_N_SHIFT) & PLL_CTRL_N_MASK) | ((M << PLL_CTRL_M_SHIFT) & PLL_CTRL_M_MASK); diff --git a/drivers/staging/sm750fb/ddk750_power.c b/drivers/staging/sm750= fb/ddk750_power.c index eaba3bc2e01a..d617f554f58d 100644 --- a/drivers/staging/sm750fb/ddk750_power.c +++ b/drivers/staging/sm750fb/ddk750_power.c @@ -58,14 +58,8 @@ void sm750_set_power_mode(unsigned int mode) /* Set up other fields in Power Control Register */ if (mode =3D=3D POWER_MODE_CTRL_MODE_SLEEP) { ctrl &=3D ~POWER_MODE_CTRL_OSC_INPUT; -#ifdef VALIDATION_CHIP - ctrl &=3D ~POWER_MODE_CTRL_336CLK; -#endif } else { ctrl |=3D POWER_MODE_CTRL_OSC_INPUT; -#ifdef VALIDATION_CHIP - ctrl |=3D POWER_MODE_CTRL_336CLK; -#endif } =20 /* Program new power mode. */ --=20 2.43.0 From nobody Sat Jul 25 04:31:00 2026 Received: from mail-07.mail-europe.com (mail-07.mail-europe.com [188.165.51.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 919B03033E9 for ; Sat, 18 Jul 2026 06:21:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.165.51.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784355691; cv=none; b=qPRbZkA7mriDXd4TtnMudOIGeslv8Q4epDtXIXbm05Z+Aik9BnVukE7e7qPRUD+m2GrbNn2Dksr6hWxnmjcD6S3rs6kIuXk9h32p9WVRstZuEn05TgEs5cePIQv1jJcAnsixVrFhlVrd4E1kcVal+CVddByVy+woM6jBy73S6N4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784355691; c=relaxed/simple; bh=aq5lttLtQv85kpcA9dgGHVffvIKBzVoUW5PjkNwm+EE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MgTZIJg6566gI3Bh8zDEQSYulWAsNbXOYwVyh2FlBHD3dUEtCXD//Mn4G1qwlfdARgfjy+xDmG6+pW41R4ocGemTy5j9nqpukVOvNCQuX6PVrwKhZQXFtOydg2bbw3jCZjrhvpDDx+2D62vDXXHqRwMZF9cAKMpRkdpgh/KeKF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=AOYNPNnG; arc=none smtp.client-ip=188.165.51.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="AOYNPNnG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1784355676; x=1784614876; bh=Bqe7z/QlpFlTUiqHzSAAcKslRo0AbEz85QoZxwn5E0w=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=AOYNPNnG77t6h2zyMcVl2UlwvpX1OIgiDhw6i3RO8WlV72PniQQbD05Qy9svE8Jc9 VGCKsXbP8d2F6ljfCBjviLUdK3ZkKhUbmTIDSAEdJ2gn5xSirH3lyhCJocbQFVlADx yL+ios/yMh8U4DnyZ+FeqsNvQUMAgPXbz4lALumN09mncs0x432IzD/vx7eYHWHDlQ NwEdpz12lQwE3TtRi8f4Y2rM+nUubqeiqZHxV5k/RXyO55yHYuZ9QJYtfc3Jxn0MgI tgkPGB8MgCBuKlo7LN9n42aBFco70QfI1L2HFadKfdqUixNlERYxV9UQWPX7RAkXag Ninb4lZiSRN+Q== Date: Sat, 18 Jul 2026 06:21:12 +0000 To: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman From: Nils Lehnen Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nils Lehnen Subject: [PATCH v2 2/2] staging: sm750fb: unindent defines left by conditional removal Message-ID: <20260718062027.5850-3-nils.lehnen@proton.me> In-Reply-To: <20260718062027.5850-1-nils.lehnen@proton.me> References: <20260718062027.5850-1-nils.lehnen@proton.me> Feedback-ID: 188354734:user:proton X-Pm-Message-ID: d66cefe6d8a34bbb5be4c7ecc5bad0510f23dd41 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The preceding removal of the VALIDATION_CHIP conditionals left the surviving define blocks and one comment indented by four spaces, and two double blank lines where conditional lines went away. Move the now-unconditional defines to column zero while keeping the aligned value column untouched, and collapse the blank lines. No functional change: whitespace and preprocessor layout only; the disassembly of all ten sm750fb object files stays bit-identical. All English text in this patch (commit message and code comments) was translated from a German draft with the assistance of Claude Fable 5. Assisted-by: Claude:claude-fable-5 Signed-off-by: Nils Lehnen --- drivers/staging/sm750fb/ddk750_reg.h | 50 +++++++++++++--------------- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_reg.h b/drivers/staging/sm750fb= /ddk750_reg.h index 4bcede37584a..2888ffe32fa2 100644 --- a/drivers/staging/sm750fb/ddk750_reg.h +++ b/drivers/staging/sm750fb/ddk750_reg.h @@ -294,15 +294,15 @@ =20 #define CURRENT_GATE 0x000040 #define CURRENT_GATE_MCLK_MASK (0x3 << 14) - #define CURRENT_GATE_MCLK_DIV_3 (0x0 << 14) - #define CURRENT_GATE_MCLK_DIV_4 (0x1 << 14) - #define CURRENT_GATE_MCLK_DIV_6 (0x2 << 14) - #define CURRENT_GATE_MCLK_DIV_8 (0x3 << 14) +#define CURRENT_GATE_MCLK_DIV_3 (0x0 << 14) +#define CURRENT_GATE_MCLK_DIV_4 (0x1 << 14) +#define CURRENT_GATE_MCLK_DIV_6 (0x2 << 14) +#define CURRENT_GATE_MCLK_DIV_8 (0x3 << 14) #define CURRENT_GATE_M2XCLK_MASK (0x3 << 12) - #define CURRENT_GATE_M2XCLK_DIV_1 (0x0 << 12) - #define CURRENT_GATE_M2XCLK_DIV_2 (0x1 << 12) - #define CURRENT_GATE_M2XCLK_DIV_3 (0x2 << 12) - #define CURRENT_GATE_M2XCLK_DIV_4 (0x3 << 12) +#define CURRENT_GATE_M2XCLK_DIV_1 (0x0 << 12) +#define CURRENT_GATE_M2XCLK_DIV_2 (0x1 << 12) +#define CURRENT_GATE_M2XCLK_DIV_3 (0x2 << 12) +#define CURRENT_GATE_M2XCLK_DIV_4 (0x3 << 12) #define CURRENT_GATE_VGA BIT(10) #define CURRENT_GATE_PWM BIT(9) #define CURRENT_GATE_I2C BIT(8) @@ -383,10 +383,10 @@ #define PLL_CTRL_BYPASS BIT(18) #define PLL_CTRL_POWER BIT(17) #define PLL_CTRL_INPUT BIT(16) - #define PLL_CTRL_POD_SHIFT 14 - #define PLL_CTRL_POD_MASK (0x3 << 14) - #define PLL_CTRL_OD_SHIFT 12 - #define PLL_CTRL_OD_MASK (0x3 << 12) +#define PLL_CTRL_POD_SHIFT 14 +#define PLL_CTRL_POD_MASK (0x3 << 14) +#define PLL_CTRL_OD_SHIFT 12 +#define PLL_CTRL_OD_MASK (0x3 << 12) #define PLL_CTRL_N_SHIFT 8 #define PLL_CTRL_N_MASK (0xf << 8) #define PLL_CTRL_M_SHIFT 0 @@ -400,7 +400,6 @@ =20 #define SCRATCH_DATA 0x00006c =20 - #define MXCLK_PLL_CTRL 0x000070 =20 #define VGA_CONFIGURATION 0x000088 @@ -408,7 +407,6 @@ #define VGA_CONFIGURATION_PLL BIT(2) #define VGA_CONFIGURATION_MODE BIT(1) =20 - #define GPIO_DATA 0x010000 #define GPIO_DATA_31 BIT(31) #define GPIO_DATA_30 BIT(30) @@ -996,7 +994,7 @@ #define CRT_DISPLAY_CTRL_CRTSELECT BIT(25) #define CRT_DISPLAY_CTRL_RGBBIT BIT(24) =20 - #define CRT_DISPLAY_CTRL_CENTERING BIT(24) +#define CRT_DISPLAY_CTRL_CENTERING BIT(24) #define CRT_DISPLAY_CTRL_LOCK_TIMING BIT(23) #define CRT_DISPLAY_CTRL_EXPANSION BIT(22) #define CRT_DISPLAY_CTRL_VERTICAL_MODE BIT(21) @@ -1095,26 +1093,26 @@ =20 /* This vertical expansion below start at 0x080240 ~ 0x080264 */ #define CRT_VERTICAL_EXPANSION 0x080240 - #define CRT_VERTICAL_CENTERING_VALUE_MASK (0xff << 24) +#define CRT_VERTICAL_CENTERING_VALUE_MASK (0xff << 24) #define CRT_VERTICAL_EXPANSION_COMPARE_VALUE_MASK (0xff << 16) #define CRT_VERTICAL_EXPANSION_LINE_BUFFER_MASK (0xf << 12) #define CRT_VERTICAL_EXPANSION_SCALE_FACTOR_MASK 0xfff =20 /* This horizontal expansion below start at 0x080268 ~ 0x08027C */ #define CRT_HORIZONTAL_EXPANSION 0x080268 - #define CRT_HORIZONTAL_CENTERING_VALUE_MASK (0xff << 24) +#define CRT_HORIZONTAL_CENTERING_VALUE_MASK (0xff << 24) #define CRT_HORIZONTAL_EXPANSION_COMPARE_VALUE_MASK (0xff << 16) #define CRT_HORIZONTAL_EXPANSION_SCALE_FACTOR_MASK 0xfff =20 - /* Auto Centering */ - #define CRT_AUTO_CENTERING_TL 0x080280 - #define CRT_AUTO_CENTERING_TL_TOP_MASK (0x7ff << 16) - #define CRT_AUTO_CENTERING_TL_LEFT_MASK 0x7ff +/* Auto Centering */ +#define CRT_AUTO_CENTERING_TL 0x080280 +#define CRT_AUTO_CENTERING_TL_TOP_MASK (0x7ff << 16) +#define CRT_AUTO_CENTERING_TL_LEFT_MASK 0x7ff =20 - #define CRT_AUTO_CENTERING_BR 0x080284 - #define CRT_AUTO_CENTERING_BR_BOTTOM_MASK (0x7ff << 16) - #define CRT_AUTO_CENTERING_BR_BOTTOM_SHIFT 16 - #define CRT_AUTO_CENTERING_BR_RIGHT_MASK 0x7ff +#define CRT_AUTO_CENTERING_BR 0x080284 +#define CRT_AUTO_CENTERING_BR_BOTTOM_MASK (0x7ff << 16) +#define CRT_AUTO_CENTERING_BR_BOTTOM_SHIFT 16 +#define CRT_AUTO_CENTERING_BR_RIGHT_MASK 0x7ff =20 /* sm750le new register to control panel output */ #define DISPLAY_CONTROL_750LE 0x80288 @@ -1294,7 +1292,7 @@ #define ZV0_CAPTURE_BUF1_ADDRESS_ADDRESS_MASK 0x3ffffff =20 #define ZV0_CAPTURE_BUF_OFFSET 0x090014 - #define ZV0_CAPTURE_BUF_OFFSET_YCLIP_ODD_FIELD (0x3ff << 16) +#define ZV0_CAPTURE_BUF_OFFSET_YCLIP_ODD_FIELD (0x3ff << 16) #define ZV0_CAPTURE_BUF_OFFSET_OFFSET_MASK 0xffff =20 #define ZV0_CAPTURE_FIFO_CTRL 0x090018 --=20 2.43.0