From nobody Sat Jul 25 04:30:07 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 173C71B86C7 for ; Sat, 18 Jul 2026 06:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784355145; cv=none; b=WY7S+uA0ZKXaGVnM7DoZkMscI/zLxMioCw42mGyWDz7XNBN8CHU0B/rAU6sdLK922QKWocphZ9lo0dwMcG/+0XPJAIjwOG/InA0ZNIDCZAHbOX61ZnK4MabZgbcS4JyHZtV0wdTvIqohd8v0I8ZArrIfRxPKyO0adOWDbvsc6Hs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784355145; c=relaxed/simple; bh=LSDi4vg4dkRBpeBiyuKHc8nkkYy3z0Zlsyl0NPyVwEE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=kNmiBO9nqhBTws3YqQW6y72OCp7pbavqCd2IRz7WYxUr46eiP0zPdU74ZUO0d+pahfmoRfQEH9DBpAd6oQSrIDHp2tC8kgrIeYagyMf9T/opfn7tSnXuwVKQHJE82vqc2glGLOlLiCCXUG+CUS8F1c0yo9TW2iBEpz6ZqGH1Ukk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LOreV1qg; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LOreV1qg" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2cee9b74ee1so50351825ad.3 for ; Fri, 17 Jul 2026 23:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784355143; x=1784959943; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=HvzRwdyZtvw7BXz2mvnVzoWsQjj8u9HVqDmukJny8A8=; b=LOreV1qgj+WUAoRc6dqA+yVUYMI3PD4Q03f9HiuKM6zziZ+is19AJIA9nazxoQjDtX Fy2Ln2GqRLmRcAvQGZiM2mzAhWQ6oX12WPhNGYk/qnBt1faDDW3pL4dA+i6EgCZT1nrU jqBYIyRelXfnU5KuDuMVSLDg8hmE44WfzMRQp46NTxeglalxg9a4fJNyfTpl5G0aWV1Z PaWZWLFObpbZ9l5XkvxcM4eBTnK251f4oCsySEtJ0Z5L9grl/4Tti+/eXmSqhV6eXn84 nDaeDwrhlTFoy2nHieifPI+DjxG4PtEmRu+LcF83pB1nEYoe06jlr1AcUgVzmCLdOY8Z d0bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784355143; x=1784959943; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=HvzRwdyZtvw7BXz2mvnVzoWsQjj8u9HVqDmukJny8A8=; b=AvHeBfmLFPx5Y+3EZyqBta1JVKEc7Jml8JvV7cAaseAUyXnhR6PD003u+jRcx9J68I o9iCL/UBBTBY2j/WO8nGFJZaO1P2Gh2GwyrkY3xyNr5OPCJbI+ISeKZisXpAz55yrh1W Opzq3YY3/4i7WD7R5vyRZUDBDlm34DbiWqgknXA3hhSwXzM8ZvN+EweU+QyhKXhIXgsh /Z9scw7wnaENY2lfOJpix2ceVSReFbNzwbDcS832VbZL1O2ZBtaJCTvp7Ijh+pXX5fZb M4H7ByfoMtg1wL++JKtjpJ89lpH1NkAMyDO6zKi2JkQpq33q2oZlRqJgg5ygY00cXvps EjxQ== X-Forwarded-Encrypted: i=1; AHgh+RqxgbgO4oJFREkoN6roEyg08fHjCpguzaEp5AhFkwY1TPkKM/6ivLxZz58fssXR6sfM4LsPRJPHxXP0i60=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1sPYXsj/MrIEOn9Zn9oHTZqgpWoiJ6Fopv3fhJ7X//8/wiDcb HZqK6LJJJnzr1Npx36roLdFNnuBsbbnZfzrb0/Cfmw6NHZ1iqcfnAvM65d83DYotO6E= X-Gm-Gg: AfdE7ckssGgiPxJLpTfoxD3J1ngEXEYHk5q7FKqUBSnvQXD4df/Ps4UpmONuAM1o1Oz ewduLT9n9xv4HNPB02BRfAPad8W+KuoUEQ/qERyIrNXw9jhDfqqrKiEDoMWo2zZMISj/2HAGe8x 4iWNEwOMpU4nwo1v2NdWBNLRY8L9NVdzI70jEQOw/gzLc7wJF5ms2MZVmS0XlUXbQpZIL9sgirU H4rvgjxPO1VBc/OU7xnr2zTwJO14ffyRva3b+sIHIGrZDdiKxCpEDAPc16hILit8T2Ikuq+u626 RH+Kshmg5012OXVvqrXxRJunO5AZ5qLz1HPrcgZP1rE5JsJ1gduSxPcC/XqCIW63wDe8uPEggLW iN2evVnT6icZQMlQ/AQjJgEEcvoIFQT1pzWkl4ezgshEmqdi3PTL4jvsGb6V5 X-Received: by 2002:a17:903:11c3:b0:2cc:6817:d9b1 with SMTP id d9443c01a7336-2cf34a00b94mr65975315ad.41.1784355143430; Fri, 17 Jul 2026 23:12:23 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf3471513bsm22271745ad.57.2026.07.17.23.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 23:12:22 -0700 (PDT) From: Guangshuo Li To: Mauro Carvalho Chehab , Kees Cook , Wang Jun <1742789905@qq.com>, Hans Verkuil , Guangshuo Li , Steven Toth , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] media: saa7164: fix cleanup on resource allocation failure Date: Sat, 18 Jul 2026 14:10:11 +0800 Message-ID: <20260718061012.2964002-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" saa7164_dev_setup() adds the device to the global saa7164_devlist before requesting the PCI BAR memory regions. If get_resources() fails, saa7164_dev_setup() decrements the device count and returns an error, but leaves the device on saa7164_devlist. The probe error path then frees the device, leaving a dangling entry on the global list. Reuse the existing MMIO mapping error path to remove the device from saa7164_devlist and decrement the device count before returning. Also release BAR0 if it was successfully requested but the BAR2 request fails. Fixes: 443c1228d505 ("V4L/DVB (12923): SAA7164: Add support for the NXP SAA= 7164 silicon") Signed-off-by: Guangshuo Li --- v2: - Reuse the existing error handling path instead of duplicating the device list cleanup, as suggested by Hans Verkuil. - Add a new error label after release_resources() for failures where no P= CI resources need to be released. drivers/media/pci/saa7164/saa7164-core.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/s= aa7164/saa7164-core.c index 6bcde506adf5..db65506ea885 100644 --- a/drivers/media/pci/saa7164/saa7164-core.c +++ b/drivers/media/pci/saa7164/saa7164-core.c @@ -878,6 +878,9 @@ static int get_resources(struct saa7164_dev *dev) if (request_mem_region(pci_resource_start(dev->pci, 2), pci_resource_len(dev->pci, 2), dev->name)) return 0; + + release_mem_region(pci_resource_start(dev->pci, 0), + pci_resource_len(dev->pci, 0)); } =20 printk(KERN_ERR "%s: can't get MMIO memory @ 0x%llx or 0x%llx\n", @@ -1000,8 +1003,7 @@ static int saa7164_dev_setup(struct saa7164_dev *dev) dev->name, dev->pci->subsystem_vendor, dev->pci->subsystem_device); =20 - saa7164_devcount--; - return -ENODEV; + goto err_devlist; } =20 /* PCI/e allocations */ @@ -1039,7 +1041,7 @@ static int saa7164_dev_setup(struct saa7164_dev *dev) iounmap(dev->lmmio); err_ioremap_bar0: release_resources(dev); - +err_devlist: scoped_guard(mutex, &devlist) { list_del(&dev->devlist); } --=20 2.43.0