From nobody Sat Jul 25 04:29:55 2026 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0CD31DF72C for ; Sat, 18 Jul 2026 12:47:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784378872; cv=none; b=Plz/kTTSgWKQJjLPZbvG2HhwTgZwY5BLHHkV62C0zFvlDDS4qaSD5Jkbvc6dwozJCpBvhXcTQmVaWeOBFhMkZhnc9aPPHI0lZAYR6RhoIXdkMeoUOSxQnqw+7LtpfzHeILinDJ2BrVZcZqf2wMOfJvLB5/SJWIgCl4RZ5texowk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784378872; c=relaxed/simple; bh=+DglkG3f/oa2ZGnDkZHurCMH7odPQbvwJv1U9ofUel4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cYXJ1OigRN+Dy2/BhibKTAbLOcfsN4FtcoF71U8rM5GSTm3VjIX82fyPXFd8lyOjjCYwtm3ghcir8pNE6DlZlrt7LH5YywXA9DEOq5hgIvfkxUIJZwO3UsyHkQZrWUpkf7lE4tc2kzZp0B/C8gfMBRn7eqmz2csPIQIz7+8Cj0o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=kwLNYbGn; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="kwLNYbGn" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D4298240101 for ; Sat, 18 Jul 2026 14:47:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1784378868; bh=fjzyqMHqJCpWgCPY606AraCobo3dyLkKwD8V5CQfQK8=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=kwLNYbGnuMqRzmQRRP/l8EKiIwbrpnV1ZtgTUPgdhrrYqv5mprxg1mQ6otz/pLdGX 4nUyNPyb1MYBFxu7rRvlBfgB7Gw2cE3gEoPBv3FlPPfw1eHWmdoqubLCpp2+Hw8ptK OSp5eP028SqOf6pB/0LRy4wyo5xED9an/CvHxtyS91oLWsRKgCZt1c00W56AfiWwQt mJvnqkK81qinCqi0XcXRIr1aKzh1SZyJUf0JVl7SuN9S9839L0RkCxFs+Xceu/c6c9 68WLxLi3/IaLLMgprhS1/aMtUImPYfypn54ytDbm7UAsaFCUY94fEB9Km/P1z5faJr Zpp7+IN7xd+NQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4h2RQB73cMz6tvs; Sat, 18 Jul 2026 14:47:46 +0200 (CEST) From: Markus Probst Date: Sat, 18 Jul 2026 12:47:47 +0000 Subject: [PATCH v2 1/4] rust: serdev: fix typo in rustdoc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260718-rust_serdev_fixes-v2-1-e5214e03de13@posteo.de> References: <20260718-rust_serdev_fixes-v2-0-e5214e03de13@posteo.de> In-Reply-To: <20260718-rust_serdev_fixes-v2-0-e5214e03de13@posteo.de> To: Greg Kroah-Hartman , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: linux-serial@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Probst , kernel test robot X-Developer-Signature: v=1; a=openpgp-sha256; l=1009; i=markus.probst@posteo.de; h=from:subject:message-id; bh=+DglkG3f/oa2ZGnDkZHurCMH7odPQbvwJv1U9ofUel4=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqW3XwpDTocvu2ZnGz9Qp6r/9ZZMjjqKAfyC5ul wdU7oz0osOJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCalt18BsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9KWPQ/5AXlhQVUYscP5A+P3IyjLyUN2tsgklco l4yPdfCkFmz4kha4Bvtp+HoX5lXip1uwDBUMl8IPEpJSEe0Qj1TXlWzmlNcULSlCY4uI84OcT9Z BgeHPHO6gGJw6+gA16psZj0WH+tQXxwjo+vMKqkPXF2GMubbTX/lXyYvSl3HArD3F6hToj9OEbb sWjX99Wv4qaH3BI9KQbs9zjAqITzukjX4Zw0j+cw1G58XuPDDYIYicBHS/hfd5KUAnwZiCI5jXi kPkQZUGL5fpDZod1k3J6wz6VHDbmIQ8WWcnIEnGD0fr4y9nip3ya7qH4qiyBa02CwhWgbmSkWfN YC9wOBksXL57p4NHyQ6MGyJJYq2R3MBZ55SCJ/ceEOBrtNdVJTjVwlDXiPwr/RP3GG5le/Q9fQS d9wnrTz+fwU244fo1iDW7tcgQcUQkTj4XL2I369M9DxG8EuTqjlhxXK7uTQAPUaQ5BB5uaKKIlU oDtv9UGPX42jirhbvlQKjPx98Fz/wRVDaicMYVTFcgbprLnesuu4rvlzxrFN8CF0aVL7t9Bn/Fi xR9NbHxeFuznx9gp2pSO+kENxuWuc9xXgX+xtYkVQZGm91qM2iLp7HpKP1G3Sj+msgo2cec3eHK F70rbcFjW9NZAyXkOjSdCZ0ahpGXazOFiFn2sSEJhQf3+JecwpLM= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Fix trivial typo Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202607172113.hLDQgD4l-lkp@int= el.com/ Signed-off-by: Markus Probst --- rust/kernel/serdev.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/serdev.rs b/rust/kernel/serdev.rs index 0ffcef1849d2..47ca57966abf 100644 --- a/rust/kernel/serdev.rs +++ b/rust/kernel/serdev.rs @@ -515,7 +515,7 @@ pub fn write_all(&self, data: &[u8], timeout: Timeout) = -> Result { /// [`Device::write_all`]. /// /// Note that any accepted data has only been buffered by the controll= er. Use - /// [ Device::wait_until_sent`] to make sure the controller write buff= er has actually been + /// [`Device::wait_until_sent`] to make sure the controller write buff= er has actually been /// emptied. /// /// Returns the number of bytes written (less than `data.len()` if not= enough room in the --=20 2.54.0 From nobody Sat Jul 25 04:29:55 2026 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDF111E9B3A for ; Sat, 18 Jul 2026 12:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784378873; cv=none; b=bp6bv2saG3jQNBIFvUNRslHdx4ZgHiluRBFcAMFydWhPgUjbq2KsFtOq7sySpBRsaz7tw+lgmJIo/VMTl1VnnvpmdpFmbpSreS0tFYM7PT9lgYCNg1xIOm9ZveCzi8leqn7LJ+0hoUAmmByhEE8lLbqiiT+AQ9rNjBc83rjxdRk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784378873; c=relaxed/simple; bh=ejBjjZoyNnpyxaqkTKNHNkHtdFFEL9SeyoIKLMqQlYA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q3xzyBLcujf+nCbHcP4ikA5kmB7zw2F6bcjjjyZCLCSr64A1oReyfqUGLAHiOZGoQfkImAgR1bVbajh8ZkgK5/cVs6i/cmU9o2lzFfHpKeTDXGLu2hnS6QyrHc8Nxnz1GhEHgKlncdypSFhHVwomVk57aATNOJEwknXylTBpIvQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=hrcv72Y0; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="hrcv72Y0" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 386D024002A for ; Sat, 18 Jul 2026 14:47:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1784378870; bh=ulyF8m79sw5U2CfdPGNsD4XEEokVxvg7p9l8hRTjR9k=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=hrcv72Y0WfpkSHaOU+isxejHKq/l22ZPWsg8lZleJ+awtRyDVOumSski2AULAm1ho noFooyPwayAVg+2Hv3gB/WhOAx4YkB5+ofvvPvMkwfYM5amGi6+CavC2WzfhuPlyPh 7uZJ9CEol1cxRke1kH1GIaQP/wTjDAoBqCbgSZEGWFk0j+vGOt2AVUbMppUUAvKxdH fTdOl7o4hFLkr6bWvSacY3GLmRGFMFE3fly8UuCfaHmWbSWzb+tyjDiMp2zYmCiNQW xje4gQW0MlUpM7XnENtDO9Qu8Gf0Mgl2kUs7mKuVvHO21cid3edIf9xVpyl5RuGajk XCBsJ/ZRC5FIg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4h2RQD0Sz2z6txq; Sat, 18 Jul 2026 14:47:48 +0200 (CEST) From: Markus Probst Date: Sat, 18 Jul 2026 12:47:48 +0000 Subject: [PATCH v2 2/4] rust: serdev: mark small functions as `#[inline]` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260718-rust_serdev_fixes-v2-2-e5214e03de13@posteo.de> References: <20260718-rust_serdev_fixes-v2-0-e5214e03de13@posteo.de> In-Reply-To: <20260718-rust_serdev_fixes-v2-0-e5214e03de13@posteo.de> To: Greg Kroah-Hartman , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: linux-serial@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=3954; i=markus.probst@posteo.de; h=from:subject:message-id; bh=ejBjjZoyNnpyxaqkTKNHNkHtdFFEL9SeyoIKLMqQlYA=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqW3Xx9V1C+mOfyaoDCqkwLl2e1COCCxJGggFRQ GgMrgAJKHGJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCalt18RsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9IcSg/9F07LSGtuk7gd5m4x1Tu55JGG5UPXDg+ 0b1V7pHsTgdKSaztYMciZ3RCwFFO8MpBNDiQH06h0O9q+mPMKdvOkx/SgMc2W1wk4m571YN9kkJ 3rFDLOw8gx87cw9TOFTvSCksV47a7B0UX0EHJHO3aTdua8jYyIIC+tw0ucmIDk58eYoy1L2sFtf i6Iv8TlcKO6G+OXiOqGtuc6bGiepLYej1dTcrJpFeZDshyMjhHB9gSmJ29BbYEQW5yxBNNjPUq0 KlPsWXB/nyjPk9cd8mVTyw9itpEoEOrUUEvBfRCTKJrd8l2+/VeQfmxXGY9+qAxdVvTEvTISl4d lRaO5XXhjG/lPrgA7wQ4oXl8k9caLmFVQbim75uDW4IhhuKkT/mJT1zWTcBJUx4Ct9/1Z6nWpfF ob9oWKCStJQIW9Q1efQFm3el/gESnFV2QeCRgZOoy6ct3CZKugqzFsbKMKyVFXt2s7oW80+oCcQ PWlN+piTowqo2m7ZG3ih/8C6JCGqaB64FqEIUfl18k2oZ7zu10uVkYzCsmLm0OJNiVQv4e6lrCI dnxVofo8fq5NXV9qEpv4rzmNPY+1l/l2HOuPaId1C6Nq9DSStxBGTSTXzKn/1dW+OU2JFJUPdzj isOsJw4rO32uiW34JNe34j6pXVh0/N5Mpg8cuF8wa+MuLmAKG+1g= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt These methods should be inlined for optimization reasons. Suggested-by: Gary Guo Link: https://lore.kernel.org/rust-for-linux/DK0SX3P5K1J6.1OV4ETJMXW83R@gar= yguo.net/ Signed-off-by: Markus Probst --- rust/kernel/serdev.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/rust/kernel/serdev.rs b/rust/kernel/serdev.rs index 47ca57966abf..79d61c6ceeec 100644 --- a/rust/kernel/serdev.rs +++ b/rust/kernel/serdev.rs @@ -440,6 +440,7 @@ pub struct Device( ); =20 impl Device { + #[inline] fn as_raw(&self) -> *mut bindings::serdev_device { self.0.get() } @@ -451,6 +452,7 @@ impl Device { /// Common baudrates are 115200, 9600, 19200, 57600, 4800. /// /// Use [`Device::write_flush`] before calling this if you have writte= n data prior to this call. + #[inline] pub fn set_baudrate(&self, speed: u32) -> Result<(), u32> { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. let ret =3D unsafe { bindings::serdev_device_set_baudrate(self.as_= raw(), speed) }; @@ -464,6 +466,7 @@ pub fn set_baudrate(&self, speed: u32) -> Result<(), u3= 2> { /// Set if flow control should be enabled. /// /// Use [`Device::write_flush`] before calling this if you have writte= n data prior to this call. + #[inline] pub fn set_flow_control(&self, enable: bool) { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. unsafe { bindings::serdev_device_set_flow_control(self.as_raw(), e= nable) }; @@ -472,6 +475,7 @@ pub fn set_flow_control(&self, enable: bool) { /// Set parity to use. /// /// Use [`Device::write_flush`] before calling this if you have writte= n data prior to this call. + #[inline] pub fn set_parity(&self, parity: Parity) -> Result { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. to_result(unsafe { bindings::serdev_device_set_parity(self.as_raw(= ), parity as u32) }) @@ -487,6 +491,7 @@ pub fn set_parity(&self, parity: Parity) -> Result { /// Returns the number of bytes written (less than `data.len()` if int= errupted). /// [`kernel::error::code::ETIMEDOUT`] or [`kernel::error::code::EREST= ARTSYS`] if interrupted /// before any bytes were written. + #[inline] pub fn write_all(&self, data: &[u8], timeout: Timeout) -> Result { if data.len() > i32::MAX as usize { return Err(EINVAL); @@ -520,6 +525,7 @@ pub fn write_all(&self, data: &[u8], timeout: Timeout) = -> Result { /// /// Returns the number of bytes written (less than `data.len()` if not= enough room in the /// write buffer). + #[inline] pub fn write(&self, data: &[u8]) -> Result { if data.len() > i32::MAX as usize { return Err(EINVAL); @@ -539,6 +545,7 @@ pub fn write(&self, data: &[u8]) -> Result { /// /// Note that this doesn't guarantee that the data has been transmitte= d. /// Use [`Device::wait_until_sent`] for this purpose. + #[inline] pub fn write_flush(&self) { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. unsafe { bindings::serdev_device_write_flush(self.as_raw()) }; @@ -547,6 +554,7 @@ pub fn write_flush(&self) { /// Wait for the data to be sent. /// /// After this function, the write buffer of the controller should be = empty. + #[inline] pub fn wait_until_sent(&self, timeout: Timeout) { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. unsafe { bindings::serdev_device_wait_until_sent(self.as_raw(), ti= meout.into_jiffies()) }; --=20 2.54.0 From nobody Sat Jul 25 04:29:55 2026 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 342DB388E72 for ; Sat, 18 Jul 2026 12:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784378876; cv=none; b=TviC9V0+qCWVPGOlZQbaWo1F1SmqAkrYhVFsVG3pk+f7Ze6PraOxXnLKCZWwWYFrtXzG6r0ITc2miz5jkjhkkpe7Q4VScltieDNIiz9OFtg4yp6onTgB9bGmvOMXqtzBbkH1M+UbuCKB5Yz6fMe3KiCFpdTPVP3j1WZJExvIzis= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784378876; c=relaxed/simple; bh=J1tI9f3jC5ts0Ly/hfiH6lrfbcMCqQ3s2pmza6gp4rc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mJtAy8vJfCLPTclzRJytCH6AkVs8m1AbXgCY7X+LtlHh3KfOmuCKmyBlgKEttVQKQOCd5xhPHN8Ah+pRfLdOVWkEoGFzR0wDSMJcwEHVOWk+f3OXTRTPkSKBfn1R8xdlp/wmyB4T6Bo4jK34qoekIdafuaYOgGOiU5/HerguCWI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=ft2sR6LH; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="ft2sR6LH" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 26925240101 for ; Sat, 18 Jul 2026 14:47:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1784378871; bh=t7BKnS7EMjRmW4YFV6NvV7lNwNUcrxmXMtnTvDUuTuw=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=ft2sR6LHTC15/ylp02eroha4SrBRQ6KhSB2WqzLw76jLjWFlDBRlwX51yAZwRNaHZ YGrzO+NcnPFeiyWlZSFr3ZIf/MQvBy7hSjWwR8BGg4WX7tMPSPxMUCnvMv0eNL0fSp 9t+ZnEbKZTUWM6mmVIWI72ngCTi2chfGODTyjhiOM4FL89oHAHL+r/FDNt9pQNOKv+ 0ew02KbDRkhA9HVhtMuc129s/Yh29QUFNmDgUTCziA1mJKG+Gk0fWJYVQ5mg3FOjRW uYxHpUjFWt4r907fhhi31fp0TEMFuv1TrlLxTRnYwggW8JweusWLNNBhwI6TDYKjPi 2OJyGWn+HFBdA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4h2RQF0M4Sz6tvs; Sat, 18 Jul 2026 14:47:49 +0200 (CEST) From: Markus Probst Date: Sat, 18 Jul 2026 12:47:49 +0000 Subject: [PATCH v2 3/4] rust: serdev: document `PrivateData::active` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260718-rust_serdev_fixes-v2-3-e5214e03de13@posteo.de> References: <20260718-rust_serdev_fixes-v2-0-e5214e03de13@posteo.de> In-Reply-To: <20260718-rust_serdev_fixes-v2-0-e5214e03de13@posteo.de> To: Greg Kroah-Hartman , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: linux-serial@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=1821; i=markus.probst@posteo.de; h=from:subject:message-id; bh=J1tI9f3jC5ts0Ly/hfiH6lrfbcMCqQ3s2pmza6gp4rc=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqW3XxWhPwlxiGPuQEnb8IJpyzpY29d1TKVbU5V gzl2zaPqFKJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCalt18RsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9Juow/+OSuutmdqe37PozLg3bwDHNTNqzQslfH QVDJiB+9ekown05G7rVN5+NQLVvsTQoi5xyE9NfiR+2aJdJlxqBPyQDud3foZvQrYHOO7ck7tIX Zeu1+1iuA2fQEnIRmkLQeI3yZ6Qtkdz7fkvaXgbMjkURz6glzVmjtPZKbUff/L1i1nD71QzGthk w7i24fQ0Ozqh6rOVnSqcYytoZ9xw95rB4MJGFnWi8bcOIRmNVhxFZAPAeACGO4tU91gyOw2rhPi NoSPPaWLSE6eokiUN0GlXGqe7JYV89xOCAUthFkDR367ksq+vj5zJGJ24C95zthSGg7pTO7sQc+ bJadf960GIiKGXvyUxOy3l8ZlrezsgVPbcl90bT1sNvKxZlJvPyKgB65XyvJFYP1gvAIeTxDmUT IUUepkVBiFUornXof4yDj2VMcXdcBlvH2HvdlwhjUBc8tlX4PZDtauKp/6r/MS6we4UJh50vzA/ 6xKqWR7IrwEJfutjNq8N0IrtuPyMc/95fFSAOo+8i4Tyf/gpupv6LPHG+MiTO+NdbRiTmJCPTwM gDOlsvNAsLD8i2l8MWEiSGEzkYD066db2zzHQiIU9NfZOw09ak/8yUREQgZvmYROS2vxbYUSjjd Xprh20ZqP7tygI73ntPNCXA839TkylCanoBPzNEUC5oQWBJuNLmM= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Gary pointed out that it isn't clear for what the mutex is used for, thus adding documentation comments for it. Suggested-by: Gary Guo Link: https://lore.kernel.org/rust-for-linux/DK0SX3P5K1J6.1OV4ETJMXW83R@gar= yguo.net/ Signed-off-by: Markus Probst --- rust/kernel/serdev.rs | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/rust/kernel/serdev.rs b/rust/kernel/serdev.rs index 79d61c6ceeec..a78dfa6e2c27 100644 --- a/rust/kernel/serdev.rs +++ b/rust/kernel/serdev.rs @@ -132,6 +132,23 @@ pub struct PrivateData<'bound, T: Driver> { #[pin] driver: UnsafeCell>>, open: UnsafeCell, + /// Whether `receive_buf_callback` is allowed to call `Driver::receive= `. + /// + /// If locked, the receive_buf_callback will be blocked on data recept= ion. + /// This is the case while the driver is being probed or while [`Priva= teData`] is being dropped. + /// This is necessary, because we need to open the serdev device befor= e the driver has been + /// probed in order to allow it to be configured, which allows `receiv= e_buf_callback` to be + /// called. Thus we need to block data until probe completes and the d= river data becomes + /// initialized. + /// + /// If unlocked and true, the receive_buf_callback will forward the da= ta to + /// `Driver::receive`. This is the normal state of operation. + /// + /// If unlocked and false, the receive_buf_callback will throw away th= e data. + /// This is only the case, if the serdev device is open and + /// - the driver returned an error in probe + /// or + /// - the driver data already has been dropped, because it was unbound. #[pin] active: Mutex, } --=20 2.54.0 From nobody Sat Jul 25 04:29:55 2026 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 341EE388E64 for ; Sat, 18 Jul 2026 12:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784378876; cv=none; b=bnc2qixeDTHPmrWpffOZLtTPnVkUV3w4tl3/iYOZwgBvfaYHT7D2mSEqllHF3ljUtcgifIsR45AhEPio85YsCBlqUdTXCNBZ1UW3qTdhAhHheERfrvG57WLEQmbx/EiPCZDcmGqpRc0rqjY5XIGYnXYFL1llR2qEzqq8q+5613Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784378876; c=relaxed/simple; bh=5Upn3XgzNHsfFjssw0UXmxtjmmJmk1QhUiVZAnpqPnM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jqUsWBfWbzw/zBtnZbWQ6m4Z6RYezmAnmCRb0fXZw/qzZBU3p39T++yEeg7VeyCjBzMhuLbG6W1NBsaXSB7okIMRQoYiaFC6W3pRl+/KlRIk9ec4A6YiWEJGme2UU2BiafzZVr63qqVHJXspC2kAQXhHighl/qIzIsRTsZs2/zc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=MZXSOBwD; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="MZXSOBwD" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EA710240101 for ; Sat, 18 Jul 2026 14:47:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1784378871; bh=9ZZOAvXfJWsCMzdmVLuGtcsnNAcVrXzkXiB16u34YRo=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=MZXSOBwDEU9rWDX6MDGhigeBdG6AUqHamEVTFx09yPmhl9cAFEERU7fIQuUF/cYY4 ccAsnIHIhU/otGF8I20IXbjJ0LBse1ftXz7DyWm6oyn5vl/jhtmEZ42qNFwRUbR+Hx fHO11EnLAllrROi/toW13vz/yMKl0pReASjZ7b7f9BqWLfsFxp/Qm4fvKSKqsR5oO9 ywdPtbBrdzUJfWbcDQZr/OPcOOREFLejF872qqhWmvmaNzzVzY/qavZ3jDFEjRhNgb 9ttnyP1+4NSnsLwujTP0uOSfGpyoppBNKQobMxEJG4ZHrqL3Kdp/aRdx1jWYdLW5BH jYMd9XVi9Q6Ug== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4h2RQF6tBzz6v1n; Sat, 18 Jul 2026 14:47:49 +0200 (CEST) From: Markus Probst Date: Sat, 18 Jul 2026 12:47:50 +0000 Subject: [PATCH v2 4/4] rust: serdev: remove `serdev::Timeout` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260718-rust_serdev_fixes-v2-4-e5214e03de13@posteo.de> References: <20260718-rust_serdev_fixes-v2-0-e5214e03de13@posteo.de> In-Reply-To: <20260718-rust_serdev_fixes-v2-0-e5214e03de13@posteo.de> To: Greg Kroah-Hartman , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: linux-serial@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=4550; i=markus.probst@posteo.de; h=from:subject:message-id; bh=5Upn3XgzNHsfFjssw0UXmxtjmmJmk1QhUiVZAnpqPnM=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqW3XxQaZWKBfIoPHQ0xqtJOQJf30Vd4j874k+F LRFG6vOUDOJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCalt18RsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9J+uw//ftD82kdrBl1jStYpm5bqkSD84Zk/8xM 7z1pO5oHR2ERlVVhhkfTQE7Mpvn6AjzQu0Q6VKfR9/VOtuPjK1xbg9m10BzXaqm7Anpb8gSykhJ cqPgOMXOHGoVLlOyyeSP420hi7VfBzVhZsyXE+RxGymux2BOC4lPXQOR9jogsWpX3bNPUtkIEh2 1b22sLFocBq0I2ubylbxSPgVOGyrHtIo9GL68x0esFucFkNsfKdDLcC3bBSb1vQmok6ZiiUH/rJ ONDEgFFfMyMwM+zsHCxQw3YOsPkLml5Elo2qkxTeW5tIuiegD1S/5TDrVqEd24jKQWizXvOb+X2 A22tKu2eWSEyg/fsNftv7lNINH+qskGNRFjWNSFyINPf2q/xTTrDrRA0dMwFN9tqC5Yy2ZqPCf+ tDZa84VgMClyoB6NiwMhwX1/Q2fmMqAuSKgPx5QOft8/AoGTXALM88Yd2rMWmXNFalzgYy+Mf9D TVq6tIqSj8B7t4PgNZyPn4yDsTrlbIDO8iRHJ84nZU3MEZIn5Ovf8Vhep4vPrtknBIe03AsKCOy kuekn9KO+Qg1kZPuoLjOWXfLeKlQeWYwCOmQcU9Avs4w29v2cXclreNzuY/c5C3rSopnygG7U3v Js/wE4mQpvc9TU4q4hHxJxawIPqwvrUxd33z80/2j7T5lAm0XcK8= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Instead of relying on its own timeout types, the abstraction should make use of `impl Into`. Suggested-by: Gary Guo Link: https://lore.kernel.org/rust-for-linux/DK0SX3P5K1J6.1OV4ETJMXW83R@gar= yguo.net/ Signed-off-by: Markus Probst --- rust/kernel/serdev.rs | 55 +++++++++++++++++------------------------------= ---- 1 file changed, 18 insertions(+), 37 deletions(-) diff --git a/rust/kernel/serdev.rs b/rust/kernel/serdev.rs index a78dfa6e2c27..0fdb37cff15d 100644 --- a/rust/kernel/serdev.rs +++ b/rust/kernel/serdev.rs @@ -20,11 +20,7 @@ aref::AlwaysRefCounted, Mutex, // }, - time::{ - msecs_to_jiffies, - Jiffies, - Msecs, // - }, + time::Jiffies, types::{ Opaque, ScopeGuard, // @@ -35,7 +31,6 @@ cell::UnsafeCell, marker::PhantomData, mem::{offset_of, MaybeUninit}, - num::NonZero, ptr::NonNull, // }; =20 @@ -50,30 +45,6 @@ pub enum Parity { Odd =3D bindings::serdev_parity_SERDEV_PARITY_ODD, } =20 -/// Timeout in Jiffies. -pub enum Timeout { - /// Wait for a specific amount of [`Jiffies`]. - Jiffies(NonZero), - /// Wait for a specific amount of [`Msecs`]. - Milliseconds(NonZero), - /// Wait as long as possible. - /// - /// This is equivalent to [`kernel::task::MAX_SCHEDULE_TIMEOUT`]. - Max, -} - -impl Timeout { - fn into_jiffies(self) -> isize { - match self { - Self::Jiffies(value) =3D> value.get().try_into().unwrap_or_def= ault(), - Self::Milliseconds(value) =3D> { - msecs_to_jiffies(value.get()).try_into().unwrap_or_default= () - } - Self::Max =3D> 0, - } - } -} - /// An adapter for the registration of serial device bus device drivers. pub struct Adapter(T); =20 @@ -379,7 +350,7 @@ macro_rules! module_serdev_device_driver { /// _id_info: Option<&'bound Self::IdInfo>, /// ) -> impl PinInit, Error> + 'bound { /// sdev.set_baudrate(115200); -/// sdev.write_all(b"Hello\n", serdev::Timeout::Max)?; +/// sdev.write_all(b"Hello\n", 0usize)?; /// Ok(MyDriver) /// } /// } @@ -505,11 +476,13 @@ pub fn set_parity(&self, parity: Parity) -> Result { /// [`Device::wait_until_sent`] to make sure the controller write buff= er has actually been /// emptied. /// + /// Use a timeout of 0 to wait indefinitely. + /// /// Returns the number of bytes written (less than `data.len()` if int= errupted). /// [`kernel::error::code::ETIMEDOUT`] or [`kernel::error::code::EREST= ARTSYS`] if interrupted - /// before any bytes were written. + /// before any bytes were written. [`kernel::error::code::EINVAL`] if = `data.len() > i32::MAX`. #[inline] - pub fn write_all(&self, data: &[u8], timeout: Timeout) -> Result { + pub fn write_all(&self, data: &[u8], timeout: impl Into) -> R= esult { if data.len() > i32::MAX as usize { return Err(EINVAL); } @@ -523,7 +496,7 @@ pub fn write_all(&self, data: &[u8], timeout: Timeout) = -> Result { self.as_raw(), data.as_ptr(), data.len(), - timeout.into_jiffies(), + isize::try_from(timeout.into()).unwrap_or_default(), ) }; // CAST: negative return values are guaranteed to be between `-MAX= _ERRNO` and `-1`, @@ -570,11 +543,19 @@ pub fn write_flush(&self) { =20 /// Wait for the data to be sent. /// - /// After this function, the write buffer of the controller should be = empty. + /// After this function, the write buffer of the controller should be = empty or the timeout + /// elapsed. + /// + /// Use a timeout of 0 to wait indefinitely. #[inline] - pub fn wait_until_sent(&self, timeout: Timeout) { + pub fn wait_until_sent(&self, timeout: impl Into) { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. - unsafe { bindings::serdev_device_wait_until_sent(self.as_raw(), ti= meout.into_jiffies()) }; + unsafe { + bindings::serdev_device_wait_until_sent( + self.as_raw(), + isize::try_from(timeout.into()).unwrap_or_default(), + ) + }; } } =20 --=20 2.54.0