From nobody Sat Jul 25 04:30:17 2026 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CBE42DB794 for ; Sat, 18 Jul 2026 11:37:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784374624; cv=none; b=sCrLWzh0nEPYSFU4zBvE0X4gPDLyr3ZTzWkqju4XyoJNyl383Z757bNyf4Q3Gv5ZuWVW7WF0rNWnC91dfUGSW0PONZiDrwc3R3VeiDdcCxFplNIefGn4FGEBVR0OiqvW4lBKv4nH/THWnP7gL5pGL3yUVVWx14UDMo31YlL4/BM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784374624; c=relaxed/simple; bh=+DglkG3f/oa2ZGnDkZHurCMH7odPQbvwJv1U9ofUel4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rM4rgeReD9MklHZcJ4oXl8FkO6fQ3+o/dqgQ3A3WqbLpQCxi/lWcYwcZ7Yd9yFWH68zW/bqDV5aa3UYjyX18cUy0FoN0Nz9H0bg9Aj8q38U3iPHe2SAoLrBW5PS/E363jRbO84qLR9wrdBpMJCcf18JDsaVGJo6CTI2pYRIryms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=gwpnHcj5; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="gwpnHcj5" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1626D240107 for ; Sat, 18 Jul 2026 13:36:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1784374615; bh=fjzyqMHqJCpWgCPY606AraCobo3dyLkKwD8V5CQfQK8=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=gwpnHcj5dzVad7vVmTQ11WaoOE/Vph/KY6rPYpu0KqUA+IOl5JWgH/SyuC5msNTwK 4jBLL36sE1/DMJCXvqYE8l1Kno32yMfwp3T65BcXJ20SQKITstlHqOwDGk+nog88g9 BXwUlBo+kxa1E+XbDjExthbVjrFeiCV9d0vbHzUkIIlUfwDvUW7W1lQd7QTzVIMtKM zaYNFXDEiGjqVy7waao6+46xuLVO4pKncWuF7Ew9gIh73fjXZP3AfU2OB464xBG+9R jD5EDKV6FsIFnNsRefJUepLM6VrIbLnbDk3V0I8VMVwj0o+oPm2BYvHbBiCQoQuOLi 5/f6LLzugfZ7w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4h2PrP0k9Zz6trs; Sat, 18 Jul 2026 13:36:53 +0200 (CEST) From: Markus Probst Date: Sat, 18 Jul 2026 11:36:54 +0000 Subject: [PATCH 1/4] rust: serdev: fix typo in rustdoc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260718-rust_serdev_fixes-v1-1-35433b6dce0f@posteo.de> References: <20260718-rust_serdev_fixes-v1-0-35433b6dce0f@posteo.de> In-Reply-To: <20260718-rust_serdev_fixes-v1-0-35433b6dce0f@posteo.de> To: Greg Kroah-Hartman , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: linux-serial@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Probst , kernel test robot X-Developer-Signature: v=1; a=openpgp-sha256; l=1009; i=markus.probst@posteo.de; h=from:subject:message-id; bh=+DglkG3f/oa2ZGnDkZHurCMH7odPQbvwJv1U9ofUel4=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqW2VSe3dyGRRm1G/GC11B7+waY7FkEhRgC3O71 1J+DzMpy6KJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaltlUhsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9ImNRAAlwCoVErM9k8YNtCB/y0QNzoxvUvOC69 fFAlMA/tCLcV6nuo+lLQMslO8mXrnGGzgtoyYA92WQVqktEJFYAPTDFXBXk8CPvYyUGSAAWZInY wv4PtkchBinPlmyv/yaop89H8Y0OF7OrZvKM0aMRRJ3aIiZdHzfCRLPGS8HRrRqabRL+uDV8Omh nQGdqsZZFdtaPqp7CVlDXdIZifHrKdtY6rBR/Y5VGmo1BwU0cfSeEKYTTtM/pWvz+WpoBLVyAgR fNEP5TnwiL1+yvrO4iA4igT2ZV2+jhRn7Q9FH/JLrFfqOP2xo/8D6pTZZPEjVLicg/ew0JD6mAv RBepZ9o0XFkJYxfAHuuP10RQzjWkEmuVqwWiq9sobEJqN902VjahK8pGnwmw6C5bWX169PU3kn2 EpDzdpcp6og9MauPRYF04p0CiSudkgeMQ0PWA5EnGW0k/3QwyZFeUrJVwgUeoIWq/uzdC3SzH+U K1edOXr8sKubS3PcopEmP9HWOjRgdlnpo46ocEXnOaq1r9248hHZHOcwBx7duP3B7zjGg4cV2HF b7S1Fem91gj092Jf2CjAmqKmAS/dxCtxhg++/nCS7uKodkcO5mndlkUTh+woRC4KRusY5oK53FK UmfsPAI+GfxtBv2W/v7MFVlVKrxM1F0qO+zj6x6XlgFt2Bza+8Gk= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Fix trivial typo Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202607172113.hLDQgD4l-lkp@int= el.com/ Signed-off-by: Markus Probst --- rust/kernel/serdev.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/serdev.rs b/rust/kernel/serdev.rs index 0ffcef1849d2..47ca57966abf 100644 --- a/rust/kernel/serdev.rs +++ b/rust/kernel/serdev.rs @@ -515,7 +515,7 @@ pub fn write_all(&self, data: &[u8], timeout: Timeout) = -> Result { /// [`Device::write_all`]. /// /// Note that any accepted data has only been buffered by the controll= er. Use - /// [ Device::wait_until_sent`] to make sure the controller write buff= er has actually been + /// [`Device::wait_until_sent`] to make sure the controller write buff= er has actually been /// emptied. /// /// Returns the number of bytes written (less than `data.len()` if not= enough room in the --=20 2.54.0 From nobody Sat Jul 25 04:30:17 2026 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56DA43101B9 for ; Sat, 18 Jul 2026 11:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784374625; cv=none; b=FVzr1pD6enUQOQ7COkRDzoSz/niJwLmor8UCCK5QAKXTiq1H//YVxwMj7h1VYrhjcixvKgQ+4kDm0Kyl1RcBX3mWxIbIi5rbeFrISx7ZvsEgxhjxSER+mMobuE0kwa2LMkIlgn8nICp09nkUhdoBht26jY+fBefa7lGcnYFbPb0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784374625; c=relaxed/simple; bh=ejBjjZoyNnpyxaqkTKNHNkHtdFFEL9SeyoIKLMqQlYA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sYrm26jjEkXdsdBO78sOUqz205W6HpeYlbSSoGzF2M1pssRkZAsAgSEdOUjyJf8ETGMeY7iUftE2vW1gwb/LPSWOho8jU82svWGypIx8poL0Obq9vUC3ficRJvk1OShZMi8oJUg8WLUgZ2TGT81bczM8Nam/mAW2LzEC6kdFIEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=CUb3qN9k; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="CUb3qN9k" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 6244824002B for ; Sat, 18 Jul 2026 13:36:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1784374616; bh=ulyF8m79sw5U2CfdPGNsD4XEEokVxvg7p9l8hRTjR9k=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=CUb3qN9kk4SxYqj8Io13wDXQTEPmg0ipIoN120QiwRp/6edupLT5pZ5vjDWaIz8+v 62xd9OvGf6Y/GpvUPQG4H2HuraU53CuxrvmkNOfsHJU4WZIY56o58FNpyD2ij1mK8S Em4NdNFUMLKsw1QPcYMeQmgmzW9odGaicVmOxqIggvTXf8l8vW74W6RIkndX+g9beo YujR9ioX4eK5v7KdTm8FaLqkbwKEudKIVnTYuf5kT9RV+XLcpud19PUzreDLlgexGf eIvVcyABU+6JjxYfDrFbSqwviwYn8ZxuljNE+zLRTIX2Io4pR30VHJ6clUl2Jidpsc FUi67kb941Maw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4h2PrQ2MKcz6tx8; Sat, 18 Jul 2026 13:36:54 +0200 (CEST) From: Markus Probst Date: Sat, 18 Jul 2026 11:36:55 +0000 Subject: [PATCH 2/4] rust: serdev: mark small functions as `#[inline]` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260718-rust_serdev_fixes-v1-2-35433b6dce0f@posteo.de> References: <20260718-rust_serdev_fixes-v1-0-35433b6dce0f@posteo.de> In-Reply-To: <20260718-rust_serdev_fixes-v1-0-35433b6dce0f@posteo.de> To: Greg Kroah-Hartman , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: linux-serial@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=3954; i=markus.probst@posteo.de; h=from:subject:message-id; bh=ejBjjZoyNnpyxaqkTKNHNkHtdFFEL9SeyoIKLMqQlYA=; b=kA0DAAgBNHYf+OetQ9IByyZiAGpbZVKgTltNEyNJkZWgJniJc8XSu0AuaPcj4GNXyRvFxPUGQ YkCTwQAAQgAORYhBIJ0GMT0rFjncjDEczR2H/jnrUPSBQJqW2VSGxSAAAAAAAQADm1hbnUyLDIu NSsxLjEyLDIsMgAKCRA0dh/4561D0tCTEACicEF95ADLKEzGUlOk+fnClGB8XAQBBt4ex6+zpl+ G11tuwvqM+t5ab1wddzOGgpbTX21bs4gXLMKwe8gtqfM9giG4lcx8hg/+eNFwuNae9rfQ3NxXbn eoCwUM7eaC9LJYgwzsdHhoahyIvKYJEpGWf3Rz5df63o8zJfKquMz2sDf8NO29xswQVztyd32Vl 6TKmYbdFaMQn+VnJaLLQnSIbT37n4kx50Hf3dNsummS7mqHr1Y39MhKlPNecEbUfM7pgpRO2+J1 kKLT98owurR9U5TSHHTJqkUxQjF7U9paZTdrmiGNh7kPRDQ276CkKf5zdyQdqm78Rqi+4Hmd/KC pkp1KsER3OtNr5OyQmC5kTCH+MFZ4ZGGYgzoVbkNCTHNpd9FQnTuvYnuIQ0pA1y6pGP3hV1E8XJ 6l7HDWewoyqNSlU5tWg398mAQvrCWjgeSB8PgoFhr7T+O+61LYHo96frqeUw6R98GfhtJpyvwpG o54N/907bMcsFhSP/X9Ndvdl8mvdOjLZ+Z7q2LiIpcgokxbiZgIuVUuWKJ0m5XPXEzQVM0P4WcN A+6OjHI5ZS8fTL4l7tsRE/PJ7iM/Kwc5YAEpkElGjJuGBmjCy81m3g6CNmMxppm/FJJnE+qqcsW MTx2tGKqR36SdpRQmbArkeX6r7/l2Qi+LwjSZ+8w6NA== X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt These methods should be inlined for optimization reasons. Suggested-by: Gary Guo Link: https://lore.kernel.org/rust-for-linux/DK0SX3P5K1J6.1OV4ETJMXW83R@gar= yguo.net/ Signed-off-by: Markus Probst --- rust/kernel/serdev.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/rust/kernel/serdev.rs b/rust/kernel/serdev.rs index 47ca57966abf..79d61c6ceeec 100644 --- a/rust/kernel/serdev.rs +++ b/rust/kernel/serdev.rs @@ -440,6 +440,7 @@ pub struct Device( ); =20 impl Device { + #[inline] fn as_raw(&self) -> *mut bindings::serdev_device { self.0.get() } @@ -451,6 +452,7 @@ impl Device { /// Common baudrates are 115200, 9600, 19200, 57600, 4800. /// /// Use [`Device::write_flush`] before calling this if you have writte= n data prior to this call. + #[inline] pub fn set_baudrate(&self, speed: u32) -> Result<(), u32> { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. let ret =3D unsafe { bindings::serdev_device_set_baudrate(self.as_= raw(), speed) }; @@ -464,6 +466,7 @@ pub fn set_baudrate(&self, speed: u32) -> Result<(), u3= 2> { /// Set if flow control should be enabled. /// /// Use [`Device::write_flush`] before calling this if you have writte= n data prior to this call. + #[inline] pub fn set_flow_control(&self, enable: bool) { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. unsafe { bindings::serdev_device_set_flow_control(self.as_raw(), e= nable) }; @@ -472,6 +475,7 @@ pub fn set_flow_control(&self, enable: bool) { /// Set parity to use. /// /// Use [`Device::write_flush`] before calling this if you have writte= n data prior to this call. + #[inline] pub fn set_parity(&self, parity: Parity) -> Result { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. to_result(unsafe { bindings::serdev_device_set_parity(self.as_raw(= ), parity as u32) }) @@ -487,6 +491,7 @@ pub fn set_parity(&self, parity: Parity) -> Result { /// Returns the number of bytes written (less than `data.len()` if int= errupted). /// [`kernel::error::code::ETIMEDOUT`] or [`kernel::error::code::EREST= ARTSYS`] if interrupted /// before any bytes were written. + #[inline] pub fn write_all(&self, data: &[u8], timeout: Timeout) -> Result { if data.len() > i32::MAX as usize { return Err(EINVAL); @@ -520,6 +525,7 @@ pub fn write_all(&self, data: &[u8], timeout: Timeout) = -> Result { /// /// Returns the number of bytes written (less than `data.len()` if not= enough room in the /// write buffer). + #[inline] pub fn write(&self, data: &[u8]) -> Result { if data.len() > i32::MAX as usize { return Err(EINVAL); @@ -539,6 +545,7 @@ pub fn write(&self, data: &[u8]) -> Result { /// /// Note that this doesn't guarantee that the data has been transmitte= d. /// Use [`Device::wait_until_sent`] for this purpose. + #[inline] pub fn write_flush(&self) { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. unsafe { bindings::serdev_device_write_flush(self.as_raw()) }; @@ -547,6 +554,7 @@ pub fn write_flush(&self) { /// Wait for the data to be sent. /// /// After this function, the write buffer of the controller should be = empty. + #[inline] pub fn wait_until_sent(&self, timeout: Timeout) { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. unsafe { bindings::serdev_device_wait_until_sent(self.as_raw(), ti= meout.into_jiffies()) }; --=20 2.54.0 From nobody Sat Jul 25 04:30:17 2026 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D34130DD2A for ; Sat, 18 Jul 2026 11:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784374627; cv=none; b=JWQ+UUIy6RHSJex9WAYnHprbFSh+vhLYLxF7zt5Q+iLLjhrk870L7HMT4BqISE24Zy3vtMx1dMHsu1zA9FmRJ288pX13CDWJOSbAZohmDruMtwpFG1fERUiKGaiOjbRwACm/rP9CbCCwr6HdOYexzrVZmyjpVvOSB4SKFNId5bg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784374627; c=relaxed/simple; bh=LWG/xU/gWy5BpMDMua+aJnjyVbTyKX+yHFE5GjyVz2o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E8v+Z4ng2XMVhgka3md5Mjiw8QtQ6FLAxV+/0J93plPwiMV+AnMuqy8EzE2UYuufLuVMMj/eRddp17YWNmzllZYU2NavUhHVfl/ndmdWqAVJKIb/wuxX9+oDNT6ef8DlRdfK9wFDDQEqaPbvi8GC/A9+XTo+w+McaY/cyDBTARg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=J++lZzoX; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="J++lZzoX" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 45E47240027 for ; Sat, 18 Jul 2026 13:36:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1784374617; bh=oAAcYcyS9CI0mS14njYT6nch2/6Ab6PkYsuhk40Vh+8=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=J++lZzoXcdYd1xoqslB/N/sg+5kAd+1RKRyi5FCnBjlS1NlA7TYaXH4BgcEK4Y4MI V7/kX6SuOnwMpLLX5N8h6cRL+KJ/Q8Dt+fxe5aqqHG3I1YKHfzyI5wBJEQg3i/uW4J 6fSJfr69tl3sBxPAZSSYnpFmzvL8QcfEwiqDmtfFV/Hqy8AnxY9vrDzL4TbLttB178 JX58rvvSfvzXa6wTDDrzFR80X/vkcZecTivNk5PLvDvTR2ZzhswkCFuGWr3e2mMMu7 lCj4ZVaNQIB+kmEabpiKBYOck9UCfRu/sVXuRM5EG5z1cmKad7ZqcRRwH5vQzZZMVr vP875/gfomWRg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4h2PrR4PgSz6tyL; Sat, 18 Jul 2026 13:36:55 +0200 (CEST) From: Markus Probst Date: Sat, 18 Jul 2026 11:36:56 +0000 Subject: [PATCH 3/4] rust: serdev: document `PrivateData::active` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260718-rust_serdev_fixes-v1-3-35433b6dce0f@posteo.de> References: <20260718-rust_serdev_fixes-v1-0-35433b6dce0f@posteo.de> In-Reply-To: <20260718-rust_serdev_fixes-v1-0-35433b6dce0f@posteo.de> To: Greg Kroah-Hartman , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: linux-serial@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=1839; i=markus.probst@posteo.de; h=from:subject:message-id; bh=LWG/xU/gWy5BpMDMua+aJnjyVbTyKX+yHFE5GjyVz2o=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqW2VSSaVBiF2HjuWrPdyrxT4hn145+0u+emlyX 4rgUnq6BniJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaltlUhsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9KCmRAAmUi6UbLmbUpCBbZyNJtOYoKQT32hCVQ qrBUrxTiLJzpUmgZtUOYEIo2KDnuHJWdoYwKZMAHqiGrEQW8s0JFCMI2KObn+E4S0/kvqq83ziY b9niuvWPJrcd6/IaBihPX6amNXLI2tqllW/40+DLxc0qq0QC0vrvmu9dhfTWUuOIzwltiEaYjA0 HLtzPqiQ4nh7EQaSnRux0rNgyIiviPAJwJmMHaojxEZtTxsJt7NmXv0njqlm6ldzaoYBOC8l5Mj VRw+ZDsTNE5iv6jR7n7X5Okhpo0PWJLU/Osot4Ajp9/+H2qeiQ+bjn50FotU3nY0waaqL4qdJuS 2eLQpBLvw0nWwo7GyoOnsPKTBqUmQqnOGzRsi6osS36YN0Vbq6vPhFnxa1OET90EpWyZgZsj4l9 O+eg5dVO6DJVfL1OrLZg2T9ytb5y99lFFFE0ZEvziO3Qj4qX73DPpDiuxHBCuhvt75hLFPirj/Z b1N36fzUXrDSqxl30+ovvaiJQoBD7WLqwnXZoO4XIYRfUheGHiD4YrRFBXoWXAQ8pkXoYrg5fH8 EyAOKAMnb/15FeQNYg4dqfdjncQtkCtnx09IV5lDvvu1AnoJJEwJKE0FCFbXa06urR0G/3wZ/fh mqnCt4IujWxGWjN17kbbYRIQOXVKkduN6AmNnCVBhODfpmG4g3Kw= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Gary pointed out that it isn't clear for what the mutex is used for, thus adding documentation comments for it. Suggested-by: Gary Guo Link: https://lore.kernel.org/rust-for-linux/DK0SX3P5K1J6.1OV4ETJMXW83R@gar= yguo.net/ Signed-off-by: Markus Probst --- rust/kernel/serdev.rs | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/rust/kernel/serdev.rs b/rust/kernel/serdev.rs index 79d61c6ceeec..3556fe066ace 100644 --- a/rust/kernel/serdev.rs +++ b/rust/kernel/serdev.rs @@ -132,6 +132,23 @@ pub struct PrivateData<'bound, T: Driver> { #[pin] driver: UnsafeCell>>, open: UnsafeCell, + /// Whether `receive_buf_callback` is allowed to call `Driver::receive= _buf`. + /// + /// If locked, the receive_buf_callback will be blocked on data receiv= al. + /// This is the case while the driver is being probed or while [`Priva= teData`] is being dropped. + /// This is necessary, because we need to open the serdev device befor= e the driver has been + /// probed in order to allow it to be configured, which allows [`Adapt= er::receive_buf_callback`] + /// to be called. Thus we need to block data until probe completes and= the driver data becomes + /// initialized. + /// + /// If unlocked and true, the receive_buf_callback will forward the da= ta to + /// `Driver::receive_buf`. This is the normal state of operation. + /// + /// If unlocked and false, the receive_buf_callback will throw away th= e data. + /// This is only the case, if the serdev device is open and + /// - the driver returned an error in probe + /// or + /// - the driver data already has been dropped, because it was unbound. #[pin] active: Mutex, } --=20 2.54.0 From nobody Sat Jul 25 04:30:17 2026 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5094137F738 for ; Sat, 18 Jul 2026 11:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784374628; cv=none; b=n8J2Q2CMVp5VDq44/HFNtQAPZhP+zi0o5SIqisHNSqe7m3a/iohXFrOFGSw2YrlAA9EuK/F9GAdcbzNCkp4omZsD+liJbSTLOvgmtxhcydtAFvEgRgPb97oF/uSSIfcPj16Bke29BRsf6/y7FeetBto8bQjrxTYpp5Yla4FarDM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784374628; c=relaxed/simple; bh=2ZXIDhydxHE3hjjC+Dk2NlLKxxOMYlGJSD1mb4foypo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pHAK6eGYs8aUG+MCwZpgHAW5+RelAGaJHYbLewjdNS3SZPN7nHlmCwfyB2l7mpgk5tAhEBCABNjpdscFW31ISYq4E1FYT0IA8YNpvuDlsHA6nYzY22ppfJGMQf9nAQaATqqTKJ4SsDR2SX2jcyCAT++GhWa1BgoCGqEwV1NDWN0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=EjzFL5cl; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="EjzFL5cl" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id AF698240105 for ; Sat, 18 Jul 2026 13:36:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1784374618; bh=ZIUBu8uI+zJm1ySbHaJhGOWmQk0bf6gYEzutcS04Blw=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=EjzFL5clm2lTXOjxen5+KsckB9AE7ldF92gfLQ/y5TqlvQAIo/O2gbqvvSfhhUBMH mAN0kLiv9i0rMlvX7HqbHD5vV1hTupQ1D5Khy/sub3wBSuX3eKKEzvkj6vl5Rna+MB MAbkGEPcFCiSkqElbMDqIvCYMnlQDqjJvARj5blH9Std7Ivx1cgdiNkMxuSqb18tw0 7DGWcI0sow4kBRH5a6KhuJfFiAHWCNF7V3K5Ud3ardu9Pqg1Q3yPnMIITZygGa6YLv Tpx+NMG9IeNz+aW59915MsVdFuEiKWkJa+RCVTdcYFfMbTuN6nIVMbmi39q+P4LvWv qCXbqbcRX2LXg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4h2PrS5np1z6v01; Sat, 18 Jul 2026 13:36:56 +0200 (CEST) From: Markus Probst Date: Sat, 18 Jul 2026 11:36:57 +0000 Subject: [PATCH 4/4] rust: serdev: remove `serdev::Timeout` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260718-rust_serdev_fixes-v1-4-35433b6dce0f@posteo.de> References: <20260718-rust_serdev_fixes-v1-0-35433b6dce0f@posteo.de> In-Reply-To: <20260718-rust_serdev_fixes-v1-0-35433b6dce0f@posteo.de> To: Greg Kroah-Hartman , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: linux-serial@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=4162; i=markus.probst@posteo.de; h=from:subject:message-id; bh=2ZXIDhydxHE3hjjC+Dk2NlLKxxOMYlGJSD1mb4foypo=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqW2VSEwE7npIDahu3IjzuuI/4aIdvFy8qNcXjs mpGErXuEPSJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaltlUhsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9ItrRAApjNk5C6FItidxuMHOYgVB5CQfv3bbX6 TLXvrQpsm6Lt1WG/7eAhJnlOtQFj+Ygkrk7iFuV5gMQsjBMqVu0JY+tusKA0VuiFdWez4aw/KAQ 8sBPJmXL68cRVM4ZAEiN/vBE9Up7BemsJly66IA95ugi32fnNtv6roFYLV64Jn4+HOZ3nJFZvi0 rv/RwPIKiCzjsFfFE/6rhKK74TNmfVvrdEoFVvNGx6trEbB/zyRgPmNZfv7log11Dn3YayIPzeq muIIB+762bnkLFXLAhS/L5qHzOxEvfwmEl6SkNlwXb4XJqGNdaPfjnVqeRrer8qq0lFIpixTpU0 EXAEbfruc1Vf8lVXit/BdK9D9tnnYiknG1dZV9+5KeKSZiXE6wRbpeHhARWY4FQYgXA9iHZEbN5 5hxYLMp4JGeSUhgUkiLzgY6sS5PJsxmfxCF1F0aU2772fPEoOhtfRthEanlMhZbMtbSiK6O059E 8cqDoaqMtr40oGCWHVYPZDPWjWtYxJmt7d6QXM60U54Ynrhx4jaQN5JsonNWJxR7RCvbR44gYa4 4yfvVP0WqURZFQysLomXgYLtOpL4L0dBkI3vNHBwskhfj/6M0WcxBAq82RCzRHOQD8Xb+1E8DmT dTQBNA4zGu7YfTETPu+ZAsddJEuOPUCufo0efHr9keQeyvMWTNQU= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Instead of relying on its own timeout types, the abstraction should make use of `impl Into`. Suggested-by: Gary Guo Link: https://lore.kernel.org/rust-for-linux/DK0SX3P5K1J6.1OV4ETJMXW83R@gar= yguo.net/ Signed-off-by: Markus Probst --- rust/kernel/serdev.rs | 53 +++++++++++++++++------------------------------= ---- 1 file changed, 17 insertions(+), 36 deletions(-) diff --git a/rust/kernel/serdev.rs b/rust/kernel/serdev.rs index 3556fe066ace..b35f20f24bcd 100644 --- a/rust/kernel/serdev.rs +++ b/rust/kernel/serdev.rs @@ -20,11 +20,7 @@ aref::AlwaysRefCounted, Mutex, // }, - time::{ - msecs_to_jiffies, - Jiffies, - Msecs, // - }, + time::Jiffies, types::{ Opaque, ScopeGuard, // @@ -35,7 +31,6 @@ cell::UnsafeCell, marker::PhantomData, mem::{offset_of, MaybeUninit}, - num::NonZero, ptr::NonNull, // }; =20 @@ -50,30 +45,6 @@ pub enum Parity { Odd =3D bindings::serdev_parity_SERDEV_PARITY_ODD, } =20 -/// Timeout in Jiffies. -pub enum Timeout { - /// Wait for a specific amount of [`Jiffies`]. - Jiffies(NonZero), - /// Wait for a specific amount of [`Msecs`]. - Milliseconds(NonZero), - /// Wait as long as possible. - /// - /// This is equivalent to [`kernel::task::MAX_SCHEDULE_TIMEOUT`]. - Max, -} - -impl Timeout { - fn into_jiffies(self) -> isize { - match self { - Self::Jiffies(value) =3D> value.get().try_into().unwrap_or_def= ault(), - Self::Milliseconds(value) =3D> { - msecs_to_jiffies(value.get()).try_into().unwrap_or_default= () - } - Self::Max =3D> 0, - } - } -} - /// An adapter for the registration of serial device bus device drivers. pub struct Adapter(T); =20 @@ -505,11 +476,13 @@ pub fn set_parity(&self, parity: Parity) -> Result { /// [`Device::wait_until_sent`] to make sure the controller write buff= er has actually been /// emptied. /// + /// Use a timeout of 0 to wait indefinitely. + /// /// Returns the number of bytes written (less than `data.len()` if int= errupted). /// [`kernel::error::code::ETIMEDOUT`] or [`kernel::error::code::EREST= ARTSYS`] if interrupted - /// before any bytes were written. + /// before any bytes were written. [`kernel::error::code::EINVAL`] if = `data.len() > i32::MAX`. #[inline] - pub fn write_all(&self, data: &[u8], timeout: Timeout) -> Result { + pub fn write_all(&self, data: &[u8], timeout: impl Into) -> R= esult { if data.len() > i32::MAX as usize { return Err(EINVAL); } @@ -523,7 +496,7 @@ pub fn write_all(&self, data: &[u8], timeout: Timeout) = -> Result { self.as_raw(), data.as_ptr(), data.len(), - timeout.into_jiffies(), + isize::try_from(timeout.into()).unwrap_or_default(), ) }; // CAST: negative return values are guaranteed to be between `-MAX= _ERRNO` and `-1`, @@ -570,11 +543,19 @@ pub fn write_flush(&self) { =20 /// Wait for the data to be sent. /// - /// After this function, the write buffer of the controller should be = empty. + /// After this function, the write buffer of the controller should be = empty or the timeout + /// elapsed. + /// + /// Use a timeout of 0 to wait indefinitely. #[inline] - pub fn wait_until_sent(&self, timeout: Timeout) { + pub fn wait_until_sent(&self, timeout: impl Into) { // SAFETY: `self.as_raw()` is guaranteed to be a pointer to a vali= d `serdev_device`. - unsafe { bindings::serdev_device_wait_until_sent(self.as_raw(), ti= meout.into_jiffies()) }; + unsafe { + bindings::serdev_device_wait_until_sent( + self.as_raw(), + isize::try_from(timeout.into()).unwrap_or_default(), + ) + }; } } =20 --=20 2.54.0