From nobody Sat Jul 25 04:54:08 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDF783FA5FE for ; Fri, 17 Jul 2026 16:37:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784306262; cv=none; b=eLw5d8u31FY6bIt8iy47lB669j5m3jPTgF9iNWCIesyHW6Xt6Wip9SgHPgJ1i9IlhIN6mnJtw6v+zkiVDt/qzcWW+waIG6jyhwytZb+T/a61fY/Vqj5ftAWVjNYVzrRx1T4OoAhma8PMZ3pXuEcBxDoKYaKcylQbLO0CvBa3vKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784306262; c=relaxed/simple; bh=9BgpLGZDrBypOf+TYKA487jGvAQ/RJEDYcYFJN6ToqM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lZyCtYXNy1UpJIB7Vy6ubn8H+dbrijZc664IT9++8kyg8Z2oqfHuTD95EzkONaV7NXpnEASZWydqFTjTsVm2nBVgy73ql0BnHpgKJmtKsjCALfpzLaTB15yTwTN8Q36EyizdIr+P5kM3HrXna+ttr3x/Wu392B9Z0S65/2TVRgs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8487088510aso8315332b3a.0 for ; Fri, 17 Jul 2026 09:37:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784306260; x=1784911060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VzhVSlDmYmL4yUGAPMw6ROM56XBmkr2uXme8y30m5DQ=; b=T2SIkjLDp/p3mCMfEQn3gVPE0OWQY0vsn/H5XtHIyDAt26P+c5Vo9MlcXyUEPLrQHG 5KkZyrYEkB3t+ZfelFevQPyofiBZJpWKYnJ9Ua4L7NZYRg5IV/VGAUQ9ROdWFah+OeDF B8C4OasWPY09llQ4L88TbJ9PXXRXEiz3yA1NEf6b0XCj6VTeyX0UV8AOqYyzL5u/+ZNW X87WYV5ma/JdVOEEtf6oPPLYAjOPvEcchUTAKOAnuIdjnZwwAB2f7FIcRtFkm5OD7yf/ oJHSBN+AwLgvtUEDvLMP5TJ18DGGke391kK5QQ8ponh/YbQtDcABvbL2hzeJR5Oah6Jh XYAQ== X-Forwarded-Encrypted: i=1; AHgh+Rpi+8+CwH0fu2wwmh9pSTHgLrM7G/td39igKbbMJMJ1oHhy6CmeGrowyl/fBVqLssw86cmzJT1u3ocLx4k=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9fCRrXDZeFo7ji+NNT5ey8zuK/ExjUU5YWcByJ6DQ3eNob0jL cchzp4DnrasruU7UVA5SMCObR5OqWm8ay6bVsc1xwUWjjpAUfuKCUE8= X-Gm-Gg: AfdE7cntnt/LzbbsxUBqUbkKWf0iCaJP30OHazlkxQV1p0SdCIrzgEsaNM6Fvk1FZlq dy8+1H50kLOLrpp5Mxi3Rqi6lG+0zUq854iXLR36vFcQ2Kq903luJPk1V7aTCCvxWM+r+qfQtOy 4YEbG97TfuO1NarERiAb2Vq3dCyD2m6JjqxCusNrOJf5yA7m4XBikR+TiYi4octZKDf77SzO9+S N22gHj45QNH+HbiRtL0kHTyZaVgQUNeteq68F2W1gRaIe+HK0HyINBCUfDGB9sZiFIRsuutSaHf 1duun6F4qU1PXdNCvyR9QoSS8zENuobiHkb6rKTAj+Ze+g/WI7yjwdMT4tcyeBru0VhhQTUQ3QG +SaafjMd9YgLpMTXZzPTyJAt/dlBWldxZB6eixFkjT8vPFWAohNZFhSrs8mHWhKHHQoDD3SGGMT eSXiKh1PYIKYgikXj/vOdvo4csvwUY8RLTlQ4znY+NS3fuIcLVoitcWVDpMBtqhe2ZQbeDtxjA4 gQN+0c2NWllrTc= X-Received: by 2002:a05:6a00:ace:b0:848:4742:90a6 with SMTP id d2e1a72fcca58-84c292cfedbmr3533647b3a.15.1784306259966; Fri, 17 Jul 2026 09:37:39 -0700 (PDT) Received: from penguin.tail0a1999.ts.net (61-228-46-68.dynamic-ip.hinet.net. [61.228.46.68]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2ad8b86dsm1441669b3a.8.2026.07.17.09.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 09:37:39 -0700 (PDT) From: Shih-Yuan Lee To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Shih-Yuan Lee Subject: [PATCH v4 1/2] spi: pxa2xx: disable DMA and fix runtime PM for Apple MacBook8,1 Date: Sat, 18 Jul 2026 00:37:30 +0800 Message-Id: <20260717163731.6782-2-fourdollars@debian.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260717163731.6782-1-fourdollars@debian.org> References: <20260712162420.7453-1-fourdollars@debian.org> <20260717163731.6782-1-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On MacBook8,1 (early 2015 12" MacBook), the LPSS SPI controller at 00:15.4 has two related problems: DMA handshake/interrupt routing fails, and runtime PM autosuspend clock-gates the LPSS block, triggering PCIe Completion Timeouts. Move the force-PIO DMI quirk to spi-pxa2xx-pci.c (the LPSS host controller driver) to avoid layering violations in the client driver. To prevent the PCIe Completion Timeout crash when operating in PIO mode: - Only enable runtime autosuspend in pxa2xx_spi_pci_probe() if enable_dma is true. - If DMA is disabled (either statically via the DMI quirk / module parameter or dynamically due to channel exhaustion), call pm_runtime_get_noresume() in pxa2xx_spi_probe() to hold a runtime PM reference, and release it via pm_runtime_put_noidle() in the remove/error paths. This keeps the PM cou= nt above 0 and permanently locks the device out of autosuspend, preventing userspace tools (like PowerTOP) or udev rules from overriding it. - Implement helper functions pxa2xx_spi_clk_enable() and pxa2xx_spi_clk_dis= able() to track clock state via drv_data->clk_enabled, preventing clock disable count underflows and framework warnings on resume/autosuspend error paths. - Check device status in the shared interrupt handler ssp_int() using pm_runtime_get_if_active() and drv_data->suspended. If the device is suspended, suspending (RPM_SUSPENDING), or clock-disabled, ssp_int() immediately returns IRQ_NONE to avoid reading unclocked MMIO registers. - Initialize drv_data->suspended to true early in probe, and clear it only after the clock is successfully enabled, preventing shared interrupt hand= ler races during device initialization. - In pxa2xx_spi_runtime_suspend() and pxa2xx_spi_suspend(), set drv_data->s= uspended to true and call synchronize_irq() to wait for any active handlers on the shared interrupt line to finish before disabling the clock. - Adjust the driver teardown order in pxa2xx_spi_remove() and probe error p= aths: always call free_irq() to unregister the handler before calling clk_disable_unprepare() to turn off the clock, preventing concurrent interrupts from reading registers while the clock is disabled. Avoid duplicate can-DMA pci_info() logging by checking the pre-computed enable_dma status in probe and passing a verbose flag to can_dma(). Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D108331 Signed-off-by: Shih-Yuan Lee --- drivers/spi/spi-pxa2xx-pci.c | 47 +++++++++++++-- drivers/spi/spi-pxa2xx.c | 107 +++++++++++++++++++++++++++-------- drivers/spi/spi-pxa2xx.h | 3 + 3 files changed, 128 insertions(+), 29 deletions(-) diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c index cae77ac18520..c107b3b53d33 100644 --- a/drivers/spi/spi-pxa2xx-pci.c +++ b/drivers/spi/spi-pxa2xx-pci.c @@ -18,9 +18,14 @@ =20 #include #include +#include =20 #include "spi-pxa2xx.h" =20 +static bool spi_pxa2xx_force_pio; +module_param_named(force_pio, spi_pxa2xx_force_pio, bool, 0444); +MODULE_PARM_DESC(force_pio, "Force PIO mode (disables DMA) for SPI transfe= rs. ([0] =3D disabled, 1 =3D enabled)"); + #define PCI_DEVICE_ID_INTEL_QUARK_X1000 0x0935 #define PCI_DEVICE_ID_INTEL_BYT 0x0f0e #define PCI_DEVICE_ID_INTEL_MRFLD 0x1194 @@ -93,6 +98,34 @@ static void lpss_dma_put_device(void *dma_dev) pci_dev_put(dma_dev); } =20 +static const struct dmi_system_id pxa2xx_spi_pci_dmi_table[] =3D { + { + .ident =3D "Apple MacBook8,1", + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "MacBook8,1"), + }, + }, + { } +}; + +static bool pxa2xx_spi_pci_can_dma(struct pci_dev *dev, bool verbose) +{ + if (spi_pxa2xx_force_pio) { + if (verbose) + pci_info(dev, "Forcing PIO mode (disabling DMA)\n"); + return false; + } + + if (dmi_check_system(pxa2xx_spi_pci_dmi_table)) { + if (verbose) + pci_info(dev, "MacBook8,1 detected: disabling DMA to force PIO mode\n"); + return false; + } + + return true; +} + static int lpss_spi_setup(struct pci_dev *dev, struct pxa2xx_spi_controlle= r *c) { struct ssp_device *ssp =3D &c->ssp; @@ -166,7 +199,7 @@ static int lpss_spi_setup(struct pci_dev *dev, struct p= xa2xx_spi_controller *c) =20 c->dma_filter =3D lpss_dma_filter; c->dma_burst_size =3D 1; - c->enable_dma =3D 1; + c->enable_dma =3D pxa2xx_spi_pci_can_dma(dev, true); return 0; } =20 @@ -238,7 +271,7 @@ static int mrfld_spi_setup(struct pci_dev *dev, struct = pxa2xx_spi_controller *c) =20 c->dma_filter =3D lpss_dma_filter; c->dma_burst_size =3D 8; - c->enable_dma =3D 1; + c->enable_dma =3D pxa2xx_spi_pci_can_dma(dev, true); return 0; } =20 @@ -300,10 +333,12 @@ static int pxa2xx_spi_pci_probe(struct pci_dev *dev, if (ret) return ret; =20 - pm_runtime_set_autosuspend_delay(&dev->dev, 50); - pm_runtime_use_autosuspend(&dev->dev); - pm_runtime_put_autosuspend(&dev->dev); - pm_runtime_allow(&dev->dev); + if (pdata->enable_dma) { + pm_runtime_set_autosuspend_delay(&dev->dev, 50); + pm_runtime_use_autosuspend(&dev->dev); + pm_runtime_put_autosuspend(&dev->dev); + pm_runtime_allow(&dev->dev); + } =20 return 0; } diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 6291d7c2e06f..dcae43a04eac 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -713,20 +713,42 @@ static void handle_bad_msg(struct driver_data *drv_da= ta) dev_err(drv_data->ssp->dev, "bad message state in interrupt handler\n"); } =20 +static int pxa2xx_spi_clk_enable(struct driver_data *drv_data) +{ + int status; + + if (drv_data->clk_enabled) + return 0; + + status =3D clk_prepare_enable(drv_data->ssp->clk); + if (status =3D=3D 0) + drv_data->clk_enabled =3D true; + + return status; +} + +static void pxa2xx_spi_clk_disable(struct driver_data *drv_data) +{ + if (drv_data->clk_enabled) { + clk_disable_unprepare(drv_data->ssp->clk); + drv_data->clk_enabled =3D false; + } +} + static irqreturn_t ssp_int(int irq, void *dev_id) { struct driver_data *drv_data =3D dev_id; u32 sccr1_reg; u32 mask =3D drv_data->mask_sr; u32 status; + int active; + irqreturn_t ret =3D IRQ_NONE; =20 - /* - * The IRQ might be shared with other peripherals so we must first - * check that are we RPM suspended or not. If we are we assume that - * the IRQ was not for us (we shouldn't be RPM suspended when the - * interrupt is enabled). - */ - if (pm_runtime_suspended(drv_data->ssp->dev)) + if (drv_data->suspended) + return IRQ_NONE; + + active =3D pm_runtime_get_if_active(drv_data->ssp->dev); + if (active =3D=3D 0) return IRQ_NONE; =20 /* @@ -737,7 +759,7 @@ static irqreturn_t ssp_int(int irq, void *dev_id) */ status =3D pxa2xx_spi_read(drv_data, SSSR); if (status =3D=3D ~0) - return IRQ_NONE; + goto out_put; =20 sccr1_reg =3D pxa2xx_spi_read(drv_data, SSCR1); =20 @@ -750,7 +772,7 @@ static irqreturn_t ssp_int(int irq, void *dev_id) mask &=3D ~SSSR_TINT; =20 if (!(status & mask)) - return IRQ_NONE; + goto out_put; =20 pxa2xx_spi_write(drv_data, SSCR1, sccr1_reg & ~drv_data->int_cr1); pxa2xx_spi_write(drv_data, SSCR1, sccr1_reg); @@ -758,10 +780,19 @@ static irqreturn_t ssp_int(int irq, void *dev_id) if (!drv_data->controller->cur_msg) { handle_bad_msg(drv_data); /* Never fail */ - return IRQ_HANDLED; + ret =3D IRQ_HANDLED; + goto out_put; + } + + ret =3D drv_data->transfer_handler(drv_data); + +out_put: + if (active > 0) { + pm_runtime_mark_last_busy(drv_data->ssp->dev); + pm_runtime_put_autosuspend(drv_data->ssp->dev); } =20 - return drv_data->transfer_handler(drv_data); + return ret; } =20 /* @@ -1288,6 +1319,7 @@ int pxa2xx_spi_probe(struct device *dev, struct ssp_d= evice *ssp, drv_data->controller =3D controller; drv_data->controller_info =3D platform_info; drv_data->ssp =3D ssp; + drv_data->suspended =3D true; /* Start suspended until clock is enabled */ =20 /* The spi->mode bits understood by this driver: */ controller->mode_bits =3D SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LOOP; @@ -1351,11 +1383,16 @@ int pxa2xx_spi_probe(struct device *dev, struct ssp= _device *ssp, } } =20 + if (!platform_info->enable_dma) + pm_runtime_get_noresume(dev); + /* Enable SOC clock */ - status =3D clk_prepare_enable(ssp->clk); + status =3D pxa2xx_spi_clk_enable(drv_data); if (status) goto out_error_dma_irq_alloc; =20 + drv_data->suspended =3D false; + controller->max_speed_hz =3D clk_get_rate(ssp->clk); /* * Set minimum speed for all other platforms than Intel Quark which is @@ -1449,11 +1486,18 @@ int pxa2xx_spi_probe(struct device *dev, struct ssp= _device *ssp, return status; =20 out_error_clock_enabled: - clk_disable_unprepare(ssp->clk); + free_irq(ssp->irq, drv_data); + pxa2xx_spi_clk_disable(drv_data); + pxa2xx_spi_dma_release(drv_data); + goto out_error_pm_forbid; =20 out_error_dma_irq_alloc: - pxa2xx_spi_dma_release(drv_data); free_irq(ssp->irq, drv_data); + pxa2xx_spi_dma_release(drv_data); + +out_error_pm_forbid: + if (!platform_info->enable_dma) + pm_runtime_put_noidle(dev); =20 return status; } @@ -1466,16 +1510,20 @@ void pxa2xx_spi_remove(struct device *dev) =20 spi_unregister_controller(drv_data->controller); =20 + /* Release IRQ first so handler won't access registers after clock is dis= abled */ + free_irq(ssp->irq, drv_data); + /* Disable the SSP at the peripheral and SOC level */ pxa_ssp_disable(ssp); - clk_disable_unprepare(ssp->clk); + pxa2xx_spi_clk_disable(drv_data); =20 /* Release DMA */ - if (drv_data->controller_info->enable_dma) + if (drv_data->controller_info->enable_dma) { pxa2xx_spi_dma_release(drv_data); - - /* Release IRQ */ - free_irq(ssp->irq, drv_data); + pm_runtime_forbid(dev); + } else { + pm_runtime_put_noidle(dev); + } } EXPORT_SYMBOL_NS_GPL(pxa2xx_spi_remove, "SPI_PXA2xx"); =20 @@ -1489,10 +1537,13 @@ static int pxa2xx_spi_suspend(struct device *dev) if (status) return status; =20 + drv_data->suspended =3D true; + synchronize_irq(ssp->irq); + pxa_ssp_disable(ssp); =20 if (!pm_runtime_suspended(dev)) - clk_disable_unprepare(ssp->clk); + pxa2xx_spi_clk_disable(drv_data); =20 return 0; } @@ -1505,11 +1556,13 @@ static int pxa2xx_spi_resume(struct device *dev) =20 /* Enable the SSP clock */ if (!pm_runtime_suspended(dev)) { - status =3D clk_prepare_enable(ssp->clk); + status =3D pxa2xx_spi_clk_enable(drv_data); if (status) return status; } =20 + drv_data->suspended =3D false; + /* Start the queue running */ return spi_controller_resume(drv_data->controller); } @@ -1518,15 +1571,23 @@ static int pxa2xx_spi_runtime_suspend(struct device= *dev) { struct driver_data *drv_data =3D dev_get_drvdata(dev); =20 - clk_disable_unprepare(drv_data->ssp->clk); + drv_data->suspended =3D true; + synchronize_irq(drv_data->ssp->irq); + pxa2xx_spi_clk_disable(drv_data); return 0; } =20 static int pxa2xx_spi_runtime_resume(struct device *dev) { struct driver_data *drv_data =3D dev_get_drvdata(dev); + int status; =20 - return clk_prepare_enable(drv_data->ssp->clk); + status =3D pxa2xx_spi_clk_enable(drv_data); + if (status) + return status; + + drv_data->suspended =3D false; + return 0; } =20 EXPORT_NS_GPL_DEV_PM_OPS(pxa2xx_spi_pm_ops, SPI_PXA2xx) =3D { diff --git a/drivers/spi/spi-pxa2xx.h b/drivers/spi/spi-pxa2xx.h index 447be0369384..44f37bf9c519 100644 --- a/drivers/spi/spi-pxa2xx.h +++ b/drivers/spi/spi-pxa2xx.h @@ -72,6 +72,9 @@ struct driver_data { =20 void __iomem *lpss_base; =20 + bool suspended; + bool clk_enabled; + /* Optional slave FIFO ready signal */ struct gpio_desc *gpiod_ready; }; --=20 2.39.5 From nobody Sat Jul 25 04:54:08 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EB6D42CAE5 for ; Fri, 17 Jul 2026 16:37:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784306264; cv=none; b=uaTg9QPS+xhPp/TlExbswA0Bwn2E5+MriA5mEcRhVcUTmMVtCqnAoJV6WdsR04MNKy+782/LTaApmk5IX/y1xyg89vL1UpVYe+26Y4m7Y4ZEC890aSMpcCjk/At4rlVv6UIqny7ey2vOTWKBqlH6V6y2Qh5XcvxdMyjRohsmhHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784306264; c=relaxed/simple; bh=4Cplk9Wyfwie8eEhkHpkoxFOURxnvpRi/wnr1nMvh2Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DC6zHeEiRhuXRU6v76ME/DBpUugkDCoGh0EBOcnzmiD4JndAEJXDESr6h4YbzVraNOqcusn6ff+1wbnRP03DAwgBSEcbK9nD9AOhtR7qEQckaG11Esd33PKRmXi2YbsNYDce8tgmWrXUkTCLh5RY+W0QQKUjjGU8WToR2KpvY3c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-848643382fcso9304556b3a.1 for ; Fri, 17 Jul 2026 09:37:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784306262; x=1784911062; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=F9cHWXZxT3AOb0TsNm1pwNj/aI5kZG+WJPp72xJRVno=; b=QUkVRU/sIoK0mqdvI+XgCf+pR1yUBrfPEMXVHKDjmEcj7URIYG4q3FTVNimXCLqsTI WKl7R9EeIm27fSAnsvKCy2nlNRJsJt/wqomUNEkdiOwtoVvTK3nY5J7F9gnPzYTk0iJV wZV8kfOR65WbfFra1ATHCmunP00fRTeyIzVMjmWu1rRzNajE7mJQqE9y2THRUPS1eb0Z S1hwiGfxHNlAMQOG2L0aoXu7OsBLzraUEINumYNkZt53mXYvB+tHOoDRP3fjkCd7T0rt JsffXhH0HvboG4NRGY+ufMhNWKWUnLW9q6u4wGJv+qg11XBBQY/GL/q4eLWNqYbJ3pyk efWA== X-Forwarded-Encrypted: i=1; AHgh+RoZWa3u/Ywzt7OBUzW46zi7hfcCK/NIp5EGXI0O0RHiUm5f05PGXHac5x95nI0xJhP698CmeE0Etr4/bMM=@vger.kernel.org X-Gm-Message-State: AOJu0YwS5WtNeuCpF7/XlnWDlYQxuHmvn4HzKAdO4oG623KUpZ8q7dnJ xL8cXmoZlG3cxeICe/ysH6uvpHcylY0KVqb6ghOH1eJJ0DC6c5kFtek= X-Gm-Gg: AfdE7cnkvqIouCF47rbuomr4w/gEnr4CuDlBzjSIxAFaaxXuTaVF5dgOXvF/IGF3di8 rJV3sXCcZ8i8rkjU2s1929TpLXkh/nStV/Ua4bUIn4VN879mBKGkymVmWfEggbn/Emh64E0LuiB Rlx16QJ6zdx3QH1YKcb1dBeuI+bkdLBv6z/lCn7XEZ6L3yMB9y3epch+2JU63CxPmSQlC7paBBa PNO+AM+YLtTaaE3Y9pnTPes9jUFGdpqOoZMZuk6vuY+nV1/9puQVJZ0qxomL5KW09KmGmJGvpK5 gMaT1BDl++KPgCXFfP4o/PIQUmqCS2G5sSPfW8m3JdXfY7DiQBtNoQgpKE361FoF+GtV0F4JbKb u0/+O7NZOdbYPWi7e2t/r07TbZku7fJqyc0Qw5PHZPhO+djuY9/0SEuYNp8saUSmGuhEh0/sWRZ 5m16FuKn/3SX8sMy3Cye4qVu615NDqLwWcgqczaFmbg6SGX2PbalOHKjKVgzsTysUxb6djDJh89 QtGx+SLxJ34ljs= X-Received: by 2002:a05:6a00:1d9c:b0:848:2f73:9001 with SMTP id d2e1a72fcca58-84c295484c5mr3845739b3a.74.1784306261667; Fri, 17 Jul 2026 09:37:41 -0700 (PDT) Received: from penguin.tail0a1999.ts.net (61-228-46-68.dynamic-ip.hinet.net. [61.228.46.68]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2ad8b86dsm1441669b3a.8.2026.07.17.09.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 09:37:41 -0700 (PDT) From: Shih-Yuan Lee To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Shih-Yuan Lee Subject: [PATCH v4 2/2] spi: pxa2xx: restore LPSS private register state on S3 resume Date: Sat, 18 Jul 2026 00:37:31 +0800 Message-Id: <20260717163731.6782-3-fourdollars@debian.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260717163731.6782-1-fourdollars@debian.org> References: <20260712162420.7453-1-fourdollars@debian.org> <20260717163731.6782-1-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Intel LPSS SPI controllers lose all private register state across S3 suspend because the LPSS power domain is fully removed. On resume the driver only re-enables the SSP clock, leaving the LPSS private registers in their power-on-reset state, which causes two problems: 1. LPSS_PRIV_RESETS (offset 0x04 within the LPSS private space) stays zero, keeping the functional block in reset. Any MMIO access while the block is held in reset causes a PCIe Completion Timeout and a watchdog-triggered system reset. LPSS_PRIV_RESETS_FUNC and LPSS_PRIV_RESETS_IDMA must be de-asserted before any other register access on resume. 2. The LPSS software chip-select control register must not be blindly restored from its suspend-time snapshot: if CS was asserted at the moment of suspend, restoring that state corrupts the first post-resume SPI transaction. Instead, call lpss_ssp_setup() which unconditionally writes SW_MODE | CS_HIGH (idle/deasserted), matching the state established at probe time. To resolve these issues safely: - Wrap S3 suspend/resume with pm_runtime_resume_and_get() and pm_runtime_put_autosuspend() respectively. This ensures that if the device was runtime-suspended, it is temporarily resumed to active state prior to suspend. This guarantees that the clock and power domain are active during MMIO register access, and that the private registers are consistently saved and restored across S3 sleep cycles. - On S3 suspend success path, return 0 directly without dropping the PM reference. This preserves the acquired PM reference across suspend. On S3 resume, release it via pm_runtime_put_autosuspend(), and ensure all error paths in resume (clock enable failure or spi_controller_resume failure) jump to out_put to correctly release the reference, preventing reference count underflow and leaks. - Save only the first 6 LPSS private registers (offsets 0x00 to 0x14) via drv_data->lpss_base during suspend. Offsets beyond 0x14 (except CS control at 0x18, which is re-initialised by lpss_ssp_setup()) are reserved/unimplemented on LPT platforms (such as MacBook8,1), and writing to them triggers a PCIe Completion Timeout causing a system freeze. - Store the saved context in drv_data->lpss_priv_ctx[6] (inside struct driver_data) which is private to the core driver. This avoids changing the layout of struct pxa2xx_spi_controller, preventing ABI symbol version mismatches with uncompiled platform drivers (e.g., spi-pxa2xx-platform.ko). On resume, de-assert resets first, restore all other saved registers, then call lpss_ssp_setup() to re-initialise CS. Signed-off-by: Shih-Yuan Lee --- drivers/spi/spi-pxa2xx.c | 90 +++++++++++++++++++++++++++++++++++----- drivers/spi/spi-pxa2xx.h | 1 + 2 files changed, 81 insertions(+), 10 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index dcae43a04eac..c4b4cb49cfc0 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -72,7 +72,12 @@ struct chip_data { #define LPSS_CAPS_CS_EN_SHIFT 9 #define LPSS_CAPS_CS_EN_MASK (0xf << LPSS_CAPS_CS_EN_SHIFT) =20 -#define LPSS_PRIV_CLOCK_GATE 0x38 +/* Offsets from drv_data->lpss_base */ +#define LPSS_PRIV_RESETS 0x04 +#define LPSS_PRIV_RESETS_IDMA BIT(2) +#define LPSS_PRIV_RESETS_FUNC 0x3 + +#define LPSS_PRIV_CLOCK_GATE 0x38 #define LPSS_PRIV_CLOCK_GATE_CLK_CTL_MASK 0x3 #define LPSS_PRIV_CLOCK_GATE_CLK_CTL_FORCE_ON 0x3 #define LPSS_PRIV_CLOCK_GATE_CLK_CTL_FORCE_OFF 0x0 @@ -1533,19 +1538,43 @@ static int pxa2xx_spi_suspend(struct device *dev) struct ssp_device *ssp =3D drv_data->ssp; int status; =20 + status =3D pm_runtime_resume_and_get(dev); + if (status < 0) + return status; + status =3D spi_controller_suspend(drv_data->controller); if (status) - return status; + goto out_put; =20 + /* Mark as suspended and synchronize IRQ before disabling clock */ drv_data->suspended =3D true; synchronize_irq(ssp->irq); =20 pxa_ssp_disable(ssp); =20 - if (!pm_runtime_suspended(dev)) - pxa2xx_spi_clk_disable(drv_data); + if (is_lpss_ssp(drv_data)) { + unsigned int i; + + /* + * Save the first 6 LPSS private registers (offsets 0x00 to 0x14) + * while the clock is still enabled. They are lost when the LPSS + * power domain is removed across S3 and must be restored on resume. + * Use drv_data->lpss_base so the correct per-platform offset + * is applied regardless of LPSS IP revision. + * Registers beyond 0x14 (except CS control at 0x18) are reserved + * or unimplemented on LPT, and accessing them triggers a PCIe + * Completion Timeout causing a system halt. + */ + for (i =3D 0; i < 6; i++) + drv_data->lpss_priv_ctx[i] =3D readl(drv_data->lpss_base + i * 4); + } =20 + pxa2xx_spi_clk_disable(drv_data); return 0; + +out_put: + pm_runtime_put_noidle(dev); + return status; } =20 static int pxa2xx_spi_resume(struct device *dev) @@ -1555,16 +1584,57 @@ static int pxa2xx_spi_resume(struct device *dev) int status; =20 /* Enable the SSP clock */ - if (!pm_runtime_suspended(dev)) { - status =3D pxa2xx_spi_clk_enable(drv_data); - if (status) - return status; - } + status =3D pxa2xx_spi_clk_enable(drv_data); + if (status) + goto out_put; =20 drv_data->suspended =3D false; =20 + if (is_lpss_ssp(drv_data)) { + unsigned int i; + + /* + * The LPSS power domain is removed across S3, taking + * all private registers with it. De-assert the + * functional block and IDMA resets first; any MMIO + * access while the block is held in reset causes a + * PCIe Completion Timeout and a watchdog-triggered + * system reset. + */ + writel(LPSS_PRIV_RESETS_FUNC | LPSS_PRIV_RESETS_IDMA, + drv_data->lpss_base + LPSS_PRIV_RESETS); + + /* Restore the other 5 saved private registers */ + for (i =3D 0; i < 6; i++) { + if (i =3D=3D LPSS_PRIV_RESETS / 4) + continue; + writel(drv_data->lpss_priv_ctx[i], + drv_data->lpss_base + i * 4); + } + + /* + * Re-initialise the SW chip-select control register so + * CS starts deasserted (SW_MODE | CS_HIGH), regardless + * of the state it was in at suspend time. A stale + * asserted CS on the first post-resume transaction + * corrupts the write-status response from the device. + */ + lpss_ssp_setup(drv_data); + } + /* Start the queue running */ - return spi_controller_resume(drv_data->controller); + status =3D spi_controller_resume(drv_data->controller); + if (status) { + pxa2xx_spi_clk_disable(drv_data); + goto out_put; + } + +out_put: + /* Let runtime PM autosuspend again if needed */ + pm_runtime_mark_last_busy(dev); + pm_runtime_put_autosuspend(dev); + + return status; } =20 static int pxa2xx_spi_runtime_suspend(struct device *dev) diff --git a/drivers/spi/spi-pxa2xx.h b/drivers/spi/spi-pxa2xx.h index 44f37bf9c519..48169494f74e 100644 --- a/drivers/spi/spi-pxa2xx.h +++ b/drivers/spi/spi-pxa2xx.h @@ -71,6 +71,7 @@ struct driver_data { irqreturn_t (*transfer_handler)(struct driver_data *drv_data); =20 void __iomem *lpss_base; + u32 lpss_priv_ctx[6]; =20 bool suspended; bool clk_enabled; --=20 2.39.5