From nobody Sat Jul 25 04:53:34 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C16F3BFAE8 for ; Fri, 17 Jul 2026 16:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784304927; cv=none; b=GB+w320+iNDxzzPdNcLKeZIqUsQQXVtgzDl5N2KlLMKFBbEACO/fe6BKfWnS/Mt4hcd26YTzGBJu556Dw7B/pOUkSZhqr43/Nn9w8WeR9ISHbw9BDiy+EqHHVl3FKX1aQSwU681gfiJF76LRAGsB4yBTZ8BwdFiPksPs6NCtbUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784304927; c=relaxed/simple; bh=b49Jo7cb+aAuOuuHYnLoWVzVL2avSfUoDItQi9/5EZU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kc5xWD8xynEDFncsANq9mduHXGz3Z3CIyiMEqq9sbGAbprWhp2dnZf+ZhKRMIMZFPV3ANYj5HGBlWMr7xZuBiAuDFVkKdMTUBYvvdwFCkyZR8aNUR1eYMwrScdpYQ0gIKaGi5hKKtmjugdcDuSatBaNvMs43C9Q495Vi53Ctnns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lFGGYm6n; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lFGGYm6n" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47ddf7b09e5so4134889f8f.1 for ; Fri, 17 Jul 2026 09:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784304922; x=1784909722; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=c+mCi6CAcCQZ/L5rZxcZEfzKd4dGmx3j4XGejbBm5Pw=; b=lFGGYm6nNvl8P4nkrJqmzWnRt8iyVRRodPOtEJGd9KKgvJHT/AoJEjyzgQN+9bhMMA uCIwsgQqZR4LPvFtfizNFBnQPUg1gJDSB1FMDB2364W0gcBWcQQPqde1Qsxz7zTTHgRT Sc72vDQYJ+ps8oLqsaGghZxlGHQp7wzz/Laovh4cFyb4k8va/7e6qf5bkCDN6mWnFASG JsN24Cj3IHYrKzV5xPsrnN6vkverJ1sax+IwN8B9cxsfxsyqz1zXF+sNQmFs+6/jY76Q Kr7lGcmxAxcWGohAUfTdgKdvGrAHBfeMMMQP3Tj6EX2QnX43dwKPSHmk5KGzriBGgOFM faNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784304922; x=1784909722; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=c+mCi6CAcCQZ/L5rZxcZEfzKd4dGmx3j4XGejbBm5Pw=; b=WpTwqaaZ0n9S10HR1+m27+GS2Pz8L+NkwU8YvTKsbXUVHZz2CzpSIDorBmMa0tGrag qIqHWSDEFdJUv+Ms/ofzST3QVZqzTXuo76IdqEpLkqVP5tKOE+Koj1WIVckJyy65eYqA OF4UUgqwfJA6GI8ScNXPTpvE4X+gaXDqek4wiS2y8T6koLp6X10zhcwRuMXA6UgQf+bM Un9YX8V692ZD4XZz0OkKSiSM0AHnGzU7gigNhesD+pgfW/l4IQCMfd4ytbtLgv1mOt2r RTZk4aohJh7O7VmMLvBAgYaaCcMF7OWDhErbnqD89X5U9tdYkK9Rb2jq35j41trsejt8 Yonw== X-Forwarded-Encrypted: i=1; AHgh+RqHie5XPkFR9SsQGUJf99bY1XJL+hJu70j9Wjs8bz4WY+dGBjuy70Mivx1GkL11npXMYEl0mGP9rc+pd/c=@vger.kernel.org X-Gm-Message-State: AOJu0YwnVm4x81N2pJASDbBVIhzPozySidJB+dmHkHuSpBuIi5BywHWZ 3rJcWt2ZInNbwD8dvTWXv0A3NZfctVgbaBmvJV9F1eli/XxltPUh3dCk X-Gm-Gg: AfdE7cltYk24b86/+lqdhl/kfyVMsSRrVtvx3XbOISe1aPYjW5jp6LtaJVMdyJOmtxT a+YEO3tQz5GBN3iFScBD1gDkzHLsABxS2Vg9rhtkP74S7h/yyy0eTZAsmOb8Wf/hdETbhD6MSj/ Odb8c60WVK0jSjcqJEa/XMEDhrR3UPu2y4pUi1haUAc6oinkVmaLuRBOWGNx3dT8LNnysg8BaPM +r0x5khkO1cGkMhR4ZHaUF4M/2h1JcCIHzANDdjHmT614FGTc9Nqc6Y+lYcpOlD/4ufARShZRiT VaPlAXpKMjN/Dz6WBzqNv9crq7T1Ck2yboEMiFkO81HRcTvXbAAH9RCttEPEdcHVBtqND7Uhji6 80zu023mgqEqzFg/mXXRCSKkJHu51Cg1zZKMQbFYLEbUw7b5k2jr6jQDCSOqOAEeo2WC2ZQAHas BwspBch6aBBZXXmamFJkI1ugY7QnQ2EzNSOTuZ1lslQqzuhVI7gWeRGmdE6U5R81fQozQ= X-Received: by 2002:a05:6000:71e:b0:473:1ccc:15cc with SMTP id ffacd0b85a97d-47f622c57admr4101203f8f.0.1784304922344; Fri, 17 Jul 2026 09:15:22 -0700 (PDT) Received: from koolguy.fritz.box (dslb-088-074-245-227.088.074.pools.vodafone-ip.de. [88.74.245.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f66df025csm3252526f8f.0.2026.07.17.09.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 09:15:21 -0700 (PDT) From: Dalvin-Ehinoma Noah Aiguobas To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dalvin-Ehinoma Noah Aiguobas Subject: [PATCH v2 1/4] staging: rtl8723bs: change struct member bDriverStopped Date: Fri, 17 Jul 2026 16:13:26 +0000 Message-ID: <20260717161329.3400-2-fliegbert2@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260717161329.3400-1-fliegbert2@gmail.com> References: <20260715171634.1550-1-fliegbert2@gmail.com> <20260717161329.3400-1-fliegbert2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Member name does not adhere to linux coding style. Changed type as well since b indicates a boolean type and in every instance of setting the variable the values true and false are used. bDriverStopped -> driver_stopped Signed-off-by: Dalvin-Ehinoma Noah Aiguobas --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 8 +++---- drivers/staging/rtl8723bs/core/rtw_mlme.c | 11 +++++----- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 22 +++++++++---------- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++-- drivers/staging/rtl8723bs/core/rtw_recv.c | 10 ++++----- drivers/staging/rtl8723bs/hal/odm.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 10 ++++----- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 ++--- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 4 ++-- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 8 +++---- drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +- drivers/staging/rtl8723bs/include/drv_types.h | 6 ++--- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 +++---- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++-- 14 files changed, 53 insertions(+), 52 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index d8ad1c75195b..df6b118ee9c9 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -396,10 +396,10 @@ int rtw_cmd_thread(void *context) break; } =20 - if (padapter->bDriverStopped || padapter->bSurpriseRemoved) { + if (padapter->driver_stopped || padapter->bSurpriseRemoved) { netdev_dbg(padapter->pnetdev, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n", - __func__, padapter->bDriverStopped, + __func__, padapter->driver_stopped, padapter->bSurpriseRemoved, __LINE__); break; } @@ -419,10 +419,10 @@ int rtw_cmd_thread(void *context) continue; =20 _next: - if (padapter->bDriverStopped || padapter->bSurpriseRemoved) { + if (padapter->driver_stopped || padapter->bSurpriseRemoved) { netdev_dbg(padapter->pnetdev, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n", - __func__, padapter->bDriverStopped, + __func__, padapter->driver_stopped, padapter->bSurpriseRemoved, __LINE__); break; } diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 7a232daf5c56..11f77b7ca745 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -264,7 +264,7 @@ void rtw_free_network_queue(struct adapter *padapter, u= 8 isfreeall) =20 bool rtw_if_up(struct adapter *padapter) { - if (padapter->bDriverStopped || padapter->bSurpriseRemoved || + if (padapter->driver_stopped || padapter->bSurpriseRemoved || !check_fwstate(&padapter->mlmepriv, _FW_LINKED)) return false; =20 @@ -927,8 +927,9 @@ void rtw_scan_abort(struct adapter *adapter) =20 start =3D jiffies; pmlmeext->scan_abort =3D true; - while (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) && jiffies_to_msecs(sta= rt) <=3D 200) { - if (adapter->bDriverStopped || adapter->bSurpriseRemoved) + while (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) + && jiffies_to_msecs(start) <=3D 200) { + if (adapter->driver_stopped || adapter->bSurpriseRemoved) break; =20 msleep(20); @@ -1499,7 +1500,7 @@ void _rtw_join_timeout_handler(struct timer_list *t) mlmepriv.assoc_timer); struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 - if (adapter->bDriverStopped || adapter->bSurpriseRemoved) + if (adapter->driver_stopped || adapter->bSurpriseRemoved) return; =20 spin_lock_bh(&pmlmepriv->lock); @@ -1601,7 +1602,7 @@ void rtw_dynamic_check_timer_handler(struct adapter *= adapter) if (!adapter->hw_init_completed) return; =20 - if (adapter->bDriverStopped || adapter->bSurpriseRemoved) + if (adapter->driver_stopped || adapter->bSurpriseRemoved) return; =20 if (adapter->net_closed) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index f5ab94a2d0a0..57f0403ff5bf 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -408,7 +408,7 @@ void free_mlme_ext_priv(struct mlme_ext_priv *pmlmeext) if (!padapter) return; =20 - if (padapter->bDriverStopped) { + if (padapter->driver_stopped) { timer_delete_sync(&pmlmeext->survey_timer); timer_delete_sync(&pmlmeext->link_timer); /* timer_delete_sync(&pmlmeext->ADDBA_timer); */ @@ -1962,7 +1962,7 @@ void update_mgntframe_attrib_addr(struct adapter *pad= apter, struct xmit_frame *p void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntfram= e) { if (padapter->bSurpriseRemoved || - padapter->bDriverStopped) { + padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return; @@ -1980,7 +1980,7 @@ s32 dump_mgntframe_and_wait(struct adapter *padapter,= struct xmit_frame *pmgntfr struct submit_ctx sctx; =20 if (padapter->bSurpriseRemoved || - padapter->bDriverStopped) { + padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return ret; @@ -2009,7 +2009,7 @@ s32 dump_mgntframe_and_wait_ack(struct adapter *padap= ter, struct xmit_frame *pmg struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; =20 if (padapter->bSurpriseRemoved || - padapter->bDriverStopped) { + padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return -1; @@ -2516,7 +2516,7 @@ int issue_probereq_ex(struct adapter *padapter, struc= t ndis_802_11_ssid *pssid, =20 i++; =20 - if (padapter->bDriverStopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->bSurpriseRemoved) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3064,7 +3064,7 @@ int issue_nulldata(struct adapter *padapter, unsigned= char *da, unsigned int pow =20 i++; =20 - if (padapter->bDriverStopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->bSurpriseRemoved) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3196,7 +3196,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsi= gned char *da, u16 tid, int =20 i++; =20 - if (padapter->bDriverStopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->bSurpriseRemoved) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3289,7 +3289,7 @@ int issue_deauth_ex(struct adapter *padapter, u8 *da,= unsigned short reason, int =20 i++; =20 - if (padapter->bDriverStopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->bSurpriseRemoved) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3718,11 +3718,11 @@ unsigned int send_beacon(struct adapter *padapter) poll++; } while ((poll % 10) !=3D 0 && !bxmitok && !padapter->bSurpriseRemoved && - !padapter->bDriverStopped); + !padapter->driver_stopped); =20 - } while (false =3D=3D bxmitok && issue < 100 && !padapter->bSurpriseRemov= ed && !padapter->bDriverStopped); + } while (false =3D=3D bxmitok && issue < 100 && !padapter->bSurpriseRemov= ed && !padapter->driver_stopped); =20 - if (padapter->bSurpriseRemoved || padapter->bDriverStopped) + if (padapter->bSurpriseRemoved || padapter->driver_stopped) return _FAIL; =20 if (!bxmitok) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging= /rtl8723bs/core/rtw_pwrctrl.c index 803eef9438a6..448611ad8237 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -242,7 +242,7 @@ void rtw_set_rpwm(struct adapter *padapter, u8 pslv) return; } =20 - if (padapter->bDriverStopped) { + if (padapter->driver_stopped) { if (pslv < PS_STATE_S2) return; } @@ -1045,7 +1045,7 @@ int _rtw_pwr_wakeup(struct adapter *padapter, u32 ips= _deffer_ms, const char *cal } =20 /* TODO: the following checking need to be merged... */ - if (padapter->bDriverStopped || !padapter->bup || !padapter->hw_init_comp= leted) { + if (padapter->driver_stopped || !padapter->bup || !padapter->hw_init_comp= leted) { ret =3D false; goto exit; } diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index 7946acd8869b..7568fc514d7c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -1892,7 +1892,7 @@ static int recv_indicatepkts_in_order(struct adapter = *padapter, struct recv_reor =20 /* indicate this recv_frame */ if (!pattrib->amsdu) { - if (!padapter->bDriverStopped && + if (!padapter->driver_stopped && !padapter->bSurpriseRemoved) rtw_recv_indicatepkt(padapter, prframe);/* indicate this recv_frame */ =20 @@ -1931,7 +1931,7 @@ static int recv_indicatepkt_reorder(struct adapter *p= adapter, union recv_frame * wlanhdr_to_ethhdr(prframe); =20 if (pattrib->qos !=3D 1) { - if (!padapter->bDriverStopped && + if (!padapter->driver_stopped && !padapter->bSurpriseRemoved) { rtw_recv_indicatepkt(padapter, prframe); return _SUCCESS; @@ -2009,7 +2009,7 @@ void rtw_reordering_ctrl_timeout_handler(struct timer= _list *t) struct adapter *padapter =3D preorder_ctrl->padapter; struct __queue *ppending_recvframe_queue =3D &preorder_ctrl->pending_recv= frame_queue; =20 - if (padapter->bDriverStopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->bSurpriseRemoved) return; =20 spin_lock_bh(&ppending_recvframe_queue->lock); @@ -2033,7 +2033,7 @@ static int process_recv_indicatepkts(struct adapter *= padapter, union recv_frame =20 if (recv_indicatepkt_reorder(padapter, prframe) !=3D _SUCCESS) { /* inc= luding perform A-MPDU Rx Ordering Buffer Control */ =20 - if (!padapter->bDriverStopped && + if (!padapter->driver_stopped && !padapter->bSurpriseRemoved) { retval =3D _FAIL; return retval; @@ -2044,7 +2044,7 @@ static int process_recv_indicatepkts(struct adapter *= padapter, union recv_frame if (retval !=3D _SUCCESS) return retval; =20 - if (!padapter->bDriverStopped && !padapter->bSurpriseRemoved) { + if (!padapter->driver_stopped && !padapter->bSurpriseRemoved) { /* indicate this recv_frame */ rtw_recv_indicatepkt(padapter, prframe); } else { diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723b= s/hal/odm.c index 180aac640a14..d18df407e365 100644 --- a/drivers/staging/rtl8723bs/hal/odm.c +++ b/drivers/staging/rtl8723bs/hal/odm.c @@ -257,7 +257,7 @@ static void odm_RefreshRateAdaptiveMaskCE(struct dm_odm= _t *pDM_Odm) u8 i; struct adapter *padapter =3D pDM_Odm->Adapter; =20 - if (padapter->bDriverStopped) + if (padapter->driver_stopped) return; =20 if (!pDM_Odm->bUseRAMask) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging= /rtl8723bs/hal/rtl8723b_cmd.c index 21b837772b24..0790209a3a8f 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -639,11 +639,11 @@ void rtl8723b_download_rsvd_page(struct adapter *pada= pter, u8 mstatus) /* check rsvd page download OK. */ rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bcn_valid)); poll++; - } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemove= d && !padapter->bDriverStopped); + } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemove= d && !padapter->driver_stopped); =20 - } while (!bcn_valid && DLBcnCount <=3D 100 && !padapter->bSurpriseRemove= d && !padapter->bDriverStopped); + } while (!bcn_valid && DLBcnCount <=3D 100 && !padapter->bSurpriseRemove= d && !padapter->driver_stopped); =20 - if (padapter->bSurpriseRemoved || padapter->bDriverStopped) { + if (padapter->bSurpriseRemoved || padapter->driver_stopped) { } else { struct pwrctrl_priv *pwrctl =3D adapter_to_pwrctl(padapter); =20 @@ -897,8 +897,8 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct = adapter *padapter) /* check rsvd page download OK. */ rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, &bcn_valid); poll++; - } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemoved= && !padapter->bDriverStopped); - } while (!bcn_valid && (DLBcnCount <=3D 100) && !padapter->bSurpriseRemov= ed && !padapter->bDriverStopped); + } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemoved= && !padapter->driver_stopped); + } while (!bcn_valid && (DLBcnCount <=3D 100) && !padapter->bSurpriseRemov= ed && !padapter->driver_stopped); =20 if (bcn_valid) { struct pwrctrl_priv *pwrctl =3D adapter_to_pwrctl(padapter); diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 3dac9a8fe5d8..bb66ab008e3c 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -189,7 +189,7 @@ static s32 polling_fwdl_chksum( do { cnt++; value32 =3D rtw_read32(adapter, REG_MCUFWDL); - if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || adapter->b= DriverStopped) + if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || adapter->d= river_stopped) break; yield(); } while (jiffies_to_msecs(jiffies-start) < timeout_ms || cnt < min_cnt); @@ -229,7 +229,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) do { cnt++; value32 =3D rtw_read32(adapter, REG_MCUFWDL); - if (value32 & WINTINI_RDY || adapter->bSurpriseRemoved || adapter->bDriv= erStopped) + if (value32 & WINTINI_RDY || adapter->bSurpriseRemoved || adapter->drive= r_stopped) break; yield(); } while (jiffies_to_msecs(jiffies - start) < timeout_ms || cnt < min_cnt); @@ -384,7 +384,7 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter,= bool bUsedWoWLANFw) _FWDownloadEnable(padapter, true); fwdl_start_time =3D jiffies; while ( - !padapter->bDriverStopped && + !padapter->driver_stopped && !padapter->bSurpriseRemoved && (write_fw++ < 3 || jiffies_to_msecs(jiffies - fwdl_start_time) < 500) ) { diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index 78fa99115751..f6ad3c8b7aa3 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -660,7 +660,7 @@ static void phy_SwChnlAndSetBwMode8723B(struct adapter = *Adapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); =20 - if (Adapter->bDriverStopped || Adapter->bSurpriseRemoved) + if (Adapter->driver_stopped || Adapter->bSurpriseRemoved) return; =20 if (pHalData->bSwChnl) { @@ -726,7 +726,7 @@ static void PHY_HandleSwChnlAndSetBW8723B( } =20 /* Switch workitem or set timer to do switch channel or setbandwidth oper= ation */ - if ((!Adapter->bDriverStopped) && (!Adapter->bSurpriseRemoved)) { + if ((!Adapter->driver_stopped) && (!Adapter->bSurpriseRemoved)) { phy_SwChnlAndSetBwMode8723B(Adapter); } else { if (pHalData->bSwChnl) { diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index 79dbca1b5525..6110172858eb 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -16,7 +16,7 @@ static u8 rtw_sdio_wait_enough_TxOQT_space(struct adapter= *padapter, u8 agg_num) while (pHalData->SdioTxOQTFreeSpace < agg_num) { if ( (padapter->bSurpriseRemoved) || - (padapter->bDriverStopped) + (padapter->driver_stopped) ) return false; =20 @@ -89,7 +89,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter *pada= pter) =20 if ( (padapter->bSurpriseRemoved) || - (padapter->bDriverStopped) + (padapter->driver_stopped) ) goto free_xmitbuf; =20 @@ -130,7 +130,7 @@ s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter) return _FAIL; } =20 - ret =3D (padapter->bDriverStopped) || (padapter->bSurpriseRemoved); + ret =3D (padapter->driver_stopped) || (padapter->bSurpriseRemoved); if (ret) return _FAIL; =20 @@ -362,7 +362,7 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padap= ter) =20 next: if ( - (padapter->bDriverStopped) || + (padapter->driver_stopped) || (padapter->bSurpriseRemoved) ) return _FAIL; diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl= 8723bs/hal/sdio_ops.c index c4058cfe73f2..da2d9088ab5a 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c @@ -803,7 +803,7 @@ void sd_int_hdl(struct adapter *adapter) struct hal_com_data *hal; =20 if ( - (adapter->bDriverStopped) || (adapter->bSurpriseRemoved) + (adapter->driver_stopped) || (adapter->bSurpriseRemoved) ) return; =20 diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index c837157404d0..b2bbec7769d0 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -294,7 +294,7 @@ struct adapter { void *HalData; u32 hal_data_sz; =20 - s32 bDriverStopped; + bool driver_stopped; s32 bSurpriseRemoved; s32 bCardDisableWOHSM; =20 @@ -400,12 +400,12 @@ static inline void RTW_ENABLE_FUNC(struct adapter *pa= dapter, int func_bit) RTW_IS_FUNC_DISABLED((padapter), DF_IO_BIT)) =20 #define RTW_CANNOT_RX(padapter) \ - ((padapter)->bDriverStopped || \ + ((padapter)->driver_stopped || \ (padapter)->bSurpriseRemoved || \ RTW_IS_FUNC_DISABLED((padapter), DF_RX_BIT)) =20 #define RTW_CANNOT_TX(padapter) \ - ((padapter)->bDriverStopped || \ + ((padapter)->driver_stopped || \ (padapter)->bSurpriseRemoved || \ RTW_IS_FUNC_DISABLED((padapter), DF_TX_BIT)) =20 diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index cb270e1768e9..c15056ee207c 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -798,7 +798,7 @@ static int _netdev_open(struct net_device *pnetdev) } =20 if (!padapter->bup) { - padapter->bDriverStopped =3D false; + padapter->driver_stopped =3D false; padapter->bSurpriseRemoved =3D false; padapter->bCardDisableWOHSM =3D false; =20 @@ -866,7 +866,7 @@ static int ips_netdrv_open(struct adapter *padapter) =20 padapter->net_closed =3D false; =20 - padapter->bDriverStopped =3D false; + padapter->driver_stopped =3D false; padapter->bCardDisableWOHSM =3D false; /* padapter->bup =3D true; */ =20 @@ -972,7 +972,7 @@ void rtw_dev_unload(struct adapter *padapter) u8 cnt =3D 0; =20 if (padapter->bup) { - padapter->bDriverStopped =3D true; + padapter->driver_stopped =3D true; if (padapter->xmitpriv.ack_tx) rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_DRV_STOP); =20 @@ -1088,7 +1088,7 @@ void rtw_suspend_common(struct adapter *padapter) while (pwrpriv->bips_processing) msleep(1); =20 - if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpris= eRemoved)) + if ((!padapter->bup) || (padapter->driver_stopped) || (padapter->bSurpris= eRemoved)) return; =20 rtw_ps_deny(padapter, PS_DENY_SUSPEND); diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 099f9e6fc3ce..c61d3d12df7f 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -229,7 +229,7 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_p= riv *dvobj) padapter->dvobj =3D dvobj; dvobj->if1 =3D padapter; =20 - padapter->bDriverStopped =3D true; + padapter->driver_stopped =3D true; =20 dvobj->padapters =3D padapter; padapter->iface_id =3D 0; @@ -415,7 +415,7 @@ static int rtw_sdio_suspend(struct device *dev) struct pwrctrl_priv *pwrpriv =3D dvobj_to_pwrctl(psdpriv); struct adapter *padapter =3D psdpriv->if1; =20 - if (padapter->bDriverStopped) + if (padapter->driver_stopped) return 0; =20 if (pwrpriv->bInSuspend) --=20 2.54.0 From nobody Sat Jul 25 04:53:34 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A69A42A15C for ; Fri, 17 Jul 2026 16:15:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784304927; cv=none; b=TRZoARGDG9YHdszmMi7RwR0XwaaXieItUT2JChvL5/7k59ZulmaqA7TRBFgYiW4UwYv3d+20OolHBcn0iBxCGaynNfyKI/JpNx35ULVUdnQ2K0hK7/fsQLQ2PxLhKg0JjE0GI2UoqO5G66mOAZ+jMeqOgtizx3mPkuV3ytlsUUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784304927; c=relaxed/simple; bh=3zImIYXLiKT4q6PpcAKK+PZ4G7fsWWk2cE2Bl8EBVxM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lwv5QBoxiuVLFdYInC3phQrwI9sfMAB8mhWpLBnWJYtq2z3b+X9vim3doITMyUmUPt7YsrZf3+Y4yoCgk9tmMNwI4Ggw6joV9zX2YKWNc7d4TIs0N7DZ7djeYYIUEs+HWy0lPLeaaHZPTe9vpFp4WWxbyGudkN6Dgdu/meas034= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LMKa4zt8; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LMKa4zt8" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-4720f3bf164so960073f8f.1 for ; Fri, 17 Jul 2026 09:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784304923; x=1784909723; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LZHW/38ICNcakcfMw1kjAmwJ8fiAmMI+UWsjBTBRZ9Y=; b=LMKa4zt8MBro4qJfPdACgobd7vIWCiCXQFcLpIO0BpqC7102xVj6FULd7jAApuv3LG 28sKUy3UMBmMcY0axGRF4X8T91qbXqUFZ3I+ls6xMFKaMniZiI56Ssli/jgKY0gIu/pW nBm9KGJktFffbiMWd9SiSj4MMZSZEUPknoS5KUFGza8sN9clSUzPO4FkvJVHWbckiCKZ ybNtK1rTNLb/6+faRUgjGudF8mBdWfq/QZ4jwmQKUOMJ+mg0eZrPd9Figq8+Sz1TKzot KO/SyN7IGv4/8bm0+cd0YBqUEzAEEhUXSNBxek5exFNY7+kt3aPnFBO9khU9VFRmKxjZ QI0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784304923; x=1784909723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LZHW/38ICNcakcfMw1kjAmwJ8fiAmMI+UWsjBTBRZ9Y=; b=MMskX/GvFIEo9KIKqLkE0XrQ7L7KIAxq/A7w1coSr0MPgtjpDasRWQUrBYANKAVDUg lCeE7PPAQKbP081Y+FFJ3UwOMuVy+M+4U8hs1dz9obeGfYYt5s3fJ0jwedw2Dw5HeVAH FPDPB80gogoasN76n1XoaFTQXZs236ECyGhynBC7YkQJZJHy5p7KnRhKBA6bSUB2DT/u dPNVPPBIPfVt/PgLgNY2b5AS3JxEb4J+Gsx6E3mlYGXzCVcuAzfoEofEnJwd6IE3kYle Lhc6Sqm1ls5B6uSIUNGl33zmg5i6qFD9k6rl3JJDYiDPiWxZ9XfsUXDx365wSlXuMQBV PEkw== X-Forwarded-Encrypted: i=1; AHgh+RqNUUWdjpwJoAwxLHCRWnF5SUqr/4VKb8LLs40gJrEszobOnZRoL6Ev0YqwqlrkNxHYbJMxDo5FF3WYkis=@vger.kernel.org X-Gm-Message-State: AOJu0Yxq/nnqm0r6WZ1ibTEBJfC/W1YFpq+3Wb+GG76EC1kFkjo2B8+O CjAxWDXvlcwv70c+qI0qsNgXDsn8poCi+5ymy3ynOzO2qnAd4TCnhT9z X-Gm-Gg: AfdE7clXKabyywaFvfL2DPKiJ+pyhSfH4eofDjxiFYijRi3qXMJDVrdNWjUSb2Fn1HI PFvnIYBwpIIO3QViqGjN87c3r7Z5XtQYNK1dw157Pxzq0Q8PsTEsIvSi4zFOSj3iXCK7x5vGGOE SmRFvrT7IfnbSGs76QMnXYdRanqFYxX6Nm7dcB7ZNxilJ5fw5DFFxNUQI7PI6dAWBoBALwbNTSc 55oxsfrX6patT6NB5F/W72ENhGB5+4zAJMjUxF5Khvf5IX+6yQxY0jPUmWyROYEna9lgdk7KrnC HgME/dbUovhy//2Ec0BF4U2K9jb0BY7x2+Pv43qmCiBdendw4ysESnPHjeUNS+cy0dJHebO7cUT cF2Zde7ne+A/z1TiVAdP/YIKmMDlBPO/b6oA1HTITmJiNuuQG0rthro8uqnHyzHhziAoN8NADIE LvY1RMHF06uB3x77rujf6VkKDpxwTNl3OC4jJ9La9jbZXodsKX+fKxRIuuV4vBAm/2sIk= X-Received: by 2002:a05:6000:41f0:b0:460:d18:865c with SMTP id ffacd0b85a97d-47f5a4182c4mr10396577f8f.1.1784304923018; Fri, 17 Jul 2026 09:15:23 -0700 (PDT) Received: from koolguy.fritz.box (dslb-088-074-245-227.088.074.pools.vodafone-ip.de. [88.74.245.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f66df025csm3252526f8f.0.2026.07.17.09.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 09:15:22 -0700 (PDT) From: Dalvin-Ehinoma Noah Aiguobas To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dalvin-Ehinoma Noah Aiguobas Subject: [PATCH v2 2/4] staging: rtl8723bs: wrap line over 100 characters Date: Fri, 17 Jul 2026 16:13:27 +0000 Message-ID: <20260717161329.3400-3-fliegbert2@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260717161329.3400-1-fliegbert2@gmail.com> References: <20260715171634.1550-1-fliegbert2@gmail.com> <20260717161329.3400-1-fliegbert2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch warning by wrapping the lines. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ++- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 12 ++++++++---- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 ++- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 57f0403ff5bf..216990e9dcc8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -3720,7 +3720,8 @@ unsigned int send_beacon(struct adapter *padapter) !padapter->bSurpriseRemoved && !padapter->driver_stopped); =20 - } while (false =3D=3D bxmitok && issue < 100 && !padapter->bSurpriseRemov= ed && !padapter->driver_stopped); + } while (false =3D=3D bxmitok && issue < 100 && !padapter->bSurpriseRemov= ed && + !padapter->driver_stopped); =20 if (padapter->bSurpriseRemoved || padapter->driver_stopped) return _FAIL; diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging= /rtl8723bs/hal/rtl8723b_cmd.c index 0790209a3a8f..d2b44ad60a4c 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -639,9 +639,11 @@ void rtl8723b_download_rsvd_page(struct adapter *padap= ter, u8 mstatus) /* check rsvd page download OK. */ rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bcn_valid)); poll++; - } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemove= d && !padapter->driver_stopped); + } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemove= d && + !padapter->driver_stopped); =20 - } while (!bcn_valid && DLBcnCount <=3D 100 && !padapter->bSurpriseRemove= d && !padapter->driver_stopped); + } while (!bcn_valid && DLBcnCount <=3D 100 && !padapter->bSurpriseRemove= d && + !padapter->driver_stopped); =20 if (padapter->bSurpriseRemoved || padapter->driver_stopped) { } else { @@ -897,8 +899,10 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct= adapter *padapter) /* check rsvd page download OK. */ rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, &bcn_valid); poll++; - } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemoved= && !padapter->driver_stopped); - } while (!bcn_valid && (DLBcnCount <=3D 100) && !padapter->bSurpriseRemov= ed && !padapter->driver_stopped); + } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemoved= && + !padapter->driver_stopped); + } while (!bcn_valid && (DLBcnCount <=3D 100) && !padapter->bSurpriseRemov= ed && + !padapter->driver_stopped); =20 if (bcn_valid) { struct pwrctrl_priv *pwrctl =3D adapter_to_pwrctl(padapter); diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index bb66ab008e3c..6d75cc8fa566 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -189,7 +189,8 @@ static s32 polling_fwdl_chksum( do { cnt++; value32 =3D rtw_read32(adapter, REG_MCUFWDL); - if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || adapter->d= river_stopped) + if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || + adapter->driver_stopped) break; yield(); } while (jiffies_to_msecs(jiffies-start) < timeout_ms || cnt < min_cnt); --=20 2.54.0 From nobody Sat Jul 25 04:53:34 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA9ED400974 for ; Fri, 17 Jul 2026 16:15:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784304928; cv=none; b=WmOczu8eMySR3NHhp46Nx9WSOl9QnPLmQd8/3uvtFIqWTOBRhXoMaW0NSb4L3ntBfzK6xMfjJ7q8po+ytT7zesbZd42j5AsgG5tsnLzprHLrpRRbkI6a0fSEh6J1LFZJWxB3SltoMEGr2j9yaVuN2hFjaR+bFPReKUgggJk3mig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784304928; c=relaxed/simple; bh=hwklLxmRYkeY84OVdQJTTV9dNu/yJ4cgQUyQnJbCpSE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gBFwp4rrkfWEDooQZG+4KvaLIBx6e87fJnWa+9sp1w1YejawBiVnP9AOcfKh8/jC5VpMRsWNnsuE8lmKK5qIzS8eeT8FApYhnbvxPdexzL/NoDdy5VwmQQ41d1hLX9MaFGI8jDbNp5hsAN1A4R3gF9USgvZwhonhr5JL/57xJqg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Um5Ho1Mi; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Um5Ho1Mi" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-47ddf7b09e5so4134929f8f.1 for ; Fri, 17 Jul 2026 09:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784304924; x=1784909724; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=va3YtjmyCtn8d1uW6UDmGlleX2+uuG76oFkM6SYjGQA=; b=Um5Ho1Mi2226PqLl9+wAXmnvr4/+5Y9ou62mAGqOi64mUP/i1jG3ohEmffX5yFOZ9V ziy37oZJaIXb6+uW5HrOWAy0Evpj/tt/PPEj3fw6V6V1BYsst6T72HTMO45rlhJgBMAi KrKV+teoLulV4X7/50NiJD/ba7eVMMZGqRmFscLtHtGYuUyqDkCQ86h/4P/y51VGtgvl lueAqcE2Y4hpqx0ph6SUo7Ia5nJdkKCb8PVPfjHMVlP7yl/R8aQ/a7YNeQxmdaR17Bs7 Fl9TdvU1kyInalg9fYmKuToBg8j7VmZgMYSIGpQCbEA5UL3v3bcYo7Ym5dOGi9lz9vKz uO+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784304924; x=1784909724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=va3YtjmyCtn8d1uW6UDmGlleX2+uuG76oFkM6SYjGQA=; b=jBFRpiqU0Psjpms6+6RZSSiBHWTYo0Vs/dkTHlqyjprUnJI8JoXcju0tfF1SQEx8S/ 60cOJ2CJ2rJGqt8/VnG1bsP7LFR6T4XTdzeX/xWtySnu1+Cmh3fIkQWEfFQ2y4dSAUoU wthm8Y886RyvlW3sIYWUQPus0oLwNp93VTMKlzpk4hw0M7ECsXWo92vIcLYxbsJ4iaOR cvmn5j4GnKWz3c66gNzixXM5fjX/RdOWloE4a/e/DZhbGvr9igpG3iMpPXgMaJdgTQ/I fhFOAB/RAkOUoJuLEgk2/CbeJ1cEntE6JpGe115yTfVXaq33wDr2e1iCDc2hlkULWeMl ONDw== X-Forwarded-Encrypted: i=1; AHgh+Rq1lqhpByeJOAHArc9eC5+lpZusd1rg8ViQ6+hdkZHBVRdAzCe8pkY7vVWaSx+YY0CmOCqkmq685WjX3u4=@vger.kernel.org X-Gm-Message-State: AOJu0YwQfzF3UiHJOwO3X5OnXjiR7MLPHSEphK98Nc84M1qkdCm4agdL rSbKz7N85eVsFsSgKEwLS91kzReRhnasRJL22mspF9DW3f7d8yQy3bqg X-Gm-Gg: AfdE7cmIq6RG/cA/paZAKfwR5mGa8vLmvJBFhCNU+nXH/VQFSraHDE4Pumzx/yAUMpl Mz/nkTtYuufYnbg6IVhOaTb6SIgAbu0/8smx+v/F7KZu2Go5JgeSblJr4sLaX5yJbrakHHb3YXX FA4tacpH1WWfW71k737gJti0FX75CUxiELwZ/8X3HVcllS+qsZcIn3r2XLOvR7Hef0SV+0N396o uTXrtGCUaHX4OcUNy9FYhZi9zJCGu2VtCOHumOMFSyLdps6S4P+RTV6GuPqWLSqkOrM7HQBwLj4 TW81s6ftJjYxWbjVdP+4vBp52biylaTlbchojgPfEUyaFp7E7tqqW0y500tmuKPqRo7QER16auz IbuspKU0NEX8OOXaIfivcG4eVGYQ5NpZhF8QjayZOvNKplez9UxDufhRF8Jo8zcsj4+v7EnBf7N h2vBsccQP03luUEZ7OPisMCtT1vTR8w7PyK7RYllHhn2tIC8j53koGK01vtUTFDDO+XGo= X-Received: by 2002:a05:6000:2c10:b0:475:f100:35f3 with SMTP id ffacd0b85a97d-47f62326e58mr4300629f8f.48.1784304923887; Fri, 17 Jul 2026 09:15:23 -0700 (PDT) Received: from koolguy.fritz.box (dslb-088-074-245-227.088.074.pools.vodafone-ip.de. [88.74.245.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f66df025csm3252526f8f.0.2026.07.17.09.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 09:15:23 -0700 (PDT) From: Dalvin-Ehinoma Noah Aiguobas To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dalvin-Ehinoma Noah Aiguobas Subject: [PATCH v2 3/4] staging: rtl8723bs: change struct member bSurpriseRemoved Date: Fri, 17 Jul 2026 16:13:28 +0000 Message-ID: <20260717161329.3400-4-fliegbert2@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260717161329.3400-1-fliegbert2@gmail.com> References: <20260715171634.1550-1-fliegbert2@gmail.com> <20260717161329.3400-1-fliegbert2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Member name does not adhere to linux coding style. Changed type as well since b indicates a boolean type and in every instance of setting the variable the values true and false are used. bSurpriseRemoved -> surprise_removed Signed-off-by: Dalvin-Ehinoma Noah Aiguobas --- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 2 +- drivers/staging/rtl8723bs/core/rtw_cmd.c | 8 ++--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 ++-- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 20 ++++++------ drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 12 +++---- drivers/staging/rtl8723bs/core/rtw_recv.c | 10 +++--- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 12 +++---- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 8 ++--- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 4 +-- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 8 ++--- drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +- drivers/staging/rtl8723bs/include/drv_types.h | 8 ++--- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 10 +++--- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 +-- .../staging/rtl8723bs/os_dep/sdio_ops_linux.c | 32 +++++++++---------- 15 files changed, 73 insertions(+), 73 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/= rtl8723bs/core/rtw_btcoex.c index 9e00424d00bd..24b6742509d8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c @@ -23,7 +23,7 @@ void rtw_btcoex_halt_notify(struct adapter *padapter) if (!padapter->bup) return; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return; =20 hal_btcoex_HaltNotify(padapter); diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index df6b118ee9c9..daad3e90ee05 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -396,11 +396,11 @@ int rtw_cmd_thread(void *context) break; } =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) { + if (padapter->driver_stopped || padapter->surprise_removed) { netdev_dbg(padapter->pnetdev, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n", __func__, padapter->driver_stopped, - padapter->bSurpriseRemoved, __LINE__); + padapter->surprise_removed, __LINE__); break; } =20 @@ -419,11 +419,11 @@ int rtw_cmd_thread(void *context) continue; =20 _next: - if (padapter->driver_stopped || padapter->bSurpriseRemoved) { + if (padapter->driver_stopped || padapter->surprise_removed) { netdev_dbg(padapter->pnetdev, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n", __func__, padapter->driver_stopped, - padapter->bSurpriseRemoved, __LINE__); + padapter->surprise_removed, __LINE__); break; } =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 11f77b7ca745..3f80b5e3d0f6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -264,7 +264,7 @@ void rtw_free_network_queue(struct adapter *padapter, u= 8 isfreeall) =20 bool rtw_if_up(struct adapter *padapter) { - if (padapter->driver_stopped || padapter->bSurpriseRemoved || + if (padapter->driver_stopped || padapter->surprise_removed || !check_fwstate(&padapter->mlmepriv, _FW_LINKED)) return false; =20 @@ -1500,7 +1500,7 @@ void _rtw_join_timeout_handler(struct timer_list *t) mlmepriv.assoc_timer); struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 - if (adapter->driver_stopped || adapter->bSurpriseRemoved) + if (adapter->driver_stopped || adapter->surprise_removed) return; =20 spin_lock_bh(&pmlmepriv->lock); @@ -1602,7 +1602,7 @@ void rtw_dynamic_check_timer_handler(struct adapter *= adapter) if (!adapter->hw_init_completed) return; =20 - if (adapter->driver_stopped || adapter->bSurpriseRemoved) + if (adapter->driver_stopped || adapter->surprise_removed) return; =20 if (adapter->net_closed) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 216990e9dcc8..5d2254222701 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1961,7 +1961,7 @@ void update_mgntframe_attrib_addr(struct adapter *pad= apter, struct xmit_frame *p =20 void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntfram= e) { - if (padapter->bSurpriseRemoved || + if (padapter->surprise_removed || padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); @@ -1979,7 +1979,7 @@ s32 dump_mgntframe_and_wait(struct adapter *padapter,= struct xmit_frame *pmgntfr struct xmit_buf *pxmitbuf =3D pmgntframe->pxmitbuf; struct submit_ctx sctx; =20 - if (padapter->bSurpriseRemoved || + if (padapter->surprise_removed || padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); @@ -2008,7 +2008,7 @@ s32 dump_mgntframe_and_wait_ack(struct adapter *padap= ter, struct xmit_frame *pmg u32 timeout_ms =3D 500;/* 500ms */ struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; =20 - if (padapter->bSurpriseRemoved || + if (padapter->surprise_removed || padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); @@ -2516,7 +2516,7 @@ int issue_probereq_ex(struct adapter *padapter, struc= t ndis_802_11_ssid *pssid, =20 i++; =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->surprise_removed) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3064,7 +3064,7 @@ int issue_nulldata(struct adapter *padapter, unsigned= char *da, unsigned int pow =20 i++; =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->surprise_removed) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3196,7 +3196,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsi= gned char *da, u16 tid, int =20 i++; =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->surprise_removed) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3289,7 +3289,7 @@ int issue_deauth_ex(struct adapter *padapter, u8 *da,= unsigned short reason, int =20 i++; =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->surprise_removed) break; =20 if (i < try_cnt && wait_ms > 0 && ret =3D=3D _FAIL) @@ -3717,13 +3717,13 @@ unsigned int send_beacon(struct adapter *padapter) rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bxmitok)); poll++; } while ((poll % 10) !=3D 0 && !bxmitok && - !padapter->bSurpriseRemoved && + !padapter->surprise_removed && !padapter->driver_stopped); =20 - } while (false =3D=3D bxmitok && issue < 100 && !padapter->bSurpriseRemov= ed && + } while (false =3D=3D bxmitok && issue < 100 && !padapter->surprise_remov= ed && !padapter->driver_stopped); =20 - if (padapter->bSurpriseRemoved || padapter->driver_stopped) + if (padapter->surprise_removed || padapter->driver_stopped) return _FAIL; =20 if (!bxmitok) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging= /rtl8723bs/core/rtw_pwrctrl.c index 448611ad8237..fa47c6dd7988 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -237,7 +237,7 @@ void rtw_set_rpwm(struct adapter *padapter, u8 pslv) return; } =20 - if ((padapter->bSurpriseRemoved) || !(padapter->hw_init_completed)) { + if ((padapter->surprise_removed) || !(padapter->hw_init_completed)) { pwrpriv->cpwm =3D PS_STATE_S4; return; } @@ -404,7 +404,7 @@ int LPS_RF_ON_check(struct adapter *padapter, u32 delay= _ms) if (bAwake) return 0; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return -ENODEV; =20 if (jiffies_to_msecs(jiffies - start_time) > delay_ms) @@ -480,7 +480,7 @@ void LeaveAllPowerSaveModeDirect(struct adapter *Adapte= r) struct mlme_priv *pmlmepriv =3D &Adapter->mlmepriv; struct pwrctrl_priv *pwrpriv =3D adapter_to_pwrctl(Adapter); =20 - if (Adapter->bSurpriseRemoved) + if (Adapter->surprise_removed) return; =20 if (check_fwstate(pmlmepriv, _FW_LINKED)) { /* connect */ @@ -514,7 +514,7 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter) if (!Adapter->bup) return; =20 - if (Adapter->bSurpriseRemoved) + if (Adapter->surprise_removed) return; =20 if (check_fwstate(&dvobj->padapters->mlmepriv, WIFI_ASOC_STATE)) @@ -548,7 +548,7 @@ void LPS_Leave_check(struct adapter *padapter) while (1) { mutex_lock(&pwrpriv->lock); =20 - if (padapter->bSurpriseRemoved || + if (padapter->surprise_removed || !(padapter->hw_init_completed) || (pwrpriv->pwr_mode =3D=3D PS_MODE_ACTIVE)) bReady =3D true; @@ -1089,7 +1089,7 @@ int rtw_pm_set_ips(struct adapter *padapter, u8 mode) return 0; } else if (mode =3D=3D IPS_NONE) { rtw_ips_mode_req(pwrctrlpriv, mode); - if ((padapter->bSurpriseRemoved =3D=3D 0) && (rtw_pwr_wakeup(padapter) = =3D=3D _FAIL)) + if ((padapter->surprise_removed =3D=3D 0) && (rtw_pwr_wakeup(padapter) = =3D=3D _FAIL)) return -EFAULT; } else { return -EINVAL; diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index 7568fc514d7c..901670fa756c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -1893,7 +1893,7 @@ static int recv_indicatepkts_in_order(struct adapter = *padapter, struct recv_reor /* indicate this recv_frame */ if (!pattrib->amsdu) { if (!padapter->driver_stopped && - !padapter->bSurpriseRemoved) + !padapter->surprise_removed) rtw_recv_indicatepkt(padapter, prframe);/* indicate this recv_frame */ =20 } else if (pattrib->amsdu =3D=3D 1) { @@ -1932,7 +1932,7 @@ static int recv_indicatepkt_reorder(struct adapter *p= adapter, union recv_frame * =20 if (pattrib->qos !=3D 1) { if (!padapter->driver_stopped && - !padapter->bSurpriseRemoved) { + !padapter->surprise_removed) { rtw_recv_indicatepkt(padapter, prframe); return _SUCCESS; } @@ -2009,7 +2009,7 @@ void rtw_reordering_ctrl_timeout_handler(struct timer= _list *t) struct adapter *padapter =3D preorder_ctrl->padapter; struct __queue *ppending_recvframe_queue =3D &preorder_ctrl->pending_recv= frame_queue; =20 - if (padapter->driver_stopped || padapter->bSurpriseRemoved) + if (padapter->driver_stopped || padapter->surprise_removed) return; =20 spin_lock_bh(&ppending_recvframe_queue->lock); @@ -2034,7 +2034,7 @@ static int process_recv_indicatepkts(struct adapter *= padapter, union recv_frame if (recv_indicatepkt_reorder(padapter, prframe) !=3D _SUCCESS) { /* inc= luding perform A-MPDU Rx Ordering Buffer Control */ =20 if (!padapter->driver_stopped && - !padapter->bSurpriseRemoved) { + !padapter->surprise_removed) { retval =3D _FAIL; return retval; } @@ -2044,7 +2044,7 @@ static int process_recv_indicatepkts(struct adapter *= padapter, union recv_frame if (retval !=3D _SUCCESS) return retval; =20 - if (!padapter->driver_stopped && !padapter->bSurpriseRemoved) { + if (!padapter->driver_stopped && !padapter->surprise_removed) { /* indicate this recv_frame */ rtw_recv_indicatepkt(padapter, prframe); } else { diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging= /rtl8723bs/hal/rtl8723b_cmd.c index d2b44ad60a4c..858471b8d65a 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -59,7 +59,7 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementI= D, u32 CmdLen, u8 *pCmd if (CmdLen > RTL8723B_MAX_CMD_LEN) goto exit; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) goto exit; =20 /* pay attention to if race condition happened in H2C cmd setting. */ @@ -639,13 +639,13 @@ void rtl8723b_download_rsvd_page(struct adapter *pada= pter, u8 mstatus) /* check rsvd page download OK. */ rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bcn_valid)); poll++; - } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemove= d && + } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->surprise_remove= d && !padapter->driver_stopped); =20 - } while (!bcn_valid && DLBcnCount <=3D 100 && !padapter->bSurpriseRemove= d && + } while (!bcn_valid && DLBcnCount <=3D 100 && !padapter->surprise_remove= d && !padapter->driver_stopped); =20 - if (padapter->bSurpriseRemoved || padapter->driver_stopped) { + if (padapter->surprise_removed || padapter->driver_stopped) { } else { struct pwrctrl_priv *pwrctl =3D adapter_to_pwrctl(padapter); =20 @@ -899,9 +899,9 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct = adapter *padapter) /* check rsvd page download OK. */ rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, &bcn_valid); poll++; - } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemoved= && + } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->surprise_removed= && !padapter->driver_stopped); - } while (!bcn_valid && (DLBcnCount <=3D 100) && !padapter->bSurpriseRemov= ed && + } while (!bcn_valid && (DLBcnCount <=3D 100) && !padapter->surprise_remov= ed && !padapter->driver_stopped); =20 if (bcn_valid) { diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 6d75cc8fa566..36e70cf0fed0 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -189,7 +189,7 @@ static s32 polling_fwdl_chksum( do { cnt++; value32 =3D rtw_read32(adapter, REG_MCUFWDL); - if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || + if (value32 & FWDL_ChkSum_rpt || adapter->surprise_removed || adapter->driver_stopped) break; yield(); @@ -230,7 +230,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) do { cnt++; value32 =3D rtw_read32(adapter, REG_MCUFWDL); - if (value32 & WINTINI_RDY || adapter->bSurpriseRemoved || adapter->drive= r_stopped) + if (value32 & WINTINI_RDY || adapter->surprise_removed || adapter->drive= r_stopped) break; yield(); } while (jiffies_to_msecs(jiffies - start) < timeout_ms || cnt < min_cnt); @@ -386,7 +386,7 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter,= bool bUsedWoWLANFw) fwdl_start_time =3D jiffies; while ( !padapter->driver_stopped && - !padapter->bSurpriseRemoved && + !padapter->surprise_removed && (write_fw++ < 3 || jiffies_to_msecs(jiffies - fwdl_start_time) < 500) ) { /* reset FWDL chksum */ @@ -2713,7 +2713,7 @@ void GetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) u32 valRCR; =20 if ( - padapter->bSurpriseRemoved || + padapter->surprise_removed || (adapter_to_pwrctl(padapter)->rf_pwrstate =3D=3D rf_off) ) { /* If it is in HW/SW Radio OFF or IPS state, we do not check Fw LPS L= eave, */ diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index f6ad3c8b7aa3..eff18320630f 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -660,7 +660,7 @@ static void phy_SwChnlAndSetBwMode8723B(struct adapter = *Adapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); =20 - if (Adapter->driver_stopped || Adapter->bSurpriseRemoved) + if (Adapter->driver_stopped || Adapter->surprise_removed) return; =20 if (pHalData->bSwChnl) { @@ -726,7 +726,7 @@ static void PHY_HandleSwChnlAndSetBW8723B( } =20 /* Switch workitem or set timer to do switch channel or setbandwidth oper= ation */ - if ((!Adapter->driver_stopped) && (!Adapter->bSurpriseRemoved)) { + if ((!Adapter->driver_stopped) && (!Adapter->surprise_removed)) { phy_SwChnlAndSetBwMode8723B(Adapter); } else { if (pHalData->bSwChnl) { diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index 6110172858eb..115f5ecd3b9e 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -15,7 +15,7 @@ static u8 rtw_sdio_wait_enough_TxOQT_space(struct adapter= *padapter, u8 agg_num) =20 while (pHalData->SdioTxOQTFreeSpace < agg_num) { if ( - (padapter->bSurpriseRemoved) || + (padapter->surprise_removed) || (padapter->driver_stopped) ) return false; @@ -88,7 +88,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter *pada= pter) } =20 if ( - (padapter->bSurpriseRemoved) || + (padapter->surprise_removed) || (padapter->driver_stopped) ) goto free_xmitbuf; @@ -130,7 +130,7 @@ s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter) return _FAIL; } =20 - ret =3D (padapter->driver_stopped) || (padapter->bSurpriseRemoved); + ret =3D (padapter->driver_stopped) || (padapter->surprise_removed); if (ret) return _FAIL; =20 @@ -363,7 +363,7 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padap= ter) next: if ( (padapter->driver_stopped) || - (padapter->bSurpriseRemoved) + (padapter->surprise_removed) ) return _FAIL; =20 diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl= 8723bs/hal/sdio_ops.c index da2d9088ab5a..ca50f8a5c32e 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c @@ -803,7 +803,7 @@ void sd_int_hdl(struct adapter *adapter) struct hal_com_data *hal; =20 if ( - (adapter->driver_stopped) || (adapter->bSurpriseRemoved) + (adapter->driver_stopped) || (adapter->surprise_removed) ) return; =20 diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index b2bbec7769d0..0a0a9b4d6a9a 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -295,7 +295,7 @@ struct adapter { u32 hal_data_sz; =20 bool driver_stopped; - s32 bSurpriseRemoved; + bool surprise_removed; s32 bCardDisableWOHSM; =20 u32 IsrContent; @@ -396,17 +396,17 @@ static inline void RTW_ENABLE_FUNC(struct adapter *pa= dapter, int func_bit) #define RTW_IS_FUNC_DISABLED(padapter, func_bit) (atomic_read(&adapter_to_= dvobj(padapter)->disable_func) & (func_bit)) =20 #define RTW_CANNOT_IO(padapter) \ - ((padapter)->bSurpriseRemoved || \ + ((padapter)->surprise_removed || \ RTW_IS_FUNC_DISABLED((padapter), DF_IO_BIT)) =20 #define RTW_CANNOT_RX(padapter) \ ((padapter)->driver_stopped || \ - (padapter)->bSurpriseRemoved || \ + (padapter)->surprise_removed || \ RTW_IS_FUNC_DISABLED((padapter), DF_RX_BIT)) =20 #define RTW_CANNOT_TX(padapter) \ ((padapter)->driver_stopped || \ - (padapter)->bSurpriseRemoved || \ + (padapter)->surprise_removed || \ RTW_IS_FUNC_DISABLED((padapter), DF_TX_BIT)) =20 static inline u8 *myid(struct eeprom_priv *peepriv) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index c15056ee207c..52db657e1aa1 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -799,7 +799,7 @@ static int _netdev_open(struct net_device *pnetdev) =20 if (!padapter->bup) { padapter->driver_stopped =3D false; - padapter->bSurpriseRemoved =3D false; + padapter->surprise_removed =3D false; padapter->bCardDisableWOHSM =3D false; =20 status =3D rtw_hal_init(padapter); @@ -902,7 +902,7 @@ void rtw_ips_pwr_down(struct adapter *padapter) =20 void rtw_ips_dev_unload(struct adapter *padapter) { - if (!padapter->bSurpriseRemoved) + if (!padapter->surprise_removed) rtw_hal_deinit(padapter); } =20 @@ -1000,13 +1000,13 @@ void rtw_dev_unload(struct adapter *padapter) "%s: driver not in IPS\n", __func__); } =20 - if (!padapter->bSurpriseRemoved) { + if (!padapter->surprise_removed) { hal_btcoex_IpsNotify(padapter, pwrctl->ips_mode_req); =20 /* amy modify 20120221 for power seq is different between driver open a= nd ips */ rtw_hal_deinit(padapter); =20 - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; } =20 padapter->bup =3D false; @@ -1088,7 +1088,7 @@ void rtw_suspend_common(struct adapter *padapter) while (pwrpriv->bips_processing) msleep(1); =20 - if ((!padapter->bup) || (padapter->driver_stopped) || (padapter->bSurpris= eRemoved)) + if ((!padapter->bup) || (padapter->driver_stopped) || (padapter->surprise= _removed)) return; =20 rtw_ps_deny(padapter, PS_DENY_SUSPEND); diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index c61d3d12df7f..c06b6b863763 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -383,7 +383,7 @@ static void rtw_dev_remove(struct sdio_func *func) =20 rtw_unregister_netdevs(dvobj); =20 - if (!padapter->bSurpriseRemoved) { + if (!padapter->surprise_removed) { int err; =20 /* test surprise remove */ @@ -391,7 +391,7 @@ static void rtw_dev_remove(struct sdio_func *func) sdio_readb(func, 0, &err); sdio_release_host(func); if (err =3D=3D -ENOMEDIUM) - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; } =20 rtw_ps_deny(padapter, PS_DENY_DRV_REMOVE); diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c b/drivers/st= aging/rtl8723bs/os_dep/sdio_ops_linux.c index e9a2f3f7ec74..71d3e4babd31 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c @@ -42,7 +42,7 @@ s32 _sd_cmd52_read(struct intf_hdl *pintfhdl, u32 addr, u= 32 cnt, u8 *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -74,7 +74,7 @@ s32 sd_cmd52_read(struct intf_hdl *pintfhdl, u32 addr, u3= 2 cnt, u8 *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -106,7 +106,7 @@ s32 _sd_cmd52_write(struct intf_hdl *pintfhdl, u32 addr= , u32 cnt, u8 *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -138,7 +138,7 @@ s32 sd_cmd52_write(struct intf_hdl *pintfhdl, u32 addr,= u32 cnt, u8 *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -166,7 +166,7 @@ u8 sd_read8(struct intf_hdl *pintfhdl, u32 addr, s32 *e= rr) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return v; =20 func =3D psdio->func; @@ -193,7 +193,7 @@ u32 sd_read32(struct intf_hdl *pintfhdl, u32 addr, s32 = *err) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return v; =20 func =3D psdio->func; @@ -222,10 +222,10 @@ u32 sd_read32(struct intf_hdl *pintfhdl, u32 addr, s3= 2 *err) } =20 if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; =20 if (rtw_inc_and_chk_continual_io_error(psdiodev)) { - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; break; } } @@ -245,7 +245,7 @@ void sd_write8(struct intf_hdl *pintfhdl, u32 addr, u8 = v, s32 *err) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return; =20 func =3D psdio->func; @@ -270,7 +270,7 @@ void sd_write32(struct intf_hdl *pintfhdl, u32 addr, u3= 2 v, s32 *err) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return; =20 func =3D psdio->func; @@ -298,10 +298,10 @@ void sd_write32(struct intf_hdl *pintfhdl, u32 addr, = u32 v, s32 *err) } =20 if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; =20 if (rtw_inc_and_chk_continual_io_error(psdiodev)) { - padapter->bSurpriseRemoved =3D true; + padapter->surprise_removed =3D true; break; } } @@ -336,7 +336,7 @@ s32 _sd_read(struct intf_hdl *pintfhdl, u32 addr, u32 c= nt, void *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -386,7 +386,7 @@ s32 sd_read(struct intf_hdl *pintfhdl, u32 addr, u32 cn= t, void *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -429,7 +429,7 @@ s32 _sd_write(struct intf_hdl *pintfhdl, u32 addr, u32 = cnt, void *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; @@ -480,7 +480,7 @@ s32 sd_write(struct intf_hdl *pintfhdl, u32 addr, u32 c= nt, void *pdata) psdiodev =3D pintfhdl->pintf_dev; psdio =3D &psdiodev->intf_data; =20 - if (padapter->bSurpriseRemoved) + if (padapter->surprise_removed) return err; =20 func =3D psdio->func; --=20 2.54.0 From nobody Sat Jul 25 04:53:34 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 952BB400961 for ; Fri, 17 Jul 2026 16:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784304928; cv=none; b=d7W7YrkqkMKuLbNCE/T2NlqBsKzbixDNdzekIwvzZ2R+os3Rdr3PQry5SErKfrUDBMTBQhaKRzhEfFzRbpE37a8Qik3JrkkUhcldatJnoDT1MDgTdoDYA5oMzvqf25fPeJ9nPD7Q671id6e0jyQttL9oLz+kSguASzr86p9D3QA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784304928; c=relaxed/simple; bh=RHo9R8BnTqDlxq7u6OixE5fwGbLhjtZ+mxTR7WKgVe8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CaePaIPHlgPtrB/uO16XiBY/SX+8pyEY9R+TNz+l9zHSSKzh53LQ/TZmE036VLTsDm1fuel/EPFJurca9frLsKmT4+lOA6QYZYiMYvJfJAuGCisVY7d394yUrMjAHNy+f1uI/ZOifCjXCs1/U/bUte5gDRf2fhp7OTRGFZHXe/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jay62sHP; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jay62sHP" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-47ddf7b09e5so4134939f8f.1 for ; Fri, 17 Jul 2026 09:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784304925; x=1784909725; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8LrC2qwHf2lSigkZwM3f4GEqTfOppRZaIXNSrf/Vrak=; b=Jay62sHPwaz8TU46SNtiq4UWMI1Tx2rkAliSgswD7JnNklYquyT3DuK6zKyEMkPctu 22T7GGYPJ/a6tElIiUsbMbgAWko7cpCceqjLabxWnvVdNnh+GRkjyKbVGJhvIXHg++IX rp+lUzSE1ZZiQCjAHAK9jIgSol+Mb9Pf0Be4RwQml0KqveqRyatahsWEQBVWf+dP0pM8 eMMOFxy1MJLA/AmzD33Ss2QPlv8xESpsrxxz/egVzzC2i8/E9ckoL+xBIbFToDbQgE8W F1hPItqLoLQUK623yrQfpjUpWqBTfXA5zXNkAQao+4sqx6VreFbx8Y+1VbuLi24HPFqz BuEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784304925; x=1784909725; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8LrC2qwHf2lSigkZwM3f4GEqTfOppRZaIXNSrf/Vrak=; b=oL1W0QLD0X2MsSucbmECs7bMP4c1urYvKYNCBMs4aI5Y10tg2FaeSLImpHuD+O9guo I0f71SDl7rZ9MTovZqnYOY26c0uMfPT6zbvEChqXIJxzUgkh/QLv1ULSoQ5WSy7NRs7J Na1oLh1yjpH/Kq5Ji79rkiWCE97xZDKsMSTULKGfVZCdhLTrIMay2xz4eXV+4ACQdMKV LK5h/wmXlYrEfKinxhQTOdejdc9uZObx9eae5kmqsVf2jVZzmlhZqJOQPYSPmnvQpz85 +vGZyazA9C3zN5Coz25Br1p75OMsAbF9AD/LigguGBq4YjFLRn5H3AT3yJXTeHCMT8/S Jy1Q== X-Forwarded-Encrypted: i=1; AHgh+RrR3j3KYejw+25rN66TaU+EAgaL/iW7lH5sc2u2pYRamXq8eKV6OadHogtiswvYzGTd4wVUINnUH0Pwg7Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyI+3ZyIE1htEKuoDiJmf8BC8diJ9WYwqFgCDhn0VWd7dMuX/lt D65KFsuFLZd2ra+zPkC65Tt9sHhi9edNOSca6GQSgBbZQ5hBHNiMvoM650Eq4SPS X-Gm-Gg: AfdE7cnBkZQeZBASVwbNLH4nse3GvgDOu2Fi2u1Vm5E6QpGP91X/pytmmkruYHeLbMu H/6hbhUXqX93LOqN9wt8OqGxPieGoYHGJYYZ9c6cOCOOIFLGeBWUyLH8yJ9HX2GpfZjpf/ZNKZB RBfcaZz79Rrq0xorjfp4xvu77zdWlvE03MGMFY41SoqbgRpnhOpmq0Id3IapoQHeECpx0i7VLP4 tObnn3jztGa54XlIqZfV2XBExTSifrDDRcxTX5kIcqJLaMbkJJ/g5vOfnNi2txbgCJcrURo8RNW 3qQPpmcq7JfidNQcWERoI0/J+ZUgeFnZJE3tSqoUUjg0EVbv2tsgctvL94Qflxwdyim+Y9jeoJw cBMHfmeTgvuXZ9sNiFNEPeOZ+dIdXmplgjamOndA/r9xBwaZSmaZvNIELO9GsEguntNBeQpy3HV Yg74ns+v9jObVV7en6AI8czDg0kXM8cwH+r4xfQvi0jlawZ3xtImWgPE5pWV7TAkvXivM= X-Received: by 2002:a5d:5f55:0:b0:460:6a13:9131 with SMTP id ffacd0b85a97d-47f622f8373mr4347703f8f.19.1784304924669; Fri, 17 Jul 2026 09:15:24 -0700 (PDT) Received: from koolguy.fritz.box (dslb-088-074-245-227.088.074.pools.vodafone-ip.de. [88.74.245.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f66df025csm3252526f8f.0.2026.07.17.09.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 09:15:24 -0700 (PDT) From: Dalvin-Ehinoma Noah Aiguobas To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dalvin-Ehinoma Noah Aiguobas Subject: [PATCH v2 4/4] staging: rtl8723bs: fix Alignment should match open parenthesis in rtw_mlme_ext.c Date: Fri, 17 Jul 2026 16:13:29 +0000 Message-ID: <20260717161329.3400-5-fliegbert2@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260717161329.3400-1-fliegbert2@gmail.com> References: <20260715171634.1550-1-fliegbert2@gmail.com> <20260717161329.3400-1-fliegbert2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fixing almost every occurrence of checkpatch warning Alignment should match open parenthesis in rtw_mlme_ext.c. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 60 +++++++++---------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 5d2254222701..94a4574d57d0 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -256,8 +256,8 @@ static void init_mlme_ext_priv_value(struct adapter *pa= dapter) } =20 static int has_channel(struct rt_channel_info *channel_set, - u8 chanset_size, - u8 chan) + u8 chanset_size, + u8 chan) { int i; =20 @@ -269,8 +269,8 @@ static int has_channel(struct rt_channel_info *channel_= set, } =20 static void init_channel_list(struct adapter *padapter, struct rt_channel_= info *channel_set, - u8 chanset_size, - struct p2p_channels *channel_list) + u8 chanset_size, + struct p2p_channels *channel_list) { static const struct p2p_oper_class_map op_class[] =3D { { IEEE80211G, 81, 1, 13, 1, BW20 }, @@ -302,7 +302,7 @@ static void init_channel_list(struct adapter *padapter,= struct rt_channel_info * continue; =20 if ((0 < (padapter->registrypriv.bw_mode & 0xf0)) && - ((o->bw =3D=3D BW40MINUS) || (o->bw =3D=3D BW40PLUS))) + ((o->bw =3D=3D BW40MINUS) || (o->bw =3D=3D BW40PLUS))) continue; =20 if (!reg) { @@ -515,7 +515,7 @@ unsigned int OnProbeReq(struct adapter *padapter, union= recv_frame *precv_frame) } =20 p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _PROBEREQ_IE_OFFSET_, WLAN_EI= D_SSID, (int *)&ielen, - len - WLAN_HDR_A3_LEN - _PROBEREQ_IE_OFFSET_); + len - WLAN_HDR_A3_LEN - _PROBEREQ_IE_OFFSET_); =20 /* check (wildcard) SSID */ if (p) { @@ -715,8 +715,8 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) seq =3D le16_to_cpu(*(__le16 *)((SIZE_PTR)pframe + WLAN_HDR_A3_LEN + offs= et + 2)); =20 if (auth_mode =3D=3D 2 && - psecuritypriv->dot11_privacy_algrthm !=3D _WEP40_ && - psecuritypriv->dot11_privacy_algrthm !=3D _WEP104_) + psecuritypriv->dot11_privacy_algrthm !=3D _WEP40_ && + psecuritypriv->dot11_privacy_algrthm !=3D _WEP104_) auth_mode =3D 0; =20 if ((algorithm > 0 && auth_mode =3D=3D 0) || /* rx a shared-key auth but= shared not enabled */ @@ -797,7 +797,7 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) pstat->authalg =3D algorithm; } else if (seq =3D=3D 3) { p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + 4 + _AUTH_IE_OFFSET_, WLAN_= EID_CHALLENGE, (int *)&ie_len, - len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_ - 4); + len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_ - 4); =20 if (!p || ie_len !=3D 128) { status =3D WLAN_STATUS_CHALLENGE_FAIL; @@ -883,7 +883,7 @@ unsigned int OnAuthClient(struct adapter *padapter, uni= on recv_frame *precv_fram if (pmlmeinfo->auth_algo =3D=3D dot11_auth_algrthm_shared) { /* legendary shared system */ p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_, WLAN_EID_= CHALLENGE, (int *)&len, - pkt_len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_); + pkt_len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_); =20 if (!p) goto authclnt_fail; @@ -992,7 +992,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union= recv_frame *precv_frame) /* now we should check all the fields... */ /* checking SSID */ p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, WLAN_EID_SSID, &ie= _len, - pkt_len - WLAN_HDR_A3_LEN - ie_offset); + pkt_len - WLAN_HDR_A3_LEN - ie_offset); =20 if (!p || ie_len =3D=3D 0) { /* broadcast ssid, however it is not allowed in assocreq */ @@ -1027,7 +1027,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) support_rate_num =3D ie_len; =20 p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, WLAN_EID_EXT_SUPP= _RATES, &ie_len, - pkt_len - WLAN_HDR_A3_LEN - ie_offset); + pkt_len - WLAN_HDR_A3_LEN - ie_offset); if (p) { if (support_rate_num + ie_len <=3D sizeof(supportRate)) { memcpy(supportRate + support_rate_num, p + 2, ie_len); @@ -1230,8 +1230,8 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) } =20 if ((pstat->flags & WLAN_STA_HT) && - ((pstat->wpa2_pairwise_cipher & WPA_CIPHER_TKIP) || - (pstat->wpa_pairwise_cipher & WPA_CIPHER_TKIP))) { + ((pstat->wpa2_pairwise_cipher & WPA_CIPHER_TKIP) || + (pstat->wpa_pairwise_cipher & WPA_CIPHER_TKIP))) { /* status =3D WLAN_STATUS_CIPHER_SUITE_REJECTED; */ /* goto OnAssocReqFail; */ } @@ -1962,7 +1962,7 @@ void update_mgntframe_attrib_addr(struct adapter *pad= apter, struct xmit_frame *p void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntfram= e) { if (padapter->surprise_removed || - padapter->driver_stopped) { + padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return; @@ -1980,7 +1980,7 @@ s32 dump_mgntframe_and_wait(struct adapter *padapter,= struct xmit_frame *pmgntfr struct submit_ctx sctx; =20 if (padapter->surprise_removed || - padapter->driver_stopped) { + padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return ret; @@ -2009,7 +2009,7 @@ s32 dump_mgntframe_and_wait_ack(struct adapter *padap= ter, struct xmit_frame *pmg struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; =20 if (padapter->surprise_removed || - padapter->driver_stopped) { + padapter->driver_stopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return -1; @@ -2505,7 +2505,7 @@ inline void issue_probereq(struct adapter *padapter, = struct ndis_802_11_ssid *ps } =20 int issue_probereq_ex(struct adapter *padapter, struct ndis_802_11_ssid *p= ssid, u8 *da, u8 ch, bool append_wps, - int try_cnt, int wait_ms) + int try_cnt, int wait_ms) { int ret; int i =3D 0; @@ -2906,8 +2906,8 @@ void issue_assocreq(struct adapter *padapter) switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC: if ((!memcmp(pIE->data, RTW_WPA_OUI, 4)) || - (!memcmp(pIE->data, WMM_OUI, 4)) || - (!memcmp(pIE->data, WPS_OUI, 4))) { + (!memcmp(pIE->data, WMM_OUI, 4)) || + (!memcmp(pIE->data, WPS_OUI, 4))) { vs_ie_length =3D pIE->length; if ((!padapter->registrypriv.wifi_spec) && (!memcmp(pIE->data, WPS_OUI= , 4))) { /* Commented by Kurt 20110629 @@ -3279,7 +3279,7 @@ int issue_deauth(struct adapter *padapter, unsigned c= har *da, unsigned short rea } =20 int issue_deauth_ex(struct adapter *padapter, u8 *da, unsigned short reaso= n, int try_cnt, - int wait_ms) + int wait_ms) { int ret; int i =3D 0; @@ -4173,7 +4173,7 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid =20 /* Adjust channel plan by AP Country IE */ if (pregistrypriv->enable80211d && - (!pmlmeext->update_channel_plan_by_ap_done)) { + (!pmlmeext->update_channel_plan_by_ap_done)) { u8 *ie, *p; u32 len; struct rt_channel_plan chplan_ap; @@ -4223,8 +4223,8 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid if (pregistrypriv->wireless_mode & WIRELESS_11G) { do { if ((i =3D=3D MAX_CHANNEL_NUM) || - (chplan_sta[i].channel_num =3D=3D 0) || - (chplan_sta[i].channel_num > 14)) + (chplan_sta[i].channel_num =3D=3D 0) || + (chplan_sta[i].channel_num > 14)) break; =20 if ((j =3D=3D chplan_ap.Len) || (chplan_ap.Channel[j] > 14)) @@ -4251,8 +4251,8 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid =20 /* change AP not support channel to Passive scan */ while ((i < MAX_CHANNEL_NUM) && - (chplan_sta[i].channel_num !=3D 0) && - (chplan_sta[i].channel_num <=3D 14)) { + (chplan_sta[i].channel_num !=3D 0) && + (chplan_sta[i].channel_num <=3D 14)) { chplan_new[k].channel_num =3D chplan_sta[i].channel_num; chplan_new[k].scan_type =3D SCAN_PASSIVE; i++; @@ -4269,8 +4269,8 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid } else { /* keep original STA 2.4G channel plan */ while ((i < MAX_CHANNEL_NUM) && - (chplan_sta[i].channel_num !=3D 0) && - (chplan_sta[i].channel_num <=3D 14)) { + (chplan_sta[i].channel_num !=3D 0) && + (chplan_sta[i].channel_num <=3D 14)) { chplan_new[k].channel_num =3D chplan_sta[i].channel_num; chplan_new[k].scan_type =3D chplan_sta[i].scan_type; i++; @@ -5345,7 +5345,7 @@ u8 disconnect_hdl(struct adapter *padapter, unsigned = char *pbuf) } =20 static int rtw_scan_ch_decision(struct adapter *padapter, struct rtw_ieee8= 0211_channel *out, - u32 out_num, struct rtw_ieee80211_channel *in, u32 in_num) + u32 out_num, struct rtw_ieee80211_channel *in, u32 in_num) { int i, j; int set_idx; @@ -5591,7 +5591,7 @@ u8 add_ba_hdl(struct adapter *padapter, unsigned char= *pbuf) return H2C_SUCCESS; =20 if (((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && (pmlmeinfo->HT_enable)= ) || - ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { /* pmlmeinfo->ADDBA_retry_count =3D 0; */ /* pmlmeinfo->candidate_tid_bitmap |=3D (0x1 << pparm->tid); */ /* psta->htpriv.candidate_tid_bitmap |=3D BIT(pparm->tid); */ --=20 2.54.0