From nobody Sat Jul 25 05:17:35 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC3F93FBED9 for ; Fri, 17 Jul 2026 13:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784294262; cv=none; b=UXJ2DTuD5ypJw0uu9mFi3NdH6KJ9+lCQguQBBoqZ97diiwiW2BFw4VqhAZvkqqqRm9eJRldL2MVCYI4wkz6/AmzV+9fxWzocN5cmeLglxMoBuj6UZz7ekzGdfe+GSlc4+Rxwai8D3607vnIT6rBP+xxzvdfgSCZbc8b24Ty0VhM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784294262; c=relaxed/simple; bh=Hvtps/wDYbIsM4c5E2UreoLfCBOyh8LrLfxlk+d0lzU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=futrEInYj3vo8+OoBJ5w0E9drTOynim6unkoz88fX/pFG9fCYrd+2RxwRDg3+NnMj3epDuzBCIoMwwB5HmxtUi0GE3l6AolmlIAAHpWmMLxPCuylnb3Gp3bmFP8iAgA7cKbiyKy8mI8Vq9Y21tZsK8eiQApyMIAaYch4Ut18vu8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kg4z/a3+; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kg4z/a3+" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ced3386430so42221175ad.1 for ; Fri, 17 Jul 2026 06:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784294260; x=1784899060; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=N2OpEvimBr9inqr1oxq/Rw5zQcfND5k4NuFnqM1lzPk=; b=Kg4z/a3+m6HxpQDiEayPLmF1tR9rTuAaBqdwnbdYiah+MOxHtadJjO09hth7J/1bG4 Lx26sM/m1caDCeWfZrVSngYiZ86ql81EYef0P0whGGmjsebHB0B6f1sz+pwT7yJdrM/w 5CqheQJQhHP20QNyYM4TLYLXoUkl+tUuLiMne/R0lz3azWJjn4Q5JHvIGX5MV+kxsex+ s/uGcd1C6NuR0oxeornop60XsSYw3c93hYsFfee2Y5/Yml65XjFr/DzDADiZsZaKMHFv jSm9QnXzV82nJzNMuN9KlvKb6oHY87kKrnYqhzXmnzv+ZYnMY8PZO5Qk/lZkDrheOBAx faBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784294260; x=1784899060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=N2OpEvimBr9inqr1oxq/Rw5zQcfND5k4NuFnqM1lzPk=; b=XVWzQoHmG3NX8Aa1P/NOlhsuIVYAzM0ygFcqwTqbW0m38CjiY/y3JNXPbfnxLsy5JG cYWyrnWmNwMUKavz4RythePQsMbnEsUTTBZzkFeKcmQrOuMoQYM7WdjE8vwXr0NL658H v5bX7mdllMEymXzvv5cNOtWUkx7u+F/uCwm2tzTiQSNDK/hdSd9VZ6MA5MVqxxF5VGd2 VZ2Z9JAetErphrgYer6DcSzVVSUlhDyLT4D3L0Oln3CZjjjLLMPLSn2vnqB7VIChV+Cj At1s+Y9hlE+hTHjMlrcAqsLIHlCz5S+ySnqtJGNeL9IzuNPzJujpa7THJ8iLKMdY73ew 36qw== X-Forwarded-Encrypted: i=1; AHgh+RofOt10G0tn11gQyLku+XCpE6BKIj0+mp90Ln72va8PF7Fl/ZJMY5wtAcVQN5nW45swPlGupq2TDzLsi10=@vger.kernel.org X-Gm-Message-State: AOJu0YyfL6DRPTROnRSzCvaJU2V4/gxrSBdbRQrXH+AKVGwcfZLisbml CJipm31ZESiKdyIct1inIaLviOgRaQRnIh76QR0Fhj2TRQMUXiNa/tRZ X-Gm-Gg: AfdE7clvZkdGhdlfXNoxsEWjw+RUyAUSMF2gInMZ+FdxKWTdbJ1QFcGhNrl26+yjapH nHorGDzrke6+h1dDh6F1X7p+EenXJ6GxktjmaPzdewJevvexFx3oY+LNyVTiI7EuCT5GwNDzY9X 6YztTDgcYclkaxmPElgg3ze28+XprTRudEziheUmJ2ewHUn/ndc//8A19cOTcyq0IW9lSNl9ljR dmw+yEQ5yHYp/U66p+4D3bGjLoenpXQ2kqpEpNHeZkFluvFK8+T1lLm7QZkagmCbQ9/7CzR5NPZ Abv6FqRFDTbWjXtnrAjqKmTASDBellj1PEaxY+w/v7P1wBXcQYwTg7GBI9S5NGnO+5purgltNeY l6PNrLvBNXa+pW564jSH2uT0ubm/I8bxIg+FNiG1fmH2/7g4HYPblsO1wBPG3YSynA2d1l2WrPy CNhkpd/XEHz4KMWIO252kJSp/xz5jLiJLmbG8= X-Received: by 2002:a17:90b:1dc3:b0:384:5b5b:3465 with SMTP id 98e67ed59e1d1-38e4b5792e4mr2760146a91.29.1784294259629; Fri, 17 Jul 2026 06:17:39 -0700 (PDT) Received: from localhost.localdomain ([152.59.184.57]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429ff04absm6907802eec.8.2026.07.17.06.17.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 17 Jul 2026 06:17:39 -0700 (PDT) From: Rounak Das To: dinguyen@kernel.org Cc: bp@alien8.de, tony.luck@intel.com, stable@vger.kernel.org, rounakdas2025@gmail.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] EDAC/altera: Fix device node reference leaks in the SDMMC ECC setup Date: Fri, 17 Jul 2026 18:47:20 +0530 Message-ID: <20260717131720.19038-1-rounakdas2025@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <182c3d64-17b7-4e18-9bbe-2fd97eb231a2@kernel.org> References: <182c3d64-17b7-4e18-9bbe-2fd97eb231a2@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Under altr_portb_setup() and socfpga_init_sdmmc_ecc(), of_find_compatible_node() was being used to look up the sdmmc-ecc node. This node wasn't being dropped using of_node_put(). altr_portb_setup() did not drop its reference under its success path or on any error path. socfpga_init_sdmmc_ecc() did an early return thereby skipping the common exit label and thus leaking the reference. Add the missing of_node_put() calls in altr_portb_setup(), and route socfpga_init_sdmmc_ecc()'s success path through the common exit label. Fixes: 911049845d70 ("EDAC, altera: Add Arria10 SD-MMC EDAC support") Fixes: 788586efd116 ("EDAC/altera: Initialize peripheral FIFOs in probe()") Cc: stable@vger.kernel.org Closes: https://sashiko.dev/#/patchset/20260708091135.94114-1-rounakdas2025= %40gmail.com Signed-off-by: Rounak Das Acked-by: Dinh Nguyen --- v2: - Add Fixes:, Cc: stable, and Closes: tags (Dinh). v1: https://lore.kernel.org/all/20260717102549.13309-1-rounakdas2025@gmail.= com/ --- drivers/edac/altera_edac.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 68846f583eee..777ba6efcc54 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -1524,6 +1524,7 @@ static int altr_portb_setup(struct altr_edac_device_d= ev *device) dci =3D edac_device_alloc_ctl_info(sizeof(*altdev), ecc_name, 1, ecc_name, 1, 0, edac_idx); if (!dci) { + of_node_put(np); edac_printk(KERN_ERR, EDAC_DEVICE, "%s: Unable to allocate PortB EDAC device\n", ecc_name); @@ -1534,8 +1535,10 @@ static int altr_portb_setup(struct altr_edac_device_= dev *device) altdev =3D dci->pvt_info; *altdev =3D *device; =20 - if (!devres_open_group(device->edac->dev, altr_portb_setup, GFP_KERNEL)) + if (!devres_open_group(device->edac->dev, altr_portb_setup, GFP_KERNEL)) { + of_node_put(np); return -ENOMEM; + } =20 /* Update PortB specific values */ altdev->edac_dev_name =3D ecc_name; @@ -1600,6 +1603,8 @@ static int altr_portb_setup(struct altr_edac_device_d= ev *device) rc =3D -ENOMEM; goto err_release_group_1; } + of_node_put(np); + altr_create_edacdev_dbgfs(dci, prv); =20 list_add(&altdev->next, &altdev->edac->a10_ecc_devices); @@ -1609,6 +1614,7 @@ static int altr_portb_setup(struct altr_edac_device_d= ev *device) return 0; =20 err_release_group_1: + of_node_put(np); edac_device_free_ctl_info(dci); devres_release_group(device->edac->dev, altr_portb_setup); edac_printk(KERN_ERR, EDAC_DEVICE, @@ -1638,7 +1644,7 @@ static int __init socfpga_init_sdmmc_ecc(struct altr_= edac_device_dev *device) goto exit; =20 /* Setup portB */ - return altr_portb_setup(device); + rc =3D altr_portb_setup(device); =20 exit: of_node_put(child); --=20 2.50.1 (Apple Git-155)