From nobody Sat Jul 25 05:29:26 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013070.outbound.protection.outlook.com [52.101.127.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88B7C3F12FC; Fri, 17 Jul 2026 11:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287331; cv=fail; b=K9DHN/WXbg5XPtqdX1zTZQqKhy4si+9HCjyisXeA6HsOaacWr++OJXmDgf/JVKU7DzUV6vfrp5xgw2RFj/92hh4sOgYS5GBOYjGWu54fJYSf5pnDreTtq3qe8gqxyxbBphLO/p018pZAA3XadN41x1lvtUp8BqOguAi58rn4T9E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287331; c=relaxed/simple; bh=Rycn6iNcF1J0xpW6BrLNy5JH/W0aawC7sD98cPnEaFY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=tAsTzXZYRdAEsbDT3JRMRtOkeM5iLkHIpBbKxI7+1fOuHsJ+BavTYltH3JhwnVzRYwubOo8ihzUSPgvWeVNEfiGK0kqSi68FPZI9H0QoZyT28KJDDzk/oOTLRniA+pz70iMI92P6ksIimp1/kOeCDd6vnbICAU0/LuyiUoMQSuk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=omuDHFxA; arc=fail smtp.client-ip=52.101.127.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="omuDHFxA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=x9KAQN8qzuvzAqBpH0p5gVGtFvW6ASuMrzPbjih4URFcVALR+imbqzU0G/6jmJsLN6fidrZvaZhp4wwhtoD8EC6tgukbJCoby1Kx1k+Et/I3vxBKSmTbu1QrFgoRFY/No4HxPll92bXA/Y+5CyZNyhBlzF71tb/nn5/jTMmuNBQ74sZI628jVZZerC7XwnFjvgstwmeouMEz40IxWotoDWfUbPnXtibsTSwv5s8SMr70E3UBz2CVlPCNcfd0AXAwRG9sRrTrHgbk+ZfhTInxmfgJKFCQJ4B3I42dBiBzTZjNNSJF1GovxY9WTdzj3v2sMrjAxP4TE3wBph4Y/TzLZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WE94sEP695xNttTFmtH11vnLtIz8HrzNoGDsQL88sdQ=; b=o3IzgWWVn/VdpMLcihAUJI/QA7LO/jxoruMQ6UsampeEztkIvwp87mPm+Xzpe5ErQt3tUBEM4TL45soLN53LINtLvz/G6u+DuoanuDM1h3NiQ0bzEjR/AAbHvp4HiktqwvHvQCU+HXBwLO3RCbqZwxW5Nkp4OSiynbgqQgV7k6OLwyrxbkswMJmc90q68SwXYMfPN9tX+KFdcgWYtyNoPtEExdQjy/vGDzdCH50/fZYsWWjobPBcLmsRTs2RoLeOcmtGLVhqGWm0CnDbGabjps9k8uPfeCPNc003UAd+Hz3+r9BlqEHelwkAbgkoxYmKC4XvVOXL8THKUr5Wc8lxKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WE94sEP695xNttTFmtH11vnLtIz8HrzNoGDsQL88sdQ=; b=omuDHFxAqf837Tm5bZNtCbqlT3fmgecajWbAPhEJF4u28JIMFKN7C/2kO5aZdOPgi1uuyvHUOkUu7BPIt7IlZb6Ok60rWHCO2QQRAB7XCUSvXZeu+PMPf8fQGVCYo9h78GWQa5SGsxx1+DFHr2L7f+n0w+0E3hxdPEKvZshdsUFi8hwu8aFM8fQ3GugZ2aig82S2pS+UZf3X39O8tushbZnYiJD7hKOcGAL3n8eTShFmYiSkZHQmfdcNOzyBW54h08TjWfgSfovBMTXvIfUq8pPBsi6bsc8Eopj8nMy/q5UDNingdymsHBlro4VAQejPHD4P6arxlSTIHocsDlZFuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by PS1PPF5540628D6.apcprd06.prod.outlook.com (2603:1096:308::24e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Fri, 17 Jul 2026 11:21:55 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 11:21:55 +0000 From: Pan Chuang To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Bryan O'Donoghue" , Pengyu Luo , Sebastian Reichel , platform-driver-x86@vger.kernel.org (open list:ARM64 PLATFORM DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 1/7] platform: arm64: Remove redundant dev_err_probe() Date: Fri, 17 Jul 2026 19:20:39 +0800 Message-Id: <20260717112103.213017-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717112103.213017-1-panchuang@vivo.com> References: <20260717112103.213017-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0025.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:a::15) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|PS1PPF5540628D6:EE_ X-MS-Office365-Filtering-Correlation-Id: 873b05d2-b640-4914-2f64-08dee3f59bd7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|52116014|1800799024|376014|6133799003|56012099006|11063799006|38350700014|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: W0xsCrygFll1HKk/q/YW9VEcU99iC3pV+6G3Iip2nblgDSch5SZJRzP1bUsPq7t28qg7cYDIxmyv8p2ikn9K+FWh/hbNruKWHbpA8tMGTqQ+xlW9BuaUZ4Cv5rB2sCGu0NZb5lbuoJX3shE0bFfbWnFxB3n1duvnnp9prDZVigs/zrisaGRwWXlii4HP+ROlgQUP5MyVaRDnGh7cFj8Lo746NZnn73oYZbLxH7yFtwTZpqKtGX7ebx/cKRFBqtmjkacW/pS3Dxue3wT0Ur9+pS9bROXMMlY/JEL0IaEaqlVZjVFE65F3YQ27W335OB2Q+REWSB2ygpXU6aK4OoqZ7la8fk+wQHwAEQE5pgTrJITmkvbzx1GRYn2UmNYa5ZsNkmbfz/8PnyZ2A2PWw+6v9/Ke503zYxBv2RCOmGH3WUTXA9sCAWsbDsVaoYZgs6Xli9ezf30xfs6qeKxHVKOFdyYLG+ulmYvZSi5zVxzte03E+ozv/SAgQjqPhCqI6hPD4iIOjgAUHTbQYO3LtcTI8ug933wCT+vW8WQW/PWf817D6eVKyqGCWU0kQ8hA6bmEL5WQCA90ujcXUg6okvRb6YRqeeAf8IfnH91xFWr5uVOC/pgHZF5gWM3NaATpF/oFYWXESG84vBbMuA2QPlUI3oDiX9NI5y06YMCrmweW2LVlErRIxq70n/Ygz+oHEPK+z7siXBzF8/O1AP+TbI1GE6HyUkC0RiKSLEk1faKq2as= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(52116014)(1800799024)(376014)(6133799003)(56012099006)(11063799006)(38350700014)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qoqO5voQ3PTdj9eGOzS9Qqw+b6SsB1mwHasOs8quzVoFaicJNguiURxuLBPx?= =?us-ascii?Q?+8ETw6Ao8jzz6w8KU/wi/+JUHUcRPJKW2GD+J1kKaop10PDk1MaVuBe9WNyK?= =?us-ascii?Q?7l0OWu4QViM+eGk/UXRVxgoO0aufISofRcX6WXi+PzwoTnF3OIMoUFAJGxAb?= =?us-ascii?Q?c1KHJaCJDpfI8At1T8bkX1XETOBTKoxeIPj/76xamSpjRGwZASEPV/hkMnx3?= =?us-ascii?Q?jB0tQblyACuep/QEGZtK3mDZ4B0FwAnHODSsUsvpmua9ufv8t3aP10hZTvyH?= =?us-ascii?Q?9SlxXXz1BmiT8+0WLKm97EhjI/TEcZHk0Y0uZLEOhN6HFNOXKbfyCTlKgQSd?= =?us-ascii?Q?HeeDsv2DsDlsQN373hty+rAJ+RRV6cMlnunXgB8QB93cngeYpCaA9CnowF3r?= =?us-ascii?Q?n8MgMn//9OLlcWHagR/JVcnBG8RYTl5ajZolgQYTAOwqWXvCgjxc+v1NNJqn?= =?us-ascii?Q?//LtnrnvZsG/Kok8yEeaZOu6LpVWpjihhFsNwukr2/wB3SSPQAJmo6PxaX4K?= =?us-ascii?Q?nRQD/izhyTK6IRZtHlzGDwWnNrBHC9blFEbRqwk5E9582jQucntoSJrVTXxo?= =?us-ascii?Q?xs6FSJIU0FhGIPSD86FzSswrXY/Goq4ffRBkTcHZP2zlbZXHNTM8Va53nMfi?= =?us-ascii?Q?zFc/5JFPzcQOC64og7h/5DudDvJsdyNzKwqq8/f6j52mg13Ur2ix/9MyBeuy?= =?us-ascii?Q?MF3iGavSF6ONZ+i+5aLWT/M5p5T9vRp3908AJ5ds39xtXXKe8FQWDb/aApES?= =?us-ascii?Q?6ywPkuj0yqMOm3T2fM5xbdLthrFrM2kRHe4FkSQjLzMVwFQt0eml9lAIVfFT?= =?us-ascii?Q?uuJyemaPrjV6kiBxqYL+zPYpl0ByC/XgeUwdOWK7M2kbLFXSiiEYLrwaZ2B/?= =?us-ascii?Q?GkZKXupGI0p7Jhh1cUnnuweQEJlachpiG3Ug7kv7nsDhmZrirP12DUzVMYsM?= =?us-ascii?Q?RoikRcGOxGfRYqwAOpmiHSLfRZpOkAXuFhZXASM0XnGEKaBZ4I56eWTQzmEQ?= =?us-ascii?Q?LdVVS0XNHJjYn7SkZoGwW9N+1PJ58At+++/fFTBFO4jAtOI0VNr1RrMqGE7y?= =?us-ascii?Q?M/C99pRZ73Cs35URBWM5V+RIYngpeaCBJJUJ01i7ZE9glxtT9a1l9K0YuYu0?= =?us-ascii?Q?Ex4JZjx9PmgPiEkGWjqcJD/c3I9NCNTSLIffNjwpWrSdxMe9/iVyPY/Y8C0G?= =?us-ascii?Q?Ov0TQAX84duK1UqLqwDdV7l/W3tXQsX0VfOByzLOkDlTJvXUk0gytiftno/c?= =?us-ascii?Q?VVyon+Eaf/4dSg08/UJVOARXZJiIKCsPsWCPFtrHL9fymhvjaa3qJyYVtP1Y?= =?us-ascii?Q?YgDjoEXuGUHDqINNKn8O4F4Nv2cE446L6h5bg8n0PLactgt6n2cSTmFFqR70?= =?us-ascii?Q?sIF/XYPps1lQ8F/Z006CaM9E5xLu65x1Ut1aCAuALy1Gm1EQeTvXaJGvm/Nc?= =?us-ascii?Q?U+cc7S5G6nwZkCvQgoWumoz3PJmIPIwkXRXYqMSAhXjD37gMaH1c+KvIEBTF?= =?us-ascii?Q?czTgZBYO0WAGqWWOYqtBWThW6PeYw4KtgBIM3BWun/72YQJ7vYHiirhIVACe?= =?us-ascii?Q?l02MYkj31kJZtP/041WvuX1L6b1LfRQjLjI/otg0PnGFjOECFtqbvAWznIG+?= =?us-ascii?Q?waKOH8u/WfWj4kXHh37KvwA1MCOBkJ0xosuY2Oe9d11njGInmv+wrvzm033x?= =?us-ascii?Q?EwpK5wsBxWekSFZ3NiWt5Sj/b/HV6xjUGY2XiDtNlDFOR+5d9nJHQLCbdPyP?= =?us-ascii?Q?VL9MlFjjlg=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 873b05d2-b640-4914-2f64-08dee3f59bd7 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 11:21:55.6135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TEbMS0fR2whC8aovNIScjXQLXyehSJ8fd1FFqKQ4eIZcd7glXuLoZWSoWJwg6KvPTZ25f9zD4BVuEirFMX4tHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PPF5540628D6 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() calls. Signed-off-by: Pan Chuang Reviewed-by: Sebastian Reichel --- drivers/platform/arm64/acer-aspire1-ec.c | 2 +- drivers/platform/arm64/huawei-gaokun-ec.c | 2 +- drivers/platform/arm64/lenovo-thinkpad-t14s.c | 2 +- drivers/platform/arm64/lenovo-yoga-c630.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/platform/arm64/acer-aspire1-ec.c b/drivers/platform/ar= m64/acer-aspire1-ec.c index 08d0b155a197..501c62a096f8 100644 --- a/drivers/platform/arm64/acer-aspire1-ec.c +++ b/drivers/platform/arm64/acer-aspire1-ec.c @@ -514,7 +514,7 @@ static int aspire_ec_probe(struct i2c_client *client) aspire_ec_irq_handler, IRQF_ONESHOT, dev_name(dev), ec); if (ret) - return dev_err_probe(dev, ret, "Failed to request irq\n"); + return ret; =20 return 0; } diff --git a/drivers/platform/arm64/huawei-gaokun-ec.c b/drivers/platform/a= rm64/huawei-gaokun-ec.c index 80a8ba8b8dda..d4ce8ad6426c 100644 --- a/drivers/platform/arm64/huawei-gaokun-ec.c +++ b/drivers/platform/arm64/huawei-gaokun-ec.c @@ -783,7 +783,7 @@ static int gaokun_ec_probe(struct i2c_client *client) gaokun_ec_irq_handler, IRQF_ONESHOT, dev_name(dev), ec); if (ret) - return dev_err_probe(dev, ret, "Failed to request IRQ\n"); + return ret; =20 ec->hwmon_dev =3D devm_hwmon_device_register_with_info(dev, "gaokun_ec_hw= mon", ec, &gaokun_ec_hwmon_chip_info, NULL); diff --git a/drivers/platform/arm64/lenovo-thinkpad-t14s.c b/drivers/platfo= rm/arm64/lenovo-thinkpad-t14s.c index e7acb66b77f2..191ecd7f85b5 100644 --- a/drivers/platform/arm64/lenovo-thinkpad-t14s.c +++ b/drivers/platform/arm64/lenovo-thinkpad-t14s.c @@ -594,7 +594,7 @@ static int t14s_ec_probe(struct i2c_client *client) t14s_ec_irq_handler, IRQF_ONESHOT, dev_name(dev), ec); if (ret < 0) - return dev_err_probe(dev, ret, "Failed to get IRQ\n"); + return ret; =20 /* * Disable wakeup support by default, because the driver currently does diff --git a/drivers/platform/arm64/lenovo-yoga-c630.c b/drivers/platform/a= rm64/lenovo-yoga-c630.c index a8600a977fbc..cad40c58c55b 100644 --- a/drivers/platform/arm64/lenovo-yoga-c630.c +++ b/drivers/platform/arm64/lenovo-yoga-c630.c @@ -221,7 +221,7 @@ static int yoga_c630_ec_probe(struct i2c_client *client) NULL, yoga_c630_ec_thread_intr, IRQF_ONESHOT, "yoga_c630_ec", ec); if (ret < 0) - return dev_err_probe(dev, ret, "unable to request irq\n"); + return ret; =20 ret =3D yoga_c630_aux_init(dev, YOGA_C630_DEV_PSY, ec); if (ret) --=20 2.34.1 From nobody Sat Jul 25 05:29:26 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013070.outbound.protection.outlook.com [52.101.127.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 175AC3F4822 for ; Fri, 17 Jul 2026 11:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287347; cv=fail; b=G1xm8fTiEzh1H1gyVqC5w5/4RQ6rLXAsHmt8LiFAvn9hzAkv12rnveAn3d/8a8xSGdghMumi+FfsPcirv3Fcjc9YTs5tsApy3LmR13SyUIByAB3N2gCvC+t+Kwe6ShQuvpNVeLrR2zXoK4ixt6CJ1GcmAt9eXgKwDoK15O04WVk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287347; c=relaxed/simple; bh=ZeOnSXIyA05cmMcT+AIJ7aoM1tIHGUoWFy9F3KvpWiQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=IFOwrgCmcMMeK79yRZzhbgB1tByHh+7fzXJ+c9ZvXj57MLNHw0CrD80G5KlFMjX901wQBfZZEQSpM6BDAMR0Z8CyQG14zqcb8396i7+qNC9+g2NZIHFLTljPeA2fSXH228QZTgd7t9uFYOMftDg0bSDnS4o/xe8e2mFIBCnpL/4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=eGY/z3Dg; arc=fail smtp.client-ip=52.101.127.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="eGY/z3Dg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QFSuMo99aZpO3PG0SD+tF/5B2BOHh+6NQ/eONlN72PGJwonJBaO0uVGncxZlEACBv8DrrY8C7C4JzX5YSz+dDUgnGut6wgiQECWkOG+k032HqhzPOV1HbNpNr/wdrFqZGpZQUFrBhZr+86P1ezjq/IxIwRT8FFSMLFV+Or2Z5QNsDPEJEaj7TUKnQtHVsPH2J5it1wFNN814Cvp0451yy5+0xBGAm0VwI0VzBamwfCuZaQ+ZDY0VKyQtcOzEy6WeRLLL4gX87u6Vk+ZukUh3hh0fj2W1s8AkN6dDxjmJrhOBuCgZHGGKjUWasWF7mZXcvSx1yiSANAud0nJz2jJ4yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VHOVTR55WKT8iXJKmOqlf7sXjXpXYsS9DKjv60gxuiE=; b=RSziKFQmBcQTwgTYtcVhWBZC7DneekcaB5Duf2MwWIYtN9vKQp2BCL/AoZTfXTQwQ/H2nugX5sT4V0hS+OJ9zVXfu/FoWRTMn9eRgyBsyQROMDX4eUcIctZP9hxuVdLb0n5mbZyvW0u0vmJ4TZU3D/5uCrFAVAC5musSEBJqFSRkmj0UB7zu7qcAVyW3FcFq2UNgHOp2HgKN+l2JRCsi7f1FP74JXJt5eEJOAQ9TPur6gPvvLal0i6p0DGZQNKsgsVmGZqxk1dqWU8WTyC0L29jZJWFjjFW98gdIkLXYUlxgLPov1tjGHxb7j2GTeNqaqhAqfjOzpMJx0gK4ZqSlwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VHOVTR55WKT8iXJKmOqlf7sXjXpXYsS9DKjv60gxuiE=; b=eGY/z3Dgw3dAwjfZNGZm/Mnvfu4RaKvuu3kU/XFQn3FB15LYwiPZ6MpmY5w4HF3c9pexwDx5EA3jH6z0VGM9rYauR49AmTm6eqL0hbaJjTEkN0vaQqr2SlHDHQ10fo3xgLYMgBRC0eZfS/hJL7/AiYrQd0O0d8gc1+Hc++jn1SAMU/HWPQ88oE66V+LF5l71v4YgDBUhqQa6RyGEHaB14Jb9UjSBVGbJOyI3MRD1H+txuZCX1w2q808P4arcL4XzCtYsbJ9yUzUj9ejLagPYb1TthAOqlYf/rivUTS81U64YRclCJdzwKtfgCvhBiGIhWS9+oOMSOeFFDek/S05E2A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by PS1PPF5540628D6.apcprd06.prod.outlook.com (2603:1096:308::24e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Fri, 17 Jul 2026 11:21:57 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 11:21:57 +0000 From: Pan Chuang To: Benson Leung , Tzung-Bi Shih , Guenter Roeck , chrome-platform@lists.linux.dev (open list:CHROME HARDWARE PLATFORM SUPPORT), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 2/7] platform/chrome: Remove redundant dev_err() Date: Fri, 17 Jul 2026 19:20:40 +0800 Message-Id: <20260717112103.213017-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717112103.213017-1-panchuang@vivo.com> References: <20260717112103.213017-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0025.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:a::15) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|PS1PPF5540628D6:EE_ X-MS-Office365-Filtering-Correlation-Id: 882d8563-ff93-4e75-1b06-08dee3f59cc3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|52116014|1800799024|376014|6133799003|56012099006|11063799006|38350700014|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: fYrXA51XBPiwmYGx61xMVnHtDluEDnSS/D8uV+HcYFn5Ezbtzw+UPMzpHAfbcePHz5i8bfxgTEi+uslw2TfxDLIlIrAIInH3kkyPnJ2jL83gK17PJYhutQ+c0hCZbspqHLwriCJa+pJ8q8rmkY+hv7pVfnRJR2a0gSLnaybYGPOXXVCXXcpnBS/nddb+e/DSgALxO3+0FnB3q3Ijgxin13KPbLi1JeJ34V+J1h5mpdyW4VbmSjrDyw390fXhn5HfjZSi28XP4lIA/i/KVA4JjkKQ23EhSKuaVBOpEHVb8nGHzD3GEgUyRZLGcLDVqzKN99CZk3t93ZZYFQdupX/5nYjRVYlf8Z0QaipT2C9MLbRG6BKjH2j5mY+ddelqbJOmteMHPDjRLyeLx15Sf46yqCUamIhszcbS9Z1riaBHY9idY6mNPwtCrNVtp5rYBKshCpKlXkN0es1WR7l6Rw8yMGQ1Nj/bnmwU0KMSRBY2psPNZ856iPmlJiGq67P2fxBBHzTL6OyHmaWmDumHw4VQZutoOtT+mpi7HfchXo4pnja4el+ic1HtMMS877z1C8k2qSMyVGOvepDHiY5hI4e1h+1WfJuDFXzXaDyv8Ofn6ftUTRmkZe7vCy63uVFkBqQk0QwL0aZjVqSHU1P6a30xOx05o5zbN7IwLB4i7mUoh5/rebFjM8btnded1uvVWHcGUEjp1WTOmFXLh7JKmShC1N/W3uAd4kfB6RU9iTelhAE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(52116014)(1800799024)(376014)(6133799003)(56012099006)(11063799006)(38350700014)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bOtepuwbZf2BdkWr1hCd0Onn0m7EF020SZ27jVbN9ljIm+cJyJjPPflyW2jz?= =?us-ascii?Q?HfXgq4UQu7Oer3rufdkj2UQbhZHLCayqF+o9z0edJjJKyCS+lI6VmFYkh0yY?= =?us-ascii?Q?mttfEV/4N2YCnxRstE4JSFqYoEarXWoesoy2K+iRQrFCg9W2gFgQRRBcDwhs?= =?us-ascii?Q?voG2aIRDiXLI+E3v14AotImV3eRZ3GR1JO69stbUV9Aq8olKk7yE2Ie38LwV?= =?us-ascii?Q?VFoxGt8R4I1PPBUo5db9WNkg+vjUsi5fsZzpdfVMbWXBPd9BgznP2ugbDi/o?= =?us-ascii?Q?4K/+JBtFk5Pouc9Xe7cF61H8z80n7YXMW+Ff5CQqeWxvJ680KhQuP9QB38cy?= =?us-ascii?Q?BnyugifuasduI5BN/mKx3znhrtgV9vtzVpIlRI27aA7oUxapKjBsRbHKcWMn?= =?us-ascii?Q?WCS2ixPFkBCrusxK3NOhEdLgC7ussI2QRbngjzhALGL1/vqUIyd93XhZJ6Xe?= =?us-ascii?Q?dIWP6g/fOCBdmfOSFpNY2vH999zX/Gn4FE5/4SI4Sx0wp4oPx3DDT1p5HigY?= =?us-ascii?Q?xCI4HDFlX4FOEWZ7DFVgrBqxdARjc5aX+/9ZWhBd09Wk40JU3eXQUt8y8a1i?= =?us-ascii?Q?shfuaNFTv58eetdzznchwboHNWJ5osMAxaSj1JDlUgZWvrX8BNYVuc7C6gJT?= =?us-ascii?Q?rdfDyuPKJakFwSdkTqyUjsAfPw8qe9LairbjLL7Xj0gIBB49ho2ZaubU+TpU?= =?us-ascii?Q?73imOTJx4VYyFjBVM1B+ojZ3aS586GBp9Ab4Wu/JYiJUAYCdt2MLHBjwXgBl?= =?us-ascii?Q?3EG4p+Q6n940uSVjZpIhV0nCkC+dsK0h3r0CzHlWxeFgMq7iIEmq7JvNzNm+?= =?us-ascii?Q?WTML6+KTgHWbe//1fKLsL6Sugj8m9WoLYhftrsTSJUvP71hyy5YOSl+A3cWT?= =?us-ascii?Q?QBK03VxIqnKzgCS8ttcbeyevk6ysj9o57CPYFzW1a+NhMW3+MIcnlZL3QR9Q?= =?us-ascii?Q?5oX5y0CGQs1EjFa4358mt7TuOKSEJnm3vWqUaS7ryTFrM812rZRIbLCBDI6V?= =?us-ascii?Q?2hNEJdc4ZaQgh6wGkyq/VEw739eCEHeFxmeerPtGrfsIMcgceISqRxvQxhuv?= =?us-ascii?Q?YT3iHvQ/IFWkefl7eIT/XySaPXEipZoWMETldObKwAY/HHID4F9sUe0klyLU?= =?us-ascii?Q?2bp78xh/be2IkVCa2ecbrphBrGwTgCn7ZqMp412TAYRmmzMggjC4db1OssUC?= =?us-ascii?Q?CTtc2iRcc2aBENywC9KlB7XDPxTHugTpNfRDxBHhquVGdrydHGJBpWRG6V4S?= =?us-ascii?Q?1FgIOr+wPvVbl9tVZthsSJXKxx/2WNHKgzTg0hSAQPwgdO/vFN25T42YcE3I?= =?us-ascii?Q?7JBVvEqi07cMrl+ilSVuKfUpdpZDJLoIhzskuHv+QGPcWR6RCNgEvUXQsDwf?= =?us-ascii?Q?rHADXKtGJGDD9jGPDEUKmGqPWGfBpnQ5gbcZHhSiSbYVlkSpbUGzWyv0982Q?= =?us-ascii?Q?Jqtiak6iD5xGmu4Rl7ESBQLB5Dve4x/4sCVhRha6iDoTaN9WlsSJz14Fyt+q?= =?us-ascii?Q?kI18Y0QklXKY6wB8W8XZw+k8hzChawWHkbHhEoxcG27iyPfpjaPd9gTpHr3e?= =?us-ascii?Q?vldRb0FKco3xHf+b26tSQL/0tJ/pxdj5OO1j4vYEfOyyVTfCEZE2kUV8g4ii?= =?us-ascii?Q?1UNVb81xa7x5aXQDkQb5s4weEBNIZUIJKqAdqO33oO7jOoV+NEvE6/zk+JSO?= =?us-ascii?Q?mDUfC5BnwXRbLQsuE2hSqF2Zkmy/jL/WsAdsFVZZK0cdGtnH/HPPy6RNrOlG?= =?us-ascii?Q?ZkHgoG6+cA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 882d8563-ff93-4e75-1b06-08dee3f59cc3 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 11:21:57.1823 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1kDf5cfHpR3N3eqC7CvzVQwK8fVT07+/nEfKoJjkzjuovxpylLeBaTUIQ5vXEJnYaW3eb67sPiARNGTKkOe2Dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PPF5540628D6 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/platform/chrome/cros_ec.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cr= os_ec.c index 1da79e3d215b..5d0f5a9187b1 100644 --- a/drivers/platform/chrome/cros_ec.c +++ b/drivers/platform/chrome/cros_ec.c @@ -249,11 +249,8 @@ int cros_ec_register(struct cros_ec_device *ec_dev) cros_ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT, "chromeos-ec", ec_dev); - if (err) { - dev_err(dev, "Failed to request IRQ %d: %d\n", - ec_dev->irq, err); + if (err) goto exit; - } } =20 /* Register a platform device for the main EC instance */ --=20 2.34.1 From nobody Sat Jul 25 05:29:26 2026 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012037.outbound.protection.outlook.com [52.101.126.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82B4E3F4112 for ; Fri, 17 Jul 2026 11:22:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287356; cv=fail; b=aweZty4Die2+gpd2RWGELZrKh9Ez+Q0ZnhFot2HdmH/kh/lldd8S2vx74tLnWT2+4J3p816JCmZUgw4M+HL5TupI0Gjh5eJaXatcK0AnVNUj/CFfB04HFB+FkZI8gZg1RrFn/2iI9D1bIaPTHbipXrOxXR8gym77WO0Ylf2FDwI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287356; c=relaxed/simple; bh=kw5Q/SjAIQexOMXGPaFOuhUcHLpfwMn70+I5IQWtBcw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=CeM8pkXu7gpmwu4bAlRcN8TmpGvciHvJLTYvR1S8EALM5L5ONtOa8bgOFRC+RjKB9iN/sO8svXq0jmu3B5keHs4Xl4bfZdBPTKXIgj86JFZdcOtMP0424vssmvgYmGKFXUNlHf9/6u6CVZzR3bd5yhpKXlLf6Ef+j+4TXt3gMsU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=DFXZngb1; arc=fail smtp.client-ip=52.101.126.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="DFXZngb1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=apbWsljmM7QPc9/DA9xFtixtKBNU7GZWI9v3GGsvKCT1sI7rYH6858mDGdreMOkfqNJevUeuMhn7kL7qEl3dQpF55rU7ukl+kROkgSMj6LAyEoltwMuw1IzEr3JY+XSvP8rvK+YlLM787A1/xM6SpvLK3CVE2Y0OWyJREH1QCUCKnF7uEg56grJBz+EQuHWG86dXrqD89GKx1LY1VbtPlUMh5x3SJBLtdAsTe8ChxSYlydsC1Rtdupr/ksTplEH/R6q/6u5kAUDRyUmnrMfX+zTVzSSJhvXZR7uwNQDPpeQwkoXP8xcwhj+e7sDVL++DDG19XdxgzxCyZEijoQpVWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UZPs28bAZUc4ClmSHWJt8kYcgXrAB7jkRRceLCVWe8Y=; b=kxM6BWHKoPlWcFgoAK6dSErEbJzvj/OrYFN9BOpflvz+FJ2F0+nUyQq3DthWd+UZP7+F4MpvP+ouUIM/sjjiPRmCZfYSYlEfghxvD1wKahXcu034R1Z6XxG5vHpcO+ROl1d0nG6aTSOPRYm9LJSpoXbcU7koQSem7V1q01Sak0uocEzdopDG1VkrsNCE8WQ90zP6wCKbE1Xf4qofMMYa18dWdTL+Ausjhd2UfmurSkMVfmw4uTo/07QO30zoDNQslehJnmWZTNWpylL1KTpoLv83pBiAEwG1NmHUCp3exiySN/MnP1pD38OxHXOtA9WUaBH7telNK+PEltU1uXkYVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZPs28bAZUc4ClmSHWJt8kYcgXrAB7jkRRceLCVWe8Y=; b=DFXZngb1ejO5Y0kw0C8/TGe6OmuecuOzsmKVrQkfq5tRhUuVrsEtJ64mS7kyHuY+6CMBvDgeIiqKvgs0my13Cz+Kg7qHSgs5BELzNJAswMAZ827u82pdo7KNf+4kqK13Kkvx81e61ao58Ywx/6ejGUT3pBQDXHKsJDScsIKulwOIxlTMg1dFE0iKYwIM/E/yY80XzBJfmkzn2h5LlFL8JgLJE9nStb6RkqpnrzBmBsedTfxVNEiMfnLTRNKEkITf4Ih3gQzIAcpTfinkm/WkipfyFNb+0h30jbH9zdLLdehdyysVm2BxqmFfyqIeaEs056+1+yETAZF5EYd9EqUVLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by PS1PPF5540628D6.apcprd06.prod.outlook.com (2603:1096:308::24e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Fri, 17 Jul 2026 11:21:58 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 11:21:58 +0000 From: Pan Chuang To: =?UTF-8?q?Marek=20Beh=C3=BAn?= , linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 3/7] platform: cznic: turris-omnia-mcu: Remove redundant dev_err_probe() Date: Fri, 17 Jul 2026 19:20:41 +0800 Message-Id: <20260717112103.213017-4-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717112103.213017-1-panchuang@vivo.com> References: <20260717112103.213017-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0025.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:a::15) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|PS1PPF5540628D6:EE_ X-MS-Office365-Filtering-Correlation-Id: c97bb9f1-cf9d-4c4c-d05e-08dee3f59d80 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|52116014|1800799024|376014|6133799003|56012099006|11063799006|38350700014|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: V2/kUoDUdUc3xofknpmkPrarMDfxLzgj8uqpqtSbUj+JIklozN/cQhvwWUMIOpCwyACQii+nntYBMPfuVO9eijn2O9550KiWBKczj5TMi8LNZ60pvdP2STvrRTuxZOobKRSHn+AOwTixuqgxH5wlCVmW9xudpR9iPcqQlitvilCqoW5tzDmGWrkhxzWeKgMgnCOmPngUVfkMn7I4SU1NgQOq6E703lLqrYwrnXed0AG9UCUBzhxwf/fdckMkE7Xcjbn3+Cy/FpKgFFVF4ZXlrj9PuudN9/UITT73bomudZJWm4UPEa7fxwqIaZdLh7/ZoP3UK2CFQ6wu9hI/8DN97au8Yi0EaA2YlscpTxLyvVx5VSCzYKxThRE4ybXcxISOM2EfzT1YMdYzyd2t34F9AURlCLwCNFNM2y3Fpf0jomZOhaBIY+0HD8+LxMNPBQ9nWgH3FNtykEIz2oTo7QzrUSytYSVT4iczTv4r4+/yHMYAh5rPYjRewid1iAjIjAXdcoz0N/zN32kwGehfzThxIFY75C9/7AfT8TmBUjRsI0IFrYMaGXisFj/DdvyzDkF8CwuufZDbSSXdawlsfE61yQcLYMLGhOK8Z4xLU6R5s9tlmhaviw8Bk1REdWGiyGjhUtybCJwBA0PqaZDPiAWW21XEDEOnI47DXrsL7Uqug2ZufTPY/yl8tQzhZWD8WeDUdH/1HbgqcvWG2UHyvgOMZ40di2Mcf2vcFNEjLxh8FIY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(52116014)(1800799024)(376014)(6133799003)(56012099006)(11063799006)(38350700014)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M26Y0mwC6N6r7gBelHPbPv0QM5gq0KE64pEtpZ7bBc4u3lobaj6jiQb5pL0X?= =?us-ascii?Q?Y2bnq/XmXNeEisf8ebbYC7Vi0KXiqpe8kjIp48YkxbsRslb3S3fqzsM4YKyX?= =?us-ascii?Q?ujnhqHiMrC4w43sPR1M0KpxaKp4D2DbdZIfmWu3/f7OMNkEe0O9qMPfl45+B?= =?us-ascii?Q?muzppntEuTVufhzuKcsg0WJ9YXWdOG9hnpODOqfAOhwBt4IJutbbtnIFuafh?= =?us-ascii?Q?VQFkMA30xy++GhlS0JOkeI/XmHJl+BfclG7FnM9P8f3eTp2NWSVcfchf1/R+?= =?us-ascii?Q?oRl4O9Xuk0zpgrQzQOVMz2h5Hg0kUhITjVgJb0ofMyE0tPqikg1mOyX49iuk?= =?us-ascii?Q?shne1HVpsUFuX8KujbdBwwHFSe5gfItyLGMj8DG9mRa+I/CYqsWZJcxVk5c/?= =?us-ascii?Q?CP5yNLClVHnuCvpBBUWpXgqdBBG8laUvxuAXdsofZTwxwIEEryB2UZ+FhV/v?= =?us-ascii?Q?8ETbumEh093agemMaeTky69yoIn9PD4orDBaUOoq6YeYmHHley/lxTsJmWvG?= =?us-ascii?Q?uvo+0B8yxl/y+gXkJuugUz9FiCuwCC+MuCOouh6unJA9W36Tfas+Q3txxYf0?= =?us-ascii?Q?sO4tkBMSH/LAY9WDunFuRbu4jxbLQIrV92QPIzRFFf4sVsW3kWsMbuK391Un?= =?us-ascii?Q?mTNPsUzJl4OyUUDfV5I5KEmWKKw/P+ZwOPTOMFNno/ZfZuV+u0i6mF4wHSkG?= =?us-ascii?Q?gRif49KISB+dIzAwXvPFdmdpB7WvooWAaY9ZIiDJMLDObWPB0tfR1zURKjjz?= =?us-ascii?Q?nsilbPmRbsAnFE1W7BXrce8qdiM9InySEAhKQIklo9xtHyUDp73F86ysd1i3?= =?us-ascii?Q?sDcZgG4/kvnm+A6WDEf9zaT6aWfN7exVXzwO7/q2Vhrn5BmZO+Jf+8FgSqo2?= =?us-ascii?Q?m/IBo49GC69Ozk0VAkHPnwfNTJt3FdRHLW+DsFXIGUUmNj4X7GBTWRgRaMTD?= =?us-ascii?Q?Vyqo2iSc/SStfDNMdTcr8qtsxB5SIW5yFWTojz0kE6ra8VpPR3lCx4jngtHx?= =?us-ascii?Q?WRTBl+nf3823HliDoCiaw/Bjlzw8HmVFlFx9yNeV2ulQfnvGELEa4sGIWapJ?= =?us-ascii?Q?CYIQ40Sje8HbFTGTPKzD1QFdV4wB+RwGpw3iLG1LepnL46cVcv7bIvH3pxvQ?= =?us-ascii?Q?GaP2E8M/q9KeoJy/1NsrpuuAznosVEwrjRARmfWm6sUyPbpO44wD4UBlzGgM?= =?us-ascii?Q?8Osr+zalNtJP96k17juXA+IVbzaXwrOTINlQPBNVtXtxuQfsg9vVoYur1lGw?= =?us-ascii?Q?EN9GrU8DlZz6Btoeo62jEY9Bg5ZMOO6M/5iYvaQGRx6P5MUeIsqjyQKq5h48?= =?us-ascii?Q?VtDD/f/zPnaHcTYTd7n7zp2fXCFqevHGoDVqeBX4dqi0pLqNEQhn0arrh2FF?= =?us-ascii?Q?lE8j8bg3jXfMUi9Y2Z2d7/0Zg+ANNEykMgCj+DiIN1QvxFkfZNNRycUDG06h?= =?us-ascii?Q?El4DS5lht2cla6gseAw+r3L/AQOi+Y30QFIM+gd71pKTto8sUPGRrk0feS3C?= =?us-ascii?Q?EN1jLPyrxPEBCTLNKlNya1adlNlv7yWs53vvEjMzwalY4/5gO0N8QAkJvsTy?= =?us-ascii?Q?/UxQccVgt81dcln2nf6xDCb644pxWVlkBegaTLnBGer4na7HEKaFVYequTZN?= =?us-ascii?Q?Bf27x3VSEImcMAy0S/f/WEGiBfsthCVzy71Ler6dB1D5ASeY4gtRYy0AoT75?= =?us-ascii?Q?09OGYGHnOe4hUj6OZg+0ELKzMINZQcgPcBjus1pLguH7Eso5NMJchNx175NM?= =?us-ascii?Q?kVN9S3Lgvw=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c97bb9f1-cf9d-4c4c-d05e-08dee3f59d80 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 11:21:58.3816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dSVAy4kJbFNEr8P4fAO+J99YjiMnFSF1TBLWjt5cA4bqf2dH3N4GwvRI+JEaox11TQzNDhhsHL6FAVcmDt+aoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PPF5540628D6 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() calls. Signed-off-by: Pan Chuang --- drivers/platform/cznic/turris-omnia-mcu-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/cznic/turris-omnia-mcu-gpio.c b/drivers/platf= orm/cznic/turris-omnia-mcu-gpio.c index 4e430d6c3fc4..4ffe609be0dd 100644 --- a/drivers/platform/cznic/turris-omnia-mcu-gpio.c +++ b/drivers/platform/cznic/turris-omnia-mcu-gpio.c @@ -1079,7 +1079,7 @@ int omnia_mcu_register_gpiochip(struct omnia_mcu *mcu) omnia_irq_thread_handler, irqflags, "turris-omnia-mcu", mcu); if (err) - return dev_err_probe(dev, err, "Cannot request IRQ\n"); + return err; =20 if (!new_api) { /* --=20 2.34.1 From nobody Sat Jul 25 05:29:26 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013070.outbound.protection.outlook.com [52.101.127.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85B0F3F4DF5 for ; Fri, 17 Jul 2026 11:22:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287354; cv=fail; b=UwQrV838G1CR+8PInX2JVLZPejkPX2SdcPyRL3AoybMntPlha7zmtz1+r5PdodumJqGZfGbvH8oNbeaqAKALnXo09bbhoaDojGPSPdOAYZfNWl9YhEspviR3FEPVvSoJxJohVB8m9KsNlPdcgIPfbWnYUhOxP/AP7/bUtcjuZp4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287354; c=relaxed/simple; bh=wOa1hI1A8knSREbwSSotIaAjhAdzQWlefHKAvAY94YQ=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=fAxRyO9sFwnlh1z39YTmCGq7X8Gws1yqxHz59meuZBH3SUvPylFNIHSplFmjiti0K0D8in5zbOC0L/8xHWwY3O+O1Z+Gw1I4Bax6SDz86rTtn5c5MnVZTfAZ2J1ngvHOlynN0HxBmT8Y9sNnD3au8BlFfiZmRgFQrzp1GU24unI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=knSEHlF/; arc=fail smtp.client-ip=52.101.127.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="knSEHlF/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JiPkz4ZMBspSzg4prZNtChXMotDjBKGE11+U8OmThTgEr4jRKXyyxgN+brcEOsU/zve7Pkm6yK5xnnmFwtMutWg5qDeonG730bQ3eEpopjqGKFlFjY9y5S4Toi5JoukpeibpOwpzGhO+UCK/H65Aiyi2PNHcKQMFUUPykRGYilN63rS38s5pdpPICmenhhW8+HDiaOjxt9OJMuG4GdX25AUNjF3vHI1Rh76BFHkD7VUECIYCuL5dDeR4AduMdtFzB5+0cWzrq+3vIwPUytJu8qAOdmUV4P+McdO0jVvCmVMqCUHRP5P0em7oySerFA0BIr/BQ9yppmg97b8t/Ddikw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0MAP7yMYRdo+gY8zP9rxfB4h+ot9QhoA8PtThvCZCpY=; b=YWVwf6gUk9imfcRkfhqFLfj+fslnKmlOTJvjabyJxU6uotO0wubk9fVPDN0ol0J3z2I4eAJ89l9NF5G1VAEVd9pTbCAjf/XV/oFMtntnkztnf7ix/b7ZwEVvfPvRpcLDRk6YtfviH3BN/vzr4BPUtFezGM2zjFe16l8NJa7oJmANmdBidzZLVqhAHlQx3+0cWhyZPpYZdHJP8/Ua/4NpcJKjESv7Fmr4qQdFOSKKAP8MtsWGPUrN3xBeRb/9neZx/W6Cgf5abNamTMVKSjlJrgFalhg7klSHAcXnR1ysrV5+xuz4vwxKGoj5fQADLPx8lak6jV+XxJLIn7NKPTWtqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MAP7yMYRdo+gY8zP9rxfB4h+ot9QhoA8PtThvCZCpY=; b=knSEHlF/WSxFs2XZZ4SW5EqzB955bOpX78KNayftcPneMBHGvUU1ARZktEtlvBM0rcy+P5Z6NRi+yZSSN4+b5TYLgh5KR3XKKNHm06xorh48yE1v/qwpwOultCJmwg0sCmLUWjOyKWte2syI026jj8Tx04m6c2ieUS0sj//SjjCZ/rBsycdzs9wL7vrAIsKPczXfzMy1OITGQoD+xE1PI7+iI+d1UXOoLyEQOr3tM6vtG5EtGcpZm/XIg3kyhHSpMT9BpKSZ9A9uQMxDjTdkBXH5PyLck7FAJTfmgVIaLX+bG2zZ5VaE7xKRDzxoscTEF9nIm9Tn5kyN3D8/fztnkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by PS1PPF5540628D6.apcprd06.prod.outlook.com (2603:1096:308::24e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Fri, 17 Jul 2026 11:22:03 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 11:22:03 +0000 From: Pan Chuang To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Takashi Sakamoto , Danilo Krummrich , Pan Chuang , Bjorn Helgaas , Kees Cook , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 4/7] platform: goldfish: pipe: Remove redundant dev_err() Date: Fri, 17 Jul 2026 19:20:42 +0800 Message-Id: <20260717112103.213017-5-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717112103.213017-1-panchuang@vivo.com> References: <20260717112103.213017-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0025.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:a::15) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|PS1PPF5540628D6:EE_ X-MS-Office365-Filtering-Correlation-Id: f6bcdd07-e00f-4c4b-aaa1-08dee3f5a02e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|52116014|1800799024|376014|6133799003|56012099006|11063799006|38350700014|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: DE/TBqHlRx+J2/zV6l0jRjYWLIbNvAvVHawQN4qmzcaUfgQRt9pN7kFIQ0VX2zkhXSKHK1DctTDqZHiU7yQ/JAqk4ewupmq7sy/CM30aUpzkEY8aNGpCj1aWAjkN7OD7s1zN5+KGVpuMt3rIA1foWWkT1l1wF0lOjBeIhSphqZuVVvLsjangbCVg4+LQ6Y7pBYqLrW0SoVYcwbLQRU6dXampScMoyErFeNfMzOmFK0MtFhksiQ+Gjsd2Zx5PFBEgyoiR5o9utI8tYngz7j6G+Bxng5/IaMxhxu5LcVurOVEwVUFpo7emhMPyvbuQUhOzXjFYIJjJc7ONgxj/GCdeiTnVuMuZw0U7Df0vj1T3ARO3YzyrHIuafZ65z836j5qWWHI/FxJO2J3CBe+H9tDt95/eHvOSC5XbnfpCZQuFO1jRr6WB2mWAemqpaL20sFIZudMy+mlyOF5hgZHM03CRnT+cUIY8AN8XnaST8+KwEsN9IYlQFjVU7/fJDIPnae2BtKDYxiqabnKHFvpl4xAJNSFHOmIS6W4s4lsSIjGvRhvJOM0stOgPzJOpXnWB9ML3UEz+ckxkVKlqxmYkwiJ2g3M05dTXX4q2jJEZ9VgAPWni5icAKy0jIvGG9JFtZtOHCx3xptIwgwgKW2v1Wj+ARoFaPyUwcxJ6M9icd6Xs9ExMkzpGU5/8LXtDgr4PoM5jcSIbdoyhNGY7PzIVMbPOdWHTuTmHJoYKBNCXDsE+Rzc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(52116014)(1800799024)(376014)(6133799003)(56012099006)(11063799006)(38350700014)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8qkn2WstrWDILDprKBCCIsTBODbehHT0hU3py8MObJIIbDlBAFL7ekq/uH5J?= =?us-ascii?Q?W3H0xA2VcEAS7daOkGdn5gzSr9T9BzIjiLx77uJFGMMiiBeIFWVyNMur+S89?= =?us-ascii?Q?53/ZYRRvFA4uZxKUcUIETAegrbI3Q3yqAf5QDi5CgA4xbnjbVg2k7rLXgAuF?= =?us-ascii?Q?TFlAl+ylG628GNvS4Ti7XtormSBzvyyrwpGCf20vYAjYXDxlUAUkv4XLKl7Q?= =?us-ascii?Q?75l2EYGUdrH4WRRf29lHI+v6JrOfy+rf0RuEc4PUq+nnJdKgFap58g0lDxrN?= =?us-ascii?Q?fldOpWBo6IJYI8W8pgQhOsFp4YjkimGLYLKLAQu1KhicAJ8+C7um+sTkTyk3?= =?us-ascii?Q?apDH9XiLaR7KuVRjJxIgLw5S7GAdGyZND4EfddF7jcl+yLVIxUC1lCAFELan?= =?us-ascii?Q?7UsGdcbb7CVQhE0rw5t9uJuZsvV10CEQvrdkgdi6dOjQDJiO7Gew0i0oFOsU?= =?us-ascii?Q?3EHITIL+saLwqlMMdmWfW8h+kfsVvSb3SfZN3oMXcO0lwK3yDEVgVxRZ/jJA?= =?us-ascii?Q?UQ7UPp4oywu3d1kLjL47fy3gDixoFsf0mnkLTLWjo5Gy2jUxzCTkk948I3QH?= =?us-ascii?Q?lBvJc08ORe93Y5+8w8nMC8uR6VOP16hBo1+KK9NcgwFAdJcld+csAHdKyUeL?= =?us-ascii?Q?KBmiO++m5o5ukgGjGdYec68OmzYDqIfriI0ye0NG+vioJ+oIbZkeDEzZzR20?= =?us-ascii?Q?37tNaWm9xkQ8o6nDdugIxsbcEWdoNqEgAlYmIQfXnWjzRf+YwFi+sMVto4gJ?= =?us-ascii?Q?f+GtSFP/A6WmRFv8Ks450IwhR+GsLOM1tgyVEA12yz6Jmy3CDeqBae5ZU8Sh?= =?us-ascii?Q?yFXQ52v+hjxM/tqovjkjdiZ2OlAqWhoKNgO0//EKsQem52hf8IsVMY7bQjTQ?= =?us-ascii?Q?uxU3VsNczdZYrxLxU7yXSzZbV9XHTzcQUzIUUIVtVBcdSqyK0JvoEvtYvMNZ?= =?us-ascii?Q?NQI7pq9mHKgLAPyW0PxlN6puVTeZsqVlGmBjxvOQQpoXJYQGZUaeZkpG9Jh4?= =?us-ascii?Q?/5iV3EXr8L5A4t5KTIkRCvNUEqR94K+z9ehEfIPsI6DqGK5tsd4NsddmJKQh?= =?us-ascii?Q?ZgkR/WpigfqnM05bRxYgIFOsF3JDqxOJqx+yamIPgO1wFQqHwoUWx2i+gkIG?= =?us-ascii?Q?aI2j0O3booti3Mwz5//xxpDH1HAD94erQLdDk6aZOyUDiE60uDljkUK6BXY3?= =?us-ascii?Q?7hn3vPEyEdnxhppMzj8TL+QZNWD0NgsFikVOyIYSfTBeSDo1RsD/S507YZCb?= =?us-ascii?Q?/ImvfuZh/nWJ+ieP35Yu1pXB/mnluBpLX65yjQ6+8pS53QWpeDujpHhvo/iR?= =?us-ascii?Q?HpBTHCp0upQVklT6f7ASob89/gS5heLDdy3mvsuKFSlsYU5vlY47ntS2aLLM?= =?us-ascii?Q?c+w8ZNL9Ch++ZqWfwpX/AzchF1kF/yH13f/XXyqlDm3vyBFdqn3mL/Tn0oMo?= =?us-ascii?Q?SMX2BdByDOI6SDmXjTfk4rrl88KqRHJwhW/A6n8tWkxFYPhpIzHzjrIqT+Yv?= =?us-ascii?Q?zsqh8+re0Ux0sgLVxF+y3gwvv6G2KJKOfozArMRjrUtc29QnjJ56LAmahKbV?= =?us-ascii?Q?6gGpjayiw2RY94bKVkPs1dXwlKzuVnEfST9L+Ztqa2DdZn3/G6xqy9YXXyYZ?= =?us-ascii?Q?otRI6uVoAzDeaUQ9TPqCQouf7g0TKsZ2M6P3rfE5cOeyphcnPQ2BX/X/zHPI?= =?us-ascii?Q?wpjCdaWkMThW24/3Y2nPJQjHFvQdnWHHTgZs9D64aZD4lxxc/+w4/CjZMRJF?= =?us-ascii?Q?9GLtKxHHVg=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6bcdd07-e00f-4c4b-aaa1-08dee3f5a02e X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 11:22:02.9970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aAZzHud+hY7O2Yy30BXF8tLquZlHv6nNr8Zc9KPJPkw5WpWq08bGD9F18QCifG40YxzCaVfj1ZF9CJ0BUBqXag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PPF5540628D6 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/platform/goldfish/goldfish_pipe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/g= oldfish/goldfish_pipe.c index fa241ca8feb0..f4f25c0a011c 100644 --- a/drivers/platform/goldfish/goldfish_pipe.c +++ b/drivers/platform/goldfish/goldfish_pipe.c @@ -810,10 +810,8 @@ static int goldfish_pipe_device_init(struct platform_d= evice *pdev, goldfish_pipe_interrupt, goldfish_interrupt_task, IRQF_SHARED, "goldfish_pipe", dev); - if (err) { - dev_err(&pdev->dev, "unable to allocate IRQ for v2\n"); + if (err) return err; - } =20 init_miscdevice(&dev->miscdev); err =3D misc_register(&dev->miscdev); --=20 2.34.1 From nobody Sat Jul 25 05:29:26 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013070.outbound.protection.outlook.com [52.101.127.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44C663F12F8; Fri, 17 Jul 2026 11:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287361; cv=fail; b=o2WS3uJfXoLKxQG1DcFeDeaFkLBIAc4Tm9/pqSws8Mn0Bw0bzqba8t7KflEhCPVOP8Ff+EU0k2/nslocZP1oyfZKufke/4XKsfXVVWiaM0zRYiaKPX/ExERcTudNoFa1itD7u6p330nuk0aQC/U0B2fxlUFagNyzXGp5+zsHviw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287361; c=relaxed/simple; bh=gmj29G/XJEV1ome+nueYgL84GstEOzbGUnqrJUr7Er8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=pmV0XbIFDVl6A0rzLMotNV7o4arOB5qx0QPBE06j3mEYBOfqu158XKP5UYTqdnfp1LVNSyNJgZ1qE1io+Ty2W/G4zbpUiyzhrwrthMfJbiycDbbKQcgIVlHTEZZkeAHhwq1/tD0q6AKsnmoL8ZZX8veSbD++FfINLgKJVvkpDJA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=gKJ7xDmA; arc=fail smtp.client-ip=52.101.127.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="gKJ7xDmA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CK3ehFhhhgBnvpcrRKbV180fDz1+twbBRco4o5grjBUl8S7q0bi2K3KLaVWRw5wrEIDHZOi57sgWCWsgW7nZMCFo7cJrMry5UO5NHDp843Wcdr2c4wzAYlxAPXoCp5NTPOq+8CY0lPd3jah5a/2MXdJQXEY9eiL5QRAxi9o1jvGY6mp/4ft/osCQY0l/LSPznlNSfOYLRVpZMQljd0ns/653jrtdMvzzXRAwbNG0mTa/GtVQ0XoPdzW+cmokXoI3yG+QXDstoHBhPuyRR/mApKzs8kv9YyandJH/emNugM7rOxHQ2a6TgYwG37DUIkO0IZd2Hoq2K0TF4+iuIowAaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+mVpnBKlrI2YZhv4VyexqJfs38qBBRNCujDNwCjJ7RI=; b=kpfq0lj+OTkhLocmcWVzBsMMCDW90179xom8oHW8CMjRPLl2jhuz2crl0LRdQWvgLVj/zMDghZAJz5MtdY6FzCM6/lkGuoAwAYDrgABu3n8HPjBTHEj3uZDhzt1yklnYWgxSTX0ue8x8ZBt0Dks4DBAqE4xeMtoXs3PlrsDCFCVrMBQB0xZZq0JnsYB1PcOZ3Ij5GAnln3J9omdwc1buqGtYMNyL0WYW9r8SmkQCA3VLYNs7YFviCXgh4t62v1XSazc2qkIjk//3Ai4KJ+Y+JRU1J8U2Rie5PknEwfFOyq4Pv4VMwO3jQto9kz2WkXw0i+z0ojPZZGLzcTmtOlVPCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+mVpnBKlrI2YZhv4VyexqJfs38qBBRNCujDNwCjJ7RI=; b=gKJ7xDmAY3cmXppG7q/LNdmwfVOOFghN9PWxfPiaS+4xq94BZvU2ed0ifS5OT8zDQXbdz5pH+Xv6G17c2NxtcixzYDBCIn3x7NP6RNwgMHyVIc9A/Wbag6JvOfGaqN0uxYxMlP6d0DD2H6wq5zXQX9/z27nokqj//h2IopSjAAkWtAcD0Kb3DNCdZE1QHN7Be+z0HDmFSiXtzOKoP2k1PHNBEAtgwH2LoLyC4C26xFzKiybk30i6V/X350+6aj2D5PO0qkLRsVNhsDsOkcfwZ3Fs9kiUVGJ0FBXfwek7Lo7qgrn0ZOmAnIlao31aeQYVT1NMUGQuWkjVYCm08XdbcQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by PS1PPF5540628D6.apcprd06.prod.outlook.com (2603:1096:308::24e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Fri, 17 Jul 2026 11:22:04 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 11:22:04 +0000 From: Pan Chuang To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Vadim Pasternak , platform-driver-x86@vger.kernel.org (open list:MELLANOX HARDWARE PLATFORM SUPPORT), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 5/7] platform/mellanox: Remove redundant dev_err() Date: Fri, 17 Jul 2026 19:20:43 +0800 Message-Id: <20260717112103.213017-6-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717112103.213017-1-panchuang@vivo.com> References: <20260717112103.213017-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0025.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:a::15) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|PS1PPF5540628D6:EE_ X-MS-Office365-Filtering-Correlation-Id: df935e49-a68f-4a3e-5b86-08dee3f5a13d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|52116014|1800799024|376014|6133799003|56012099006|11063799006|38350700014|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: 9WE06L+jHsE/VMNRAR3E1pt0ZjA5T2WJp3+lsfb8mf9SitpFbQqsuksE8sLjz+oZrtfvf4XrmQ0+KFeZjYcP4OR6+q6qi8bWdM85JipWKUNGcci98jqEF0G2vxywkAN2Wf06iw8OtLq5xdz4p8LZEpfOrsRo2ShyO3m0jBOtOwuPfe7PeRKZ+y0QRFWY6zrmRhaEcrKSTSW4Csg35Runa0FsWeoq3MyMr0T/kGoWlug1/DqrA6lRAI7t1N9WPddFB8QZ4kWQ30fjEj/RQ8EuISYPZVPTdMXI4Z/TnVLoveJEN5K/+JvLh9C1Mtsh1OZcOWOKsohVmu7INbyA+Z3fp6xubyWfO3koDeHUydFeRSOy6hA2C4hS/YHp64tF883KOPAgU0HhOMBRqf4DE4pkNwWb/H8zktjCcPHVZunSPAUR2oHBHKXxiBZyaKc0UaUhIbGcc8q7yyWMC9GCuV4G9NmOhEIPOqQ5nHiRPyeYey/AaYAvGY+Oa81a9zAL+JwtQzI+2orsacsB3er4Rpy/x5vkqW7RW7CyxUzbvPlEyulx7pdiqN4A91ieN1NbUkV39dazbCD/8DZuDya4VvZCCs5Ra5hxf0aXjNR2tOh48bPYTKhEH+B7FD2qcDDcWMv5G5VqKKCXNbOYgoeySMusgQjK9VJF86LLDswk+dVEC3kk5D9s/4RBoq/ELK91/IRiikTSFb7ev8J3jofEpJfkcuk/d9y2E5pCA3fq3BJu4nw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(52116014)(1800799024)(376014)(6133799003)(56012099006)(11063799006)(38350700014)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?G5lXujO3yImGAmZLvCNibuy/KwN+ZMGtCkzHwQ1tQD0UEo7C2DobiEbjZ0yU?= =?us-ascii?Q?D+apt54Z6purJcdwvmM5tPnJsJgNV+q+Qf4lbg+yQbnGs8Xe0BahD9WqzGug?= =?us-ascii?Q?9YHCbBcLj5Pvetw7X1rQiGAGS4fSi8vvvbOASjCBtEBXDXlFjLvwiG4VNCHn?= =?us-ascii?Q?ByKrLx1D+kbbP4+KxshnTc1UKsYS5+o+qxUkzTTBYFOeDBdkhm9tjP25m8EK?= =?us-ascii?Q?omOW1UCw+0qNRZx4WhbIofmzqD7fYiTgFqk7Qtr0c8viIX8RPIddU91miliG?= =?us-ascii?Q?Zdj8XSxYloeKHoGVrj/9OmLQQ6TF478aT58skaKVUWkpy2f2mXSLkU5CjOHV?= =?us-ascii?Q?3vLfAKUVXkXkpFn+TpG5svTMHLesEWDJLGnC3gDnx4/Pf4ZMM3D3HkZ5TYQl?= =?us-ascii?Q?qt8R9FF1VS+9woo/1IRK3CgCgbM4AhUnLHA7mRjavVsYChbZFL3fCCNoYjU6?= =?us-ascii?Q?JFm4qLvqmDHI0ID8xigDqCxdWcUAGpYDMUVK6CTqXjLU0Ydr/sru2Lr50P63?= =?us-ascii?Q?rKvgJnWtx+l4zeqvOzRA6qlVF9mo2vHVopB7iWl8gcGx3/E6jaopxiteeace?= =?us-ascii?Q?BI9e0t6eP5GSdgX0ydY8RAfbqf0UV2iZ8in0MbF4wB9out3V0PTIs3Ju3feD?= =?us-ascii?Q?HTZtEAHxGYJ9iBkS88d+bjsqkig9SIAKJGbObjRYourAnfQ0UgwpYz2nTWCd?= =?us-ascii?Q?+l7nIZ2w+S4DG2/iYxfqWUpKiHOVgabsQTnwumfTZL21ht6vBFhczh1sqd8r?= =?us-ascii?Q?vT5fyTPYZEt5FdHhOhEWSI4zGXRgBNc4IDkVi4h/QRi/VkPL3jEWARYK/Qdl?= =?us-ascii?Q?UUEdgEo9GvAstqdacc27ybRDZylWHflid+RYtngs6prFt9YP6XElbuqUlDts?= =?us-ascii?Q?Ifw2Xb04bAhnl5Di/cI7bRK5r2ub4XX0OP9Qhw5hAK9P00P5/BD9mXpYn8Lr?= =?us-ascii?Q?82csp9bFtBALWD+tIz91Lbf6aj8EMWi4ppSG2Xm6LrFCmH+5VvVGxzmnMXoE?= =?us-ascii?Q?D8gg2bCaJ4HsIK557NDdQRaDLyRbQzfB/pQIVT0h6trHB8wXCSBCfDGctqrT?= =?us-ascii?Q?84l97HZsNZ5ea40/DmEHN1V4NkAm8gSZaudX5v+86kOHzdfy2IeN2WQVahZC?= =?us-ascii?Q?gA7rjwHhSfSxI0CPolhPZjlR/MsyY3+ir5GPWpjASYfOj+ZCcJaJgi3Pnn2Z?= =?us-ascii?Q?EkTF86Gs2H8K+ZnUvM1gj5ogy1rG+QA6H/t3ReLcOLt6ipXGBtFH44OwCIml?= =?us-ascii?Q?QDu2n6u5vXQSRMyWMhRXN3RHRguxpnauI3rAnfuYmS/WUJmV6L3aJlih97lk?= =?us-ascii?Q?GSAIxnshWs5JLaRe0DUC3AmXNdciYG6H9NUPRksKSAudY6HhqsXRQ/vzCDUu?= =?us-ascii?Q?pgDCPgwyTaUuMVYC+lZPrE6Ug2fKu+FY6WHERrJvm2YKTD1E86ZZQC1yroTf?= =?us-ascii?Q?iy+03em9Up1FnRtof+zTNqHRCrjYNg31h7usCDYqg5e/IVVNtie7PVYoEFG2?= =?us-ascii?Q?Mfclirvu504a6A50lv63NGwS+lUdyxHpfYOu85WpMz47IXnn4GllcKSKzfKG?= =?us-ascii?Q?OIL2SeS8fo8hgivZ6sLrKgRQFMWiL+nR7m3yhiFW1cFpmYcN39H9uCOWJMqn?= =?us-ascii?Q?rEwPdgCZ5ZIv5irSzdRDf7uHCNBt9tgzdK3sdD1GplmCsnFWeX49l3PQRJ9P?= =?us-ascii?Q?pzL/gUUgqBSpAIU3iEGHNtzwOR7csmxraSB1QYzcvyYsZXZj7u3GklIZOA2o?= =?us-ascii?Q?DpHd/2/xZQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: df935e49-a68f-4a3e-5b86-08dee3f5a13d X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 11:22:04.7013 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CpJPtX9QO9GF58u73khaTFqHJPhEPZtvEUrBHQEA6twHFoLH8zbyh6x8tqN0lh7vPblITGzYiTKaslY5RCxDCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PPF5540628D6 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/platform/mellanox/mlxbf-tmfifo.c | 1 - drivers/platform/mellanox/mlxreg-hotplug.c | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/me= llanox/mlxbf-tmfifo.c index 3c6408581373..fb1d424659c6 100644 --- a/drivers/platform/mellanox/mlxbf-tmfifo.c +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c @@ -1390,7 +1390,6 @@ static int mlxbf_tmfifo_probe(struct platform_device = *pdev) mlxbf_tmfifo_irq_handler, 0, "tmfifo", &fifo->irq_info[i]); if (rc) { - dev_err(dev, "devm_request_irq failed\n"); fifo->irq_info[i].irq =3D 0; return rc; } diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/= mellanox/mlxreg-hotplug.c index d246772aafd6..d6549dd21772 100644 --- a/drivers/platform/mellanox/mlxreg-hotplug.c +++ b/drivers/platform/mellanox/mlxreg-hotplug.c @@ -740,10 +740,8 @@ static int mlxreg_hotplug_probe(struct platform_device= *pdev) err =3D devm_request_irq(&pdev->dev, priv->irq, mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING | IRQF_SHARED, "mlxreg-hotplug", priv); - if (err) { - dev_err(&pdev->dev, "Failed to request irq: %d\n", err); + if (err) return err; - } =20 disable_irq(priv->irq); spin_lock_init(&priv->lock); --=20 2.34.1 From nobody Sat Jul 25 05:29:26 2026 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012037.outbound.protection.outlook.com [52.101.126.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED88B3F54C2 for ; Fri, 17 Jul 2026 11:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287368; cv=fail; b=pY1BQ9eL2CnsaMlxY5fH0xSdqYCIUgP4GJtSlr5GUJctIMzpFbezgDorjodPXI9dtsWROsxOcLoxTVU5d8bIzMLEHr+YPd0OyHgbg7VvPCnEK5MmwVRJPXcejQg3dZt2S3vpf1bvMVpLryCAJK6mGZdMZiLlDd0NMV9usFCW9dc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287368; c=relaxed/simple; bh=xW0r1VCcOfgn9mdXxQcVmf+ileb2Ru4J3strBjq9f5M=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=GDo9EHGuIf/UF4uR2M/6eWQ3+dJdYuCRtt0C+pXO4pacLzD7pPcB9yeqCzG1JJP4PfYDPdF0dcwEy4OpZSZCJavGv/NQ6J5lh7MUVr3X4vVALxaoCJOyz4NLupz6EvcVB/9bIlEkaZg6BtAsiRZx4Q+FmlfxwSOCql19LPn0j2E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=Q4Obp5g/; arc=fail smtp.client-ip=52.101.126.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="Q4Obp5g/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L983pSUMr9ojuS4AA/T93I4ctPItXipfQbOTchw8HAxJrWcNxd3zqu6dfKDGCVSl3i3BnxlwqvI4BcFI6ur+pq36vyGDca+aJ0HfdIubMLn0wCQKHL67euBjsF6opgkh6oaQmfE3QPygZ5uck3XezqA9hNwO0PoiKSpPvS4U6q7q/dz1hVlRaA1h4QK3fAO6xXTK2xlK7tJtKtVhJT2mp+HXJK+Yy0Eqc4mX0DRF5/0B+yRKd3iYQxRoLGUSaGJcCcGzltEUiLF18hyVnQwbMgAyIbDrFPef98ZCMhcyV9mnOVxG1P57GG8JRMMW09A3iajMTc3nbatN3GMADQ4AiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VE+FVmdnBf1PST0PzHLPmWGcvZRop9k196U3Ptq+c20=; b=qod23RHGsRFESy31XutIf7w6igTLc8Pz+++g7pDUGSdRAIsnq/vkkpRrautnzflyvDMpbW798LQsx5RYyWSJ9hKod6oJAIIbrMcHE50odXeBYu5pz0/5N3oVf+j/fOvtUX70WeFivZVrjCSeOovpBstvVDj4lQDjFqmptPbGXq7FGXogtQm2L08qDiXxcS60d5PrUDi8enug21kLrmBKVfrruhpwm7aKndrekeeZ9mDs4st6bONN7UK5vIYHvUyBc+wVjXPRO8XqR0Jbre7nFQirWvXH0S0IoOYrzL2vW5EcHgQBzH/b+ivoY+5pDGpmokvmdxZDSduCBeibIkelpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VE+FVmdnBf1PST0PzHLPmWGcvZRop9k196U3Ptq+c20=; b=Q4Obp5g/mz9HNOuIaQ6WlhMIfpwhKoCytNAuTF1eXNEa6viNyMGiBP6enhXC1ERzDpXiMXQqMOB55ei4K/bPkAfUg/R1e0jBsCgBJnHsI1HDBjM4qxCaTstByOJ9YHVLywX/95O9ZpqmRhO1YeNy9FznYOEiqLpBu+iTVGtR10EHmKgt9mDXcCxMD7XTX3cw9HCkzBhoJdQL8DFjfo28MFz16bmm0RBgJR1ZFx2UimkfFiEvRc2qvkLWeYkjrAoRlEb2VWtxrIuCZbI3E7PrtlWaHJ3B9Jbep1MhDITsJRr9VW8RN2BNUwQzskX/KPX/XVC752qZ6ukbMH39M7QjRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by PS1PPF5540628D6.apcprd06.prod.outlook.com (2603:1096:308::24e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Fri, 17 Jul 2026 11:22:09 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 11:22:09 +0000 From: Pan Chuang To: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , Jai Luthra , Stefan Wahren , Laurent Pinchart , Pan Chuang , Phil Elwell , Kees Cook , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 6/7] platform/raspberrypi: Remove redundant dev_err() Date: Fri, 17 Jul 2026 19:20:44 +0800 Message-Id: <20260717112103.213017-7-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717112103.213017-1-panchuang@vivo.com> References: <20260717112103.213017-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0025.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:a::15) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|PS1PPF5540628D6:EE_ X-MS-Office365-Filtering-Correlation-Id: 51f61344-bcb4-4c5d-85df-08dee3f5a42a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|52116014|7416014|1800799024|376014|6133799003|56012099006|11063799006|921020|38350700014|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: N7OnvY6QybFfovsGhIUV8HfniWReqePOQ3rgUkbzxGUKepdCuQn5zF4jfzQwQ57nQbznvnH7Qq17J8gk+ezamAlJm8haK9kaokMtGslVsmE0zo70sRdRRPJPxmYS1pRQMPgtYVnVWzLTYk2S/lRp8WWUyN7h93btqqPgaf95D0v3NVADe788gQAkERYuSIlCjuHC1hlTY+vWbaboTS/egigFb4WtA5W9BwuNySx9//AUTjoNQGCoJg32AyjJ8Oa/pqyWknkswqn5w57xgJWdC8t5H8w5a5k/tS+wD9rzaLS0KsacZYOlqMcmZEIMI0/+7GLQfUifZv0CNVPNkof76hndNRbRl7xd/Qx2/1bz+MzQyBl0O/i0xLT1uc0iAS24OYCKxePJumntDxTszfkb5Mr13kSN0nWnxKeL78gjiDQ6vbS7t48C0oeaJEAj4F4DAI05JBKvTzSckdlK0uhh8kKni7ne259TJzV6X0eTzW/IlDluJ8edJTEKheAmqqaIPvsbwDCb44qNweP6yw0chtS5+FjceazvK9w1vJ1R29+PVP5rhILxuvYUqI/+j2aVd0mWZdhy85uMxV5tvRIUNhmdoc/ZMqKjLBB7k/xS3ZIdwDZDQ0cnO05cBwZRK3ek84sSdPhIv1xMu+3WY52RVhk6W47WVKAgyF7XFw31IwVT9sZbnSFj2DBC5KsLYamGiLgDgR6plPWQJrTvOmNn8as1n0Rc2PBQSZp+t9EBeYK3hYRjUzVBU4ltOg4y1ObP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(52116014)(7416014)(1800799024)(376014)(6133799003)(56012099006)(11063799006)(921020)(38350700014)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kfGcD3+bJSuHZKQ71rlPbsI2ArVGirAYZdWOWSS2UwPyocEvvxMkE7pxbYQu?= =?us-ascii?Q?XXP0/vNCShdiWmX1CNykEcTYmYUqQHTZT4aHaRBCN8WPTM9QPHM8YopnkM2L?= =?us-ascii?Q?xVpAiWcI9dXTfrSnuwIEA1ScHnF67PyAE57TU/1c/JkglRLB3UL93VraeRkQ?= =?us-ascii?Q?WyUFQU+QB4jOux8Z9ZkN8uIuHmHdwiz0gppkeEEf9eOKqfrKVToNNPsCyvvB?= =?us-ascii?Q?3rRG82qFw/kk3fXF/SLt9MwIui+SaAGpYLK0rw42xOxKFH9mngILpvxz7+/Z?= =?us-ascii?Q?nFoPgBjWDDB1hhUYs6QCZzVLxJUN0WA+B+/s7mEtYCnvxnVlgcw6IoeqDvV+?= =?us-ascii?Q?l1rHbSTrl4o1SFOR8yiidbn2l6z+KV4gsVoPwJfe/CrHtSt01UYa67Iz0Gx5?= =?us-ascii?Q?EgpFT+XK6t6lOn9RZ+/1xHHSMkCzoCcVVAEhbqfxaNAqE+ZuAKCE/yKWktQx?= =?us-ascii?Q?rZIT8/W48s/1rgG6vVSvMCdyyf3QgSxxQbHRLerd/t3CBhM2yIXwU+7sET9g?= =?us-ascii?Q?y1lgWcq0fKd1DjWuDTiiR/b/hPb3UAThCUbexQsYuCWr2+LWIBaZpRhi+QmU?= =?us-ascii?Q?E+PhfZfGXW5GRCmdilj59OFLNXpPdtY4YzlM3MIDwshhV39E2Mw8PKQcSUht?= =?us-ascii?Q?BrgXFiwbQcXVNpdQ2jORN/XykjjaEZaD2oLXab64NrMSdsza9LdpSZ3ZTUfN?= =?us-ascii?Q?I0Rbn+j64HFb84p1lvdA+5lmdn52845WkUVWOG3f39XlXc3otPav1BIoyeL8?= =?us-ascii?Q?OGoheIe8IA/6SeU/38Ez6ezvuHWcfmd4bgcK4XmZM5PVGEz49bXL10i7bk/x?= =?us-ascii?Q?OWzEfoDeoHx/oncpgQmV3cJTN9ydzVebFrvBfla05OL9siBoB1rZMA8ox/65?= =?us-ascii?Q?0cXQ5NwmB74KwvF+Ozz4PDoq5xJp5SQHaYTiOsRMdz3zM3MxkIK9QIOkGZDP?= =?us-ascii?Q?pQgOldJjwDfpkrCQFbdmofXyhtq74Cx62hnKNBEKicHKVbNK/+wcagzlyHj0?= =?us-ascii?Q?cYkltWd7K0EV2MXeVCjHUbKpbpLyG4a/QRr0iFLAE5B5UC1DJks85K8TW/kt?= =?us-ascii?Q?FyWgFyhzeauPQWCBvfyufTb0M3b6ZCWIXVg8Xvt59yNZmUBQWgdIqaiNWIT/?= =?us-ascii?Q?JuAD72ZORSGgSH7y9y75bpT4MPukrhJyfYyhM4Ah4BIo/JFHwknFNegjsFea?= =?us-ascii?Q?tzsd5pO7uxbkJieoOCGhhxIhcAZesSxGYo2A0PD5zbbSlp44ftHNvZzPH1ts?= =?us-ascii?Q?CJYx6ReQKt/aU7oE7nyPEuks7BbnunpnzLzJYLJAjWHnNzj4+K7skDZaAkea?= =?us-ascii?Q?ZBorIKkLvv2B4D4UJkSy9uH2AYO9h+XoifzD0oZeAaQfvpYZbwA/5Izbmu8p?= =?us-ascii?Q?F617tYAuu0fFkHzR7yxqEw2A99MNBLGMaToZUtoTAOqNzFIknU1g2o1D0qO7?= =?us-ascii?Q?VziWLvFG7zBlCTE+d164k/RAoQt3AUfuO8/jU/cFjQDd1yVabghOM2XIzLd6?= =?us-ascii?Q?3DXVyRgTa4hjan96XXF2clFtzcGPJl4zHllY285z7kYCLBOOPP+Grfgi4ldV?= =?us-ascii?Q?piSvVOFEWFUf/L/ojKrYry0e8+fbbqlO1ZrAGKw7bqkAKcAbqrWdgy+2tmG0?= =?us-ascii?Q?+9tGrYySlynRXLXG5vyvh+Io1Y/6lyh4nEPvPcDH5utkSefI7oONffbphuAV?= =?us-ascii?Q?OQCBLhwz8SYxKaApgk+XTkbfiBWNKR+2ZHwSatRbmd3ou5gQNyIpYjAkjxav?= =?us-ascii?Q?zxoPtcC1eg=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51f61344-bcb4-4c5d-85df-08dee3f5a42a X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 11:22:09.5657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xZGzFVQgYkmXX2JRsi7kVCHnp/5tPCtT7u3/u9KI85HYP+s/vAwn9Dwj+Tn38i+Owlxu/TpXJns7wpjzOWixIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PPF5540628D6 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Reviewed-by: Stefan Wahren --- drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c b/dri= vers/platform/raspberrypi/vchiq-interface/vchiq_arm.c index e78641703252..9490ad88df0f 100644 --- a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c +++ b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c @@ -257,10 +257,8 @@ static int vchiq_platform_init(struct platform_device = *pdev, struct vchiq_state =20 err =3D devm_request_irq(dev, irq, vchiq_doorbell_irq, IRQF_IRQPOLL, "VCHIQ doorbell", state); - if (err) { - dev_err(dev, "failed to register irq=3D%d\n", irq); + if (err) return err; - } =20 /* Send the base address of the slots to VideoCore */ channelbase =3D slot_phys; --=20 2.34.1 From nobody Sat Jul 25 05:29:26 2026 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012053.outbound.protection.outlook.com [52.101.126.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC4123BE627; Fri, 17 Jul 2026 11:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287362; cv=fail; b=Cq4t+oim6evIYivkM5gRED4267X9KIeLG+dCTzjqP77xcadxhyulmEnrwpijErY5iHcJDKGDi1XG0i31TlbaG4wWTYBzDANCPMXZjj1R9U97HUr3glZz49+0+Q5YT/ftXDg8fVZSk86RV16egm+CpoLUQUGiqR/guNx2UHOK8DU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287362; c=relaxed/simple; bh=qweM8MU9p0ZOKBzcsN81UAs+twUCR6LP+shvSq4hQuI=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=YPeuVbX2YdFllXqN5V3IOGQQYm0qEPZslcU1wKoojnMc3NyKloElejgVV442gMYWKlHqUscF5RCu0Y//I2pjCqPT5/04j43ZIMC5//wlaO5WTYVw2G5HPK/1KrtUE91JP7qD4sZ2eFLUtUNQd5Kf/Cb13R62+MdlxYUfCal/R9c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=h41H4Za2; arc=fail smtp.client-ip=52.101.126.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="h41H4Za2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bGbSaEQrl3smU57R6lm2DAf0s6vq+yB7X0I+XjNlq9ihChidCMCEQS1AhHn5J3CucH1xqHEzkw2P8tO9STJhmBoLqN+f9EVXx+Ipchr1J0tdp9HUHWRXSo3Odk52AwM8zDYXPnX0NR1rdhUEZpi9MPR5cXe0Clfy5XhVUFr+kHgzJYb7Guier5q/xhmtyCd3McjvLVf8bbHai3sp/CFOfCiwkbqmLN1IQifL6h4aHbdEF9skcpNAd6q1MTZW4CFfoemVh6dXXC0yhBr01WDmTAuYj+xXwcIW7YFvQzTmYqflIV8kk+k7yZ1E2amm8ahd+pvvrq3hsXfZu2AcdQhQ6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZXn08gmqQdSzVDneXAECvqkejPF7HksHYGcMzsIOSs=; b=XZQVWixVxhOPht+QU+XXcXHK7/6d01jxn1/Dd171iM1/heCThDnLC4aZRNSU3CmG4qDhxWe0zEtRFNH3tlfZ9LlyN3jlE0RU3femGGNMRbxFp6pgvGfpoPkuQ5Z4QIZ2zpQswx5alNY7FUcfqSzM/zu+YoRveQHp9wW/dE28+D2LUVlJNzgWraac1447AAZKRaJYbMZgQS+aumYQftQ3BwHchcRQnj6QQRzTgHH3EG5uz1GNotHM2JdIrPsbOX+oWMV6MY4DJQO8m3Ztpitmw81E6l5PTTyd+I+cdUpPOfTXADMLVtj0SRafZPZrYcmYzn++SG7PLYIpv/6NIl4TkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oZXn08gmqQdSzVDneXAECvqkejPF7HksHYGcMzsIOSs=; b=h41H4Za2Sptxd3IlhBzMbnE4b3w27oXZ8OxYweA1bI1fREdbiUYJ179Vut5YPZDvyLlOOss5X5iGkzcJ2dyNaZR5Rj75exI0HjUDXwCtxxRBbXYRoPPQa1PLX2ZVV7skOBot6YlVCbWTUJ8w/fuf+nx29aV7uQwoCDpsxjRppesz9EJ6yYJH59Fx6KPnTqcwDZOL5ut/AW05S+ZxqntDehgQKwR5pPYSWyKHawXlVWQbhfI2dZj2lCEdoWrBwqXE2GkIxNKhoy6GSY/TrRsSV+waknDGoB17eqsS7SBhaTL35CnqxLNcCXOiX3IteZqBL1hB4zHYJBokVNAqqZAuhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KUZPR06MB8075.apcprd06.prod.outlook.com (2603:1096:d10:2f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 11:22:23 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 11:22:23 +0000 From: Pan Chuang To: Corentin Chary , "Luke D. Jones" , Denis Benato , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Zha Qipeng , Danilo Krummrich , Pan Chuang , Takashi Sakamoto , Bjorn Helgaas , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Bartosz Golaszewski , Thomas Gleixner , Sebastian Andrzej Siewior , platform-driver-x86@vger.kernel.org (open list:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 7/7] platform/x86: Remove redundant dev_err()/dev_err_probe() Date: Fri, 17 Jul 2026 19:20:45 +0800 Message-Id: <20260717112103.213017-8-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717112103.213017-1-panchuang@vivo.com> References: <20260717112103.213017-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0025.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:a::15) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KUZPR06MB8075:EE_ X-MS-Office365-Filtering-Correlation-Id: 70dab3fb-fdf2-4d41-6c0a-08dee3f5ac4a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|7416014|23010399003|1800799024|366016|18002099003|22082099003|10067099003|56012099006|11063799006|921020|38350700014|6133799003; X-Microsoft-Antispam-Message-Info: dgaoh5H2gI+ZetO2UkBYRWIpv+3BIWBVQV5saX7+W2bpy7FAF1DWB+kubaalzargSefzQMCISs/DcALk6tT23uC7sXqa79caw8P8LkP61XRhBYsKGUKk4RdEwqnRyIvYNYypRE6gF0/GHM9igrVGLHaqMGJsKNieQGjDZIPBGaaRpYBQOJrRiWfL7Uoc7qL/IXVDh0WFmTviv0eKDKKaOxQNRWn7NYh+RMr61VeLDCHCVPCjRJ2mfT3VOkUuTamDHWiKOGcgVTgnhys3WK7tttiZH6/0EysVbCi6vCbNhaKa86XY/yR9TKrUA2X1SFpVgBBiK2oJx6JS1ww1YhFCOIM20FCEW694XX6pbDrI3XsQ8CNOHckXms+LwhlZbWnPmHRNRVc/AAmU/wq3/cPQtxk15CfOTgwNhQaENe6EAJZDoDqWtimXO2Li+uR4h8Y4m68V1zxnnIx/j0sG9op2ljHrQQDOwtzdJgLmzSqKeDH1Y3ykiAZ8X/fFx224vDYIQOzlrnLmrOtgRUf9vw1TSDXCJnDKdjpZXKIMDiwCtmg84kc0H2Tllplv9zd1j/YHuAs6znLqHlPeJfiFDCOUyCkzIhgv6idtdLSSVPYDC88i/H9DHYFio0+WhiLeaK7gN3Z+aJOmdQUUggCnBBHL4yX2k5lSI5FuHrnPCzZToLXed2LKxkLYdpPemX3ikYRUtJ4ww4z+BpLsjmjHm5dJQS1DdOxJsaO8XSp7RMoUhet0SJukesdT3okGprJfzMKU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(23010399003)(1800799024)(366016)(18002099003)(22082099003)(10067099003)(56012099006)(11063799006)(921020)(38350700014)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qkX0252rtQHdNcylVe25H0YJaRSNX7ZbFk/6MB78aymwShRsQ0Ka1vVmNWFA?= =?us-ascii?Q?zs/0Hm1nkDw1/cYyq1fJuTqLXC5wQ/zFv0LCFlMtqhY3Xvqbr929FewPbqwq?= =?us-ascii?Q?0HaM1kd2ZKXG/fkqGkewA+S2Rfvi1N4QNVatRdYvREQ29/pV8c+PvCAt3M+H?= =?us-ascii?Q?lwRIRXTSmfN0brbBLfbEfw8xOI24VYvX7MBr664Fvh1CFYeID9ZYpHIXMYZS?= =?us-ascii?Q?ZwijR+J0951iPuRVYVBkFBCnQVoZwqM90D/wiozuO7XgrGhYUk8BDx2+LKwE?= =?us-ascii?Q?2pB1ZWzIvpoFz+AXoD/jdeZaLEGIB3xzSyZQUD8YrDYwY6Ar+87RoXDaI3s0?= =?us-ascii?Q?MlrYSmaMtZjYU01bnpnI9eY0DfkcPOkhJTIvD+xoJuyfCE4EH9yVdAvnQL0m?= =?us-ascii?Q?v8VBip/TnA4erMwpw3EPyuDNMt4tTMmU2IscGXQ5ylIAh3pkWlw6oXOrg4mS?= =?us-ascii?Q?5cmHukSltbeEF/xTZyG9guC+WHeFzeqPqPAM8TRLTJqilfy6Y0/N4jGY3hcv?= =?us-ascii?Q?VGRuYAasZO00kiX6Tx/Zmo6jcoVtVjn2iliU7vaSsFxK64ZGaFOQKBJzQunb?= =?us-ascii?Q?sQn9xTrLpPDp1M9ZyhVtRTEkx+hBl8pJzzdBleqCgzaEPzcbhK55QNXXWZfz?= =?us-ascii?Q?JBkyZcb7NbfwyuIK+B3LE29R7pTCiEpdJ0s+zcTe/OTD8xEEdt4bx7iCyZ/4?= =?us-ascii?Q?5NOyKG6TMF8j2/MMyq5zlyXa5F4l0PnJCcq5VzfOU3cyHTmCG2Tdes+TUXS6?= =?us-ascii?Q?yj4bAWAxlC3lWYkSzjG0YyO9zZYUfqTfpEMHH9MmB1lnU854E5tWu1x48xk2?= =?us-ascii?Q?BvKji7i7ig3Gvgv52F9ji2otch0B3oGZBX5IRpDzzvAuXeTyC43tsyceM0to?= =?us-ascii?Q?liu7VJvnKsUyDoycpE36wSmuxMSzx7DGfOG5qa4HymUPPgkmroFZBMt2Fpiv?= =?us-ascii?Q?3irq+jD2RC3xBJjnnnmjSeMvZcj0oLqxt8Y9ZyXO7E11CJrXA3SpKSeJkK9K?= =?us-ascii?Q?PlcPKnSP7Umr1zBa03rVi+6cWzYVAyFZabYL/QoJXhK/CDHCTQyRg99FBVzM?= =?us-ascii?Q?xvNoL5x+sPqtrlJIdM164ZrLPspNrFIpZeL21KUtToET1iYLar3nA0+0lzJ/?= =?us-ascii?Q?TPl40IkkltvdY5BRJ6zeC/a2mhH4Ieggj/mWoydgRdCFYEkTc0/sNNi0wGCj?= =?us-ascii?Q?Nnp/MfEX90fWXb8Up7hu4D/sNSNOrN5Mo4jyehzIF0r0msCa0Sb0Vv4prmBu?= =?us-ascii?Q?3yG06aO/8a8OSf6cKcRFeQ+0t8Jb8065vy99xDnELhkvlPT0nSk7/I18tbFu?= =?us-ascii?Q?b3omBJLYBfbf3n9ZG9ssxCz+C4kMOUpKCItd7Pmbk5Nc1CNCH7kX2zVcv2a6?= =?us-ascii?Q?jQs+saM9upIZjGqZR4lFA4rney7iSUHCAvcDxU24qMwhelnLE4LZS+hIzptW?= =?us-ascii?Q?5eMvXrQHewEPyIVG32UN40uL3oGE8gBAUE5CHdLH5Yn/5fLfCtxcCIsMbdu4?= =?us-ascii?Q?g8mK5W/DM2seu1Kxo+EgM7mZKzdkhh+bTRvdaXcvV0A20XE2PBi/RSnPIoqi?= =?us-ascii?Q?olPS39FG2o4yZhRI2NA4hMwt4uj/6r8CKHs/ikSfMjZNVPlxYZC0BOx72AK/?= =?us-ascii?Q?sJ7GEkUrdngBFuaCpQ4EE4NLpCT87ynnzP1UOyWnPXDH9MZ3HxrC1SRDXndk?= =?us-ascii?Q?Jfqn3GTYzw67RqpyRsTeszqAKEK61c2bfTWqE6xbiYETD/iHD4oDhcJxmv/u?= =?us-ascii?Q?ixN1p4gGeA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70dab3fb-fdf2-4d41-6c0a-08dee3f5ac4a X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 11:22:23.2511 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: urMKaKKovLg5a8f/sarK0W0A2hTtHIgOUV2x2xVTiu6dhSEfR9lCrISkvaHfVCZoYjOpB3ctxUQ875StBkZHmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KUZPR06MB8075 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq() automatically log detailed error messages on failure. Remove the now-redundant driver-specific dev_err() and dev_err_probe() calls. Signed-off-by: Pan Chuang --- drivers/platform/x86/asus-tf103c-dock.c | 2 +- drivers/platform/x86/intel/bxtwc_tmu.c | 5 +---- drivers/platform/x86/intel/bytcrc_pwrsrc.c | 2 +- drivers/platform/x86/intel/crystal_cove_charger.c | 2 +- drivers/platform/x86/intel/int0002_vgpio.c | 4 +--- drivers/platform/x86/intel/punit_ipc.c | 4 +--- 6 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/platform/x86/asus-tf103c-dock.c b/drivers/platform/x86= /asus-tf103c-dock.c index 92466477de9a..3be5b96de548 100644 --- a/drivers/platform/x86/asus-tf103c-dock.c +++ b/drivers/platform/x86/asus-tf103c-dock.c @@ -772,7 +772,7 @@ static int tf103c_dock_probe(struct i2c_client *client) IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_NO_AUTOEN, "dock_irq", dock); if (ret) - return dev_err_probe(dev, ret, "requesting dock IRQ"); + return ret; =20 dock->hpd_gpio =3D devm_gpiod_get(dev, "dock_hpd", GPIOD_IN); if (IS_ERR(dock->hpd_gpio)) diff --git a/drivers/platform/x86/intel/bxtwc_tmu.c b/drivers/platform/x86/= intel/bxtwc_tmu.c index b3666704d85b..73d7f71b2fd0 100644 --- a/drivers/platform/x86/intel/bxtwc_tmu.c +++ b/drivers/platform/x86/intel/bxtwc_tmu.c @@ -64,11 +64,8 @@ static int bxt_wcove_tmu_probe(struct platform_device *p= dev) ret =3D devm_request_threaded_irq(&pdev->dev, wctmu->irq, NULL, bxt_wcove_tmu_irq_handler, IRQF_ONESHOT, "bxt_wcove_tmu", wctmu); - if (ret) { - dev_err(&pdev->dev, "request irq failed: %d,virq: %d\n", - ret, wctmu->irq); + if (ret) return ret; - } =20 /* Unmask TMU second level Wake & System alarm */ regmap_update_bits(wctmu->regmap, BXTWC_MTMUIRQ_REG, diff --git a/drivers/platform/x86/intel/bytcrc_pwrsrc.c b/drivers/platform/= x86/intel/bytcrc_pwrsrc.c index 68ac040082df..1f39850b80fd 100644 --- a/drivers/platform/x86/intel/bytcrc_pwrsrc.c +++ b/drivers/platform/x86/intel/bytcrc_pwrsrc.c @@ -221,7 +221,7 @@ static int crc_pwrsrc_probe(struct platform_device *pde= v) crc_pwrsrc_irq_handler, IRQF_ONESHOT, KBUILD_MODNAME, data); if (ret) - return dev_err_probe(dev, ret, "requesting IRQ\n"); + return ret; } =20 data->debug_dentry =3D debugfs_create_dir(KBUILD_MODNAME, NULL); diff --git a/drivers/platform/x86/intel/crystal_cove_charger.c b/drivers/pl= atform/x86/intel/crystal_cove_charger.c index e4299cfa2205..425c7eb32442 100644 --- a/drivers/platform/x86/intel/crystal_cove_charger.c +++ b/drivers/platform/x86/intel/crystal_cove_charger.c @@ -135,7 +135,7 @@ static int crystal_cove_charger_probe(struct platform_d= evice *pdev) crystal_cove_charger_irq, IRQF_ONESHOT, KBUILD_MODNAME, charger); if (ret) - return dev_err_probe(&pdev->dev, ret, "requesting irq\n"); + return ret; =20 return 0; } diff --git a/drivers/platform/x86/intel/int0002_vgpio.c b/drivers/platform/= x86/intel/int0002_vgpio.c index 562e88025643..96b36cfcd9e4 100644 --- a/drivers/platform/x86/intel/int0002_vgpio.c +++ b/drivers/platform/x86/intel/int0002_vgpio.c @@ -208,10 +208,8 @@ static int int0002_probe(struct platform_device *pdev) */ ret =3D devm_request_irq(dev, irq, int0002_irq, IRQF_SHARED, "INT0002", chip); - if (ret) { - dev_err(dev, "Error requesting IRQ %d: %d\n", irq, ret); + if (ret) return ret; - } =20 girq =3D &chip->irq; gpio_irq_chip_set_chip(girq, &int0002_irqchip); diff --git a/drivers/platform/x86/intel/punit_ipc.c b/drivers/platform/x86/= intel/punit_ipc.c index 6d770b950dfb..a3d2b0b64135 100644 --- a/drivers/platform/x86/intel/punit_ipc.c +++ b/drivers/platform/x86/intel/punit_ipc.c @@ -250,10 +250,8 @@ static int intel_punit_ipc_probe(struct platform_devic= e *pdev) ret =3D devm_request_irq(&pdev->dev, irq, intel_punit_ioc, IRQF_NO_SUSPEND, "intel_punit_ipc", punit_ipcdev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq: %d\n", irq); + if (ret) return ret; - } punit_ipcdev->irq =3D irq; } =20 --=20 2.34.1