From nobody Sat Jul 25 05:27:15 2026 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CB2E3783AC for ; Fri, 17 Jul 2026 11:03:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784286229; cv=none; b=m4pqGLDd2ENr40bMZEeiQj+iIOLk171ntTSuNiA+m2o0XdK2sOl81Kr/CV0xNvqV4IQz9gnow+zgPJ2R5oK+Z80hhm4/lFqJ5s1eXp7m3/islkiGmCzePPzXvPEncI2ybZm1u1M4inqEpGkbfiSayuX6XNzcIhsYep9LaPgRUmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784286229; c=relaxed/simple; bh=jA79gpOkviouKGGXfJkuzjbm7sgvQfwwpHf05WgGl18=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dO/Kx++oNgH+C/wIV/rOX/8yETO0JCNZQcNmypFJAJaCVq08SeQNMuCyiRKDeZa31aGzEZN2Mk0sUtSwed7gFpawGO3aazObWFam3nj9axLYPgWUUZ09cNEi0QnUYkLbR2TVFoRk4KigZG57bWkF0Lr32uCLCEv+0zXSRkAFK7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nakYVP1/; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nakYVP1/" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-92eafc94c9cso602472685a.0 for ; Fri, 17 Jul 2026 04:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784286225; x=1784891025; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pJUH2+9UwKuoF8Z5sAeBhPd3xy/csT/L8ZRS5KSSWKw=; b=nakYVP1/U/lgDxRh8JSSbnhxgiKjpV+p7U5vb+K7bdoTTQqalJWNIlER3qnU7Q8nkt QRNRG5HEE2f/NDopB/Usatyaj9AbEPx0D62A5TjHBm++HpQph4RkZVOMrNqXEXstsaQp nE48xYF4DKZZDoi2w5pP91SAAy1XnE2qPk6clxd0J0TT31bEd7XA2tblX3HYho3n1x2D 8ODV+V1o9Esj7uBznVsVem6+towFUnPF1/fYTWmMSY83jurLrotf9SDQJUBGAYv0OHvi P9hgpVyRgxemNoq71k4ea7/8TRvp0bFIFs2PGge12fW4vHtLxJxgoWQzTHQm7sgaZa1+ 49AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784286225; x=1784891025; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=pJUH2+9UwKuoF8Z5sAeBhPd3xy/csT/L8ZRS5KSSWKw=; b=h5qQmOOKTF7N8482QzWgLwl3VRqguPYwXhz7KzNLpGM0h/+mpHQYJMGWa5l5pstOi3 2YAwhD+Rprah/mPYpxRGB4GTwbgWhM50LLFpLCYaE5/sjwiUPwsEQTtjFaw4r4b1HlIn +aFYs+5pxODV73sC5nCQ0NM60j9IQIlZiWiDk6hkTr8qypa3kTT+V4VfNnNPZozxPwnE x6h70wcpn0++bwnu9yxSya9X8r3zJ0FqZQq/ng+FfQG105jTuNoSIKt4uVJuhdwkF58r 5NHbCryQf8jLCEhYjfeFIVC1rjq5nvI2UcvhZt1o7dWlVaeH1nLCuutuagYHFyW3b/J1 Mo9w== X-Forwarded-Encrypted: i=1; AHgh+Rrdq9G3vS9+136mD0OmjdDTXdXqv/jNIAbvCf5vGCchg3MMCysn/FP320KpP9zbqwHmKNg8vDJNKhTFypk=@vger.kernel.org X-Gm-Message-State: AOJu0YzBL428+xTZ3z9j8grdfoaBNBesFCCylKr6NyzixbDTowhBqzNu nsEeD32pT6fkotxJh24N0hIF3E6K3w48nAjfdGgCYwd2n25ZNTWwS7/P X-Gm-Gg: AfdE7cmIXS1ZwmRChuZ//3NrxWcjk9RG9niCE8ihuEbOElbbG2c7e+2BLwlvegQln5C 3KskzJE3Tesm30LWEAgW1zl+43miG1Ah9d+84W2MDo9d7OfXAP/U2OTu+23XKD5p/ktp/uo7PgE eaJ3gJoQ9n95cQJFzv7W4I0x3UsWmr09m/XJtsQ8qIWWGJx8PGO+aPM6ptzx7ZdwLbxqpr2j96S QiVS6jahI2Eg/EMnDxcBJexM5Eb8ZD9ApVS8gmGdjBJPyytRT9FdkXoxnJ1g9ShbcKbAaw7fSb3 hlmxhkj4UE2qOFOEdnd/5yc3FPmCWh0RZTIbKYvVhcNf/LJUYzKbxIwO66BuCqTn9asD735USmH 8ofDIi9To6Sy1ZT00HxxBQHTpQMnuuc4nZWcvH5kraDtC20ksSxhHKi3HFQVy5XWCH4THGfr+kq XbaAgux5H7e73/B0Gc4X/AnDRTFD1bBeDPYL/4lJV2 X-Received: by 2002:a05:620a:4147:b0:92e:6a43:4768 with SMTP id af79cd13be357-930b3e4e844mr224517685a.11.1784286224683; Fri, 17 Jul 2026 04:03:44 -0700 (PDT) Received: from mango-teamkim.. ([129.170.196.108]) by smtp.gmail.com with ESMTPSA id af79cd13be357-930b542d61dsm124744185a.24.2026.07.17.04.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 04:03:44 -0700 (PDT) From: pip-izony To: Jeff Johnson , Kees Cook Cc: Seungjin Bae , Kyungtae Kim , Pontus Fuchs , "John W . Linville" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] wifi: ar5523: validate rxlen against descriptor size and usblen in ar5523_data_rx_cb() Date: Fri, 17 Jul 2026 07:02:21 -0400 Message-ID: <20260717110219.2392132-3-eeodqql09@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <7bd71d11-d6f2-473d-b5ae-f5fbc972ef40@oss.qualcomm.com> References: <7bd71d11-d6f2-473d-b5ae-f5fbc972ef40@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Seungjin Bae In ar5523_data_rx_cb(), the `rxlen` variable is derived from desc->len, which is provided by the USB device. The function checks for an upper bound (rxlen > ar->rxbufsz) and for a zero value (!rxlen), but it fails to check for a proper lower bound against the size of the descriptor. If a malicious device provides an `rxlen` value that is positive but smaller than sizeof(struct ar5523_rx_desc), the subtraction in the call to skb_put() will result in an integer underflow. This passes a very large unsigned value to skb_put(), which then triggers a kernel panic upon detecting the potential buffer overflow. Fix this by adding a check to ensure `rxlen` is at least sizeof(struct ar5523_rx_desc) before performing the subtraction. Additionally, `rxlen` is not cross-checked against usblen (the number of bytes actually received). Since the frame layout is [ar5523_chunk][802.11 payload][ar5523_rx_desc] and `usblen` covers the whole buffer, a valid rxlen cannot exceed `usblen - sizeof(chunk)`. A device reporting a larger `rxlen` would cause skb_put() to expose descriptor trailer bytes or uninitialized skb tail data as 802.11 payload to ieee80211_rx_irqsafe(). Add a check to reject such frames. Fixes: b7d572e1871df ("ar5523: Add new driver") Suggested-by: Jeff Johnson Signed-off-by: Seungjin Bae --- v1 -> v2: cross-check rxlen against usblen to prevent overreading past the= received payload =20 drivers/net/wireless/ath/ar5523/ar5523.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/wireless/ath/ar5523/ar5523.c b/drivers/net/wireles= s/ath/ar5523/ar5523.c index 66ac396858a5..3ee4b020f416 100644 --- a/drivers/net/wireless/ath/ar5523/ar5523.c +++ b/drivers/net/wireless/ath/ar5523/ar5523.c @@ -589,6 +589,18 @@ static void ar5523_data_rx_cb(struct urb *urb) goto skip; } =20 + if (rxlen < sizeof(struct ar5523_rx_desc)) { + ar5523_dbg(ar, "RX: Bad descriptor (len=3D%u is too small)\n", + rxlen); + goto skip; + } + + if (rxlen > usblen - sizeof(struct ar5523_chunk)) { + ar5523_dbg(ar, "RX: rxlen too large (rxlen=3D%u usblen=3D%d)\n", + rxlen, usblen); + goto skip; + } + skb_reserve(data->skb, sizeof(*chunk)); skb_put(data->skb, rxlen - sizeof(struct ar5523_rx_desc)); =20 --=20 2.43.0