From nobody Sat Jul 25 05:31:08 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013026.outbound.protection.outlook.com [52.101.127.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1393B3B71A0; Fri, 17 Jul 2026 10:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784285962; cv=fail; b=o0bb5zQLuvSoafO1uiSXIG/ItV03Yunz0gni73BiZ4QPUyvW4fFR6ikguvlv4Okx8qOxV2U5UFq//1HVTvpffHOv4vPeBTw6WmdC4A0lytkTkMHHtdmPk7EErTiGrpibsDPsZJLCcx/tT5ObciMHWb9Gt+XH8FdGb8H3cnHveKg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784285962; c=relaxed/simple; bh=q/MzsJuohNymgUwPJxoAi/tHWoGLqHs9ePpuJz4FwC8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=MhQcOrZeBbrl36asBmikhe4rBs5zDsI4fFfemmouoyAMFvd/4qtMl9Bio+LA7Fw3c0MEq3epFyBDK/Vk3rmeJFxMUVkebFzSxUSz2BAQZVnnF4C3eFB6zOvBERKuNPQjsWp/qI2RucxGr81r3Cu4O5sXhga3eQdrjJ+80RhP1TQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=O9mmBdBp; arc=fail smtp.client-ip=52.101.127.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="O9mmBdBp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UhA3XjDUemClJw7cmFED7KOgXS7qPkXnvi1T0ay9KD0eSzqNg0C1rrp0AqRQZM+icaK7eJp3tD6FZOvfRu3/hFJJJbz+7ntTe52PHnOsrZ3gW4sbPFnootgn6BeXzeXmUn39XBqVlD3vOlLBxZMcpwOKaruhD0Tp7h7YFS9wwD3MOk/KW6brXGjUF6g//Tu2p5HXerRiL2iW7gHS+7EARJ6uqstSl968IjRNQeh7t6PTPWtbj/sxIg0prJ9Pa1mVaxn9KAU+iOZALNrVawFij4MMyRWt3Rd50he//40Z2qnfANWBFI+v1R9UuDdoo6sJI1FDFrYbatnGgFL7BdNptQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WJxlHgkWxGGHMXW0VfLZHkZS2m0ImYAVxD5wnyNAt54=; b=hYo2P8WOaC4qOvIYB1kv86F40MGW1mnIrkC2PkHGTFq7Fy118SGzXdjVS+gl26RLez1w92Du6ifM0eWeJPxVPSVPcCJQ1h1QA6ubdd2eEZCt5miQeaYkc4QVIJBFB0BKxtULM0QapNuXCo0n9MKY5AoMqK/rfwYi7TqeA2Vmrg6b0TYzcFYCzM8rhlBqyq7l0Fc3EdYlzBKCD8ML2mXRUrQIsLNcNmUe5aeczBriKlzHs6vGmpsVQwj8bpPoHLtdxBj0iMSsIBOfZhRgpFbS+aHQSiD+ufBwr4OWBuT/nq/l2VjaCTswvBGxA0uRr16fLJWyNllpU579LaeKAZfttA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WJxlHgkWxGGHMXW0VfLZHkZS2m0ImYAVxD5wnyNAt54=; b=O9mmBdBpgXHs4Tlh08bKf7agesPlbL+ZhVK4TMCEfdrMBHQJmH9NfYje3sRHxw9Jw8gYS6aswhwn7OFciO6mrGr0oXAMw+HvunyBLbSHxL507rBpduDUkSiAE+5pkJ27XH664fl4HiGZYWWgr1R4LS00r8a1Ji0ioPMJQkuNSc+9UliSNj6vm16/M9Li673ovkY7P2t6H4BfSnva7BEJYk7cxbc37QQW7As61Z4O5VA88SCM6CZc6V4RPEJiT3p9wOEn7zYfZfHQz/WOe1qwVKxQiW1qQI1D12dazV461DR2aOlAw5Y/4pTJxq4bZo4ZoJjcxHvLfU8V//Rg1rjxDA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KUZPR06MB8313.apcprd06.prod.outlook.com (2603:1096:d10:64::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 10:59:05 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 10:59:05 +0000 From: Pan Chuang To: Lorenzo Bianconi , Linus Walleij , linux-mediatek@lists.infradead.org (moderated list:PIN CONTROLLER - AIROHA), linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 1/4] pinctrl: airoha: Remove redundant dev_err() Date: Fri, 17 Jul 2026 18:58:43 +0800 Message-Id: <20260717105847.131359-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717105847.131359-1-panchuang@vivo.com> References: <20260717105847.131359-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0036.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29d::20) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KUZPR06MB8313:EE_ X-MS-Office365-Filtering-Correlation-Id: 31162a34-0c59-4860-956e-08dee3f26adb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|52116014|376014|1800799024|6133799003|38350700014|18002099003|22082099003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: et9auvwrMZM+xa9KQa2cbKKiVeZ+Eum+CIVronsJZQQDIC/zYGMM+nB55wGlWOy/03iPIUtT2vUuA94b4UAKHQ1FV2mvZWC9pSJSJHpZYbVbkSRFdc6tKin6djRTAQOc2PVwbq0OMynLg5rJIUQMrNjGUt27dfJd5urM7Wi9MXI79w3mXm2rXIR5zvmiizIS7DL2Tsd/Ovb0OT52hSBtGNwU6Yaanbeti4PEhsqiKaAT5042pMuDlp0mr44ndtkdeR4/WNqtvoALWIuIZNy2FVotUqJUnYVeOqZATs+PxttCmEqVd0zd6r3F2xwQwNijLuBmrXxLbtvCaRh50ucslaFErkaWUR59MwRxgteIwRHfeFl2lnd3uWdu4e+PDX2h2PxTp7mhGNI+xT1XtquAu2F4vSauUVdCQ7b/XmzZ2fZkz2lRv6dmt2PN9JeB6UZ+CxrpJh96M6VKmQlfXO6jxfSpo+rulQxvMyjzVpKc1LK1qcteFUXVXtTfABY6wM5S0i3aH2DwZ2Iz1kCFsbVFuLW+/SEcTo7VPNaLnxsgYjuVj05EwPvstm7UQq3Yf9MVuGPu7ETjswK6OZTVl1lIS78U++jB/G305H1AVySwqQhsAWiOwkijZlZK3q/+RDcSPG8o0BYQ2/9lJdzBqhYyJS6/1eg0b14IEC1wB+ATx9EUwPCVJIR8u+M/k0ZXOPIhoB4JwWY7xobFNBQV7PW0w9p9qb772CN0K3NWp+76uYU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(52116014)(376014)(1800799024)(6133799003)(38350700014)(18002099003)(22082099003)(11063799006)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+bQ68eJEgo3wt3RS8J9EDC0FNNbzFhWRuEjZvJ+Sal69mA3AQjmQvS5xLWWe?= =?us-ascii?Q?x7fWy0BheAw4L9TiWPqMibB5sL0Fmh7/yfTa5S95s+Tnz2JYLFMn5Ev5mxk4?= =?us-ascii?Q?DoqrA4DBChIlFLVpkrPN9WBiHkxAmq2X/26TEcEdD7cNFsd+6cSfnUq/AjMj?= =?us-ascii?Q?Hxi+0m4nRfHVtzhM8lHu41ftbHak2NbrZIV652zbbS5tkdQfElKWIN5b+TWI?= =?us-ascii?Q?kqa0kme/X7jAfnwo/jBLiwvbUDvBh811/WiR64EhvomxPsBljHddhXLYBtKh?= =?us-ascii?Q?zFb5YBnYwIM9EZkc3niiBO+vtbb19ClkLBnofPQEJSjJ8k8fAmwqKTPibWHm?= =?us-ascii?Q?+Dhe9sL7GLl8VNTjlNTAsUKk4YfYnNvbfsYMVatKupYW5AOLarxu7hQFVDfH?= =?us-ascii?Q?0xXjtXIa/cMMCrUxYeWRkwM5nZyJ4LuwCMTP6OhVoFZe8Vg+V7ki0YleD/NJ?= =?us-ascii?Q?YMtjMYNZ5QUTClGHQHNGfbbgU07ZM0hbKLTyXcJaSZE6IpYkXtx5l7wvicPS?= =?us-ascii?Q?nZmklYcNp6bX4yGXpHhl42CDV9ZNgkykd5/S2/8MlmouCg+uiPiKnoThV/Ki?= =?us-ascii?Q?7ozjRmtDZ5zTaoickJtBC1ulkDTc0Pn4nqkFbngb0V1tMDwsx6gryX0/UlOv?= =?us-ascii?Q?/X8cEt5ZOJxMYirBpUNylq64NHmAdWljueMx2f+eKV7gQ+yGPoVBXEmfpB2a?= =?us-ascii?Q?mBHFkeCRUslWUGKHsy3VugeS87N3TMyqyk1vJuOdq9zwpn8K+jMpNwMbUKJ0?= =?us-ascii?Q?eg5G9RW0Az6KyK1s4amLgZacB60agTPlgUndZw4J+15MeuOJMxO4W27YtDUW?= =?us-ascii?Q?S+ChDoYSpOKrQojjVqdL3d97j/g0Oix/5hbukVgVPSNmziBXyWLv5TqXxwTz?= =?us-ascii?Q?f5AlBMIckG2XWb2Ln/f2ef98C++Hz098VBjN5FLiFJp2cuvHEal3q7eLPhzH?= =?us-ascii?Q?ja24ouN73QI33Bee5x3nQA92bgSaottrUP3kTC971L/G4i8UudwOenrv+26L?= =?us-ascii?Q?vLkRpdLNUDC0YjnSpxJamTwOu5tBzdGAwsIDLrIFQwQ9YarHodu+YxEu8WLi?= =?us-ascii?Q?GADOy6o7pwdlU4N0MhdSmpgR77sZRhx+FDEDeEdfyg6PR4e25s+ANWSX8WRb?= =?us-ascii?Q?7q0m1aFnTfAWMywDIpaQ5VH4C2BQ+Z6+fieshNht9iIfhk6Gzqw+7YYWUI38?= =?us-ascii?Q?T9m60sB3j5bP2CQhonZXTufrjetINFKQepnYilMlnyTZLQhQCoziN9EmJGlM?= =?us-ascii?Q?GjEDfdbROLSoo3y3ydSp2ZpzqGjbdOXVAJwoj7Ua8u8zil+JOInUEtyoZrVW?= =?us-ascii?Q?bnI5RwFz1Lu107WsGD8GhGXes5AzTGSFQWE7gQy1uNQUXOWVUIA3XkY/REun?= =?us-ascii?Q?wvepxIKhxe0TIay79TOu9ClsXdi2HQDPQy1TQdz7DjKPFAl5EbIyNJprQOEY?= =?us-ascii?Q?kUmV7XLcEoaB1Ve5O2J4rbjmFSvEhFoIv/T6nQ8WN9XOrhUagaPCVQk9Y7JR?= =?us-ascii?Q?s1blLoAWM90y3pCLV7DEMLtCEpHe+JH90GSETe4ojb87Q5hsaCZlmryHivTc?= =?us-ascii?Q?gSaLX9Rs00IXp8QSeXyIMYZTlvSwXCSwGkEZUNiXPhOV5s+az5XVglDJ6rgR?= =?us-ascii?Q?t0NkBKg4hWmsKc2uqZmtc/6uztr7lBNj9cLmfHraw6BWp8CN/M7ScwNauDkN?= =?us-ascii?Q?VYRZcZR385pF+QGEg0bXyWFG7P6PPJi+pnePxqL8DAMkDGvGz2uqowdiFdSC?= =?us-ascii?Q?BBy7g64kcg=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31162a34-0c59-4860-956e-08dee3f26adb X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 10:59:04.9989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nrbf09KgGbP8O0BNzUGGcDoWEhTT5Wu30VdHaQz9gzIrggNgbx7k+GIhiqYT+yzi4zjuLjWYx5A+h1W9218+2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KUZPR06MB8313 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Acked-by: Lorenzo Bianconi --- drivers/pinctrl/airoha/pinctrl-airoha.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airo= ha/pinctrl-airoha.c index 04b4424c688b..abfb018f207e 100644 --- a/drivers/pinctrl/airoha/pinctrl-airoha.c +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c @@ -2519,10 +2519,8 @@ static int airoha_pinctrl_add_gpiochip(struct airoha= _pinctrl *pinctrl, =20 err =3D devm_request_irq(dev, irq, airoha_irq_handler, IRQF_SHARED, dev_name(dev), pinctrl); - if (err) { - dev_err(dev, "error requesting irq %d: %d\n", irq, err); + if (err) return err; - } =20 return devm_gpiochip_add_data(dev, gc, pinctrl); } --=20 2.34.1 From nobody Sat Jul 25 05:31:08 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013026.outbound.protection.outlook.com [52.101.127.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C899F3F412C; Fri, 17 Jul 2026 10:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784285969; cv=fail; b=KO8KwUZna/NS/OxhmWgrxiL76a0RjRWZMHRyCa3sV3VnCBEAobDqXq4Y2+mpCMsarxNt4MgIXFOKy7v7oUc10xtuAdrn+ZXN3m5myi0mOC7feKf4VbmgcQzdA4T5jLpSm6egjxsit6wUKyKKMN7WoMGuJsw5KZcVnFX4y/CdrYw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784285969; c=relaxed/simple; bh=EKSPvhyd8Mm8m61F4a+8xNukNkz/2jlWAD1HmCj03m8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=NFS11as2ZPZNt7v9mX/eHg44nuymQwx82YRLFI/wWIrQD81jt+UN3CdcQgMrTdQu2XQAr2CxTGYgrC99VlDyaDl7x6cMcRHtifZwthqfPXt1d/TOsevkr1gA7r/daP0tgWc0amUyFl6V4soiNv/njQkeh451FjCcXqIjlFwi8vg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=csiVBsIV; arc=fail smtp.client-ip=52.101.127.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="csiVBsIV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kzDPYynn6CgVvpui5p2nWY47TIkr0BByXIs6lNI/TfT5711m5Pf+K34FGvf50gSKiSIcsxb8rZjxC84o8hAoeNSAChucKyVFXP3GceUWXJvLc7e6nBgTiz4aRTrlZNN6sn+ZbkqKe5LS3iymOsttsRHjvJkY06uodKjhV4/Ymz2OY5NRtj3bxz3w83irIId26QnUeWT9k1wYTjdddX/ujiPwekPe95Uz8O7BkhkKDmk+GDXRTM6GORJrq74MwEMTw/XMOj4DK1jMHUH8bPIiPvAbdIEwuiow0PXBXK+2scZcThUTnAKD6EQ3y4TBpNm8ucmXN24ltMhYfK3uG2YBVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PY4uVrPvN+6ZIwQNbP46A09f4bcw/FSaEE64BE0gu78=; b=ug2czAo8JW4oOsGnkuDVhozhEEvqGmalov0vxFIm4/RJvUIcvwefQ/jQQxAoV1NZlle9d2y5Pjo6YajTLZSFYgMVZTxdSSf9XWks57MqONCNnizo84r/3Gty4sGwmKhkHRucaa0GexJaxxt8oOEr7h8kZYZDhs35Xew+h7582Yt6KFb/OepHWfC48nTPoG6YmVDrWB1uK5ik+aybgTpDxQuwUR0rLJJuZ7YWbs0BL0Ny/ihcxM1SVVavc+z7wstyyZtqn0+sJzLr2wF1yDbGjcveffkVBTpsFFb9SMCswNqiblNZy3piGSM7JkpKGTpAIpF95gYXt50cOdDVcHsbtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PY4uVrPvN+6ZIwQNbP46A09f4bcw/FSaEE64BE0gu78=; b=csiVBsIV9Bw4825IqL3QOq+J6ZB+v+Kz57ypeWS++ikf8HN1R7dYgrLVdjdLopyZfe8zKec+lFFCeodGRxbsEdA43tKNiTLL9m9RuI3TEi7+gg0mpNyHAcXaDbmpcHWKsb7IL1f4zDzkHWSN1B0hWsWF4ZzJwyDKprQzkelq7K9vYGGN3MRXNFBCaOz79ScZdr2pxu0CT+T0dEhp1zt3u27aVZifw8vojjqTn+q5s4hCdmeG+5LDfofMLA4UL42IKzIcy6lhbTmmex0paE0wpWs4ASX9qaN2srkAbAfxvfRM5Kr+DuIxmq6BjbO6LuLjOxqE0DjfD8LkOWGeJVtfZw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KUZPR06MB8313.apcprd06.prod.outlook.com (2603:1096:d10:64::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 10:59:06 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 10:59:06 +0000 From: Pan Chuang To: Ray Jui , Scott Branden , Broadcom internal kernel review list , Linus Walleij , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE), linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 2/4] pinctrl: bcm: Remove redundant dev_err() Date: Fri, 17 Jul 2026 18:58:44 +0800 Message-Id: <20260717105847.131359-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717105847.131359-1-panchuang@vivo.com> References: <20260717105847.131359-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0036.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29d::20) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KUZPR06MB8313:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e0eaeb3-1d93-4a7c-d7cd-08dee3f26bca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|52116014|376014|1800799024|6133799003|38350700014|18002099003|22082099003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: +nNy0uA7H1t6q9SkEBH2N6DP/BV+24q0ucw5J0W2+wBJ1/wk55Rz1SO19XRepFyc9IAg7bsUv4E0jHeoZsyQq7d9evZy9tQZeREjho0lGcgro5td0FB+fIVjYl33Lt8PZXt7qDDfc7N3+tH77p78Rg98IaRVSufknIsM7kDEAZZSMMMkOtecdEVGQTO55wNVGo66WjqE1GZ3z0v0z8cXAST2M8JwYZ4aaUiMeDZ4juVX4ElU8rYXEI0UYCBNGSzLZyNsNq8/NVOIyBnvDWfktrtjnfNN+gUqwNIV4DyNXJ6lv6UarYaRJOM1zs0jZ6lQHGOX9d/g7Y2shT/DLI6+Q7pFOxU3CV9AGi83GlucdA2KsTilNyRfgBZSipugJgDyQprgt/6P+Z/SehYb7yzibv/GiCn25Lit661wf3KjFlSO5aDjZdrGZGcEMV4A4OldtBlyp3tqGxBKiji866Rp5/7Bi0eJsxyoWuztrOIxz3UZniukKOn67+pJmqvbLGcaFJwa6IiTr49s91QcadpBykod67kuoN90LS47/I47zVGbj38V6fmrAe8L0jN/L/ojovgg0/5JqBFl7tkEbLhAaeAbmLL1T1eVkCdqru12cVGm3e/SdTVD2z6iu5ExY8lxCZEqRNraOhoaGaRc0Fbf5SrfDdQOVLPQm7olPbuxKWAqwlNMH/nOHbTY4Sih5fdmeJyrs0RW5CQW4j7xE0N7IZJ6RTxb1MuQa/VI6Be2QH4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(52116014)(376014)(1800799024)(6133799003)(38350700014)(18002099003)(22082099003)(11063799006)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5ns7V15zLxZyt0GT9ZLtgQQOk8wmKOiArFw2DpsB0+PF7UFvZTR647DUGrnV?= =?us-ascii?Q?CGawBx3jD9EwJA/0X9cLisLsL8s15pM1qWzxPlFOfpfh1bzjiwUMxZD4/84b?= =?us-ascii?Q?YrzfKFTXB6Z9OpnKbvo3o4UulIfnTukexeug3f1Fej+7cbFAc2x5BssEaS88?= =?us-ascii?Q?KWCBuFWjv3VOgqt7Pybovxc/kpuYegV3sssI+o6OB+8UJ5qKAR++CM6WctLp?= =?us-ascii?Q?cubxWnfcRjZwEZyRSd9JDvtsOju+1TZSkbhRw66Q76LQOQzomSTtTvr4LVUE?= =?us-ascii?Q?/kvN0aE/4zX7qpVm4Ex82AoGdmN9IhoqBH7LVxsZdghWkoRbuGsKw1FgGhNL?= =?us-ascii?Q?JuIVPprR3Q9aUxv2240/UcHod6xcCyfx+Lc6W8OwGWupDkZ3S8s4aLzQxrH8?= =?us-ascii?Q?4G09QXws9tFm9G0l5WB3dhhOSl819MqkiRlDj9B7ge8gsq6RQ2nnees18KnI?= =?us-ascii?Q?3USMTjvnVF+ZoIY8O0JYyQC8mI+LGTzDAkqxGxkce4oqQE/JJM2RC9hFu+Kf?= =?us-ascii?Q?yI9sZwKXJqkml2y2NcCFnhTHxQZSeKwp9vBJfHc29EjfTheZaUOM+YPl4GQp?= =?us-ascii?Q?O2bzahQrhVn9Jhrk9Mp/6kLfU7xsQBbsMeYIVuVoXH1Z+10h8izI+S72UBkt?= =?us-ascii?Q?ilsfQe081IRU6N1qtEpiARyCki/2+38PHWovz3ahkhCSZttx7Ba2xIBWXyGw?= =?us-ascii?Q?fbs5M7pWNVVdx03EBkUIl+5npoBR2OG+MuzX0XkPefK2k8ZAK6pcAOhQVfOl?= =?us-ascii?Q?4SemTulsHFgMNX9/c9foh3eJRKxLFJSRsWaQwpKqkjutAB4kvBB56oHGjGo6?= =?us-ascii?Q?fpityFLjdGtUc4rpkBfrdZv06MjhyCiTxbBYxlUmcXBNAi/11txWYa5sZTmH?= =?us-ascii?Q?1F3pxG9iOwKVQmV5brTYXvYPQ+TfvFSX7zKWLVM0WVi3E6rrteh5KcYoFS9G?= =?us-ascii?Q?VATQ56hmx5y5P8GIaokDiuTWbaDbCmKwuYKTPqnS5KYgT7VkWAEFnN0+ncT/?= =?us-ascii?Q?ALChBX7wYGwYKJBQY8Lfk2WVXXpUKjac432qddLS4aitICqDMDsXLXefVU30?= =?us-ascii?Q?/Z71LuUap0l8guEsN87WZsTy6peSw42/YHemzUTT/q9gtUbVQ3xeJhnyikyK?= =?us-ascii?Q?FfNL4eX2ZONGYDwBzVVQMYiq0acwELHnNf4pUOYHOQSmZKtQChfO+uwQxsk3?= =?us-ascii?Q?jQSFyt9ZtMUW0N+2KOnLXUhB4/RblNYYVmz6HD0jZGK54/iiKZvEaGsXVFW6?= =?us-ascii?Q?9KKxjWaXdU8ESBYf2qD0gzbsahc5JowmRQ5x2tZ7oOaiZfwX+RlaGKcvAw6E?= =?us-ascii?Q?bqxVX7Zgw2s1hXaklMw8iNhQhtydRhXAVwIZBjIoRKdG0xqK9NlfXxFaxHqt?= =?us-ascii?Q?fcqJegtl7tlvTzHx/4Kt4YcfVVIljQ/gpz12HhjhXRigYV1XFqwK0TuYFvlo?= =?us-ascii?Q?kjzt2TpEwcq4fQxc+Orj2/llDEpZgJOus9KZxgSnLtscw1b57JUfsBzQE1dU?= =?us-ascii?Q?E/s4fIqX5HZ4OVyeBF9I6ms+4Z6CwYXQETBKt222ZXaFCJQxI2hfz5EMja01?= =?us-ascii?Q?f9HThSFXAZpVm+NsMloBpEoyNe5q96z0Z2N5/9/6jzvlr+r4HMVCvJ5P023q?= =?us-ascii?Q?DA/1WNW/jYlA7LvMg30Dj9GCc+2d2nCiRPKojOsYt3mY8U6m7Pd2PamyDr5k?= =?us-ascii?Q?ikP5csI3qbKhc2/j+iuq//jyJKAfaXJQvyO2ArshDiXTdT/MrU/rQN/oariU?= =?us-ascii?Q?w4FkH2DEUg=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e0eaeb3-1d93-4a7c-d7cd-08dee3f26bca X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 10:59:06.5479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u1B2XKjWDyN6NLVKxoKIYsAivqHDpBecYsMTIExhsnmWKb2FRK0RrM3M0yeRi5VTuaa+4PML6Drm85itrNSRJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KUZPR06MB8313 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/p= inctrl-nsp-gpio.c index b425ecacd1b0..1fbb101386a3 100644 --- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c @@ -671,11 +671,8 @@ static int nsp_gpio_probe(struct platform_device *pdev) /* Install ISR for this GPIO controller. */ ret =3D devm_request_irq(dev, irq, nsp_gpio_irq_handler, IRQF_SHARED, "gpio-a", &chip->gc); - if (ret) { - dev_err(&pdev->dev, "Unable to request IRQ%d: %d\n", - irq, ret); + if (ret) return ret; - } =20 girq =3D &chip->gc.irq; gpio_irq_chip_set_chip(girq, &nsp_gpio_irq_chip); --=20 2.34.1 From nobody Sat Jul 25 05:31:08 2026 Received: from SEYPR02CU001.outbound.protection.outlook.com (mail-koreacentralazon11013064.outbound.protection.outlook.com [40.107.44.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B4ED3B71CB; Fri, 17 Jul 2026 10:59:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.44.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784285963; cv=fail; b=db4u7f9W2nFSEXm33mraYtN56AclVjp5dIc+aSh5gHnU6ktoLv0iaQiCSSNCD7AKoDw3GRJGSlwr7VAw7J+nGSdl4se/GsDD6Ve+Ho/18OsY241Nj6nEmceIgwL1uulUX6lc7GNeUd+3zEl6vfxgRhe0HCs2fjZKZc69ThVdlFY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784285963; c=relaxed/simple; bh=1qJTj4d8mw5zPfZbIk03jmjyrx/wlNf3Q30ONWEO+5M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=i1FDUhYu2WOOzX/E2bJkqV9rHyoBhlMG3nh/jyHgSKJc73ERgb5X2VacAPpI2MBEGLeP2s2fTaT+k/m5LaSDhaPlugdvU7JxMzK01ajwl5U2HtiC7nSwwmFDsWsXLLAoRp3V/2q9DathEfHoPMP5FH/FASj6bkevpoGaLRTg1u0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=RIxDz5n9; arc=fail smtp.client-ip=40.107.44.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="RIxDz5n9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=otCuWDywUENlecXq4rFV6sI55RqinDFf41JGLSj9+sgNH9TXv5gycX2TIYx5SIHoQhV3gsrZDBR3XLs0xagOaoICoj7tfMmjADBPK6AIZRhpbDc6gUvo70YJq1ANxZbQZrU2MkzEFlkQDLmwRJJpaxGzpOd2c3NUqWpQmeLxQBHZUMO9e6G53Voqv2zDXe+RCi0sO9FNQVc+dr2Ny+DwlkPAlbYTkw696se8Niky4Iww+UTgLOReURclGXXZwh5Ts4oPQtcQqFJw1HxNWbYoxeBXyShSpMLK7IrOwZ/2qG5PCQc6eanzi9xaUnuc1Z4doLSPSBMuPxAXWUf3YkbSJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r8RYD6zSTBGTpuRoftwLyXV94IFA2vFMBxYhdYXkWSg=; b=UzEAIijrUShrRO5Hro621RkXqXgBhLHuGUFc4/6gjLrl6DAy2Mccc/9PIU8u73nSiKWG7h74cSDMXoRFMry4j2fiLsjINdr3l/zr1SotsS975Gjpt2byQTZ8y5+Ln9lFMEF1Y22E3gtn7Es6/+vCB7tsyd4vTJox+mkCZaYX/LrubnDCwnfgNmXY5qgvOh6aXi/lVeRU+BUGKQ1JId1x/dRWsTt20LA+dXwgsIBw9DncaHkH6Ly9vD0dh6YP541W//j6/sUam4dcb7NdLClzzYIAACPQCY5DwZbJdLQc2X+Ei3s5Xc43sOh0aaMHv0EXoFBAcck5ASKUs7c64j5cKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r8RYD6zSTBGTpuRoftwLyXV94IFA2vFMBxYhdYXkWSg=; b=RIxDz5n9azoBbEIGxvzQ15TZOyYyG8CjFBJ9gD1D+0y6uqtdkhWzvLkLdPg/Jm7Yw7zcOaiLdYq9Hs2XvOQRiruROPjzxzNzcWuRGAIJrJZ/CGheMzuIluMQQfPaTw4yCuZSqK5Eqt+rjz65GJfWud4kbL34MVEL4tZUeESYo2gNDgFVTUVHevB0Jp2ZX3LHhh2HvfrcgbOBalwswzOhCnPk/QEmVJgE/oLYDrPlBcDGRvOWRNDBmWVo6ibAXnlpLXkwuFGeUxEfDiy+fIlwHm0mDg0/sIfbSHod1yp3S0SrjAf6NeUwZ3C+H1luM9cE/ID3FOiEDagMNLTkO5P1oA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by JH0PR06MB6702.apcprd06.prod.outlook.com (2603:1096:990:35::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.10; Fri, 17 Jul 2026 10:59:08 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 10:59:07 +0000 From: Pan Chuang To: Mika Westerberg , Andy Shevchenko , Linus Walleij , linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 3/4] pinctrl: intel: Remove redundant dev_err_probe() Date: Fri, 17 Jul 2026 18:58:45 +0800 Message-Id: <20260717105847.131359-4-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717105847.131359-1-panchuang@vivo.com> References: <20260717105847.131359-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0036.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29d::20) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|JH0PR06MB6702:EE_ X-MS-Office365-Filtering-Correlation-Id: c5129f39-300d-44e2-d88a-08dee3f26c91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|23010399003|1800799024|366016|38350700014|6133799003|56012099006|11063799006|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: w/bl00LZKu8BDfK+osPq5N+Lm4Aim9MpDIZA0L2VZLpXVfEXJ6oNktv0ZKVRUqX/epXsJKm3N17g4JqlFoTvJmgHIBJ2i/YA6+Ca+LZOO8+cfSEw80ReTGtIj5ZX4fUP/Flo0NMuI9y4fvbap3I1N8lZeIKRxqkpDkL8481gnOp/qM9RCcsshdIf9zIzUDvqS/unOUbEO4T6H4sSXFy8lY0E1Y+suOJ3zATp+h60qWivQnAKCqYWPXts6E+RVqcOoQuPurEM7qVLoi3rteul71coJSNZuH3GVDwwNpZ10+Ch4U8ey144bCHKy/Zd0NdPVz11Tc1USzsGLHcQFMNbsvcdSZFNHzCN0PWW1YuOgFh1aV9eHxZsDAU1qEZyu9UmFZQ7CBO0l484ZcUwBFPTnb+6MmOomIiBECjKHshgJSuX/+NcIp1mQm/asBCpfV01/hRjZHq29oGVphnNokHy/kgVXHUU4QYgnDhwoufnhFBgq5WZecOJF5urcIlLDDQMJFOhXlBWckKVaM6QBvDSCQEfW3HcLEEnP/8nz6qUqO1wOMDKfrgCZyPnDzLVVk1oyCYjJA1cX7Josi2L6piIf2a2453b2Y2jYi8u8BGQoPEMGMKZ0qRmc6YY3FPWPC5CvgJfXBTvvB/GCIbu+TTxclDCisHN1NEpsza8Pa1eaLHT/GMq4vccpk8l3M8XsKDWGiz0WkBWBgYbDAEbKUePU8yJ0uLBNg6Q3E1lGZqsILw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(23010399003)(1800799024)(366016)(38350700014)(6133799003)(56012099006)(11063799006)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CpYSazIkOE/hia1J77D3InP8l52NTtlGunw6v37ABI7BpPRbvaLHuz/D0ka3?= =?us-ascii?Q?6G5iZkg8/eNXJhiFRAsIkVT+q8u2pAlLTKbPccWtnvXvQC8KRyNPCYnhpOa5?= =?us-ascii?Q?TDTsYtV/lOdFYnPiAJ+PZN3DlrmuuIabtpYbezuwJon9npVqo4pwFP4bfV4Q?= =?us-ascii?Q?t6UmbhgGet67utZKMprf00MiYEDBZQczgzrjfzA4EFF6aCKrwUP4/QfeVHvt?= =?us-ascii?Q?/d+w1dCf4sm2BF40Pp1EcHJHZWwozfO2D5CKj5vvfZp2eVHmDt+1Jz1FTIVt?= =?us-ascii?Q?AsANOUpNCDjQX+fNzfWY0QPBRU4/0o4ebvRlo6brwPx8Ebsc/f+uQCLAasV2?= =?us-ascii?Q?ibaD8L0vENpc2SKAUS66F7Yr4LSAMlRRrvPnHtoH9IgqCROmAUvwe6kK19u3?= =?us-ascii?Q?xh/tUdEi/ojBEXx0vWUo1g6oe7B5bzdcdr3twLarl68bR8L1oQgzSL6dDB4l?= =?us-ascii?Q?yMbDf86FS9E0V/M1pVpvYfzcahWPKM2WqIWxrtd20W7vUIISuLgFKRstn987?= =?us-ascii?Q?Ie7yZXa/SG/YocEwbUaFCt5p09tVrFDxOAAv1YtQKK58v+sJz1RjneU+W6uH?= =?us-ascii?Q?uuJhIltAO5TgWgMWdHVq1Yj0lxwqoSO+HN+tS3XNzo96Luh2z4llrmELxfAN?= =?us-ascii?Q?upki1wHJtgwzVZ2ZEPd73vmsVTUtgJdnqTo313L1Ofvk2WVzOMUaX3JvdV8g?= =?us-ascii?Q?0TztFr3hTwSZjTPz7ED4iBgpkGTgNhyBg8ym89K3eqnOxAK2WqMruE9Er/9K?= =?us-ascii?Q?TIvcH5FInGcETIzH2dCGrRHisK6BiXH3Y2dYHvQtVLZwD0U/KyflJhbCIgjB?= =?us-ascii?Q?uY9zmsNJXidtiOmZyreSd6fCoqxJOulVM1g0QyE2InHDhMywwJ8PioioB5Sv?= =?us-ascii?Q?biZae9JwPpl2wjluI3i1dO7OTfrAEQGaCzcvg0UYDXNM0OIeq9LTPK0sGjaV?= =?us-ascii?Q?FsGQaqHFU0Cclhs4GC3VecyE9Q7hGqs/9diUnmbvx+VRc7zbE3RD/0PKjUoo?= =?us-ascii?Q?ncEfLpmEZD2ZTGWrbF/VzE1qiSzYH6gPw4tggfCqFiy2nShCowB0WVOICz9X?= =?us-ascii?Q?Kf5UsTmbM3cN/Lethl6eR2uEIXpg4cN2C3MFXIjxc9oYa44l7LlyfM334ZQD?= =?us-ascii?Q?LSZw0m/ggA5WjXzKK0KX/dm5k/FAupcvgaTxCV7qUSB1GKtalwo1VGATx5I6?= =?us-ascii?Q?uEVlr0vyLuUhgD0/Qj2NqnhuoFf99yZDDqiS+SvDwhrZDVZbAFBMhTjmaE/B?= =?us-ascii?Q?IJn6wCNyz8LqHfcUUzBZZeyvZK+ToBrSHlDS4rEekZ9Ohtc+jFhCG4YMqZk7?= =?us-ascii?Q?LR6hs/NgiCI1bJkdziT1ivnIHtfP9kHGTtVKXWbv+kjzFwzXyMYRmAfxrdSy?= =?us-ascii?Q?hbmtVpEiIPqtNZcEKSafsGJF7O4ss/iyUAmId9azvpaMoR4CEzAk9UWU2GyT?= =?us-ascii?Q?hou4OXnsjfaXI7ClXGG8K/PL3CXVCiKs3OqeHVWYdSp41QycPvM0xehnAavS?= =?us-ascii?Q?1CbqjcM9OuVveFedPhsHeQsVdB80AFiiszGp03Ua+Sdf7Bre/ym1+EoaSMP2?= =?us-ascii?Q?N1QMtoEcv5jBR1uZ6a/ZnpOCeJ3XhjCHHvDvc1NxP3QWelWh+CkjD4Y2UJUS?= =?us-ascii?Q?HTeC3vcVmHDfx2RaI8IA18v3yIjTPF4tbX5gN29EDmkZqWftsKw3G7nxLN6S?= =?us-ascii?Q?hPf7x5046Nze9PTFYoCfI3xx6yWFnI+YAVeRNBg9u71a/8ywluuEU8HVhZe5?= =?us-ascii?Q?Pz27Lk6MpQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5129f39-300d-44e2-d88a-08dee3f26c91 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 10:59:07.8570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /AlfYsvADZyc0kCNfvymqp2PLC2hbujK3tpi6U3C+L40iSFIOPQz8U9fekw+saqDd1am6b/L4bnj4goHvkOEMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB6702 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() calls. Signed-off-by: Pan Chuang --- drivers/pinctrl/intel/pinctrl-intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/= pinctrl-intel.c index 2e2526e01d58..261ec2ee63ef 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1414,7 +1414,7 @@ static int intel_gpio_probe(struct intel_pinctrl *pct= rl, int irq) IRQF_SHARED | IRQF_NO_THREAD, dev_name(pctrl->dev), pctrl); if (ret) - return dev_err_probe(pctrl->dev, ret, "failed to request interrupt\n"); + return ret; =20 /* Setup IRQ chip */ girq =3D &pctrl->chip.irq; --=20 2.34.1 From nobody Sat Jul 25 05:31:08 2026 Received: from SEYPR02CU001.outbound.protection.outlook.com (mail-koreacentralazon11013064.outbound.protection.outlook.com [40.107.44.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E53F3F4DF7; Fri, 17 Jul 2026 10:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.44.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784285975; cv=fail; b=NzyKqkHcZ88nVQSrQ2kPmoXzlPmhA0OVNkouJ8zxXJGQWHELu+XWsvH02VtdckqDnuEEXxzcvk6NEn5KyIpVaTtgetLRKKGcWcxdGBIx+DA3fUBXE4vT66DEBIkYiWOT7eujwWO/szo8wV5XMx5wePKFvd4Rl5sMCFlvSYAXhVo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784285975; c=relaxed/simple; bh=mZ+gj2yfuo5XT4xxbEUJUrTpUBNwUjaw0Vpjoyefz0c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=ohWB8rVHdmS2IcVF9Nu+ZwWMjfh3gjUS77JcZ+6EGULscGpeTOqaVnLrb0hkmMRoWrnMzxlINtdw8WRsg9WVpp/6Hw7kLid2NO0QOKKv/CJwPmoSmFHOs5hKzVRHYcJKrKZ7FjfY9V9XiMnBAfvFaafot+ZcwwFcL6GYruNuyTk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=mvLG0XHR; arc=fail smtp.client-ip=40.107.44.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="mvLG0XHR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pMEs67BRVYIxurSI74JfOwb4ZVS5Nsb2kbtlaXTegZX9MKvnsY6TbBW+vKujnm8QpPV65EoUWvJ3znI2dOcdhb6O1112+Q7GKC3xJaKsRMnIa7mlRqCW5SvsIbFDyd9kkR17au9SwGi6Op9DWvW8OBlVP+iFEqRq+Cq5w9AcTHdyf/5vRCdK0Nezs+vtRoF12xwjLkoz0Lmk0JlORFIQxlmb/46+iQK1JFCapmfuYR8Zb133hFDQXrise48hCOUbbUf6qPQsgdUg2PYzTn72/XpF4Y7nXFwYySDl9WTjZ4Ggee43LGbA8C1PtHS/tPXqOF71vWoZxqr/+bmF08H0AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ifkHPWss/sbLgGjJNGzATMNQNOwFwfAMevw/wBDNkKg=; b=vG/wqUVoDDvtZAg7Nt4nQODGheYet7AWcHinwNnSbVb03+TJAHtGC3F5Kg0I1LSiaYTk2V9N2/P1zQPzxYBcvpUGRtDCAPNupgWq0cE9hky90JsbCg26cxtLsWsx/QhNdykwQ07l63HFX0bhakX9xn4pEQuPLjv0/GJ3NJOdn5wLn/5jgwTxt1CAzr0qU1ZnaOuafKMEU5XUR2Hku7Q7B6Yfuv0maBTMphpSrbMf13y5djlaEMQhIGYHcHIK+ZMCEOjph6UZd9/0UlUKlgqgjIcWCkSs7B6FJoId3Af+l7EpwY2ABOaDZmT76ji6OZRH+oA+HIrN8qyuUOGUoOAoMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ifkHPWss/sbLgGjJNGzATMNQNOwFwfAMevw/wBDNkKg=; b=mvLG0XHRaChywGpFjaL3UcR6pWwuY6SpATZAlGX8zwD9SLPRjbfdRAYuMBNntEB0uxPLI5JGlXUppJ8DuI6gmYwvGSJZ4Ofkot8HZekpOXBvQYXoXFY1hRbZ/RzuFMpHaO/jEn6e6ZyUXM2M9LBLAN1JItr6thC00E0FtzhFeUkN3/3Vpf8gl9zdn2uKkEIWvGYUYh4p/V1/PFsp7t2PpJrfSDwFsclZOStoO3XjDC18xdIdtJfLDb+D4irEEawIZmnBLGmj6FEFHClUV++TQ32IJ8271JxPh8VhSHgSw2aja5RWvg7UwjPJ+IX7KyFa9PVsPa2A/4cpDnng6zFSvg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by JH0PR06MB6702.apcprd06.prod.outlook.com (2603:1096:990:35::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.10; Fri, 17 Jul 2026 10:59:09 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 10:59:09 +0000 From: Pan Chuang To: Linus Walleij , Maxime Coquelin , Alexandre Torgue , linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-kernel@vger.kernel.org (open list), linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32 ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32 ARCHITECTURE) Cc: Pan Chuang Subject: [PATCH 4/4] pinctrl: Remove redundant dev_err()/dev_err_probe() Date: Fri, 17 Jul 2026 18:58:46 +0800 Message-Id: <20260717105847.131359-5-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717105847.131359-1-panchuang@vivo.com> References: <20260717105847.131359-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0036.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29d::20) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|JH0PR06MB6702:EE_ X-MS-Office365-Filtering-Correlation-Id: f472ea65-554e-4378-9a0c-08dee3f26d92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|23010399003|1800799024|366016|38350700014|6133799003|56012099006|11063799006|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: LL1800VZtzK5977+INMp7KocXnj5AtNTlNYC+NBE0DS96ou7X/Hf2XSVjSSVOUZMJJh4gTmro1qermrx3wR/xaQT4C8QopbzYkJbyJqKwbeIIQMQCO+g+rK1B3hH8DbRIJmhFF9THCgHOxj/KQYyiNOzgNdfaWpo4HfjpOz1TvMO60UsrVsaByQu5979f/S42xsCxPqtDDCLUP3VBUSuYVGExujfxa2dSfDKdCHC87NZININzut8VAytHP4v8buNzR7txxjUuknjJvsB1YD7DFEAQu0sOuK/SXs4wvfi3Xx3J/ABIp8C7rRoYVM302VZhLJRVzPCTBBwMuksxCA7qhgO5w2+VWR2orwbMYFG3ix9Te4RGxuXNYsn8+WuAmX3gKqxjXPIl4oOHy8epnCjpQd7zlg78sC3NVwHFEUo28m7//q63/SjThg0ffV6+hMjfqD2z56lZBhxFAmEKyKlc/FbafgIkvbNIp7JeOlIaULZ2j5I9/RIiiUOhEOx2/rPutpijaUkj87TL8t9fKXhz9WzrBrw/ktz7Cx0yUqkLVh0Vz2qPeBayqcC4eZ31rcekoaGkNV08w4VJMhuHmjohgVpZlRn1tkFJaqw0qd7W+cXbLhmJMsq+bJQl7BRJIY46xQ0Y5k4OJMTXjh+s4vq4PO8W3P1NydFJMxjoMGoZas72AgPXeA/RfbPOW4U+nRawpXVq7l/KcsGSg3D85R9y2XUhBE6PE/oPBaQGws0xl8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(23010399003)(1800799024)(366016)(38350700014)(6133799003)(56012099006)(11063799006)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8+dGuizVYbrwsnu7klAWWcjK26iK/Ik+Gsmgv8YWCt2pSIHh4M/aCDRxVBOm?= =?us-ascii?Q?v7r/V2dWLu5dOL5/Dzh4CZasgatINOBFjykuBBWBu8pEFKGf9rwokBAYetj4?= =?us-ascii?Q?XZYP0IkKTdCMS0p7yWrAzDkFolrX2BInLQkFsiMNogCKXy3obHDaUV2bY+LF?= =?us-ascii?Q?NL2Z4rxjRhoZ5LG/2oJauYMtB+L2KD2iDAbJeH+Wu8Ba2WifasLLtfvH1Wf/?= =?us-ascii?Q?cGCTqxhdFEJK9vd7RYjHCtsIS8y4teuIZFobwC0LKWrWjTSuuQrNIQpcivPa?= =?us-ascii?Q?uVRw9tiQ5PUclsHUy8LvGoaxdzF+wO8kviwW8fzLtnz/tNjNYvGaqkYLddDd?= =?us-ascii?Q?rg7oprW+1wlPMsCdhcmJ8LNtC9wwGlMxkfivTnAxdLD+w9KGE97jC+f7LoRS?= =?us-ascii?Q?toPpIxrqXzy3YBIJftAL1fs/n04+706nf7t6n5aDI1ucHhpDUwHFrJbX+8LM?= =?us-ascii?Q?FoJiaMkXwl6NOGdBvu+Hi6FF4rUBTixDFukWl1EMYFIuR2/15T3hnePp3OPv?= =?us-ascii?Q?3NV+G6ZxKl4TPpc1zx/9UewCGuo8vqRms8Gvtt8AoPMgLptxyDAhnma6EyJz?= =?us-ascii?Q?DCNMkhsA2a+Xh2vwshlOJ/oLYLVFCJjL1/gqdMA3j6VIOwPrtXmKXCRFbMaq?= =?us-ascii?Q?RtLWApWFXGBX6hLFBpcyXjryXYbW+68wDyVZMEbnbj47aMQ+jcdn5mxDVZoH?= =?us-ascii?Q?dHc7NNdpEfCeGnQ2OewfwZEYdDXh7zzgifPrYcuX+wyErBj0gSq4OMgVOplr?= =?us-ascii?Q?2XIzoUiprM/ThGc46f4G4kIrTSBHTocv8nNeJxvCBlATfjoHrdLtk7T+OQjQ?= =?us-ascii?Q?ivEF2DnVqvf7LxzxTU8RyIKiUKIR8kFQJtA+o5lHrvFjwWCuE7WKfzDMfx5C?= =?us-ascii?Q?PY84ulPxLsYjNiagaCNWG6RFa4xPF9JLMFhBQ+z4BA831KKrDfLqLcfEWDif?= =?us-ascii?Q?FhvPUPWLLRlI9EfzYXb0MCk6U96EtJCLAu+DzivPMgYmNPo1cfacOFn1MvRh?= =?us-ascii?Q?4YaYT9aaTUYP5QkAV1sD6c2Zku2m7qjB99onJe9gI5lbjOBXKCb+NOi70Qv5?= =?us-ascii?Q?yrvr91WdqSfSC4LdYib7MV28V2TnDoOoFOLmS+ub4to4kqqcExrr/5AdlmJM?= =?us-ascii?Q?Di0jKKFegekq1YXJaH0wwlWOtUsd1iC+4/7+OYxR9r/mhJ3zQvUgv0JPCx+F?= =?us-ascii?Q?uLa9FXLwl1E2A3EPW25aLNGH8XEo8UDLEx3cChRH1SBHie+opxB1F7lBIRyU?= =?us-ascii?Q?cdi2F/WRvTB9XhBfkTBasq5JKqKKH5UVhGrVT4wobHLM5CwEbqPoTPGTQxwX?= =?us-ascii?Q?Y2Ee3ntPFrMXOnzeVoKEIWjdK2VIuHezfescbg+TA6GMlW5UEb28ikWyS97a?= =?us-ascii?Q?KEBNunqMZfOeAo8PPV5F+MHfygNjBBnrEht3x4iIPb85cGrBp59i06vpTwOo?= =?us-ascii?Q?8/1pz4pDAgOpDgdtJ7S9em9pD220URvnT2rin40tokWoqAFI2zumPVJyZSNg?= =?us-ascii?Q?YZdOSEgPeOzoBB9bM0pTR4sTqD7Wbl6KJEoAZ73RKSQsHk1RcsarFl4+orZU?= =?us-ascii?Q?W4AQNX7rAFmO8GvpL373WfhWOE1MouJJ6jvIFadabwWUIUpwesXDf87MMyem?= =?us-ascii?Q?pY//DBfohx4x/3RcXw3Pd10mu5r7VzPyoDMhBgadMYP4TPD70cz2OOK/NB/H?= =?us-ascii?Q?n5yZld4Ix4TateNDgtn09b5CQRvqDkfKE4UUUd4TbLKUHhrNVUklJvN3fCGC?= =?us-ascii?Q?mhIRnWElyQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f472ea65-554e-4378-9a0c-08dee3f26d92 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 10:59:09.4448 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NFRUfRAdbvzSlpQzmR3fUQt+Hvzd8iP3CznBFAZMjbreuTB4zqyIR20cl0wMypc7bB0I7WAmzXMEW1Vr1s5TRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB6702 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() and dev_err_probe() calls. Signed-off-by: Pan Chuang --- drivers/pinctrl/pinctrl-aw9523.c | 2 +- drivers/pinctrl/pinctrl-mcp23s08.c | 5 +---- drivers/pinctrl/pinctrl-stmfx.c | 4 +--- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-aw9523.c b/drivers/pinctrl/pinctrl-aw9= 523.c index bc94003512cf..a13b1cdb78ea 100644 --- a/drivers/pinctrl/pinctrl-aw9523.c +++ b/drivers/pinctrl/pinctrl-aw9523.c @@ -817,7 +817,7 @@ static int aw9523_init_irq(struct aw9523 *awi, int irq) ret =3D devm_request_threaded_irq(dev, irq, NULL, aw9523_irq_thread_func, IRQF_ONESHOT, dev_name(dev), awi); if (ret) - return dev_err_probe(dev, ret, "Failed to request irq %d\n", irq); + return ret; =20 girq =3D &awi->gpio.irq; gpio_irq_chip_set_chip(girq, &aw9523_irq_chip); diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-m= cp23s08.c index a4f0ba728c6e..cc668f84bf8b 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08.c +++ b/drivers/pinctrl/pinctrl-mcp23s08.c @@ -559,11 +559,8 @@ static int mcp23s08_irq_setup(struct mcp23s08 *mcp) err =3D devm_request_threaded_irq(chip->parent, mcp->irq, NULL, mcp23s08_irq, irqflags, dev_name(chip->parent), mcp); - if (err !=3D 0) { - dev_err(chip->parent, "unable to request IRQ#%d: %d\n", - mcp->irq, err); + if (err) return err; - } =20 return 0; } diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmf= x.c index 03ee13844b50..935cace7f645 100644 --- a/drivers/pinctrl/pinctrl-stmfx.c +++ b/drivers/pinctrl/pinctrl-stmfx.c @@ -727,10 +727,8 @@ static int stmfx_pinctrl_probe(struct platform_device = *pdev) stmfx_pinctrl_irq_thread_fn, IRQF_ONESHOT, dev_name(pctl->dev), pctl); - if (ret) { - dev_err(pctl->dev, "cannot request irq%d\n", irq); + if (ret) return ret; - } =20 dev_info(pctl->dev, "%ld GPIOs available\n", hweight_long(pctl->gpio_valid_mask)); --=20 2.34.1