From nobody Sat Jul 25 05:29:25 2026 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012039.outbound.protection.outlook.com [52.101.126.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DBE63D25AF; Fri, 17 Jul 2026 10:33:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.39 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784284394; cv=fail; b=m0xJh2UfRVt7NvtciZ/30et0GjN6IEt6iYORiCRv4HGCg9m+TVdtZA4YkgDoW9FI7M3q6Qmur1dG0kqnWl2LKqLbZtBv5E8BCTFYTmUZe6J7rh+bleMSs9+xlX1lLJGY8tl0oLPW6IzZ0Bh+1BdHSHFQqs7Ghg7gzcLDvljRyao= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784284394; c=relaxed/simple; bh=p8Cuxoz2RC4l6beSn/KFAiuPaIKGo4+vBjoxI0lHW6o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=XC+hr9uU/ImjcQAgCx0llW+C/5ol/q6+AMJx9jrJnP6Il+WcqfflTlf2H4E8CBb7ysEWjL7iA4F0BD9toHxMuhg3jiT1+82Ul39cqLBWk9LQT4BLQ2MZ5UgJLEpiETHkQ4TPmOs7S69CjiyGAPMhuyi3sG+zVa6w/UZ+n+dKBgs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=R6KIgU7u; arc=fail smtp.client-ip=52.101.126.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="R6KIgU7u" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UqpA1hrmYZxmHbU8VNJCEGh3Ses1SNShUA3xpLFZpUpdtB7kbxUiAUg6V13uRZB2G1Pbk0yI3j5SO8D2bFtucynqJ5yQ4v0/NjiAerbMg9epmXf7W3TRpI8mGfly66MuH7BnT12oTO095E2MIYl6oMpJ1bB4evIOGjGtqwVn48kXhaCXdEqgMapaPZv+iGNxbUH1hkhZ2XSY33XiXgbJBTxzBc83RWoQdWaNwk1PuzMyi7JA3wzqJfP5O0ZvuRvNhVlKbGZ7mR17EuvPHe999nsW5fuurWly/iFDlj60fgHUXcPfEXjXCykwvY/rnitiSHr+/GZTNkpRoEsIKQqCvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cU1sHn346PJX6moDyJFmlx+Rt73kxTLNJGH3QUMjqFo=; b=OLgwMV0TYVn59mjgDwIs//9sxKH+KdgNZ2EuSh1jDrtFb/RO1f/IUZp59QQwkv5falb8+PgetBRyGpVCeRuQM/dl8/uGhaGVAvtt8g1OPh+uxnd8f5ipjUcXe8RwtS6d4cvPdpb8AT2hEGbj3ntzbo9hPEUxbdk0EaytSJC3nK2TyTA8SFMcL9azz/1j8OFSCRJX3qusoXGu0CSUrQu5cLtG01HvtHR0QE11lSTGIhPh+bye1OHOSmi/trlwW50sSn7XiZtu95Bk/g3kIIa2K8/VCzdoPaEfrLxWeYX1hFPsyS7lvguN6lE5mMXrcqxXM9PyDzQR+M8LmfmWwHbtpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cU1sHn346PJX6moDyJFmlx+Rt73kxTLNJGH3QUMjqFo=; b=R6KIgU7uQIWvFBWJtIDOD9ESCGg18LHdQWg9wOgC0lvGW1KKqyHLkcWJoy4/9JEIGPORd7quNpvrVJ0ZaoRQVmullVabTcJOqsG9+bmAFNyX3mDC8TfBR12FlU4q7fZckoDJPzTpLZ9zyJAxXTMxYV3cASB9g8yKW+QqjxJ3djETvIeExxUJfHwqBjI+cy1tZVmDY/0XDH/4atfk9UyfOfAg1PNte3aSa/TAoCI4kCMadCEiPgpVJ6SMSWcUTrMJLFXLnWxVTTce0oQkwZsV8OcuK1+NqYRZUT2QuHMNAo9oEg/yh0nLSyGFhRok2Y6im/PXZ1CFvzoxPwCUrCOxuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by TY2PPFF72AB57F6.apcprd06.prod.outlook.com (2603:1096:408::7b2) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Fri, 17 Jul 2026 10:33:10 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 10:33:10 +0000 From: Pan Chuang To: Shuai Xue , Will Deacon , Mark Rutland , Frank Li , Xu Yang , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Ji Sheng Teoh , Khuong Dinh , linux-arm-kernel@lists.infradead.org (moderated list:ARM PMU PROFILING AND DEBUGGING), linux-perf-users@vger.kernel.org (open list:ARM PMU PROFILING AND DEBUGGING), linux-kernel@vger.kernel.org (open list), imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM MAILING LIST) Cc: Pan Chuang Subject: [PATCH 1/3] perf: Remove redundant dev_err()/dev_err_probe() Date: Fri, 17 Jul 2026 18:31:17 +0800 Message-Id: <20260717103123.34887-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717103123.34887-1-panchuang@vivo.com> References: <20260717103123.34887-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0042.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:7::20) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|TY2PPFF72AB57F6:EE_ X-MS-Office365-Filtering-Correlation-Id: 088a27c1-d73f-49f0-054a-08dee3eecc3f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|7416014|52116014|366016|1800799024|921020|38350700014|6133799003|10067099003|22082099003|56012099006|18002099003|11063799006; X-Microsoft-Antispam-Message-Info: 7WjmlvgKKCajrfHPDDS6r1JQnmP71yfN3Bk5iiZIpMKlpo9EYHC8+i1KVW1V3qByehRi89JS2RAHNJP1xZeQZ7676aUlN0lvkCjjk6vGb2/ENBfpouhwMHlAxxJ3xy/MIfKq0sB2WhV9i1qe/jOwkqE94wrWV9U0OAAdIhsb+eSJI9E0B0xl7PcPflSSi6O9ilF36BWvJZ6neFNfdnE4BDxrrviZIRGDzreU5OMrmdpvZHgg0gtO8NAQnU3xM2TJcdsRffSrbmTpDIpefOCmEyuNo2SfO7cQjdID4Wmo8PlZVO3qO6nsl7cln+8QZCsy+kmn2WICWMkB/n6JeiGN6uMHN6f5Xj2QdVL8geQvfs/JP3RfZS819NJ3pcxYb4kKeCoEDVIbnF16HW8u0C1E4BeatFUfk+zZqERhXAgSJM+/N1r4so0WzJsJiB03hPIWKrVyj0qDf+qB7qyzf7kOlji95zbYlOVvwfqRk/iY9GIh8KkXObNrFaCBXHYa6Eo16JiIaiSeWtsAR7eBTJ1nDA1Cqxmwd95z6tB0B3hv2PgwLDuwfDG6uKewOrpZ0Q8NPJ02HsSDvtBZA88+Hzcl4naYtBE3ko/ax/IM3+/JOdoDQnhvWKgXEZtlwFHIbi7QLDe0V9yXj6RNGsblDhQdaIjSg8Y0QPmMTGLbT6il5JSaiU30WIu/4jGC+LAH3lCqvgdsUByT/NZmvgDIXJIfVa6Lz5hfS+8rFsyhNfPRRtI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014)(6133799003)(10067099003)(22082099003)(56012099006)(18002099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DZG6LvlS1hxxrCeQF56OA+Wx6JdR+E2ZN/n4E+PrJE1ocsMXDomDdwdM068k?= =?us-ascii?Q?oI6GoKpQWNHr0Gp2LFe7hvoYnfZ5IN7UMLzEyEJz7P+JxwIbtfyefmtcqgFJ?= =?us-ascii?Q?FK+knModb9YvlQefzqKuiOLL0qyiiEgHR6k5te9PHGRSUvF3f8yP5IOOj8hA?= =?us-ascii?Q?b5JjGKk47WMINR5/5r2n/YcTA0GNYowijzs+EzNC0C5AH+QK1aqgmct0nzX6?= =?us-ascii?Q?jfikINVllqErBrJCs+9UikVQW0YyFgftWzbjktrWMWVQwO8LKRlvL+IO524o?= =?us-ascii?Q?qHm+WCRqRAs+J0lNDR5nOCwWwk6JeTNTv4UYBmau1V/qBniRlNkXSsAxMhEb?= =?us-ascii?Q?JLztMrQucPmKp+nJU8K9Uppkx0UNU705OgK0bAGANXLGcxfGC2ZLm9wvFFRm?= =?us-ascii?Q?Zv8F7J426kmMcGwq/xH9nLKryRetGXBPD7T7WnX9Y3EK+N56e+tR7u0KCoKK?= =?us-ascii?Q?/TW3qYCUfs/M6QFo8ltO7brJn3FiV+ZU8vkoyzMYUjk81CqyYzI0vYUOWCcF?= =?us-ascii?Q?/f7cBq7idPCOWbDfDOI+XHZq3ydO+buJ16A8LGESYDkHN5a7Hb6cALZk+0PC?= =?us-ascii?Q?ubcoKKEPoRWiGwFinltChUxNK+XrOokQEEfaunnHyxlnK7AFxecSi2WiLEvs?= =?us-ascii?Q?mPKEZWk6sfSOctyhc3wOVG57mcP8Szl1IrSB6yOppJoHK677cwi5Cle0gxRw?= =?us-ascii?Q?j2WnUoo+mCdFWuCXYkSWCr5eL/kVi/w8XUrcueBru9dGAS9e3IaigGQA56VS?= =?us-ascii?Q?wDdf9XXcRE2R9IGD8SE72kUdArLVMB5V1Wya5HrCzi99w68WaROp9VPVZvCq?= =?us-ascii?Q?mNj8ezxaHmYWzi8JeQ6HdJaa8PNRTRLdJsI/XPgRByOfXnXhGxRUeab8P3+a?= =?us-ascii?Q?G4BxwmnoIGiHhicKiVvJ89zUm0GHRefWxkJjAhWpZ7oqLPi8X/T1tmedNEpZ?= =?us-ascii?Q?sgg1c/fY2BRsMLqxQPp7C8PymQEAPR7Rdia0QvVbsLL8586djjGjEZXVPY2s?= =?us-ascii?Q?oAche7qHRLZV8WYhcYx5rcdpSneqX2J5bP1NleDlihxKsNXXZWVygeQX4g7p?= =?us-ascii?Q?pd7GNkXmQ41oAL+jPE1RCVfsBJaQHqi5vYdmfv48126gp58zfgj0bZtvWe57?= =?us-ascii?Q?wyLpfodprkME4NwfkPHZkVR/j71FeteluInGGJ1272lbn8FrgNj1DjeY1dxs?= =?us-ascii?Q?kvIuGVQxo48wldowQ3dh5V1Xk/2ZmPJCCQpbwE0xlNb4XEt5O4gLjYt0RFnr?= =?us-ascii?Q?B2dHixn4u7A9pqNcJHJB7uOFZKWRvnaOQ6/QDqTiOrkUvBFOtIxWIYhtMB5b?= =?us-ascii?Q?u7bdwb1poCEyVwkDVdCFhFelKA/YdIWE4zQcE5LZs3If3GaeFW+Q+lb4Cvbl?= =?us-ascii?Q?McHTXJbk9cvflpWYb3Ln1IWDmCMHaVNnPA7uRTH+9TOiK5wmH4kMI9vpQHaR?= =?us-ascii?Q?sAyH2JK7MDaDhpw6wDVSU+oZcr+ED2GEMb1cN4Uu9qgJT5Ku+Tg7ma/tTGTY?= =?us-ascii?Q?NKi9eX5JxqJez858Xd4XU8tTZrJc1jJC5+MtNJy/TXPdPeP63PJjSkHg1Z4l?= =?us-ascii?Q?jDM37E22WpKaBCdi7Tst/+a4eRYzDMwfeWI/RrUUqlmGIv8+igiK93zq8v1L?= =?us-ascii?Q?NTkldDmU2ypFqNN5oR1+6nwMEc/+pa3hYVqjlIdaUT9iECoDF8hcVLjR3HlE?= =?us-ascii?Q?q3TCOFxDpMA8eaZ3KAniH+KXQcysfepAIJibLoY/4G+O2zKSFlJWT2aG/M6t?= =?us-ascii?Q?JLDckrgxYA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 088a27c1-d73f-49f0-054a-08dee3eecc3f X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 10:33:10.3959 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7bfq9lNvZHgWwqSDC76pcInqsTrhEcnVYD10NHvYGzJ45NnGiWfWFEdHao/h4G7534MDf7apRWm1MiDPzIE6Rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PPFF72AB57F6 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() and dev_err_probe() calls. Signed-off-by: Pan Chuang Acked-by: Frank Li Reviewed-by: Shuai Xue Reviewed-by: Xu Yang --- drivers/perf/alibaba_uncore_drw_pmu.c | 5 +---- drivers/perf/fsl_imx8_ddr_perf.c | 4 +--- drivers/perf/fsl_imx9_ddr_perf.c | 4 +--- drivers/perf/fujitsu_uncore_pmu.c | 2 +- drivers/perf/qcom_l2_pmu.c | 5 +---- drivers/perf/qcom_l3_pmu.c | 5 +---- drivers/perf/starfive_starlink_pmu.c | 2 +- drivers/perf/xgene_pmu.c | 4 +--- 8 files changed, 8 insertions(+), 23 deletions(-) diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_u= ncore_drw_pmu.c index 74786a5dd6a2..fc934bccf4a6 100644 --- a/drivers/perf/alibaba_uncore_drw_pmu.c +++ b/drivers/perf/alibaba_uncore_drw_pmu.c @@ -449,11 +449,8 @@ static struct ali_drw_pmu_irq *__ali_drw_pmu_init_irq(= struct platform_device */ ret =3D devm_request_irq(&pdev->dev, irq_num, ali_drw_pmu_isr, IRQF_SHARED, dev_name(&pdev->dev), irq); - if (ret < 0) { - dev_err(&pdev->dev, - "Fail to request IRQ:%d ret:%d\n", irq_num, ret); + if (ret < 0) goto out_free; - } =20 ret =3D irq_set_affinity_hint(irq_num, cpumask_of(irq->cpu)); if (ret) diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_p= erf.c index 3760ebe02674..dd8046265584 100644 --- a/drivers/perf/fsl_imx8_ddr_perf.c +++ b/drivers/perf/fsl_imx8_ddr_perf.c @@ -858,10 +858,8 @@ static int ddr_perf_probe(struct platform_device *pdev) IRQF_NOBALANCING | IRQF_NO_THREAD, DDR_CPUHP_CB_NAME, pmu); - if (ret < 0) { - dev_err(&pdev->dev, "Request irq failed: %d", ret); + if (ret < 0) goto ddr_perf_err; - } =20 pmu->irq =3D irq; ret =3D irq_set_affinity(pmu->irq, cpumask_of(pmu->cpu)); diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_p= erf.c index 6fee5eb5087a..d59bc5ea3155 100644 --- a/drivers/perf/fsl_imx9_ddr_perf.c +++ b/drivers/perf/fsl_imx9_ddr_perf.c @@ -830,10 +830,8 @@ static int ddr_perf_probe(struct platform_device *pdev) ret =3D devm_request_irq(&pdev->dev, irq, ddr_perf_irq_handler, IRQF_NOBALANCING | IRQF_NO_THREAD, DDR_CPUHP_CB_NAME, pmu); - if (ret < 0) { - dev_err(&pdev->dev, "Request irq failed: %d", ret); + if (ret < 0) goto ddr_perf_err; - } =20 pmu->irq =3D irq; ret =3D irq_set_affinity(pmu->irq, cpumask_of(pmu->cpu)); diff --git a/drivers/perf/fujitsu_uncore_pmu.c b/drivers/perf/fujitsu_uncor= e_pmu.c index ede652f757da..fa64146fcac6 100644 --- a/drivers/perf/fujitsu_uncore_pmu.c +++ b/drivers/perf/fujitsu_uncore_pmu.c @@ -526,7 +526,7 @@ static int fujitsu_uncore_pmu_probe(struct platform_dev= ice *pdev) IRQF_NOBALANCING | IRQF_NO_THREAD, name, uncorepmu); if (ret) - return dev_err_probe(dev, ret, "Failed to request IRQ:%d\n", irq); + return ret; =20 ret =3D irq_set_affinity(irq, cpumask_of(uncorepmu->cpu)); if (ret) diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c index c0c522b10b72..29554cca22c5 100644 --- a/drivers/perf/qcom_l2_pmu.c +++ b/drivers/perf/qcom_l2_pmu.c @@ -869,11 +869,8 @@ static int l2_cache_pmu_probe_cluster(struct device *d= ev, void *data) IRQF_NOBALANCING | IRQF_NO_THREAD | IRQF_NO_AUTOEN, "l2-cache-pmu", cluster); - if (err) { - dev_err(&pdev->dev, - "Unable to request IRQ%d for L2 PMU counters\n", irq); + if (err) return err; - } =20 dev_info(&pdev->dev, "Registered L2 cache PMU cluster %lld\n", fw_cluster_id); diff --git a/drivers/perf/qcom_l3_pmu.c b/drivers/perf/qcom_l3_pmu.c index c8d259dd1f80..e18d0f94e8d8 100644 --- a/drivers/perf/qcom_l3_pmu.c +++ b/drivers/perf/qcom_l3_pmu.c @@ -767,11 +767,8 @@ static int qcom_l3_cache_pmu_probe(struct platform_dev= ice *pdev) =20 ret =3D devm_request_irq(&pdev->dev, ret, qcom_l3_cache__handle_irq, 0, name, l3pmu); - if (ret) { - dev_err(&pdev->dev, "Request for IRQ failed for slice @%pa\n", - &memrc->start); + if (ret) return ret; - } =20 /* Add this instance to the list used by the offline callback */ ret =3D cpuhp_state_add_instance(CPUHP_AP_PERF_ARM_QCOM_L3_ONLINE, &l3pmu= ->node); diff --git a/drivers/perf/starfive_starlink_pmu.c b/drivers/perf/starfive_s= tarlink_pmu.c index dc4e653761fc..98e5ccee2fdc 100644 --- a/drivers/perf/starfive_starlink_pmu.c +++ b/drivers/perf/starfive_starlink_pmu.c @@ -435,7 +435,7 @@ static int starlink_setup_irqs(struct starlink_pmu *sta= rlink_pmu, ret =3D devm_request_irq(&pdev->dev, irq, starlink_pmu_handle_irq, 0, STARLINK_PMU_PDEV_NAME, starlink_pmu); if (ret) - return dev_err_probe(&pdev->dev, ret, "Failed to request IRQ\n"); + return ret; =20 starlink_pmu->irq =3D irq; =20 diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c index e9e4871db08d..ab3623fab914 100644 --- a/drivers/perf/xgene_pmu.c +++ b/drivers/perf/xgene_pmu.c @@ -1876,10 +1876,8 @@ static int xgene_pmu_probe(struct platform_device *p= dev) rc =3D devm_request_irq(&pdev->dev, irq, xgene_pmu_isr, IRQF_NOBALANCING | IRQF_NO_THREAD, dev_name(&pdev->dev), xgene_pmu); - if (rc) { - dev_err(&pdev->dev, "Could not request IRQ %d\n", irq); + if (rc) return rc; - } =20 xgene_pmu->irq =3D irq; =20 --=20 2.34.1 From nobody Sat Jul 25 05:29:25 2026 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012037.outbound.protection.outlook.com [52.101.126.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AC143EC6B8; Fri, 17 Jul 2026 10:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784284400; cv=fail; b=UuY0ZkSRkprqQDN6pUsuYjOYwvbR+GAXo2Nqe3OJDqDa0TQ2mm7dwsoAtsDOTlTZlOKX6Ajs6KzLuYjn2+GyrknXPrhW2+7BopHW5REXzmIg3AtnHuNmdJ0/z+ylROoC7XGEue+99nj/TnF1mUCACt/084VPT51HFpv0ufQUb2o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784284400; c=relaxed/simple; bh=zZM0APSLQ9vU+bsya1rDm0lnWuQpnxFdp+HltEISuJs=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=bRsOreEoiKLbeUrXJSrtnY4fmjUUeKt4awgGWOJ+FmyrjvFZMoxB3rGk7vMKU9fCjoCDZNMFl+YV10atA8Mm7C4v8zMS9jbe5nupW4oNrfa6gR7Jy/HiEekyDnrvxHa7v+4xkIN6Z9r4EvbujKsHaWedhR1NtYEnU/WV2AF5Y1Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=T6dr89Wb; arc=fail smtp.client-ip=52.101.126.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="T6dr89Wb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jski8lZJEeNsNNNwEICJQ+66LpUqnwPlwW13hKd4lBXyFsX8kWpvSzHwk2cNsr5vMLo6mAb8ZwsMjzXoL5LbUMAiSCpgToVAR/t8YIwlMF+P5GGEhGAqgN1C50P1wNv7+mV7Cqqs4TOfednhYXuNxjwlrg99vFySTIXEJmm3sPuZmgnugYAe5qRGbIHFZ4Rw0w/3/8NOoB9t05KA0ACZSl4xI2P3q6Xm+s6tNwp/BxQli9EoReByJhq9yNs8qP4p0DF1aYVm628+Xg9Xtr+SweN7yelrTFoR92gK6UuOXCZHXJ6XJo1fK37A5mgn2KNmhTxfs/3EqNzKdJZ4I8peww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qqLKOy5Dwlv7qZqjc6PzehiBiHD7xL1s2xKrnFHLXQk=; b=UXAoWWvGhZRe1cN/txMp4rwkspTg3pNXL1u18qbzo+EcjDOmr5bkoPQLTl2Ja8pBR4EuS3dgP1N2ksFCgRLudnCGFlyReyJYXcU9hdS0iWIFPKOzMiCcbjrkYRh58jUYoBkc1xB1zqSRTGLIKmdRKv/K7zXMt5+c3yYxrKPMOhCDNTOPDX8pf9FhjmkuvFPU9fsINTjr1eG6noHLImBfPG3bdCAvWLMIgKZ/gnxnGM7lVtFVnE2qb8ymNlAgXkFMmIhrFpbTKOg84QS33I9JkjxxQWCXwathtxnECnbSjniDTqHk4OlKqrCTmjWuhle1i2jr6+IlwdomkoCVY3MViQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qqLKOy5Dwlv7qZqjc6PzehiBiHD7xL1s2xKrnFHLXQk=; b=T6dr89Wb1wiJ36r7/6i2R16PnvNKJdk7cZ9z/Ae4w7sGmSMdL29MpuC29cPX1ZJCO0sWgq+EtdpraqKFlyg9Vr4JCPWgOW+yBdloU3mApnkSCxw45V303ySRxGSovr1W8+vIaJBeWcWJoOryfVENo1LzxdDuLSVaD0OCOiKYM4I5G1CyzcaBIhg2bMll7mvFKS7z44MFrx51UflY3Dv4Lyt6CUQPi+uQgJRcoeKHv2TzqqNEmZWVVrMLP5D2s4bEU+Z7bZWlr1eMCkSopcStHmML1ag/sE6kLQkYs1C/uI4rf/5dbsp+8x38+7TvTOuxslq5/tqiNOy9c5Ye59XjAw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by TY2PPFF72AB57F6.apcprd06.prod.outlook.com (2603:1096:408::7b2) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Fri, 17 Jul 2026 10:33:15 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 10:33:15 +0000 From: Pan Chuang To: Will Deacon , Mark Rutland , Besar Wicaksono , Ilkka Koskinen , "Rafael J. Wysocki" , Ma Ke , Chengwen Feng , Yury Norov , Pan Chuang , linux-arm-kernel@lists.infradead.org (moderated list:ARM PMU PROFILING AND DEBUGGING), linux-perf-users@vger.kernel.org (open list:ARM PMU PROFILING AND DEBUGGING), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/3] perf: arm_cspmu: Remove redundant dev_err() Date: Fri, 17 Jul 2026 18:31:18 +0800 Message-Id: <20260717103123.34887-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717103123.34887-1-panchuang@vivo.com> References: <20260717103123.34887-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0042.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:7::20) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|TY2PPFF72AB57F6:EE_ X-MS-Office365-Filtering-Correlation-Id: 1defcdc5-efa5-49f7-5f49-08dee3eecf2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|7416014|52116014|366016|1800799024|921020|38350700014|6133799003|10067099003|22082099003|56012099006|18002099003|11063799006; X-Microsoft-Antispam-Message-Info: /kuNCv1tH9ijh2YmzZ/imwyKd8r5N4N5FFdvFXPvJmw+khtGXzEo/EAVm+rDzNEgIs2m2hQZZz4OwcrSsyAtCVhZnd9sUyU+uBzseqocZA/OY7R4GglSqO1+tEysLLVeGxMvZEqGtpd4VCzrCaMmEcSs6PkJGKn2akQS4PbW5khq9q31GYG1IhUS8bx5okBQNMIPiwJleOIVtZEEYhNEeBSTOA1K9TZxTFKqb87PcmD9m5JkK6g+Iwy25ySwbpqG5+TLvds+BPazom826h9eBMAiAUmF5DNnKXRCHdSxmDLi7qNP0atnCbqKKOrpfeJ7tyKwlPeYR/SIQMeiNc2X7twXy07WTdPneeiaqvRkychMBLCMKrtrEQPiXcDwAqkj3zYv7ccxWouSiJSxkzHsMJjP9YmNyCrTWWoUy5opXyxRo+RM/gjTKoD2wWGZxmAXclT/hYrYEeN3t+pBf1N46gOBNEGl+EhL1JdA9DPc+O28M3kGKo8ZK6e/544Jk3F+UG6QU0PJ3SNuwHeMWsDH5s1lzK+dYWm6/8Hl9Z8o+P8UxFH4zI5VwgyWxLMHuwn3gFTlzj9FpJz7n8Z7DnNncC0IyXgrHWo1IBK+9zlcKw3MrNcmhpgIEs+i+rwaC4e/NDwptV7fZEZt0WFg2GNKS1LmRi1T0Y/3dieSeAnbIqiM1qmXVd+pIQ3mEivDJxdFBJIhCiFdrzGhG1XXmSUmmlISqi5aEAfDGAyRz97aBWOySr+K2gUy6sYtYkCevmnv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014)(6133799003)(10067099003)(22082099003)(56012099006)(18002099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AheHZeIWrNeW+gm/IyqyXR91+h/QRnO50Ud6cWMUostDqSBUX+BlcAkTXkRS?= =?us-ascii?Q?xbG25TILd1rwRWl8pD5b5rl7+EiGTgpnLeIUixB17mu7+WElzloslxMYKR0w?= =?us-ascii?Q?Ml7N1jw1H8FkdSnZPsQ+fX2qMzRl7XbQQrr+o8nj4P0DN5bTwvXBLNLhWAB5?= =?us-ascii?Q?nF39d+tkv+LbzL7iTyfW2uDQmJhEHtRJ4rJK1WcEpiZd9kkfd4VAbvz6yJwG?= =?us-ascii?Q?dLPZtDLi140AaJOxU9hgShQjPRivZAPlu8OJiu7CDC3QxzpE1VY3Wjbg3utU?= =?us-ascii?Q?FKgvefr/mDFDlNXXWcoW7m4tsHOos0hHMedNW+2mRyxIYeT3ovXIWRmKs7V1?= =?us-ascii?Q?3qe+SDaA/zn2IjmZj66daazpazQna9+duH1AYq+HjkEmJBpFi8Zs0e2ecC0G?= =?us-ascii?Q?yHlgVMEmIY4Rh7DM5kIWTIukYc7G+gmONpoHsW3hqem3LipsGQGQ3AMEinOa?= =?us-ascii?Q?oeOMuXk6E/bsEH+8FrYm2Izx2EBNvmMtnJZbQx59rNGrgde6pjQsWI87HdyL?= =?us-ascii?Q?Q+riHeBVB6Q7pBo3mMMwObr2VjHsUTZCs8dTrjJDvZgSLkEFhGj+g3PBH/oq?= =?us-ascii?Q?jzi4ep5fnKW4qulKZOXHdugrOobmIcTosT2N0piB5WgvbwZd0IFmXrTin04f?= =?us-ascii?Q?Vbihcmp9ckxS0bz7oqkGKlH61LdCrsuqo7r0ZC/CdZMs3dPQvqFH0bxbFGCS?= =?us-ascii?Q?vZNzpb58GGeAuHU/pTPeGeeGagTxFyzif5nypzNCJzw+1/c0ghRbUBIa+87X?= =?us-ascii?Q?Ts2b0ELzMraiZU80eXzzTuIsvBGL4ye2HX5FABWPTMV8efv488AEUkwHJ+lI?= =?us-ascii?Q?z0Bf+1quf9rgkLbKqV/2mTuqCRkUNk2pGWBGyYweQtp079Fp1qn2czFiRohT?= =?us-ascii?Q?8bwYj563Xgc7KXl5nLMWgFzA206opE/JpU4K3u5TJqVLgg+EHjSr+VeDZQnO?= =?us-ascii?Q?/x5syAINI7t6v/Dz7npuYDWs7NnBd7e2jSOj0oa4GD55eCST+zb/EAlcK9Bl?= =?us-ascii?Q?SRPe7CLVyB62SQuwE40J/c3RlNRtasyZGs7nH3W5U/4xYzF8WcguiqkIHE/l?= =?us-ascii?Q?0eMjfCtkxJF+Ke/FluTe7mpwoirKIClhLrMNv7761jUjcoDhDW0c8JGu+cvw?= =?us-ascii?Q?/AI2efn72uED/tC6rdNzsdPfyHqzsedHnd8rXspse/yrhZU3e1ZnQXVfDXdP?= =?us-ascii?Q?XPJhq30Od1bbjldbXwFFExy+uB2qnMRX4Ml0TLiJt1hOlmfRUqYmXd0+VIRj?= =?us-ascii?Q?ckGNkUZK1xxQE6nRbh+YRzNqRnJQybiTKjjB3noT/ZoKDUNK+3Vvytn9hP35?= =?us-ascii?Q?tDA6D8aSjhrYDsvjXKqIbf+1UVQyZsY3sTvSoO1bzFRH3DfqJJYx0dFwIMRd?= =?us-ascii?Q?ADDCVY2XlLKah+9k+eXQmQceHNlO2PeFH1qxDSaaluXngtT8niaOJvFec8Hb?= =?us-ascii?Q?+l38lea+1fY6GpjfmR1KW9/g5Q6x9mM8RHQOtrPs5+nxJMqQxs7SrAryH9XK?= =?us-ascii?Q?ELkzzISOy5robwVEv0HajwQWdvlGoB/Tav9W/kgNISceuJqN4+lAlC2P98gx?= =?us-ascii?Q?inxCOxTYkZsOIJXrIu+7IVzItBpuZdjZWOpDOIj0K/iqJru3DCOSFZzQg5oc?= =?us-ascii?Q?1e1Jyb+elp+3hA6KP7aP4WHw2QleKnwdKiNHjGfZfDt9uiNn+2Em2uwQYO+U?= =?us-ascii?Q?/3PNo1CsJp95r4nfhi5++VzpwbaOmY05Gy+OUhj3Pp9vwpA1N+uLzJAVa7Cf?= =?us-ascii?Q?mTUj0/IxRQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1defcdc5-efa5-49f7-5f49-08dee3eecf2c X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 10:33:15.2911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z9kBKpyjiPg6SAm2Ya2+8IJc5QcvurPm3myFWObqivbvZRy5niRnvUCeyW1BkGZNeYDkQvIkO4l3pbv3/wBXIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PPFF72AB57F6 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Reviewed-by: Ilkka Koskinen --- drivers/perf/arm_cspmu/arm_cspmu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/ar= m_cspmu.c index e6292021f653..ae754363fba8 100644 --- a/drivers/perf/arm_cspmu/arm_cspmu.c +++ b/drivers/perf/arm_cspmu/arm_cspmu.c @@ -1070,10 +1070,8 @@ static int arm_cspmu_request_irq(struct arm_cspmu *c= spmu) ret =3D devm_request_irq(dev, irq, arm_cspmu_handle_irq, IRQF_NOBALANCING | IRQF_NO_THREAD, dev_name(dev), cspmu); - if (ret) { - dev_err(dev, "Could not request IRQ %d\n", irq); + if (ret) return ret; - } =20 cspmu->irq =3D irq; =20 --=20 2.34.1 From nobody Sat Jul 25 05:29:25 2026 Received: from SEYPR02CU001.outbound.protection.outlook.com (mail-koreacentralazon11013059.outbound.protection.outlook.com [40.107.44.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EDBD3DD530; Fri, 17 Jul 2026 10:33:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.44.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784284405; cv=fail; b=m7PSDbgiSW+h1Z7T3MqdodqTq5iOpDJXPaRa5cl/WUvOtLOKVQrd34bz2qltf1jDuulf0CeyaY8Z/sFkkUheoBiN9X5vBU+4fDbshV6EZikbNR5mjescX3dEMiO9FHo5MSaqCu7BFbZa76TGwrIyE7LZ4qYkAHwM4gfU9HGagVc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784284405; c=relaxed/simple; bh=bTWCCqpOSSff+f9XWZY4L8WUZNpmprQZqCd3DdLO/ro=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=hVb6rtLbetKuJ2cKRISa8stwZADnt6vWWiYXaLHd2nlrCtTq0k8Jqxe5H+fIY8qjOkaqE8QWt9G1Oqcp7lcZ4+g+hwJC9kpnHSbcoBudvx17EZ5eX9t736vQcNYvjT6rNacQpMbERExg3//GX4upzhMq6btVdml1vdjsUuJB5S0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=XrQ4h+MW; arc=fail smtp.client-ip=40.107.44.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="XrQ4h+MW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L4nAhH7E0fJAfUMq/M2lADty3+KYJNvDrLQvBgrMPv7l4pM+W3m/8YQVHrb7VPqQdVMksRc4EgCtndkMQKACrLTDIa3W0jXATjTJc7N1vDOyAfwkBcwWsSnhLHxXu1b4+3OKozwiNycf0pLkM5HM4UIb63LwN00i3Mp+s5OEBActPLYgHonhEkiIk5dbVHC03ug8GxyEYYxEeSLhQ+qiIVMzwvybHrl/0ao13fKKFidUAZ3ixkSpL9KQ62zg/SUZ9+2MD9G2YdLQ7F1X8f8rYT1Bdq5Hra1j168UelaTy2HLuKCZEYkfaITXnhbGbLwhX34j+ybq/+21fhNSJSXKhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DZJhsxtfXmNDyCOSWmsurPxg1zibYRIvaLD3WuUi1yk=; b=FcYX83chG6t9j45hh2X8NQR4kAt3KESgxXk7RSYtuayX2K13pQwDHOwDEo9vrsUFUIzDZn4I1G1ZjwFgu7TFlQ+qFL2gwI9HWiBLwBM2OAzRKfzJ6SFjk55M/z2sRcnx0YQcPtuslTIIqF4gJLGgWAzw3df5ovOZv8//+RYJ4HZRbf5snVtZqB76c+brEkHj4I69zldgFHTBfXEF/YdSM/MpCEZlTdKNMDdf77Gu3dxrKfHt7AHjq/NiKA/fNIoLXpSlJEnjmJSuh2Le0vfDIvnnu2ALcbAUpAxxk8IFAYCTiSNqRsb3tuXTrR+PLd/Nne84/v+QuFwSlgskMq0a3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DZJhsxtfXmNDyCOSWmsurPxg1zibYRIvaLD3WuUi1yk=; b=XrQ4h+MWoa7QMbIWKqVuKEGQ09yWJYRs82qvr/B9CGVSrVLw3TfxXTc8xR+VYi3kXRpSKBXoupclyaGs7xCt1+BJEiKxYjcE52+y7MnzJdXSzXZ/PyZ9UygVZK3MC63Ad8zHdSRzInnSVm6XtuLwg0yen7WF/MfWfL56a5uclamJ4DxGTQMYDIRyB0WLgyaak1fT2oAa0icNDZP5U7AKrX/QNA0PdocuJ8OVIYeCwp3pHhfHy4UdZLoEybxH0AhEzXUZdttGGZv4Mg+vEKgKxjTo6tuAyYQOdh6S4gRE/sdjWq/6lv6IKkGJV7xXOZvcLBpx0bTOGVKdLHlZInFaBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEYPR06MB5765.apcprd06.prod.outlook.com (2603:1096:101:ba::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 10:33:17 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 10:33:17 +0000 From: Pan Chuang To: Yushan Wang , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org (moderated list:ARM PMU PROFILING AND DEBUGGING), linux-perf-users@vger.kernel.org (open list:ARM PMU PROFILING AND DEBUGGING), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 3/3] drivers/perf: hisi: Remove redundant dev_err()/dev_err_probe() Date: Fri, 17 Jul 2026 18:31:19 +0800 Message-Id: <20260717103123.34887-4-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717103123.34887-1-panchuang@vivo.com> References: <20260717103123.34887-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0042.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:7::20) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEYPR06MB5765:EE_ X-MS-Office365-Filtering-Correlation-Id: c6ed3ca7-5946-4375-bc95-08dee3eed036 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|52116014|1800799024|23010399003|56012099006|11063799006|6133799003|10067099003|38350700014|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: xeF9FnlfKtkHCQb+JfE5Fy9tP2sy/McUZZxyS2Zfw7th4pElM+h8vpaCKqUlOTCNTE22Bi6pTxyz4ZlFGVYgJQ6+0YwoAGW0pwvyY4MBER4Q6Bti4VNs202Cb4fctN0Lm3ycXGHxTZlbZNnEW/CgJ5n69JJ8djzxR89z/MTGuBK+HTK4VC8mZzFpgj50+4/va7xnT0AtHt4Rv09F5LsXOiir9sYmU2Tt+s2BjC0dxAJ1xzlwgC5KFEopMcL8Nt3GmQ+muuYf4KvOn35C0z5dCtAg2hGCy/QUJxfBqFX7SDJNly0gN18Jqhcj9Wngd7tZ5caNReTpPsSOA1W9s+sywQHrYUNu/mXqQpXKbClqPl1Vuy76djiwt2MjfIHXxpuE20Wzs27zvbnhKtrEgdh7DW1cBgj3ch15tF75Hq4jfWDHe4JOrM59J0kPP/M4x8inXgvtS4zCaPUjaNWPgkDppi6nnvpWULUKpvG3x0n015O2liaXvugvnRGVnHxlcrsRCpJkRfmXkULkPTC8/8VTQqmDIchgJQ+brY+b8l304dul/0DPA/RBMDcquQNp53bBKTsGrKYN6Iu9BPckvpQ82BJM/1DifBZa+nFku7KL4/FbruPYdLNk0nch4+KO4rOzECD51PbtN3u5xQhGxvShiKBCLuEsA9jPRUhia7frJiHhFImsRCzsgbRvgO0qdgAQgISsOIe4ayXlTIXXdMvXExjDAbfBUeSl2P3hl2ka6TU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(52116014)(1800799024)(23010399003)(56012099006)(11063799006)(6133799003)(10067099003)(38350700014)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bRnL3Y0kAd0z6mvj0Q2ZKRZ2DQJMIxiM/A11QxW3DBdhQ+IBmFYmC6yPs2t+?= =?us-ascii?Q?4U3eSck1GDlnNtpePMtiWPLDW5PFju6VqmkWHgNNooRybhelQHP0br1IY26T?= =?us-ascii?Q?F0XjO0sHralRzrvIhhpfxdr6B80uYkLrELP7yOND+jbETyzkndExTmSUd8AE?= =?us-ascii?Q?wpp0sdUc2RWLLOEoMidgozYn2slILx++D2ez26sWGRxRtMXmB1y4cFdc3Klg?= =?us-ascii?Q?xnNzIDRBLw/W36XfJQ0Zv/MojtK5iVMhQ87I+vaQKoezXStXEkhNRMMyiOtc?= =?us-ascii?Q?5FZMOuHH4+Yd5eajhGtsmS6/6nUtMP2tpueA+erWzbqnw9D1HOl41upPbx7X?= =?us-ascii?Q?hNk3uqPycNq1Xq2H50DNFuJNr8anmvO1uS20jvrcO/Ivy//fTMkSdr+Jclo6?= =?us-ascii?Q?AIb8ENf9LIvoqIJ8FfyQhDLP61841voN4F1snXAuAWiUWZXqmrWA1clY+WvP?= =?us-ascii?Q?YuD6567z7NnQO6KGicWmKOn48QgAPeP7VSGZ0+15lmNHu8mjGQODSlbyajCn?= =?us-ascii?Q?uoBzaRT8m0Sb6AB8f30hDARPacvqZg4Ub5gTSM2ZyujwAifVGXdM2QNQxdYS?= =?us-ascii?Q?QDy++wWBISW8PyLqh205cK6npltiSawqwfyoSnnxKFwSD5sRCzJCIC7kUZZJ?= =?us-ascii?Q?0sZCwwT7Wa4X3zOPFj+TodXXqNS0ANiLkk6V5an+WmgFqU6qxvzfVMYcSXF4?= =?us-ascii?Q?tMh3YuQVtUNxBFNrezoOVQhQHQKlXfxhqSodt/JK53x0yuxlP9jyY7CXnwM5?= =?us-ascii?Q?EIQJH5fZKZAcitdn//DbTCAxNbYRI0XLAILqU87V91US7EgFCO45SHSM4JeG?= =?us-ascii?Q?PvhzyfwBFrkTxPNrXzkmBW5u5p0GdVls2S5OivtTjJ2LlPDBlbI+w4Il2EHX?= =?us-ascii?Q?MHa+/CF0pog1cLzwieWU+MAb0zRSsBzyKmv4zGin5wMS3ANjjxKZMEEARHVb?= =?us-ascii?Q?oUJmKMthqA1dTZqOk0XM2qnM7CcYJkE4pl7rCpSeT64pETjf/zh0DD42Kd7x?= =?us-ascii?Q?P2ONtxqzx8jHMS1WYc58xO58teaWhOMbV6L0F9LZDMDI6Jt/8YAWj0ygo1R0?= =?us-ascii?Q?+YtdxB1xAxm5G1mH+8N7fR7uYBrN6ZIwTWqmX7Puu7V7y9rGgVAwgC0rptGu?= =?us-ascii?Q?iEllzjgKiEdxrJP+Twd+Pe8DYie9n7/L6rgo5UQln02Wijq6WS14CtdVL8+c?= =?us-ascii?Q?87LLk9uvPS9kw5iIX+/JgnVykkmY7oFQEZsKwnJVGEaUI9lwGgkPbqk0GcBn?= =?us-ascii?Q?2ov5xJXYCSbVwV768eeZlerWc2gQX0BOvQ0ST5liDpBIUTOPZjczTTNCqVdx?= =?us-ascii?Q?ywwYNtd1sufQUG108cTAcWmxlMztKnL0wRbEckrRi2vno3zs7Cv8wGcvyHkZ?= =?us-ascii?Q?uMweRsPYaUFTlB3JT1wKxx6jZJrWGyA7b5rmOitS1+y2YCKeH6wbNqiqKjS+?= =?us-ascii?Q?GaTC8hmEVyD1Q+9AnjFnjCzKAey9PzIGb34lB3SsL9k7TaMgnmNQ+G/1nRl6?= =?us-ascii?Q?XhLNhbicU9J5uxmoFVbHPkklNcYjUZPfXDevz8QbBQwejr6g2zzecYnEa6XL?= =?us-ascii?Q?JOSvObQyFRCip8YeMmo1gofDTXjcXDr5Rfa2IfXzFvCQsGLSDRUyZQLWHbKr?= =?us-ascii?Q?sTD8fuUYvS98tK6p2y6rJo5Yd937wjeSC5tqeRITuhQpILgi0JpeyrF4jgYb?= =?us-ascii?Q?OYZXw1dPIbm/aeoUCoERSqnhqILbEQlmzD0er2tUcJKw5NhWoPzQNf5Ig6lc?= =?us-ascii?Q?r5QOe71vxg=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6ed3ca7-5946-4375-bc95-08dee3eed036 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 10:33:16.9915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YEcqd/546K0Hnz1RfQI5V2poAZLtn1KPU/XKYo5bAekOagD33fDosrUTVfMDN+/lotIACeDvzItI0PB8ghv95A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5765 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() and dev_err_probe() calls. Signed-off-by: Pan Chuang Acked-by: Yushan Wang --- drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c | 3 +-- drivers/perf/hisilicon/hisi_uncore_pmu.c | 5 +---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c b/drivers/perf/hi= silicon/hisi_uncore_l3c_pmu.c index f963e4f9e552..56a88fb0d3c2 100644 --- a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c +++ b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c @@ -604,8 +604,7 @@ static int hisi_l3c_pmu_init_ext(struct hisi_pmu *l3c_p= mu, struct platform_devic IRQF_NOBALANCING | IRQF_NO_THREAD, irqname, l3c_pmu); if (ret < 0) - return dev_err_probe(&pdev->dev, ret, - "Fail to request EXT IRQ: %d.\n", irq); + return ret; =20 hisi_l3c_pmu->ext_irq[i] =3D irq; } diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisili= con/hisi_uncore_pmu.c index 0ff2fdf4b3e2..77390d033d08 100644 --- a/drivers/perf/hisilicon/hisi_uncore_pmu.c +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c @@ -192,11 +192,8 @@ int hisi_uncore_pmu_init_irq(struct hisi_pmu *hisi_pmu, ret =3D devm_request_irq(&pdev->dev, irq, hisi_uncore_pmu_isr, IRQF_NOBALANCING | IRQF_NO_THREAD, dev_name(&pdev->dev), hisi_pmu); - if (ret < 0) { - dev_err(&pdev->dev, - "Fail to request IRQ: %d ret: %d.\n", irq, ret); + if (ret < 0) return ret; - } =20 hisi_pmu->irq =3D irq; =20 --=20 2.34.1