From nobody Sat Jul 25 05:29:18 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012002.outbound.protection.outlook.com [40.107.75.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5702D3EB0F0 for ; Fri, 17 Jul 2026 10:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784282755; cv=fail; b=OuVD+I/omFZZj0LBSSIybJAWmgRdvzPqQfdGad5zeI95W5BiezTdU8FV+TA3QhorJ126FxjuVDFromkP1O/fQ4HXFfK+/npmWg62Afq7pjzwpnPTeY6qwrn9QyNRVG7ZWnQAlBsQ7RbjwQLnAzhu8fWtHL4bj/lrOshO3ZE1ukA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784282755; c=relaxed/simple; bh=vMiX8nDOZoyiv5kLYxvClfki6da4uumrrThJ3jcyvo4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=rjikTnZFq8WkmAEWmLramJiDEgMYp8EC406EHH4TfUHMBjnoqPRU+dQr1lgUoU4EPP2P9g1YPGNo8pEipU8Akjw7wmx2aecbL7wBX8LbF3Ssmg3BIYr4BHHn7qkLWkSWOO1dLmpZ5+Kzud0AAT1vZriOxA56RiaXGaIoDzLrQv4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=JINti9mZ; arc=fail smtp.client-ip=40.107.75.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="JINti9mZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zSx4SV5O2iz16608lESqZyGdSsT//uDietpYeihoTihJyFh2bCo1COt4NTZe9YbdRm3cHLXy7rvhsktyjx8rLwiH2RpD+6bttEYtfXX/LsrqanOF9qwLAtJeblhgf6il7OGNcVSSt2ZuHfl18gIwordwirYYnt9Q3s1vbgVnw2tuQOZ9vQ1Yz2JsgZtbUPoWnLqlaNM5r1DLZd4to3fHys5y4h+8fSYN3hCz9aoc4rdwtjbBEzwzCN9+oopg6KLWiiW6CXRIiM2oj9EvBXnw9DWVC08Ls1wpHL2QuL/ShQRiyWwvyo6igMhrppHzDdi5fjW4daGJmP7EVHNx1HfYjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZJWneA7Evlbaz1xMSZ1Jut3c6WYzD/PFMYsr1eJPKdc=; b=bxKhTrxSu0KJqBi3CuwCuvwwCPqLkqfIf+B/X9P9TQvJHLEFCet+qOYINKoauuS7I/HSjm+J3ndU5WrytOpMN5OzmznyNmourwVGX6odw7lyzNg567na6iHHR59xt3gX4Xe4drw3KiJTDK3YJp6ojOc1uzmGTSLK3/Lhx0qilydQlJenzBx7VIuElXbPAtICV+7MCHr7gZHvKMuMqzpEx5q1V3TZOwf3rqhh9UwD1K+ZqYqkAc2zudMaYuTQXvOndt6JC7hVfdzJJRF3dyr7IoI+toS8/uQB1FQ4nGbDHfOXhqXE6XGCjd84Dk3XVY1vLxHOfMPDgyzpLe66V7InYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZJWneA7Evlbaz1xMSZ1Jut3c6WYzD/PFMYsr1eJPKdc=; b=JINti9mZuAdt+D6hOUzbAQxmpDIgkbkshkHZ+TgZ8NK3/fGxChzJPPtlJFynzsQXdFf06ABft8GtLJAZMtfhclu8yMftbJyYcVjOD/zF3AR1n0bYnIBydNTgX9JHogDcxbz3PUnUahLFqzsjNRFKVLvcfLCSjRxyMU/XKKr/e40/4/jtdsb+4iTYHo3HeDhS9QJwRpGU+/ncSmb4jWfWyCC8EmOZPWsrjPkZ48Je5tITV1YbCi1KKNzqRmA6nOVfuRrhVm49xpuA7g6qTfg/F+Bkzmq2znnLF2Y2YuMpbRvl5HMyYm4svrXNGbNITGyMFqW8Cmrt69pj+dQXRorYLQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KU2PPFBE3986883.apcprd06.prod.outlook.com (2603:1096:d18::4ac) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 10:05:46 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 10:05:46 +0000 From: Pan Chuang To: Scott Branden , Broadcom internal kernel review list , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 1/3] misc: bcm-vk: Remove redundant dev_err() Date: Fri, 17 Jul 2026 18:05:30 +0800 Message-Id: <20260717100533.601899-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717100533.601899-1-panchuang@vivo.com> References: <20260717100533.601899-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY6PR01CA0015.jpnprd01.prod.outlook.com (2603:1096:405:3bb::11) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KU2PPFBE3986883:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b70b8ec-c9fe-499e-38e3-08dee3eaf839 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|23010399003|11063799006|56012099006|6133799003|22082099003|18002099003|10067099003|38350700014; X-Microsoft-Antispam-Message-Info: z3l7DU9UYwdMyiuZLt+ND4eNI8H5kD3Tld6Xl26gE7KDPCrtaF76GTjZKcvIE0v2HA5gpy5/o61qOj4Gred1s/PkHmTHbsWgQLTXS7JFNTFB5x1A6eNTTmxn+8sDb5kbRH+mga5JbIgcVQ7LSq1s90imkp1jJHhY2/2aD/yovkP456bZAkwMqpHzzXgjSMwNETx/I+y0UPy5ObMZs5cShABQSNlP48uZitO6fTmP9Ksau7yB/tDeF2emCmJYHKm2s9e/dIdvfNHaBfBqkKMCTSNL7IWCTdKeBWZADIqGU6Vj98YUkshcY9Ed8pcxE8LmK7YsnY0OjwBFhrUyDo2vrNtGDqLIJ15KjTjD/BC3fsZ3jsYJZ49LZiU5EGftP6igIiUnqUOxxEp/VDM+4IUyixp2+xsZyjG7Xxas5MiQLU5FLTNwDnLrd+UCpyxPO2DCFjZ/XBaDuRDVE/WOUhfQ8QgRWUfheWxsrKJtYVy+lPBIsnp5PW1ZynzQRyi8nPYrnBwU/XeEP4lKuI3mSbintW3uNwwyLwrHFCG8Yi0zRPIqZbFydn5l59unM1Gy/RNiYYDHL4TPx28kzKfZqiJmGxTgPOuSykEBDVOPUIYNyKC6y1/fDQa9OgqljDmAAdOO/s4M8VVQw9NCw7UscVz1yiMLLjvaDqV+fppN0mq+ThFX4pfB9hhPV17WLGZsRCv7wPtPpKRD2M5AXune/61/wBhXwLq89NAq0gSpkXqI464= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(23010399003)(11063799006)(56012099006)(6133799003)(22082099003)(18002099003)(10067099003)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4t4rkG/BwzEa+Lv5kIisrXmTzxGga/xHd5wjgzKCF1Y3ADh6pstsfhX7DNhA?= =?us-ascii?Q?9ahe7FbL4HUsldFlU4fzyXObgt8A7z+9TsepueHlgcvcnfRWhBHwb0MPnn0g?= =?us-ascii?Q?WaqTGRa45kwE4bacR2Di5F8h7nVG4C6YC/jWbFvlmzlZgnR9tU6M31h3CrwE?= =?us-ascii?Q?LUkhiDJyJM/X5ZWsqsoXuKzNZwBvCqZURmrbK1YvYQLcw03LWETE/OzILnIN?= =?us-ascii?Q?g7k1RY0FIXUQtG4e3a2j36z9IqENTV4BoDIoF+H2Vl9SRQafUpOwgYtpb4cb?= =?us-ascii?Q?jcZMUQq4e2N2ZJHsTQikkI4HXYeYSKp9f0x13dd2XjGM6mRqhL2bz+vZruxJ?= =?us-ascii?Q?HGn88/P/xRvOfjgG2nwixjzimZr3daSMv5I4d9HEJvTU5vSx3NOr++6dMPsa?= =?us-ascii?Q?u2dT5r4LrtIjc0mutVQxu2jFqI+05Y1fZNXxjc3cpAgA7KaFKZkZi3QYzELM?= =?us-ascii?Q?Kwxo4yrOibCJshDGaTVl0RXPlCzJksb2o9WugX4RDgJZj8Br2i7EYg0Wfqi6?= =?us-ascii?Q?ZJfxZRa9IZv0QKgjSMNA5Jr1tL8CSSFwnCICzpnMJ1Ra4ZtYaDQ4OKQkmeEd?= =?us-ascii?Q?6LPk+TCEpegiSu1jX21+xM2SJs3stqykkyQK1Un3a6zk4JbhuCOFrorQCsui?= =?us-ascii?Q?N5I8TxbSEF9qVLABO/dkchwkFVUDdC987DkGq94Y50pHfhFt4PBDq0hGzAC3?= =?us-ascii?Q?dbDQf7WBj+HGrvAy9kAbPPu6T4Me1PbyDE48h019m797225TOTD5PCZ/PIL9?= =?us-ascii?Q?PXn0/kN5Rs0sADWAcjP30hJUkD4ayFFADU/oD3eRceKaWe1kl0cEbDg3C5pS?= =?us-ascii?Q?UCdJXa1EQf6oNPBXBU7dDDYdBH5i/bgW+r8vNTFPJNP5/KGQqZY4RGk2O56t?= =?us-ascii?Q?igdrNiT8mey+fSQu545PK1qpLKhJrLDWLuMSgODqsGkmb/EOt6wOe6pjBRjW?= =?us-ascii?Q?O/HLUvVU7H5zuwACrq+uH5gl6cLbSAYrRMHpc+mX3aH4qi2K/HbLa54J1UvO?= =?us-ascii?Q?/wZADzhuAa+ArylQnFg2soXy+/sK/qxu52R77zJhhzFvCOp6N+zBaXm4Lw+X?= =?us-ascii?Q?BXZlxcWI8TT9hUd6jWeWv07n+ijsIa3cDaz0asXacoORWsVFjorfj4sSDTuk?= =?us-ascii?Q?lLHfR2C+5JlKFDdd5Y+pnKDlHlwVFGNG5+f13q2O8P7rhdFgRS/CrIEA0tfI?= =?us-ascii?Q?Ok9MOySDaJpKoh+2kWNsOCXbPF7uQs1ZPaozQ8Sv7HINwzAHOdBr8gHtj16S?= =?us-ascii?Q?rqiMiKCOurgbnMLpcl80tNCJsCxEBCorhah/msIhbNX08P4qYKiPI9roRv6K?= =?us-ascii?Q?jynIL7aBk+8zNGEFu+CWOR3PFIu5n4J9vj7+RsXfbvOHWLoi8SIGkElIcRGo?= =?us-ascii?Q?Tv7Ai+fVKJXcO/mB45P5lvB5/2037a/UMa+VJFgYjEPm0Um7J6TtI2lZIIoB?= =?us-ascii?Q?shi6BYNtGcnbapg2bWEK3VSOyNiWJuQB69U5RkPNnYwaKyLqkkTol63fUfgu?= =?us-ascii?Q?REuIjcIN6AWn02Gcx7etHMb5gRbXGBZGjH9fIj1yhd9yN7FtEdGjWXuJJYcp?= =?us-ascii?Q?ecJRI5nLPjm0iSWjM3wRGsd498J18+aA/7blDXmrl9pF7fo2pld5kdWcbDrK?= =?us-ascii?Q?7GHkSjbotlVpJ0dgX5nXgUsZdX78xodAudO8m3LOIE0GKa0dg8NbRPBkoonE?= =?us-ascii?Q?wX5xkyt9knp0ScMSET6uinkq4prCCRh/g58i9/6qSWfsubg2w/6i7BMNA4g8?= =?us-ascii?Q?BkzuXxfkpw=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b70b8ec-c9fe-499e-38e3-08dee3eaf839 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 10:05:46.1336 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KaYPw56+INhzBmKHjVtE4gyUh36pWH6voOApJgDlqCIqKuIjhkHcxtFssbvW2TW5Xvkrttmp0PRUkT3m+utFrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KU2PPFBE3986883 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/misc/bcm-vk/bcm_vk_dev.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_= dev.c index 5773ffb46f0f..54b40b4d556d 100644 --- a/drivers/misc/bcm-vk/bcm_vk_dev.c +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c @@ -1370,21 +1370,15 @@ static int bcm_vk_probe(struct pci_dev *pdev, const= struct pci_device_id *ent) err =3D devm_request_irq(dev, pci_irq_vector(pdev, vk->num_irqs), bcm_vk_msgq_irqhandler, IRQF_SHARED, DRV_MODULE_NAME, vk); - if (err) { - dev_err(dev, "failed to request msgq IRQ %d for MSIX %d\n", - pdev->irq + vk->num_irqs, vk->num_irqs + 1); + if (err) goto err_irq; - } } /* one irq for notification from VK */ err =3D devm_request_irq(dev, pci_irq_vector(pdev, vk->num_irqs), bcm_vk_notf_irqhandler, IRQF_SHARED, DRV_MODULE_NAME, vk); - if (err) { - dev_err(dev, "failed to request notf IRQ %d for MSIX %d\n", - pdev->irq + vk->num_irqs, vk->num_irqs + 1); + if (err) goto err_irq; - } vk->num_irqs++; =20 for (i =3D 0; @@ -1393,11 +1387,8 @@ static int bcm_vk_probe(struct pci_dev *pdev, const = struct pci_device_id *ent) err =3D devm_request_irq(dev, pci_irq_vector(pdev, vk->num_irqs), bcm_vk_tty_irqhandler, IRQF_SHARED, DRV_MODULE_NAME, vk); - if (err) { - dev_err(dev, "failed request tty IRQ %d for MSIX %d\n", - pdev->irq + vk->num_irqs, vk->num_irqs + 1); + if (err) goto err_irq; - } bcm_vk_tty_set_irq_enabled(vk, i); } =20 --=20 2.34.1 From nobody Sat Jul 25 05:29:18 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012002.outbound.protection.outlook.com [40.107.75.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F7FF3EB0EE for ; Fri, 17 Jul 2026 10:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784282757; cv=fail; b=COugMPxQUNsD/zrDExEV32RGfbArG6laTQpPVQ02YWvaur9bXa68+UKgMl6bdCAs4aruxQ1gkpvCdmjhQj3ttdOu1254qay3lHxtUT5sl5c1nGyEZyzyvaz0AZ6+kUNAMhnR/GPrpMH14R0L1V6kPAFQP+vs4ls6p2HEAFChwmI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784282757; c=relaxed/simple; bh=Rs4j+OeUIV0YKkYHwIdPasrhdLieqaiiYlvhAPzSh2s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=pVMTU4mvcs9O2lgeroNrqFmVPDj7ZJiNNdnscFLwZJ07/hGC5qnZP5HtMeMMzBV8dcIRsQAbr3eweEx5tjZiVXVmerV2RN44ejyEOnyZtqUot07sP+GboR2V95mz0Qpdxpcy+cKTYO/BymQcqFZLvPSusOoiPIgMJJlE/3EJEH8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=ohw48bk6; arc=fail smtp.client-ip=40.107.75.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="ohw48bk6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W/gq04JK8TR6qmvlp6VCPj8sBwfvn0fuFjJiDhWN1kiyXG2b+fjcfJwap4Oij4ZNnLAHgksJCcAewdddAaY+jmJOOJ+F+qYZ6ekaCk5CTmk3trgPhla62r3IFkMr4uFZVzS/bCbjI/XGR5US2OJzsF6uZKfFW02GZV1I/1CgLg0T8Y7K7mVmQd1mN++LHugX5pS9ckxRHIusEAgLP2occQ8Z7orMcpz0Xwk9wSZIPdcJ8eHX5MKO7peJZhiqy32SPUw20kqcq7JxaFXjn+OsqyBusAsXY6ORWdY6Gi05YuLLXyCpw3AwRB+ErlQqjh1mTqjRFp4yFb01pSavoAWkzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s6s1HFxHSgq2AoLabWmhGUqRdLTUsmRIu50ZTheVawc=; b=Oz6tgIHE1mOTXlyoy1i8aGcwKw3RlhQKsBBC9tSAH8Xfm4iZ3uHIRzZYz6LDGb8QPxxR7dqNy+1GUiJznxKmHeypKOTlr6oAKmQ+ISfOZ/zVURySc1avTxMhCgNBy/FJS2ls88iiMt1a1RTMGd2H/aGhI/g/ISxJgssqsA3FA6bIe0uKRhzWzS6UqCjQiAU0k9GE2cqgZ5x17BAvT4IfdIArmw81Xb9xNFQpZ0xsd2r8y5hY/GkCDphmW6bCu/upF2rIvuH5Eb+OnnMqGKQurWA6PvYkgEfkqvciW7Swljco4eVcqtkXGt0N/2TnnpR2awfdAwJxgetq+DwYR1zBQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s6s1HFxHSgq2AoLabWmhGUqRdLTUsmRIu50ZTheVawc=; b=ohw48bk6gErAPd8xvEr7x4t9WaIgQpeAoPMKppT0LezDhXa8GPtIUHHtqIszk2VJq6jySaASuEBU+sdnicfg4wuKDOApKEWxnSkIymmBnxoZKQ83nTxo9lINvR6Hl5OIO/HKteNGgZ4sxwvXgh1L/JyhAVmPaB+K1QXRMq9OoKviMjOuo007v10BYrUREXAYQWs4rRYsYGXa7DwDAxwVRxNF80fxyUDCiyYhkJPmNq+R+Y3nS/KPJTyDdICHeW4VuTuIck0iHTXvwY+XUm2MnTfwD66Q93bicPusZCE7Zo7e+LzAvN5GzX0Cg+Jsq+zQ4lYB/Oh3RSP1ZUs2hNvx/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KU2PPFBE3986883.apcprd06.prod.outlook.com (2603:1096:d18::4ac) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 10:05:48 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 10:05:48 +0000 From: Pan Chuang To: Arnd Bergmann , Greg Kroah-Hartman , Vamsi Attunuru , Derek Kiernan , Dragan Cvetic , Michal Simek , linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/ZYNQ ARCHITECTURE) Cc: Pan Chuang Subject: [PATCH 2/3] misc: Remove redundant dev_err()/dev_err_probe() Date: Fri, 17 Jul 2026 18:05:31 +0800 Message-Id: <20260717100533.601899-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717100533.601899-1-panchuang@vivo.com> References: <20260717100533.601899-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY6PR01CA0015.jpnprd01.prod.outlook.com (2603:1096:405:3bb::11) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KU2PPFBE3986883:EE_ X-MS-Office365-Filtering-Correlation-Id: bee78da3-22d8-4446-12eb-08dee3eaf95f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|23010399003|11063799006|56012099006|6133799003|22082099003|18002099003|10067099003|38350700014; X-Microsoft-Antispam-Message-Info: iIu6v3O4vx6iKEocqHbv0lFJxlWj56IhZZ0ifRWkFQ9wYDGrxMmDI7Dd76/JT4IO05JSfWV5DglKSD70HBN7KohCPDZxNfboLP1jRd245vTxMjbS/4eDUvKKEGmlLSOttA4ZZFL5Rgvx7TNfwLQBuvDcvZFMSdNp8Kl10A4ArnWcL/qiPk2vammFFvqKru7CPLDJn0yE8lMRB0WRws0130ZAgeGCdqS9v/4lDkJwCa8ezWhiZoOIzXHIPuV5bbGGfF7Zk85PYtmk01gWCQmrfjjF5ebrpg3Xpg+Oz7LNR0GJ3PwQH0lKOn0V8Vr5Qulv8f88zKlCKp/igbYh9mBLdiEdodf4M6G/JagYk/7vEe8RJWbsWHImGJ4LbScCVto6Zl6QYFGpRQwmrDJgJ5ENLnhFmRnRoJWpJl+WfNRUSa4sVxVW8TgklWYBY3qoL8GpGmOO7+yLFB1zvO3SWn34X3R4BcRqDnRSfP15Ip7Ky1dSkhfPgMNOf75MDoq+fy9FcH0hL7nKoH9lTmY+r3gna+hemey3hzIOOBrOHYqfwX/UPRvLl6Z8mvfZxz/qd/P/KCqTI722uM7HcOrR8jSQWtcVMMTnxibXIt7xCDGCFMgN9fEM0affYrPlwXcrT1idxKZYZ+kXvsPufmzICW1wdKd1Om/xS/kzI7OIztH3OZ85nwsv9ggUb0+FLvArmlBbtHYdKVru+3jOhM7naQwq1V6S4yd1Y1udh5sImN7OWSY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(23010399003)(11063799006)(56012099006)(6133799003)(22082099003)(18002099003)(10067099003)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?szptaybuVasacR2ocdwmN+PXJnoCJtQDHswZhNYP5EJQMP/ezdFBrH3p5XG3?= =?us-ascii?Q?Jn58wry/iDIR+wkf5cJRUx41QKmPSoy49k8e5l4hGI5nvNFCGBUp4m1OtHXA?= =?us-ascii?Q?fKLLBIXVyhVEpsW16OgHpgVrI2N6uDbARvxJSlNtiwrHvVSCZ6xAO9dKW9M9?= =?us-ascii?Q?9BUjefihxTAdE2beWFHYpwnpawA7Kg96qhd6fraXPZohU1GrczUN/+SUh5+S?= =?us-ascii?Q?G+3eQKYwvX7B6ZCZNmXI09a0k+wUpYEJO68aGgR8RS1vwoJtC5tGVk+WSVXd?= =?us-ascii?Q?Hse93yyxce1dwW2x5GzN80HZw15lZmgP2n3JCZbAiLIlktk6GRIYULB+XsW7?= =?us-ascii?Q?jSeKL62ICSgYsv4J9jV9wpfwHShADWzPsOVu8QSj5QZdupjD4EBnpbakCYAM?= =?us-ascii?Q?cnHSSn2vyeQNbMQ+2H33ByvGTU+/UUd8wDPm3Q8SpsaubzUJqkpRP74oOIZ6?= =?us-ascii?Q?S8dwwhzeilX1EM72dVr93lHhb0HC+TqRNUlB1ze9W4GISF5zMU9PFQ4IXAYe?= =?us-ascii?Q?EAmoegEoekyILq6B28arwhTVvc+eikQ6rHNVGH5u51e9DXJWvvNKIDpV2PRB?= =?us-ascii?Q?OUky9e/UKWRBLcQ4yp1s54IJeI3296pBJFbj7oZO1hoxZBsVp5TgOtaoUzRn?= =?us-ascii?Q?jy2R173sYEOsZGcw+zepJeHorUxZe1rlTgFvliuxBcsZwZDV97IURGNvpJXu?= =?us-ascii?Q?MIwM9n1W5nYT0KYivuE5qFUWosgKZSTu5STqtQy2Yp0UFCZpxcUIeU3O/PaU?= =?us-ascii?Q?KgJFqinIXmCFvKakLauAtLDN0SeKGE9bZOer8CYrYvGjX8xaCtIFTW8tAym4?= =?us-ascii?Q?Zz+xDG/SKyJynogrWVgNsTMCTz03JHWvbaNMhSOVQFRTL8MKvBMmVBDV+Ygl?= =?us-ascii?Q?kScWl/WJmSsrAhv8wWUZktub9rYMMUT0f60+WK9lFfdpAkstOQ9CZp97/wU2?= =?us-ascii?Q?ouGULR7htOG1/30fgygXDRPPQsFHQuW11h+cY/+CHuyf41Ik49PKrBfvzFOQ?= =?us-ascii?Q?wNSvCk+9DbxIvu7mTUlRWzYwwPhLPeIQ44s2camVSdP48u41qeDtl27fd+6Q?= =?us-ascii?Q?D7u9rdDQR1TPUZL85ljub9oPcN8ocsRcLaj4LH3r9tH95QDhzoRx36pz53pW?= =?us-ascii?Q?8FUbchvyY4nF9+dd0+nhPM9wpd+n/bK5U8LeHFJRYssStdqbT1Fv3gNjtyYm?= =?us-ascii?Q?E4scPmwwbDd4vhdp+Dqi5kUblkHjuh3A5C0yn6QOPoeXwEAvS7/FOGZf5T82?= =?us-ascii?Q?5XDX70q78T9P9vIWNXaLMl4iF6Zw+0Zys1Ix7rX/jvjIRjvkshBZNkgq1cbJ?= =?us-ascii?Q?zenKAqEsi2VufnznKSHuRA5m811dgEB/ujHXWH3HyMniBUd9zFrmtSbOBwqz?= =?us-ascii?Q?yJT9Oum7mKhcW/D5UQzS5Aub+GocM36AyRkUlAGxyDqkXjkOYNJ/aQLF+C/e?= =?us-ascii?Q?pGIGlgWNkGrCbpSrVBRnLdFz8tKYb03lHC5gaKUE4dtGlmIseZ7u826bTyS4?= =?us-ascii?Q?unl6+ERa9KgH7zaAUOYJvqvbsIcL8HKGfCoYlkbXXgjB4KOpHVuZ4Cty7k2p?= =?us-ascii?Q?FsleK+KoaY/ehJ8omU8xoLwGKtsdEoFj2h/+L9j3JQYWQao5nZmoanBss0jn?= =?us-ascii?Q?D3Ag+1UBHwEeShocSAr8m5qGIAstEMfdaxEs/gO9K0E8+umUrBrRlLSOhlOv?= =?us-ascii?Q?fDquIiV7NyFRJ9DGeT6cdTx5iTKre+M9oOSmSBagLh93Y0Q+h0ORcWPYgja9?= =?us-ascii?Q?ZzbIPxtWdA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: bee78da3-22d8-4446-12eb-08dee3eaf95f X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 10:05:48.0731 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5801Po7H3q3wmElYyEcXWnAvsDPziCP+JkjfqWP5kgotXuHU/Nt7tio20Bv1mENws0bvGRbjGA9vonAHFa4NvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KU2PPFBE3986883 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq() automatically log detailed error messages on failure. Remove the now-redundant driver-specific dev_err() and dev_err_probe() calls. Signed-off-by: Pan Chuang --- drivers/misc/hi6421v600-irq.c | 5 +---- drivers/misc/mrvl_cn10k_dpi.c | 4 +--- drivers/misc/tps6594-esm.c | 2 +- drivers/misc/tps6594-pfsm.c | 2 +- drivers/misc/xilinx_sdfec.c | 4 +--- 5 files changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c index 5ba40222eb12..5f65ca91b342 100644 --- a/drivers/misc/hi6421v600-irq.c +++ b/drivers/misc/hi6421v600-irq.c @@ -274,11 +274,8 @@ static int hi6421v600_irq_probe(struct platform_device= *pdev) NULL, IRQF_TRIGGER_LOW | IRQF_SHARED | IRQF_NO_SUSPEND, "pmic", priv); - if (ret < 0) { - dev_err(dev, "Failed to start IRQ handling thread: error %d\n", - ret); + if (ret < 0) return ret; - } =20 return 0; } diff --git a/drivers/misc/mrvl_cn10k_dpi.c b/drivers/misc/mrvl_cn10k_dpi.c index 7d5433121ff6..d26c53af05eb 100644 --- a/drivers/misc/mrvl_cn10k_dpi.c +++ b/drivers/misc/mrvl_cn10k_dpi.c @@ -470,10 +470,8 @@ static int dpi_irq_init(struct dpipf *dpi) =20 ret =3D devm_request_irq(dev, pci_irq_vector(pdev, DPI_MBOX_PF_VF_INT_IDX= ), dpi_mbox_intr_handler, 0, "dpi-mbox", dpi); - if (ret) { - dev_err(dev, "DPI: request_irq failed for mbox; err=3D%d\n", ret); + if (ret) return ret; - } =20 dpi_reg_write(dpi, DPI_MBOX_VF_PF_INT_ENA_W1S, GENMASK_ULL(31, 0)); =20 diff --git a/drivers/misc/tps6594-esm.c b/drivers/misc/tps6594-esm.c index 2fbd3fbdf713..50e121669c6d 100644 --- a/drivers/misc/tps6594-esm.c +++ b/drivers/misc/tps6594-esm.c @@ -62,7 +62,7 @@ static int tps6594_esm_probe(struct platform_device *pdev) tps6594_esm_isr, IRQF_ONESHOT, pdev->resource[i].name, pdev); if (ret) - return dev_err_probe(dev, ret, "Failed to request irq\n"); + return ret; } =20 ret =3D regmap_set_bits(tps->regmap, TPS6594_REG_ESM_SOC_MODE_CFG, diff --git a/drivers/misc/tps6594-pfsm.c b/drivers/misc/tps6594-pfsm.c index 44fa81d6cec2..c3a0d6367f2c 100644 --- a/drivers/misc/tps6594-pfsm.c +++ b/drivers/misc/tps6594-pfsm.c @@ -308,7 +308,7 @@ static int tps6594_pfsm_probe(struct platform_device *p= dev) tps6594_pfsm_isr, IRQF_ONESHOT, pdev->resource[i].name, pdev); if (ret) - return dev_err_probe(dev, ret, "Failed to request irq\n"); + return ret; } =20 platform_set_drvdata(pdev, pfsm); diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index 3135ba3a58ee..fe7bea3b14bf 100644 --- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c @@ -1390,10 +1390,8 @@ static int xsdfec_probe(struct platform_device *pdev) err =3D devm_request_threaded_irq(dev, xsdfec->irq, NULL, xsdfec_irq_thread, IRQF_ONESHOT, "xilinx-sdfec16", xsdfec); - if (err < 0) { - dev_err(dev, "unable to request IRQ%d", xsdfec->irq); + if (err < 0) goto err_xsdfec_dev; - } } =20 err =3D ida_alloc(&dev_nrs, GFP_KERNEL); --=20 2.34.1 From nobody Sat Jul 25 05:29:18 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012002.outbound.protection.outlook.com [40.107.75.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BDA23EB10A for ; Fri, 17 Jul 2026 10:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784282760; cv=fail; b=LpziCTKimP9YtUZ0+LZnxwQvdiRcRuOxbInROTTGBw29usag0ThFAfhFMD9D+TaIKEGUSXiHToofrln09k70tNr0NuuCdnrOEgmf9aa9Zg7VVG5un1Mqi3u3viqMmwHYDVZ1CmRuiNtO+GoBs9QmN7CZtnZmkl1fZMkawpfw6xo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784282760; c=relaxed/simple; bh=NohNovit+5Ilfm/6jolo29tyMCmJT3WI7a70AHCxIUE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=bTsiVSqSBv7N5iYhKzWmX2VNPyJEa0MLIXdEqX2hfMDlQSzfyMQMZwdeSkuDtmB09mhGcrmjM4TCzc5G1+sbFM9FyjtRurq8QAPIHsm6XYirYbJ7U1qZc6P1NWS+ajiZHwN4FFCQ3dhV/ZZSQjcWJSv60VD/Jb3FTp0NgA0a+MY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=UAUzQcoC; arc=fail smtp.client-ip=40.107.75.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="UAUzQcoC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ExtdDxLRcmOJH+Lxiiap2ddRLI+zMeyYf2g+48JnjnIoB9H//GWqSWPeWoCN1zeF3v2wWbmoZvHLRtiJbXvIKiplWpBBdH1hrYJzjTHVJtcbFgNSIWnqLONr07dFleFvlMvU0+D23hhKTM3ChYxJ2XTqOEmK48Lk1mT9apiZCZASfV9w2FekCITuVjNy4aFjQs0uqbe1bE9PZOx2uwGJ2zNOzt2mNhNUd+aAE75y3YF/74YF7pRCvIwW+xfebovYYccPSsJaxMQi5hts1bE8bzUQ57sXEp2DgThXRKv2Nx4RvXhWcsxEt0dOGCWZZZ1NKdfLuyaOIalpIZWYCLH2Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R7tq0Pskp9+G1EiZqkOgNeyfluH7mZIJ+vJYHk4LQvo=; b=Hf4HhE73+B6vmGpIanH0hLXAif9W5oadLaH4nMSEYAgRvsZA47Akj4iFdGyBRGcqFaMOYYFw4fM+kWqBSqAsNkbEfmEQOZ0SUBYf3OA/77SCNiSotbOMSdbu1xTZLxmxPJ/2PVy++DfGHZCmrd3fZrRFcSaoicLNCKZXFDbc5MaDeMiLWwpVpWhV7Qxb+6prArYFr3B1cQ0ozSbtV9W0XZ+IuZboTQdWJJ1xKy7eS03CSqN52g/XhnJGm1KORz5vgqcKzgWgzFIpFZaKTgJ0VPdeTH0A40rtCq8dYk5rhHE2N6nlYISvTjSSxSbfo0v6DQPHpuyycAMz9C6ttHRaMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R7tq0Pskp9+G1EiZqkOgNeyfluH7mZIJ+vJYHk4LQvo=; b=UAUzQcoC8ddfEYW4Pr5Ajsh0eiAfuH7szWX1uPLckot8wiTGycg0QdNE0rCMG1/ESQxUQEhr9clM9c9sL3oYwoafckt3Zv5/MxGceNQPgW3WgPsrMG1EXodXub29k02a2BuH6wD9RBX12Nx1EpelQfvdL/PmF4EuD0zDGrxhJ1H+RRuZzZrkaO6CVfAZ+H6oAYLA2l0iiyYjL5j4gwd7j622t8jg7V/wM27vLbaVADAWsQ3tFNmNMOr/0DnFZ2LhBmf+cFCMJP9znGP5U9f+egInyCJ4fpZwbGR+XnV+J0Pez7DnDe33PwNwkwOdct8M6Mt7PzfCkFFiu5qbrO9exQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KU2PPFBE3986883.apcprd06.prod.outlook.com (2603:1096:d18::4ac) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 10:05:49 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 10:05:49 +0000 From: Pan Chuang To: Alexander Usyskin , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org (open list:INTEL MANAGEMENT ENGINE (mei)) Cc: Pan Chuang Subject: [PATCH 3/3] mei: Remove redundant dev_err() Date: Fri, 17 Jul 2026 18:05:32 +0800 Message-Id: <20260717100533.601899-4-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717100533.601899-1-panchuang@vivo.com> References: <20260717100533.601899-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY6PR01CA0015.jpnprd01.prod.outlook.com (2603:1096:405:3bb::11) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KU2PPFBE3986883:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e173c74-d8e6-4551-5889-08dee3eafa18 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|23010399003|11063799006|56012099006|6133799003|22082099003|18002099003|10067099003|38350700014; X-Microsoft-Antispam-Message-Info: lXrPeQWYHHWWmqiQ2b2ktI1WMun5s9bfVsiwqPMdRbawwZUduYHhZABjX1EWSM/hiWbLPYOD2zhQM5juC7PpQ/KvlBhfx3YgpeFL6N3GpY3bI+jxIDmWz2Zk+4eScsiNfP9tN7YvId3DFi7PX3Up2mAYblNNNx2qIsgA34qsQ7MEpzN2351q2LwhJdKkQBu2ZpWs/X2/EvWxCjMLMstieV6nMDtBhA6DPrV3V+EJtoIN/dh9kkBInNgwQIyWMmRHAeJvflo1vIZf56BLNUKB8yP4ZmZNDabMk9F8W7T7XOkfV9f5Fv12n3rOAlvgLhzoyeDUGyhf0Y99e9EFBKA3vP0rqcL3A38nIw0bIuNJuFXvCs4HkWyZc4bK/oyTb50+P0BvF4BM9NFF9vNzjR79+kzaEeO4TB8lAqrj58JZd0uIgoH5X4f69zZ2kKAWeGPPPNXn3Q3u4iojRWErsG/nUwsJkbXMcmCBzRMwgIlL6Vys2B7f9IU+LKg8KOsw1etp3s/wd9alPvrJLunb9rnIHq0AZ79CGwrbYVtd36UCnaY6pBnOK9OpOWQTEO37AvJcCg3ccAJQiI64J4YeXhCKzW0lizu7HaaQIyZ9ZeIaoq55hT2YlIjpqStSXq5xGor6w171IIpa97cnjD1RG+b1gEOXfWsJ5q/iwQMrDFEHpqXKCaOvyFEvxIH9M6OeSs23pSmes1U2b9FZRnpucmr/QcgfSYn0f7rB7oj7SCYPgyU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(23010399003)(11063799006)(56012099006)(6133799003)(22082099003)(18002099003)(10067099003)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6h2yTpE+Zlmj/qsjs7Km1o+XN1uIA2W7Exr5ORZ1aPEmAbLZUPFEm6zBBl9h?= =?us-ascii?Q?Loq/+hz3/roZrIcT7K7BEqqAH71MBxU8HgzXXpsVlMjZ9bPko8uB+CumkiE1?= =?us-ascii?Q?enSE7qj3LOp/7F6N/xBDK+ysL2ZwfXqzy5b2BRWbc705r7piFIgNQjv4+r5I?= =?us-ascii?Q?G/wOOUSb9NlBDavzaEPiDGONfLX1YBOpBhPlyDrKvMXuSYpfulty76+TkN0v?= =?us-ascii?Q?lAJj9HTztyT193ZpIHx0SVz+vD+saV3mWuojv3LBsssftq3M8fvd5bwVnKiy?= =?us-ascii?Q?O51v7X9HpAnuxsHq3eoz/wcM/CaasAUJOEp6Hu+NEohLlGAWo1Q7H4grPU50?= =?us-ascii?Q?5fADPax7RdcD5MLsXe7l/REmG/WeILoI7Nb3gA6hTtAFo8TtFCiexmwIIkm8?= =?us-ascii?Q?ofNiCn8Z283mU77sR24QIl+VULeLoSGiLDJSncYzDyd+mAZQwSnF1zZkeVqI?= =?us-ascii?Q?SOfV7XVNCA7JuU/viga++xdJdlLGJLylEChc1a6/rsg/iXG5FXTJpzTbB/V0?= =?us-ascii?Q?wqON8FVO0jkiq9r74j8LJCA7HpTX7sxwjLAc8EaYPp3Ue3gwPdPkqHudJ7qv?= =?us-ascii?Q?41E3b4384SDp5P6jmFwQ9IFnpyw5hO2xYLf4zKR+6nOlkkhO0qfEls0PJ801?= =?us-ascii?Q?7/1NiwiFh0NW4O8NZWJiDpeX0viOvJQQQYsOO2E0de/ewVck2725YIcMXVeG?= =?us-ascii?Q?KA5jPZGpW5sCNVxj53xNnq8cpKwM05eDBk45RojMKy4zrhKEpSE9swQTQ1Tz?= =?us-ascii?Q?1xOLKrgiVlyrhI7BccpWfOS9RMHzHcSvLDPLq8IdpIG3YG6dGjSA1FCR+MrT?= =?us-ascii?Q?FkNGtXIcj0xWZx6nJ9NHQLMHpCFh4h14Lc0YtrR4bMkAGUg8332LqMSQBPz6?= =?us-ascii?Q?H/93Afl2SgnJSk1pHtrHKA6P2EEJmWaFWMaU60hfOO1f/JVXu/QDfvQT/m0N?= =?us-ascii?Q?FLNTWo5wDp1jPNeldprHIQdZFxYME0/2C2DUO2jYhEN3jm4/F6VrWprdrF+G?= =?us-ascii?Q?xVe4DmiIT/AN0OhhcJvw/Wd2In6pdR+MOUYSrHF4uQ0Xj9lGPV1MXOyUYAib?= =?us-ascii?Q?hELOgcpi97p1UbsNm1kbDuKZ3mU8w/QC/BD+Fr2le5CC4mkS+BiDcNXxLZxv?= =?us-ascii?Q?PwtTq5bFBftkFSdcQCSB03prGRgv67txnsXgoZcIKm9d5+yTexeVqAeyDNIA?= =?us-ascii?Q?m4xX52onOKKcr8R3zyu9hepiOjNtSluBZg5bIhPaYrzkPh9L7OeDCnwQXXaD?= =?us-ascii?Q?N2Xq4CN+8KSWWzHpOcL3/+Fqw8S3n6itmXN6fU2WdzQwOFFGExyGA5xvGSfG?= =?us-ascii?Q?JleaGQUpYlGM7j7WMd4hLytr/CHhDqFEvieB0gtUSno9bh2D30L2+40tbv/u?= =?us-ascii?Q?NrO8uGqLbSqGyFMEHYWsEpi1PSFZCd+8x6L1vQQHPHFHxTVojewbqxgdrgSQ?= =?us-ascii?Q?CskAkM8AXXsaM4pWD49rqOfzaTh4c/5NvY9ZWAiMcPwiQDaVsdR7R32PaRn1?= =?us-ascii?Q?aUe6rd0JdO5a0L0XzV7ZtSYncCpqcaYcq/C7M2TsJ2PPWPQS3p2tsW+kWObU?= =?us-ascii?Q?Ew87lWgrz7s29pgWBP/2rlX9lWEdyRqj71aQEhamqXmU8xKZ00rEBj3pZrHf?= =?us-ascii?Q?FxHw3YEMqoIEp0HBhFaNi4yWF5RBhw5DFI0/JXSCldOZr4Pd0TD3bkbTMv8a?= =?us-ascii?Q?2wO+fKyJq1IRzBS4i/bwTvbjWGsQXkMNoCw8l01C2JdY05fYDVrFGKjsi431?= =?us-ascii?Q?7HWXBgvXtw=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e173c74-d8e6-4551-5889-08dee3eafa18 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 10:05:49.3253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eX2/cJzwmYoHMvXotFbE/xl8Rz17yhUrB12ED76yw+wMGVIBxhpy9PaWpdwPlWT0sWuq6MmPQlM+xwJxvlZJlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KU2PPFBE3986883 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Acked-by: Alexander Usyskin --- drivers/misc/mei/gsc-me.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c index 73d5beeb9c34..376840b2c354 100644 --- a/drivers/misc/mei/gsc-me.c +++ b/drivers/misc/mei/gsc-me.c @@ -101,10 +101,8 @@ static int mei_gsc_probe(struct auxiliary_device *aux_= dev, mei_me_irq_quick_handler, mei_me_irq_thread_handler, IRQF_ONESHOT, KBUILD_MODNAME, dev); - if (ret) { - dev_err(device, "irq register failed %d\n", ret); + if (ret) goto err; - } } =20 ret =3D mei_register(dev, device); --=20 2.34.1