From nobody Sat Jul 25 05:29:26 2026 Received: from mail-pj2-f3.google.com (mail-pj2-f3.google.com [74.125.227.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B10AF3E4C65 for ; Fri, 17 Jul 2026 08:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784277598; cv=none; b=j3RQ/K0C0zILiw/jNH1CJ1yuftWPLDR62mqF2BisI/41ObTWauxU3hpwDf9xt8Cz1d+qHoX4r3PF5J3G4wT72XDwoQ/q5EjbYh0fv5wEvESYOLjh2JKsfpHShx9mAKlGt5GeoLg8xB5jco6nYtU/7MY+jK8r4Dv7vc1VaiZF/8Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784277598; c=relaxed/simple; bh=H3GQDQLM3/sMzbexVRKe9kXmIYmX6pHOQJ0+Q9cfII8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UWG0pdTEuRuIiJQkdZRJCd0hNE9rI2gVRAZ96HdMxt44HL8GMFtIWaqUgY6eyH4eiZnaO8QrQvXWfMU/iQyQ7kHlSW7hqlO8LYwWrXZrVIDTlz1YU9dS0tFjpLsq7wFqC2JdNUr76wMxZ+1xIBBvGZ5NusZ5RKIIS03en39/I60= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jAgDEN5b; arc=none smtp.client-ip=74.125.227.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jAgDEN5b" Received: by mail-pj2-f3.google.com with SMTP id d9443c01a7336-2ccbff2e6a7so46873155ad.1 for ; Fri, 17 Jul 2026 01:39:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784277596; x=1784882396; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=os06Hz1EE+6kvFIzrlf+U5cWKP6xlbMTLi7tD84z9LI=; b=jAgDEN5b5WJdCo9W0JmY7xO+oJmvcg201mRI+Zbm1tmw/wzwVcJWWzqKrt5SbRp5TY lunLMjgHPqHWMmDl9WUNXdJgM9tvfnY00HFiwCOpuFi9BsBhjC/vKSdVyhiXi/i/2nTq dfmXOkZj52GCW+wzT4zJt9bPmYpc8iVJsJiLDE2Mo6wlucvJE591nBv525H/rmW82Pkx /O86jWOnMGXgwOdLMeBR8cg2InHtxYoxsQqT5g7pferfBgvCB18iVOGtmsxgTcpzCI19 iiDtOzf/gpZbkxZI2BukMwm2wm3TOtKGU7KSrRdUHmhvco1q7k1FpCLN+QJOn8HiAraO pGaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784277596; x=1784882396; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=os06Hz1EE+6kvFIzrlf+U5cWKP6xlbMTLi7tD84z9LI=; b=SoR1MKhDZ5htp/ohGc7eWA0CG95b9rVfhCmroiPoaM9aqfHGnErmZY/B0ZTotk/Ex5 qz2/+HLcRnTqxN9u9PIwSMIB4c1fm3dUVV2nOFXWLaPyLrvxQk+Y1o6nhGehch71lGIE ErpXvyujydhcqB16WyG8ex/vS+ec6xYt19VooGEtBVXRbYXlEhLxE3sN5DN7Dbrx3Qmd 8kD3kbp46CFRJ0o+4zLXXcMsrCgzR4iidaKEnARnfdLhsAj781460DVoSmV5cawv5tTV A3F8f0Odzkr9ludJAl8qOI4DWFNk1A7M+PZQMlYkGrugiRsF62n4RkVr9nyG+877F+FS h34g== X-Forwarded-Encrypted: i=1; AHgh+RqEZ3YqtO4BS+XDKaBJdFuhp0VKkPfrDKdb60qVnMWsgDxD46shLrGka88aImtQQyS9Gtyjdm7aTpynSO8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9vndUDSSiVXEBbPRHCQAVkJbWhGm3dJmfNnXgguxjt3onn2uW AWDt4kG27UHm4mZV1t8AZ+Pb3+pOZBDrY11l8DT0cvXaBGIXi6oAlE7d X-Gm-Gg: AfdE7cmmupQDD9JYZCCh0w9psCBwWhz/5s13jHSzRf1xtV6lQJYShx3lXYxpJaEvwKk aqgD123ba8/aqArTd4plIvW3RfTymeuqQFWgvpeTf2JlzayD5kJtZYDPC7DXGG1j+qzCK9LfYyd Tb+UtL7g0f1LXwq6Z35tZVhdxx1YJxr/9onYqy9fn/1Y7pAyy/H6/Guv6JgsBom68w++L2L7B6v wGmCkKildq1WLSwq575qWQPcMua7vGoD9Q9eZSphBf+BfQMie13Q29FvxxI5rFAjPp8xz8XEQh1 pqWyZeLpPEG/CFPjqptMOsTbVp2y9XBXwEQN6gWwlcfgpHNfO3I1hfbl7pcMoJ0qtdCxm1ugpuh GtthCXw+NYAmIRtMy5bHVrPTzaxMx5O1kjhTr5Tm3pEQXXHbEvSLkItGYhfB0WZU+4NgIR+B7aK 1yo+Rw4slCeWQHvCEapNTRlF/jZb0= X-Received: by 2002:a17:903:41d0:b0:2ce:6d4a:5b8a with SMTP id d9443c01a7336-2cf34a4c2b5mr17058975ad.38.1784277595966; Fri, 17 Jul 2026 01:39:55 -0700 (PDT) Received: from DESKTOP-P5RIK7I.localdomain ([118.112.177.142]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf344be458sm6842445ad.25.2026.07.17.01.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 01:39:55 -0700 (PDT) From: jianyungao89@gmail.com To: dongsheng.yang@linux.dev, cengku@gmail.com Cc: mpatocka@redhat.com, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Jianyun Gao Subject: [PATCH 1/3] dm-pcache: replace tabs with spaces in comments to fix ASCII diagram alignment Date: Fri, 17 Jul 2026 16:38:54 +0800 Message-Id: <20260717083856.12820-2-jianyungao89@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717083856.12820-1-jianyungao89@gmail.com> References: <20260717083856.12820-1-jianyungao89@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jianyun Gao Some editors interpret tabs as 4 spaces while others use 2, causing ASCII art diagrams in comments to misalign and hurt readability. Replace tabs with spaces to ensure consistent display across all editors. Signed-off-by: Jianyun Gao --- drivers/md/dm-pcache/cache.h | 4 ++-- drivers/md/dm-pcache/cache_key.c | 2 +- drivers/md/dm-pcache/cache_req.c | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/md/dm-pcache/cache.h b/drivers/md/dm-pcache/cache.h index 27613b56be54..b1f44f62e336 100644 --- a/drivers/md/dm-pcache/cache.h +++ b/drivers/md/dm-pcache/cache.h @@ -273,7 +273,7 @@ struct pcache_cache_subtree_walk_ctx { struct list_head *submit_req_list; =20 /* - * |--------| key_tmp + * |--------| key_tmp * |=3D=3D=3D=3D| key */ int (*before)(struct pcache_cache_key *key, struct pcache_cache_key *key_= tmp, @@ -281,7 +281,7 @@ struct pcache_cache_subtree_walk_ctx { =20 /* * |----------| key_tmp - * |=3D=3D=3D=3D=3D| key + * |=3D=3D=3D=3D=3D| key */ int (*after)(struct pcache_cache_key *key, struct pcache_cache_key *key_t= mp, struct pcache_cache_subtree_walk_ctx *ctx); diff --git a/drivers/md/dm-pcache/cache_key.c b/drivers/md/dm-pcache/cache_= key.c index e068e878231b..c83fcb303e88 100644 --- a/drivers/md/dm-pcache/cache_key.c +++ b/drivers/md/dm-pcache/cache_key.c @@ -265,7 +265,7 @@ int cache_subtree_walk(struct pcache_cache_subtree_walk= _ctx *ctx) =20 /* * If key_tmp starts after the end of key, stop traversing. - * |--------| + * |--------| * |=3D=3D=3D=3D| */ if (cache_key_lstart(key_tmp) >=3D cache_key_lend(key)) { diff --git a/drivers/md/dm-pcache/cache_req.c b/drivers/md/dm-pcache/cache_= req.c index 7854a30e07b7..cc5747d472e9 100644 --- a/drivers/md/dm-pcache/cache_req.c +++ b/drivers/md/dm-pcache/cache_req.c @@ -317,7 +317,7 @@ static struct pcache_backing_dev_req *get_pre_alloc_req= (struct pcache_cache_subt * * The scenario handled here: * - * |--------| key_tmp (existing cached range) + * |--------| key_tmp (existing cached range) * |=3D=3D=3D=3D| key (requested range, preceding key_tmp) * * Since `key` is before `key_tmp`, it signifies that the requested data @@ -352,7 +352,7 @@ static int read_before(struct pcache_cache_key *key, st= ruct pcache_cache_key *ke * During cache_subtree_walk, this function manages a scenario where part = of the * requested data range overlaps with an existing cache node (`key_tmp`). * - * |----------------| key_tmp (existing cached range) + * |----------------| key_tmp (existing cached range) * |=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D| key (requested range, overlappi= ng the tail of key_tmp) */ static int read_overlap_tail(struct pcache_cache_key *key, struct pcache_c= ache_key *key_tmp, @@ -474,8 +474,8 @@ static int read_overlap_contain(struct pcache_cache_key= *key, struct pcache_cach } =20 /* - * |-----------| key_tmp (existing cached range) - * |=3D=3D=3D=3D| key (requested range, fully within key_tmp) + * |-----------| key_tmp (existing cached range) + * |=3D=3D=3D=3D| key (requested range, fully within key_tmp) * * If `key_tmp` contains valid cached data, this function copies the relev= ant * portion to the request's bio. Otherwise, it sends a backing request to @@ -524,8 +524,8 @@ static int read_overlap_contained(struct pcache_cache_k= ey *key, struct pcache_ca } =20 /* - * |--------| key_tmp (existing cached range) - * |=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D| key (requested range, overlapping= the head of key_tmp) + * |--------| key_tmp (existing cached range) + * |=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D| key (requested range, overlapping = the head of key_tmp) */ static int read_overlap_head(struct pcache_cache_key *key, struct pcache_c= ache_key *key_tmp, struct pcache_cache_subtree_walk_ctx *ctx) --=20 2.34.1 From nobody Sat Jul 25 05:29:26 2026 Received: from mail-pj2-f3.google.com (mail-pj2-f3.google.com [74.125.227.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B61423E4C6B for ; Fri, 17 Jul 2026 08:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784277608; cv=none; b=R0tMWtNibQWx9KaBAPkC0slpl3kXAgHKDisSaoDtPQ9R1T3WN2QrsECysM9dPTDoxGOdR1FPHveMjq0S7MFQUwAhz8yCZoxWwSAhTLIpQLFZlUR0WRx0VsIgfJfaVQI8pFkXogW3L0wecqTHaN1RLxATyjv3fgzx/aqU1sNokHI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784277608; c=relaxed/simple; bh=GZ5gwgCP2LA26o6pMZlFMuRWHmWxQ6Zx+dcQOna+q7U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DhuOCo6C2m00Ljnc3a/Tco6qckROgIcUwP/bbkvq9ARI1/k5uQJEkhTTOJRgzRgOcaaLoEThEtpoX5OoFeeWfjjeizTHSvwsMxlB/GLasjcT34EzMoI4RLBCjo7cXAlOJBvWoTiFFAqLCcNlBMctwwe0jSSZ0jpBRTF0Stp9NZI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NOEBfExw; arc=none smtp.client-ip=74.125.227.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NOEBfExw" Received: by mail-pj2-f3.google.com with SMTP id d9443c01a7336-2cc8ed77bbcso49008325ad.0 for ; Fri, 17 Jul 2026 01:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784277605; x=1784882405; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KezZCHqRxWTLWtHb/Ud8bW+hXzNnb7tgRNgyfGZ/luY=; b=NOEBfExwAnlywPleG+z2/W/pZmN5tDL3jbEw4Uh/cqBcu/dQf+2PWpotjRK16J9v1J d2DJHGbbg2kSRzIHiJ+EDAuvQxHM36W3FmCfXLNgyYCLbUcmPVeJaPnziYFMJRM2xtFI LEktvFYIesb2+CCrDFizFi7gysQDL3ijqaUDrYiZgzAhsH+w3d2krtIEL61kA2oHOeQT 7+MP7Zo4GZUmFmUbUMZY/7eKKxW0EdJG1gtqxInKSeHpAxnabPNbqKYsmdInWfGDTpFl VcQa7NEvBlJ/xr9yvhId3hcvvqILJdgnY4l1wHMdUXJ7YKEN0ybbi5wF7pDmCQmiKhaA yGow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784277605; x=1784882405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=KezZCHqRxWTLWtHb/Ud8bW+hXzNnb7tgRNgyfGZ/luY=; b=LTVxEq0R64UkZNm46t0l6YomxpNOGSR1mnZEQS4qVyfrDFJZ2PkmgephqsJLtf2iTY 3OfVLBh97ll/99JdGwe1NQeLn6yacn3zZMWqbYQ6EgFGWAvUuG8tng2s5UoYGlCzaESD WQl95uHAaplgzgN7LrN01iPZHWnUxTLPsAu5hvEJXGapJCDe7Ba+XYKgy06UNbXwY8xy k3hFRb067mnJ2ZsO8v21LZTSa3LQ2xDKXtPYFiXpxvq2SQ8q8cLOXSMzYMq4jPm3QGTS gmoOYhGftMiJes2LYOIPAyWZYGDqK812wRUoJkDDa3nOpa5XdtbemtzJfKTVhRThnB1r y3yw== X-Forwarded-Encrypted: i=1; AHgh+RowvBywboSBMBUP9c57W/dqNvbEFddFlkFZ1rhbBvm32BLuzBxnA891HonEr7+WqApIsHNhbRnlywV8eOk=@vger.kernel.org X-Gm-Message-State: AOJu0YxQ0Zleq0sMAGbt28xnr+PhlOC1rS2GbEcV9+NAwZLjeVrJ1xpZ L1RmJKfOeiZfnUDUiep2jvsBjpM1Gcp1WOI55odReovqvDEiPqFIZ/wVj+ufbPb3yqno2NamtrA = X-Gm-Gg: AfdE7cmKHuhJxHhFf1DvqXJwMtiNq5O64fqnqXXEF0RTQ5kpxPqi2A7gjlzMTrJID1F 49lGm1kWLz37jcHHc8isSC+LOsxIBDTQP3+rLiWUNI50pyNJWaFVNf8Zgx6ycp9Ral6VZqveyY3 L90mqbSuMyOoGhThwCGQr1c3/Bh6oM8nJdSRqB/f0v8G2xbecfYB99cu7Rs8p3WKtMDe+dR/dEZ wzW/pQxnfuLQZEgVOu82WQroNYB+LfZSI2Cs2KH89RwEVjnvVmk6RnpAgcSagn2hoF4cn1pxJsp u0d/fisxY3+7Bj76bcdduUJVGcEtHga6vYcPeieaZo+9kadC1jK/1qJk3rMqizRNCY0gHk9gfcc isI1qmmkeYBtPMbRXL//mGZSUbxuTrapLUQQG4cVGyk+b0eUpsYQvyQA6QY0XuPD3D0dtnWbvwb wRVBrHKhIzWIcYm6Q2SaLNcdPTMZ4= X-Received: by 2002:a17:903:24f:b0:2c9:e9c4:82c1 with SMTP id d9443c01a7336-2cf3494af9fmr17587945ad.26.1784277605056; Fri, 17 Jul 2026 01:40:05 -0700 (PDT) Received: from DESKTOP-P5RIK7I.localdomain ([118.112.177.142]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf344be458sm6842445ad.25.2026.07.17.01.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 01:40:04 -0700 (PDT) From: jianyungao89@gmail.com To: dongsheng.yang@linux.dev, cengku@gmail.com Cc: mpatocka@redhat.com, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Jianyun Gao Subject: [PATCH 2/3] dm-pcache: simplify cache_seg_remain() Date: Fri, 17 Jul 2026 16:38:55 +0800 Message-Id: <20260717083856.12820-3-jianyungao89@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717083856.12820-1-jianyungao89@gmail.com> References: <20260717083856.12820-1-jianyungao89@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jianyun Gao Remove redundant local variables and return the expression directly. Signed-off-by: Jianyun Gao --- drivers/md/dm-pcache/cache.h | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/md/dm-pcache/cache.h b/drivers/md/dm-pcache/cache.h index b1f44f62e336..08a9409deb35 100644 --- a/drivers/md/dm-pcache/cache.h +++ b/drivers/md/dm-pcache/cache.h @@ -517,15 +517,7 @@ static inline u32 get_kset_onmedia_size(struct pcache_= cache_kset_onmedia *kset_o */ static inline u32 cache_seg_remain(struct pcache_cache_pos *pos) { - struct pcache_cache_segment *cache_seg; - struct pcache_segment *segment; - u32 seg_remain; - - cache_seg =3D pos->cache_seg; - segment =3D &cache_seg->segment; - seg_remain =3D segment->data_size - pos->seg_off; - - return seg_remain; + return pos->cache_seg->segment.data_size - pos->seg_off; } =20 /** --=20 2.34.1 From nobody Sat Jul 25 05:29:26 2026 Received: from mail-pj2-f11.google.com (mail-pj2-f11.google.com [74.125.227.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 891E33E5A37 for ; Fri, 17 Jul 2026 08:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784277611; cv=none; b=W7OBqxkujYtv6j/z1VispEa/mt+DtXciiUrkZv8Aq4T2fdh7jLL2PpsYyiYzuksJxivS5Ub97eWbtXANXI5byh9JwanDtMoWLBwuazlFTmzXnYbBraEgpAWDDeyZeBreKtw67kMyyntNPCEJ2oHi9wuUaAHEFDP6OklF4XJk8wQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784277611; c=relaxed/simple; bh=OOvCDIL8Iuc/C198tt6pY1A+niCBqQsk3dFca1OLUkc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=t89LrPjJt30K+Au1Tadg61WXLcYojG7QXICufQdCZ6klhI4o3qXl9tgudVvAaIJhnn81ia1LDMS2pzafY5aHyv6lKf7zqVMMWwAg2IlvHUoknkUzsCyXV4pil5sWAz9iSIM+2SnL0iGHEiqd6m42cHcbv55ilpaVTHER1lmvspc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rhUdA53j; arc=none smtp.client-ip=74.125.227.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rhUdA53j" Received: by mail-pj2-f11.google.com with SMTP id d9443c01a7336-2cf02ecb572so22530105ad.1 for ; Fri, 17 Jul 2026 01:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784277610; x=1784882410; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VDRmiQHSYLDQK92BzglLD+34hwddU0qX2gfWudxWF18=; b=rhUdA53jWJPg7XGrOn2yRtA81pQRNRugBxet515g/S/RvOcvODFU9esjujbHeLxYNX GCr5+LeATpsxGFZy0B+G9S+AcCYGf9Dnafh6CFMd+L0MDsWu3wvwMAWeCR/0hl2WmRL+ GyjVXOXlHYE401HKplnCsT8s4qrvCVjM7HoSTWiIYAUUvfEYK1dU7ILo4el+OvFvg6sD GQvJVsuYjMcXU6jKnFXpMZqADQH8RKvl/TRRkWijPFYrUoTaw3ZN4fbUAosE2e5Wgwln toGL/07IPSF2yJw/HLWX/JHN8jIlyZJWRc02mesT0GvFlLon79/Eq+ipwBBedCyDDz+N QSWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784277610; x=1784882410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VDRmiQHSYLDQK92BzglLD+34hwddU0qX2gfWudxWF18=; b=osxb1nXtSTldgRxqS3Cz4FgB6F49Y5eX1jJGWU0dK3jb4Ov8k4dWQ7JwwHKm9uP6IH i7zAfiuB91hUhfE/r+h3sL8FHV3h/hmO+wXbUzS3ApVZo8Qn02NfaqRhQAbOA+USuAFG bu9uRw78+8QzbiEsZpmmah64kGPwY+xXnUQcX9xEPBV9X89A79GZYjYvKGNQmP39yINJ D7jSRp0ssyOpL8EEuZ8G7V1WwulHmJ118/nozG1S+p79ZtYyaddsYYo1pJoRpEhDMOps m1I++Gi/CXw6hUMplrezedB1nLg7bCqDdsgUh/SF0yt9UBFMOM2z0sfFsS7XWGGj7HDn AxDQ== X-Forwarded-Encrypted: i=1; AHgh+Rp4K9vsC1+3kzDZjrWY8f6rKihI+JwESKFiRw0yojRJH/CwKglbvDV1bdEIe9y1hwUpPQ6YVjig5ickrXQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxGd71LANsZbGyGSgaMcp+vB0FhFTx0axqISmYfYAFpvVMiRE6J VikEci+TJ9GBYmmhIS8UGa0FWbcknccm2VZ4f1UhNVvC7qTOZ/y4ew7q X-Gm-Gg: AfdE7cneNQIRPZRBE+R6rLX6VwkJCzY0eKiUu+ZXPOkk+qAMHQzj2NTPV5KF5xK+ZSr 5afCO5MR74YeJtdw1KTjvm15Hq8qZGE1l90CmEg9V9U/oBKTljpZWJXm0NyoAS3nad3IVvBWcWC 39Hlhb35HCGgI0NKdJUEXojh7H6X6epyjr9KitAM983FzDmY/u4LFBG/iSR9OqX9Na7R/b0Blhn uKJzTYtqSDlI4eT1TExhVuiJTbLFb9TBnxX913U57YzS5pPccmTqkhzyArikDkEpMZM2Vy8l3Pk y9atoZxCJYoQgkLDFeE9LT8uXXRWP1x55GVBX1ngL0VBTDjrhhMhs7A82mF+KJeMjtT4+jhHQOy YHDLMXq2BSwNNbhY1Gc6hJz0vKtJRxHJcQNS6msNkLbrnNcseQVkzYJqtKGJk9VUnzNYlxa9lwz 4Qi6/lEG71DoTcR6RFcBvpGYbqFmA= X-Received: by 2002:a17:903:8c8:b0:2cc:5f48:5764 with SMTP id d9443c01a7336-2cf349ebc1dmr16982495ad.44.1784277609770; Fri, 17 Jul 2026 01:40:09 -0700 (PDT) Received: from DESKTOP-P5RIK7I.localdomain ([118.112.177.142]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf344be458sm6842445ad.25.2026.07.17.01.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 01:40:09 -0700 (PDT) From: jianyungao89@gmail.com To: dongsheng.yang@linux.dev, cengku@gmail.com Cc: mpatocka@redhat.com, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Jianyun Gao Subject: [PATCH 3/3] dm-pcache: remove unused 'allocated' variable in cache_data_alloc() Date: Fri, 17 Jul 2026 16:38:56 +0800 Message-Id: <20260717083856.12820-4-jianyungao89@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717083856.12820-1-jianyungao89@gmail.com> References: <20260717083856.12820-1-jianyungao89@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jianyun Gao The 'allocated' variable is never non-zero when its value is consumed. 'to_alloc' was always equal to key->len, so replace them with key->len directly. Signed-off-by: Jianyun Gao --- drivers/md/dm-pcache/cache_req.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm-pcache/cache_req.c b/drivers/md/dm-pcache/cache_= req.c index cc5747d472e9..b2cb3c7615d4 100644 --- a/drivers/md/dm-pcache/cache_req.c +++ b/drivers/md/dm-pcache/cache_req.c @@ -39,13 +39,11 @@ static int cache_data_alloc(struct pcache_cache *cache,= struct pcache_cache_key struct pcache_cache_pos *head_pos; struct pcache_cache_segment *cache_seg; u32 seg_remain; - u32 allocated =3D 0, to_alloc; int ret =3D 0; =20 preempt_disable(); data_head =3D get_data_head(cache); again: - to_alloc =3D key->len - allocated; if (!data_head->head_pos.cache_seg) { seg_remain =3D 0; } else { @@ -57,10 +55,9 @@ static int cache_data_alloc(struct pcache_cache *cache, = struct pcache_cache_key seg_remain =3D cache_seg_remain(head_pos); } =20 - if (seg_remain > to_alloc) { + if (seg_remain > key->len) { /* If remaining space in segment is sufficient for the cache key, alloca= te it. */ - cache_pos_advance(head_pos, to_alloc); - allocated +=3D to_alloc; + cache_pos_advance(head_pos, key->len); cache_seg_get(cache_seg); } else if (seg_remain) { /* If remaining space is not enough, allocate the remaining space and ad= just the cache key length. */ --=20 2.34.1