From nobody Sat Jul 25 05:59:49 2026 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96C5E2641EE for ; Fri, 17 Jul 2026 07:49:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784274549; cv=none; b=UDGeJPqUDndz+dZLE++wDk+B+aZdkqMtikA2+zBIX9KyE+IUMztDQgnMBEr8iEyX9XdgvNw+efR9BiHUOWFpnex1Bnv7rX4teEOlumINNYc5bA9VJBiF4EtEaVhXq8Zlv3bRukfUfJrMRzPtWewN1IG+lKgm5Q3bkskMJlhMnsc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784274549; c=relaxed/simple; bh=QsX25RSzBaeCDGxjfNm9Iy0psAtxdi41sZxfmHj8aiM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YDvcwKwcXkpvKVxEpycEVVGQe6WuuWKKryaAA0aXbo55B4ElZNDbIyCOHMuU9b+EtOnsMpZ46mbCFfeVU2WUmRaDLUnfBRuS2F4G7BhNc+ySB5tJMSjv08YEGxwfMQ8/t+8aU2yuJULdD7jEdhCdrxjFxjd9zu4aTEqLjcf4U1U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cTKZ9UHS; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cTKZ9UHS" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-697bd21fdc2so4575091a12.1 for ; Fri, 17 Jul 2026 00:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784274544; x=1784879344; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tKk5vrY2co9MgfAMfcRD+C8jGuDWrHk9IrcaAoCqleM=; b=cTKZ9UHSl6c1ekB7LTGgocqVMqFr0E3lITnKgTZ2Cfipn/I1kvT6gGIFED19LgYZaX BtToH0fY1ZFGhyxe8wlOHGTlYA7A+7iL/+xQHCl0LAml7y8fEyZOxUb2GyQ1mHhVzOZk AjBfjtYBP9r2j+IzdA2q4F9ECj0cBmHdLENkLwMPVdeB+uv3jVwQnQjjRWcrTq3KrOpJ 9IY69yyzgJ6PN7Pqno7Z0kSQA6kg931twh+BxmZAXgIOfMeBD4gOXv+1pmnCV6niySYu bLDx1AF9qlxQv7K+sHG+/Zh/Kx+JrPxNAbzUOTqICNUpa2GW8RFTo7NDvvmCy8mu5ySA bS5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784274544; x=1784879344; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tKk5vrY2co9MgfAMfcRD+C8jGuDWrHk9IrcaAoCqleM=; b=r1ur0Ia1tN6subFUVRj3yolMt0ZRdhZshH26g06RtxOSeeXkt4A3lXBH+NLLuYW12U /yMUK8x0QCyZxQyvfTfvIhX6fF2CRGnxXClsUUo3Iu3jKZvQb7kVm1adk0iGU/8+uJYQ liFYidiR4wCnu0kTw+7w88eu1ELk70sc9Ukg4y8c8yAYE1WskOfUaTWAHq1mc4qes/jY ScBtnPw8ezhszwJzJdrj8dnEORxJe2aMmvgCfMfsbVVS3xvvKSRDafHswgO7UTKYb4yf AKTR3WfV0JpATPA5pCFcB6dIAGK9LWN5FBf8jEuDM/ZHEWfcASGRAukIZelsUyv+Gp4S I1/g== X-Forwarded-Encrypted: i=1; AHgh+Rqx1I5KyZOB7rzXMHmsq7jtIEXu4Yqp55GMxHmGHTGynLZqT3SVv8iVK6FIG6qIBHHQhqa8jB8Smfmp0uo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5HH8R4x145qaMvwo9aKRTKKJO+LTLWy2PlUofl2JIJzrGcOO2 Cm+HkZ69+QdU6+euLAqQwMZiFILdzkKFH62iZoRX6ZaMEEJZO5KdqAI4 X-Gm-Gg: AfdE7ckzjMnnZHGxns6/NlMG1buuwiuiOd6bHv7es9YqVJt+hjlbn2MrlshzgIvrI1V TUqCfxuLuh2u8w2o2zOn4hTPjnP7DvhtRAPkzxxL8+48fGre3RBmsdDWp17L1au8o1jLlWuVvfh gKpcCrJVMwKjAhC/fXmVdMydYxt2OLnjLt/g+KN5wBvE6hYqcE40CoUpqzGvTAkmG0VEgUcgIll Eqw0wqossrmpu9Tdl+bxSLgXMhzjSLzD4+evRFnyunwuZ6/Gexzn9G7OiiopALnu7/3OrTsnliQ 2kE3+uSh++2ZkuidKIzdPQ6XhJHtmEpItP3RiXeC7pSHcoKxKc66i7ZxewL66+BtA4uzbbieMdy r9WFzgzAN71OTYOA/GiaLPiGGPYUzSBD72N4mLy8EaVNXV9nHzGm95V1ngXEoPf2c9I/8OCQVtu ex+NDNl/gNJQrwPzlfhGkc1kibdJrBxTuDs2g4jsaNDj2du2gXIHF/syh9nonnU2o3+WNm1PfUX PmS4pXXGta++DjCP/uXNNZa0nAUWAzXrtXU9C2tUn/LKvy/k5fOPy7+tmIUjLTxM2pKfZtGYRCC N07goAoUUFohj5eu6LDbUIlqiheWlTXoJmOWbnwHV59UDM195fKnrMMZoo5KevNMuES/B2yBwvi geymj6ae/XQp/cGNCbw/LrAH8zP7gtjkEBfh447Mzd6LlKI77Pk9vnsE30tQlyfLs+jNAJpF3A+ qmvc9HGLqVd1+OX7QglKc= X-Received: by 2002:a17:907:970c:b0:bee:b5f2:639d with SMTP id a640c23a62f3a-c16b47289bcmr61632666b.10.1784274543794; Fri, 17 Jul 2026 00:49:03 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-a.c.oa7bb030819b2a894-tp.internal (193.216.13.34.bc.googleusercontent.com. [34.13.216.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c172349690bsm35374766b.42.2026.07.17.00.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 00:49:03 -0700 (PDT) From: Joshua Crofts To: Ryusuke Konishi , Viacheslav Dubeyko Cc: linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+cae54346a70bbceeff2c@syzkaller.appspotmail.com Subject: [PATCH] nilfs2: fix infinite loop in nilfs_clean_segments() Date: Fri, 17 Jul 2026 07:47:10 +0000 Message-ID: <20260717074710.1397-1-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" syzbot reported a hung task in nilfs_transaction_begin(). This occurs because the cleaner ioctl falls into an infinite loop if nilfs_segctor_construct() repeatedly returns -EROFS (e.g. the device is remounted as read-only after an I/O error). Currently in nilfs_clean_segments(), if err is non-zero, it logs the error and sleeps but doesn't abort when it encounters a terminal error like -EROFS. This causes the thread to loop forever. Fix this by breaking out of the loop if nilfs_segctor_construct() returns -EROFS. This matches the behaviour in nilfs_segctor_write_out(), which also handles -EROFS. Reported-by: syzbot+cae54346a70bbceeff2c@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Dcae54346a70bbceeff2c Fixes: 9ff05123e3bf ("nilfs2: segment constructor") Assisted-by: gemini:gemini-3.1-pro Signed-off-by: Joshua Crofts --- As much as I've tried, syzbot is unable to test this and always fails with "FATAL: Kernel too old". Nevertheless, I've tested the patch with the same reproducer in QEMU and the system didn't hang. --- fs/nilfs2/segment.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 9332f5ac6..91d3bb314 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -2561,6 +2561,9 @@ int nilfs_clean_segments(struct super_block *sb, stru= ct nilfs_argv *argv, break; =20 nilfs_warn(sb, "error %d cleaning segments", err); + if (unlikely(err =3D=3D -EROFS)) + break; + set_current_state(TASK_INTERRUPTIBLE); schedule_timeout(sci->sc_interval); } --=20 2.47.3