From nobody Sat Jul 25 05:59:38 2026 Received: from flow-b4-smtp.messagingengine.com (flow-b4-smtp.messagingengine.com [202.12.124.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97C583D3CFF; Fri, 17 Jul 2026 06:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784271589; cv=none; b=vFt55dlmYMl/Ay856V/TAMpz9uq+QHwzR6CrMDNAzsoy8srMPu8z5NIJfp8lCEhr+rLtLai6YxXQiriPIACACo5tqugbxvsFhJVBQLXixnIOc4K4tn7WDfeJ2IupS0AV5yX54C5h02ilhY0f3j69NjwpakRZbUu2SLij0JHgNhs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784271589; c=relaxed/simple; bh=Lw0WXQNj+UDucKZ0V8r8SvhkbRfH6VFsCRqgQWhrvlA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mFQDWB3AkctyQJHn7/iSYXTTzGc2aW4ubOu8WCDipg5MqMS+3tHuFdU5PwTCNCcBRprZvCXyUj1Ijbuo5YA3erb+H0cy9ewS+EDHssQs7YDSl65T9+oTCQLtgAPjMJMh7xyuvYECey+z0kO8JOm7P5H2bGdpenbpdRzxLiY3ceE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gahingwoo.com; spf=pass smtp.mailfrom=gahingwoo.com; dkim=pass (2048-bit key) header.d=gahingwoo.com header.i=@gahingwoo.com header.b=mnNopGWt; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=DNp8sgxO; arc=none smtp.client-ip=202.12.124.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gahingwoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gahingwoo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gahingwoo.com header.i=@gahingwoo.com header.b="mnNopGWt"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="DNp8sgxO" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailflow.stl.internal (Postfix) with ESMTP id 5D9F813002DE; Fri, 17 Jul 2026 02:59:47 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Fri, 17 Jul 2026 02:59:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gahingwoo.com; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1784271587; x= 1784275187; bh=bB0hJT3PmFV6VVnpy+wEn02P0C7IyJ+v1DOMySWTkaM=; b=m nNopGWtRx/TZ3ipyS7ZgadLWztrAY88a9a9t9bP5NNNakIIaKlRrisvr4IfshX1N rtkkYeSxJL/blDwfHo4kLbZrNGNNExHLg8meez0V1UqmryqsP5SejSH+Rnlcnr0h jf1l/v3FNy0iXEe0eSwFYsISdFJCiUVmlwL9A/jav5h2mxBiUi+KyQMXiCVTc1d1 lNFRPurLvYseJTgfNcZccP8icpAMyps1IFOoMcvKZjTj19Dva3aY204HBXfRYRpk jABXhaAguliYopWjACTl9ee8jFgmJ9renRRSsEyLeX144AegPXKr29erNxKYFdGQ 3AsukKMrsi3RFsSKfKkWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1784271587; x=1784275187; bh=b B0hJT3PmFV6VVnpy+wEn02P0C7IyJ+v1DOMySWTkaM=; b=DNp8sgxOisMqXWP0d gh2o5DqMVCCpuCG19v+Psr6hDgBpObq2UgYBGItf8+ZxAJEVhyfWqPxYZXink3rO He7OGIzmH6/vdsXhfilfBdT0ipzJ+PxnttsfiImAGWAOn004ss37UjgrK8VvpMtv ycKjBc3+3wZjH2mB94UKIgLqN9kDKY3DOCv/E7Or/k+rvPcCS8cy8IeLC24xNoX6 Z8/GmwygtMbC1fkVjx8+/At6sm6McKp7KPr6EZQSAYM9p8OonoTdvC2vVx16PXIO hSXCO+OTGO0u4E4TjhrlFImuJCXgW1Liwb/zjM5QYswb5bVf3l/97dHYNEC5wIIE JxKxw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGLHoAYSuSv1o2npO99y2j4JkxLBJgWvGtMoWzVR091WtPJ1Xci9p6O9uorqIXytS qgiXLBX5pDi0cPzeDICNt6t/BjVh6mt6bhnC1C9CdJS3gO9mNnV/Rt+6btcqroSenMILop voSGMzPtXFidDk7Dp2YoPeT50jUo5Q3onDmNotbFDoLJF/D3BCYCo8e2eP7pyPHIz2TSZC jsi6aJHydnCg5nKTF+BekS20EeckpNO8KO0n0tfCCCM8qMgu4tlj8ReyNRU5j9Oz6Mh4EJ V2sIjpMsj8gCmoVqK3xuHwBHpYYmhbaxejpxfiWeEKyUfqC8zJxs1qeJl6zVpKllXpKBtI qpGNbwJnO1qGqSrA8cjy5YTlpfntk5Bff0d6uANOd1uTii2R5XMaX+zeWLVdmK2sAm8TAS nQtymLeDn3c7CBER+Y09MMwqH0AdHriOebrd29I/pq+Irx6vQ/YrjxkaGLxKiHMxWfpHaA OK3alGrWTqf1HEqn0BFAZxd+egDlqNdLpXTtc2Gbt0KRHnFdmRvG+C6QvNIzyJfw4+hJQA 5NrBvqBwUQkghcIMkhk7TecGYFy9UqcRQcqCuNyP/LCw78WJ5tuqKDO4DomS00JDL1YPB5 XahK/0QBsJD5Ik9toHV7UTVmNLFO+9yunbU00FbnwCjRRniGRLRVdi14ka/A X-ME-Proxy: Feedback-ID: i7a5e4b5f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Jul 2026 02:59:42 -0400 (EDT) From: Jiaxing Hu To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com Cc: netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com, Jiaxing Hu Subject: [PATCH net-next v2 1/2] dt-bindings: net: rockchip-dwmac: allow output clock_in_out for RGMII Date: Fri, 17 Jul 2026 18:59:32 +1200 Message-ID: <20260717065933.2629501-2-gahing@gahingwoo.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260717065933.2629501-1-gahing@gahingwoo.com> References: <20260717065933.2629501-1-gahing@gahingwoo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clock_in_out description said RGMII must use "input". That is no longer true: an RGMII PHY with no crystal can take its 25 MHz reference from the SoC, in which case clock_in_out is "output". Document it. Signed-off-by: Jiaxing Hu --- Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Do= cumentation/devicetree/bindings/net/rockchip-dwmac.yaml index 80c252845..d5816d6dc 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -89,8 +89,9 @@ properties: =20 clock_in_out: description: - For RGMII, it must be "input", means main clock(125MHz) - is not sourced from SoC's PLL, but input from PHY. + For RGMII, "input" means the 125MHz main clock is input from the + PHY, not sourced from the SoC PLL; "output" means the SoC provides + a 25MHz reference clock out to a crystal-less PHY. For RMII, "input" means PHY provides the reference clock(50MHz), "output" means GMAC provides the reference clock. $ref: /schemas/types.yaml#/definitions/string --=20 2.43.0 From nobody Sat Jul 25 05:59:38 2026 Received: from flow-b4-smtp.messagingengine.com (flow-b4-smtp.messagingengine.com [202.12.124.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA3583D9695; Fri, 17 Jul 2026 06:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784271597; cv=none; b=p05W7hAc/sSuAbICaA0L62F+xmwNCiDVVn1RxXDenAv2LbCr/9GyyQaXgDkYARaA3bsjAVggV/IXYUgSvTYOA3n/MDcHQSGKD19FhRxrkEMbLuIEmtXTO+kvdacFz4i2K02NvBooEF9wCpPitO/pD5ywMz1ba9tZmcfKM9fAGaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784271597; c=relaxed/simple; bh=kFHCrQHc321zynVITXaL162igpcjTuOc6p+EGhQzzLM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=avVQN5mv16szSgb4VYGjWglpRhjSxt+TRhkBEIf41H9g/UoAYZVrni0HUawgE9FvPI0cwCW9QwjASJIB9MYiz1tRbBwqryogD/tjecZzg9DAhOwfGp9/Kyb714d4PzPa/foA9AnC3St8D6RlMjNfqLoiDDY627LePtDis+fin2Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gahingwoo.com; spf=pass smtp.mailfrom=gahingwoo.com; dkim=pass (2048-bit key) header.d=gahingwoo.com header.i=@gahingwoo.com header.b=kbFlxD+e; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=BNKZlXH0; arc=none smtp.client-ip=202.12.124.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gahingwoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gahingwoo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gahingwoo.com header.i=@gahingwoo.com header.b="kbFlxD+e"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="BNKZlXH0" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailflow.stl.internal (Postfix) with ESMTP id AF23E13002E2; Fri, 17 Jul 2026 02:59:54 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Fri, 17 Jul 2026 02:59:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gahingwoo.com; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1784271594; x= 1784275194; bh=uIIyMwAcqVkt+px899RrpC9+Fguty7npn2U4kEL+f9I=; b=k bFlxD+e6niwqY1tiKSQgm/1EIA4GgO5TGNo3Ufd6/kR66jIfwM2fFGBj0koX5z5q Dism3PjcU68iYVHm+MwOHuFBeb/u+RCTAabsxKjmuwSU/lBFzXmR7zFaZhhjnQok WlGfSgKRv69HuNf7nAe1YWbUlS1H6FlTbomB0aUqS5vVkMUsxUY320wAc2pYlz17 Fpn3VFuSpAIm+v9mGCPFgWCCbtiAkcUxZb15EnoQihNu112G91b7MEDWQeSxabr5 jijsCmstZiNWbRrjKYyiz7h1q8zTPJgwvb79HxF2XhxwmN9uvZ3LdjMMmKjvRfme JT+9YSHaJhcAJn+Z7w1ng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1784271594; x=1784275194; bh=u IIyMwAcqVkt+px899RrpC9+Fguty7npn2U4kEL+f9I=; b=BNKZlXH0gVneubIGH mFSun4XmlX1ytpbO6oONoaytREBXZ5TILPagxBvqFJjuFiljM3CdFT6Ycq9d0WsV A1NbxTPAaeyw4SEqr0Nq6msxm/ZWxrnkKrpJBoNH/fzCXXjeXZUgnDmiZ24gopvD ndrnswzJ5364Hfwkub3Jo+Km2/rU9DPEO3jvab9KMmZlMne5au17djpJf0BQyOSt I0XZEq+mg+nTuZ5GyimpRFQziTJPQTrqfEFgNX+bWWDOzy7pIneKRLDeuYpoPWS1 Qi3Y9wxNhX+2xOvKjEwW9wZp6i3PB93XdbSGP3NQHAxQFgiIRyQwEjExfO3zaVwr onxHA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGLHoAYSuSv1o2npO99y2j4JkxLBJgWvGtMoWzVR091WtPJ1Xci9p6O9uorqIXytS qgiXLBX5pDi0cPzeDICNt6t/BjVh6mt6bhnC1C9CdJS3gO9mNnV/Rt+6btcqroSenMILop voSGMzPtXFidDk7Dp2YoPeT50jUo5Q3onDmNotbFDoLJF/D3BCYCo8e2eP7pyPHIz2TSZC jsi6aJHydnCg5nKTF+BekS20EeckpNO8KO0n0tfCCCM8qMgu4tlj8ReyNRU5j9Oz6Mh4EJ V2sIjpMsj8gCmoVqK3xuHwBHpYYmhbaxejpxfiWeEKyUfqC8zJxs1qeJl6zVpKllXpKBAI QmsQGq4Oe2fjIaSKONDkMpKaNQ/2YbfFu+2VjSH2vvfAged8qiT9ds2xi/eY8zrSKZo5Xg UiVX3GqojPDOBM5zZ44nwJ3/64hUfSF0NyO0S9a+k1v9yw3TIJYTc/GX/JoTQKYnQ8mI8d ZRrfCFDUtkEYgHzp5cp/a06g33DHbP+MqCfQqXKerG2CIgRGWJjesR2pQ5WwJuJMOJIbbP 8hDmdi8p4vh1jVXx/McSWsg8az8VLn1glcMKnFg8y+1I71PNsBw33mFvn9tgej2PaYXO66 orGyfrxUtH0EjJh49PqzjQoD+mJcjYaIbMqNePw3LkPCO/j1Nwx+Z5O5Q8qQ X-ME-Proxy: Feedback-ID: i7a5e4b5f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Jul 2026 02:59:49 -0400 (EDT) From: Jiaxing Hu To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com Cc: netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com, Jiaxing Hu Subject: [PATCH net-next v2 2/2] net: stmmac: dwmac-rk: enable the reference clock for output mode Date: Fri, 17 Jul 2026 18:59:33 +1200 Message-ID: <20260717065933.2629501-3-gahing@gahingwoo.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260717065933.2629501-1-gahing@gahingwoo.com> References: <20260717065933.2629501-1-gahing@gahingwoo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rk_gmac_clk_init() only requests the refout clock group for RMII. The ArmSoM CM5 has an on-module YT8531 RGMII PHY with no crystal that needs the SoC 25 MHz reference (clk_mac_refout), so in RGMII the clock was never enabled and the PHY did not respond on MDIO. Request the group whenever the SoC drives the clock (clock_in_out =3D "output"), not just for RMII. The clocks are optional, so other boards are unaffected. Signed-off-by: Jiaxing Hu --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/e= thernet/stmicro/stmmac/dwmac-rk.c index 8d7042e68..dd060e4b8 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -1112,7 +1112,7 @@ static int rk_gmac_clk_init(struct plat_stmmacenet_da= ta *plat) bsp_priv->clk_enabled =3D false; =20 bsp_priv->num_clks =3D ARRAY_SIZE(rk_clocks); - if (phy_iface =3D=3D PHY_INTERFACE_MODE_RMII) + if (phy_iface =3D=3D PHY_INTERFACE_MODE_RMII || !bsp_priv->clock_input) bsp_priv->num_clks +=3D ARRAY_SIZE(rk_rmii_clocks); =20 bsp_priv->clks =3D devm_kcalloc(dev, bsp_priv->num_clks, @@ -1123,7 +1123,7 @@ static int rk_gmac_clk_init(struct plat_stmmacenet_da= ta *plat) for (i =3D 0; i < ARRAY_SIZE(rk_clocks); i++) bsp_priv->clks[i].id =3D rk_clocks[i]; =20 - if (phy_iface =3D=3D PHY_INTERFACE_MODE_RMII) { + if (phy_iface =3D=3D PHY_INTERFACE_MODE_RMII || !bsp_priv->clock_input) { for (j =3D 0; j < ARRAY_SIZE(rk_rmii_clocks); j++) bsp_priv->clks[i++].id =3D rk_rmii_clocks[j]; } --=20 2.43.0