From nobody Sat Jul 25 06:09:49 2026 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11021140.outbound.protection.outlook.com [40.107.74.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2BA4301719; Fri, 17 Jul 2026 05:03:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.140 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264601; cv=fail; b=qeBdMcCjTXx+uBeF47LEeZx7FWwpaxJn0wkWRgpKbg6WMZAD1hu3DteDH9wXCX8Qssz2djndKPTCBBNSWJkk3L7lfIbeRnUTBDvE0lX5lVAQt5+FhRNp4URQJdQufURMxhkr/1xLbcg24635q4nWX/OSnahteS4VSzz9QqbO0Nw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264601; c=relaxed/simple; bh=0kHdLdkfNZcTB4Hj8E23wqhkvaQNBsLCrlKQWNawtkE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Tc9MdCIStzLa5yxJPS1ThxU/L7cD2n9izYsAIm5FWjWbkGESQO8X7MnavUc6HtEG0c0CFArDjTa4u8bHae2AUtad54YbokIvFApefmAqLNQ/QlJX25GFNE/gwPx2GlPsPLjRydTSU8OlAv6uWHcMA6wSB1AOCIT0D2aFNo1hZ7k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=qD6otCxV; arc=fail smtp.client-ip=40.107.74.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="qD6otCxV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iyx6BleQkjUee7YfHSTAyEd5gtH0lGCZMEJPvCgIoehxEtOERyeAk/N4TNhRfeyeoobZB2HzjwB16nWvV/+U7w47Q1iGWDQxIowWGGvANgMpdqv4loVi7zWV5bjMnP/AVA6Ykva4TzXHJfweOTYC7UvX7psU7obwXZVdo7GG/KcXOX24cS+kjoKc6Gx82SfaxVXaWQPznSsqo3EfvCHIiU8L/nY3/saaANXRQB9muK0qVQZ3BCDNnBLoub+j+uTVunDAozXt/KI7rJnG3I3DXk8CWeFmTzM/NENnY0GAiXZ5KdcLo9MxKHtUgU2isbXhqQzT7QBCCii8DKG89UdhSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/SFqbB9JEmCrK5N+35lsFPr8DjylFUejS9lcbxBc0s=; b=iKvvQ4aSzsEoRbiZeH5vejraURVu5r7/kcdZokzik1lJqgG50LttK0jXKbT8h7l0ykHY4F1H6h6Yccju2YUH9+/yUv3XVYqGScfmH8gb/jtqLdjZHDJrrpiI/kBg0Y3mi3ijSwohqmwiepSNswYUtAjCJ52YkkPSteZyqtdZqofBbs8g6mAcfJjgz88LyKxJ8JztONwfwwJnQ4/GSDe48Nt/tdIZmpGUHrXF4m+k9TzOPh69vqx1k3vpftN+uLDvz+vYmPXeEezGnwXKO/659s/WYVhCH9r19aMx9z/tlEyJCK/xI5/6oD1WtdFsYEZzq6akbklooJ2MFxUbKay4YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u/SFqbB9JEmCrK5N+35lsFPr8DjylFUejS9lcbxBc0s=; b=qD6otCxVqJjPViX8RwUBfZMadeMqZ6GB5y1Y5lWfJlOAk5mtcUBNf0x3MJsO5jBYKa/EXr7FYCG1kQXeb/jY2759KvVFkTNfp2V69nEFW9bI+OJvjveq1qRYVg6hq85OeZV73KN5/5eUqBVzNhbsJknEjIO67H9+t3GZb8e9kTA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:15 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:15 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 01/14] dmaengine: dw-edma: Factor out HDMA interrupt setup helper Date: Fri, 17 Jul 2026 14:02:55 +0900 Message-ID: <20260717050308.2144108-2-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0329.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3b7::13) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cedd34c-8d64-4c6e-acd5-08dee3c0b544 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 3PbgqHoLkduAzQX3/940rXgLDA96SpOFlzOyWxRM0N9Vansk0Hi1y7lgOnw02rs+olkHt+G+u0CNjehwNLnwGaGjHo7IoYM5OKeUUQdMFO2N2KDKaXh43U074GDo4oBxd/hsjAOA+kZf5spPRRTO0CNzYkZbqKb80qgpddiD0QqreWaFqvUXNsPv7BjyC5pMR5kMlnC8y/aCEBEC0Xyc2sn47vUpFmLuf6e6amakHHr7OnZkQYjtsLVpqF/QEUbIPPEuTpn2CqfroMF/od6hJnJHfIeqnNEB12PfqxifZZCTh97I+3vVstrOk67I4KVKOUCaX4J7YkP0iIEY52CDn5Wyw7sEi2i5CYHQTtgvl22GUEDDjOquNbTkPv3+6KQkUgop+n7m5eltMjo2/mw8PXE8n5uoO+jPTfqkIcO6V9QRThcBiEV21Q47OhiXH7TFajInHEuk+82fn796bBpp1VUabYZGhVhPEEc2aeynTN6i9sq+3uHn+j9kxAtAI+gDcqWW0iwonMhCpt1oP6eEFDWMaZKgCijk7CeuFEoWiSWehZSDDe+NgFJQLOfutAiG9AMNAzFTr1yDRE1HKzIYij03T2rALyTxAV/JA+A4bczj7JES6h7NSuWklpx3liXzqZ3HIS14Uts2I+fu+XnhujIT0o8gEKnGrYez8z9zkIM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+9jNzoAfHle9PW9rhQSwahzDJOObWTS+uAIy8RxlxOD8sy9xrcBMzdDDPetb?= =?us-ascii?Q?0E+rrXY4H6BDUoB+8kLRjQITDujOc2qXmQfjyiPMb6yI2K7r0xWl7DD45wfa?= =?us-ascii?Q?WbnViQoyHZnWjN9jKyLZ+gwF6DONg0bFQeuaKYtAYkNimXwFLAWaPKFIsCgo?= =?us-ascii?Q?WEdpk2KrCApz0C4i7TTRi2QN7DEstI89N/9E64BuAjYisC/g6TtLSmouse/w?= =?us-ascii?Q?JVGDRELVoTo1N7E4iwnAzWhA0yYegpBaNJptGug4mW0mBHgHS0X+o8ulKJHE?= =?us-ascii?Q?WiAajPxJC535vbg6z2FOkJ12AW6PM7SmgsYLn0/RoAHWi+OLCEMH2pmutE2j?= =?us-ascii?Q?N01c1xWFWmhUIViqp29alDRLlxx+vTO1UJTDb+RVwQx933s2e9l6zOIw30bH?= =?us-ascii?Q?LKYo84r/nXxPjTuMU19MtHPRT9pNRqfZ28VFTn/QDykg3OvjNnf1giWeEuNZ?= =?us-ascii?Q?wXtuUsIyXbiDiiJRIhqjwOsPRF0WQStGt7cjsh94m2bCHfAIWZIWRFXLwdwg?= =?us-ascii?Q?ZeaQ5Re5feD6OYA6Kndrwp8ewkyEmqMYXtZg1M8UqyF9dX3mJaw7BP61/caU?= =?us-ascii?Q?wv9fLLL9JWuKYfIh0TNGCmLP+YAsc5jpJpG2tl+PGodUjjpO6elayWM2/dqa?= =?us-ascii?Q?QVQoaqahsHnpwvWi/MEVnr6ZcUclVge2nEsjdS1cy+D4TLP+kUb5/f1BBIHZ?= =?us-ascii?Q?bjHeZNLG/cfoCb0jQ/l4gi/FP2fdc5cZQDV5dUKZ425oQVwQAArfqnJP3h8V?= =?us-ascii?Q?AsmVn29QfDqLRKAt7onXzKcAVohKjT1wanUrCH772sAhipYIBWHuxzENm7zS?= =?us-ascii?Q?w+ajkcXmz/kXsD+IYUeZ6/18q0xM6AmTI+zHhSdgwU27KCrGVWRkoDXRiFH3?= =?us-ascii?Q?xYPLaAKcGRMU/FUu3j68hXfA0iCRHU9zXnS00r5vSPLoDGGoBfJkstvyrez9?= =?us-ascii?Q?E97vPo7dIgpjz7nTj3IoNS0rqvf/9UO8RPWljnQwd3MMurBEcupWsgFDj7Nw?= =?us-ascii?Q?mWJXLyJFCiVXPp7rtuKA8TvZ8GI6K4gWcECtNmeLJxde1wU+0xS8rDim4imR?= =?us-ascii?Q?hya1nABXU4giZnPx+3SKGfsMizcXhtgi1vFrp7a1vVlmE6NXTLdKZcyVkFd7?= =?us-ascii?Q?VaCupqkjbsoPsBcSvjJGsXiEDBYFz7HAeZOb60vuzCdHItaFzis9epCmQ6nf?= =?us-ascii?Q?8Mp53qDgngI0LKRTNdlfjeyFABrGFcRzZcs2Y4c624RwtSjf9qnJCWWDVh6j?= =?us-ascii?Q?6EO+3xjhR6F6gTUG6khhsRQZPEhGGCkDz2hnjiXG03iqPLoeNj2Y0HRjjEJB?= =?us-ascii?Q?0uwH97d2cUXaIMc21VdlFLaFB7ZrhDBHDlYMKNeJPvJ3V/Bgev20y0gjSFLG?= =?us-ascii?Q?A+OkP43rDWr4fxqB1etf6butBeus3IdWsSs2nGHzsXhBvqdZ/k++wv3NqxYj?= =?us-ascii?Q?PKjngI458lbk2LK0yQ6ndBQqKU9MLnuZvq7XD7cn5ouGlGTcnPuVxn+8mWDm?= =?us-ascii?Q?2pzideLoi7zwufx4aVW2ugDjIYeNJTZzOSPWg/UDhkwOcIN8aLqyXAz49dgH?= =?us-ascii?Q?kvBaX84zGWvACp5o8SicxgOWJBkk6PO25dsM/XE2+L0uSSERsupWsA23wiOV?= =?us-ascii?Q?Kmc44BiNiGiYzG2sboplWLoQFW6TA0bV4vVm/zETsmwrYQnlfGTEPtGxA0k5?= =?us-ascii?Q?TV3TQpNxoPsyaGn5me3NCme/mcw4CzHfHHSsneyzhfnrqTSxWsZ6bBMrxxRh?= =?us-ascii?Q?49vQ7Ac06be3/ekyu9778/1VQPVuddt34WrSSteGSzyN1ilf6QZU?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 7cedd34c-8d64-4c6e-acd5-08dee3c0b544 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:14.9221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V+qi4Mtw/Bn4tC5rrNfGZHL7WaXkPhcI+4txRS/1bZR8yv6GZP/rwCxO/NazI57asyqHNdF3/Mv9rP5a/82o6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" The HDMA linked-list and non-linked-list start paths both program the stop/abort interrupt setup register using the same local/remote enable policy. Only the interrupt-mask handling differs by transfer mode. Factor the common setup into dw_hdma_v0_core_int_setup() before adding per-channel interrupt routing support. No functional change intended. Suggested-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - No changes. drivers/dma/dw-edma/dw-hdma-v0-core.c | 34 ++++++++++++++------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw= -hdma-v0-core.c index 4bf5a441afbf..b455da3d9b0f 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -49,6 +49,21 @@ __dw_ch_regs(struct dw_edma *dw, enum dw_edma_dir dir, u= 16 ch) writel(value, &(__dw_ch_regs(dw, EDMA_DIR_READ, ch)->name)); \ } while (0) =20 +static u32 dw_hdma_v0_core_int_setup(struct dw_edma_chan *chan, u32 val) +{ + if (chan->non_ll) + val |=3D HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK; + else + val &=3D ~(HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK); + + val |=3D HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; + if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL)) + val |=3D HDMA_V0_REMOTE_STOP_INT_EN | + HDMA_V0_REMOTE_ABORT_INT_EN; + + return val; +} + /* HDMA management callbacks */ static void dw_hdma_v0_core_off(struct dw_edma *dw) { @@ -203,11 +218,7 @@ static void dw_hdma_v0_core_ch_enable(struct dw_edma_c= han *chan) SET_CH_32(dw, chan->dir, chan->id, ch_en, BIT(0)); /* Interrupt unmask - stop, abort */ tmp =3D GET_CH_32(dw, chan->dir, chan->id, int_setup); - tmp &=3D ~(HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK); - /* Interrupt enable - stop, abort */ - tmp |=3D HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; - if (!(dw->chip->flags & DW_EDMA_CHIP_LOCAL)) - tmp |=3D HDMA_V0_REMOTE_STOP_INT_EN | HDMA_V0_REMOTE_ABORT_INT_EN; + tmp =3D dw_hdma_v0_core_int_setup(chan, tmp); SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp); /* Channel control */ SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN); @@ -260,17 +271,8 @@ static void dw_hdma_v0_core_non_ll_start(struct dw_edm= a_chan *chan, SET_CH_32(dw, chan->dir, chan->id, transfer_size, child->sz); =20 /* Interrupt setup */ - val =3D GET_CH_32(dw, chan->dir, chan->id, int_setup) | - HDMA_V0_STOP_INT_MASK | - HDMA_V0_ABORT_INT_MASK | - HDMA_V0_LOCAL_STOP_INT_EN | - HDMA_V0_LOCAL_ABORT_INT_EN; - - if (!(dw->chip->flags & DW_EDMA_CHIP_LOCAL)) { - val |=3D HDMA_V0_REMOTE_STOP_INT_EN | - HDMA_V0_REMOTE_ABORT_INT_EN; - } - + val =3D GET_CH_32(dw, chan->dir, chan->id, int_setup); + val =3D dw_hdma_v0_core_int_setup(chan, val); SET_CH_32(dw, chan->dir, chan->id, int_setup, val); =20 /* Channel control setup */ --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11021140.outbound.protection.outlook.com [40.107.74.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54F102F8EA5; Fri, 17 Jul 2026 05:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.140 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264603; cv=fail; b=XTlvtgf8WKkiNqjDPhvawoeNN2ahAjCjbbxr+q28eX7Z1Bpm3UaFCgo3vxdtVMbl9h9Nr06BMHFUkL2+H6VorMMTKq0J0LpIYfIB5bVeJCyLwQRKLZJtB9jgiCdneJk/7THiierd8vfnWaQIVLldWAOtXp2TI97lKbvOaWyUo+k= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264603; c=relaxed/simple; bh=XNhEaVO0+6SFnN/eJIBqTO18QfLpef+Kap73lCp1QlE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Ka/o4qILuSw2Kk/8qN8LboXCbUpGdnpYtu33YTOklVVyYa8Lz4ITSbr21Mhid1BQij5dxnjgshCBQh+zPtXAAvKRHh1OXWCDEcA1OhYgE/VocVsaqGC9fNLjpb4Hbse4oIXRAdX13I+9CQZYp1K6F69m8mCMSyWhNLP1zGNmdcY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=CuI/tuKI; arc=fail smtp.client-ip=40.107.74.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="CuI/tuKI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VMD9bYakOFiCn151PBzB4Xk4cl1Gs3lE5ObKVTH2Ki9IB6fRapTPqhb21FYwhqS4EMCjoKZ/hGq30ymeGsZ5/PodgtswqJ4P1soflQhcdjDw/yGkuktTHzmgKFmzT58nzXMhGZ8OQYp9u6JryjIGsD3HdxyGEiqUn4TUVdxRLtmEcOa8kWkwB9g6PdigQxmW4H9Gw3EWYK12BUbKkB7RwXCWFqCd69pOXZt/A3H2P/h8p4ODfwLBPjXj9NKmiEZOeUO1ielUqwCMAeP/YFddeJh1Y3quDppcKF0qy4jrvALEDy7RHsjUWMa8JYBV7BGEwzGz8oHji7BrBxyLbY7Mfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8qvhJY5i/x+yGhWdY1qD1YUVhKuFjNY+l5ROfitai5k=; b=KrxmYlOq8LaEibJeMq2+XqyY+UsEZp90CH11fNV/CnUGo8hFnFKNwatOAJWgLVinr1YikUgX5S9PoN/LFpg4o5pDMxt3UfltGTe+HllL3QGz9MxS7ox/E/YxDbQNLx113HBi1/5Zm5Y56FXENiKJExpUabcEfXeXMz2fH+X8UBRtEmB8HFgAGPd0VEMhkEIpmKRf8qx0yjE3WmauZhqyVk2Q5c8T9SeDOBO8pDX0xGgq6XCKWo+TVh7ND9RMly0LNgFyq6eRon272LsCWRWXZmDoUCoTzydOqcwJqLrRLaU+92R++Dudu4H17iWBDsR7ch441MQo34Z8AiQXoHmGUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8qvhJY5i/x+yGhWdY1qD1YUVhKuFjNY+l5ROfitai5k=; b=CuI/tuKIi0og0poTKHltDpxP2gv5fUud8Z0iGYJpYAxLVKZl6P4bNq1qoiGDj0R/yXcqWJzbOCWDdEpF4SuFUH5Jv199JM082Z2hv2JplSYLEXmGbzzsfDXjTXU5IR0K8oKIfEpJGYDkowF5Mc8bh14jjptnTpyaCELwdhLnVoE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:17 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:16 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 02/14] dmaengine: dw-edma: Add per-channel interrupt routing control Date: Fri, 17 Jul 2026 14:02:56 +0900 Message-ID: <20260717050308.2144108-3-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0027.jpnprd01.prod.outlook.com (2603:1096:405:2bf::11) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: 63ef543d-4631-41c1-53a4-08dee3c0b5e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|6133799003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: XsMsVZa2z1xgBBpepy8V75sOuLYvvwnM1AqNpounHOA0p7gIUW1bC+u3Z2ZFOlZGowFU/PiFTMwsC8rUyPKCYRLTS2F12sw3rHxADshVrHzBFPfTq+sUMblRLVGSuSByywewMBsVtSpR2/TY7dM9xYQ/zrqxiKHnaGwB3I48EKltvDypn0Or+1Ez6zpUXSXatF7CSwSqqIDXou8Hi39Q60fhiBAEDbGsaoOwlvVff9+hryesO4xUyJ2wLmYYhWasqqRkfIpWKDDbGcqmh9BBGQHsCU+F2sMzU8joogrLbTgNbr8imeZ+5GOGsmCk5U7YgE7Hl6qic8Ukf8i73z4H73eU4maa42Tgl7IivqbKuxpc1Bi/zazgizbCCM5brrS2q8/9FIQAEbzV9wpLFl+ov2MP1T6cJk/im2OxAZUbmgxwxfa9heS/Nd5u29r93j4JKr5tBSoGEgJ/GLi2hs42rCwLmUiqwY0gG41ae51Y9/1/Nlk1+9d5BT8un9BQav9T1pHIVMTo1COZnMccPbRWE92Qa3iPAVGiq3jhAp8IwTHT/KVYiynW1Ve7gb/5VT4Rz1pxIn6/mSEaiXkFiMh7NThayFrEfCLF5p92C1hm6d1dM97oAdv/xkilczjPcyaUv+e3QWNJvyBQt7DeE3MYDIJcvFG6XFPHj9DK+1h5q74= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(6133799003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mECjvAULE4cqB3euakQRDnljMuBwQtpu/HwhBRKS1eDz48shKX4D6zgYFtPI?= =?us-ascii?Q?8MTe4u4UAVryhsFAFQaOfFW8VBdvKEAJH0YJEH2IO4J72VZ9E0qbojY5F3qV?= =?us-ascii?Q?yR14iko97e8S5BSN6G1BAyH3iI5+qYMHQqA9dY1vsRQAcVkeOFDQHroRGSfF?= =?us-ascii?Q?jAxYU+vFqW9QPEqAy02VIW3c/vie2KyosAsVWT3RECP72zbkohcVZU9buwa2?= =?us-ascii?Q?kMLg787pJc94WCrgJQqKWLdijarnhGR8kYEuDYncdFW0cnchPCP6OOZKsvlK?= =?us-ascii?Q?38hEqlMmrB4ix3th0S8E4vXel7uviALLvxVBSE6JYkOSPSbg0e6m2uiWOGqP?= =?us-ascii?Q?sM/VLO/OGus+VZFifq0J9vl3Hy6hFSjMcdhxOYBLJtfKnT9JraWLx0IjR3+f?= =?us-ascii?Q?m9WpXxGiN2PSzF2uUqLpTa9Ze7g4WjBimYmPmMHJ5P/8zkzgiWqW8nVoF9N7?= =?us-ascii?Q?DXLzOolmik8IB5P5W+rcmFgT5V9xslmpki2FeDeLcUQO/yrRspjgYNRzxERZ?= =?us-ascii?Q?ghF11oPx6YvoDchGPWawNDa05GlmBdCDhv7rgGiz6++mT5qe6mDabBhJs+kD?= =?us-ascii?Q?cbfd/FHp2ZK2APcK667WqoKXlJgoL3nwPZX+aSEgjkDtsvuh/32zrkEicNVh?= =?us-ascii?Q?kHS6TuQ5AGL/GiqjHRoqlqdD7NOajqg3SUtj0JoCrm79xiDMgOcRzkMm8WBs?= =?us-ascii?Q?HzPWaTxMkEob7jccXGib8XFZaQr+yvxwXQBbLazCAP77E32KeCBYpQttdC77?= =?us-ascii?Q?l4Dq7sFDRPtht94n4iZE3Q693B9TdEXoMwuHHDGhtC9RZWSv2RV3xm4bRCRL?= =?us-ascii?Q?n6nkp+MCImzbULAggqZWe1xwSWI7Qr7QryUkCiSwCITrrCBHKNGqfksSBY2h?= =?us-ascii?Q?VoMCy+y+n4BPjJIkY+PxzBpeieM5cepiLdw/way/F01Plntpe8stBd3RaOAA?= =?us-ascii?Q?ntwP3p4aPhbYgMWRLN1IkWiYE7VvTzfcw30yld0aL2NU1MButPChX+zYDoCc?= =?us-ascii?Q?o/x4r9MAvosSAf5+/Kp7G6fz7S/MHLrtCteQ9MLeS9x7sRcSDP4dGTLTwo3H?= =?us-ascii?Q?HcmhfSALIaRUdXerz+fh7KNdIHgMQq3xlDKfWC/iab3qE/sJNcCMgfEFA+NC?= =?us-ascii?Q?wzNggfDGTa6qS93VoxFN9fsyYO7+iYCmZRdPWVbShsYq1E5daNbW8TcqBaQH?= =?us-ascii?Q?Z1iiQPNWDuStg7LLDl7Dl7fZoG+yN+uc3/r5wrhgmCVHCns3EiWMGM85mwCU?= =?us-ascii?Q?Tm28d63p2aRIy0si7m4F65UlUrKX3xmgVjQk67wzupJzn3dvzIcc785ZeweZ?= =?us-ascii?Q?qHeU1/Ytsj5iNfGww2PgRxulMmJMWEkIFciBGanX68xQ3H4eI+j1m5RvLEMk?= =?us-ascii?Q?W6bYMC+8JcdlIM/+LuF+hLJJ7APJMPKi95+Y0Neec5SLP8ZSUkVa8/jwMClG?= =?us-ascii?Q?uIhM8pz6DNl4vGphtIgKjI20Qke8iFcuVCWyolvz2ulrdofaMiPP3Vv9Pngf?= =?us-ascii?Q?zmHZRkoLu9OLTdhS1LUp05ApLX30aQ7+H3vNDcAQIZxRfvsoSeMO2heVweKg?= =?us-ascii?Q?SECwcTk6G/q9rVtW2GWDO1GlOmVw3/I9cVmmsV9cPgSKV9f/ts0wEUR/nDgq?= =?us-ascii?Q?6rvFBohojUtxmvSRUyoFUrWIqwNBsjmDBcccZ/ox+kmoscXCCVVzMv0l6sB9?= =?us-ascii?Q?qQ92zG8wYHpGPh7wkJMnXIRjTpefZRfjeNVCspCi27zAp3ySgsWHPwx+zNHs?= =?us-ascii?Q?CmPn4JtyBSKyjqcDXeX07geHZJePM/CAUsm8YG/7LWqfDXJAxDT0?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 63ef543d-4631-41c1-53a4-08dee3c0b5e0 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:15.9330 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oHgmk8Vw4EKAr77KEcXHHVlkd5VZKIfdXPNgTvsGlZFTjChtChB6xWLYXgloMLvQhuzPrseFK35u0YYHOhyMGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" DesignWare eDMA can signal completion locally through edma_int[] and remotely through IMWr/MSI. When channels are delegated to a remote frontend, the local endpoint side and the remote host side must not both service the same DONE/ABORT status. Add channel interrupt routing state and initialize it from the controller instance configuration. Update the eDMA and HDMA native paths so linked-list interrupt generation, HDMA non-linked-list interrupt enables, and DONE/ABORT masking follow the selected mode. For HDMA native non-linked-list channels, keep the local stop/abort enables set so status is latched. In remote mode, also enable remote signaling and mask the local interrupt pins. Keep the existing dw-edma-pcie host-side instances in remote interrupt routing mode so their IMWr/MSI completion model remains unchanged after local routing becomes the zero value. Note: - The routing mode describes where a channel should report completion. It does not by itself say whether this dw-edma instance owns the interrupt status. A local instance must ignore remote-only channels, and a remote instance must ignore local-only channels, even if such interrupts are unexpectedly delivered. Otherwise the non-owner side could steal the interrupt from the owner by clearing shared DONE/ABORT status. Cc: Devendra K Verma Suggested-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - Keep LSIE/LAIE set for STOP/ABORT status latching and mask the local interrupt pins in remote mode. Fix the v4 regression observed on HDMA 6.30a. drivers/dma/dw-edma/dw-edma-core.c | 10 +++++++++ drivers/dma/dw-edma/dw-edma-core.h | 13 +++++++++++ drivers/dma/dw-edma/dw-edma-v0-core.c | 30 +++++++++++++++++++++---- drivers/dma/dw-edma/dw-hdma-v0-core.c | 25 ++++++++++++++------- include/linux/dma/edma.h | 32 +++++++++++++++++++++++++++ 5 files changed, 98 insertions(+), 12 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index 30eeb7bffad8..8a1ec0fd057b 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -133,6 +133,15 @@ static void dw_edma_device_caps(struct dma_chan *dchan, } } =20 +static enum dw_edma_ch_irq_mode +dw_edma_get_default_irq_mode(struct dw_edma_chan *chan) +{ + struct dw_edma_chip *chip =3D chan->dw->chip; + + return chip->flags & DW_EDMA_CHIP_LOCAL ? DW_EDMA_CH_IRQ_LOCAL : + DW_EDMA_CH_IRQ_REMOTE; +} + static int dw_edma_device_config(struct dma_chan *dchan, struct dma_slave_config *config) { @@ -818,6 +827,7 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u3= 2 wr_alloc, u32 rd_alloc) chan->configured =3D false; chan->request =3D EDMA_REQ_NONE; chan->status =3D EDMA_ST_IDLE; + chan->irq_mode =3D dw_edma_get_default_irq_mode(chan); =20 if (chan->dir =3D=3D EDMA_DIR_WRITE) chan->ll_region =3D chip->ll_region_wr[chan->id]; diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-ed= ma-core.h index 3c958ca05144..90ca88f5443a 100644 --- a/drivers/dma/dw-edma/dw-edma-core.h +++ b/drivers/dma/dw-edma/dw-edma-core.h @@ -74,6 +74,8 @@ struct dw_edma_chan { =20 struct msi_msg msi; =20 + enum dw_edma_ch_irq_mode irq_mode; + enum dw_edma_request request; enum dw_edma_status status; u8 configured; @@ -247,4 +249,15 @@ dw_edma_core_db_offset(struct dw_edma *dw) return dw->core->db_offset(dw); } =20 +static inline bool +dw_edma_core_ch_ignore_irq(struct dw_edma_chan *chan) +{ + struct dw_edma *dw =3D chan->dw; + + if (dw->chip->flags & DW_EDMA_CHIP_LOCAL) + return chan->irq_mode =3D=3D DW_EDMA_CH_IRQ_REMOTE; + else + return chan->irq_mode =3D=3D DW_EDMA_CH_IRQ_LOCAL; +} + #endif /* _DW_EDMA_CORE_H */ diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw= -edma-v0-core.c index 7b4933c66f9f..9f4f8a93ed0e 100644 --- a/drivers/dma/dw-edma/dw-edma-v0-core.c +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c @@ -256,6 +256,9 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, = enum dw_edma_dir dir, for_each_set_bit(pos, &val, total) { chan =3D &dw->chan[pos + off]; =20 + if (unlikely(dw_edma_core_ch_ignore_irq(chan))) + continue; + dw_edma_v0_core_clear_done_int(chan); done(chan); =20 @@ -267,6 +270,9 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, = enum dw_edma_dir dir, for_each_set_bit(pos, &val, total) { chan =3D &dw->chan[pos + off]; =20 + if (unlikely(dw_edma_core_ch_ignore_irq(chan))) + continue; + dw_edma_v0_core_clear_abort_int(chan); abort(chan); =20 @@ -354,12 +360,17 @@ static void dw_edma_v0_core_ch_enable(struct dw_edma_= chan *chan) break; } } - /* Interrupt unmask - done, abort */ + /* Interrupt mask/unmask - done, abort */ raw_spin_lock_irqsave(&dw->lock, flags); =20 tmp =3D GET_RW_32(dw, chan->dir, int_mask); - tmp &=3D ~FIELD_PREP(EDMA_V0_DONE_INT_MASK, BIT(chan->id)); - tmp &=3D ~FIELD_PREP(EDMA_V0_ABORT_INT_MASK, BIT(chan->id)); + if (chan->irq_mode =3D=3D DW_EDMA_CH_IRQ_REMOTE) { + tmp |=3D FIELD_PREP(EDMA_V0_DONE_INT_MASK, BIT(chan->id)); + tmp |=3D FIELD_PREP(EDMA_V0_ABORT_INT_MASK, BIT(chan->id)); + } else { + tmp &=3D ~FIELD_PREP(EDMA_V0_DONE_INT_MASK, BIT(chan->id)); + tmp &=3D ~FIELD_PREP(EDMA_V0_ABORT_INT_MASK, BIT(chan->id)); + } SET_RW_32(dw, chan->dir, int_mask, tmp); /* Linked list error */ tmp =3D GET_RW_32(dw, chan->dir, linked_list_err_en); @@ -474,7 +485,18 @@ dw_edma_v0_core_ll_data(struct dw_edma_chan *chan, str= uct dw_edma_burst *burst, if (irq) { control |=3D DW_EDMA_V0_LIE; =20 - if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL)) + /* + * A local instance never issues transfers on a remote-routed + * channel: on CHIP_LOCAL instances, REMOTE routing denotes a + * channel handed over to the remote side, which programs the + * linked list through its own instance. The remote-only + * recipe (LIE|RIE with the local interrupt masked) is thus + * applied by the instance that owns the transfer, and the + * LIE-only write below never executes for a remote-routed + * channel. + */ + if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL) && + chan->irq_mode =3D=3D DW_EDMA_CH_IRQ_REMOTE) control |=3D DW_EDMA_V0_RIE; } =20 diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw= -hdma-v0-core.c index b455da3d9b0f..52f54e14544d 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -51,15 +51,22 @@ __dw_ch_regs(struct dw_edma *dw, enum dw_edma_dir dir, = u16 ch) =20 static u32 dw_hdma_v0_core_int_setup(struct dw_edma_chan *chan, u32 val) { - if (chan->non_ll) - val |=3D HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK; - else - val &=3D ~(HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK); + val &=3D ~(HDMA_V0_LOCAL_ABORT_INT_EN | HDMA_V0_REMOTE_ABORT_INT_EN | + HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_REMOTE_STOP_INT_EN | + HDMA_V0_ABORT_INT_MASK | HDMA_V0_STOP_INT_MASK); =20 - val |=3D HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; - if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL)) - val |=3D HDMA_V0_REMOTE_STOP_INT_EN | - HDMA_V0_REMOTE_ABORT_INT_EN; + /* + * HDMA_INT_STATUS.STOP and .ABORT are latched only when LSIE and + * LAIE are enabled. A remote handler needs those status bits to + * identify the source of the IMWr, so keep local generation enabled + * and mask the local interrupt pins instead. + */ + val |=3D HDMA_V0_LOCAL_ABORT_INT_EN | HDMA_V0_LOCAL_STOP_INT_EN; + + if (chan->irq_mode =3D=3D DW_EDMA_CH_IRQ_REMOTE) + val |=3D HDMA_V0_REMOTE_ABORT_INT_EN | + HDMA_V0_REMOTE_STOP_INT_EN | + HDMA_V0_ABORT_INT_MASK | HDMA_V0_STOP_INT_MASK; =20 return val; } @@ -147,6 +154,8 @@ dw_hdma_v0_core_handle_int(struct dw_edma_irq *dw_irq, = enum dw_edma_dir dir, =20 for_each_set_bit(pos, &mask, total) { chan =3D &dw->chan[pos + off]; + if (unlikely(dw_edma_core_ch_ignore_irq(chan))) + continue; =20 val =3D dw_hdma_v0_core_status_int(chan); if (FIELD_GET(HDMA_V0_STOP_INT_MASK, val)) { diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h index 1fafd5b0e315..d29a8df76f8c 100644 --- a/include/linux/dma/edma.h +++ b/include/linux/dma/edma.h @@ -60,6 +60,38 @@ enum dw_edma_chip_flags { DW_EDMA_CHIP_LOCAL =3D BIT(0), }; =20 +/** + * enum dw_edma_ch_irq_mode - per-channel interrupt routing control + * @DW_EDMA_CH_IRQ_LOCAL: local interrupt only (edma_int[]) + * @DW_EDMA_CH_IRQ_REMOTE: remote interrupt only (IMWr/MSI), without + * delivering local edma_int[]. + * + * DesignWare EP eDMA can signal interrupts locally through the edma_int[] + * bus, and remotely using posted memory writes (IMWr) that may be + * interpreted as MSI/MSI-X by the RC. + * + * For the v0 eDMA linked-list programming path, DMA_*_INT_MASK gates the = local + * edma_int[] assertion, while there is no dedicated per-channel mask for = IMWr + * generation. To request a remote-only interrupt, Synopsys recommends set= ting + * both LIE and RIE, and masking the local interrupt in DMA_*_INT_MASK. Se= e the + * DesignWare endpoint databook 6.30a, Linked List Mode interrupt handling + * ("Software Programming of an Endpoint's LIE and RIE Bits for Linked List + * Transfers", Attention). + * + * A local (DW_EDMA_CHIP_LOCAL) instance never issues transfers on a + * remote-routed channel: REMOTE routing on such an instance denotes a cha= nnel + * handed over to and driven by the remote side, and the recipe above is + * applied by the driving instance. + * + * HDMA linked-list watermark interrupts have the same LWIE/RWIE guidance.= HDMA + * non-linked-list mode has dedicated local and remote stop/abort interrupt + * enables. + */ +enum dw_edma_ch_irq_mode { + DW_EDMA_CH_IRQ_LOCAL =3D 0, + DW_EDMA_CH_IRQ_REMOTE, +}; + /** * struct dw_edma_chip - representation of DesignWare eDMA controller hard= ware * @dev: struct device of the eDMA controller --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11021140.outbound.protection.outlook.com [40.107.74.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B67431E83A; Fri, 17 Jul 2026 05:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.140 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264605; cv=fail; b=CoSTxnIeE9oJEyLVKMuCai6p3Dh5ynBJ9EF5UHCvDrx1qlv1qO3W7uhlVQgyQB1TgmfhoQoNBYqCY3teOKbGrQZqHIO1rq8AQjyg4dsA8PQpMNz2AE0K0RY4k3om1HNnWKVH2/ZW1/P76fJ650WW9a4HYI0Wc6Fgmq9MmEEqRC8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264605; c=relaxed/simple; bh=u0xxV0yX3DmibFuVOo5zOq0lKgdfKfTnw8+MFb6K7BU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=AgIrjP/krdSx0k1alQ//HKwAAYTuVEJN23HCle5NkVcvK/80622zoBxpZYMpSACr1Y5TEBCa04DF10WVCH3S0AvQ615deiwHOr8YeqqklTdTJKk6O8TF83yowVSGm4WkNh1UOL1UdDVjqYz4EPpvWhWGZ+UOjAOvkOmdfNQ35uo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=FJezNMPn; arc=fail smtp.client-ip=40.107.74.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="FJezNMPn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RnACUNcvp3851/QBuV2OaS0ddq23hEdPGQrZ6l19C3U0BWVyhIXFAHg4KuTgl/byQ8AJ0nSyARHlLkcse4x/kKTBhMTfcoasVFmGK2dkMFLDpH9j1UcFt0YQ+81vgRIvT+B3OHvgw0JwlK6TAmObuOhgp+0ul+4UrLO5FXapQIonUnvxzwpRgKlll3wlnwSuwgcZm90LV+bwD/yqYpbaF5/cedxIV2l89vbe965xSQXr6pQzCMINmZsabtOYfMAB2CCTniSvAd+L3CrN6S1lEtodZaaGWZv/oe0vA2RLS83isYHge5JYJRk6Rs/wXyYEIGmgGuzSjbvqxRud5++8ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uyxrHfVEczde0s3qkIlRnqKJP4JzErtViedYYUYBg0g=; b=SZgANgYYqhseK6l4y04OmLzTOY4FZXKtQdfRaPfgLmm8ej0ct2oUqs9oybiROe6owxlW1WkD5dwfuPaoB0ZZwms6+6lvhGodRCoEvPkFeOzrNnrVZp3Bt1U9R87sYLhCkH1jiVQQXitESnysrCZxbQ7G7A6dptqPKa0jn3Lxov0sufILRz/tpnutWQl4rrIaTqYQI7uqfCb2ATTFx5MGbtPWv+9JSzdGTuOQB7InQIYkYJXgS09cH1qD6grH+jGpW30GFq/X96M5dpvr88N2CmPTTRkTi16shuN03b0D8PEDCFMyMzCY4AbKqC4QOlfQhUU+dvyAIG3T3OsJ9b6v5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uyxrHfVEczde0s3qkIlRnqKJP4JzErtViedYYUYBg0g=; b=FJezNMPnOJRAA2jQsfn8S773z3tLEgGfvqa0BBwW1sAQts6RVqmCfa59TfztVhRm9ni4LbCM/jRp6aVM05ZBkkJcpV5KRh8ylSee3MWeCUVm8nWCGWbuQT1HzQlsFnR5yp++j0WgvMkF6LFs47po+vVtc7jr2PjTNUXN7rEf9dM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:17 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:17 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 03/14] dmaengine: dw-edma: Add core quiesce operations Date: Fri, 17 Jul 2026 14:02:57 +0900 Message-ID: <20260717050308.2144108-4-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0321.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3b7::14) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: 21cf205e-950e-46cd-7e12-08dee3c0b68b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|6133799003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 3PMzdFSrMaRWEKLR0gVVYuax+82qZZj/CkU/0rG4LSDkz5W4lcpsRp4uD8OyO59dFVk13xh6xc5BhhPyqeHQ7ENbhP9zJb8PAyQA67MjI2erbL9deXlZYtQ+jgxos9Kv8i6K4qpWrFsrdl4DJE+FBsRiMa0l9c5WgvTkFarLd24UTDTqUdjUoWXrr00N+UT/VX0geB2Z9AvC9ZV0qHvxGqEILmpYA7fEbwxmuF7SywKTnzK6S9FXIGndib0eRkH6oD5BG0cpg49aQgC8I4cgiu+dq8Hv6GEkJZdSKdTTveJ0SMMkMkiTap1TRZ+M0YKdXKT0VTcSO21HZMMGGaQiHS4r+8z1MR8mN1kl9lqQzsHA7BDITSokUApG8M6+19BLgRLpIWCHrT9Ku7gGKvPhkg/6q4G8meWQRXWILP9rB4vmkd2SMTN1B6sLtbdijfimJbDVSXCJ3gR8R8DHOGLyclYfyINJbQvNCGxmP4fbYSUPaKl2Evyfqt6KT+FgiPuR3bDbnmK/lq8/CXHaVdIg2FtRJQC9OMu2dwwKjgJU+vY4j4sVYwAFHReoGCihcm4zhDdDqqLd1lMbSduqf1svLx9DROUztQCU1de+uzOKNBgx2n+uPbsI3zmhnSgWXnN2R8908IVAGr0mMWMAMX3Uq5Rjoo/7GyWrAPuL4P4l2cY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(6133799003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SgAjyddlfmNGN+uEUbHzFEAi3KTuXwA2vetosajceWAu+ik3lXFX9rvpVewh?= =?us-ascii?Q?j6Il2fc4ZaMWejqNJKR0F5sMtWIJC3YrhYpTtchRDuLnvxViGKBp2Zh8oEU7?= =?us-ascii?Q?LIdy+25NqQUzt4Oah2qPX7162AmvcEDH16/TbPYVrmBFOsFu1KEVBCFik6eW?= =?us-ascii?Q?owzXIzSamgtcXC11g+pRRnP4vJZyBNJeB/5qcVAPSxlyG2WxnW1qwbJpVy0U?= =?us-ascii?Q?aznhpXX1zOGoAIp5ltBhgPR4OfpeNRkJ9J47SVxxV8mXAMCG3JXJ9OqNZnhq?= =?us-ascii?Q?GTrgpc4caej8VuPylGHZTdUrPPumInu0nNapVfEWUVYNvUTmx36N0wIgl6On?= =?us-ascii?Q?2MsDwbJ/ScQ6b8sWFIi8M41g/X5BgZamz8gYi3wFWvfMJVN2Ht2KfHI/c3Or?= =?us-ascii?Q?qM66vv94d2IfcEN0yUseI6awIIdfxC4hO3DxFB/PhX0MKTd+pV/W+BoD3cTO?= =?us-ascii?Q?Hys3T+8W/BgUq8XmpuozjLbYjlQ6Iimxp1pcwuZeu4aSONUOoDVTf18xMXwP?= =?us-ascii?Q?/Js2LS54qXpYrn/g2hlucZW3XJ8WqEKYYH+Jdnn1uMYgJKweVoCZJoD29Of1?= =?us-ascii?Q?x2A2bpOiuPcFdCkt5XBRR0I5OcwwpfDr3361NPO0MNUqs8r5KwRYFA+HKanc?= =?us-ascii?Q?/FGuKXZirwYsazxyvO6pVtHGrbvfQBs8lb5dM9ZcoZfraiUfjb2RHgCxEyAF?= =?us-ascii?Q?PxMyNcoscaJnHJplvxuCIPQTm0XLSgkd9Ri2JhHmxbGd206uhhMkqxsr/hpT?= =?us-ascii?Q?Dso+Va92lRtnRqcsuN/FC8TqWOfeqCEkc/hKmkv/1VEPgeM6cfPuSg8YvisF?= =?us-ascii?Q?llIFkxl9R+KBkggdHsDbkfmH9A8+WI0pxvr/Kdz7E10MtjEPZdQjHcHjFwle?= =?us-ascii?Q?2elR5mwlFloRjyoAlFnt+P36C4K1UpXIcJknwHwUvFIpf7RF0HUL7JKU/QYd?= =?us-ascii?Q?YZwYi6W3pGss4haPLVcVo39RLGK5U2dfrhB0+iyZjMWS6/1L7+6jlfBwRTx6?= =?us-ascii?Q?20ODn6a720RuJjVZHqbKcx6RCshWjuZJ8Xp/R7ZDze/JcWkkH185C7HcHLUa?= =?us-ascii?Q?h5ngmbnYkOZInDO8aKWWhuMoSpmp5HDNv3U0W4Y2vjDe83KIicLI58DS3tQG?= =?us-ascii?Q?qqPDvdFRQN9FsItzZiBtYC3QEddeM3FIBNEGlytG0bmrquFvuYWw7Vec9qdi?= =?us-ascii?Q?5AmGiXH1CqacEfovng6tvwkgqekvGCX/5h8JdnGoyRJJ1Svr7aZm9oKnC0WK?= =?us-ascii?Q?c1HjmMo3BbnMXQH3+eobCbV7z26dcmbZwE8ZnOx8DV0iQPEll79O04uOInDO?= =?us-ascii?Q?TMYv2eBTKNlHAC4dRvN+zKABBN3Fp0ha2MgsNP6qolLSQxKNfXkJB7HDS8rz?= =?us-ascii?Q?RMfqFKuKLICf5j7S/DsSXZxunzVn9+5hY7p5nhTmpN2UQJFoHcSFIFRe6lBf?= =?us-ascii?Q?Y2A+zkWDiIOiYaaHff3WyN1uMe4DhwoPfR0T2Lel+u/IW6dYYmkeis0cKcJR?= =?us-ascii?Q?leVEPLKL/oozBXbF7KbSOqOJHjxpvARYtyrqpxcLjqX3CtLsuZFR55NUmek+?= =?us-ascii?Q?SMTNv2lQOwnwlgZp/IKJDNFZh3+jV1Es1c2U/D6cVXmIcSEM6KJYpu7Qqz2+?= =?us-ascii?Q?MmExE7k4LZi0OJCdBN7D3d5QhQ9vC2ulLF4WSfj+b6ICQoDcqYJUoM261yQM?= =?us-ascii?Q?neF61Vuz528ulkVXUOEBew+5wSSr4Hxr/MXH5xyIiXPUHR1iZCSQluNEalCq?= =?us-ascii?Q?Kt/oE2irc404xIPR2ZLAwoqvTDyummY4Bbe5esqoYbaqva1ifCX0?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 21cf205e-950e-46cd-7e12-08dee3c0b68b X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:16.9798 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FJD1yqJBXjV6QzCBVTqg5ak+mN12fXbelM3uaFIftfpy4sblolSEnpzDZpPRzwEMp++HKoFQrA4kt2fWP+4qFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" Add core operations that quiesce only the resources represented by a dw-edma instance, separate from the existing full controller off path. For unrolled eDMA, quiesce masks the direction, disables ENGINE_EN, waits for it to read back clear, then clears pending interrupt status. If ENGINE_EN does not clear, return the timeout to the caller. HDMA compatibility mode does not implement ENGINE_EN, so quiesce clears CHi_PWR_EN for each represented channel instead. Both register maps share interrupt control per direction, so quiescing one channel quiesces the whole direction. Callers must own that direction and stop the peer from programming it first. HDMA native has per-channel registers and can quiesce the represented channel directly. No caller is added yet, so this is a no-functional-change preparation for delegated channel reclaim and partial-owned remove paths. Signed-off-by: Koichiro Den --- Changes in v5: - Propagate detected quiesce failures to callers. - Wait for ENGINE_EN to clear when quiescing unrolled eDMA. - Use CHi_PWR_EN because HDMA compatibility mode does not implement ENGINE_EN, as documented in the 6.10a-lca06 databook. - Clarify the full-direction ownership contract and register-map names. - Use scoped_guard() for new code. - Drop Frank's Reviewed-by tag due to these changes. drivers/dma/dw-edma/dw-edma-core.h | 14 +++ drivers/dma/dw-edma/dw-edma-v0-core.c | 141 +++++++++++++++++++++----- drivers/dma/dw-edma/dw-hdma-v0-core.c | 31 ++++++ 3 files changed, 158 insertions(+), 28 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-ed= ma-core.h index 90ca88f5443a..1a9f1b58d2fd 100644 --- a/drivers/dma/dw-edma/dw-edma-core.h +++ b/drivers/dma/dw-edma/dw-edma-core.h @@ -115,6 +115,8 @@ typedef void (*dw_edma_handler_t)(struct dw_edma_chan *= ); =20 struct dw_edma_core_ops { void (*off)(struct dw_edma *dw); + int (*quiesce)(struct dw_edma *dw); + int (*ch_quiesce)(struct dw_edma_chan *chan); u16 (*ch_count)(struct dw_edma *dw, enum dw_edma_dir dir); enum dma_status (*ch_status)(struct dw_edma_chan *chan); irqreturn_t (*handle_int)(struct dw_edma_irq *dw_irq, enum dw_edma_dir di= r, @@ -180,6 +182,18 @@ void dw_edma_core_off(struct dw_edma *dw) dw->core->off(dw); } =20 +static inline +int dw_edma_core_quiesce(struct dw_edma *dw) +{ + return dw->core->quiesce(dw); +} + +static inline +int dw_edma_core_ch_quiesce(struct dw_edma_chan *chan) +{ + return chan->dw->core->ch_quiesce(chan); +} + static inline u16 dw_edma_core_ch_count(struct dw_edma *dw, enum dw_edma_dir dir) { diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw= -edma-v0-core.c index 9f4f8a93ed0e..3e9512a7b201 100644 --- a/drivers/dma/dw-edma/dw-edma-v0-core.c +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c @@ -7,6 +7,7 @@ */ =20 #include +#include #include #include =20 @@ -160,6 +161,87 @@ static inline u32 readl_ch(struct dw_edma *dw, enum dw= _edma_dir dir, u16 ch, readl_ch(dw, dir, ch, &(__dw_ch_regs(dw, dir, ch)->name)) =20 /* eDMA management callbacks */ +static void dw_edma_v0_core_ch_power(struct dw_edma *dw, + enum dw_edma_dir dir, u16 id, bool enable) +{ + u32 value =3D enable ? BIT(0) : 0; + + if (WARN_ON_ONCE(id >=3D EDMA_V0_MAX_NR_CH)) + return; + + switch (id) { + case 0: + SET_RW_COMPAT(dw, dir, ch0_pwr_en, value); + break; + case 1: + SET_RW_COMPAT(dw, dir, ch1_pwr_en, value); + break; + case 2: + SET_RW_COMPAT(dw, dir, ch2_pwr_en, value); + break; + case 3: + SET_RW_COMPAT(dw, dir, ch3_pwr_en, value); + break; + case 4: + SET_RW_COMPAT(dw, dir, ch4_pwr_en, value); + break; + case 5: + SET_RW_COMPAT(dw, dir, ch5_pwr_en, value); + break; + case 6: + SET_RW_COMPAT(dw, dir, ch6_pwr_en, value); + break; + case 7: + SET_RW_COMPAT(dw, dir, ch7_pwr_en, value); + break; + } +} + +static int dw_edma_v0_core_engine_disable(struct dw_edma *dw, + enum dw_edma_dir dir) +{ + u32 value; + int ret; + + SET_RW_32(dw, dir, engine_en, 0); + ret =3D read_poll_timeout(GET_RW_32, value, !(value & BIT(0)), 100, + 200000, false, dw, dir, engine_en); + if (ret) + dev_warn(dw->chip->dev, "%s engine did not stop within 200ms\n", + dir =3D=3D EDMA_DIR_WRITE ? "write" : "read"); + + return ret; +} + +static int dw_edma_v0_core_dir_off(struct dw_edma *dw, enum dw_edma_dir di= r) +{ + u16 count, id; + int ret =3D 0; + + scoped_guard(raw_spinlock_irqsave, &dw->lock) + SET_RW_32(dw, dir, int_mask, + EDMA_V0_DONE_INT_MASK | EDMA_V0_ABORT_INT_MASK); + + if (dw->chip->mf =3D=3D EDMA_MF_HDMA_COMPAT) { + /* + * DWC PCIe Controller Databook 6.10a-lca06, "Legacy DMA + * and HDMA Software Compatibility": HDMA compatibility mode + * does not implement ENGINE_EN, but retains CHi_PWR_EN for + * per-channel enable and disable. + */ + count =3D dir =3D=3D EDMA_DIR_WRITE ? dw->wr_ch_cnt : dw->rd_ch_cnt; + for (id =3D 0; id < count; id++) + dw_edma_v0_core_ch_power(dw, dir, id, false); + } else { + ret =3D dw_edma_v0_core_engine_disable(dw, dir); + } + + SET_RW_32(dw, dir, int_clear, + EDMA_V0_DONE_INT_MASK | EDMA_V0_ABORT_INT_MASK); + + return ret; +} + static void dw_edma_v0_core_off(struct dw_edma *dw) { SET_BOTH_32(dw, int_mask, @@ -169,6 +251,33 @@ static void dw_edma_v0_core_off(struct dw_edma *dw) SET_BOTH_32(dw, engine_en, 0); } =20 +static int dw_edma_v0_core_quiesce(struct dw_edma *dw) +{ + int ret =3D 0; + int err; + + if (dw->wr_ch_cnt) + ret =3D dw_edma_v0_core_dir_off(dw, EDMA_DIR_WRITE); + if (dw->rd_ch_cnt) { + err =3D dw_edma_v0_core_dir_off(dw, EDMA_DIR_READ); + if (!ret) + ret =3D err; + } + + return ret; +} + +/* + * The unrolled eDMA and HDMA compatibility register maps share interrupt + * control per direction, so the whole direction is quiesced. Callers must + * own the direction entirely and prevent the peer from programming it aft= er + * this point. Partial ownership mode validates direction granularity. + */ +static int dw_edma_v0_core_ch_quiesce(struct dw_edma_chan *chan) +{ + return dw_edma_v0_core_dir_off(chan->dw, chan->dir); +} + static u16 dw_edma_v0_core_ch_count(struct dw_edma *dw, enum dw_edma_dir d= ir) { u32 num_ch; @@ -332,34 +441,8 @@ static void dw_edma_v0_core_ch_enable(struct dw_edma_c= han *chan) =20 /* Enable engine */ SET_RW_32(dw, chan->dir, engine_en, BIT(0)); - if (dw->chip->mf =3D=3D EDMA_MF_HDMA_COMPAT) { - switch (chan->id) { - case 0: - SET_RW_COMPAT(dw, chan->dir, ch0_pwr_en, BIT(0)); - break; - case 1: - SET_RW_COMPAT(dw, chan->dir, ch1_pwr_en, BIT(0)); - break; - case 2: - SET_RW_COMPAT(dw, chan->dir, ch2_pwr_en, BIT(0)); - break; - case 3: - SET_RW_COMPAT(dw, chan->dir, ch3_pwr_en, BIT(0)); - break; - case 4: - SET_RW_COMPAT(dw, chan->dir, ch4_pwr_en, BIT(0)); - break; - case 5: - SET_RW_COMPAT(dw, chan->dir, ch5_pwr_en, BIT(0)); - break; - case 6: - SET_RW_COMPAT(dw, chan->dir, ch6_pwr_en, BIT(0)); - break; - case 7: - SET_RW_COMPAT(dw, chan->dir, ch7_pwr_en, BIT(0)); - break; - } - } + if (dw->chip->mf =3D=3D EDMA_MF_HDMA_COMPAT) + dw_edma_v0_core_ch_power(dw, chan->dir, chan->id, true); /* Interrupt mask/unmask - done, abort */ raw_spin_lock_irqsave(&dw->lock, flags); =20 @@ -553,6 +636,8 @@ static resource_size_t dw_edma_v0_core_db_offset(struct= dw_edma *dw) =20 static const struct dw_edma_core_ops dw_edma_v0_core =3D { .off =3D dw_edma_v0_core_off, + .quiesce =3D dw_edma_v0_core_quiesce, + .ch_quiesce =3D dw_edma_v0_core_ch_quiesce, .ch_count =3D dw_edma_v0_core_ch_count, .ch_status =3D dw_edma_v0_core_ch_status, .handle_int =3D dw_edma_v0_core_handle_int, diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw= -hdma-v0-core.c index 52f54e14544d..77260c076cd3 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -72,6 +72,16 @@ static u32 dw_hdma_v0_core_int_setup(struct dw_edma_chan= *chan, u32 val) } =20 /* HDMA management callbacks */ +static void dw_hdma_v0_core_ch_off(struct dw_edma *dw, enum dw_edma_dir di= r, + u16 id) +{ + SET_CH_32(dw, dir, id, int_setup, + HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK); + SET_CH_32(dw, dir, id, ch_en, 0); + SET_CH_32(dw, dir, id, int_clear, + HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK); +} + static void dw_hdma_v0_core_off(struct dw_edma *dw) { int id; @@ -85,6 +95,25 @@ static void dw_hdma_v0_core_off(struct dw_edma *dw) } } =20 +static int dw_hdma_v0_core_quiesce(struct dw_edma *dw) +{ + int id; + + for (id =3D 0; id < dw->wr_ch_cnt; id++) + dw_hdma_v0_core_ch_off(dw, EDMA_DIR_WRITE, id); + for (id =3D 0; id < dw->rd_ch_cnt; id++) + dw_hdma_v0_core_ch_off(dw, EDMA_DIR_READ, id); + + return 0; +} + +static int dw_hdma_v0_core_ch_quiesce(struct dw_edma_chan *chan) +{ + dw_hdma_v0_core_ch_off(chan->dw, chan->dir, chan->id); + + return 0; +} + static u16 dw_hdma_v0_core_ch_count(struct dw_edma *dw, enum dw_edma_dir d= ir) { /* @@ -355,6 +384,8 @@ static resource_size_t dw_hdma_v0_core_db_offset(struct= dw_edma *dw) =20 static const struct dw_edma_core_ops dw_hdma_v0_core =3D { .off =3D dw_hdma_v0_core_off, + .quiesce =3D dw_hdma_v0_core_quiesce, + .ch_quiesce =3D dw_hdma_v0_core_ch_quiesce, .ch_count =3D dw_hdma_v0_core_ch_count, .ch_status =3D dw_hdma_v0_core_ch_status, .handle_int =3D dw_hdma_v0_core_handle_int, --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11021140.outbound.protection.outlook.com [40.107.74.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76965370D4F; Fri, 17 Jul 2026 05:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.140 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264612; cv=fail; b=pW6asynK06X9dsJe5hLpOCKmeDM7pit0VlFSiWEVNk7oJXIqcmUsfERmFTaMdy/8mov49Kcdmu/WBuGzADh1K0arNTcqCPUIjr7AtPUT8rBy2IIYPHFcIbYpHwvDRmsUREizMEpCTy1dQ6HtMR9EyHiOaJQRTdxAW6wuuLlqxg4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264612; c=relaxed/simple; bh=VzcX4h84Vk/WKYqVAvaOLSSRny95VN+H5FRjMH01jkI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=NZbPxHdLGjHVTisTiT+f66NxN5Pkhb6OlAZgJb6P0fqCri7UwNHBRx3tTce0qvqrmOheReuHFAPmllFwhQTK5Lnv3FDhagLQyp90+EWk+N3Dgd2WWL6xq/5UTjJ0fS9LnWKQsxt+UByDprrPpSWz6CGPVlgUbCuI+qFjd8rYn/E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=lRTR/lRU; arc=fail smtp.client-ip=40.107.74.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="lRTR/lRU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c+pEOuP++f1fXaI/HiSkDpn5SWJindykHJU/qwBtamtfwSnZ7/caXIN9yz/OWDC2TznPQgK+9jEZKSglwTgEEcqFU/bcUgd+hsVV32rRP3hqJBpvCHbCstMSVcw8wUDnEn25okzbfHUxXhr/2r+JwfUkrAw0R51F3iH/PKxAuQ8fygr4BXyVlkrkn/LUgsIF8Qtx19+gTnadRUgNdh/7m/xvR5m4can9mrbuEIcR579nIUAjgTpj0Ky7g6oFtg3I3uSrr3pCfpQ6eE+wp4I9F6DoLWC7GmW2XFFxlaCtS7R+xmw9KsSXUpkhxQfy29zKIBG2K7VPE4Mh7JQwMsU8hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XOdLsWvqrYrA4y9EPOfHJqf/m8ALuyBSKXSHq+olpLg=; b=VifrvTD5vUBlAajIhzCE28GPFjv2j4TIH2Sz+TsFDsWSGMVxiMYflEbFg7NsVN2yrIUPuB6KJDN2dthvBa+iAJT65jNabeoWYUx7CQxxUmpiTTTbFLioYTt8EvRsrl7KyNwXm24EXL3wtSSH67+t9ZfR4LnILMg0Lx3ZKih4Q9GdDFRlElU0yoUeL7PW1pSrT+NqE1UhML0CidrntQEI2tn9gxMdhO/lCEU0WSjjoyrLC5hFiazD+kOjUIfgvOrQBfP6vfpAmQO1WOBoT6IASVB092TVsHAKKYG4gDzrKixpZ1Bo6VRxm064zEUxF2tkapa7mbxRYhu3Stk8e5MCSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XOdLsWvqrYrA4y9EPOfHJqf/m8ALuyBSKXSHq+olpLg=; b=lRTR/lRUy95ofKv6bYYOFOcxrJ9/XHeEd1Pg3c3F0N6nQc7NZf5eeLAg8if3iiobOL7h4TLoUY0U/RU4ZVgnLpVLZL82Plw/c78FQNXNHMeRlaAr2vDmbZEDNB0a2HlBlfrNPOYVS0DQfnImmKTxlwyPvWwSlQtJy1ehZsuF52c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:18 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:18 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 04/14] dmaengine: dw-edma: Initialize IRQ data before requesting IRQs Date: Fri, 17 Jul 2026 14:02:58 +0900 Message-ID: <20260717050308.2144108-5-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0055.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b5::10) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: 138f6ea5-eb42-4860-9794-08dee3c0b738 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: R13XGK60YuteFrNOj6Tlxe7pWp/060pA/llJhd3HNjywUHjr4n6W1Fmvpnmoxfy4ruPIaRosHlPrNilC0tJ2246i1ro/iWR8SJuHcMdLorkF2Su5olWK3EM+Am/wOA/A9r9jTfDxcDWk3+LHgvCQvRw3cJy+2laI3BF826oyGjiaCcfnJYGymduETzipkrWu+7ziVM2eeZz2zFSZfMZOBH7wX7BHAAAu9+6Ar0uq44VpGKAVe33QFTbY63BY84apfIwgZBVMkqqkPCVMAuBbLXnJG5mR0SDPGjro8qM+RGzx0Q0sRxPP0l7ZXvXYtMlEXfUP1mPuxJSOjF4oxOyN2w5qKUOSnkTZiW1WPnoVTUOSWnnqDrh65pJNodBdoolbnzOgEo42WMMh2e0/SV9XShPexh7xonYGi1dsUWVhlH4kE1x0rzR1FfaGivGgtqlmzhCp3LR9gUx2gsDXRlZIYrllsczrBIKJr2bDApn1kaosaQR+nsuX2DmJacSV1PMPFS8JSA+J37rGv4DbpHqwRMq6qk0ruu2vV+uoTY4fUEVUxNoFovPfMkpMP+vi2RWFartYyb8+8au3edvXuJzxwllC+8FxHmj6loZPuoQcDOGpWiY78LvSfZnD9x3UnFEJDOrp8EEs8A6iP4ZxkKvyHYrtkJNE+gvjsjQMTToDooc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ShD2tjQ5fkksXQLg5jzKNeOwANZTwTarjrZmgjHVRctU6bdWjXCvgbnpKz8B?= =?us-ascii?Q?7+EOztd8LEvN2rJO6zECBmAzAIP4sso29rYUDBXq7XOTcAa3YzNfZqYkh+KQ?= =?us-ascii?Q?oGoEpuXQZjqzKRVMqgrn30p+nuWxpRTDyJWkH8rlhpTWxFtUSCgtOQ4WOZDF?= =?us-ascii?Q?0KEg/p2wy+HoyIX+3C2xgBY4JUdyCynvvGZLmVRXDb+FltBo36ENRTdpQirf?= =?us-ascii?Q?7z6MrzLaBmM9aMzNSqoBvryzht3vDaN4YTcAE/+Bre5NxUO032euxctwJDls?= =?us-ascii?Q?AykoTiHb2rGX7GrST21/iaf8F3zQrBE8LHLgJPQPCvlhim2GzQJdMaalBS+G?= =?us-ascii?Q?4qXDJcMeXVxKEKW/ekZsZwY6tndlefDqZnvgk3iiMZjmQ1339ww2kjp7URC1?= =?us-ascii?Q?QXQl5wOznpq4RWoVTVFAStdmAbhQ6n2/9npSUuOcRbxhA4vPU0HrOG60ulyw?= =?us-ascii?Q?MeNPwFt/jIiIHiNLIL68vtgSwdvUtF94qGKhuw2cHlU9zOMqZgerSyf7DWo+?= =?us-ascii?Q?kXqy+tQr9spqTTrpFfVYQlpwdU8uIcpaG6IVM7Ih9r7WqtEbgYq8kdb36aux?= =?us-ascii?Q?KdvXioF792rS3CJHG+VPxxGCb55WJHKu61zz4Uc8u/sl4AR2meM9KLVHl8Y/?= =?us-ascii?Q?b2wag889gTwEXsq/rjGsYNA+OKQza2pkIwkiuPk1WjpFBoHUw6t+oE+fQvlI?= =?us-ascii?Q?jibieZrGEuNFFSpWXb7vzltecViURMrMoNrgsI3eCLE1RnE58penjXKCQHgz?= =?us-ascii?Q?Mf8/F1TLHCDrk6npWB7prsmMr+jp/XAKDyRb6A002LOX+qffPdFU/LNy8eFy?= =?us-ascii?Q?uMJb7tDlJQhYkC/+JBhviV6REUkphOjMFqzG7o3gLoDiGw7y6zzFLkwnQHxx?= =?us-ascii?Q?6tFPmzJ0yl5xRFoyAkI48C+p+efIJQvK5PUCH1UqkYxj0JT5FNToXBeuOjAP?= =?us-ascii?Q?j154cmDr/hLGhr9TBQ8r7VHiDJoYJlJk/6ikMIpnnWT3gkba+vd8IsZSbpT+?= =?us-ascii?Q?IbkDaf915f9yjLDsm71EtXk3NdHvw7W1GteIDr5o1aAPnOSbz0fs43tEPK3G?= =?us-ascii?Q?eYvDeVMdEAAboZ5KjYOwwkfWRTpjsGyaDNJGFJsaGbh6rWb9FPKMBBrW2UDu?= =?us-ascii?Q?StAjNVshFFZ7CiwzYnsu7m1Ess4B9dm2WzY1TOPJLcTYtqWdrpCkRgAFL5Iv?= =?us-ascii?Q?AyDiMUDy1P7mDGZ35DsThWX3Ng5sF09aVNp9dncjIqh5s8Q8TKakwdltuyip?= =?us-ascii?Q?0Eq+54mWZ7OFJrvqZS3fhwujmY7TNkAeGn+KQsUdu+Nqy2KbnANu/8xcDCIx?= =?us-ascii?Q?KlI20xZAFGJ7pTfSktBGYKe7WpkdHkUBSqSMBml18Q5gF8Pcs3TzipbMcMUc?= =?us-ascii?Q?zfNpUp4rlQzua4xLluYzbxd31H9qMptAakLdT3i++CFUrtg5y2FhMavwaV2R?= =?us-ascii?Q?cBTgD8PwCKJ5sPLXMCScjdiwGnZPF9953PXvV5aG9dblsjldfRMzUN3JRpRn?= =?us-ascii?Q?j6+aiyKrxOyI7ATniJ+KEr6zSe2sXdwMTWy6+SnDHaDdMPubaOglE1wU7Q1B?= =?us-ascii?Q?yM35FpURwp1DoGn7Tyr8Lh2B3i3QUgC2sGdNog/2eQpyUkPSz0YTmn3+WJqb?= =?us-ascii?Q?OnZf/FFtvv3W0rgIxUYHhXuZUH6tpqddg3Ra7yWbJvgubNSlGzOv+GAGOmhO?= =?us-ascii?Q?pFAfu9visZjw73CoJng12mfFgvQt8eTfuDPXdbYEyK+xMqN+8KdL+FvU9peO?= =?us-ascii?Q?1n6Nbx84uLGMtF4nvM0dkFnrmZwayoWv2V4H2mYknz4wPNUntPM8?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 138f6ea5-eb42-4860-9794-08dee3c0b738 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:18.1245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nGVIbkSR/VCQIaCcakCdS/5ncmtVWzEqH1rxfA5NA224dle3Ib3LOEmUUNFguY3WQRKlQqiOhgWGCUtTV2bCvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" dw_edma_irq_request() passes struct dw_edma_irq to request_irq() before dw_edma_channel_setup() fills the back pointer. A shared interrupt can therefore enter the handler with dw_irq->dw still NULL, leading to a NULL pointer dereference. Set the back pointer before installing each handler. Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver") Cc: stable@vger.kernel.org Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - No changes. drivers/dma/dw-edma/dw-edma-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index 8a1ec0fd057b..392981f3b7bb 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -854,7 +854,6 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u3= 2 wr_alloc, u32 rd_alloc) else irq->rd_mask |=3D BIT(chan->id); =20 - irq->dw =3D dw; memcpy(&chan->msi, &irq->msi, sizeof(chan->msi)); =20 dev_vdbg(dev, "MSI:\t\tChannel %s[%u] addr=3D0x%.8x%.8x, data=3D0x%.8x\n= ", @@ -935,6 +934,7 @@ static int dw_edma_irq_request(struct dw_edma *dw, if (chip->nr_irqs =3D=3D 1) { /* Common IRQ shared among all channels */ irq =3D chip->ops->irq_vector(dev, 0); + dw->irq[0].dw =3D dw; err =3D request_irq(irq, dw_edma_interrupt_common, IRQF_SHARED, dw->name, &dw->irq[0]); if (err) { @@ -957,6 +957,7 @@ static int dw_edma_irq_request(struct dw_edma *dw, =20 for (i =3D 0; i < (*wr_alloc + *rd_alloc); i++) { irq =3D chip->ops->irq_vector(dev, i); + dw->irq[i].dw =3D dw; err =3D request_irq(irq, i < *wr_alloc ? dw_edma_interrupt_write : --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020109.outbound.protection.outlook.com [52.101.229.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E33E232AABC; Fri, 17 Jul 2026 05:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264611; cv=fail; b=g814/T1wAq8/pzHaoanB2vgvkrWz8cnnWMGB9spiP1jGBqXAAamDll2ghFkeS2uWRW7APz77+uXlPaNlW/sVDIEVZ2hySTv84Sv8JiYXmn2ihVfyIe8hCnCtufwjv9hPOxJg5VHb4Oq35vuQfurNYmf5xG+uZpnS7nDMqTKiPsI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264611; c=relaxed/simple; bh=oJIGdjp7EAXOlQxMBo7w/8vqV6Ga/5W3vX02xu0zArM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=sIbWiifTsxokZRHbK9k5oF92D0pydW2ApNqigSog3zlMHyJvQm6OaLuUwJF/TFXE4tWVVDrOslpaEwAKrO6x8ZKvmGectXiylMHmOHaHFwhKxOYijjLjJVwyQmArn6ltvrf5mW3NEkn/QMe3hzKpLrKF9Wv9+s3MoJoII1k9mI0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=ee9EbYSB; arc=fail smtp.client-ip=52.101.229.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="ee9EbYSB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y5FVPKBOCfV2pyMaxZCRAF/VDEdv7zZsA9UFndRp3wYiFYjGkywPQXFu+e8eoMaXENZijBCzvhIt6xyngezShJfeLT/XnDGNKjlOYfK1Oriqbkm6xTJSLP+ckN5mrPMQTUesn3eZDgYBymRLAtNO5M/L1YnR7nAHyK2wI/1yQfVR0LiUixJIr/EsyIf1AigxKrZhIkefs1xY6zBfiAYGpF5JTGAqQZZyS6/Gx5KgKCdcoLmWlqm+yV3oPyLcVa3IU/QruNPA2Nnm9MtRBl5lj5XyCfpCdpCtmKQ6Rk/Cjs4DNkeBn6k0EZI06eXjgKcAPRqihiDwKlDYAvcFzcrtHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TzvQ9eHjScS2ioxxfdmusosS7abacdE48zd922j8BX4=; b=LBKcfVlEmAL4onpvif8OPRCMIlURsKtdshGQeuU2a1PLw56MaDlC/c+PWD7oCKJmHcsJNYBnUxqh2upM/Lw37uqPNAByXsCya+SY3fBEmnJtyfOzEJ1exo1Ur2WgpZCgT0XxNHI6oOvtGeehRIdoUOSTJJMv40H7Aze44e0UhKtqAdFfEzK+VKdr+M+5RCOyXguGWkCvndU+TPc3Fn9uEy13+4XI+qtPfZrxvalHP+qVmOAzD7XNLbK4Gdwdy1Il9XW+8+sCtPaKH32YqJRrDPhyNJoW+BvUGhmvaUFMhoJoOggR0zF7hsRih6ItztbYrZvejV5MI4VFU228uFScuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TzvQ9eHjScS2ioxxfdmusosS7abacdE48zd922j8BX4=; b=ee9EbYSBbJ/ovZ70lEFSDYHYtuO3rXWIEO3LT00XTYrIdK8eYZAvIrDa9oOhattJFkmsAmZFdgOUToRDOyM+fdCUkI8Np9kToQgkyGOlkpBED0AMgITqv0glDE18Tjf6LH/WRKRk4DCEv4HGELfmaNOZgVSzzuN1TvJlojkux44= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:19 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:19 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 05/14] dmaengine: dw-edma: Add partial channel ownership mode Date: Fri, 17 Jul 2026 14:02:59 +0900 Message-ID: <20260717050308.2144108-6-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0059.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b5::16) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: 08778325-fb97-44e3-cc90-08dee3c0b7dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|6133799003|56012099006|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: nkMqlk3d+Z5UU9X+nmSzbw2lA1wksh7e03LMNTpJ0FRg+EMhmUGRkZNDzgazn5AvRVprolFn6T7HnKeo+gCBBmGqwKoVVo9SHG++hSF9EysqLv6mBlO3q2ry2yGCmNYZuunqlF2PBpM5/mJuElPRvHy3pSiFsLNTLP+lv0DckoFOtJMJPK8uXFYgirUzmn1REN4+JdHzc42Re5bBesdYiuW8arPG1rWeWV3JIZkO8+Og1Ygll/L7Y5iihjm4fDNA2RoBkrXxSnSx4sod4kXNE2bVU2pxjuj1it21t18QGHayyz/OrhhMBmx2NfPLS/GLJ3nNEfnfli/PNNtK8ri6vJtDF4k0E2CGuVIEaR24A3Khd27F2U5sJiTU5S0lcK5qUaHTIuHYSE5cit0feR61IpTHHDToxKgc+4GhbsSdtfx3IHMezy1KCw+edjg44PAzGq2EYLTxWvbBnlxhMdSjjgiwWBcv9oYosg9nO7nJ6pciIYCXxrZW7IbP8A6c0R98/rjbsrPVcrBX4j4MGKSvPYqHFVuTuTfplA8DVqkGd7ME4+42gZdiKSaJ3E3VSiaBOTBpEsO0BUWc9557s7Unw3Nl/DomThqxcEEvwuepa5GAQiTitIrKTw7bPxjUHtT7XFZw0Biqc2derFC5z7lL6hGZGOIzMI2ov+dl3M2BRms= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(6133799003)(56012099006)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z0T4DD/i/zew76yOTYJaggv6sW+1fM5SWkYQ6rBI/qHftu/z7QdXIMVPlgTb?= =?us-ascii?Q?FPk3ddo/jVgVPiEaNFBJxsccf3BM/SVlJEX0B7HGz5GYGP7sRi4MYbbrKc2v?= =?us-ascii?Q?XRZIYcCsSVXsT+/LKb6PQanmFkYp/P6DKm3ImjaZ6rNNkdp0LlvPgyFkQVAF?= =?us-ascii?Q?mfG/oV288G9a72ob7IAJ20QAB5IclztCs55Gvp/VbXQYGV3Y7eCtqr0RTwP2?= =?us-ascii?Q?iNn5NTtGCZr0XAsIgeyzI3B8jThm9F8lNBK6c88A+l08LTJCV1VUBjep+xvL?= =?us-ascii?Q?4ghUFNYr9F1+4hU5xOBq3SMo+UXD8XVa50rYdMxj5fhlzMcbAqaEF1/654ZR?= =?us-ascii?Q?J0+ZX9tHYEmLEFOS8u3gGMiPfYzstOOHimLHK0a1hCvTkUlKjLPcNeRVJune?= =?us-ascii?Q?Onv+gkP+m7bfn2tQF1xdjbqFDu8HZUFwPmALkEJlJqgZVmDDf0SIeDaMwC4L?= =?us-ascii?Q?msUSH223AadL3CywUbGVpR1eUpMki8xFQdkx1tbnLzzw103xp5TA5KlS8prd?= =?us-ascii?Q?nJVTgFn2UrvNR0sKzJTF1MpXJ5JrPw+FMivO3ubztj1RuCAvnCFO//wYKYrH?= =?us-ascii?Q?UO1zF7UQH1JrqfocgY3EEvHJNTPjxdmH0UnFHhMhxJnt8Tju/4yixZmXFcjd?= =?us-ascii?Q?3XRv3s0PUyj1U7mjZsfsc4l0RGkNJcRo3ATxWEUWfr1sCHigG8s2poNpDVHZ?= =?us-ascii?Q?vwe7mWRF7ctuA7klMkUoK0ilIhfyMBV7ZD1HyUWbQCeRKI0mjk2vVexjel2n?= =?us-ascii?Q?1P1c1+ZYowu9bZuoe8ESLHW7d9zNYGuVxdDX36bcCvzdHvsRW2LtK6ad9QG4?= =?us-ascii?Q?xOWYr1Rc9brCTUPOlqWAtUX9vpqOxP3QIuYj1eakBusMUOQFm2Ggidd8e3Xk?= =?us-ascii?Q?jN5Fdxqmjqv6dLb+MSvNoJYdrIq+2mUUjyBOMtuETKt30OyQ98IUcHITFEUl?= =?us-ascii?Q?wO6tFj9mzl9VG1sYoJSKvLIOY5L+x3a4gcsUUTUmTCvUphREtBzCJao0jow9?= =?us-ascii?Q?rIsx0tbI+mfeAbfhHCY+Q7NhrNdpJ7hBenknhSgnVAyARK8KeqKI+xLBvCBJ?= =?us-ascii?Q?i21cChA7Z98JRdiThW5ZfeADmTbsuA6B7p3E0iIbGK8AoI+Y/ubw4LJV68rQ?= =?us-ascii?Q?khr62XhfHBX5jtn/NrzTpMcQmmQh7pDHa5U8gX2jzbAespByf157lJiWH3yA?= =?us-ascii?Q?x98XeZdO1DN+u8yyMQGdkCKR4esYya9obvowuMlm21M81U6arGc/cMNw9iSQ?= =?us-ascii?Q?zlgwSlaU72+0ZkmbFeAqKE7Etw5J+EhgGY0adf6SWYJyTt+WdVzccdCU6Ata?= =?us-ascii?Q?CRMAiUAU5n/MMCrKrexiU5m8kwPdzzI5PM5upSL1EjPD3Y5KrJU+vhCDeRQq?= =?us-ascii?Q?VPpiD8hhEilBf0k+F0dU97GafIDQdGQIyFIYzUtC7mOiEUqupeU53rsmpq1f?= =?us-ascii?Q?CiWY1nrvEBUelLqjI7xWjtH5Hhxk70qWMwdlkz6F/7pp3SiRiiGGiC83fQA4?= =?us-ascii?Q?M4sjyS05hGXEEzRzXISrP/kzfNlR5trMG+HrSsAhdvrwfscVNrqu7TPsowi6?= =?us-ascii?Q?VHwmjog7g/qEyDdiBfbbEp+9/jufpljCJKdRpjNdKjKvkMUTdRPNxmqNEm1O?= =?us-ascii?Q?jt3V66NRN9S8dKSZL+D53prd2BDpWNXRaTztyDKVwqT/r7bN4zpc+a0y7e0I?= =?us-ascii?Q?UwtGmgrEapD2oVZzIUp5Ud4FQ2TToqt5eNARz2C64V3Tm6bZk9yX01Vyc4fv?= =?us-ascii?Q?47R4pJ2/7uYEW5FDwLp1T4GXHDNQOa2Qy073K2AVUebkEf63Mum8?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 08778325-fb97-44e3-cc90-08dee3c0b7dd X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:19.2348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /g+UaG4W69818HB+If1T+xT9/3vh57AKj16P0yaeB6HgWpp7l07qqrtkA9PYqcM32TNnX6Dai4uSi2bO7qT/Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" A DesignWare eDMA instance may represent only a subset of channels that is also initialized by another OS instance, such as an endpoint-side OS. Add a partial ownership flag for instances that must preserve controller-wide state owned by that peer. In partial ownership mode, dw-edma skips the initial core reset and uses the limited quiesce path in probe() and remove() instead of the full core-off path. The flag also makes the driver validate the ownership granularity required by each register layout before registering channels. Probe fails if the limited quiesce cannot stop its resources; remove reports the error after completing the remaining driver teardown. Partial instances also skip interrupt-emulation doorbell allocation: the emulated doorbell is a controller-level resource, and a partial owner must not claim it on behalf of the whole block. For EDMA_MF_EDMA_UNROLL and EDMA_MF_HDMA_COMPAT, the driver programs per-direction registers, such as DMA_{WRITE,READ}_INT_MASK_OFF and DMA_{WRITE,READ}_INT_CLEAR_OFF. These register layouts have at most EDMA_MAX_{WR,RD}_CH channels per direction, so the capped hardware channel count still represents the whole direction. A partial instance can therefore expose write or read channels only if it owns every channel in that direction; otherwise two OS instances could update the same direction-wide registers without a shared locking protocol. In contrast, HDMA native uses per-channel registers, so it can be owned at channel granularity. Signed-off-by: Koichiro Den --- Changes in v5: - Use min() for channel count limits. (Frank) - Fail probe and report remove errors when partial quiesce fails. - Drop Frank's Reviewed-by tag after the quiesce changes. drivers/dma/dw-edma/dw-edma-core.c | 81 +++++++++++++++++++++++++----- include/linux/dma/edma.h | 7 +++ 2 files changed, 76 insertions(+), 12 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index 392981f3b7bb..cef75da3f2f6 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -662,6 +662,9 @@ static int dw_edma_emul_irq_alloc(struct dw_edma *dw) chip->db_irq =3D 0; chip->db_offset =3D ~0; =20 + if (chip->flags & DW_EDMA_CHIP_PARTIAL) + return 0; + /* * Only meaningful when the core provides the deassert sequence * for interrupt emulation. @@ -988,10 +991,33 @@ static int dw_edma_irq_request(struct dw_edma *dw, return err; } =20 +static int dw_edma_check_partial(struct dw_edma_chip *chip, + u16 hw_wr_ch_cnt, u16 hw_rd_ch_cnt) +{ + if (!(chip->flags & DW_EDMA_CHIP_PARTIAL)) + return 0; + + if (chip->mf !=3D EDMA_MF_EDMA_UNROLL && + chip->mf !=3D EDMA_MF_HDMA_COMPAT) + return 0; + + /* + * Direction-wide registers are shared by all channels in that + * direction, so a direction must have a single owner. + */ + if ((chip->ll_wr_cnt && chip->ll_wr_cnt !=3D hw_wr_ch_cnt) || + (chip->ll_rd_cnt && chip->ll_rd_cnt !=3D hw_rd_ch_cnt)) + return -EOPNOTSUPP; + + return 0; +} + int dw_edma_probe(struct dw_edma_chip *chip) { struct device *dev; struct dw_edma *dw; + u16 hw_wr_ch_cnt; + u16 hw_rd_ch_cnt; u32 wr_alloc =3D 0; u32 rd_alloc =3D 0; int i, err; @@ -1003,6 +1029,17 @@ int dw_edma_probe(struct dw_edma_chip *chip) if (!dev || !chip->ops) return -EINVAL; =20 + if (chip->flags & DW_EDMA_CHIP_PARTIAL) { + switch (chip->mf) { + case EDMA_MF_EDMA_UNROLL: + case EDMA_MF_HDMA_COMPAT: + case EDMA_MF_HDMA_NATIVE: + break; + default: + return -EOPNOTSUPP; + } + } + dw =3D devm_kzalloc(dev, sizeof(*dw), GFP_KERNEL); if (!dw) return -ENOMEM; @@ -1016,13 +1053,21 @@ int dw_edma_probe(struct dw_edma_chip *chip) =20 raw_spin_lock_init(&dw->lock); =20 - dw->wr_ch_cnt =3D min_t(u16, chip->ll_wr_cnt, - dw_edma_core_ch_count(dw, EDMA_DIR_WRITE)); - dw->wr_ch_cnt =3D min_t(u16, dw->wr_ch_cnt, EDMA_MAX_WR_CH); + /* + * chip->ll_*_cnt describes the channels exposed by this instance. Keep + * the usable hardware counts separate for partial ownership checks. + */ + hw_wr_ch_cnt =3D min(dw_edma_core_ch_count(dw, EDMA_DIR_WRITE), + EDMA_MAX_WR_CH); + hw_rd_ch_cnt =3D min(dw_edma_core_ch_count(dw, EDMA_DIR_READ), + EDMA_MAX_RD_CH); + + err =3D dw_edma_check_partial(chip, hw_wr_ch_cnt, hw_rd_ch_cnt); + if (err) + return err; =20 - dw->rd_ch_cnt =3D min_t(u16, chip->ll_rd_cnt, - dw_edma_core_ch_count(dw, EDMA_DIR_READ)); - dw->rd_ch_cnt =3D min_t(u16, dw->rd_ch_cnt, EDMA_MAX_RD_CH); + dw->wr_ch_cnt =3D min(chip->ll_wr_cnt, hw_wr_ch_cnt); + dw->rd_ch_cnt =3D min(chip->ll_rd_cnt, hw_rd_ch_cnt); =20 if (!dw->wr_ch_cnt && !dw->rd_ch_cnt) return -EINVAL; @@ -1039,8 +1084,18 @@ int dw_edma_probe(struct dw_edma_chip *chip) snprintf(dw->name, sizeof(dw->name), "dw-edma-core:%s", dev_name(chip->dev)); =20 - /* Disable eDMA, only to establish the ideal initial conditions */ - dw_edma_core_off(dw); + if (chip->flags & DW_EDMA_CHIP_PARTIAL) { + /* + * Do not reset the shared controller, but drain stale state + * from resources represented by this instance. + */ + err =3D dw_edma_core_quiesce(dw); + if (err) + return err; + } else { + /* Disable eDMA only when this instance owns the controller. */ + dw_edma_core_off(dw); + } =20 /* Request IRQs */ err =3D dw_edma_irq_request(dw, &wr_alloc, &rd_alloc); @@ -1078,14 +1133,16 @@ int dw_edma_remove(struct dw_edma_chip *chip) struct dw_edma_chan *chan, *_chan; struct device *dev =3D chip->dev; struct dw_edma *dw =3D chip->dw; - int i; + int i, err =3D 0; =20 /* Skip removal if no private data found */ if (!dw) return -ENODEV; =20 - /* Disable eDMA */ - dw_edma_core_off(dw); + if (chip->flags & DW_EDMA_CHIP_PARTIAL) + err =3D dw_edma_core_quiesce(dw); + else + dw_edma_core_off(dw); =20 /* Free irqs */ for (i =3D (dw->nr_irqs - 1); i >=3D 0; i--) @@ -1100,7 +1157,7 @@ int dw_edma_remove(struct dw_edma_chip *chip) list_del(&chan->vc.chan.device_node); } =20 - return 0; + return err; } EXPORT_SYMBOL_GPL(dw_edma_remove); =20 diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h index d29a8df76f8c..f827f2dd5299 100644 --- a/include/linux/dma/edma.h +++ b/include/linux/dma/edma.h @@ -55,9 +55,16 @@ enum dw_edma_map_format { /** * enum dw_edma_chip_flags - Flags specific to an eDMA chip * @DW_EDMA_CHIP_LOCAL: eDMA is used locally by an endpoint + * @DW_EDMA_CHIP_PARTIAL: Only channels described by this instance are + * owned by this driver. Controller-wide state + * must be preserved, and layouts with shared + * direction-wide registers must only be shared at + * direction granularity. Layouts with per-channel + * registers may be shared at channel granularity. */ enum dw_edma_chip_flags { DW_EDMA_CHIP_LOCAL =3D BIT(0), + DW_EDMA_CHIP_PARTIAL =3D BIT(1), }; =20 /** --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11020142.outbound.protection.outlook.com [52.101.228.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A44B332AABC; Fri, 17 Jul 2026 05:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.142 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264605; cv=fail; b=OQZAhWJW2QJ1Bsfwdw+YwL4fNpX8Zg1we+PG+AE3pqbLfJT82e0fD0ilHu9GTjqJwBBpMXWPYDgCiSqWziVFDGFk3XvOj1f1XCVg0MueEfgHutgWDCQAiBaE5qYe2bIkiB8dgKoveaH1V07h61+aZ5INaHmNDigtrdK52Paqd8w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264605; c=relaxed/simple; bh=J+45n3GcVj0hfWfjsrimti8T2h8WHvE2jQyfrWcIFcg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=gLoObK2mwAuULGqy9lgEMPXLW5Rrlmte4DyFsJUCMsoLU5/DrOp2DQY3OzTCUVGK9XnQprXvHGzoJWnDRwvDfvbzcLXYkj1l3SHHm3l6OddsbDiN74dTAXeINp/oSxTxaJGWaXwqI5BSnwlniBdHxFNITj5i5AidhvfaFOiH3ss= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=uO2v1dWs; arc=fail smtp.client-ip=52.101.228.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="uO2v1dWs" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gNwRj2mt2VeViwphfb8y03WPKfp9focSGxsu17xBDjbOb3RspfwiZikp90omtUcN6WgLTleQ/5cB3CB1InBcBhEvfvirRxBlLJQb3K+maePv3jFfytnO6+IIK7eVOPsFq32Kon31gk/DDVDu11WZcqKoWJtoKYohq1IIN/oSmTdpiK8i19qMhZeC2hKqL3RPyVCE/rsPaamBTbmdxKIzZiroXrxpuHYyMPzJ06Or6CUIu8U3nfIQvEnjrBZfRqVuwA6S4lN7MGaS+FNObHtrJztdg+hnjr7Lk9/zQ6Od4q69Km8IKXRXH3tggF4LZxLsZCmgeRICc8wBtBU/lPyDWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2bHJh5l1umZQLBBq+0UwISiaAYS4M1efqkzx/udIKzE=; b=KCp0Guv6f6XpL178z9rw2yLirKSQimsFy+zrmYOWvUAgqSYg9fUdKTWEuLSjLSbf3K4jPYmV1ZJ4CDjJhof2exXdT8ptBg7rjpFa1KWUKa3WdKDWj6iRbbUgslCVHv7/FmNpuGuv8w2t1c4X7S3cw6j3I5ZCe/j6upr/tmHfXOOt7pV+JJH1ORrvqvmFTwwOhv28yELhfz6anfA1vq+fxlBy0Y/kGhgKh0JqlJP1mhlcqlPYTO6hSKFbTDr1B1OP3x7oRwx5AaT2yBKY61PvP7T9CVoUYQbV5R2tUynhFr9ntr61bRh/YDTWm0A5DdTAl5leIhihzKro/W3wIm3zYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2bHJh5l1umZQLBBq+0UwISiaAYS4M1efqkzx/udIKzE=; b=uO2v1dWs+UUipz0VWRiXpbet8/15/JQznj635MXSh0Lh4Gk9hX25lTOqETsoRkqsaA73gV64LgSQhr6QTn6aZDgRysMp3E5Kp2DrztkvNprbFFKQ0Tb/d56Jo9ZFsTLk604VAr89TdZcG1H9c+p879Raox7DGThHWBAunf5sa3M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB5635.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:2d0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:20 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:20 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 06/14] dmaengine: dw-edma-pcie: Track non-LL mode in DMA data Date: Fri, 17 Jul 2026 14:03:00 +0900 Message-ID: <20260717050308.2144108-7-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0016.jpnprd01.prod.outlook.com (2603:1096:405:2bf::15) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB5635:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e0b7b3e-5443-4771-39f6-08dee3c0b870 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|376014|10070799003|56012099006|3023799007|22082099003|18002099003|10067099003; X-Microsoft-Antispam-Message-Info: 54VEsAwDyNOn9EQ2R3KBEhSY5fXzxby8jvHLUMvTLEw8yZPBYBuzbAzFD+6nTrqoTl/kN01Winv5t+ztzL8Qee5/dkwGOT1STanDqgVqXcO9W13YUViHbmiVBcb+PEMLaecLos6RSgoQD0FOpY6suth8Vubv4dWEUI4vR9ZRMt1isz/pQnILkrCZTO1S+swHXRfa/NDx0TXdqhXKX9BV097PSeberD3HvPa1aq/vGQxDZxqE5+/EJqOP5Mqq6PS2HB4AcxCqZR1ulZJHcaBqq04ZwdxMt2C0yH+SbGt76D8DZqJVeH6ZP7JdXe4wQTqivqEIbd7JsRzjD8mA6OPSjKhitUvscst931/9LqZcMk3TwcUwudCcUK28Zit+KK5ilt742UNQV9/QwMtEuudG7MHdnBLOnhKT59jsRrUXh3TPPdl5oClIXjyJs9IAhFaoYsVcg77yYs3LwD3DzQD5St4jEIQq4yQGK9vd8XkUEZXo/nSnGpYZzTvZiZ4F7d6z72H1Rji3Qi6mymg2eMj6K220dqAqJcbXftznWXofsDLo4I1hRj6MWskBJDsNf2t3Pfnw3NyyxONg0A66wyXMcXiFuKSSc3viKU4bBJMbzCQ2fST8ac0hQeg1g5hZlT1rQp2Z5p93waO99/yBiXx8a7Vr2399Oitc07LJIW72oCc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(10070799003)(56012099006)(3023799007)(22082099003)(18002099003)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tY8XketSC8vbeJQlNv6VoZD5bHAmEQy6/MI/Qx87XKCj8A8wl9ng+DufkJrN?= =?us-ascii?Q?LhTS3lIPXBpZA+FpSThNLeRfWv/C4sZg0UtLrYm3rrwBX+v6buGelZW2tu1X?= =?us-ascii?Q?q+WPGtAUPEWc5jsKxi5rTJTclsIdf6+X/NltgBSzgwarXKoXR56KfyGlauy1?= =?us-ascii?Q?9XqrFzO+UTr6TG9nCWhmOPjnN4bKZHWwIpuuJRhOTTyU6q98ZveltpWSLNgt?= =?us-ascii?Q?O4Mf/I9a5h85MV/ll+NekLRd5JZemQras6xQCitNRqAstGqgbYtwdbMDbtQV?= =?us-ascii?Q?Ht5EvlAjzfBxW94ngaZ8+xRMOW2PGjY4W9Oa2Qs/7vphUwSU8PsU6Pqmw6HB?= =?us-ascii?Q?8xjyZ++68yFe5rLkejfIkdSHyJU6Ph1PDXLVUXyd4c6CZhiCWsoj19tm4Fv7?= =?us-ascii?Q?JB5N3+W0slnxSPWAqrLkz4lFtxWoWrXI9PX2H3nHqrMnbW+EzhYeeXR86CU+?= =?us-ascii?Q?NEimXVpV4BouQTq+EGFo+rf1KdYMoYN8OT23mwwlusRo7NfE+iFvtB0XIQCL?= =?us-ascii?Q?zbQ7tC14YOHeL4uKup9VjQK3Zb23441aR8g/xuNcUz0yY8YWwgUE6pWBCC7f?= =?us-ascii?Q?heQJi7lkiWjZ9Qd6e9DJ5HYgoqMS6OMHnZ44OokFF6PLkFk3q8fkCvQeUWD/?= =?us-ascii?Q?+szf5tUXATH4A1RTbkXcpzCQhz8nRc2DyPOYb4p9hKYr/mHXH90kiK9Gzvpe?= =?us-ascii?Q?/oIdLuK96YukqcNVKXG6Ow01sdr48wxieYGC5gCqtCm69dZaugCNkm/sBGpG?= =?us-ascii?Q?S7YiCp6aMlPOvgpr9Y0JhrVizKFSUBfCC5sAkWiQQDtf4X/9NQr2U/LJwWCs?= =?us-ascii?Q?xfkygUNlh60+E4rb4neK6EBkm2CIbG209WVhsLJ+++YXduKKdGMRxpITxVSc?= =?us-ascii?Q?7JIs88vf3FxerY1vm5nbhofPLB1EGcWkYUoVBHp4sJlX+8dPvTy5srJuZ2fO?= =?us-ascii?Q?M13zjOtmRsJZziCY4z3ZfMjKZKeKoJxR/RfIMXXG9OM3bMQqjdY9SQZ/nAXb?= =?us-ascii?Q?t9NG8TD4iY2NSISnXuD7N6ZtYCeugyF4UqAcEF3BVv67kqwEbAd/XxGjeSKL?= =?us-ascii?Q?m8k1ku/dg84JHHWtZDUcAA7hDJIkHO5BYnpUGIQT76QbK2fzG4FXID52D9Mg?= =?us-ascii?Q?+2CmVITslmv/aU0yfLE2E3aId9oH6jNfHDIYTkILOVfe9PFxacuK+KFOkggQ?= =?us-ascii?Q?5cU5BYMTfD8cxJOzHoW5YqaoRFSgovUxpTcaJrjddZRW80vXhljlhkAzjAlP?= =?us-ascii?Q?MwJfJIoufV+jlOIESMDMGrWTQ8JVcbc6B9xC+j8BLUOXQJlH8kPn49Y/ugSn?= =?us-ascii?Q?lFgesMYXxkVNcOYHA6Q/ugOZWUW+lJMyZqjIhUsBOrrTdz31fZqCRyMtc77S?= =?us-ascii?Q?uO8CIm4mOHER6v7HICSb1+oLPtjAIjl0yqUqyRZcvWWIRsQPwY2/6eC8Pb4S?= =?us-ascii?Q?WQ3dQXq0oLqlsWESxd+2RGwUrhA/tAsuRyMGEuIkb4SYQDP1SLW5hLUDBD8u?= =?us-ascii?Q?gRr3cbG+Dv5+LGm/218V661I0PzpLbgX8suRLXN28XV0+x+hgF1/L+EDydVe?= =?us-ascii?Q?9dnQGjdyOAR2NzcQ/CyW685W8uxchoGSM3L/y7WY0aC38ARS74Ng8e9d666G?= =?us-ascii?Q?5KjnYqQbMVfl3J9M+O76EQ5t+7suIkoF6Il4YYLYZEFi27MD+gVfam0dUyhI?= =?us-ascii?Q?SE2JY0GnQmgkB8akIw0HCQ4Kt4qL5JvyQTpU6j82cVA0rWW4Jc9naP9MIf1r?= =?us-ascii?Q?S8M3x6JW9PdR2VyhLa6cgqpPYadwAIvzQZRFZ8IAQa1guUXKofnm?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 2e0b7b3e-5443-4771-39f6-08dee3c0b870 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:20.1719 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E2KA9o1qZlYkf8yDZg9b0WVpHGZiS+KJv5Tf4yHUi4Sru+Tv50BCz/s0QO0e56f6Jvi8WmUf2FEOJQdLMYtH/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB5635 Content-Type: text/plain; charset="utf-8" The dw-edma-pcie driver copies static template data into a mutable dw_edma_pcie_data instance before applying capability-derived updates. Keep the derived non-LL mode in that copy as well, instead of only tracking it in a local variable in dw_edma_pcie_probe(). This prepares for keeping capability parsing behind match data without a separate non-LL output parameter. No functional change intended. Suggested-by: Frank Li Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 791c46e8ae4c..16bb938c6e40 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -73,6 +73,7 @@ struct dw_edma_pcie_data { u16 wr_ch_cnt; u16 rd_ch_cnt; u64 devmem_phys_off; + bool cfg_non_ll; }; =20 static const struct dw_edma_pcie_data snps_edda_data =3D { @@ -326,7 +327,6 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, struct dw_edma_chip *chip; int err, nr_irqs; int i, mask; - bool non_ll =3D false; =20 if (!pdata) return -ENODEV; @@ -361,14 +361,14 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, * the HDMA IP. */ if (vsec_data->devmem_phys_off =3D=3D DW_PCIE_XILINX_MDB_INVALID_ADDR) - non_ll =3D true; + vsec_data->cfg_non_ll =3D true; =20 /* * Configure the channel LL and data blocks if number of * channels enabled in VSEC capability are more than the * channels configured in xilinx_mdb_data. */ - if (!non_ll) + if (!vsec_data->cfg_non_ll) dw_edma_set_chan_region_offset(vsec_data, BAR_2, 0, DW_PCIE_XILINX_MDB_LL_OFF_GAP, DW_PCIE_XILINX_MDB_LL_SIZE, @@ -421,7 +421,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, chip->mf =3D vsec_data->mf; chip->nr_irqs =3D nr_irqs; chip->ops =3D &dw_edma_pcie_plat_ops; - chip->cfg_non_ll =3D non_ll; + chip->cfg_non_ll =3D vsec_data->cfg_non_ll; =20 chip->ll_wr_cnt =3D vsec_data->wr_ch_cnt; chip->ll_rd_cnt =3D vsec_data->rd_ch_cnt; @@ -430,7 +430,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, if (!chip->reg_base) return -ENOMEM; =20 - for (i =3D 0; i < chip->ll_wr_cnt && !non_ll; i++) { + for (i =3D 0; i < chip->ll_wr_cnt && !vsec_data->cfg_non_ll; i++) { struct dw_edma_region *ll_region =3D &chip->ll_region_wr[i]; struct dw_edma_region *dt_region =3D &chip->dt_region_wr[i]; struct dw_edma_block *ll_block =3D &vsec_data->ll_wr[i]; @@ -457,7 +457,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, dt_region->sz =3D dt_block->sz; } =20 - for (i =3D 0; i < chip->ll_rd_cnt && !non_ll; i++) { + for (i =3D 0; i < chip->ll_rd_cnt && !vsec_data->cfg_non_ll; i++) { struct dw_edma_region *ll_region =3D &chip->ll_region_rd[i]; struct dw_edma_region *dt_region =3D &chip->dt_region_rd[i]; struct dw_edma_block *ll_block =3D &vsec_data->ll_rd[i]; --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11020142.outbound.protection.outlook.com [52.101.228.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66F19223DD4; Fri, 17 Jul 2026 05:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.142 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264610; cv=fail; b=G+nzteyjrhVutVRUlxqdXsuvYkmtLfzgj8Vx8LYZtcOme3TEUrmalWMgOmK8bU+tdGusHxJ/IMCCc7u0//bz7Yzd0JlzsbXvBYdKXhNNisw6oDHMmzz3Q8r+9eAhYKXKl8dyRaIlUiC141MBA8tYa0VZ0jLBoJH79055UJqeQvM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264610; c=relaxed/simple; bh=g7NomjkKgZfnfhiH2BiXyCuD7pzRmNJ3QlTTlHRSu3A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=nFSr2eDF1tI2jIygod81CDAVxHEgUk8vRd1gV5M6X8duKHcxZv1+B66NPdpsK1rvI7samBOhgDWdCQ7EcbM5ipL2G6LGPVddDjVXch5uFxdnZuSzDf5hcgObKQcvxrYAG+nSbOdyqXzkSEikupC3yLplgpQwrkX6KYHTYJPzjqI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=lR2bM5w3; arc=fail smtp.client-ip=52.101.228.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="lR2bM5w3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RZa/ZEDzHYIEYhhVa2eGDY6fgFqN2OzVcAMOJdeMx5yhJNwltynkMWJ0blGvDhn7mbF2PO1JvqmHq9eN7JY2jBr2EA6Hc+QwIFllyl8/XbFzvGgCJpLEp4FVygk14wyLNJXKgM5TO39dEdqc2liHbBU4jFo5h3//RkgNnAYdpcBssmo+bMjItEqqTR7GirM/centKfB7DW48Ue59149pRBm5FVRjlcTEf61Ergg4j/fEi3cYxspS/bkhM2yqas2nxXs1IH56Gx06+TlqKsXvSdsxI8xl/gxExSHDXh/RaeJcqoyJnY3JFKGFymvxDHFExJnnVng5JyAOKwEKJ0jJtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l2AJGtKfChKDPfbiktCos7nVAQUjOJ/XWuLHtvjClEU=; b=Z/4QDxN7dxzxOjH7ez3NE40321sdb803g2KM7y2Jh+QofaTWiR7c8+JhTnF3BEuT/0WsoAxPBMSiTmVWqh6wQFMhHRzext5ccWU6QE4VYGNkm/O6lsdoWZtjqiX44fOfHyM63qwjQVT6fwElriLveEmbtVRLj7iHG/hMSS9R43UVX8PQ3gANL+W59H1bm12sw2YtYj0C6jncyaz0C1eIFwQi2aFcse2r0gwEmjNg82Ocl8RYkBJ11ihlRcy1r0HFuN4rVYM5cCBq09bJAgyG4LeFuEPK8vLH36kvkKWZesydQcwvTLtjjkAQr7XlyJD9Uiq7gkpYpJPeUfAXu4efLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l2AJGtKfChKDPfbiktCos7nVAQUjOJ/XWuLHtvjClEU=; b=lR2bM5w3g1BcNzBDkjudXU1WJBAGpVjDfS0aubg9269S4cuZfW0wFiYKGAY8KxKNOOkGqh6oUpXGUBkLl899T5v6uljFRKnah81Py4uIohr/2SWhZu+DHmyrbeLcctSOeML1jf4l3cg2sLQfq8+434MBrdhLyAnCUtcW4QrrHjs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB5635.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:2d0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:21 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:21 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 07/14] dmaengine: dw-edma-pcie: Add capability match data Date: Fri, 17 Jul 2026 14:03:01 +0900 Message-ID: <20260717050308.2144108-8-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0319.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3b7::18) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB5635:EE_ X-MS-Office365-Filtering-Correlation-Id: 71e2e9f2-f52d-4922-dd8d-08dee3c0b8f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|376014|10070799003|56012099006|3023799007|22082099003|18002099003|10067099003; X-Microsoft-Antispam-Message-Info: 73Gt/3MtSLSSpkWbbCNCbjNJvEn0iwinzLRR6HnP4+IRsJhbSlkCtr+sMfI+9GiTZHd1W15wKWo8ZNNj0OBac3ViY9m1nwPTP/9tF9DArsyEJnJE8OBjtpmA65YmKGGoQrLYNIq0tgmfeV8i6/xzuPJaW0IvxT3UZeXsfA2Wh92bzUwEIrPtIB4oKIm7rFG8tPAJOzK4M7Vb42LRSHMGyNYvJRGzpKwiqCe1VzUR0+L+xStSdiEI9uJhgr/P+c4/Xx+vy7gzv8jnL/GLFEyEJjm41PZG/b9+L6ipCywm2RDSqMKkTB+0UT6uIYFrvxhjg9pmgjOPsgIJAHkCY5RX9vkdBtyj6NanwqivSSlzyswQ89DPUUZ8c+ZbUwjDV7DFT51Q2q/x+spcENClv4T5w5oatmwaQDpcBnok5MuKakY/6s0Agz80rHSYmmdoq2VU+DUQKN617AMwVZ7Rmlj7UHEXGbUzq+s8vgWJeh/A//zuGV5J+H4h9ccPo43kX+jsUIIPcvUzaWbG3ZldnLf9ppI9JeEuO7ggxG4FtIb//4aJ2X9eenVp8PPYzQws6oJiQtNp8j3Fthd2byQ6FV6nH1bIfmOTB6pu3NeIai194/Ysn6SR6iwP/KGLZYZaEwV/bzdCU8o7hFHS67+3D3Xk/AgVRwBhbBbDD2vJ8wwagSQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(10070799003)(56012099006)(3023799007)(22082099003)(18002099003)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MlYrWD3gzn77o2j9SKSvv3TrSw3GV1kj6/E26dNnLCcdx9aYaDK6fkwItwJ2?= =?us-ascii?Q?kHpuxmIWzuX8sTJ8FSrVjJ4N38NOHJr4NBEtxQHisQ+u8cUAtdgGxwceeRwT?= =?us-ascii?Q?a3cdCbKfmoGUcweSDOB9J0uy+bntgfNAZ/Ovwvxh2lHiJvO2kYVnWFIeJCH1?= =?us-ascii?Q?WLSc/mKIC1MVVTwr+yq6BQCiD5oEwwFQc8rIDWUtby3ceVNiqSUQo70RRXx1?= =?us-ascii?Q?/h9DUq8JddDXrHrKqErvHIDhQ+rs/tvqMC43jdB1UuotStmM8IPXs9FVFud2?= =?us-ascii?Q?USslhqTQA6OjHN0sdXwmgYtmrglU0LZ0Qdriyo6ExSfg/zRshvvEvbzhuwYZ?= =?us-ascii?Q?7Iy4Vx7VERxDCGWifUS5Wxf6sZ1lzW3bQyus9UIgdApdxrFFbLO4yyWhlumo?= =?us-ascii?Q?73G8I97+6hxT/hp2L/O2nHzB/sKHdi4QeGlGnctFM9dkz1gildrYOZsb2ltf?= =?us-ascii?Q?qjKVSBGJVAef5P3SBL3YATbpTO8ltOjoLBIge0kJZb/l2ah16IDBKyrbeqU0?= =?us-ascii?Q?a1cxPOz8REvWEX9/puiUuOCQfoHElH/tLkQmyi/vBb0jceLjPzKqD5h8dtdS?= =?us-ascii?Q?0vA3BfSLFIaQ9drxCr0MljWSNn7TTmfuZD1PhVRqkpchYxVuW5hGFkF3poEY?= =?us-ascii?Q?gQKAJGgDqtZy8nfaKwJyAz1GTCqTKTXXOtplk0Wl18aw1jfppsmYQcLa6n1Y?= =?us-ascii?Q?wwKEuFMla+lbj3oXbbYZ9hDBfmb1bM6q0Z3FMoeFv/D3M8VUZp3WdrRyLe9h?= =?us-ascii?Q?YNGvuMZjL6LBuYxYX5taCgcRBJVIE2H6HyKKBjDb8w20rOgK/NgPQP7pgITk?= =?us-ascii?Q?5lUBWT2oWtUNmE5kGoV12aWQYFO8Yauj2HaEHmyJPAwYH5w4mbmsJ/ufYYCV?= =?us-ascii?Q?TE/xR1uHU36j4l6vW5K7EZlaIXiFYqTKsbGGLx0ke0EZtGc2Y4wuzYmsaGia?= =?us-ascii?Q?faunRrXJiXeKJ8ci1VTUW8PpcN8Wt1N8MJpe3VXLgyq9Z924DMb5Mbw3h5MM?= =?us-ascii?Q?ITgFJ80FbBPq8qC8Nrprdde2kzLsuIe/hKQTzElXb0qtoCk9w8eU9RzuHrZe?= =?us-ascii?Q?Qh3qfdpF5g0WZrLeOI5DRuOJfmIkS+VofKMahCGpLK+FCFoeW+gicx4JpN75?= =?us-ascii?Q?oRCQuXEUYhGKnF9OhzeFM2Gz8ktUN2+oZAwmPG2GJcrLn+oiYiECNYZJgve6?= =?us-ascii?Q?WvvHYcimiCsnhGbAumALBI0Wn1Nwl7t6icBTeGKwDfAUyNUwskCFifjBuM04?= =?us-ascii?Q?mI1V02AIqoPVkqEmFkCB/pTsfb1TnjAbxDtkIqwO/zn2p6wGAOhym4Ood9fv?= =?us-ascii?Q?nwXuD+vvdrg66Ic0lwP+6B8jMEVDuUl8yNCVMuRhxiBQ9w+jSGfjhDGc60fS?= =?us-ascii?Q?ejEW2YDmV1EugqTLp7VB+aMr86sY9IIG2fESWSgBo2hQIpg2Nmt91AEgPssr?= =?us-ascii?Q?o1zOZXR1A+pK+lTI9xzS/2wVUBKEa4GkOqOC0x0/JFCmU2VlTQjjO3gM4r/g?= =?us-ascii?Q?gjhxW29/to7XSajyuQHNk/VwhGdgFDBH4i3QqLwxt0ZHLNQD3a0WWNXeO4Q9?= =?us-ascii?Q?9wB7eL9gSF3OHe9hKWh+Sgmk0jWWafkTzUDC6WvwTCeSvBAX3UfExgo7ebei?= =?us-ascii?Q?opEL9+SVchVTrqAnzsmO0hIAAulM/7NYk0aYRMeG2vEoP8G1U/wzR/RkEWst?= =?us-ascii?Q?WSgMXrF4+0Qz1XU3e5nfhBnG+xfPwuqz25RHbaL2SELcsHTiUeCOtJvTChr/?= =?us-ascii?Q?NbI6Z3g1MoMP/55rjQKGfGWXtpiCqXUgyffxfWb3tea6lNk+b3tp?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 71e2e9f2-f52d-4922-dd8d-08dee3c0b8f4 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:21.0257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fco1C2mon9+PFFvErvUki645Cnbdd2HUGQJZDiswpf7FEwZUJhmSjP/cmtcC/lmpPnNS5Rcuiv4CP+cpykEExQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB5635 Content-Type: text/plain; charset="utf-8" Move device-specific capability parsing behind per-device match data. The existing probe path mixes two decisions: which static template a PCI ID uses, and which device-specific capability parser adjusts that template. Split those decisions so device-specific discovery can be added through match data instead of adding more vendor checks to dw_edma_pcie_probe(). No functional change is intended for the existing Synopsys EDDA and AMD (Xilinx) MDB/CPM6 matches. They still copy the same static template data and run the same capability parsing logic before BAR mapping. The AMD (Xilinx) MDB/CPM6 entries also keep using endpoint memory physical addresses for descriptor windows through a new match-data flag. Suggested-by: Frank Li Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 139 ++++++++++++++++++++--------- 1 file changed, 96 insertions(+), 43 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 16bb938c6e40..23f09ee89639 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -76,6 +76,19 @@ struct dw_edma_pcie_data { bool cfg_non_ll; }; =20 +struct dw_edma_pcie_match_data { + const struct dw_edma_pcie_data *data; + /* + * Mandatory callback. It may leave @pdata unchanged when the static + * template already describes the device. + */ + int (*parse_caps)(struct pci_dev *pdev, + struct dw_edma_pcie_data *pdata); + unsigned long flags; +}; + +#define DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF BIT(0) + static const struct dw_edma_pcie_data snps_edda_data =3D { /* eDMA registers location */ .rg.bar =3D BAR_0, @@ -310,24 +323,70 @@ static void dw_edma_pcie_get_xilinx_dma_data(struct p= ci_dev *pdev, pdata->devmem_phys_off =3D off; } =20 +static int +dw_edma_pcie_parse_synopsys_caps(struct pci_dev *pdev, + struct dw_edma_pcie_data *pdata) +{ + dw_edma_pcie_get_synopsys_dma_data(pdev, pdata); + + return 0; +} + +static int +dw_edma_pcie_parse_xilinx_caps(struct pci_dev *pdev, + struct dw_edma_pcie_data *pdata) +{ + dw_edma_pcie_get_xilinx_dma_data(pdev, pdata); + + /* + * There is no valid address found for the LL memory space on the + * device side. In the absence of LL base address use the non-LL mode or + * simple mode supported by the HDMA IP. + */ + if (pdata->devmem_phys_off =3D=3D DW_PCIE_XILINX_MDB_INVALID_ADDR) { + pdata->cfg_non_ll =3D true; + return 0; + } + + /* + * Configure the channel LL and data blocks if number of channels + * enabled in VSEC capability are more than the channels configured in + * xilinx_mdb_data. + */ + dw_edma_set_chan_region_offset(pdata, BAR_2, 0, + DW_PCIE_XILINX_MDB_LL_OFF_GAP, + DW_PCIE_XILINX_MDB_LL_SIZE, + DW_PCIE_XILINX_MDB_DT_OFF_GAP, + DW_PCIE_XILINX_MDB_DT_SIZE); + + return 0; +} + static u64 dw_edma_get_phys_addr(struct pci_dev *pdev, + const struct dw_edma_pcie_match_data *match, struct dw_edma_pcie_data *pdata, enum pci_barno bar) { - if (pdev->vendor =3D=3D PCI_VENDOR_ID_XILINX) + if (match->flags & DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF) return pdata->devmem_phys_off; + return pci_bus_address(pdev, bar); } =20 static int dw_edma_pcie_probe(struct pci_dev *pdev, const struct pci_device_id *pid) { - struct dw_edma_pcie_data *pdata =3D (void *)pid->driver_data; + const struct dw_edma_pcie_match_data *match =3D (void *)pid->driver_data; + const struct dw_edma_pcie_data *pdata; struct device *dev =3D &pdev->dev; struct dw_edma_chip *chip; int err, nr_irqs; int i, mask; =20 + if (!match) + return -ENODEV; + pdata =3D match->data; + if (!pdata) return -ENODEV; =20 @@ -345,36 +404,13 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 memcpy(vsec_data, pdata, sizeof(struct dw_edma_pcie_data)); =20 - /* - * Tries to find if exists a PCIe Vendor-Specific Extended Capability - * for the DMA, if one exists, then reconfigures it. - */ - dw_edma_pcie_get_synopsys_dma_data(pdev, vsec_data); - - if (pdev->vendor =3D=3D PCI_VENDOR_ID_XILINX) { - dw_edma_pcie_get_xilinx_dma_data(pdev, vsec_data); - - /* - * There is no valid address found for the LL memory - * space on the device side. In the absence of LL base - * address use the non-LL mode or simple mode supported by - * the HDMA IP. - */ - if (vsec_data->devmem_phys_off =3D=3D DW_PCIE_XILINX_MDB_INVALID_ADDR) - vsec_data->cfg_non_ll =3D true; - - /* - * Configure the channel LL and data blocks if number of - * channels enabled in VSEC capability are more than the - * channels configured in xilinx_mdb_data. - */ - if (!vsec_data->cfg_non_ll) - dw_edma_set_chan_region_offset(vsec_data, BAR_2, 0, - DW_PCIE_XILINX_MDB_LL_OFF_GAP, - DW_PCIE_XILINX_MDB_LL_SIZE, - DW_PCIE_XILINX_MDB_DT_OFF_GAP, - DW_PCIE_XILINX_MDB_DT_SIZE); - } + /* Let device-specific discovery override the static template data. */ + if (!match->parse_caps) + return -EINVAL; + + err =3D match->parse_caps(pdev, vsec_data); + if (err) + return err; =20 /* Mapping PCI BAR regions */ mask =3D BIT(vsec_data->rg.bar); @@ -441,8 +477,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 ll_region->vaddr.io +=3D ll_block->off; - ll_region->paddr =3D dw_edma_get_phys_addr(pdev, vsec_data, - ll_block->bar); + ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, + vsec_data, ll_block->bar); ll_region->paddr +=3D ll_block->off; ll_region->sz =3D ll_block->sz; =20 @@ -451,8 +487,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 dt_region->vaddr.io +=3D dt_block->off; - dt_region->paddr =3D dw_edma_get_phys_addr(pdev, vsec_data, - dt_block->bar); + dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, + vsec_data, dt_block->bar); dt_region->paddr +=3D dt_block->off; dt_region->sz =3D dt_block->sz; } @@ -468,8 +504,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 ll_region->vaddr.io +=3D ll_block->off; - ll_region->paddr =3D dw_edma_get_phys_addr(pdev, vsec_data, - ll_block->bar); + ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, + vsec_data, ll_block->bar); ll_region->paddr +=3D ll_block->off; ll_region->sz =3D ll_block->sz; =20 @@ -478,8 +514,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 dt_region->vaddr.io +=3D dt_block->off; - dt_region->paddr =3D dw_edma_get_phys_addr(pdev, vsec_data, - dt_block->bar); + dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, + vsec_data, dt_block->bar); dt_region->paddr +=3D dt_block->off; dt_region->sz =3D dt_block->sz; } @@ -560,12 +596,29 @@ static void dw_edma_pcie_remove(struct pci_dev *pdev) pci_free_irq_vectors(pdev); } =20 +static const struct dw_edma_pcie_match_data snps_edda_match_data =3D { + .data =3D &snps_edda_data, + .parse_caps =3D dw_edma_pcie_parse_synopsys_caps, +}; + +static const struct dw_edma_pcie_match_data xilinx_mdb_match_data =3D { + .data =3D &xilinx_mdb_data, + .parse_caps =3D dw_edma_pcie_parse_xilinx_caps, + .flags =3D DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF, +}; + +static const struct dw_edma_pcie_match_data xilinx_cpm6_dma_match_data =3D= { + .data =3D &xilinx_cpm6_dma_data, + .parse_caps =3D dw_edma_pcie_parse_xilinx_caps, + .flags =3D DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF, +}; + static const struct pci_device_id dw_edma_pcie_id_table[] =3D { - { PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) }, + { PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_match_data) }, { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B054), - (kernel_ulong_t)&xilinx_mdb_data }, + .driver_data =3D (kernel_ulong_t)&xilinx_mdb_match_data }, { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B00F), - .driver_data =3D (kernel_ulong_t)&xilinx_cpm6_dma_data }, + .driver_data =3D (kernel_ulong_t)&xilinx_cpm6_dma_match_data }, { } }; MODULE_DEVICE_TABLE(pci, dw_edma_pcie_id_table); --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020109.outbound.protection.outlook.com [52.101.229.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A013E37204C; Fri, 17 Jul 2026 05:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264613; cv=fail; b=QPdlLQoCPkq4x8wUq9uenCCvOWUs1ZaWWPKePkGWmLtwXc/hyRU3kRUcnot8YpqrNTuNpoicbH4DLluE2tFOe00ILBfqHlr/QZBDu7rd3yYMuy7Uaiz9Ix0DgBAPb930foiDTAnRSVnqDEWdEPx5g8baj+5aC5XqvY4JkfLChoM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264613; c=relaxed/simple; bh=LSDP5nIMXfsw7cKotI0TGgGAyo1oCGrLmKcfVzjbeXk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=svTVAHKU+YefPL7VWk/OzCBi44wbRoUSq6mY3P9qnJT2Qa73QvR1WP2j/0xXNvZro9gmEcdCLTV6/LOZhC7RYRG7XSA0M3vlOCof5rwlXV08A0zJPkKWc6gSde6nw4kobyvWWojM5MqWFFbZ1CAQ5Mg3tJ9plrwgPZVWGBs5mBc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=D2VU1cY2; arc=fail smtp.client-ip=52.101.229.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="D2VU1cY2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qLuEHk7wXrIajPa3w2uImzvJXxRvW5tPzz4mW8/tkYGgzGxkgKYbg8HTqpf4YTRkNaRvaqmWSp3I1PYumz3VNdjFC4MaFfUBEXQEY0vUbhe0w+S9KNs9qkACJKGmxnyIWTPZN3+LK04iySa+cxpqZHAuQ0QvZ3Ufd/aEygF0ZGpf6uMDExqy75eiLLWrcBaVdC9Ht7FHvqMqZHPeF1N5j1kYpxpjjUSMgKECNUSvAAiBjmXygeFYYqBxhyhxylf8R5bHYLiDDjw4WSVbtlJaY2aUfJDPFCdna7N3cnGa6xvAXeO0Rnw1/WwzrhMSgOiOO0pkxhpyfZdNluV18yYe9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MlNqYHzjSSY1MkHV/uKYRiIu3YetaMkK08Ibm8OHTG8=; b=UTvpto0mQMSGJwpbn1o3Kqv628twFDG7NOgEsxbQYS+JMQR6BJPhMjFxnPkaCyB4TGcwJqKI9bICH8MUazfuWImTxyK5xinDFPmZf5Qmy2spphhLwC1YJHCz4qtLZH7pDctk/IQ1JU5DVpJbJrxUAeT/irSPJ72P3xMH5DUzbWJ+IsT7HwqKfYDkqUPVEc7tvgfHhSvovfz1F2MVv7HSvdeXQnu49eJPJc+SI98A4iLHMvzS3UfBHCOZrzMaTjWeHG4+IQyFYoPQlcxwL6fOO2SjIPDheTFhACR6Bw1DZ3SO6TlJnrkK1/pJTHs/KwtY+tZ+ozLB4eyevCM5eorg9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MlNqYHzjSSY1MkHV/uKYRiIu3YetaMkK08Ibm8OHTG8=; b=D2VU1cY2R8nFmPeEGn49SnYJUcnFD11a5tGyBQSqOqHqhgI1Wi2PuMmMl4Y/6fdtNaq2HMEy0GNq0PfCMJMunyEr6nsFphsEm6vsTNsWACdiFVyLQdII2s1SK3EOcD2aeVobvHrMO+1f5qNRUggny2qBFE2ZgWEZ2sl54Dgqx1c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:21 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:21 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 08/14] dmaengine: dw-edma-pcie: Rename vsec_data to dma_data Date: Fri, 17 Jul 2026 14:03:02 +0900 Message-ID: <20260717050308.2144108-9-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0088.jpnprd01.prod.outlook.com (2603:1096:405:37d::9) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: 08f2bda6-dd7b-4a0c-8566-08dee3c0b971 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|6133799003|56012099006|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: ERW4qds9vu9ZiU7daKbXaE/NhSQFoOqMU40wzhtV9ehLRklPKwGUuz66Pdi+Pb5ZRfRqObI92fJU2ArBYnvlAJYW0K7tqGBKGDoh2G1QvRA2pi4glZ0XjWp09g37sUMieBGwaybrWNAfHClHBNaE+vmzMrfXGdjdd4eJTJbpliRGdGhOkmT6aUsJwFAJt0gWHDiRr1sxmzKjWpuq5hjYKdFGN2Niw21jNpD3bat8XGySlOFl4YW4kENBayMzjYSmTR58XGiO9t2uGrRpK05wH0jzKqEiQnhjxFzvAEDhPNICGKhBDnh95Q/IcJHzAdXKlCpmWVxh/duTh9FUuCOr1iFd+4F6gnepE+9TL5lK+d7lUXyEOjZPIDNbEeiKGRZqWGxBVAva0nXNGyvcO64g9r62xu5PfMFLnPSblyPvilvlXhfGSoGmMIw09+i/05+RskKTAcvzFoPRPBkl1TuW2BIlgGP0cZWGKZ38zagd8gW6Nr87xRcRyzVpOkquecMPqzi0EPpPxTGYapAklvcoV+5+4jy36v+67d4UVOKB9g1DG3MgDUn1DAbSccWQYf/Z47E9mufm29a1xd8UuZEkvDAfGyncDRp7e71hym5/nwAA2Guf/eG41CG7/cAWCuujzboCzeBCKII6SGqzBkkmaqlvMzKrWWjMFNhYQ/za/QE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(6133799003)(56012099006)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OGjoTqc9kACFcwFdrbQE94QgybF65kgQSFUmkRTAJt3a2+2RgfzocpPJ9Ia0?= =?us-ascii?Q?2Uei0wiT1YX/PHIqdMtRX5f1qxPHkrD6JWYnin6F+IkD4PgHuXiPMt+S0YCC?= =?us-ascii?Q?tggfm5dJf18njJqVwg/ETjCq6IDRuFca8kUKs9jFPDaVLp4MTuxHPblntnTt?= =?us-ascii?Q?qg99C8EXEwQL2cK9Pz0Khi0tBfQq+2PdHdOeHlA9J36ADRycR5KKn6n59k4Q?= =?us-ascii?Q?XawNDtBNtv80vPSHw7ZU6hdBvBJUGw+LOm/5Zd42Le3CImWLfwWwBReV4x4c?= =?us-ascii?Q?L0qSFnuy7UnTaVwWagzhVzCTQJ44s5N88Q4mg4gBsmCqIv9f82qy9JgoVPxM?= =?us-ascii?Q?gR1qsxu/9exZn3zbCntjZGEtO85pGlddlXZruQyzpV7hgbxD4PgEBqSECvjP?= =?us-ascii?Q?84/5QYhDscAOkwPUHH0EJppf2DrJjBA8tyx4kB5dWXiK62MA1GcP+X45eA77?= =?us-ascii?Q?AUc5XLX1ZUR57lyaID1lY+lXVGElyXffO44qvC+mXuFKqoRj3gJ83BFlO23p?= =?us-ascii?Q?cZDJS8gkF3Kch15LNl+LeyzVqve6Dk3r0NbgKqNvLD+/abFJdKf7Xs9DjjHP?= =?us-ascii?Q?31Fj+UJOn7O5eBS8XZy+MXGQKAda0og6012js7sKL2+bSXcjvWX3nIzbEN3E?= =?us-ascii?Q?mu49lxxQlA/D82a9T5cMxeRoRPVput/6V12lV4UEPUpOobcXO7wmsAMqGEK6?= =?us-ascii?Q?r6roMYGarUhy3BvKcTZp8YZuJBmLicqLfK/kc6j20HToL5RLzCIUglTWNbra?= =?us-ascii?Q?nDwkZSYeaO9v3IsriMtBA+VNj5M8zpp7Ej0InHMla3CsWj2GdsgzdCR4TeXD?= =?us-ascii?Q?p+MzWPtGWLc2IBWQRtPHIZU3qb+aRtXDx5wsxHNCVd45+Bw8DEW7nPMiFy04?= =?us-ascii?Q?7uo3XxEIgwX6ZjZEt7xiYLi4cpZ/aXMGG4KlIA47qjy+hBFLZKoIfq+veKHn?= =?us-ascii?Q?+G/kK/ZoaLjaKW933m2qTqNKAFGKSyeJvx6DNxF878hdlvGNyzKshOtQn4EF?= =?us-ascii?Q?ThUoxnsaETFgtslg669crCIhQN705j2iiE/sOPicZJnOQ8UgcQq1NpDZni2v?= =?us-ascii?Q?oQ5aJGFmtYO9NDwVYGBmTjmsaSgDckzf+Qso8WNhh6Ci1o6yPZA/nWvjkcBH?= =?us-ascii?Q?tG+aMiVKhLKPWVXLat8ST3wnG5+onPjHEnrbhJGhuse1UP1i456JkxoHOJqS?= =?us-ascii?Q?FsKczhd3UgdouMNp4a+iyIYECq6lPanbX4MZLh1VZI4aF3QgZAetBwSWvvkh?= =?us-ascii?Q?scLSnxa3jGpmLXHmXAkAZRBQpdCU9GrIiiE/nH4AsG1VmBhUGQuQY8cZTVyl?= =?us-ascii?Q?kIiV/SwkiHYCGFAvOzkZNXp7xHfVRCzuugDk8Lz1XnNFpufr20HRY0ayrln6?= =?us-ascii?Q?ap00yXxbE9EECsfnvzZg4xsZHb2DijoBXEhBSz9fVbK6D/TuWi67uo8IxFpu?= =?us-ascii?Q?ySw7spqmjW8kx040j2hti/ntvmevuLF3ZfvPIhE00SZchAqAG1KbjadmnRqO?= =?us-ascii?Q?nvMMp55OP+pYUJF6Qw+df1Kg0kr7DpMCD55ONuqQr64UxbR8d5Lf1LMuhSFJ?= =?us-ascii?Q?7Esm2Drnvgmiy8XUUWvOb3sakWmqH+pFXg9d3+8Q3n1m3jCZgmGHzbm3JRMt?= =?us-ascii?Q?S68y/eDW7KUU0BBdnGGMffolLko6MEYNTNxZjxBOMT8u9lFMj4TXc7Nn68nX?= =?us-ascii?Q?COiQIaLA6Z5Zt4hgrQmDt2Eoe3hKRtUvqZmHW+7Z3v0rs/SKZNeLwX7zhxTR?= =?us-ascii?Q?BHa+JU5C4zk4Ly9iDb06UNINIvq/gIyN/g0kDdceCoDR6QQZWm+m?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 08f2bda6-dd7b-4a0c-8566-08dee3c0b971 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:21.8424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GlL1gmeso7dZtkaBYK02oxQwahpWfobnk+EV4UhbokLoW7NHEHj4QFlc4bAG+V7Yk670adtJlDdzyU9PeCse/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" dw_edma_pcie_probe() now obtains DMA layout data through device-specific capability callbacks, not only from PCIe Vendor-Specific Extended Capabilities. Rename the local data copy from vsec_data to dma_data before adding endpoint DMA BAR metadata discovery, which does not rely on VSEC. No functional change intended. Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 74 +++++++++++++++--------------- 1 file changed, 36 insertions(+), 38 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 23f09ee89639..46f16d7b6d51 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -390,9 +390,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, if (!pdata) return -ENODEV; =20 - struct dw_edma_pcie_data *vsec_data __free(kfree) =3D - kmalloc_obj(*vsec_data); - if (!vsec_data) + struct dw_edma_pcie_data *dma_data __free(kfree) =3D + kmemdup(pdata, sizeof(*dma_data), GFP_KERNEL); + if (!dma_data) return -ENOMEM; =20 /* Enable PCI device */ @@ -402,25 +402,23 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return err; } =20 - memcpy(vsec_data, pdata, sizeof(struct dw_edma_pcie_data)); - /* Let device-specific discovery override the static template data. */ if (!match->parse_caps) return -EINVAL; =20 - err =3D match->parse_caps(pdev, vsec_data); + err =3D match->parse_caps(pdev, dma_data); if (err) return err; =20 /* Mapping PCI BAR regions */ - mask =3D BIT(vsec_data->rg.bar); - for (i =3D 0; i < vsec_data->wr_ch_cnt; i++) { - mask |=3D BIT(vsec_data->ll_wr[i].bar); - mask |=3D BIT(vsec_data->dt_wr[i].bar); + mask =3D BIT(dma_data->rg.bar); + for (i =3D 0; i < dma_data->wr_ch_cnt; i++) { + mask |=3D BIT(dma_data->ll_wr[i].bar); + mask |=3D BIT(dma_data->dt_wr[i].bar); } - for (i =3D 0; i < vsec_data->rd_ch_cnt; i++) { - mask |=3D BIT(vsec_data->ll_rd[i].bar); - mask |=3D BIT(vsec_data->dt_rd[i].bar); + for (i =3D 0; i < dma_data->rd_ch_cnt; i++) { + mask |=3D BIT(dma_data->ll_rd[i].bar); + mask |=3D BIT(dma_data->dt_rd[i].bar); } err =3D pcim_iomap_regions(pdev, mask, pci_name(pdev)); if (err) { @@ -443,7 +441,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 /* IRQs allocation */ - nr_irqs =3D pci_alloc_irq_vectors(pdev, 1, vsec_data->irqs, + nr_irqs =3D pci_alloc_irq_vectors(pdev, 1, dma_data->irqs, PCI_IRQ_MSI | PCI_IRQ_MSIX); if (nr_irqs < 1) { pci_err(pdev, "fail to alloc IRQ vector (number of IRQs=3D%u)\n", @@ -454,23 +452,23 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, /* Data structure initialization */ chip->dev =3D dev; =20 - chip->mf =3D vsec_data->mf; + chip->mf =3D dma_data->mf; chip->nr_irqs =3D nr_irqs; chip->ops =3D &dw_edma_pcie_plat_ops; - chip->cfg_non_ll =3D vsec_data->cfg_non_ll; + chip->cfg_non_ll =3D dma_data->cfg_non_ll; =20 - chip->ll_wr_cnt =3D vsec_data->wr_ch_cnt; - chip->ll_rd_cnt =3D vsec_data->rd_ch_cnt; + chip->ll_wr_cnt =3D dma_data->wr_ch_cnt; + chip->ll_rd_cnt =3D dma_data->rd_ch_cnt; =20 - chip->reg_base =3D pcim_iomap_table(pdev)[vsec_data->rg.bar]; + chip->reg_base =3D pcim_iomap_table(pdev)[dma_data->rg.bar]; if (!chip->reg_base) return -ENOMEM; =20 - for (i =3D 0; i < chip->ll_wr_cnt && !vsec_data->cfg_non_ll; i++) { + for (i =3D 0; i < chip->ll_wr_cnt && !dma_data->cfg_non_ll; i++) { struct dw_edma_region *ll_region =3D &chip->ll_region_wr[i]; struct dw_edma_region *dt_region =3D &chip->dt_region_wr[i]; - struct dw_edma_block *ll_block =3D &vsec_data->ll_wr[i]; - struct dw_edma_block *dt_block =3D &vsec_data->dt_wr[i]; + struct dw_edma_block *ll_block =3D &dma_data->ll_wr[i]; + struct dw_edma_block *dt_block =3D &dma_data->dt_wr[i]; =20 ll_region->vaddr.io =3D pcim_iomap_table(pdev)[ll_block->bar]; if (!ll_region->vaddr.io) @@ -478,7 +476,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 ll_region->vaddr.io +=3D ll_block->off; ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - vsec_data, ll_block->bar); + dma_data, ll_block->bar); ll_region->paddr +=3D ll_block->off; ll_region->sz =3D ll_block->sz; =20 @@ -488,16 +486,16 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 dt_region->vaddr.io +=3D dt_block->off; dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - vsec_data, dt_block->bar); + dma_data, dt_block->bar); dt_region->paddr +=3D dt_block->off; dt_region->sz =3D dt_block->sz; } =20 - for (i =3D 0; i < chip->ll_rd_cnt && !vsec_data->cfg_non_ll; i++) { + for (i =3D 0; i < chip->ll_rd_cnt && !dma_data->cfg_non_ll; i++) { struct dw_edma_region *ll_region =3D &chip->ll_region_rd[i]; struct dw_edma_region *dt_region =3D &chip->dt_region_rd[i]; - struct dw_edma_block *ll_block =3D &vsec_data->ll_rd[i]; - struct dw_edma_block *dt_block =3D &vsec_data->dt_rd[i]; + struct dw_edma_block *ll_block =3D &dma_data->ll_rd[i]; + struct dw_edma_block *dt_block =3D &dma_data->dt_rd[i]; =20 ll_region->vaddr.io =3D pcim_iomap_table(pdev)[ll_block->bar]; if (!ll_region->vaddr.io) @@ -505,7 +503,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 ll_region->vaddr.io +=3D ll_block->off; ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - vsec_data, ll_block->bar); + dma_data, ll_block->bar); ll_region->paddr +=3D ll_block->off; ll_region->sz =3D ll_block->sz; =20 @@ -515,7 +513,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 dt_region->vaddr.io +=3D dt_block->off; dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - vsec_data, dt_block->bar); + dma_data, dt_block->bar); dt_region->paddr +=3D dt_block->off; dt_region->sz =3D dt_block->sz; } @@ -533,31 +531,31 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, pci_dbg(pdev, "Version:\tUnknown (0x%x)\n", chip->mf); =20 pci_dbg(pdev, "Registers:\tBAR=3D%u, off=3D0x%.8lx, sz=3D0x%zx bytes, add= r(v=3D%p)\n", - vsec_data->rg.bar, vsec_data->rg.off, vsec_data->rg.sz, + dma_data->rg.bar, dma_data->rg.off, dma_data->rg.sz, chip->reg_base); =20 =20 for (i =3D 0; i < chip->ll_wr_cnt; i++) { pci_dbg(pdev, "L. List:\tWRITE CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%= zx bytes, addr(v=3D%p, p=3D%pa)\n", - i, vsec_data->ll_wr[i].bar, - vsec_data->ll_wr[i].off, chip->ll_region_wr[i].sz, + i, dma_data->ll_wr[i].bar, + dma_data->ll_wr[i].off, chip->ll_region_wr[i].sz, chip->ll_region_wr[i].vaddr.io, &chip->ll_region_wr[i].paddr); =20 pci_dbg(pdev, "Data:\tWRITE CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%zx = bytes, addr(v=3D%p, p=3D%pa)\n", - i, vsec_data->dt_wr[i].bar, - vsec_data->dt_wr[i].off, chip->dt_region_wr[i].sz, + i, dma_data->dt_wr[i].bar, + dma_data->dt_wr[i].off, chip->dt_region_wr[i].sz, chip->dt_region_wr[i].vaddr.io, &chip->dt_region_wr[i].paddr); } =20 for (i =3D 0; i < chip->ll_rd_cnt; i++) { pci_dbg(pdev, "L. List:\tREAD CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%z= x bytes, addr(v=3D%p, p=3D%pa)\n", - i, vsec_data->ll_rd[i].bar, - vsec_data->ll_rd[i].off, chip->ll_region_rd[i].sz, + i, dma_data->ll_rd[i].bar, + dma_data->ll_rd[i].off, chip->ll_region_rd[i].sz, chip->ll_region_rd[i].vaddr.io, &chip->ll_region_rd[i].paddr); =20 pci_dbg(pdev, "Data:\tREAD CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%zx b= ytes, addr(v=3D%p, p=3D%pa)\n", - i, vsec_data->dt_rd[i].bar, - vsec_data->dt_rd[i].off, chip->dt_region_rd[i].sz, + i, dma_data->dt_rd[i].bar, + dma_data->dt_rd[i].off, chip->dt_region_rd[i].sz, chip->dt_region_rd[i].vaddr.io, &chip->dt_region_rd[i].paddr); } =20 --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11021140.outbound.protection.outlook.com [40.107.74.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10DAD3264E0; Fri, 17 Jul 2026 05:03:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.140 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264614; cv=fail; b=Z9YZKLAnUWQwUb5wWxayxRMDu3MrYeOq5PWCJD4NIokmqRuV/NiKhhPLwRy95P6w6ARKJ5vVLoYdCsJIfzaY8OIqCStttEgMTgU6aM+v+ZshzZ5Y56t8aAqgk3C6hBTuyYjvbx7hNDvuLwy9eGm1YUzT3QxsKE0I380HDBdkLls= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264614; c=relaxed/simple; bh=zCuBWNWYbREUdxHFZ2fYGhPxb2l5GSlWunKj63AuCOw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=SV5e8OnECDw8VAVllnhHUTzTybTVFjvVmS9d9VBHagWObnAx0TJ4QduQtlqH+I39Grvp6bjdG9GyxJ/PBFd5ZNH+WWVAg6bc8S4Od/X2MisFPWGOZ5uNqYZUoXUfy+7D1omURjN5zjNpQqwn2m4l8r5cLuVElhQwn6ZiCJzKxWI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=oymXdakn; arc=fail smtp.client-ip=40.107.74.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="oymXdakn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gUJYLAmU2B4vhgW5WM2t7hx1RzFbRwHoKv1/eB4+QY/bBhVYQM34dANG+pxiVj3vOQdnyvsbZfPh26P3X5I41hsoSnUgkzWoMPx743quBU/3Zcng6/dvrZDNBBWt2ITVB7+rCZUKgKpiEFZ3rYDiGn9qLlU1YowlonijOnmMmYCDZCcVU2WXNU9SFyEKj/Ktl3TvB0zmT5WxF9qiCO49+2lEDD4C2AOYT0Yimuhz0UPL5hgcJrgxHS9YEXEWHz1SlsyniyFHDFLAMWvN830pUHXtzyTU/kITuQUNpKMDlbadxbh3Y7hTsi7MHLGdWIuZ/6Rjq3NcVbXEplwyl87B/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=beHTmEG7TDc5hGDMXBLh0atGoBh3t6vyAJmpEPn+YtY=; b=Sf5K35pHg0AxrNqjVQSuB/u8Xi94kIuxpiyYvclUxKDpeREcpgn/NDDTIVq/zg3JdWJRJPo7xQi8cvgp0kqTjM9EhICcVqcDCgDN5JekusPQxvARFVnvpbvqeSjrgNK/XdKwb8F7QifMxEH+pVlvaQhKITIl9i8RXCXlgsUU08+ZMsxmJPjXNUk0JHSz7JWxDG0lQjDUromkbrHki4WW5Ospem0UaJTRjsMc6nRJhSmgyGxbeF4Sr+O0lDSUNv8F80gcmFOps4mcjX6cPkEyH+mX1KXWSOngrtmnHV2T14Q4Rk6d+a360xMjZQxBcvYigAKvo7N33RT564Wfl3jX6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=beHTmEG7TDc5hGDMXBLh0atGoBh3t6vyAJmpEPn+YtY=; b=oymXdaknxw/ieZPM2F7D6kINMXRT/0cW8kmUpyAa3EslVvjyYtKwPWJ6o3ljLkR4G7FC/ntUiBtoRE+AnLocPVPPLHDpnHFFNm2j4Nsdht/C1oNaOEkc0/9k64o+ztib36XNyqr4NepSWfEBdNicTGz4UWasPdGZj4V6pIY9nXc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:23 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:23 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 09/14] dmaengine: dw-edma-pcie: Add platform ops to match data Date: Fri, 17 Jul 2026 14:03:03 +0900 Message-ID: <20260717050308.2144108-10-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0050.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b5::8) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: d5d83d8e-eb89-4e61-350a-08dee3c0ba09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|56012099006|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 6tLg4mzSD7vPSOWIEMbNRXAQZYsKhNM9AfFz6xBYx07b3LfzTJr/76HWHhs3P+nVi9yQ6WexCV25DJsWFJpridmGEqasGG9fTByPOtVNUKr/ueZ26Fr89B98A2B+jBnSB5KrQ2Fq3DV0m7vYWiSkw4DzDJKbQtCykrcDegDGWGaYnRgyo1w/A5vxXkfXPnc4t3tYpB7zV3GpHYmDfUyh/tH2S3+Zh1THEvL/z7/lA1t+3u2Qhx9IWCsbW+waCFAAVxZ87xz1PtEmsBLb9LKyIrGoqn0M8JsU+SOT6oggj0e1OrBEH5PY17nHqW66p7gpaZt0Amg/fFzAZomIBnyfHn6TmPBeKeiz7n7v0iyEwKjykiOLCrqZ+P3B126SS533GZIo8a0De33zpeCejJBarwqWNleDSZYMLp2rsiYCMvmyDROIV4yEK8YS1edMV/3551A0n+4uVXnFii0ejrQy+Kz4ZDtcnawjCYGdFv9lJ8cs7mzoLw+RxPopNYXKPXXO8jw7qg/JQ+PB6AvZg5SrtFiar15duBuE1Mx6L4gaaSdcB7Wqz8wM34MFMKZsqv0mxu9OzyNfVHGRAcQ5q/Vt9BAGZuWU/ZtfbmbxQT4FJFgOI52qdhs4eCeHtTVoK9bjXsnG5y2sXLvu+HwvgMyBhsN4/AE6RenucIymQ+xdWAw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(56012099006)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q4li3OGbACetgFN1avRKz3/JxssZFcG1d/c6FJABmcvxxTk3N4h/tFwK+uan?= =?us-ascii?Q?YkoPrRQU4B+sCCvLc0R1cKBpgDgR0M8WkTO+7TzfiGpq1s90Hi5zZiTdjQNp?= =?us-ascii?Q?WI8ihLdzr9OKm/UScay/dRGomnbS+Q6vJPHp6I06uT0x+xoop2wLEE1hDMU9?= =?us-ascii?Q?766h3MlAxRJhThbEIhR9AjVCYclPRa9Fq7FCLJoadbAL5inLzEiUSqL/fgtM?= =?us-ascii?Q?vuy8W0XsdnPt7BxvUYjC9pdnhW8bpVlfR0bSfA9qAjxPQT+FoNuBXsIyLxKT?= =?us-ascii?Q?4xrVIfwCmtF1GH3kVuNQQ+qqGioKv4phqoNF2UG3Q0DKA+bRMecEdy1+TudU?= =?us-ascii?Q?G5D0B+qSRlFCKVxjTKnuKPQyUDe+n1KNsQ2zpSnP7tUN43tDNOk7eKcrKcKp?= =?us-ascii?Q?S3zMprI4Qr4gL0zEasWuuPvP0uV7atIgFTR71Roz353qSKDTTuoxwXlvlsui?= =?us-ascii?Q?RDTDct2oe41KwkBu60xDgpnqdkQ1qDJlhF4AeKhVg0NaSH3PrrBRxV4am6+1?= =?us-ascii?Q?2xMzwJ6v0EmyRgj1JkzJspPa40vm7/XEalMn5ruMWz66k+hRpkVd87mu6N8n?= =?us-ascii?Q?zhNR0OKlu6DCHWziJVGMEh3jCIiLC2LifJnCg5fNR6uZPGOIwBEg624QaBL2?= =?us-ascii?Q?UbpE18pxlQZatp+y3hZJVfmvLK47FpAThlNjkUapPfPegtughWt07eYmafU2?= =?us-ascii?Q?b/oRSNYslGB/4y6/49+iSECg4FowibdOsJqqdz0o0xrKfelnnfZ+AehXC+9S?= =?us-ascii?Q?rlYDhVCnOO++hd2y7NZVis+UZJ6GN0cECQNhXShCxNy77hshmeT4fSVAPbNW?= =?us-ascii?Q?rEExvsD0itHwogBePlNXd9Qhe5WFCagxxIV4oGXCgP0GsvnY4qG7tvSijnyF?= =?us-ascii?Q?GfMavZCywsMq3EvIVmARwPSx82zz/6is2+Nm/XPCcWAo6XL8UXq/JRDas4KV?= =?us-ascii?Q?RpL9SpqCbeXWZvWiqYKEJaiMk+BhAeDbZIJ4GOOK/yG2AqStlvZ4hWsOy2J2?= =?us-ascii?Q?2cPYu51WFcQfyioYDFqKm9eCTE3iwyZA0tPnIdChFmUdGwXbDr/LoVw2d0VW?= =?us-ascii?Q?IaC2XOV2d3NrsOqUQbeUZ/QAIjN5909/1RUVvSz7s4gYyfsn5TqbVorPJ6ZS?= =?us-ascii?Q?anmc3yWannJdM44PMY7U1VdCk0Jbd08MTIX1ylBCNC2FP8U1aAsBccvCw5iw?= =?us-ascii?Q?1cb6YEZRAc3VgQW6Ds7L34QTWczjRTGfcleXVRsMb2bfzcASm6SM0FMcyeu4?= =?us-ascii?Q?4WQavz5SBcwqet9rETIjG5Y7q7ejtGSn0CniJoKPYO8y2cE749t+konuhzrb?= =?us-ascii?Q?TBJ2qZVKfX2ZJxSNGDoP/NFqvVSJFmEd454mm2KyOXD0QjF9jgUaCPR3iNED?= =?us-ascii?Q?51A5+H3jQPdKUuaqojswOoBcJu0FBB6KTDvYxhx8Tdh3bYAiLxThQtYCTrXm?= =?us-ascii?Q?LC/Z+NAlBc4k7VEjEYqbNmjByjkeiLegLLQyPExTdPi8LiPmATqpKrWC7L6x?= =?us-ascii?Q?k8V1XqmEXE49YLiypr/RJS1t7nK3RCn6smNeC9/AbT5RdbV+MJI/UjVHxyN+?= =?us-ascii?Q?6rtesN5/X5clBGsKEa/4/GFQQs/WjtrKsfQ8m2PmatKl/BZOaHirKjcXrc4B?= =?us-ascii?Q?bWJPA5MCuOIJAQadGXglbY52fk8SM9/d3J2X51eyQLF1pcBriFqxkb+D1YYi?= =?us-ascii?Q?317ajChSXjbyL2bVkzp532BypPltZUeVys51dQKAFZE5J3lOIVPQJ7eIficK?= =?us-ascii?Q?pwg9aOKhchElwhJg/P2aHeMKpPUUep4F1qthVHhFfmJhZ/hv45W3?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: d5d83d8e-eb89-4e61-350a-08dee3c0ba09 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:22.8550 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HSjtqkLMbKuwPE2f8mkxX4I7tJnihS8V1+G+2MMvGlNEA2ExEDj2PDkj78Sn58RfMu2cxyHUvOaXzgvVBsYcTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" Move the platform ops pointer into match data. Existing EDDA/MDB/CPM6 matches keep using dw_edma_pcie_plat_ops. No functional changes intended. Suggested-by: Frank Li Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 46f16d7b6d51..531d1227a012 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -78,6 +78,7 @@ struct dw_edma_pcie_data { =20 struct dw_edma_pcie_match_data { const struct dw_edma_pcie_data *data; + const struct dw_edma_plat_ops *plat_ops; /* * Mandatory callback. It may leave @pdata unchanged when the static * template already describes the device. @@ -403,7 +404,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, } =20 /* Let device-specific discovery override the static template data. */ - if (!match->parse_caps) + if (!match->parse_caps || !match->plat_ops) return -EINVAL; =20 err =3D match->parse_caps(pdev, dma_data); @@ -454,7 +455,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 chip->mf =3D dma_data->mf; chip->nr_irqs =3D nr_irqs; - chip->ops =3D &dw_edma_pcie_plat_ops; + chip->ops =3D match->plat_ops; chip->cfg_non_ll =3D dma_data->cfg_non_ll; =20 chip->ll_wr_cnt =3D dma_data->wr_ch_cnt; @@ -596,17 +597,20 @@ static void dw_edma_pcie_remove(struct pci_dev *pdev) =20 static const struct dw_edma_pcie_match_data snps_edda_match_data =3D { .data =3D &snps_edda_data, + .plat_ops =3D &dw_edma_pcie_plat_ops, .parse_caps =3D dw_edma_pcie_parse_synopsys_caps, }; =20 static const struct dw_edma_pcie_match_data xilinx_mdb_match_data =3D { .data =3D &xilinx_mdb_data, + .plat_ops =3D &dw_edma_pcie_plat_ops, .parse_caps =3D dw_edma_pcie_parse_xilinx_caps, .flags =3D DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF, }; =20 static const struct dw_edma_pcie_match_data xilinx_cpm6_dma_match_data =3D= { .data =3D &xilinx_cpm6_dma_data, + .plat_ops =3D &dw_edma_pcie_plat_ops, .parse_caps =3D dw_edma_pcie_parse_xilinx_caps, .flags =3D DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF, }; --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020109.outbound.protection.outlook.com [52.101.229.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC074375AB8; Fri, 17 Jul 2026 05:03:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264617; cv=fail; b=Nfagxl9r71SF7f3/WzDAit/t8+9auziUpuMSQodS3M7B5gdBAE49xP+/zKvfTZ5sazNxKwEUKmIhnDAkk/stj5jIUMoY1UABdmBTZHedqazb60/ZjQCG6rAgKXOWLVv84IcenaJe/DDjd0cS9dQyLKCsigbL8/H74L3oOEu2KMY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264617; c=relaxed/simple; bh=qgzI1MvZ2Vh4WDykfhiQ/LtCwvOEPlNuKy30oHu0sqM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=hcFNX65SZ+iEhvHZ6pzEAyycAzW/LF8EWZ1MIl5mx0A95S3DPfZ62EaaaKgNAKPhF51yh4pPhyZ1oFabSYk5S7jjsQRY1f9I+ZphWhNeeNs94SF0IQrv8WbFXk8wHbow2w/kRSui+sID9oL0FWrujrBdhO89keyVOuaM9aCK2rs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=uCbPxsit; arc=fail smtp.client-ip=52.101.229.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="uCbPxsit" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ye/DDJxKN74WB1dUn4azFccALDLJCRQjdJMU5MwcEIEjFCVD8Vnt7QLrhswBqZq4qySzqHkVHxqaXKgEonez+0gVI5VPG2suCxDeitGT8b1dmPtS70lbAugjjltsnV8R36MyJ1V1K1RX8rb45htH5RRiDMyL5JavoDDuY899JXionVR3m4U85TlYCmT92qUaer0ydomx6pEsGHS1LadtCWKGfuGBSBvsQfmNV4HPYe4ryn2FLQVsATtGH+JoH6glEeS/khvk9u2roaL7OIETO5CceTbtdThOHM960hFLHFlWbuJDmfmF1YK5SAPYfJsWuIStu5eVURIh+XGHSCnQcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yRF5/zvWdNtDPYBA+iSYisZ21X2Ycx5idGuaytAorQc=; b=cDU54P4lDPwPyBj9Oykh5lhGlJqjh5++SRJWFfgcsGWOOWp59UbtvYoCTkknWi68GvlIGKG0JcB6w3EsmBghPKOdi7eOd5dNsB/3EJ5bTaZu27c41kI4Z3/cQFrLtSdp4fy30ktQftpOCnDqlXvBYFq/X039IC5SZ8K9+vgI4KBRkGXh0W8nbcUxmZ7XJI5Q/RnR4/RJv0wQXrYLWyGwCF6HmjIfOjyMoh+viFuthBs/0SGJApiTg36R2z93/xGp+gzY6cUBy2B+btuohYEaafIdGjx4oXULumH59H8S2hvL+ZyzsoUztXBF0q+LBVYHoXGWrv8plGzjnehRd0FnCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yRF5/zvWdNtDPYBA+iSYisZ21X2Ycx5idGuaytAorQc=; b=uCbPxsity4N+XgQXLwRnLfF/BhXKOtbixBxoZi3abD0/iz5NhIHeLfeqO5EeFPSrc3CYleRLdNMKKzVIy1QR68pi3FVaxJYYIGahyISRE7Umb4rCow32XsQpEFjdEZsEIcAKepFqR9IXhRALGrlJc9bz21OcFfA38/WtULMpy/s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:24 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:24 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 10/14] dmaengine: dw-edma-pcie: Add register offset match flag Date: Fri, 17 Jul 2026 14:03:04 +0900 Message-ID: <20260717050308.2144108-11-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0058.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b5::9) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: fd135f1b-968c-4da5-a057-08dee3c0ba8a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|6133799003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: eIcEkUSFr5XiaIzAPgv4Ypx/tUYuk+aJFqUYeYDDyTMDUchvXsRTuZ6Iwtm1kAh7jtMixOKdzjFz46fOfLOq9pnSqj6gCpNQ1BYxzmMA3R7I17mfTbnJtSATo4NwWmduw9DfYATKMoKmtpiVcr7AZWzMkOgu4PS3k6xapFHwEPF5jHqih1jyUBglmU3CG/Z8BfBYgaj/AulTnzmAwhGxgYAsXzPXkRJdxwAHcYlgZzmHs5poQ+/QFLD2LlUTxnQqTGcvjCi0kM4GZiOFv2+KhmxxCAkHOsBXe3oD3jmk3A9Mzy0U6YrwoH00UZiLHR2uUvCeRSRr1p0IDt3IITCGQjh7HxMIwl+Qc/zJH6Yy/3vGQvJxIevIL0AXJv2oUr/y7Szx9SjMTeaTF2L702NET5OEjdTkdY8/43FtYoWJtxbCA/hfMDjMihJ5Wb1kVISe/j9hlyDUgq4NGbwZcne1SUIXwhjHhxe/lAq2Bx/wa4rOExODuN8CtYMphbot9ualI/XLGpKLcKpqJPKr5u+/g4kOcFNT1HRk4WmdOY2XkDlpqQbX67RZRA22S0jJepzxQ7FMh/CHUjUmsK8N3y3nbu4loi+c6PAPSYXHxbDlQ1y/7fgwnqn6vjilbPpWx3EuQzuKIDbllowZ9NcwAKs9FAcuPaSHSnw+P2uERE9fLkI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(6133799003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OVaG2F8TTkzvW09KhQkY86mxzSSc4HBkWYdYyrK6ov8vze7Bk2IEbTeqH8Ek?= =?us-ascii?Q?WmWbuUZFxggFTBWjeI+UIh8oQtO5IV1WEgAOEK5GsZimVVWwdebYf4cps3rr?= =?us-ascii?Q?V2Z59YfXLueWK6/8e2oVuqt8zBdLzDqRgbQWxUzsHPw5R5zQd0W70240toX2?= =?us-ascii?Q?ltZPdtY0Q2gYNTypkH50+GemxVUFB4q2oi8SgCtX/wdjtMKYgAlY6RbcI2BJ?= =?us-ascii?Q?KEsOO9Yd7b8nwNl4C5SUsC1yLi5CWpH4oTjiP7EzawQxlZ3MxOav8RT+8Obn?= =?us-ascii?Q?GZPkadePJ2Q35ri+Vs+nCnt1vvoLG63geotaLNIb+Oem8Szo5V5XGl0GXqcW?= =?us-ascii?Q?OsaZh5H0MjnDUSul28Of8ctmqcoEQmdpmZY2qVz97I0ausVeiza1mkkrO5r4?= =?us-ascii?Q?x944ibVRVeJ1AgRvGazL2iUVugBXXFVSqdoWTBUGZs5mxEbyjte1DlOKqNuN?= =?us-ascii?Q?byPF7jVDGxvuoA2v3krgY9y2EkpAPQxXk6rg4raJ9DwVChSEnTuBMQ4mSKMe?= =?us-ascii?Q?+WjuLZ1zwb8uekJkqdaWV9jLlAvTTyTNCeI9aPWTQzDmdNA+pyXhfjyOljdm?= =?us-ascii?Q?6KBQ7zuPBidjoGxJRzZPZrgVuemTg8yF76k/DSau20saiMjtgIHX39vIjNN2?= =?us-ascii?Q?Z5w2O6wKZdxUqzKCex0y3ULHFiTApmKq/2+ALY7gjt/V/M+aFyB89mJq1CuA?= =?us-ascii?Q?EUGvUeZCAIYvJA7RYoaszKeofnkVGYcDV7rPf5w1lF2a2RDKbMEALKaevVhO?= =?us-ascii?Q?h0RBIo3aism4qsABH3KynEiPUHO/EOXWrVaKvaPJYaI5GrtvbLy1zp5Ib+09?= =?us-ascii?Q?rVgqdJ1HgBvRMyKBtlrIwkHUqouEEb1dENZfGSYCSlRzgUhqSfMnvi0GJ69H?= =?us-ascii?Q?4xnuDTPO9WWHaZhfAi1lj0W2K9xIMGrpFO4OH51UlqXmCq/UBz991szpWSVV?= =?us-ascii?Q?DSiXrVeSELPyyM+XX/zcCQBT7/lqO5H57kHRdPhsyunghEZ1I/rXa9dwJLpH?= =?us-ascii?Q?0gYzEyWIxpfvHnWe24EacQcmxSGG/gjfyV7BZgG8W8b1hbUW8N4HkxGudFt6?= =?us-ascii?Q?4ahGhNIkAY26bY8qwEWAU0Fuva5kO6rTvGgVlkBtTG2QFAF171/bZ0jSwTK2?= =?us-ascii?Q?UdmnSbGghZgAfvpUqfybT1wzV9vRm6C7L6yheG4kq9kWnNKXt+BakVZU30n8?= =?us-ascii?Q?8fEiYl/MwFmX4pt4QsEU4i4VIE7uxP3zyFU8T4G+81jhS/o7lmcYoVZ5V6fP?= =?us-ascii?Q?oG0CpHVvNp5MvXiCpLRB4YNJo3cBIVddCu6Cc6NcbBbq1VXfhSjI/SUerzMu?= =?us-ascii?Q?pB5bP+F0l01QDDpQKMR8bUMAYdMAfezHUUTuLPEvmAdYz2QVrDInL+uZhA3H?= =?us-ascii?Q?nLs8AhGcf7+UEuaxsb9lZfKTpjG8ZL7+TQpFa58bWJMY/9tXOAREgX6txBOU?= =?us-ascii?Q?V8evr+DhzndZfJwsGKVj1hPXNUwDZQokorL+6PjdV7WTFg0NUHRA1U44nKSI?= =?us-ascii?Q?guey2AEoN1dSRgjcxsVwEe8dYzA/y1IFm+bw+/bO9jy6FulwHgGOWDNDu1Yj?= =?us-ascii?Q?K7m02BKsxy1S/F24pFvVt2HQzkCgNmi3X/0ZOSsN3BFDibiLalVCeiSLRqz9?= =?us-ascii?Q?k3YihGJAMxrPFEUhae7vrAHR21FLMXpT1r405d2WXhzuu0WKztpY7FhTtXG6?= =?us-ascii?Q?q09RJWnH/zwAD1AcwVaemWIMc1rxAKt51338om3nGVERqxFSS5uEtzTB+3jr?= =?us-ascii?Q?Qd5fCIRLWsE1WUsN1Xs83dvkpstyVGvrc5fLKPPo3DLwpbbBX5lF?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: fd135f1b-968c-4da5-a057-08dee3c0ba8a X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:23.6895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HCpytiBx1XjKm81Cv/JkeawZEljvfV+UlcbJdS72aSim2bxRC0KXIpRpVAETxMODE1CaiHxdy8/YSl8sPaT2Nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" Add a match-data flag for devices whose DMA register block starts at an offset inside the mapped BAR. Existing Synopsys EDDA and AMD (Xilinx) MDB/CPM6 matches keep using the BAR mapping base directly. The offsets handled here come from static, trusted match data. Later metadata-derived offsets are validated when the endpoint DMA metadata path parses them at that trust boundary. No functional change intended. Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - Fix broken commit message. drivers/dma/dw-edma/dw-edma-pcie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 531d1227a012..327b59828bfa 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -89,6 +89,7 @@ struct dw_edma_pcie_match_data { }; =20 #define DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF BIT(0) +#define DW_EDMA_PCIE_F_REG_OFFSET BIT(1) =20 static const struct dw_edma_pcie_data snps_edda_data =3D { /* eDMA registers location */ @@ -464,6 +465,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, chip->reg_base =3D pcim_iomap_table(pdev)[dma_data->rg.bar]; if (!chip->reg_base) return -ENOMEM; + if (match->flags & DW_EDMA_PCIE_F_REG_OFFSET) + chip->reg_base +=3D dma_data->rg.off; =20 for (i =3D 0; i < chip->ll_wr_cnt && !dma_data->cfg_non_ll; i++) { struct dw_edma_region *ll_region =3D &chip->ll_region_wr[i]; --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11021140.outbound.protection.outlook.com [40.107.74.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E4DC3750AF; Fri, 17 Jul 2026 05:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.140 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264622; cv=fail; b=Vdy/xtriBqLqjyKRlCcxNQLSq5mnOr0U6oHH0EOUHfs7FKj5PWCbQsSHHw6XwYkvtorcl1vxDOOXS4zXcwOLpFbxRsX/R0bHeHqQhVQpaDqjTv9UQOQAee7SKU8q2Y+eWzd1mnSvFIwpy9gsJyf0qh60HquGMCp9w89tsTgf6QE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264622; c=relaxed/simple; bh=owv/XFZWqW4UVHzCIEj6MkGm3fL/jO9k73rFEEukeN0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=LFX9Qx23+ZsIw+FDCWhPE6Scc3gd2goGbpgcDVyrphZpAOPpuuXw9vf0oKHL8rBHXiKIZA/3Wz4dyro/lqweWTZrzRlrSXbmDiWcbVrVHnTINXOkOig+rjUCMFnOw1gFKvMWlFLVfqsr5LN3CzXzlQB+Fg/37dqRsjBT1OVexSQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=vTtw+QtW; arc=fail smtp.client-ip=40.107.74.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="vTtw+QtW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TKg07UB12nbihp5xxCx5Ho1XpzEJVaMnOaTEQIALqjEhlbwkDu1+kH+bX6cTEV3azl0+CzZ8Mewoi4VB0RiwV5LfRzyKgGHDsUl40LDlQTd2nQy3fFSqGE0eT7Q6Aaycut/bXQQMl8sjOZVFSbaMdnLqXrRkv9Hnn5FhN8xuH7+tJ0IMFtQ2+NFVng9w4+zoxOKQLXCylWto+dteB9O/Zi2AUMNwDRMMvgpPaVVhgJgqIv5lLPdcdlOmUTgw+XatpZ7+7sRdFZ6E2QnP39yGKmLvDXOnBxk28gMJ8s1LoQbpnVTarYwMMFiwQM05iw2MjiEU95PARQ8Gkcvq+eSalw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zQcDlhu1mlkWuXIhvW7859gYpQQYRb+AtcYAopgJC3s=; b=t4mNYOOB/BfiOoaEu8Z8QqXWYiiZ//i/ArGIp/WORjt8esVZqvigfrBrzFRi+2Suj5Fqq64sNkfBBeLhw3DJYdCJQg0Tq4Qz0MztHqCqMdbpYsSQAtnXV0qM1zmcPqBntvjqipNQ4TNEv/q26MRek0n+eFIO/9TXkFdeqgjMlzYo4S/pnZROznHw5kEMDxDluIzzaQdLsD0CqSX8hJs1JEJ5rJbCuV+DwgENocUaEAsj4fcEhO5zy4PN4YeGDqg1kESewxL2SnU17KoiLPk0iIOMMqv56F2INISQiQdNi5/LTmHDS8NjF+sRguBo5g1BWytqWcPOsTxgQGcygkuC+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zQcDlhu1mlkWuXIhvW7859gYpQQYRb+AtcYAopgJC3s=; b=vTtw+QtW30JwsKtsFSs6uJPYzj3JGowTCGvsMY93UYGPUgOhkjVLwD3phti7RaYanYwNPSXyrHJ6f+CQ4VdXQRRUEFUAnHPckb5KNU5UTKQB4rQTipmtNdSZaYUNQsEd1K6FLZv8TPr/bg6E4r2aEj3wAXpTKZJjKn3ikM+16J8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:24 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:24 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 11/14] dmaengine: dw-edma-pcie: Factor out descriptor block address lookup Date: Fri, 17 Jul 2026 14:03:05 +0900 Message-ID: <20260717050308.2144108-12-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0092.jpnprd01.prod.outlook.com (2603:1096:405:37d::17) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: c48dfc4f-c168-4f62-3f31-08dee3c0bb10 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|56012099006|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: +AYrf96QQXnv7pWsfPN7BI4RcjcDbvlSFH/IZIPmMuRlWzqnd1GpfJRHeuRgCzvvBGs/1WE8bDksgeKTAsHPOzAytNYLfI3k0hVVcHDGmiU1TXtKfwnE64wIJRkylzPlxWlD2F/PYFb1IehQNsZ5cH7bJpwNtctYX+tWtRlD4u9z141SPX+XF9JgRzKV7BlBjGTIGapZZ1x7HMG2VplJn4PolgCjClkrI5gnGenyTpwkuRq93eXVTqWP52pRpK4ryvfzvM++TeYVvmn21k3BqiKP18bZboLxsuf0HEt1aXS9QEEu/GDjOo5my7prokLbljrivwjFwQb4jLo0XYAW4YYrz2iSJ/4hNZfaP6n65jET+Y8lRgVXGKY1uDno48eVZTS+9BJeXvmVZKn0PObsalPei9dtwu2lHTW75h4vQ+Ky0zdPB5zMS+Tz0nnyBAqeos6hTpq2cIvCd+KnLPz7T+8sCLhVbXlsztr43EdXUOzfpngh3eoGh25WqDl63up411mDm/V5bW9ENnOgZZNBLC1A3owsTTR0Y/wf/sFfO/1rNyHv8U58nY6cF/auSzTdmjc64CQ4/CXJtn+VGLVayVDQKcnpt3+6pnbsCiA/hu83fpqk0fpy5qS9XoKjrqTUEnwvEzbcOvujnU18gzTwZE4xtUXMTvKGEomLzF2G+ls= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(56012099006)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qgRi5HAiERCycdXJD8HxdorZsCoQ8yJDWajsaRr8eZare8jeyi7k94OISj2q?= =?us-ascii?Q?M8klNqFMdI2X0DiV/mcwTYsCR1wSWnL/xLnjzSf0kA7pVElsrbR36AcwHRGk?= =?us-ascii?Q?eWh4k3mIYr8s7n22xHZ3NXXagZ1CuaTDReBAt7HsryFTPiKCL7DW+N0wTx13?= =?us-ascii?Q?arb+0X6dFvPEoSgaFE7mF9zE+KtxcxFaGoSL51Vu9eMU+55cbeX3X6uduort?= =?us-ascii?Q?4XaX1tfUzmhREVTP9xPZIyJnOiUJ6+QXOP2mE3UNXpbbqI4iLsNUNAS21TMq?= =?us-ascii?Q?yV4s34p61VbkjSbu64HEN9o/bxND1A7sEoWqZoOmi5V2MVEF75QH1PP3iDQh?= =?us-ascii?Q?5xx9bVp/tcd4Ig0I8jY3HztF8PnK5N8jQh0BIljk0vufb3aQOOGghgJdUTpw?= =?us-ascii?Q?pXAJTj495rsrAUn5ZlHujgWUrJI5hNQQ80N/Sj6z297eeU24o7umlUd1+VW7?= =?us-ascii?Q?06IybJh56wGm4A2uNQ+MmQrgrGfFGy75ED5Cjg10S8ChZC4Tgvb07Ct/1vQk?= =?us-ascii?Q?bc8pgPAzEDqyEY+F1Few4/AHaOSAOrex+m/JfY6HKvttUcmFI4B5wOh7Sjb3?= =?us-ascii?Q?aOTJTRsdrJX1tF0JP9fSXWeDO6rhzbTwrh6269AX2xs0EFaypdYb3Zvw2wCy?= =?us-ascii?Q?o7eCbPeZ6PBT4+bfyyYdX1Gt+c7vGIyg6yIhZv9Vl9NfMzY4ZB8GfuhtvbP3?= =?us-ascii?Q?cL4IYdr6yx4Wgmo1MJ1fo3haOQFgAvu6WFb7YJacEstQwlwJza/ASUFIit8K?= =?us-ascii?Q?//t5l7AwDr4OGDjzGNQ7iXVNVT/bMvoZaFBy6M3ULrK3VWolif0dWvp+G0rx?= =?us-ascii?Q?pDPeWoGYT7+Chz8fLrjK/MMGGsPzuqAd6OdAKzblbrGW4NXNfYEkm6cJZyOr?= =?us-ascii?Q?t2Izxwh+qTTXpKX9DVm98bBaBs61b1Zmta86XS5ThZMIXyYIUN5NiWvfodZy?= =?us-ascii?Q?uA+Zh9OHVXH7nN7sFxTs83wG5Y36uun3AWjrCmTdxNj9kLdqd6mXUogFfxrw?= =?us-ascii?Q?Fv23NS+MnIeLXsw9TuZQuWPG4/qfDxE68i88QH1ZPGTP0b4na7srJoVGKIIM?= =?us-ascii?Q?whrk5l51n/SJgTdktUI7P8T+JM1xzOJK3sYQozKbSAS0HOYSwT6zMo+1XCLp?= =?us-ascii?Q?XLZEzqWdUdsqFW1FcvUYODqZ1k+znxEQGaYLD1w0vdEXV/MD+wR1ZDf2IeQ9?= =?us-ascii?Q?BoS/BxWz5YXJ35IHLqWborARoNzNdUQR1qwr9b56GR3H9E3L9tAopH5oNw8t?= =?us-ascii?Q?FXu4bivNgcXiSfCI6U/Yefe2qiPBHFBFqYVt0NDo+R/AgGnODf32mBVjYk1V?= =?us-ascii?Q?C/6vZduHpTSihi2AQzmVHs4ds2VIA84MXu+oVNtTtAnu/kmmDZvH3ONEtpkV?= =?us-ascii?Q?kTbbv3UUNHJQpwrLQoMMUhYn1llnDN4NEwh9nyD8flIJLON8eWUhHZf+9DYr?= =?us-ascii?Q?T9WUbQ+bdKbNfj+H/bQGLmmpD2wv/zHk2vvj+RtSMq+aFTBmq+Ky++78Wpbd?= =?us-ascii?Q?gKWulhCnQEv2Q4CiH7eDFtBL1+iN+RzHoJNBPkAZiVZkzTqGervLLl6qSkjM?= =?us-ascii?Q?z4JP3GoRPUrhmsKjZmdS7/ohy25+b1H8qAWRRqEl0Xp3f43m6CoNbb+upT0y?= =?us-ascii?Q?3X6nqBDQWeik4K8ML0M/ckSkKjbKy8B6nmkB458oG6zkkAeB0ZIODdvebidS?= =?us-ascii?Q?Fg5fI2bhsIGmH4aLTzy0h29Sp1WA3Rk6e4umj66pehEdiXW1UtV0I+n27kWp?= =?us-ascii?Q?AdZ7+1KCwMpx/rM3Lvm/S+qcPbxu1yTZyom5+wI5ag1sJo4apU1x?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: c48dfc4f-c168-4f62-3f31-08dee3c0bb10 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:24.6101 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nGKN6bfqz2QyKYgUyeOfEm/Jxf77x1Y0I+f3eaNMA6tw+EcFW+662TwnZ/kxLoJDreUhsKY0TwJfiuBkunslTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" Add an optional physical address override to struct dw_edma_block and use a helper to compute descriptor block addresses. No functional change intended. Existing Synopsys EDDA and AMD (Xilinx) MDB/CPM6 block descriptors leave the override unset, so the helper still returns the same values as before. Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 34 +++++++++++++++++++----------- 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 327b59828bfa..a5d65cc9706c 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -55,6 +55,8 @@ struct dw_edma_block { enum pci_barno bar; off_t off; + u64 paddr; + bool paddr_valid; size_t sz; }; =20 @@ -375,6 +377,18 @@ static u64 dw_edma_get_phys_addr(struct pci_dev *pdev, return pci_bus_address(pdev, bar); } =20 +static u64 dw_edma_get_block_addr(struct pci_dev *pdev, + const struct dw_edma_pcie_match_data *match, + struct dw_edma_pcie_data *pdata, + const struct dw_edma_block *block) +{ + if (block->paddr_valid) + return block->paddr; + + return dw_edma_get_phys_addr(pdev, match, pdata, block->bar) + + block->off; +} + static int dw_edma_pcie_probe(struct pci_dev *pdev, const struct pci_device_id *pid) { @@ -479,9 +493,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 ll_region->vaddr.io +=3D ll_block->off; - ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - dma_data, ll_block->bar); - ll_region->paddr +=3D ll_block->off; + ll_region->paddr =3D dw_edma_get_block_addr(pdev, match, dma_data, + ll_block); ll_region->sz =3D ll_block->sz; =20 dt_region->vaddr.io =3D pcim_iomap_table(pdev)[dt_block->bar]; @@ -489,9 +502,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 dt_region->vaddr.io +=3D dt_block->off; - dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - dma_data, dt_block->bar); - dt_region->paddr +=3D dt_block->off; + dt_region->paddr =3D dw_edma_get_block_addr(pdev, match, dma_data, + dt_block); dt_region->sz =3D dt_block->sz; } =20 @@ -506,9 +518,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 ll_region->vaddr.io +=3D ll_block->off; - ll_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - dma_data, ll_block->bar); - ll_region->paddr +=3D ll_block->off; + ll_region->paddr =3D dw_edma_get_block_addr(pdev, match, dma_data, + ll_block); ll_region->sz =3D ll_block->sz; =20 dt_region->vaddr.io =3D pcim_iomap_table(pdev)[dt_block->bar]; @@ -516,9 +527,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, return -ENOMEM; =20 dt_region->vaddr.io +=3D dt_block->off; - dt_region->paddr =3D dw_edma_get_phys_addr(pdev, match, - dma_data, dt_block->bar); - dt_region->paddr +=3D dt_block->off; + dt_region->paddr =3D dw_edma_get_block_addr(pdev, match, dma_data, + dt_block); dt_region->sz =3D dt_block->sz; } =20 --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020109.outbound.protection.outlook.com [52.101.229.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4A29377000; Fri, 17 Jul 2026 05:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264624; cv=fail; b=udrTB+LyHiddBKCu6T6LdKpFHLMNgI4E+azBy8eyUY0MD2SOHR/l9Prv/sDV0Hv6e++hCIekagmlDmaxf8Abxed6vlzvaE9L4SjV9eiOV2pzt1HyXECZJCQjXa70cF9TpSAwttur0wQgymp1CmOUu06icfSoR+cdJ6RI14FeNIk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264624; c=relaxed/simple; bh=+aKfuugYCCzrlF6KtwTOsKvztL/15yv/3l9b2/kT5ek=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=VlxvXq2ijNZV4jPX/FyjgkisreeV9Y6T3Uj+iMlgJvFRTdA0apNWPIZ1t61rXwv96wMKhpphrB+mJ20FJ8kiySioOopFlafFVgOhDrtZ8mdHiv68LsZi4w71Cjc+/XWx8+2i1c8caXe48sTKCfVPLNS7gJKe8iDy1i4xl4+Kt+Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=mZf8xuLe; arc=fail smtp.client-ip=52.101.229.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="mZf8xuLe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Nsng6G5hzWGPwIVmHT6kh/OHs4gaXe95fXLSMkFMt6dCEitxOxVNXkRF29LtJqcWHoC1C82+RfqPnSIa87fEUKXXEQnDLekOwSIipd4JbjD2ATcXlxSCocvGpBgFhhdrf88Q3IhMEmwdmHPs5sRULL9TNtudFHM+VbmtRSd7zz6ddXZ5ZA8a/zOVEEmjx1qejpHVbLjCAOVbNTEZTpBRT+NO7nzXldaCDh2sESXPRVHmXgFoxRObAea7yZGfNY+50UL90odn/ohsDHMwaT2Qqx6eo6mrMrmNmI1wJk80wWMPda0o6eyWSJigTRFzzjZqze9zxTf/SWnPDehPH+724g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XNBSEkweaoA/K+rbZBs9psUiCbtAb1DAxraHH4SX+g8=; b=CFA+KmEfZQKh1ktYIwYhZZyMN9S82E0uqfVEHiWEF/k71awRgMgg0siifGaRg3WcccdJtKcLSTZj7OOLESozHDKi0y3avOZ28Izgqk0dK9pXRUouyZdz6dXVLm4a5EBxw6qyKL0R4WGjAOMgDd2o/Ds5gcE6SbhP1MSX0fYPGBoriv580cKIX0xSwrA8GCWK8mNe2YWHsHZQEdq9UNQR+F1HCrddc9O2hDAyTAudQPDoMcVnRNTqaFLonL+xrsEGkWrRl1QJF/IaGq7FU8ajvlAyidatWpwoOVAPqGf/bPQ60AL1/tZVQFJzRl5dv8xciM2MelzrHyMeMTfj8nzYfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XNBSEkweaoA/K+rbZBs9psUiCbtAb1DAxraHH4SX+g8=; b=mZf8xuLe0H+9wg2pxG+qRCwuzcmNPcCkBosbd1w57oKzJ8dbnM5z3uapLcKayOK09EPQ2Asp0Cg4tOgEJni4qrL3pFNtga+ZDZFofIldmsUPFSuQz5KakOxHXoJoSl/AUGyue6lsZQQcAdnhctarMAUKz5MGtGJ5HU92eSmZY8A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:25 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:25 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 12/14] dmaengine: dw-edma-pcie: Handle optional data blocks Date: Fri, 17 Jul 2026 14:03:06 +0900 Message-ID: <20260717050308.2144108-13-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0327.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3b7::20) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: c63bacf2-a0bb-4b32-f38d-08dee3c0bb98 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|6133799003|56012099006|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: MaHxDZSOgrdLLFnPwdYlsnTllAymIBak1cme8DQtTgU8oQer2oD0p87Z2vjHfAndL4AvyRVFyk4v6I74LuqYCn17a4st7jA93fqSM1vq+flEEm53qOurZkItJdsv1HDLRMxq7Ekfbnka8M9GLKDTSELeVVWuBPPIfnXDAWfXvN0JM8DHhXHhggXr7t9nzixnN7Y9laQ43MFcBLFSJGIIC9KJeM3ffqWolE4NRoaSmQocBYOYiMzK63zzvGl8ERETBgpnCHlK7umVNh28kH8jRHYFRLqsRm/2zbeLNcQOud0jjXEla+sO894sv4G6lVHFsOOBWOSzstnmDAXCQJsFYEB8Q14BQfSXv3cD6d1hbjMu53sTwD+oTGNSZr4Ie3SuJtvROVkdoex0+GZ7P21VJwkQ2AsN8rHPijsOfB87aJIoVLtUD5T66J6cZ87KAe8Hw4voI5N7Y4ocrQAUUu3n8dXJeg6SUcurrsEmAnUjAdmH8R92tLqKSTYUxZRP/TPXZKOpDxooqtVLBJyVdbmuD3Gp7KXYjr4W2mzkEnsLWInA/YZaicIJinDleEPtYlK18IHqfZMtu9xkLS1fyDT27t5g/wRhUMFXCxwVrgcC32vRm1JP272rRubBqs+QbDKOrinCdFWtXmdD6oMPX/R3KhHEuBeS9yXPDosUo7BfjPs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(6133799003)(56012099006)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TIG5UsGj4Zl73zjGUtdJzsqechn/nXNO5NiOwwmDZuWGHOPrl05bGwJM5LLE?= =?us-ascii?Q?odU3GALmCDR8yPX3LEBPrljcUnSfFWYMYpx2J0Maz5Z3p2N+PhwNs0iBXjOV?= =?us-ascii?Q?pFE7yfR79ieKhriS0dtzeEbhPb4stULXJDCRIXReY+mHdY3073hjHiC+GvmR?= =?us-ascii?Q?DKRtxByuj0RYJA4SVH6HWx/IQpnZuqWCQEAM8ILP83jd4gESZLUAR5NkkOgE?= =?us-ascii?Q?EjQtFeAUeBXAl+vUZvJT3lX3IO/Iga2JhBtfTHpNUf9GQWZDPYmojGy21pF4?= =?us-ascii?Q?7MpL5PyFSXVq9DZKnYX4HPHmR9jdz777gLAo9WrmNX/+DNBkSV6Zgh/rrU7i?= =?us-ascii?Q?/HQGW4DETRY5Jl3mxDRor/iBnLjOngoetzGGmDTjULIUZzIinKwZETZPCqjA?= =?us-ascii?Q?ULj0KOvxcOiUq1lej2w/zWUehN5KEPQtLDqDi3PbpidxIsN4dfgHO0urc9Gb?= =?us-ascii?Q?CG9NXGQbqc9ZNL99dYTyzVtp/jhxkuh89EfOZjiZa1ybFrykXEujjJOQwGz3?= =?us-ascii?Q?6RMUqOFMbP6QqYY1Dw0JQoFKdUokJ93mubLgjlh75r1XbIHfJ09EJbhyBD9Q?= =?us-ascii?Q?7mhLEnEeNSVd3PlgNJFfM3FZqVGP0kWyav3PkCsNLv6IrWLO8Lxe8+k0uE63?= =?us-ascii?Q?Ily8lzVXoD5LmUGdUF1KfWVIwAUhhHPpRvCYwTBs3LPsL/FoQQ4JoHFi7exw?= =?us-ascii?Q?R5UBWf6Vdvhs0iPnHxxImK5kQHf5HTM8zE9vCgzilKDpNQNJUvxn6FHgDAE0?= =?us-ascii?Q?wZ4KY1UcHfIcjr09pjs2oNZHc1UrMOmPNyyNcYM57+i14rHlxZvRi4AZCg2q?= =?us-ascii?Q?SP+LwCHI84yuF1lF6U36yhgWMYEbXrLcqNFJDC8/vi0IvcxE2LcMd9eupdyJ?= =?us-ascii?Q?PjdYnu3nXoBMBkhe6l55wj7VQZbq+OZ20s6Ddyu5AyfR4tfyx9d5aeZMtHIT?= =?us-ascii?Q?3kVfnGg4mG2ohASU3nSHD+B9P1/enPd6k4g2JgfXB0sMH87/ot7hfPwY4Qow?= =?us-ascii?Q?UYJirpIbo7PZy7Cre+uN31J25jEEKrbqrzvbmPgV1TMW9oDJG6S51FWZr7mk?= =?us-ascii?Q?k73zjSwef2BdSEiiycFEzYT2W3OryH7b+lxBWFqrIDxvGoM4CIf+E3HIjkWF?= =?us-ascii?Q?5F4IzorjUcDhWAHa95YuW7P1i2WUZfpHvUtW+nYOVT1kFbiZYvcO1qvhXa3F?= =?us-ascii?Q?lD/ah+WjJwEWZKSXVuA/sBI+ZlUVPlDfJlrSWsBil0WLMWF2BtkhXl8MCAVR?= =?us-ascii?Q?d+048bA4hYQcWvBKIkTcIU41WIsuOPF4onBub/svz+CL05WBKAF1gZ7IqOm4?= =?us-ascii?Q?wrd7M+oOS9GliVhP8RYiAzLZIie8UdlxJol45f2BJ7t4SsNdX0L9vGbke+uI?= =?us-ascii?Q?LDuFb02Zfhuyg6wawxb3zBaRxDBRlXcb/2I0vSl1RIzKNeg3VHhw9WCTNMFQ?= =?us-ascii?Q?BGSVR1FbIegwxXi+sRe9F6CFeVMd4kNVlRJZxCZX9Uk9BgjUDfFNbi499VTE?= =?us-ascii?Q?k+k57M8QkymavoqjOce/pKZV/40n/AtOhvwxcTJGOKiJq0EpLcVnaK1nrqGN?= =?us-ascii?Q?c6BY1TpdDKmJrgnVJ0PGFbx0k/LLdMQW+fiGhgJDNlQlsSPYcevwUcSMhZH3?= =?us-ascii?Q?TSULzXMSRIfT5O9LS7WIS9hbNDae0Y/kGj1MKD6zfVH8aH7SrpJlVzTMT4Vx?= =?us-ascii?Q?LNCO6K88Hcbx6l/if+OOPTHrlJL3erPXuP061WjsC85gu3XbPXu3uAhC5jMI?= =?us-ascii?Q?E8wUSA+DEPdSphdeQePLRnkAd7oIv2wUcS6BcevUzaUtGIGIVdRZ?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: c63bacf2-a0bb-4b32-f38d-08dee3c0bb98 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:25.5361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TA95i8BEIkoOhfe5byTred5gjUE/1OMHedQbcOVhv3tU43Y0nPiaTt6NcqCCBJCg1Y1QDmtjoqg/kq2WUvam+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" Skip data block BAR mapping and debug output when a channel has no data block size. This lets future providers describe channels that only need descriptor memory exposed. No functional change intended for existing Synopsys EDDA and AMD (Xilinx) MDB/CPM6 devices. Their static channel descriptions still provide data block sizes where data block windows are used. A zero-sized data block now means "not present" for future metadata providers. Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index a5d65cc9706c..8c4d1359a545 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -430,11 +430,13 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, mask =3D BIT(dma_data->rg.bar); for (i =3D 0; i < dma_data->wr_ch_cnt; i++) { mask |=3D BIT(dma_data->ll_wr[i].bar); - mask |=3D BIT(dma_data->dt_wr[i].bar); + if (dma_data->dt_wr[i].sz) + mask |=3D BIT(dma_data->dt_wr[i].bar); } for (i =3D 0; i < dma_data->rd_ch_cnt; i++) { mask |=3D BIT(dma_data->ll_rd[i].bar); - mask |=3D BIT(dma_data->dt_rd[i].bar); + if (dma_data->dt_rd[i].sz) + mask |=3D BIT(dma_data->dt_rd[i].bar); } err =3D pcim_iomap_regions(pdev, mask, pci_name(pdev)); if (err) { @@ -497,6 +499,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, ll_block); ll_region->sz =3D ll_block->sz; =20 + if (!dt_block->sz) + continue; + dt_region->vaddr.io =3D pcim_iomap_table(pdev)[dt_block->bar]; if (!dt_region->vaddr.io) return -ENOMEM; @@ -522,6 +527,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, ll_block); ll_region->sz =3D ll_block->sz; =20 + if (!dt_block->sz) + continue; + dt_region->vaddr.io =3D pcim_iomap_table(pdev)[dt_block->bar]; if (!dt_region->vaddr.io) return -ENOMEM; @@ -555,10 +563,14 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, dma_data->ll_wr[i].off, chip->ll_region_wr[i].sz, chip->ll_region_wr[i].vaddr.io, &chip->ll_region_wr[i].paddr); =20 + if (!dma_data->dt_wr[i].sz) + continue; + pci_dbg(pdev, "Data:\tWRITE CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%zx = bytes, addr(v=3D%p, p=3D%pa)\n", i, dma_data->dt_wr[i].bar, dma_data->dt_wr[i].off, chip->dt_region_wr[i].sz, - chip->dt_region_wr[i].vaddr.io, &chip->dt_region_wr[i].paddr); + chip->dt_region_wr[i].vaddr.io, + &chip->dt_region_wr[i].paddr); } =20 for (i =3D 0; i < chip->ll_rd_cnt; i++) { @@ -567,10 +579,14 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, dma_data->ll_rd[i].off, chip->ll_region_rd[i].sz, chip->ll_region_rd[i].vaddr.io, &chip->ll_region_rd[i].paddr); =20 + if (!dma_data->dt_rd[i].sz) + continue; + pci_dbg(pdev, "Data:\tREAD CH%.2u, BAR=3D%u, off=3D0x%.8lx, sz=3D0x%zx b= ytes, addr(v=3D%p, p=3D%pa)\n", i, dma_data->dt_rd[i].bar, dma_data->dt_rd[i].off, chip->dt_region_rd[i].sz, - chip->dt_region_rd[i].vaddr.io, &chip->dt_region_rd[i].paddr); + chip->dt_region_rd[i].vaddr.io, + &chip->dt_region_rd[i].paddr); } =20 pci_dbg(pdev, "Nr. IRQs:\t%u\n", chip->nr_irqs); --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11021140.outbound.protection.outlook.com [40.107.74.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48EBF3264E0; Fri, 17 Jul 2026 05:03:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.140 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264625; cv=fail; b=gBEsFjCN4XjDZLZAuzU+kzFnv+4/UhRQ9L+psD0H8aTLWUFccWF7GMEuOWrmA6OqyiD1EXszihhG754wguOPC/s0GxfoxETwHbdO//7MgpTcx3D/DcBYZnlxJY0ZeE/pUOY8u9iV6L5Qh67x4dfEHIiTSRAo1KZ3tCpJxfv0uV0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264625; c=relaxed/simple; bh=33o8slbGwr8xxzDhCzSqNKpKnSZjtWvPyMjCzqk2LEY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Ma03BMDCesu22MRqMzZ8yC0TH7c67ikQf6+ZOGgS7ARHtmZH/1sunKryMiFBEx4ACdLPziF9Z6EATBt6p+Xp4WA4obeNzgIh1o+Ms7HfX+FCVI7gjekB8uSAGNo1EzW5886JbNBPc3zKxNValmMagZLT4Hd7tNTqoodfKFAaP5g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=FUiPDG1/; arc=fail smtp.client-ip=40.107.74.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="FUiPDG1/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UtMiQIrgua842RFreIxBGtcYtwzkfhsfU1Rx7BydE2H7x9zLKrMDK5JNboOFJ/auvfSrxoejBQBod7TXZuO9SZnKjsriV6UR/VfVr80k+/oORdi6Mz0t0UNEoTxFdgWraSpoM67PpyBmzGC0AJFuf+PwAkl4R6akSqcKoNlt+DZATBM74YEwC0VoXmnu6rDfnpv/jTcil+KEHI9sSEQSVuDaowowjgHjHrQjLj3hBP3FqYyQAdPIZ+Uc0ih58BrIHq+M7gUjJDVSArVPHsxEgltd7F3NhgUd3240GaI91nyjGj2BHosmGQUtjPfMEQ/1lGoNnaEcJ7I3netGwJ+QfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ESfJ5Xu9zOE72lC8DPSx+daZi0sNyccbQgG5e4RwRs=; b=eecAmSAP6gA8iRenjyhaN45APgVZe+6IS0KeQhEq8iVPY9lxxA+jSqYFhNLjjU7HYpXHOM9T8/9Je/3zb49rQFU0/q3G+UptWpwc4rturdq319jvNROiJJZYTWnOEVn952XWRddYYlSIp9Ed4Cfa6AeO8q6bdabEEcAiIlCKd7WjL4YGOtdOcEti7CXRiHR8IY93yQUPn3kL9UYi0uYtrD9UU/ypv/eE9kyAve/i3X1DMEY6neBq5ak5IWxbdxDFeG+Wfhr2sOX1EuPyScBg5eyBAhJ6ejEZU5rsv6vlnIy6STNJ0BazILnahU1aiHa/D924o0C8xGOiPtBzQ3nygA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ESfJ5Xu9zOE72lC8DPSx+daZi0sNyccbQgG5e4RwRs=; b=FUiPDG1/RCJd20WwsGmGx1BgnQjMrZOlKWKrcVzsq+ljA7J4VjmlIg9JSuAYb9RuB3X1gq6kJfadtxicQ0Ae0oCp34vqBE4b34oKi4KmQgiCrCQcjT+tKvw0XnZlymC8LeK5ZQb83sJiDg63RsqVfPPGmUAbdeQ35+NmzkhKUE0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:26 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:26 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 13/14] dmaengine: dw-edma-pcie: Add chip flags to match data Date: Fri, 17 Jul 2026 14:03:07 +0900 Message-ID: <20260717050308.2144108-14-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0323.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3b7::15) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: 5501fa50-ba9a-4d30-71a8-08dee3c0bc38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: AiT8F5iadMSejWYlUkI3muwwYq8/xjXIeHhHO6pB32zj1Q0U6JIVvDHL9jY3Wtvzex6eTCf84plzhdAaYB5nd7CQvlcAUfhqArOq/iUvOtlreucGE2omoO55fgEsGLNGJIr0D3YTnqQ0VR+t08aY2iCUG/QR5eP6NvABJbYM4o5RB8A3V2vhZeI8RYftZ/DAxDZBFYPjcC5Ll0IaIwS58l1amcM4i6VdT7HbR+k1RgXX+FhnKu7x57jy8VeHbqaez10QYtEJhgwf6bzFSK6RpjAxi57G6X7Yt5NTjY4KLPrPB6UgZCOL7Dn8CRAYYin0GK4qJUwTv5krHja6FLDfiXkQpHAseMaBbniZ9/DbwLFoloD+nG73P18tyE621cmqOYRkILOwH7dmjf5BRcSW+ofrhkAFvyPwM0i/VEy0GskaK9xd3Ak8e++DRTfE0gZZRJZj5xX3/bfpT09ptIqxTHFswC4JeJOZ5wnfa0tiD/Vp7ddICvzTpUPO1Ofzo9tZRlFowPYvRT6vNv3JbAEezTvtXjSmtad2jkfeq7bx0+ue3apGjkRP6xprvujFJU+iVwsRXygs7ulDSohLVjfhwpDt+NLIBSRtAUDxW2ueclAXJOnWQOAHeoSp30mPFgehpfElWCce+mH7H/jAYmsvfYtd0k+2+mNuIlmcf8f+Fx8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EKJBtG7b12pVinkomSWFE8DGI7QRGKYPpsvc6P3PJcTI6/+g0E8xTAxSYG5z?= =?us-ascii?Q?moIy/zAFQARcSk7bvuXhvzTXGMa0NLKDPDG1RtoDRgtV5LeHZEAvKfIG5LZk?= =?us-ascii?Q?iiRN9iDzEofKOLvpWVndx3oTjQ3i1QO8jg8nuGmDKApjnjvEEOTWWzO5qLbu?= =?us-ascii?Q?1bW35POEGSvNOUVLb9REUWY79A7c6Ut7ZbL7Y4ZUpvcQTGvofW4Dp3wI/sXc?= =?us-ascii?Q?dA7QJ6YOEyUHXaqPQ1PvXb2Lo8tpzc7AqDed5oNXOWrgvD1J8OETI0zAiY2d?= =?us-ascii?Q?NcgwXcFpITwYfu5WLm7M1RnM38sa88kPJiavMQHcpKUv+FvqLAFLHi8rAUD5?= =?us-ascii?Q?eJclqjVaLIux27Sy5wT6vbwBZ37cQzpXBoAHpgugmdrMRIFvBEoYEvwxQYqU?= =?us-ascii?Q?/sq+SGHhLz03J8LJDn5v+mfHygbO9Lm6CUjmzrWI9fN1F3zjQRFz5WTVJn3F?= =?us-ascii?Q?H0d0UoAxZFJTOOPsX8/c8h8UWGfRlL5lUtS2H0NCeb+AbzsTQW+vTNKvKGsB?= =?us-ascii?Q?wa0nJVQtR+ZvF31+n0pqmRXrEsPKRRN/+G2jRCbuTnGPZtT0E6g1mUy+VS1O?= =?us-ascii?Q?kb73kGDRDTciBSiLGbm6ozaL01Bo3TMjg4vFApG1syZR3Cc1oTedaHvfAsXN?= =?us-ascii?Q?nchFLf/lbX6NfzDGNE7bGrR4mD6ewP26R11/l9sjfd8H8GHpoorhgF6caq/u?= =?us-ascii?Q?1l7lTIVNUVuQihdxx4ZomC3oJZPmpnGGTGpkPOOzk0HkU55tIzYeywhx34bL?= =?us-ascii?Q?G+rWNu3F7QqE4UofrcwXZvJDwgIAOWAZjAEaeSgiJ/QKJ4vZ8hJMGObgJ35f?= =?us-ascii?Q?Yv/b32e2jbJ+lu1TEyGugzFI/0zvvCUd+zu3D3bKuhjZEWxEfQjWTHDKCb+W?= =?us-ascii?Q?yqPTaIzxhZY7L1dD7EuqCoJXlYHqkJtmhxoSEFflASwFNU3O5k4VNI2OmS8W?= =?us-ascii?Q?PKo0IIN0G7maerrfXqOJLTu4l/28Ds4AuKFUJcjOCmbZ86q8/n5N90UktJ6+?= =?us-ascii?Q?q1uYKSnT2+gq4bZtw40Otm1ZHV5vwlBa0mnLcGkZd2vYI6EpXY5R7zD7s0nH?= =?us-ascii?Q?0HnH1oXx6xcWkXyU5B46zh+PnJWWh0G0EgVtoMW2EKTWFtDgi3aAuUpUwXGv?= =?us-ascii?Q?yp6hoY4EQr8i5uHXvK1NOA7cq96N7fNtQY+zKF/YJwZf9SRfsKIV2Euz7v/g?= =?us-ascii?Q?ptCaf3olEtQkI4MdchsegcdKUf8zS0zE0FjS1MzY4RcUCnxO+qAGe/YV6m0z?= =?us-ascii?Q?h8BTRE2q7wJtmBoLtaJowjVchG+3MlbK2ZK28ciTvdU8Jfw6M/1Z5pj8d26/?= =?us-ascii?Q?NAXaHdcCjL8z0c1R5QQoDBI8bw/CWFCWBCqQcrDzVDIsS+frPUocRRSyZQug?= =?us-ascii?Q?jb+alEtCB+FApvzbI8cpTPq6cqM8kV8E87/KXsHCChAzH5LzRI8ZvJAWk/cW?= =?us-ascii?Q?YvdMRMTSQ0IswNjozUtJLaUYXMAewsCyB3xPVjZCcsmcXgT8/jsonREzZOEi?= =?us-ascii?Q?Gqk5Uz0uH24nBD6Z0y2qtwLvQfnbcYtl1rEsgdfVAOXXQMHvy70nfczFN3H9?= =?us-ascii?Q?WPm64mYhcUz8LuX0pIPffsNE1sgVct3rdyk5+Wl2zyTDg0OqtNO9d09uXogI?= =?us-ascii?Q?9l3aQEqCMAEyM24CPIeSroOD7m76/JxIz7XhEeSZpRFrPq5gYSeb4Jh4/2b6?= =?us-ascii?Q?/Ebyy+qfhfOtrsycSNat9cuMTtjDsZxFU8iWP+GiNoLIrkM2WGRX8ksXFCyC?= =?us-ascii?Q?XIZ2hqDxL4DPEFkiGi8o6fEAfiDuP3Bvb0kTgFQBleHNkPmJgvwH?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 5501fa50-ba9a-4d30-71a8-08dee3c0bc38 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:26.5770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aXoSU/LN/XKXyubb97eEcq2HpA5cEGlnqsNgcRmflUjfI5FjZKtmJwTRYV06l0kjiM5c9XVbw3BAjbvKIGOfQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" Allow PCI ID match data to pass dw_edma_chip flags into dw_edma_probe(). This keeps per-device policy in the match data instead of open-coding it in probe(). Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - No changes. drivers/dma/dw-edma/dw-edma-pcie.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 8c4d1359a545..7f96e65ee274 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -88,6 +88,7 @@ struct dw_edma_pcie_match_data { int (*parse_caps)(struct pci_dev *pdev, struct dw_edma_pcie_data *pdata); unsigned long flags; + u32 chip_flags; }; =20 #define DW_EDMA_PCIE_F_DEVMEM_PHYS_OFF BIT(0) @@ -471,6 +472,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, chip->dev =3D dev; =20 chip->mf =3D dma_data->mf; + chip->flags =3D match->chip_flags; chip->nr_irqs =3D nr_irqs; chip->ops =3D match->plat_ops; chip->cfg_non_ll =3D dma_data->cfg_non_ll; --=20 2.51.0 From nobody Sat Jul 25 06:09:49 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020109.outbound.protection.outlook.com [52.101.229.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0920835F5F7; Fri, 17 Jul 2026 05:03:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264626; cv=fail; b=UqvW7QfhdOq20gsXTVZ/qerpNOtQ8ZY9w1IFzFs8tw4wXeW1RQXCNmQIjWbQD4Wz23bef0D5DXcPEHem+h668ue5mdrd8OJ7FcQVVi5xNrerEHGwnR/boBxeNkRl5w8SBYkxbpQvoQSMrcxi02X27B9P7OZyCta994N6cNu9nNU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264626; c=relaxed/simple; bh=cyQ5KMngmOIxT0Zkc2y1r1UsM8CQaobRg1D0HpjrlRA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=jDuCh9jxQVQ6yx64syQDIm0n9rmK6bmbZ53ZLaYND2/XJinY0m9zRcLQzaZSWHsheAQVZ0CyHBcg3FO5BwC2zWX17dv9BN6o57Mf7pZNhFF3l7VHDwRjNbhO6qmbwRTRCT/PJMrX5btydTHOQ+XyKQ1ASDUSbNWwD+owNe5vAw8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=NVYJji4K; arc=fail smtp.client-ip=52.101.229.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="NVYJji4K" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q3Tsgiv5CfmQmx6vLsNte+56mTISbodGKwycdhZpuAIe7eyAbowyLGzmmpljPgEaPYNdawppBkTSATpD3j6+u4Vss0HqS7YmwfbIQuJyc4EOAbC12kPtKYI0ljoH0HWcTLbuXO+eG4EsV2REteJIvNx49PQd5SDmDQZkmJkbiY41oOanHv7ec0rjuIq7AIGsY0Z3AmLQtMTyE3sLNfymUROIe8fBn5b/IjQCkV5mk1VvWMCtSy1wSQTp3CvuaRRVFSenfw7AbZOHAVycSdF6LN+nuSpXwI1VlA3iRJB3gpMndGL6Rf9eSHyIolcHVq0+THLWjNlOt3vwPL5A8nwhyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cVzypddBminPrstceRNaKa7R/1CU1DNw8IfZvvOv5/s=; b=CLmS7g1OKoqnF4iXrwvRr+a4bAQjpaPdt3lrKI+oxMLtg0JSs9Z9HwZMBzzQ0GAx5eZGGa09tcTlgfuqBXHbBQ7vw0wFLXU47ZJJ9KUvzT4Kxot0PZqWAjFEUAH4+pTCAHZJbTmOcEXmS4APxtA8pUZLlAhC+gYSMcNCqz4UfgQQz3FSjJs261EsGOMmZiASx/zfiPBqYbIe4mAAY1gwe1+zy5f/cWucLdyznSBP+cGaqd0v83cgSLtTMyYv+vumHudxOPJeVYDTppgBFX83BvCVCtnLGiKGCzpO4V6tZUBrpiHb9N2TiAcd4I+QQQVvq30KTQVUSibjgjXyQrb5Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cVzypddBminPrstceRNaKa7R/1CU1DNw8IfZvvOv5/s=; b=NVYJji4KGGfW5c+9QkrGwDq6RFLWEX0/SP2A70QELTtpqJs9Dy9hvqpBpU3ptaEfDpVGXMAz+ILzEoz09cMnlrb2YYhXetEku+LnDQlfEeMJJL8J/3fGoSR3Jxb0FW2BHu5J2MQ6YGiB8C7cgGyVqS7pIaaL2oIbqJBYnUcvFzk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) by TY4P286MB6313.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 05:03:27 +0000 Received: from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM ([fe80::2305:327c:28ec:9b32%3]) with mapi id 15.21.0223.008; Fri, 17 Jul 2026 05:03:27 +0000 From: Koichiro Den To: Vinod Koul , Frank Li , Manivannan Sadhasivam Cc: Marek Vasut , Yoshihiro Shimoda , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 14/14] dmaengine: dw-edma: Program endpoint function numbers Date: Fri, 17 Jul 2026 14:03:08 +0900 Message-ID: <20260717050308.2144108-15-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260717050308.2144108-1-den@valinux.co.jp> References: <20260717050308.2144108-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0083.jpnprd01.prod.outlook.com (2603:1096:405:36c::13) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY7P286MB7722:EE_|TY4P286MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: db2aac02-ac7c-44b6-0872-08dee3c0bcd7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|10070799003|366016|376014|1800799024|10067099003|5023799004|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 902ZZbLdSEU+iRvUjjGoP4WA2S3jYRL2fwA/uKXeF8J3J6/WL3UlcSmD9EY9Ix2m1Xelz4WDgLLGoKVc/yA3GfLL2nv5BaHGdPrBtPSIcPVKQpZGB1u1/8kuMh167DYb3Rz1uEGAk01yqKG2k27aHSbTCLAgcqvO8S/4hgLRKvxO/sAMjEi21fBor5Zb+Y5U7kWoOwNp5mhhWEhES5PX8hlpS9DZ4N2PEdOdkbgKznvKN9xG36vJHD3uE52mHTlXqvjkw3IOcutlJIOTPGA73rHfrCY5YRfNUb0r3nadVYT04GzuHRURXqc2NeLNAgbRSkMsfwqIavMoWdfbkSd1yMH44kS4sUIZNeEKAZjTdKPwXxw1Qgo8aqhE1wefsxXsn8KrZIFlDFqbbdrSFdVtsJhpnQbdnVxqbKmT1JEcki55D8T+83H+1yKtIvNw1pSHT7HUg7yoYfFC0LctjUU99olhK69ymgWbDypoyMWJcjw0nciLX10umnj+j+Msbqbn5IufxYP7wgZsFMMh3bykxlyIIcyl60gUMQ3Rn1w9dlyPm8GJJ/ixpZuCscsquXUXyIiT/sN2c3NvxC5i2VOWWr5sZBr8XoKyz82MUahVF+HdYDAvyuhBHFfyUzW6gLIPurbgaB/BDEA1Xe25KEehg1R3Idw9CHNoxvcSTjPCRKk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(10070799003)(366016)(376014)(1800799024)(10067099003)(5023799004)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8blzjCz+yKPskCSSfuv0JycH2c72kC2FWQ1i+J4Nmm+7yuRT8Mj25zyRthFC?= =?us-ascii?Q?nupw6Tmjq1a7Plj3B9mpnAo6OfKlSjnpQzqcose1cP26rajBtaqaFa98TKwA?= =?us-ascii?Q?pGfRtmd4GrO9GAWRklPuryIReg32NHRUhzWGiLxhQitQIrMgIcXwIjsJmnOc?= =?us-ascii?Q?xMmM8vJR41IkJZKiqZn5Pfp57b4IryWmH0RuMbtpPtoYtX6V7A49h1SlT+Ey?= =?us-ascii?Q?mexjxyuPlAXRW/CxGKycP9Ga2OxJW+8NnqKz1jXZKcnZcX3GDsueeaCywErz?= =?us-ascii?Q?ubWz/kTY0A/n2q/lwszm0VH5fUUYalS9GK7ddYqQfsOLob5/4VASit4PkR/Q?= =?us-ascii?Q?KFZCLmXokrWwsxp0bSBuQW6neMRZNh8Utobm8EYXgrHuAgF1vqi4oyqqtn80?= =?us-ascii?Q?pJLPQhkbEU2+5jtslmt1AHtX8HSJ54NNs+ZV5RNcbTRBBJPTKk4GItRzUx2W?= =?us-ascii?Q?pIkx00CORDYkJGqPSGTWWsAw1ynSL/12R4AlZHwAAhTNH8yNsRCzg+Go+23Q?= =?us-ascii?Q?e9MPvEDr3OwqOF0VS9UICq7hn4axo17KREc3mHzmLQPhSAcZTx3PQ6OkWgVK?= =?us-ascii?Q?FqwVkUrVDO3Fp/s1ZDWQSOD6pTgZiFWrMSXi0CHumSPxpMvQBGlL0YF/P0YW?= =?us-ascii?Q?Hq7TwBrM+OynMQ/VUEU1SMZ4E+5LmKXTHU0Bcsv3zYTFN2xfFn5Cq39WwBNj?= =?us-ascii?Q?slEPcBnNmObjlnWTRQoMpqxL8kDu0gYIC50A1QbLE0gYSUfj+zOwDqV4vHdU?= =?us-ascii?Q?A6aA9WbRvRUECZ8wBfqjP9PwpcjPH2Lz7oKQ/CojX6WBKG0onTIp169TljfD?= =?us-ascii?Q?e4/RRjJEb4Nwf3u2fT+UXtKSV7cevAAwEn1J+Zg+Pwo8xn/0a/gfrT8DbJh4?= =?us-ascii?Q?1AxTQP83cVU0U6kIKfGXeXyqAk/z/Rs277XnqI/eO3AxztVEI3ibH3athMRr?= =?us-ascii?Q?1DjnhXCUg66V9c03VLN/exhXCi+EUinaTz5qk/UIlWSv5fkp+/eSmxUPy2BD?= =?us-ascii?Q?uovd0YykOIE/9zN33zJQ8VSR05mkopf4pe452X2bj3gMvWuyhZ36iK1g1jgU?= =?us-ascii?Q?avCog68rz5Xucc3C9xwBBsP5N+fPZ1dEPrRlc1w0r2obdBYVacvEgC8mCwWu?= =?us-ascii?Q?FWRbs90j73jbMqvDX97DG3yh/1WKJZ74jjwY4I714iZcmxQQ4QYhe9DLGe30?= =?us-ascii?Q?dUgOzbj8Jzu2l87zLxotbVXD11oMjJXGjbB/cUFMeLoV7oI4s2OoZ5ZixRdy?= =?us-ascii?Q?1G+Igpp/bjY079ovy7DRxnG6M4JghtuW3akNawFntGv+JH8P4Uh3lttDny12?= =?us-ascii?Q?H40RTR/6oIy+SuCbGF/x66dds+B5nd4/HgrDOQ/DA1mpURUCLCRkX9ulFnwd?= =?us-ascii?Q?5gOvHipdIGc54B5wI4RCbJ96T8Hs3f95ObKzOvyEBXLmzmg+2jUrq9rxdL3/?= =?us-ascii?Q?Z2xq8ez8R7QjKJAl+0Dq9CdUVH9zNc+BDNT7RcK6QxAoACtyJzVjHWTIYsT3?= =?us-ascii?Q?VGzabphprGQV6iuKQgZc8/rw4GmjhWlfwkWmo4VwQ4MshiktId0smfiOf7S0?= =?us-ascii?Q?wlbyUBXmqmNEUBlV2wQFo/3hzUBwJQYtxZ2KsKtCz6sVmDIPZdMvrfpCPlX/?= =?us-ascii?Q?AhkuNKY7LIYoZG3jPoVw4WV4N2wEWqipxTDjFc/arxUTsHm4MBi9FxdVvajm?= =?us-ascii?Q?eT74VrDjywWvYftACG0vP4Fvt+FZcynkMThFHpKiqcGYa7iyJDDC47ShoWex?= =?us-ascii?Q?3KRScd6aRlbHnq859a/wsMpfNR82qbeJIwtn9sDqeWAOgz6zi/Cm?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: db2aac02-ac7c-44b6-0872-08dee3c0bcd7 X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 05:03:27.6235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dl6ONNiviCJ+ob6bkmYvz4aPRbzfW2tpc7FGSgxHHJLIB/fCDZp0x2nzSQGcsTSg6BCYbPXgMcyNcHnkJOwX8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6313 Content-Type: text/plain; charset="utf-8" The eDMA/HDMA transfers the driver issues carry a requester function number in their TLPs, but nothing ever programs it: eDMA v0 leaves the FUNC_NUM field of the channel control word zero and HDMA leaves the per-channel func_num register at its reset value, so every transfer is attributed to function 0. That is invisible in single-function setups, but once the DMA block serves a non-zero endpoint function, its requests must carry that function's number for the host to attribute and translate them correctly. Record the function number in the chip data (PCI_FUNC() of the probing device for dw-edma-pcie) and program it per channel. Endpoint-local chip instances keep func_no at 0, so transfers issued by the endpoint-side driver remain PF0-attributed. Delegated channels are programmed by the host-side dw-edma-pcie instance when it takes over the channel, using that instance's PCI_FUNC(). Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- Changes in v5: - Add Frank's Reviewed-by tag. drivers/dma/dw-edma/dw-edma-core.c | 1 + drivers/dma/dw-edma/dw-edma-core.h | 1 + drivers/dma/dw-edma/dw-edma-pcie.c | 1 + drivers/dma/dw-edma/dw-edma-v0-core.c | 10 +++++++++- drivers/dma/dw-edma/dw-hdma-v0-core.c | 3 +++ drivers/dma/dw-edma/dw-hdma-v0-regs.h | 1 + include/linux/dma/edma.h | 2 ++ 7 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index cef75da3f2f6..43f8280b5811 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -818,6 +818,7 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u3= 2 wr_alloc, u32 rd_alloc) chan =3D &dw->chan[i]; =20 chan->dw =3D dw; + chan->func_no =3D chip->func_no; =20 if (i < dw->wr_ch_cnt) { chan->id =3D i; diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-ed= ma-core.h index 1a9f1b58d2fd..3832e015aee9 100644 --- a/drivers/dma/dw-edma/dw-edma-core.h +++ b/drivers/dma/dw-edma/dw-edma-core.h @@ -68,6 +68,7 @@ struct dw_edma_chan { struct dw_edma *dw; int id; enum dw_edma_dir dir; + u8 func_no; =20 u32 ll_max; struct dw_edma_region ll_region; /* Linked list */ diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-ed= ma-pcie.c index 7f96e65ee274..07ea237577d5 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -473,6 +473,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, =20 chip->mf =3D dma_data->mf; chip->flags =3D match->chip_flags; + chip->func_no =3D PCI_FUNC(pdev->devfn); chip->nr_irqs =3D nr_irqs; chip->ops =3D match->plat_ops; chip->cfg_non_ll =3D dma_data->cfg_non_ll; diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw= -edma-v0-core.c index 3e9512a7b201..fa123fa167f9 100644 --- a/drivers/dma/dw-edma/dw-edma-v0-core.c +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c @@ -26,6 +26,8 @@ enum dw_edma_control { DW_EDMA_V0_LLE =3D BIT(9), }; =20 +#define EDMA_V0_FUNC_NUM_MASK GENMASK(16, 12) + static inline struct dw_edma_v0_regs __iomem *__dw_regs(struct dw_edma *dw) { return dw->chip->reg_base; @@ -160,6 +162,11 @@ static inline u32 readl_ch(struct dw_edma *dw, enum dw= _edma_dir dir, u16 ch, #define GET_CH_32(dw, dir, ch, name) \ readl_ch(dw, dir, ch, &(__dw_ch_regs(dw, dir, ch)->name)) =20 +static u32 dw_edma_v0_func_num(struct dw_edma_chan *chan) +{ + return FIELD_PREP(EDMA_V0_FUNC_NUM_MASK, chan->func_no); +} + /* eDMA management callbacks */ static void dw_edma_v0_core_ch_power(struct dw_edma *dw, enum dw_edma_dir dir, u16 id, bool enable) @@ -464,7 +471,8 @@ static void dw_edma_v0_core_ch_enable(struct dw_edma_ch= an *chan) =20 /* Channel control */ SET_CH_32(dw, chan->dir, chan->id, ch_control1, - (DW_EDMA_V0_CCS | DW_EDMA_V0_LLE)); + DW_EDMA_V0_CCS | DW_EDMA_V0_LLE | + dw_edma_v0_func_num(chan)); /* Linked list */ /* llp is not aligned on 64bit -> keep 32bit accesses */ SET_CH_32(dw, chan->dir, chan->id, llp.lsb, diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw= -hdma-v0-core.c index 77260c076cd3..fdb2c6fb08e4 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -334,6 +334,9 @@ static void dw_hdma_v0_core_ch_config(struct dw_edma_ch= an *chan) SET_CH_32(dw, chan->dir, chan->id, msi_abort.msb, chan->msi.address_hi); /* config MSI data */ SET_CH_32(dw, chan->dir, chan->id, msi_msgdata, chan->msi.data); + /* Configure the requester function number used by outbound TLPs. */ + SET_CH_32(dw, chan->dir, chan->id, func_num, + FIELD_PREP(HDMA_V0_FUNC_NUM_PF_MASK, chan->func_no)); } =20 static void diff --git a/drivers/dma/dw-edma/dw-hdma-v0-regs.h b/drivers/dma/dw-edma/dw= -hdma-v0-regs.h index 7759ba9b4850..2bbcc7fabb0a 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-regs.h +++ b/drivers/dma/dw-edma/dw-hdma-v0-regs.h @@ -24,6 +24,7 @@ #define HDMA_V0_CONSUMER_CYCLE_BIT BIT(0) #define HDMA_V0_DOORBELL_START BIT(0) #define HDMA_V0_CH_STATUS_MASK GENMASK(1, 0) +#define HDMA_V0_FUNC_NUM_PF_MASK GENMASK(7, 0) =20 struct dw_hdma_v0_ch_regs { u32 ch_en; /* 0x0000 */ diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h index f827f2dd5299..45f66fc523d7 100644 --- a/include/linux/dma/edma.h +++ b/include/linux/dma/edma.h @@ -115,6 +115,7 @@ enum dw_edma_ch_irq_mode { * @db_irq: Virtual IRQ dedicated to interrupt emulation * @db_offset: Offset from DMA register base * @mf: DMA register map format + * @func_no: PCI endpoint function number used by DMA TLPs * @dw: struct dw_edma that is filled by dw_edma_probe() */ struct dw_edma_chip { @@ -140,6 +141,7 @@ struct dw_edma_chip { resource_size_t db_offset; =20 enum dw_edma_map_format mf; + u8 func_no; =20 struct dw_edma *dw; bool cfg_non_ll; --=20 2.51.0