From nobody Sat Jul 25 06:09:17 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0CD732E151 for ; Fri, 17 Jul 2026 03:06:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784257563; cv=none; b=ZXXNz4oN/j4XztKXIsI/Fp32rnaSFlpDWYKT+PJlrfLMriByXEeTLFchL41LEo4MUy0yzrMzyyBCu+KMDfkS84nz4TGG/NVSMtmZIgobvr7JKtiGtmnM7HiH9cck9HD5e568aLFb/EuwbIZ3SE62bzB/W2L/5PSNpzmQp63JioU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784257563; c=relaxed/simple; bh=IVQpi5kOsSjc6nbKgnNr4wTB7eZdYdNqamQ1aOhbGM4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CuzT1g4lJzEF3HpAGQi+aoBD/9f9b6cjpzlraT1Ypk5UwTyYE1oeZ83rt2tgYHKFUFpn7MGfhey+DrExeyXOx/oB/dAykP3OwP6col87pOJaPNw32/tnfEIs+qyQjQrG4kDMV/CPUQNVybEcrAnNRzJ4t1Rw8B9QR3sV18xGpH4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kO6Z23b1; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kO6Z23b1" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-384930ca5e2so7203111a91.3 for ; Thu, 16 Jul 2026 20:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784257561; x=1784862361; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=mZVR56XOREeMXVCUwfvytwmladieL4xpwdBWK5Npchw=; b=kO6Z23b1eVbRdc74ucI94vhxYTXsLZAtfig0piFQT2GChZ65Q2SRB7z3wOvDdh7LQ+ PsbRvSc+hV/Rn5u4Qr903g7svgPqMneKMaf3b4ljPOzWWEqAwBdudiVYth2DKkQqiDXM bvUD0sZXL038DLgPKYwVae6jDEQ63daN4GLe6arnIXyW8z94r8DzXxdTe8L3QZ8CqeKV E3yXG/je7a2F45HRkzsbaU35StnVS0BJJg6Cafng8qyKGT9TRmS5SDnDRPQyf0YMt3WQ VDb4Tfat/ZBH9jrttk4m7uTTDDTzmXO5trBEc31bMq6E4Te/8buqBF0v8l24YdLhzrw1 WPNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784257561; x=1784862361; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mZVR56XOREeMXVCUwfvytwmladieL4xpwdBWK5Npchw=; b=iD0b9bGwlKobOZnPXQYNo716RM/xeT7P0sfTojfnPPWQ1BYt5izFImOUt9bpjfZbQI RAI30rilapRqvE0FzdolsXHKWOrnsbq83FBC2UDfMmdQI6J7+1n2Rt3QEuzuh0Z+qRDb CAoj62f23NsD0fArBw3Vl30PShiZQoSzojBbHpUHmiJypvo6V1Dx5FrPUk6/VobW3wLO TvByS3GMKWAAiqhw/bKcuG2hESkRWo2NQpazd/dAHG3EOlCOK4kug3ub1Hf8G6KHV68O FgC8rzHEuL/z1o/6uWKrDBvVIFZJTFNXPS30ovIPSZPmvkXWVniG5TZHAIwSMOEWvgqp 8NUQ== X-Forwarded-Encrypted: i=1; AHgh+RphJu8vOzKTTbOo647XxJd+1+0LzbpI/nzopvx1wFqpg1bVSU61G6nRMmZYWXU4oQuRYdpp3mtPpTtJ8xY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7SAo8PMuIXouRr7FWINgZ5LtESRywf2CXv9PnBjapWWmEDV/E CiCR2alEMFisBkVvvwTAPILRAf5lpvGGjFZ0bKFq1+6eGLJbnsxv9Aan X-Gm-Gg: AfdE7cmabvxSDohX0z+gacjJVdG7a8iq+b7Xdh1R/dKJR3MyoXpw0SIpy9cegrZHhIA WaUkVObdOFFCjEOCF/+X8o0th3jH+tkHfg6XePdTh060qsC36iqwajXCGeHFWHtp0SaPI4NExi4 jvW7wB6DioNx+hEgYHdzcZcQWbSQY1ygdjlNInRGDgbirLKLKlwraBLVdzqZRRo8FD8cV6tlIt6 LR6HNcLB2KH7nlvkbKksYXzsxMC9siGUHD/KuivHVRTYtj6X1dYXJNAoxTzcFjWYdEYHUf04Fin 21xEepra87AntkWEJVQ9mfYijThyrImi4x37QuPZkivm8zsldFKBxOEB7Qj0I67J1eFpL2xK3qh HlISDphc0OL/0fZncP8+ylcU4/0gLa4L85XZjrD/1vBTH6uRCGvFDa4w+axvowPyoevwuPNLhz7 8U59R24nRRFUBF3njpOmI7mxTLqnGTBlt/M02JNbvNRO32wC9o/SabjlGk6C81Xupe+cH4Y9HrD 3OOK4IIjCseCzpOivPUXTopeNRGXfXWqBRs X-Received: by 2002:a17:90b:58cb:b0:381:5bd6:eb19 with SMTP id 98e67ed59e1d1-38e4b47765dmr715137a91.18.1784257561268; Thu, 16 Jul 2026 20:06:01 -0700 (PDT) Received: from OMEN ([103.184.238.237]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429fe1014sm1424650eec.7.2026.07.16.20.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 20:06:00 -0700 (PDT) From: Alfie Varghese To: neil.armstrong@linaro.org Cc: gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, dan.carpenter@linaro.org, error27@gmail.com, alfievarghese22@gmail.com Subject: [PATCH v3] staging: media: meson: vdec: propagate devm_clk_get() errors Date: Fri, 17 Jul 2026 08:35:58 +0530 Message-ID: <20260717030559.167-1-alfievarghese22@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vdec_probe() hardcodes -EPROBE_DEFER for all devm_clk_get() failures. This masks the actual error code returned by the clock framework, such as -ENOENT when a clock is not registered or -ENOMEM on allocation failure. Return PTR_ERR() instead to propagate the real error to the caller. Reviewed-by: Dan Carpenter Signed-off-by: Alfie Varghese --- drivers/staging/media/meson/vdec/vdec.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/medi= a/meson/vdec/vdec.c index a039d925c0fe..fba1e7f88d81 100644 --- a/drivers/staging/media/meson/vdec/vdec.c +++ b/drivers/staging/media/meson/vdec/vdec.c @@ -1026,24 +1026,24 @@ static int vdec_probe(struct platform_device *pdev) core->platform->revision =3D=3D VDEC_REVISION_SM1) { core->vdec_hevcf_clk =3D devm_clk_get(dev, "vdec_hevcf"); if (IS_ERR(core->vdec_hevcf_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->vdec_hevcf_clk); } =20 core->dos_parser_clk =3D devm_clk_get(dev, "dos_parser"); if (IS_ERR(core->dos_parser_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->dos_parser_clk); =20 core->dos_clk =3D devm_clk_get(dev, "dos"); if (IS_ERR(core->dos_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->dos_clk); =20 core->vdec_1_clk =3D devm_clk_get(dev, "vdec_1"); if (IS_ERR(core->vdec_1_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->vdec_1_clk); =20 core->vdec_hevc_clk =3D devm_clk_get(dev, "vdec_hevc"); if (IS_ERR(core->vdec_hevc_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->vdec_hevc_clk); =20 irq =3D platform_get_irq_byname(pdev, "vdec"); if (irq < 0) --=20 2.54.0.windows.1