From nobody Sat Jul 25 04:55:57 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB6283D9680 for ; Fri, 17 Jul 2026 22:08:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784326141; cv=none; b=E7w5x/FshBbP7HRWu+i10AAxFnigyasKlr4KEdajBFJk9Z++mP3WjHxCfSq5oT1CoG5nvWRq9w3X6k8YTHweiRYoUCAKiag8stgSv2oSPjHBdqs/wQQOlIHH/dmAu43qzUEK5rzxnTe36T3ZHmenJleH5H91xLxw2eeJBRSCGa8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784326141; c=relaxed/simple; bh=sj2gFgGlkXOf7HmUOz2/0YiSYtXipVoVsXjVPqSBSH4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EnA9jIuJ1p4UspMoSN5/2HJxphr03stE+Ef7eCJSk0Akmpmnqgj/GdtM+zuWfFJ7YfloaIvFQnmXEK4wj3mTZLukLRKQT7KixQ0BdqaobMQQyzqZW7F6dzZu5QdQupb45khW4QDVOu3maKIn1meT6AnsrVyzpJIpNUnCcudl07g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HMjvmMY4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g5nP0AAr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HMjvmMY4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g5nP0AAr" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HJtSjG2751816 for ; Fri, 17 Jul 2026 22:08:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LTHU+K66C/MTLyOO1XlHiv0lW5j5mAa4izNrPmhWl6Q=; b=HMjvmMY4s7Cbm3J2 vUeTvV/9yTEppBGZyMC4fagMOXAwuDQmRECSt9nPb6OblOXOdpS82uzbYgP+NBQr ScpaGLDNRUFs8ZTxJX4QFEYs+HIzGVT1e5H9yiTy60Am9iHrJ88SmgVKUMsvaB2c t70T7LyM8LKynjegIxeRJu4FjFVMg14UCy1dGTMlXrPPThbR8kia3fADmZ6FGspx xXcukhBRrAp/UVyRNvpXoS2t8RK1iZacLpMQxbDaLPQwjGBgj/EGBiHZ5dBFC0wV fvKF5FZXfS8qRntObG/p/705N2jM36VTeQvrCQiHYeIydnWXo9S9msqIY8aEn+Zg iffg0Q== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffpug1jcf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 22:08:58 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cc7ea29141so36001375ad.1 for ; Fri, 17 Jul 2026 15:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784326138; x=1784930938; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LTHU+K66C/MTLyOO1XlHiv0lW5j5mAa4izNrPmhWl6Q=; b=g5nP0AArLMQw2UA+AlEbm/BaFNisy07yDaPgaq9vd7yv+RpcV2s2tBCa3fcL6dfoIN c2M4IG6NZX6Co0IBvtkfHy3t+lUy0arR2bGKlAnD47qKUEXNn8z/Sa3G7z2jD/los7i7 jTiPG3o2/JG+8jWTXiEML7TpnT3Z6VAKIoyNX4oPLpPDzr60Ll7HctBT/7gdt8g0MQcv 4eHAwH8px+pEk02JEduXGlHEq1TpgfAMahOur/IgGattctyjj6JVUk8ERY1MdIeqUtoX e2c7n7wfeEGCWuQkv/CLU7a6pETzWxmFErZt38x/qHBQEFqGUD3FhJJxnijYxqGUS7vn sv+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784326138; x=1784930938; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LTHU+K66C/MTLyOO1XlHiv0lW5j5mAa4izNrPmhWl6Q=; b=B4ygS2LrPVF7rPd/KsXzFnBq4pIRTb8fJh7uGloffPJz6pS4I2VFZXLQ26LU6QbqTR iBJWdEQh6Cp/szFJSEvwjjOE1i4EwRlRf7jZrmP6i5sGL0lMEbX8UJoDjiw4R56zUdQ/ qjGbUhJAIyJotDOGfxHLAU95nT3/r19YanwbEUh/xeOikSi8qIQYQSE/K/m6K1nSrwqG XZ2+ZjRlFR2EPR/jb0CagJ8KV3DcRT8RrBra5pmqasz6AO11eVR2YqhjrXSTdkbnLWD2 n6BJ4HrDR7hldcf4Ad34pW/iJk026dWyhIA8yFkyy735i+HF7DVJorZoYv6GFptI+F08 blKQ== X-Forwarded-Encrypted: i=1; AHgh+Rqyllv1R5MAczeMkiRwRAgTR+4ibyrj/QWFOFX7a9d50dMgV8vGcArf/11W8JXVe+I5b4ZeOWAdGEdl9JA=@vger.kernel.org X-Gm-Message-State: AOJu0YztLOEcJqUenW/RuB9OtuxKbMx58ZXGMZlSsIsiPD9JF+hcmFbQ 6E1Sou6+AXiMpBqZnXXNd1qyx807LrXpVembr6IHlDBhm6IfpRhcp0AKwlrQMeeAnzLC/0BmSqy YGf+ZaealnuJVoSQORppL4qL09COJP/PZQYRvcXbv/OCHPVQjlSCTpOpepei8rub1Vls= X-Gm-Gg: AfdE7cnNk9nU7mZL5uHs/WB94FNdr9rlqdzS3wOwB5nxrjU6upe3fYEWJaq0wXI/4im GfsFe83rSvi6fTLjIQ6sndbY+olsQu2W8ZL7OFGRrplCYcGaxwhQd54m/xoW0ogU/1Gm0rET3GV 5ToSKCut70nC6FpgKW9s0yfafkDeJIe3pRw2kuZOVu+5R+mQlZQjjdcTVEZprdR/U75Ndl+Extx eYutkZoadk+4/KaKjLEPfBNTChfIRvWcq1V5b6cTQ0AvOaRuAsP7gG2d62ANphVzj+oKmAJR1RX sKcKgL3GsPh0uHM2YLP8hDTvf5OnBaOborUzoi8oIpfPsuxBKH/sNM3QLKcg5VBeAy4/BU96zxf qTDSMu/MoqGqzG18P5a9Lml/6Atb5gvIlDSvnS8R1ITHdQrk= X-Received: by 2002:a17:903:2301:b0:2cc:f4d4:29aa with SMTP id d9443c01a7336-2cf349f3d04mr34757195ad.6.1784326137757; Fri, 17 Jul 2026 15:08:57 -0700 (PDT) X-Received: by 2002:a17:903:2301:b0:2cc:f4d4:29aa with SMTP id d9443c01a7336-2cf349f3d04mr34757025ad.6.1784326137330; Fri, 17 Jul 2026 15:08:57 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce29c2dcdsm7668667c88.1.2026.07.17.15.08.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 15:08:56 -0700 (PDT) From: Zijun Hu Date: Fri, 17 Jul 2026 15:08:53 -0700 Subject: [PATCH 1/3] Bluetooth: hci_qca: Replace HCI_VENDOR_PKT usage with HCI_EV_VENDOR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260717-fix_vendor-v1-1-f22263c1175b@oss.qualcomm.com> References: <20260717-fix_vendor-v1-0-f22263c1175b@oss.qualcomm.com> In-Reply-To: <20260717-fix_vendor-v1-0-f22263c1175b@oss.qualcomm.com> To: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz Cc: Zijun Hu , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.14.3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDIyOSBTYWx0ZWRfX1fjVJFsWGIgh vYiQkmNKi1zkYyzBzQc+XMxoX0IDUSeBxYLB/JMa7ScLoOSi5k33TOLe2XcfhbUnxfSABHTACD3 QqtOsORq/Mt1gUvuKZI7gn2rbR1zx/y1g4FV9EnQ4GPlrTpKRk50NUf7soANXcctXTIK7THOpDw YQGUVmB/ZAwXXlAbPmyPzEx6LVAsyPBgo/eDjxVEaPSwe60NKoMsS1+E74jPBBwNGw1CebPlNQN 1u9010CwFJYE9EbBnm3yf2kKVSF4GTE5tEchK58Y/TVbR/YdQRZ3YrvLlHYy0p98+YhNK0UfHC/ QZW6g3QdE15w0CcOrEiDv0k/1cZ9mcRZQqlTLheYHRXJWVccyLHhvgOMiUaLndH9EI/8UHk46kn XrQ6rCudOtiGLxr3MwNecW9+nH38waM9a3nwbZB2rCc46PnJbs6xShPifbbxMvwKD1SZYwHap/7 wLh7RL9Bohfz25xR7Zw== X-Proofpoint-GUID: MLtP05sUFSbUs_z7ZTqXyf7udXwExUrY X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDIyOSBTYWx0ZWRfX6WwGQTRvNQOP kBqLPdNA+4Xm7Y8/5fU1s7PMthtkZl5FwZKAq6HN/jJdJZJYRcM0+7i0tC6Wn51ZDQu0ga2oDyX Rw+bdgOEblM4Wm1lvQt6J9y6nR8Ke04= X-Proofpoint-ORIG-GUID: MLtP05sUFSbUs_z7ZTqXyf7udXwExUrY X-Authority-Analysis: v=2.4 cv=Q63iJY2a c=1 sm=1 tr=0 ts=6a5aa7fa cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=SK-ELO-gduZh6qpZz3UA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_06,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170229 The macros below have different meanings even though they share the same value 0xff: HCI_VENDOR_PKT: HCI packet indicator or type HCI_EV_VENDOR: event code of a VSE This usage of HCI_VENDOR_PKT is wrongly checking an event code. Fix by using HCI_EV_VENDOR for event code. Also fix warning "CHECK: Unnecessary parentheses around comparison" given by checkpatch.pl. Signed-off-by: Zijun Hu Acked-by: Bartosz Golaszewski --- drivers/bluetooth/hci_qca.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index bd29d422c209..f978087612ee 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1240,8 +1240,8 @@ static int qca_recv_event(struct hci_dev *hdev, struc= t sk_buff *skb) * received we store dump into a file before closing hci. This * dump will help in triaging the issues. */ - if ((skb->data[0] =3D=3D HCI_VENDOR_PKT) && - (get_unaligned_be16(skb->data + 2) =3D=3D QCA_SSR_DUMP_HANDLE)) + if (skb->data[0] =3D=3D HCI_EV_VENDOR && + get_unaligned_be16(skb->data + 2) =3D=3D QCA_SSR_DUMP_HANDLE) return qca_controller_memdump_event(hdev, skb); =20 return hci_recv_frame(hdev, skb); --=20 2.34.1 From nobody Sat Jul 25 04:55:57 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EE77175A5 for ; Fri, 17 Jul 2026 22:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784326142; cv=none; b=Z5igcneXmZ2lLDrBXgHF/UiMyzJx+d9UXC0/1vtTxzRDF9ZHQIr8BQK1fWRfPRpKFwJbcx35qUW1xqoprNswh7FUazjWkmUJbGH4UmSsy0oyP4iv2ZaIjNUbEfLsX2QB2bhneeczFpaAHnU3R/uTkhEJp8qC5mmh+WMWNbxtXpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784326142; c=relaxed/simple; bh=2mg4lcCoBOrma6IefKKbH4/A1AJkOSonKY92QFoY8Ws=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DwpMY/ovS1DrLiL/7z/k3+qu7TWqi/qVwYsRn2dxxOEvrg4dxUUXwTWKSGoDqzssppKFEcellVO0Ds4Zc2k2U08eaAuxtd51lOdZzA5cwf/n5KfzHQfsprCSpcV8I+37i4MRhbIg8Q5OUXDWy3+hGYWQPCxEJXTrnyt0MN56POs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WGEOQCxG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OpEqQgWP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WGEOQCxG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OpEqQgWP" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HJtJLc2652794 for ; Fri, 17 Jul 2026 22:09:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pPC05PLfPQYtBhoBw/chggXx2GVa+E6AUpymsBU5IM8=; b=WGEOQCxGA5+b0OEe MvMXY0+O1P58e5E7sQWzw2V7F3Z5QdLadTwQLEqJvuUNoi9CkrAB+IPXJDPkR9QW hkKOicwbD374nL1wZEsk067wQCvDMwzoLP9pd6Rj9TCK/gySbCJAdRtDVeEqV0ZV vXxQnUYJHIDHgVcWUhv52C4AFtlrpfnO62kEEqXvQ2OXuZVoASfHkZo5BOjtoNtx Ewre3rjwpXYwVddIrGIxOuQ06zmEqp6Xds3XKX8wXa8Q7i7vKcLxD6Wzvr3VCJ6Q ORulOz0k4XtnyZNLO6NRLzCMJiCloG6+6tCfZ9yRiJP1dUUypHCCsNrqJxic7r8J M89kZw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9pbh8g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 22:08:59 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ccbdbeffb9so28189495ad.3 for ; Fri, 17 Jul 2026 15:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784326139; x=1784930939; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pPC05PLfPQYtBhoBw/chggXx2GVa+E6AUpymsBU5IM8=; b=OpEqQgWPuHAhpuchLikLDOxtBDBRV045CaWb+QLS9W5LxzNb3mMpC943Ty4+czKoKi 0nIQ0KHvP6dcbiZA4r44hCKthTAFhTXY5EGOEL4JFEASUVhvh0K/JOGFkQb9AfK2J48R HHdGh6FlqFsCA4n4Zi6GutpR98YuKqYJseQEiZcGtIqgwDe5PlPMq6160s8dtXyGdw3C yNrMmlW8SN0+Lu+QWxDYBbVmW4yt3iHBAn62e06iMUk+kJmmN02z9ZMn63Vx1Yb4hH8L 3wig4GY3XZr4t8bpWZ6iwr5/JJtP2aAvPwn3apuUU2xsjeKgPbE8q2bDCZiBF0kdBFpv vipA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784326139; x=1784930939; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pPC05PLfPQYtBhoBw/chggXx2GVa+E6AUpymsBU5IM8=; b=Akx8YyBntiPClGMC8dDNbk66aQsQfO52ZLh43ewcEQo7C7bHr+/8q6qGOr1KHlJIpK FUvPi/NSWRBaX2vwZm9Radppd7AzCprmOkqujM/a5xzjexhJo0xq8VRXrOmnaSkT6Njl kVlYX/MJhM+pnj8b0WFNc3mTss56sasbyjmJiLrtg5qEbAIqmzNehnNN8DAf1JH/ZL45 y5rEpQjySH5Xl5cMyf7fDhky/m+cwIWAZlaVRnHV3Q4UWxdaBAXQ5R23Jtz3zhE40pgW JO/yRSyuujT2j9p98dBZoZxNGmn/VHqJkXfFp+FzG7928LCtPFTdgISxe7dPuu4tjIdx vNQw== X-Forwarded-Encrypted: i=1; AHgh+RrY+WEnPlgEPOQ2kAhinMQ5YPzFGOW/uUN154763t5XTxaaRGskbvVbIDZ1L/NiIS/2k6cGFtPw/p33g30=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4cHQPlyoavRVXIjtXitNrbOq191IvVW+VmrhOf2HkYU/hj5ho p4TPypADogCZM1DnhkYkcEnbLb3BJjhSUAby7xe0CQxOd1k8DmxGFsQbgq0xLvg49s59z7CAeNd uhmg0aTns3SYvoIwVf1h1dFVeGl6Q8cej3N0sytvWf0TC9vBiMGnhWhtJJ1b02zN2kHs= X-Gm-Gg: AfdE7ckpTpIvC9a950KS1zVMIHdaUy/tEZLkzABK+BRLrVp5Wq2ist6/H2h2hQpI+V9 Fm6gnvFhWynsUucIf3fpHYs4kBwNDqkLaVI4DRTEr24GPWC+KinJe5cDGi3ByFIMAi2C80Xk8Om WHi6EQfTnxjFWazpYsf1UFTeBrDjL8K8HI0gSd89JAPeidx5Udp0ap9WVqenf9+a59TTDAB5r2w 58IKdEvYwA6qfekKNIkUExMQbjbFcKEnbvSMAts7KE9bhQMShlIpx+cEJ/m0kjcZVI+I/eWYF+U IIE3Nw0O2GOWWYQz8NtpFojLpRyW/X1/nRkQLZRPP/DwehwnrwLttqa6/5BZdEfRt9JBzXh7AbO OP+55ySp9xEtR3kHaOq02dn7ZLyHSpyOwnfMBwVFLLjNqcpI= X-Received: by 2002:a17:902:f650:b0:2c7:ef84:c58e with SMTP id d9443c01a7336-2cf3480b3abmr41455295ad.1.1784326138915; Fri, 17 Jul 2026 15:08:58 -0700 (PDT) X-Received: by 2002:a17:902:f650:b0:2c7:ef84:c58e with SMTP id d9443c01a7336-2cf3480b3abmr41455035ad.1.1784326138457; Fri, 17 Jul 2026 15:08:58 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce29c2dcdsm7668667c88.1.2026.07.17.15.08.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 15:08:57 -0700 (PDT) From: Zijun Hu Date: Fri, 17 Jul 2026 15:08:54 -0700 Subject: [PATCH 2/3] Bluetooth: btusb: QCA: Replace HCI_VENDOR_PKT usages with HCI_EV_VENDOR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260717-fix_vendor-v1-2-f22263c1175b@oss.qualcomm.com> References: <20260717-fix_vendor-v1-0-f22263c1175b@oss.qualcomm.com> In-Reply-To: <20260717-fix_vendor-v1-0-f22263c1175b@oss.qualcomm.com> To: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz Cc: Zijun Hu , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.14.3 X-Proofpoint-GUID: In40Mqe1XTmzz-Ipix8O9PO7_dOqIo1w X-Proofpoint-ORIG-GUID: In40Mqe1XTmzz-Ipix8O9PO7_dOqIo1w X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDIyOSBTYWx0ZWRfX0dd57qQelHo7 pKifNf9mMVuX5npbD1Q+25Hwn4eqHzdBjP/6Ca6iwchlhvw74fLNiNHspG3ZwLrYAki9YzWAOu5 7GqS85BL2EOOj/O/IP9J5jF2pc0mb75mh/a96swHN5ozMxm54eplJ4L8x//UNrKivfE6RITVN/t vlei9Kl4jG5NVWRZN2TTch9bY1y2GOYr6VtXK0W0cRNt8VmYJyDdnDb8xzFsV14tZyq0DDH7UaG v1OesmttHCIeU+klr0ZqcIVJbOlQyrYodSOkfYK/GS1pcIZ4Ayh2O4n4Oe0q2KJ4L3RHHGxW5dt eren4mb21iYanMu39PTGD3Nh6YqiP9J6thiQMPdZM0EhI3HsDFY1psxORXSwcsJ8tPKg734Qf6C 42bsDkWwi9e7IhRXY1XDwtj5LAfjB6c5SsFmP+IOYUM4gKhkyIj2MJ2I50pg+gAydz1v/1lvylY jToTrCx/ruY5mKW8fSQ== X-Authority-Analysis: v=2.4 cv=TaqmcxQh c=1 sm=1 tr=0 ts=6a5aa7fb cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=_0CnrhXH5lyLv-Mul2kA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDIyOSBTYWx0ZWRfX3cXLQNT+S0hC 8JHU36oefJAIElPAnhYnN7DxopWy0TcESUvy2AjZAWBSgDi9EqDE+EwHNd0WG17/67z4A9NLWoq ArIPZnp33Pesy9AgqSM+1UTlGTb/edI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_06,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 spamscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170229 The macros below have different meanings even though they share the same value 0xff: HCI_VENDOR_PKT: HCI packet indicator or type HCI_EV_VENDOR: event code of a VSE These usages of HCI_VENDOR_PKT are wrongly checking an event code. Fix by using HCI_EV_VENDOR for event code. Also fix warning "CHECK: Unnecessary parentheses around comparison" given by checkpatch.pl. Signed-off-by: Zijun Hu --- drivers/bluetooth/btusb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 4c3193ec2d52..d69eec8b2911 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -3276,7 +3276,7 @@ static bool acl_pkt_is_dump_qca(struct hci_dev *hdev,= struct sk_buff *skb) goto out; =20 event_hdr =3D skb_pull_data(clone, sizeof(*event_hdr)); - if (!event_hdr || (event_hdr->evt !=3D HCI_VENDOR_PKT)) + if (!event_hdr || event_hdr->evt !=3D HCI_EV_VENDOR) goto out; =20 dump_hdr =3D skb_pull_data(clone, sizeof(*dump_hdr)); @@ -3302,7 +3302,7 @@ static bool evt_pkt_is_dump_qca(struct hci_dev *hdev,= struct sk_buff *skb) return false; =20 event_hdr =3D skb_pull_data(clone, sizeof(*event_hdr)); - if (!event_hdr || (event_hdr->evt !=3D HCI_VENDOR_PKT)) + if (!event_hdr || event_hdr->evt !=3D HCI_EV_VENDOR) goto out; =20 dump_hdr =3D skb_pull_data(clone, sizeof(*dump_hdr)); --=20 2.34.1 From nobody Sat Jul 25 04:55:57 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 604F33DDAE7 for ; Fri, 17 Jul 2026 22:09:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784326143; cv=none; b=Wgi+8asy8Tyx/MHMWppTqrekApyHLsydQdoaohnFCdh8NOtf0m0HY1uA9/DCS9Ynnc+HnspXH3yxgIC0tiiFdizGdCqu9MbkSCzNZnwQM21KNH4OMxvCwrkGF6CE98EfzyyvewXDD2jfoBUQ71JaVAdIa3+ehsMFERBThWnamFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784326143; c=relaxed/simple; bh=fHse+rS17xUX5GVYWIfKr2FEbD8HYkVCn39BVdXrWpQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mpf1/76vlBbEvl6gNW7EGYorT5KJPwBLp52WOFj8W1RDirptMuaWBFSoRUqotQ1yEqhLPGGSShJyow26k+4ijh36ynnJ2t+D/7paEJYUZvowXmu2usu/02mkW3tB48L5luTHVJqSkuQFUjZ22n9KwY91Ljat8lu/dPxF5qCWsa8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Moa+46XW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IkXu5WW9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Moa+46XW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IkXu5WW9" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HJtPYw2751693 for ; Fri, 17 Jul 2026 22:09:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fdutxu1QSPLRQaJGSv++B9jUfnt05l6Eko2CexsSKaI=; b=Moa+46XWBvNd8yYN QAq360Sn4DLbWW+1lLKdJ7S/ix8kPSST4m/7xbrN1jqBNRTQcwAKx/x4X+yp7DfW o+r94aRKyfk4s35R6Tdv0h1X6f2ft4IFpR2fVbI9ZNqGhU/cwWAiIXhz7zmeuzD+ ECUOmQrd2Zn8bZD1Lxu6VMEXhS61eMzi0/21L3USWJ+pjsXAQwUB2CoIj7X/FMYN i68FQsPOrWpiPmLiaihdN9W6v8lWJxw24m3yxXa1gpOA78jHs2TPXbcPOisovYxZ zmepR3psmNDv3gT+j47ricEeYy6vwghauSugSwU7JulbobTjUJufdLcBpr5LuorY clB5tQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffpug1jck-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 22:09:01 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cca0ed258cso29400215ad.0 for ; Fri, 17 Jul 2026 15:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784326140; x=1784930940; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fdutxu1QSPLRQaJGSv++B9jUfnt05l6Eko2CexsSKaI=; b=IkXu5WW9HI/C1kuG2JJn+1I4BVdhqoRNUipFt6tUH+kBgUbj0MeHMPG061fs6YnzSD vlfrqZUorkKHpKweblDmMeNiTSuvcqdVZoNZE/4tDK6cCOge2FkMs8PdFgRosu0nyW5M TMqvx1LBgEbfnSMEspepUv4Lz6X7O80wRFd95ufp+//hOoJUf7QXaZSCS4PT/U6dBOtO bdOuXSXTfYZXqG+kUnDVIxz3U4AsuNZaDJ9L7d6BfvvXvdW70y8czxVp0tvjkkqIotNI /+oZhjIQkZzYubOQP2FzvkTw1RNxsFTyGO2OmO6SGGES1/hvGYu95caKzMKywwJkqAm1 R84Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784326140; x=1784930940; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fdutxu1QSPLRQaJGSv++B9jUfnt05l6Eko2CexsSKaI=; b=C7gry5mZxB1Z4avDEpr9hq9cd523mRu8oUV0LAGn70HJp0wpP8DcMwRKc/cNUtcWLz fHL5btqfRe4tngzzmGUMNec8xgLgEWaDFpb7o5q2u6iDsLxbVdHOZcrAP949oP3ekWpf XVsq5Y1+ZiJog5cRUlgNpSNf5tQVDzC00kswx/KUZDGlLaDtHvGFFmidJG6ZlCdFH4th odDYZdXB84/jp6GWzCjEjBLv1qfo/86ja7vqG2mQv0wAG+B+TQvjeDfhE/6xZOTPXCqy 1oSfSu0WWiNMmHTxnJonBZllugnGKrekA/s7T4aoOW5xeWl1nkQ6lMbhNgO8eSYjoOEw UwUw== X-Forwarded-Encrypted: i=1; AHgh+Rohq2p+ZC+JUIxn+A+wb3H0oBSZojCvOLezQoK17s7477+/MsXSPSde8wh5JxOocWQSTmfg7k7lfcEo0HY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz39ssHuXzWBimJxUZro3stbux+nV5D3EuUE6l0bXdrBU0azH3N df+pABB0zqO+EdRqX1xhwzQR54PjFAYgj3F3VB2pP08xFwRVIS4c3ZyWMY2pGO35Nu/EXcgR7gL HRUnro5ZSEI7y3eAS7YEvr9bgJxjjwwNEUT5tOodWMfSEfquofZA1epdY+QGeWz6qUEY= X-Gm-Gg: AfdE7clTwyIkZ8q3GXEDtqwSlbgV3pApmHycD77qpJE0zpSwJf8Sh1l4IkzH5ZD/IOk xM8LMUxYQmmC0DLOEwrM3lCRBOHAKuTpF800NbBaTRR2nmgBEftzuMqNW6tWRm9cHymyLL+sax3 M0UkECPBzO5Hz6aT/nUqtF+xpDA+e52qZQK0tABqJ0nVW2WOGAQu1m+JoPKbzXCTQnulrufnlep 75JPrPKBVHEPGLCH/cIBzkHHCqi1K+OUAV6/AzG9dXbGCHSt6WFfqpn1tXanbv5rI+Hi8Ilg5YQ IY7wH0/I7OrZoXWyVpWIeMSEQ/oyP9PSoMI9zKbno3NXPr6w09SQ464Ir2MeCwZSypxjgfvadVb hMDNSSXOBja8EV+nNilsJo1Hf/jN+MPqvZPCDd2zjWxbndfo= X-Received: by 2002:a17:902:f684:b0:2c9:ed4a:c3a4 with SMTP id d9443c01a7336-2cf34652e9emr39186395ad.0.1784326139969; Fri, 17 Jul 2026 15:08:59 -0700 (PDT) X-Received: by 2002:a17:902:f684:b0:2c9:ed4a:c3a4 with SMTP id d9443c01a7336-2cf34652e9emr39186175ad.0.1784326139601; Fri, 17 Jul 2026 15:08:59 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce29c2dcdsm7668667c88.1.2026.07.17.15.08.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 15:08:58 -0700 (PDT) From: Zijun Hu Date: Fri, 17 Jul 2026 15:08:55 -0700 Subject: [PATCH 3/3] Bluetooth: btusb: Realtek: Replace HCI_VENDOR_PKT usage with HCI_EV_VENDOR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260717-fix_vendor-v1-3-f22263c1175b@oss.qualcomm.com> References: <20260717-fix_vendor-v1-0-f22263c1175b@oss.qualcomm.com> In-Reply-To: <20260717-fix_vendor-v1-0-f22263c1175b@oss.qualcomm.com> To: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz Cc: Zijun Hu , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.14.3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDIyOSBTYWx0ZWRfXw+dRoEelZ1mE VtNoxXVofsWMcpSTzi080XaiB24uzkGIFxC9ZT7gNjnlfsip8aJO8euu2ogixc4KgyBFp4FjGHq 0G3UE/5aND+h8dIXlSvVGNy7uM3ZDWl6rcq/5L3bh4YkY0nZ3qWgcN/vWBgbwVHCYHCYKWHYXYj f1O4Yqpcpg0AMDM72A7AyoRX9Jng2vSNK2qMfzLGeoO3RWZB5LT4vpMUr3pjFNl/g5KX8I6Xb5Q 8QEkOE9hBdsq8YrBN4P2KVBzU0LXDvAb6OiikllmS8Ks8ekQsbFFtA1u4hj+n6qGk0nUEvP9n3A Iz6jY6BOEnRF5RA5JvPPFy9qsMdY+AkhEcywKRoyrn8WbofeBQqzO68N52EX/uMCLrA961eqLFt D0aotiRS5x5Y9c2Cx0UFYY1FkE5o9V18lPNo/Z9LYMxqgGoe05QEAsDAbTUhtFeYzmLdW4ZSP0s O3d7jVwaRe5TpAteLzg== X-Proofpoint-GUID: kG6RkxgZ4M8u5EfoUacMdHmBhs_TvSsc X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDIyOSBTYWx0ZWRfXwSsNwfk89Omg lz4CHCWFjmL+xFoZlmD1IwtBQGbjuo2D4iSwetQGv7MeJIpfPwoXmKdzliXqwIueAeIxSaZARBY +3NJJ5R/vYVbRneWU+PexQnsiBZ23Ak= X-Proofpoint-ORIG-GUID: kG6RkxgZ4M8u5EfoUacMdHmBhs_TvSsc X-Authority-Analysis: v=2.4 cv=Q63iJY2a c=1 sm=1 tr=0 ts=6a5aa7fd cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=x96CrpYRk5hthMOPTrkA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_06,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170229 The macros below have different meanings even though they share the same value 0xff: HCI_VENDOR_PKT: HCI packet indicator or type HCI_EV_VENDOR: event code of a VSE This usage of HCI_VENDOR_PKT is wrongly checking an event code. Fix by using HCI_EV_VENDOR for event code. Signed-off-by: Zijun Hu --- drivers/bluetooth/btusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index d69eec8b2911..6973daab91ec 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -2799,7 +2799,7 @@ static int btusb_setup_realtek(struct hci_dev *hdev) =20 static int btusb_recv_event_realtek(struct hci_dev *hdev, struct sk_buff *= skb) { - if (skb->data[0] =3D=3D HCI_VENDOR_PKT && skb->data[2] =3D=3D RTK_SUB_EVE= NT_CODE_COREDUMP) { + if (skb->data[0] =3D=3D HCI_EV_VENDOR && skb->data[2] =3D=3D RTK_SUB_EVEN= T_CODE_COREDUMP) { struct rtk_dev_coredump_hdr hdr =3D { .code =3D RTK_DEVCOREDUMP_CODE_MEMDUMP, }; --=20 2.34.1