From nobody Sat Jul 25 15:24:48 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4761363086 for ; Thu, 16 Jul 2026 20:29:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784233798; cv=none; b=aWm8pJkbMMG28EUIpwUbhmNn8g5InlA9uEE3VrwEmSyd+XZ1P9ODbnBuVKNCiNoRrhuMJe3C3tH6QLhg4xzk6xXBc2lL2c49VOwBDFcMa8yMh33ubwkXKnFT42mQUB6E28ni0GPQC5dK5Zw3z+es6hU9u4uONaN5UJ3m+6xtPn0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784233798; c=relaxed/simple; bh=IJeXEkvaYFI2ijYHmji3XnM2xTV5dy+jj6rf7SrwbqI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n8QpFU/kPcAcRQMZrqqvGVkLkRWGkkuGEBIbqCDn5WFdcX+uVMdQJU5Td8D9vz3hDnj6VpfJcMdCUbppCzHRhPEmqBYBqLXwKfJ2pxL4bEdenEHaqH5M98w0W617F0bEmA3tCc9k7egzbETnvAa17c57SsDaelRvPAQjIoCz7Ao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MLCgeyW1; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MLCgeyW1" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8484a0b998fso5800096b3a.2 for ; Thu, 16 Jul 2026 13:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784233795; x=1784838595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fq5+Et8VCLx3YNlIRBYElnfSV6kqx1OSwg8TLAZrMWc=; b=MLCgeyW1elEKq4u6vnf07npCC6EEOIPz2PU0jDlk1gGKvOqctznswNDBBfwdN13IuC RLVjUk+o0KkcVqG3xOn3voCScfBJi5j8Lfmwz0vvNi7UkX0+p5lk3xh7PO1Py+ECP/1O k2/3XH0qXiQlqgj0q44xpKvVlU1WbkvCQDtJniJN7Gwg61DucumQXqyt02ycVlhI5B5V HaDBJC3f7MIlGgroq1IAhaIUeyskpMkc3uJdkwGuUrrCxdbgYcddGaorf+5yLs/A/Bit n+ZUYTgaC0H9s/FfEF/oqzIMETDp9LOVlF0H0ZeLeycbM4SZweDtGKcRNeMFeJGcD25n +KUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784233795; x=1784838595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fq5+Et8VCLx3YNlIRBYElnfSV6kqx1OSwg8TLAZrMWc=; b=AqyV8ZKWD8xRRpVTd0HiwjV9/HeWwQLsnkZSLZziTj0G36/pZ6rJfcFPvyO1jqv31b /8KGbRmSTKlyg2rAk1kHj9syuYgWLECwjY2Q7b9wqFqGJJSRhxQofEJkEitUpgmgrvUf rln6B6jmBd4UkDw+UgasQCdsD9kRiaZitJjYJ/Z+BtfRsQC+XHUHp+Lwc6YvbdW2chxH B0Fl7PVs7a0rrqDq0TFlrVUgNY4CNUaH27xbVVsCY/oe7iPGkpJJdM1mgL4a+c0zbewm oGlk+iQXP3rEYz16kSKaJTqavFDUO8QxPQHhfyzG7v37OQ7E543k3gNcxNmsi9+xWozH aGwA== X-Forwarded-Encrypted: i=1; AHgh+RoU2r97TjgvifdGkD9zxF8F7Cw5RcILCyflmJWFSqhdgY3O+zNKM+aQust1FGzVJw8gTKC2IvOcy5TNjXw=@vger.kernel.org X-Gm-Message-State: AOJu0YwWoy2vUaKblqRc89CdlSxHzMrL2hPrQlzpSvT1CuVdk2mbcukT Df+s6U9FQIruIFcxDrgsDK/debm/ze2q3uS1GYQ6+jN9VK3QFRVnoYsH X-Gm-Gg: AfdE7cnnBZVvF84nthsRIGpGimiiKjCLvyhRa3G3jSAyZIyQWQUfuAxWbm4TeV2l6SW H8842rfSdiTQCSI3PTJkxW0Adt0GdRqmpvWUZbqJcRyJizghs4t8bVl4duQMdYEArEEuSPU4MV6 9plPLe/1wIQiqrUj0FqmY2b4l5EP4mZhTlux94bo071jgsiKcNe50GWdNRLkKF980tq3vzzEoGJ VnLu+5vXwdRZdbZcnoBPxNGe1JLSyLC02tdjsRZ7/LblpcYglHSK1RGfH++X1HYzkPEn/5vKxth Z5+3ICz4Cb4jjiWmupINlD5kixzahdYS0rlLQ2Of8RRxQEz89jqPymWp5T+Qd5dTGm190F9pzYS CBmj0QJ9IPYrmsXQ9kr+6U7HR9VLM8zrdAyyy2ldNicVsbIyV1jq8Z+OjAVx/uNcAdV9ArpLqdA vMN3BcnnKYxubYC/ajhxSo1QxwEyE0jplMKY6joIFD1fes86jy1L+8lc8uFCffJoKH8d/SJokvJ x96Fq/0/r0nhTqiZ7e2c8qfQ1SeOIhIGM56+6ctKxb31dVvuz74HfM= X-Received: by 2002:a05:6a00:4388:b0:82f:50cd:e586 with SMTP id d2e1a72fcca58-84c234f913fmr859680b3a.13.1784233795193; Thu, 16 Jul 2026 13:29:55 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f26f703sm5536776b3a.17.2026.07.16.13.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 13:29:54 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 1/4] dma: fsl_raid: convert descriptor stores to big-endian Date: Thu, 16 Jul 2026 13:29:46 -0700 Message-ID: <20260716202949.677290-2-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716202949.677290-1-rosenp@gmail.com> References: <20260716202949.677290-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The descriptor structs (fsl_re_cmpnd_frame / fsl_re_hw_desc) are in-memory but their fields are __be32, because the structures are handed to the device as big-endian. The driver stored CPU-endian u32 values into them directly, which is both wrong (the engine would see byte-swapped lengths/addresses) and flagged by sparse as a base-type mismatch. Wrap those stores in cpu_to_be32() so the values are little->big converted. Reported-by: kernel test robot Fixes: https://lore.kernel.org/oe-kbuild-all/202008111749.yy85rFMD%25lkp@in= tel.com/ Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev Reviewed-by: Frank Li --- drivers/dma/fsl_raid.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c index 99945845d8b5..2778d07a05e8 100644 --- a/drivers/dma/fsl_raid.c +++ b/drivers/dma/fsl_raid.c @@ -242,9 +242,9 @@ static void fill_cfd_frame(struct fsl_re_cmpnd_frame *c= f, u8 index, u32 efrl =3D length & FSL_RE_CF_LENGTH_MASK; =20 efrl |=3D final << FSL_RE_CF_FINAL_SHIFT; - cf[index].efrl32 =3D efrl; - cf[index].addr_high =3D upper_32_bits(addr); - cf[index].addr_low =3D lower_32_bits(addr); + cf[index].efrl32 =3D cpu_to_be32(efrl); + cf[index].addr_high =3D cpu_to_be32(upper_32_bits(addr)); + cf[index].addr_low =3D cpu_to_be32(lower_32_bits(addr)); } =20 static struct fsl_re_desc *fsl_re_init_desc(struct fsl_re_chan *re_chan, @@ -256,9 +256,10 @@ static struct fsl_re_desc *fsl_re_init_desc(struct fsl= _re_chan *re_chan, dma_async_tx_descriptor_init(&desc->async_tx, &re_chan->chan); INIT_LIST_HEAD(&desc->node); =20 - desc->hwdesc.fmt32 =3D FSL_RE_FRAME_FORMAT << FSL_RE_HWDESC_FMT_SHIFT; - desc->hwdesc.lbea32 =3D upper_32_bits(paddr); - desc->hwdesc.addr_low =3D lower_32_bits(paddr); + desc->hwdesc.fmt32 =3D cpu_to_be32(FSL_RE_FRAME_FORMAT << + FSL_RE_HWDESC_FMT_SHIFT); + desc->hwdesc.lbea32 =3D cpu_to_be32(upper_32_bits(paddr)); + desc->hwdesc.addr_low =3D cpu_to_be32(lower_32_bits(paddr)); desc->cf_addr =3D cf; desc->cf_paddr =3D paddr; =20 --=20 2.55.0 From nobody Sat Jul 25 15:24:48 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FC7835E948 for ; Thu, 16 Jul 2026 20:29:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784233800; cv=none; b=WMFwp9ijgzTn+CEnGTFwyuU+f5oCUFeHkg+iqb8FiU+TJyzOBC8XCPDJT6ipDLlMhDDmABGzMoNBftznYfhieYN16eVz8VZm20VuyPAZ+pEX5z4aeoH8wnRKZ4q2GrGEga5OUQQAvB75EEEhbJGvm0x4koXv2heRX0KO3B2M82k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784233800; c=relaxed/simple; bh=gfFshzEu8IhegW8gH8NdEfyDiL3W7wbKBDOADZWlG2o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dDMR36FK0WSmyxeQAQBAnZ9z4Dj/bcR6vyjiIxLKYXkyZ3mVETIKm8v/y/9xEyuuOuyp4Cadm28GAEmX0kqfUd+YGybznLEqOiaiAYkeCyAvjrj9TokJuCyZnR7RJwGAnnftF1A4F5t7iPm+UdExTxZLjGnfpdwyq4KteIvlPtw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jlkYfeS/; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jlkYfeS/" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-84830c774a0so3011537b3a.1 for ; Thu, 16 Jul 2026 13:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784233798; x=1784838598; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GYDjEGjYwxlAAaUy1jLazqjAp/ssF5loEQya/7wPNrA=; b=jlkYfeS/46TGR72G6D9oARUcCFboqGbgwZG+G+CmsfXKTbQmf963DJm6rMCGMe7H4+ FC1ECLWyzG3+m1vyPRPHXGzZCo8gBNAgNZ7W1PqgaM9NYzDoSdbeNhnzJ4oSAoF+Gw3r wLjsTVhuFt2I7utYa+5fn0mrBSDzpmxkHoXn5ygsbo6Q/Tf1ADa7uCNzNFAAGYSE8yfl 85PFqAJsZXtd4U5oc46lEvE7qVcruFGJYMb3+6gEdq7Lf4M2Eu0AHbFAlVnvhvtQAXK/ dRqBQ0Wb81Yj4umv70BWVoywGUsWDADlhsR/Ly+260EYfxb6MK8j0p/mhCJKWqpk+Jqd RLTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784233798; x=1784838598; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=GYDjEGjYwxlAAaUy1jLazqjAp/ssF5loEQya/7wPNrA=; b=hZdXVSxvfS4lDt6qOsCnLo/9+qQQl1KNpcjy/Ih5mGWd2/q8SldAYBSrQz9FGXSk2J HGCjH4dNS0GFyyJg/ltomI3l8Bvf1IjXnR9Bv9yDmJjcnZF6poAA9aCM2rDQ5nIDHRtb lDMZvwqA/v1UQLEUK3zMJwH0BMLn0Ax7DgfNe9jTTBFEIxUrORY35cUTvCdIXUgW1AXN h5F28dSmu+0I3OIMPNSYV6/Vbg1oQk1Bv6SAvpC43BwZDi6e7NAndNyTuUx2K5Z58JXc D0LM6jHbfDTvWFb0yc7Fzz7AJRxLLvns1CbmGak6CyAyfrG7nCRdFbjfbIIFQC4eSrT1 kinQ== X-Forwarded-Encrypted: i=1; AHgh+Rp5XkNeW5aM3SNZDrdnevhC1so0kBN2TMevwflJ817xux4INRn6LLBM1iwmUVMnHlaoeowc+/h7XI6HdU0=@vger.kernel.org X-Gm-Message-State: AOJu0YyZ8ayHSEb2JdIwuc+scq6wNM3uExR6Ajz0mYpYkAJ8oi50wbhn UyOtTlJoZtlVdJn84eHh0AO/iNC/kBVTITAhM4UeSViTwnaMCEqM01dh X-Gm-Gg: AfdE7cmCxaO/9fKorbcMm6oJcC+1bgT9W/ywx/2+w4HzZ9oqRGjk9mj4n7U1arDAxjP rrIWpro7+DLinPqRLkaAi8wnyjhCNIBu8A82aTxosfzrbK2EBX5RunqMyDR5AS73wFOZJNuuLnx IsLVUNXLN5JluoCmuzP0Vd/wbohHnxckvMc+s96t0TmY8c2AuLwdOMNe3LnazlLYzpQdXJBCgt0 eGtJVVgiugPpFO3K2BSaoUMjWzDITnl42028pvqmemZoxWSagrxEW7DE7GNs5v5AxtkwdNHd3U/ hAowkzdiMHVmrNzvKjNapTB8SG0cBjz8n8elqPES/r0F5FWB+9kpcfVD270gyMthXrjvArid5XG +bDXvGyXmIZCVZS+V+nQYILVfU54Gyx3DoAveyQzAvIQt76CqKb+b38gDo5VPJ8vcCqcijbUzkn +SYhsnIITf98QrZIKdBITJaIvDyJipwqMeSUxfjZPUSgDq7mJIinQ0Ijk0yIVsE2BAxvaz19iGP zQoPImIJavC46jY7BygKgwfDjZUasMa8fndRgkcd1cnpCVARw/NEvg= X-Received: by 2002:a05:6a00:3994:b0:848:32f5:4999 with SMTP id d2e1a72fcca58-84c23a2c08emr774796b3a.30.1784233798508; Thu, 16 Jul 2026 13:29:58 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f26f703sm5536776b3a.17.2026.07.16.13.29.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 13:29:55 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 2/4] dma: fsl_raid: set final bit via fill_cfd_frame() argument Date: Thu, 16 Jul 2026 13:29:47 -0700 Message-ID: <20260716202949.677290-3-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716202949.677290-1-rosenp@gmail.com> References: <20260716202949.677290-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The final-frame bit is now passed as the "final" argument of fill_cfd_frame() (as fsl_re_prep_dma_memcpy already did) and set in CPU order before the single cpu_to_be32() store, replacing the previous read-modify-write of the __be32 efrl32 field. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev Reviewed-by: Frank Li --- drivers/dma/fsl_raid.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c index 2778d07a05e8..888f55b672a5 100644 --- a/drivers/dma/fsl_raid.c +++ b/drivers/dma/fsl_raid.c @@ -375,11 +375,11 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dm= a_genq( for (i =3D 2, j =3D 0; j < save_src_cnt; i++, j++) fill_cfd_frame(cf, i, len, src[j], 0); =20 + /* Fill the last frame and mark it final */ if (cont_q) - fill_cfd_frame(cf, i++, len, dest, 0); - - /* Setting the final bit in the last source buffer frame in CFD */ - cf[i - 1].efrl32 |=3D 1 << FSL_RE_CF_FINAL_SHIFT; + fill_cfd_frame(cf, i, len, dest, 1); + else + fill_cfd_frame(cf, i - 1, len, src[j - 1], 1); =20 return &desc->async_tx; } @@ -505,16 +505,16 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dm= a_pq( p[save_src_cnt + 2] =3D 1; fill_cfd_frame(cf, i++, len, dest[0], 0); fill_cfd_frame(cf, i++, len, dest[1], 0); - fill_cfd_frame(cf, i++, len, dest[1], 0); + fill_cfd_frame(cf, i++, len, dest[1], 1); } else { dev_err(re_chan->dev, "PQ tx continuation error!\n"); return NULL; } + } else { + /* Mark the last source buffer frame final */ + fill_cfd_frame(cf, i - 1, len, src[j - 1], 1); } =20 - /* Setting the final bit in the last source buffer frame in CFD */ - cf[i - 1].efrl32 |=3D 1 << FSL_RE_CF_FINAL_SHIFT; - return &desc->async_tx; } =20 --=20 2.55.0 From nobody Sat Jul 25 15:24:48 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E7B22D47E9 for ; Thu, 16 Jul 2026 20:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784233802; cv=none; b=XCn3eGKUiwIwRdti4c3ZUZJEqDao6Ces1XYPxy8WLyxnH40RdVAmzB+kohcJJtz2lfsmXM/TX8FQz7+KxecqoR6AYD35+6tfgJTHGv+Zc04PyNECso0qYAyak0ZIsxuATfPL46lSeQzaX1RWB/Yxo7SeqiUjBxmT07bx/i8wn+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784233802; c=relaxed/simple; bh=wxjMkKsreed/7e27ZFCOcBPSRd1CCOhvpMtbH7hHHS8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fy/F0AdnYthANlmH+U0Xswc1aQjTpa6YtWCPULCB5vfgjVLYpL60G4P40vWjBZV/NqgyyMvKBNsbASUlz0rSWbnikloAxpJL9pIiz9LEaFeJBl/oH5JN0v1m5RSdzU9xVAAztEJhwmL8kqNUrcpXTHTXCeBzBVcBNI9Fe3L4vIY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hRBbhsTK; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hRBbhsTK" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-84864086bfeso7566930b3a.1 for ; Thu, 16 Jul 2026 13:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784233800; x=1784838600; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hp0UXZl7o8CuN52LDd3te+0pDBgn+7llmGMGyUuUZGw=; b=hRBbhsTKEdTg36fiC/xe8U63faTFdfBKjjswiqIIw+eKgdgV+21dV9+Awaew03yKuY pPM2Dscu1Q55GNH+y/17J0c0xVPXNnt9asJ/0Tcr7+NBuAUYPvrWe2XWOMhzjYP3ZW0y RXotSOTn/P+xZFf2q1kchymiGrIZYRcogqapqmrQluc1RDNx8qsRUkBOGxvZzzvdy0/i A3ToJfC48I5V57PI2HuOPM4Estl0rv6roaj0lexKj8ZcpZ7Waw95XKWUuBHkpSEyTe1B OULvSHtIQ8zUm9gi3NHZszQMU7b5006Jv9Dmzo/qPijH00b5V3osTzBMl4mGvx8Jebbi hJKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784233800; x=1784838600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hp0UXZl7o8CuN52LDd3te+0pDBgn+7llmGMGyUuUZGw=; b=LF+RI2tOYexfsNs23SJqBtcSoIMjDPjs/Tusj3p5uU+3vMF/Il8ZdoFpgLQs6olJGc L78Dmq9gxCWgsP7X+RoQ/ifPalhAlTtdYvjd99Ge9nc7L1AGaKs7TGSWbivyDh3NErBJ 6QHmXadIzGchOe9MHvUyIj3cvQrlj00xBQgZvOXOxMYaxdzyeOiMFkWAe9WDt0CW7kNY fK0mYd8f/ptp8E6e+YMI824j/QpTHW8ZoltmR10MojtKs63kwfK+bDSFWAxu2VBXiMP1 t4e4wCuJ7P2ezU8QzNxPVxgEA1zwU8D0NF41ATg7lB/I8wvwEYlE4q25JpAd95LQFOSv tP5w== X-Forwarded-Encrypted: i=1; AHgh+RrbP+m++DQxs2yGuTA3pACGx8Qlxjrw/87YlpRqcJDxjGyymagTDzlUnyFwAp3lZjmGqQg+mjj/nrXTvck=@vger.kernel.org X-Gm-Message-State: AOJu0YyegpfUD5gEZUIXH5Sc+bE/hc3d0RiC6BLqCRR7O3agiPPAuEM4 WRPsk8QJu/BmmohxfAs9r76OFrfQiQGghVx4U7X3/zg6ps9wh6C2xP/H X-Gm-Gg: AfdE7clg/WOdM34R9Xl09d9dsnAMy6RYAIPw2IShKuTg439MsxNgSkA3fDrUky9AaMU jD8/ne5i+iojWc6yVaP9m1qxQIjeQehUbgnbIsILKtVI5TgPBT+K9Rqx/FmEbiOrdV9nn4pUFBm M36pBJSq6gYMmXPAfHuSdxNd+8Q9/0/pwNLiZr+be1iQ3b2XqW0gqfSuGUXDyveBnKLon8uuqR3 5F7BZVUDXugXKuOKWYhe13yp4bIsbA62aqHYB9LD229nGQjYnXxmRlXfybYYvc/Al4e6Otm1kXp ILYaSnYj8URtneQTcTTpl/KM4rmIZNCeSiklVAiq29K0DK4yjO/YrGVgZFGwxYlLFqJ+OO1k9Ff aVc5ObAT7E4oIy+lji17FvehRSyk73oP9U33knc1OnRq2xvSK25cYFrSBD7x8U4nvVc4yIsFUlR LzvsVmqKBQe6WcGsKB7jmVV+t+iIl33a/1UrsYSHdET/xQs9ENuUN94Ou7hzIqLshkC/2PZ5J0t snErLs6n3bln0dwxzURkg6Qka0Graw0MZcF21GBEcATn0YOaVZEAao= X-Received: by 2002:a05:6a00:b87:b0:848:63fb:fd93 with SMTP id d2e1a72fcca58-84a55894cbcmr11883404b3a.50.1784233799713; Thu, 16 Jul 2026 13:29:59 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f26f703sm5536776b3a.17.2026.07.16.13.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 13:29:59 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 3/4] dma: fsl_raid: keep MMIO bases as void __iomem and cast at access Date: Thu, 16 Jul 2026 13:29:48 -0700 Message-ID: <20260716202949.677290-4-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716202949.677290-1-rosenp@gmail.com> References: <20260716202949.677290-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fsl_re_ctrl and fsl_re_chan_cfg structures describe memory-mapped RAID Engine registers accessed only via ioread32be()/iowrite32be(), yet the pointers to them (re_regs in struct fsl_re_drv_private, and jrregs in struct fsl_re_chan) were not __iomem-qualified, so sparse emitted "different address spaces" warnings for every register access. Store both MMIO bases as a plain void __iomem * and derive jrregs with void __iomem * arithmetic from re_regs, rather than carrying typed register struct pointers through the driver. Each function that touches the registers introduces a local typed pointer (struct fsl_re_ctrl __iomem *ctrl) and uses ->field, which is the idiomatic kernel pattern and keeps the registers' __iomem qualification intact. Reported-by: kernel test robot Fixes: https://lore.kernel.org/oe-kbuild-all/202008111749.yy85rFMD%25lkp@in= tel.com/ Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev Reviewed-by: Frank Li --- drivers/dma/fsl_raid.c | 19 ++++++++++--------- drivers/dma/fsl_raid.h | 4 ++-- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c index 888f55b672a5..524f83faf3da 100644 --- a/drivers/dma/fsl_raid.c +++ b/drivers/dma/fsl_raid.c @@ -657,8 +657,7 @@ static int fsl_re_chan_probe(struct platform_device *of= dev, goto err_free; } =20 - chan->jrregs =3D (struct fsl_re_chan_cfg *)((u8 *)re_priv->re_regs + - off + ptr); + chan->jrregs =3D re_priv->base + off + ptr; =20 /* read irq property from dts */ chan->irq =3D irq_of_parse_and_map(np, 0); @@ -746,6 +745,7 @@ static int fsl_re_chan_probe(struct platform_device *of= dev, /* Probe function for RAID Engine */ static int fsl_re_probe(struct platform_device *ofdev) { + struct fsl_re_ctrl __iomem *re_regs; struct fsl_re_drv_private *re_priv; struct device_node *child; u32 off; @@ -764,20 +764,21 @@ static int fsl_re_probe(struct platform_device *ofdev) return -ENODEV; =20 /* IOMAP the entire RAID Engine region */ - re_priv->re_regs =3D devm_ioremap(dev, res->start, resource_size(res)); - if (!re_priv->re_regs) + re_regs =3D devm_ioremap(dev, res->start, resource_size(res)); + if (!re_regs) return -EBUSY; + re_priv->base =3D re_regs; =20 /* Program the RE mode */ - out_be32(&re_priv->re_regs->global_config, FSL_RE_NON_DPAA_MODE); + out_be32(&re_regs->global_config, FSL_RE_NON_DPAA_MODE); =20 /* Program Galois Field polynomial */ - out_be32(&re_priv->re_regs->galois_field_config, FSL_RE_GFM_POLY); + out_be32(&re_regs->galois_field_config, FSL_RE_GFM_POLY); =20 dev_info(dev, "version %x, mode %x, gfp %x\n", - in_be32(&re_priv->re_regs->re_version_id), - in_be32(&re_priv->re_regs->global_config), - in_be32(&re_priv->re_regs->galois_field_config)); + in_be32(&re_regs->re_version_id), + in_be32(&re_regs->global_config), + in_be32(&re_regs->galois_field_config)); =20 dma_dev =3D &re_priv->dma_dev; dma_dev->dev =3D dev; diff --git a/drivers/dma/fsl_raid.h b/drivers/dma/fsl_raid.h index 69d743c04973..adbfede330a7 100644 --- a/drivers/dma/fsl_raid.h +++ b/drivers/dma/fsl_raid.h @@ -256,7 +256,7 @@ struct fsl_re_hw_desc { struct fsl_re_drv_private { u8 total_chans; struct dma_device dma_dev; - struct fsl_re_ctrl *re_regs; + void __iomem *base; struct fsl_re_chan *re_jrs[FSL_RE_MAX_CHANS]; struct dma_pool *cf_desc_pool; struct dma_pool *hw_desc_pool; @@ -273,7 +273,7 @@ struct fsl_re_chan { struct device *dev; struct fsl_re_drv_private *re_dev; struct dma_chan chan; - struct fsl_re_chan_cfg *jrregs; + struct fsl_re_chan_cfg __iomem *jrregs; int irq; struct tasklet_struct irqtask; u32 alloc_count; --=20 2.55.0 From nobody Sat Jul 25 15:24:48 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 668F1372EF7 for ; Thu, 16 Jul 2026 20:30:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784233805; cv=none; b=tID3GBt6EoTQGpyftK3gSWhFRPcZoL+RWGYu9WkigiL5+gPTbJHu6lDbicdun0srheudS3GFBLXVUTnsmFebUw/qEI+wo4sk+AyvZNt4oZk7boihCwQRBrwLhz1IpgmUlCGP0ZLBZXPqZv24ptsjqCeD3o8L16bh/x3C6GCj1iw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784233805; c=relaxed/simple; bh=aiUf3J/DMgL7A60YXutHrKt7mc+0jAQzbAUeMGys5WI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bg5SQb0yjjHz+f4KcKZ8KXw7vKRbFK5XR68du0ifJZQN/mWe2XZdu2FjluAUHUxHz5BYCs68an6rI0RyjZ95BpEK3ybnKRBAOxxxUuAHnmbofxdD+twaev4aOzmoRysbtYLSTx7mDAcusp+eU4DE/29qvNf9G0V9kh2RcjHj1KA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YsJPRtSV; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YsJPRtSV" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8485ef63b68so6581729b3a.1 for ; Thu, 16 Jul 2026 13:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784233801; x=1784838601; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=j86JWTDEYzHZnOUJNqNzQRfU3fCHXDlbngSp/YHU0R4=; b=YsJPRtSVBWH+IFzozQT0+qPD8jorJwKOEuJy3ptMJmJqC4rawgSgbrrK++wI5PTb+Z VMp05bXXMC0p2Pf4+/wMwmGebT0tJ+wIjZ0QC2TxFceblvUgsLil9C3Av137LDo9Q2q+ Es81T2fxhY0MNfDf47QKieK6T5NDrbmnLEGQoTjM6NXJnu+l6xkrzM7lJiSeVNI5fPOt bDrVeuHERr4+myV9Qjn/pBYDBgz4lHk1U48CzT2BUqBlcxcIi6YVwkEco4ElxcvxoW4J QE62N/SXN2jNqVZMk9w0qMDBMrS4kf6pRWZJe6+K1AfxPtc1OjHibIO5+Jhsou0k2daj qGkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784233801; x=1784838601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=j86JWTDEYzHZnOUJNqNzQRfU3fCHXDlbngSp/YHU0R4=; b=XzBegcNi0aVXirR+b/3t61dD1Zf8cfKmrh0Hq8lbR8caqc0BStRFZSdSSeyXhYQQen B3v0qiHWog7mCmTgSlcdDYpLzFpzIzC6th1cRzjun/4VX+dTcp/D8eN6itZGsiw6i5FZ /rRmcd4c9+iA4cI27evgotNXSudQxW5hyRkKfmCj4dkLN0yQsM/KXwlkDbCRGtaTnvso h0IbIds5NVtI2HTBIo5z3r3qIextPQ7QWJTnkNKm28nUsZrE/JacIQ/Ef5mC1mKTIdWF AS3VhN5jo1Bx41mHSGRDty8dapVnNBGSRfGfP9nzNqd2qAcprOMikovhYmk0z6K1LSMp RluQ== X-Forwarded-Encrypted: i=1; AHgh+RpzYbNFpnOe+WYXG4pg00JKJKqR1D9zScRZn+ZihXWlAU14P1S05MmbWprKgIiBY6m2ox2IWbr8pDi2SeQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyO1jgNnbJUlzKt8omnQ1zqywCFeM4fbKWW6MYQ7+mC9qg/wpkS 7ECSPp/okcF9gdXNs8bTmtv9ctfHX4csNyR1N8enxC5nvUu27FHpukw5 X-Gm-Gg: AfdE7cnEwu1wvfPRhNFfq0ZvvHu3gqaPJH4XY5wjLl6dErLkNFsRzinAe6XZs0QGdlj MMVDz+wnyIju5mruI6NXuxUqRk1aK8aOj1ZUo/X85ugpcjWofOA3R/zWlVDrdJDRUmgj4k0VtyJ xad+Yuydlt3b+yqRY5CHZu3f9Ds1EzJ1zybkGcTaEuS9/qwH3NfvmeKPE+mluBXipMndgOJ2WDS R4ZvIcwlqEGjKzhECMAWPcHH3Q0WRSgBblVN3LtDr03CJFRuLUIY6SFmKhIzxmKV3PXSw8oyEq8 HuhRu9jd5TfDVhlB4rr+yc+XMynaJ6HZZNcap94aHwVoDWL8ORawu766TorYmbmPeYcheCeoLgN +7PCPORHV1T8qd9ncPq9d6qMGBPsIrsz5gPVr1fwammLP7IYUCj6Edqp+5nbc8D09qfYBtTNvTq Z/SgpeTNIHLlk0VarvxNMNMkyqzVp8r4K8y/KB2zKIC9Yf5oPqIqTSfQqpZFaUindR0pNhLMM25 IXpJtr4ixQpec2DZNFVw0VX1fmutN13pPg7sCiZuuv+JDxpwAGqWy0= X-Received: by 2002:a05:6a00:6c86:b0:848:60d5:9526 with SMTP id d2e1a72fcca58-84a558201c9mr11417799b3a.43.1784233801270; Thu, 16 Jul 2026 13:30:01 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f26f703sm5536776b3a.17.2026.07.16.13.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 13:30:00 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 4/4] dma: fsl_raid: use devm_platform_ioremap_resource Date: Thu, 16 Jul 2026 13:29:49 -0700 Message-ID: <20260716202949.677290-5-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716202949.677290-1-rosenp@gmail.com> References: <20260716202949.677290-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the open-coded platform_get_resource() plus devm_ioremap() sequence with devm_platform_ioremap_resource(), which fetches the resource, requests the region and maps it in one call. Switch the error check to IS_ERR()/PTR_ERR() and drop the now-unused struct resource pointer. The raideng node has a single reg region (0x320000, 0x10000); the job-queue/ring children are separate OF devices probed independently, so the region reservation added by devm_ioremap_resource() is exclusive and does not introduce overlap failures. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev Reviewed-by: Frank Li --- drivers/dma/fsl_raid.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c index 524f83faf3da..2d86f61105e5 100644 --- a/drivers/dma/fsl_raid.c +++ b/drivers/dma/fsl_raid.c @@ -751,22 +751,18 @@ static int fsl_re_probe(struct platform_device *ofdev) u32 off; u8 ridx =3D 0; struct dma_device *dma_dev; - struct resource *res; int rc; struct device *dev =3D &ofdev->dev; =20 + /* IOMAP the entire RAID Engine region */ + re_regs =3D devm_platform_ioremap_resource(ofdev, 0); + if (IS_ERR(re_regs)) + return PTR_ERR(re_regs); + re_priv =3D devm_kzalloc(dev, sizeof(*re_priv), GFP_KERNEL); if (!re_priv) return -ENOMEM; =20 - res =3D platform_get_resource(ofdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; - - /* IOMAP the entire RAID Engine region */ - re_regs =3D devm_ioremap(dev, res->start, resource_size(res)); - if (!re_regs) - return -EBUSY; re_priv->base =3D re_regs; =20 /* Program the RE mode */ --=20 2.55.0