From nobody Sat Jul 25 15:51:37 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5580D20E6E2 for ; Thu, 16 Jul 2026 14:32:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784212362; cv=none; b=QqW8vQNXbtr+mwcB7q8k2V/gYQ+HKVomxjvlIsOBm8/877bEtLigxWUhyJQYQx4gDe+xPr6Dz4kaVBb8o3E0ZD4I9RTh4F2ZADFob4GMvK0CHYhvsU4w16/m04i4fo6Uk0OXubXyFsKIgSFbXwwA+y/RPCrWxNuM1amNh8Wpw3A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784212362; c=relaxed/simple; bh=xWFWLM6PPd4BC7Wru9yX1KPMY1C2JYqGrBIy6wgPD4w=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ZV9JH4+r07OG84CDg0TAxfa2iL3uPveqrXo8kHKwobcX/MNi4UqRcxZUecKmpKE9+xgBrnGQ5bSVNhsvIfiDQQT54R0AtNuL7gf0z1t2C/yN4FMIqEAJU2NTZidM3s0gPkKmVP4ak7giBEj7cX16N6PQ73KdEzr1Y5QrCVmXUM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PoDfzymr; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PoDfzymr" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-493ce08a75bso27470635e9.1 for ; Thu, 16 Jul 2026 07:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784212359; x=1784817159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=5f0QojCaRyOlV2E9YXj/J+35e8vJwchULBWmTPvTC48=; b=PoDfzymrNyVS8vT6so7/TAir7vfYvC+f7bBdaMPER/kZJE/IU4hOOczJbtmyThB9h5 Cb+aNKgcsWPP0hlrctQSbaoDgWww3PLW6TVUrfUUM8ejvbK+gTC5Pxjhnhoiyjpd5s19 P8tT+sXtwDY59GIJaXlIkRnihgXAXotPSe7eXBj1SlAy83cqYUpH55koJmIuxYovduvH r26mPsG+gt/Z0CF7t8M0Zirpt7VsZe0IoI53XeiS2B+Ii7JHub1VNOYCOHB05zwVfHYV WkwWNDFmYq2eox+7x3CuaMpWkGlG4Jo38HApk2P6mfyo75kbHhpHD6oMpJAvTN8Mrqvz gToQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784212359; x=1784817159; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5f0QojCaRyOlV2E9YXj/J+35e8vJwchULBWmTPvTC48=; b=oLOtGmdOH4XZf+k+dTbJXHQAo9LjnylQncZeMJl1X5al/9rbOnciso2830rQEJyh5Z aJn3BUUOceb1EYR5HHK91l5b/PnPIskovMdGvsIlDeCYEdJRi8cvJ2UtGRd4oo0GVmVi k2pnziK4CwHSDIL7rxED9Q4Y5Aa/JCCAJ3S31OIVUEf3JVhqjdsXSR5Fte6g5mlKbHlA ygWpeJjoGszqJL7j8zQq4mvbo4DIDUv/WtfW2GRX09Gb6JbzGM3Ukwr/wTnbvZtrHWGm 5aiGvYEpCejopqw4sDI+Md6DPg5dAbGFM/xUgKEBe8zd7A8W5/SKAVhW1c5T0jWbH4H1 BHKQ== X-Forwarded-Encrypted: i=1; AHgh+Ro2CuFC0MkR6b8aGGxNjwyA0uq81b6FI+6EUH8fd0bMVsVVBeJYj8Ctd7vIviXh+K3+HORJDrs22Lj6n7w=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6oaw0Un5s7P6r4YKS2RxrUm+MfIzhm23CfF83RPWpWJFkrqPS kJbYD4zyXXymCofWPMvOoiYQe+vhEiqpKKVaMZbKSEwdiHwIp6wav2mC X-Gm-Gg: AfdE7cmrvSj4d3e2h5b2zrK5wplwGl/XsI1bIJ4pDD8dGeZnBq7zNBB8Watx5vvRrSc iFk6BIw+AH3b6bMLXd9MFrYAByMO4NErNABlV3MEPXZLbhMU9unGqbZ/uEifUbxucur2tP82VAd byKc6EWDfbGh9Dqujtcsssa87itP4mNXv5QlSXt6JJR7SjtiToaAsyiHkGJC02fhwZROP4Ca4L3 ENqxg5OteDo1hLnvU1chFWxc46bAZMzaQahGYzt27Pbv5Q3kOolJFU5oZrb8r4YHl/Szp9zRyok ONmh2NSLYNYRRN3YZpzevFboECsECpoxlEvZD5c3h9QKdciLjBrSyKbivyETioVNucJd+CtdBjl JrRL+7zzK3ROzwrkM6HoAF4lsCCmHLubk06kveObwsWvv1Zt9rfiLcDy9Tvmq/uNiqrximv2H33 dhsRo32O7D0HAw6aT09t/mWDhpD44906OjC1QVWgz0A8Sty+Bwr/hVHMyXiw== X-Received: by 2002:a05:600c:6216:b0:495:4047:7ed2 with SMTP id 5b1f17b1804b1-495404780d3mr58319645e9.32.1784212359319; Thu, 16 Jul 2026 07:32:39 -0700 (PDT) Received: from ptb-02009389.paris.inria.fr (wifi-pro-83-187.paris.inria.fr. [128.93.83.187]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f4634e0e4sm26256307f8f.4.2026.07.16.07.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 07:32:38 -0700 (PDT) From: Ella Ma To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@inria.fr, Ella Ma Subject: [PATCH] tracing: uprobes: Fix incorrect __free function that frees an error value in __trace_uprobe_create() Date: Thu, 16 Jul 2026 16:31:54 +0200 Message-Id: <20260716143154.1091840-1-alansnape3058@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Before applying the __free annotation, the original version goes to label `fail_address_parse`, and does not call function `free_trace_uprobe` on pointer `tu`. However, after the change, the function will be called whenever the function returns. This makes the error value returned by `alloc_trace_uprobe` get freed. This patch fixes this issue by adding the check for error value in the __free function definition. Found by Clang Static Analyzer (my own development fork https://github.com/Snape3058/llvm-patch-revision/tree/cleanup). warning: Argument to 'kfree()' is a constant address (18446744073709551604), which is not memory allocated by 'malloc()' [unix.Malloc] Fixes: 8b658df20658 ("tracing: uprobes: Cleanup __trace_uprobe_create() wit= h __free()") Signed-off-by: Ella Ma --- kernel/trace/trace_uprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index c274346853d1..ccbdc96e5578 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c @@ -533,7 +533,7 @@ static int register_trace_uprobe(struct trace_uprobe *t= u) return ret; } =20 -DEFINE_FREE(free_trace_uprobe, struct trace_uprobe *, if (_T) free_trace_u= probe(_T)) +DEFINE_FREE(free_trace_uprobe, struct trace_uprobe *, if (!IS_ERR_OR_NULL(= _T)) free_trace_uprobe(_T)) =20 /* * Argument syntax: --=20 2.34.1