From nobody Sat Jul 25 15:52:00 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013055.outbound.protection.outlook.com [52.101.127.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5784A4229A6; Thu, 16 Jul 2026 13:09:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784207385; cv=fail; b=BD7rTUw32w3mRwNmZAIYJ4kSL5MytKivTbYzMa7VW802aAogI6CICnfX9kFqKbWFV6QpjfSz60YnvN1CKwme7uXanpXGg3Uah0pRJlEliC3B25Tu0B1qkHzVKV4hidfZ3Idy5fS7294bBiWZ5S8sNkAPGTkG9iVj0YjFrQnTp5o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784207385; c=relaxed/simple; bh=ibNreMuQP0jnbkLvc5HPzv5GugAKY7ujwDOeJXUPHgA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=uL0dmZMf1LbhGCkllPmPwq88bNnSiPW+CttmhjHt5k52gX+Yz1cKp+3mvWwRi3tVQXzvk80y7rgepf5OLxth470Kj58W6F2giNtSVpIfECO03VFxmTtsy5fVCgVvJuUTDwjj9hHMJADlFggrPTOQoK9z4vyb3AhbKrBCsNx2lcQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=qIN7NZ93; arc=fail smtp.client-ip=52.101.127.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="qIN7NZ93" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sFOJQTZXLexF5U3pyrkwKThdvzwi5u80TlH9xCO/zJjYBUrGI1yzhoXfq7qFBTesONIqOu9cT1l2jXHVO5L1ZKv/7LHsdu/sKai6RZNzH4yw+c86iay40bOIhEAGap2Uj7mtmhuWyFuBgUWJ0eAPvKr80fYdxMIAeSDHiTOMHVigsotUeCQAUOQHrtbgw8D/0TlvLbqw3+BVp6HyjVRq3Fcg9UyEBLznsF6d/VcAsHD8mgb1a3Nrd07n0Yocni7EXx9zEKVUv63nYMakLYI/Pj4vJ/oXSsJw3xLztDNdBR3J45irn12ZqCVOg4QFDJaoE1lqFTLPLLpJG0KOz1rGRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xizWcmAODdk/XomTUn9veexHLQMRsy3Ag6ncsMBhguY=; b=i9mztFnwY/iakRcc6pIEvEzPNV2MMaOPUjeU9dUle2CqAifMlnP5D4nj1/Jf+ETHgF1DUgI7hQPmdrlH/rgsgAWHVC/gupua8tc93jkxFqg90zHbHDMMzYsNPEHYFU1CMNaRI+8Sbh+krL/1gKhTORgrgiwA881gqqOYnzpsy5mDGFkQ2Va/Xuw3ntIAem+utyeCxmW4jGuOI4yro+CLzXG4ZhEQ9lzy1b9YGzGHX3AWsD6NJ0TB+NZwjWHSWFa5YmsNmBH0ruo8SIGJuHlxq5irqneSgF4vEXDGohxzUZ6W0O1oPlydYjv+C4fLQDj2iZRG10ZniltLv8ZZQXeexg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xizWcmAODdk/XomTUn9veexHLQMRsy3Ag6ncsMBhguY=; b=qIN7NZ93Mm9DIeyw7IyP62sr8y9J2ZOiUgVB70vTKmd9sZ4Nb/1Lhhc31RzpRm7dutIxbhnXmgZ2h9Z7m6CdlBKbD5a5exvfRv6+xE9PuIPpGqqVYyEET6YCPFNs/ho431x99GTJTabINVPBTaI/oHbN2h5RUvoHALi9B43FZziqeFUpbAOiuggLaALeVNqJUoQm77Vb4s1ZZ9dZwtdK3uS1IRcYhVlqLDAZuKRKmMJ9bvhGbpJM6FE5BMNz9Ij5/o/28rNeAa+6XWCWGs8uNoOzKskBnXknaFEgEr9+W2Dl/8zArLobXnRWh8QfQwg7FjaymzD9v9MQNkU7OUWF3w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEZPR06MB8885.apcprd06.prod.outlook.com (2603:1096:101:339::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.10; Thu, 16 Jul 2026 13:09:39 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Thu, 16 Jul 2026 13:09:39 +0000 From: Pan Chuang To: Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM MAILING LIST), linux-remoteproc@vger.kernel.org (open list:REMOTE PROCESSOR MESSAGING (RPMSG) SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 1/2] rpmsg: glink: Remove redundant dev_err() Date: Thu, 16 Jul 2026 21:08:29 +0800 Message-Id: <20260716130830.519740-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260716130830.519740-1-panchuang@vivo.com> References: <20260716130830.519740-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0051.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:8::11) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEZPR06MB8885:EE_ X-MS-Office365-Filtering-Correlation-Id: 842f34dd-1b7a-4873-36f3-08dee33b7de5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|1800799024|23010399003|11063799006|6133799003|56012099006|18002099003|22082099003|10067099003|38350700014; X-Microsoft-Antispam-Message-Info: KnpwqbSQHmt/LAT5w5G4MVRUhx85YSsCG1RPcpoCQm/rfxECcPPnoEGrTVPk+7JHV/xnvefpJwVFpL+FSgVm195PqW0iPwuRsEiShNeVBfgNfjFvsPRgN8VFn9HdZJWZv+UeItdB0J2DZFyTPkS7xKNBiQrRoGh0UeLYzdNarEi0N2qt3p3H8C71cgQkCIxP/f3Flp8r0Q6JY0B56ZLogbB6saIgpc7BGPNCTyMZMS3uG1bZVJffoKH2aUaWsV+hh5G5tI8XTOZkRRczSHidSW5k1fzChEtf+AFJ4YcG90EjtkZH7axCaXtu3rg1p/0f95rsI8RObV2UH/gMvnGbC7ZNonSyO/GlCL8tsURMIlAbsayR5AUFg4qzalgmERDrZN0OtxFTYc0LcAu30J/6P90JJuEZiyDSnP4uDAsPu3ieSw2TOaT/OPmF6cXnK5IUoq4iN2m+aG1NoTRE45jp32WLU5QlR3Y1vrU/muxrgJBgtXB+ZHPFyZUhskhLipcOLFtoUyyvOychVmzjIjQm/hQafLugl77W874/vMct6/5IUxX07J9tXShYG2U6FQ7OMnE1Ffap/2FeXI2AS9019sB8p51C4oT4sX+3DkXLTxetoKctEC65OgA6RKdSAcWdXgy7A+bpChGxuooZFuNvL5e5rjxZn5wFK5tvGy62zlDTdNMLciUzoz/9a9oNkhAqz73QORb7L3WAHUX+NBx2mspznu2oJe8qzSKFtJEvejk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(1800799024)(23010399003)(11063799006)(6133799003)(56012099006)(18002099003)(22082099003)(10067099003)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JCB9Z+zLsAag0AWPma90v8IQtU2pqZ6KZ4X5sCRkval17+a0fLsH9jDzMzja?= =?us-ascii?Q?+jRUn4ZKuD/3suxIlnrwKVEEiEg8pvZSMvh+vHmJH+DHLyyDQmhyMavOlQGh?= =?us-ascii?Q?P5GU445r1zIXvkYlAdPjglGLvO5yJx3ARlA8JL0fw+JajYQG4JEXYxunXOPE?= =?us-ascii?Q?w6hVDnnBMAfdVjiJbCMJ5YvDPvouBTEWt7HzlWLBnskg64O8KIl7AYjAg2XN?= =?us-ascii?Q?m9CUV/IWwpBq9lTeH+NUgk5BL6wTL9d8G8xZJ0TqHg1TlOV/rsXZDJu6pExh?= =?us-ascii?Q?tzk3B3ZlGgoKJkgYuQVsa9CHgmutOA/E6Hdp5rm/PHfBl+Xuko0j0j93Zmq7?= =?us-ascii?Q?RB8h+RY9slyZaNpLGDVvCNeldKd1E5Lq3twX7htCJBMwiQ0jwxIICsQgjM8c?= =?us-ascii?Q?hyo+RUNN6G8A8zg20wW7cb9iGIBSEej6b8hjNxtMV8XQFnHKWBtQafoU4w2d?= =?us-ascii?Q?njMGff1FLLDnkBl7UyPXPPQ/0CQ5xSF81B9hT7JPh0XMFSh8NVwV40NlvRPq?= =?us-ascii?Q?BPtz5fFCiDLRSV4gO9FJhM6BilM5neR1GWZcN+94AuvrT+wVWw5XR9Ncxl5A?= =?us-ascii?Q?Vxu136V0HPK4PS+8AJWENH4qLb4cLtn3WP6elkOnQOOG739X8VdbQL1btsgH?= =?us-ascii?Q?zZJHkPqVcOfkF2Uwh9Jtn8ArMDYnd80WH+5U56IZAihVOR3kJROosW4BuIpT?= =?us-ascii?Q?MwBgUL4Sy7DdxYgFOEQ92NW1ngGsCPnnLKJraxt/I4g5Hnrb0upcjLR+XElt?= =?us-ascii?Q?l6x47RCe5QMe7fho8BrRI+Y2a74Xy0dp/r1htFwyPVc1KUk5OLAwjzqhxqrK?= =?us-ascii?Q?uvvCkTutn1n2G8dmDOuJFQ2F3kU4BGx163WZscgbF+TCpoLr7GecEcPVVsD7?= =?us-ascii?Q?OGyg8VXL6+L0gQG16M0+qs0afCbetV330wYWZItX54MMvNo3J841Owa/aLGw?= =?us-ascii?Q?QF7/0JUheWNxS1BnFGV2CMvdWGiZL26t/zR51gm59ZvU4JFf5/BJ7QI1fHfX?= =?us-ascii?Q?ylbHo+qUd+/K3XAyVudQDiwFTc58q+E3AkkEkVCHt9rrChPD6ZNXlLmnwV6V?= =?us-ascii?Q?xl7j46BsnoOGhKtyVOSUZV6hTiopwbUC1448XMQliDiuNI0adhl82R8whKG/?= =?us-ascii?Q?RSLGkbS/aK4TP/zXn0OjULzNDSo+TSyWRE+1uVwr6KbS8vcjKVrgvMjSNzAP?= =?us-ascii?Q?TicELpFzBdXeFP4T4xh84Iq9Q+7jFhl69fPoK7Agg02o7dhDmjuTIpAdZTy+?= =?us-ascii?Q?stdwCxryx9TQyso493A8uuC4NLF8FxfFKmAbyzeSdklUc7bMJB247dFkdPYn?= =?us-ascii?Q?H3EB525Hwx+2Xl8ghByRuT9z6dUao4p+9GL/5sO+FV6GR2HEa8AJ3b70kzs0?= =?us-ascii?Q?Q8Rlesp8ndZ/NbCBJkOk7pEdbYO/rvRCw+WuS/cLb6UJyKn4RTn6PZGR0uxZ?= =?us-ascii?Q?bzjW62uqKb8DrhgBTOWR5WgdPuHccul2AtEgNO74fLRH/54int9ruHJ8KqWZ?= =?us-ascii?Q?0bxAz2GR1yh3dHoxfHLv6XGuCZ0R2gIDaRwgE2Dfcg2tSANf/fxSNpuXqKoZ?= =?us-ascii?Q?MzDw7/L1bs2Plw5J3xEs0lQrC02qXQm+A/F3a3I+b5j5ilrF8Up7BjWFOyQM?= =?us-ascii?Q?roAhsiOhm7794ityfHUbCWJXr6fNp8o39fxsrDzevh93Fi/OVgZ4Tx8mZR7c?= =?us-ascii?Q?AiGBZ+taO+W1gPfDZT4NDIYIlM1zP3tGUPb69cNDcH3E9p++AQULMvkwXc4U?= =?us-ascii?Q?0uei3iMlWA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 842f34dd-1b7a-4873-36f3-08dee33b7de5 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2026 13:09:38.9863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0xrRYb2ZWJrxaljXfDm1taxnrmrbN601XStaFsS5/+uKqanGo3ySv9SV/n6QxnghS8ZmjyOuLjgN17thr/bgGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB8885 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/rpmsg/qcom_glink_rpm.c | 4 +--- drivers/rpmsg/qcom_glink_smem.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_rpm.c b/drivers/rpmsg/qcom_glink_rpm.c index e3ba2c63a5fc..0662c0668f75 100644 --- a/drivers/rpmsg/qcom_glink_rpm.c +++ b/drivers/rpmsg/qcom_glink_rpm.c @@ -320,10 +320,8 @@ static int glink_rpm_probe(struct platform_device *pde= v) ret =3D devm_request_irq(dev, rpm->irq, qcom_glink_rpm_intr, IRQF_NO_SUSPEND | IRQF_NO_AUTOEN, "glink-rpm", rpm); - if (ret) { - dev_err(dev, "failed to request IRQ\n"); + if (ret) return ret; - } =20 rpm->mbox_client.dev =3D dev; rpm->mbox_client.knows_txdone =3D true; diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_sme= m.c index 35bb03e67ae8..2217a1573b16 100644 --- a/drivers/rpmsg/qcom_glink_smem.c +++ b/drivers/rpmsg/qcom_glink_smem.c @@ -315,10 +315,8 @@ struct qcom_glink_smem *qcom_glink_smem_register(struc= t device *parent, ret =3D devm_request_irq(&smem->dev, smem->irq, qcom_glink_smem_intr, IRQF_NO_SUSPEND | IRQF_NO_AUTOEN, "glink-smem", smem); - if (ret) { - dev_err(&smem->dev, "failed to request IRQ\n"); + if (ret) goto err_put_dev; - } =20 smem->mbox_client.dev =3D &smem->dev; smem->mbox_client.knows_txdone =3D true; --=20 2.34.1 From nobody Sat Jul 25 15:52:00 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013055.outbound.protection.outlook.com [52.101.127.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 155BA41F5FE; Thu, 16 Jul 2026 13:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784207389; cv=fail; b=Xp8hH4xCyicIeMdI+P+w18P4Yse0551O7ndR0rtBLr/M0llVYTu2qHlWeUwwgzAA1qaqq5PsqHgMMwKnfiW0SZPqnkrVP8X0j84/GF9DcmFR5KVXXkDInMJc5RC6Em7OoQjJlWifrOuPWUeP5/PPY+Xp73WK1ZdY86f01aACTp0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784207389; c=relaxed/simple; bh=1ELF5TFTUX04dnh2pyF9pTdaj3GqBR+akKYoHt68UbI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=q8T4tOzvcI0VtENxkksSXvbGKvEk3AVe0B91UnUSe0wDP4fb1N+PO8AhG9DIPi7skH/DCZaZT/Kv57LaLFBTewuIWG9fKq2gpCDgGiI4BEUKCa0bXOJWXz855T5Y63T8FjE0nhYVPvvBL+82GLdzssMkrV7rZ6DY8Jrr/ZaeJxw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=LMRQO87p; arc=fail smtp.client-ip=52.101.127.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="LMRQO87p" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qZ5pkXJE/5jLt6Xt6Ck326BKG9SFE5lVUY7ecr76gG15ZFKKnc9YtyFvjs0RikT9qp0VDkojyLyo5xJVAxCvxqHD5A2+40M1+cnwfUl5UV/VyRIU6x8L6li/aFDbTVkcAT3ekmKGZcqZVx/BTkuQul2UJ8/IUlHWOpw0eMBnggxGoEty0XON+w8O828rLs74qE8s6qsnystgMCCnhAdvPbZhcAE1tC0GErPNMC+dNXO6W9FBUL7fMbf9HZzkwrL/zXYlRuzQP2b6HtRgeJadcpDpzGQR047xPZdsbq5NMk6A2x04u6DIOSIW6ShwMfwBhfCNNwkv9VIsn9SnLqUBaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xf6n6ByRM3XHz8Ho+XC6M00j7+R0ttyHFOR5jS5J8fs=; b=kU2L5c4FZG9KrCbgxsVE3tv2pgaHt/Jg6TO898FjPaRHAYiVitUxh6xwyyLuCfHR+VTALvkBIafump8yeH5XAfSq8tMfXKiKQYKQO8bz3luVqKmIZapRf9jXtWdqtz6gZAuN1Z+7vAr9rc0fvfoVt6tqu+D5HPlmEskix7khNX6m0Pq/Vn+LSy651neg4SCzEP+1EplvvbrXdsKwRqZ01t01Vosz4fg9pmQYB0cGFYNvywDVNm0xXkWuajlMeNKvQUJiIm1eX74NA+j3jrhPFNhptUbponRUajrRnJOENYCqmQGUlmTB+oH9QsDBhJZ0Q1M019NW34UEECRqeITpvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xf6n6ByRM3XHz8Ho+XC6M00j7+R0ttyHFOR5jS5J8fs=; b=LMRQO87pa5mCWKx/ycPwRZk+1p/GR9xIfOck5UZYtYoy9WWjCJrzgdHmvncDpxOeQlEHgwWT9qzQYmhSAHxcSookiVDFkMOSuhg8E99FhlcmOY5aSfWa1ceGGER9L2i2JoI5e9m9C33GQGyLImiu7tjSWLjVGzziJRk7Xf0hi+8MoVpKU8m7qztInn4lWhGKZMhpNCZ6JvWWifrYtQvNTS5O1yE3R0p0xhiN74C10WZ8eezDYsaSg4jjMMOfwLOgI6VSfIJbWruWq3bnHwc+GhxlYRmkawGOvmsgO7CxUhHWnp+5CHczAOCkbEGJ1IK4OgrNiKWTNZYnc2mq8rs0Eg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEZPR06MB8885.apcprd06.prod.outlook.com (2603:1096:101:339::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.10; Thu, 16 Jul 2026 13:09:40 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Thu, 16 Jul 2026 13:09:40 +0000 From: Pan Chuang To: Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM MAILING LIST), linux-remoteproc@vger.kernel.org (open list:REMOTE PROCESSOR MESSAGING (RPMSG) SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 2/2] rpmsg: smd: Remove redundant dev_err() Date: Thu, 16 Jul 2026 21:08:30 +0800 Message-Id: <20260716130830.519740-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260716130830.519740-1-panchuang@vivo.com> References: <20260716130830.519740-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPYP295CA0051.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:8::11) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEZPR06MB8885:EE_ X-MS-Office365-Filtering-Correlation-Id: dada3b88-8868-4fb3-10c0-08dee33b7ec9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|1800799024|23010399003|11063799006|6133799003|56012099006|18002099003|22082099003|10067099003|38350700014; X-Microsoft-Antispam-Message-Info: kjrH+Mk7C9eOrOExIiZNGWdTuGiA620RG3KOGFMjTIE2BNrsyF1RXalv5ExTDh6+I68IowB/Izk4mx5bS4ExYE4Vt4LV1RDdXF7xKDKRNr/ZV9gbcU7sTE0pv0szE18evbKXdXoKioOXFCJkcLru8eZ6Tgn2rQoBf2qFdOgA4AM4S8YEYc2OQFgNzN7ZPm2FagdRj9yc/6sXXrlV4XsjBX+GBOG3W5g2PrwolORKzXvThODXUe9pwKTS2nGFbVtCGB2jr1GctNSnKdYMdbwPnJZKuJhJ+X/X854MqwzaE7hXex0f1nJHexueWfBNJPs2G8tc1u1SKAfehEbmBP6TzaDkrBOZRNqfjWZQgFAvVFTS+7NyutXvDa2iBA6fXhiiWrhhApCmBJ+0Il542Xj4PDGH8Mez4ZtPQCeMbLn5x+CMXEJy+SOMACuyb+ljotDG9lVbPrdWd0B2AtaQM9P6ikQyWj6Ea4/cALDnsrU0HeHQICjjMuxMEljmYlfOiEgjHJWrFqr1KDzFwUhYYYg2Ebnsdzc0myxO1L+Ds7yVYmS1oaq2BGoQhqTWgfyhuuYOObpcB+uFa21Natgi2U2JogtmV9DN3A3Nb7Gr0Lp/8Hl1h7rgVYBuKdz50GKwY3xA23UthlfwS+0htDViRLog9mieEp8C+j7newFNXF+VonNrgsc9TTP8y9eyjAR7C6kqoT7RRJ+c49YHMGFXj5Ws5pv4Mysen/leqFsxh/i1UfY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(1800799024)(23010399003)(11063799006)(6133799003)(56012099006)(18002099003)(22082099003)(10067099003)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0Z4EqhLLSffcPMPrdJ0pzjpFk2OLhxUM03w/Fcv43VGek4Ejk9tqqoPqaqBH?= =?us-ascii?Q?AtuF1ybdnqcfe9OJIaRfm6yk9vgK4x7MPvIaeIkPFXGb/nSnw6fYdA/v+Q6C?= =?us-ascii?Q?XK2GFM26hnC44f4jtM4XRG5GXmnbOlrEBYspkL7NHhii4a2f9KGQdnuhLJ5s?= =?us-ascii?Q?f96s2cd2HsgskOd59OLvh4MwcM58tEqpKWzuj0y4lkH/8s3LSFSNiJmiz5Ou?= =?us-ascii?Q?TeUriaHc/02nqdd/D0fgdeYm2ZGpMFoMMlSZ6ogd45BYVcGbyFzTe/H5UTRq?= =?us-ascii?Q?C56pYE4XOpE4dkzwRxMY0IRsHpmsCpDsBJG8rfNcDnMl4c9ufMIifyCNdmbI?= =?us-ascii?Q?oAZnT6mxWhwlYAGKiGCVFp6j7nKG2f2C/mgOQRU+OQFTmUrLgZ/JjZc9qOLS?= =?us-ascii?Q?I3dWUiXnRLFRz7iD89UfXWEIG+B/cptWqp5ImD9WfLm2YMm45njdrNQNJV/h?= =?us-ascii?Q?M8ngxtuEVpYWU2Y9SqESAzFPLweu7P7aHrgGG+bohahQBG0flLtMxYsbq4cj?= =?us-ascii?Q?BhM5g8OgF62aLHXm1fPlXySGM69PW+Os67gDZdbdr4IsEVYsrh39bxu+Fz7w?= =?us-ascii?Q?WFRCuLAfhClOheEfBZDzAlyEpTLiX1dLccqZzBmxI5ZZt+Aj7+/tHT8jsrDs?= =?us-ascii?Q?QSMnlf4jqWWBSFhdpSEaBo4lPCKpA9139xGBXWjggD96HM7SSNbK24NB1IjP?= =?us-ascii?Q?WS/nbiI3fGT9bXz7Hp4aYIr0vgeiI286wqKGTqE9cBYU0RMuyDQjwpE0ZymE?= =?us-ascii?Q?AUpX4nQt3r5VNl+EyjZMPqufkx/xd3BLcti1gP3Vr/Zy8QPKJpDiw/ipE251?= =?us-ascii?Q?kRo0ml8syaKcsUzj/KX2/YHLdvWmxh9G2DWZfBSMrjQsI4dKttf+ZZ/Cq+iV?= =?us-ascii?Q?FtQzK/m8Bo3/9p+ME8CXbxStuykfJWfQWqvpiqs6Q8I5T+cqhfAoAOq7AJSa?= =?us-ascii?Q?PqbKCCH8trYRuH+P2RH1Uct46x6lKqZv9qfhLpIaG/z6HaRS5W5cFDYIv9ke?= =?us-ascii?Q?vG6OJPLrx5gjXWvz3nL7lgBL2C5fR1Dnp8Bst483ZwoAv4/PKaqi+pQJfac9?= =?us-ascii?Q?/SWIIth+i5D1fzW1hi+vYdOHnq1qKqjGMxKBZQkez1RjiTw2XwbErPHgmqdR?= =?us-ascii?Q?AMIagBQVjTCicA35d5qvxw92le/hJWs5/pgXPRy72/cvGNrW3LcRAfx8TiPG?= =?us-ascii?Q?4LWBDB7mTWg0BQPtopjxiXuDq70YDP+7jkNoLe3+UFVMs6ees71UFZQowa2T?= =?us-ascii?Q?6sHpRzTrV38QKTbcfRBjePzym5D4FDmbhqoELcfBNZ84nPmj5CnWAmRf5Vih?= =?us-ascii?Q?BfasglprYRG9E8KeL8g6Tb/O5iaWuT3Zj2spDNJmfgcAnDKhvIO/jOn2aluq?= =?us-ascii?Q?QdeEttoxbHsdoGx+bQTqXkcdLA1rOca5mjnlXIpccHrQ1fAKtMPyLqzlHCm4?= =?us-ascii?Q?aCrcwx1aR+neI4gdGyYLs47ThvFJpd04GWQJJzJG7nd5vrNGba7s16LMgBHP?= =?us-ascii?Q?r+x5oZ2aQvQ+KwGdsRAOMpsLyfsp8DFVKPN0PdUFcafvZ8ymaWkHz17w+XW4?= =?us-ascii?Q?Mv3DKFr7PhXlBLtJ/ddH7AMoEjSaZNIoEiUoYAZt9/I+sA5tPFetGMnF3jwY?= =?us-ascii?Q?2Fge3+1b/EVb/dsr5e1Gm/Vb5GCyqdbjIZIqUirWRP81Xk92kAtD0qW0b+Ev?= =?us-ascii?Q?tx3b+IOH4ycYzY2g3mZ7zjKXSAJNZybuXidskZmHrcCww+vZkrldFgRXBFwR?= =?us-ascii?Q?sfOsH1XLDQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: dada3b88-8868-4fb3-10c0-08dee33b7ec9 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2026 13:09:40.4852 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GjZLYh5JWFJjtMmd5z9X3H8FoFjvzkv4Uj3nkU7jRkttWuPHt3K/zU3NtRXz60xJnxxzvueqRpQ/la3tfwWgjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB8885 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/rpmsg/qcom_smd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 7dbe1c6efe41..9a300eea190e 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -1421,10 +1421,8 @@ static int qcom_smd_parse_edge(struct device *dev, ret =3D devm_request_irq(dev, irq, qcom_smd_edge_intr, IRQF_TRIGGER_RISING, node->name, edge); - if (ret) { - dev_err(dev, "failed to request smd irq\n"); + if (ret) goto put_node; - } =20 edge->irq =3D irq; =20 --=20 2.34.1