From nobody Sat Jul 25 16:48:58 2026 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2BC61A0B15 for ; Thu, 16 Jul 2026 02:38:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784169528; cv=none; b=s90Xom04yeSa+HtX9B5HIpngAlWNypI8M5uTxv/CEi3TJGbx0tAfKsxwj9XmZTLxUPoHGDT8uhcLEOjeEOHDjaX6odj+ZNRTX8rd/PW0mTowYilnImuD2L9prg4OdNnWs/t0CupU208tH7iMFKIuYsjrNjGpoKD6gh7BuT4fy0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784169528; c=relaxed/simple; bh=GDywgNAAv1SeClmWk8TV/5ffCC5ejh0weyQI9rabPVo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=em/ucGdQQimeLQLdGy/NEMT8thfxiHuReY0BUifJZJIqzJhlYM7vI7W5W/yyMdFaO+xw52Rdv8PhM3gDcmEz5eeUT3hWu4RE2sFJj/Fb4kleL2JB03+DiLv9pg/3D8qhQhuKXSTgdWJkVfFtamnvUYXqN47uGpE1gGrcZlT66Fk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=gDJndlNr; arc=none smtp.client-ip=185.125.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="gDJndlNr" Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id AB71D3F2D4 for ; Thu, 16 Jul 2026 02:38:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1784169514; bh=SXgfO97DxS3/azhu0TLaCnZvyMLMyG3H3No7UV0iFzI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gDJndlNrsOXNJyevpPZ755a7lIexPQJtqrwG9yocs8jszB9XYo+8Zk4hO832l2h39 LWLOVRxweuJblQHfKAi+11yp58/qWk9YJWvR6QES0cpX40RCw4Rxj2/fQ7JsUEabE3 DcQGkkbjCUhsEjEWPAnmt3Vf/EbuXjMKg6k5DcY/VUi1YJwxvOXuLp7e6itToMN3pC fQyELWpPeEhe/MaXJsMvrN9AnMiBJD4YRCW4vZ07Xm7Aot2yznNh4xjnOK+UcBK7LY K2r5QF8mYWIm3VStNC+zF4YB0a0x8rkRKKeFYZmSjXk1funf3Qs/Wzj64aEcdDUaVj 3rEVVRAOMFLmJqoFgk9RCYdOkxUMk0UBoGCBMuLsaUZRt+a2Uqm17hJPnqzRltwqJ4 AX3DZZBH8fEHXzQdI9qAEwK9EQb4S2/d2fYmoNYOqrg89BtEpqcOKdMjpnvq7Vr6hF WY9ZZWYSn6X8A2k1EBemOAJgKQlN4w9uElG9o2+ww5xAkR1oWoJCgoyiZxP+CHPCka x/xFaiifrKl8AgLjPnh51sUG/MBlZIvbSJLDPyuvxjJsinGjtai6Zubi49E39m0vSD MKU+jqnjEQ85WmWSdV31HloOrBiGKJsUWky++N2AVmewb4SayzqNVh/JwZnzejtdKK JE3t3EAH/8pkPP5PsOZHZBNk= Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c88fc985a65so10861709a12.2 for ; Wed, 15 Jul 2026 19:38:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784169513; x=1784774313; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SXgfO97DxS3/azhu0TLaCnZvyMLMyG3H3No7UV0iFzI=; b=MTwV1IHhA2c3IyZfyH8J77BGiNW3kJrGIOraqYeSdCb3bBs25x1S+e9qUmQQQJBYuc X6VscDXeoi0aUGOQS66zn1rPXR4UyXxqPaBtGYKrp0R/OTz8i/oAqy8yaTdI/R52JRxb 016ke/lemD50lbOC/3S45OWWIdT94cJl7TcdssvegdFwFxbFeLjv5SxuePAk7rdHoz50 h2kBAKFwtA3U18l+JdrA0SOHPAep3ZlyUbU1ir7QPpyp9v/KbLj8Ophn7oYy5+h7q0uO 4fy+y+Kb0rwaJPynT1IhVSGvDwV5SNyDejqdYm5G0qTNBJV/sNQDUfIOnATiJXRp+h+C oLyQ== X-Forwarded-Encrypted: i=1; AHgh+Rrs025UaJKhwSpPJIZ6DWTb1uilL7T1Z0fURAcTAMlCqR7FfwNxkujRsvDZOU3/kJBLpkw6DefkzPzQEIw=@vger.kernel.org X-Gm-Message-State: AOJu0YzW2Vl7nxCe6FEnu4kMF1RmuLHbFqXYOiG16hL9mKzoUBwMm5Ln ccLISQPwYO5c+zyhuQ8ZCbVVd9Ze4+OKyQ1bemVN9kH5Pb5+qpnzHEmX0fpZgY4kScxY6Ebi/mI pZfcivu3ra0NwckSOVfeLiT4nEXO8xG1dZ86aP6Oxqm9JhIBhBYWtFE6vB0rmolDcCnarsMtrQy SWf/vBVA== X-Gm-Gg: AfdE7clXv64IqgvtSWakMbh5iYoAc7P/AwoGk8CBqWj/Y169qmCRS45YEiqiIVOJFNK VYKEFy33GdIgIdh3FSZ+dFnr5KPCSSDVsjsevUotqd9ADrlC+Df/qFepdcecpq5k4xZFjuHPALV PlG41zntvomWbXX1oxxzDPUqyTjz54zBxIp/PdDPtPWBAvyA2cZW8UnQOipddabN+VFU96KTuBC LJC4Qxbf1PeSAvwmtLXF5l7vVfSVixEs2xLGSElRvUfOxxJRvRQFnuJhRPoqBy17WCaU6hninJB CceAz7Nmwxvptck12Uw/M1GYCrcbDFjRR+/fjKtLW4EoB/wbjXBcfvJ4jYYHD4d4hfFpNQLKyM7 Fd8z1WImxwz09f1c/ic5ZJd3tr+comadGFRoAXY2M+Q0= X-Received: by 2002:a05:6a21:489:b0:3bf:9c93:ac44 with SMTP id adf61e73a8af0-3c36c1923d0mr5662668637.19.1784169512922; Wed, 15 Jul 2026 19:38:32 -0700 (PDT) X-Received: by 2002:a05:6a21:489:b0:3bf:9c93:ac44 with SMTP id adf61e73a8af0-3c36c1923d0mr5662642637.19.1784169512519; Wed, 15 Jul 2026 19:38:32 -0700 (PDT) Received: from localhost.. (118-163-61-247.hinet-ip.hinet.net. [118.163.61.247]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb258ff3c9esm1041715a12.24.2026.07.15.19.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 19:38:31 -0700 (PDT) From: Chris Chiu To: tiwai@suse.com, kailang@realtek.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Chiu Subject: [PATCH v5] ALSA: hda/realtek: Add inverted LED quirk for HP ZBook 8 G2a Date: Thu, 16 Jul 2026 10:38:25 +0800 Message-ID: <20260716023825.387532-1-chris.chiu@canonical.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" HP ZBook 8 G2a 14 and 16 (SSIDs 0x103c:0x8f94, 0x103c:0x8f95) use the Realtek ALC245 codec with a TAS2781 amplifier via I2C. They share the same hardware configuration as the existing 0x8f40/0x8f41/0x8f42/0x8f62 models but have inverted speaker mute LED polarity, so the existing ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED quirk drives the LED backwards: off when muted and on when unmuted. Add a dedicated quirk with inverted COEF values. These are speaker-only models without an HP pin, so the LED is driven directly through the vmaster_mute hook; there is no need to probe the HP pin at runtime since the configuration is static and known per SSID. Signed-off-by: Chris Chiu --- Changes from v4: - Rebase on latest linux-next/master Changes from v3: - Drop the runtime HP pin detection; the ZBook 8 G2a 14/16 are speaker-only models with a static, known configuration, so the LED is driven directly via the vmaster_mute hook. This also fixes a latent issue where the hp_pin branch fell back to alc245_fixup_hp_mute_led_coefbit() with non-inverted polarity, which would have made the quirk a no-op. Changes from v2: - Corrected the fixup entry so both 0x8f94 and 0x8f95 use the new inverted quirk - Simplified the commit message sound/hda/codecs/realtek/alc269.c | 43 +++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/a= lc269.c index fac781fca9d4..b3562c821954 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -3776,6 +3776,15 @@ static void alc245_hp_spk_mute_led_update(void *priv= ate_data, int enabled) alc_update_coef_idx(codec, 0x0b, 0x0c, val); } =20 +static void alc245_hp_spk_mute_led_update_inverted(void *private_data, int= enabled) +{ + struct hda_codec *codec =3D private_data; + unsigned int val; + + val =3D enabled ? 0x04 : 0x08; /* inverted: 0x04 led off, 0x08 led on */ + alc_update_coef_idx(codec, 0x0b, 0x0c, val); +} + /* JD2: mute led GPIO3: micmute led */ static void alc245_tas2781_i2c_hp_fixup_muteled(struct hda_codec *codec, const struct hda_fixup *fix, int action) @@ -3804,6 +3813,33 @@ static void alc245_tas2781_i2c_hp_fixup_muteled(stru= ct hda_codec *codec, alc245_fixup_hp_mute_led_coefbit(codec, fix, action); alc285_fixup_hp_coef_micmute_led(codec, fix, action); } + +/* Same as alc245_tas2781_i2c_hp_fixup_muteled(), but with inverted speaker + * mute LED polarity. The HP ZBook 8 G2a 14/16 (0x103c:0x8f94, 0x103c:0x8f= 95) + * are speaker-only models without an HP pin, so the LED is driven directly + * through the vmaster_mute hook. + */ +static void alc245_tas2781_i2c_hp_fixup_muteled_inverted(struct hda_codec = *codec, + const struct hda_fixup *fix, int action) +{ + struct alc_spec *spec =3D codec->spec; + static const hda_nid_t conn[] =3D { 0x02 }; + + switch (action) { + case HDA_FIXUP_ACT_PRE_PROBE: + spec->gen.vmaster_mute.hook =3D alc245_hp_spk_mute_led_update_inverted; + spec->gen.vmaster_mute_led =3D 1; + spec->gen.auto_mute_via_amp =3D 1; + snd_hda_override_conn_list(codec, 0x17, ARRAY_SIZE(conn), conn); + break; + case HDA_FIXUP_ACT_INIT: + alc245_hp_spk_mute_led_update_inverted(codec, !spec->gen.master_mute); + break; + } + + tas2781_fixup_txnw_i2c(codec, fix, action); + alc285_fixup_hp_coef_micmute_led(codec, fix, action); +} /* * Clear COEF 0x0d (PCBEEP passthrough) bit 0x40 where BIOS sets it wrongly * at PM resume @@ -4168,6 +4204,7 @@ enum { ALC256_FIXUP_VAIO_RPL_MIC_NO_PRESENCE, ALC245_FIXUP_HP_TAS2781_SPI_MUTE_LED, ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED, + ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED_INVERTED, ALC288_FIXUP_SURFACE_SWAP_DACS, ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO, ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY, @@ -6753,6 +6790,10 @@ static const struct hda_fixup alc269_fixups[] =3D { .type =3D HDA_FIXUP_FUNC, .v.func =3D alc245_tas2781_i2c_hp_fixup_muteled, }, + [ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED_INVERTED] =3D { + .type =3D HDA_FIXUP_FUNC, + .v.func =3D alc245_tas2781_i2c_hp_fixup_muteled_inverted, + }, [ALC288_FIXUP_SURFACE_SWAP_DACS] =3D { .type =3D HDA_FIXUP_FUNC, .v.func =3D alc288_fixup_surface_swap_dacs, @@ -7403,6 +7444,8 @@ static const struct hda_quirk alc269_fixup_tbl[] =3D { SND_PCI_QUIRK(0x103c, 0x8f42, "HP ZBook 8 G2a 14W", ALC245_FIXUP_HP_TAS27= 81_I2C_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x8f57, "HP Trekker G7JC", ALC287_FIXUP_CS35L41_I2C= _2), SND_PCI_QUIRK(0x103c, 0x8f62, "HP ZBook 8 G2a 16W", ALC245_FIXUP_HP_TAS27= 81_I2C_MUTE_LED), + SND_PCI_QUIRK(0x103c, 0x8f94, "HP ZBook 8 G2a 14", ALC245_FIXUP_HP_TAS278= 1_I2C_MUTE_LED_INVERTED), + SND_PCI_QUIRK(0x103c, 0x8f95, "HP ZBook 8 G2a 16", ALC245_FIXUP_HP_TAS278= 1_I2C_MUTE_LED_INVERTED), SND_PCI_QUIRK(0x1043, 0x1024, "ASUS Zephyrus G14 2025", ALC285_FIXUP_ASUS= _GA403U_HEADSET_MIC), SND_PCI_QUIRK(0x1043, 0x1032, "ASUS VivoBook X513EA", ALC256_FIXUP_ASUS_M= IC_NO_PRESENCE), SND_PCI_QUIRK(0x1043, 0x1034, "ASUS GU605C", ALC285_FIXUP_ASUS_GU605_SPI_= SPEAKER2_TO_DAC1), --=20 2.43.0