From nobody Sat Jul 25 16:48:31 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DEF92EC083 for ; Thu, 16 Jul 2026 00:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784161561; cv=none; b=jm7NUJSCz30t2CHTA9a3WTazDzeERrfHDYB92yPgz/T9SMCVUg6Mjzm/PURjAmhRJSZHCbcfcT5i+BbmeFeON4GpnKUZ0wFD9AA9XclDA08S5Bf15I8iv+jZ4IbHgixplyN+xBjWnHwLIytEzrs0WvK5lb/B05zgy7ljVNj/2Bs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784161561; c=relaxed/simple; bh=1e1N6xH7vqyO+MHhocu8Qhs6l+hP4MaAsyqHKWudrgk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SqnfV4fIaJCld1FklLzrHgs7M4A8djvtL/t6df75X9C9aSZ9aiOIcOId1q4LCI6vANtit+hLrUtQWI4z8AKS4K+NdBKLbs58BO4kgLqHZ8/M3clOooggcYVN8y2hy3yC0KgJRHlD/capDZBx8yaHsFfjrqQ6HaHXxfgZKYpbFDY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NpR2IrzN; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NpR2IrzN" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-8487088510aso6159740b3a.0 for ; Wed, 15 Jul 2026 17:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784161553; x=1784766353; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=T08FRuPIa7+44bxWiq0MXIRsXwFq6punNAYb/5OuNU0=; b=NpR2IrzNBqVsGmR4l0n2dDDXAeteHyX1LukgaRYb2MJtQBWx5JVKBlICcYaVshBSf1 JwN56nlgS0SknwLoQ9Gu3xwReAG+GDYSHOyP/yfsEcR5rc2EcrHjnQVff7nwRcrXV9hr FmXzhIvxl+oNjdYZRFY4WtKtJH0rXGHmu0IsUX7OoWiVInQzmr2NuMTDAzSFotzyIzIg QVGRHJTUNxKq3dh6FS/sZV+Iu7axZ0IZMwh0epnjvwtnXzvGbClJKytMhEARHADNWSjG 4WvP0D3D/CY+XRmDLw9Keq6QLS9wBsk2svsFtQcLG51yoF98CQxwY/SAlkYndOZGw4zw DKiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784161553; x=1784766353; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T08FRuPIa7+44bxWiq0MXIRsXwFq6punNAYb/5OuNU0=; b=UpXKdNB19fpFwH1wcrN+iH1rSLioBOt/FWyKo2T0CDcCnwVB+RrNsRYLoW4NFFYEdu WBH4Ly/1ED39LIkVRkcPu3onp244zIvgUqWGFGJSGSnooBh+kt5gpW0XC0zHFebldMqg Y9tHRNVW5C88B5M98ZWrtPEMOPj+v5+5tbsQTqd6JUJw1oeH6drh8BdxDxe0CmtqRVeT H5HZxNWzmEekO+5q12+hG2Rfkl5jS47J/LI5vJwNQoS8SU/MZWmAofCaxTUXknnjwpWo u+3gI0WtZ6s8F0JEs2qMSI3x9Rj4DR2kLcGuBr2RvJ51sQm50j020Yc26kkJ/Rg/R8u0 7Obw== X-Forwarded-Encrypted: i=1; AHgh+RoEYbG7wi1KKlNyLjscPl34rIgJtDiHAkv6jkpbgEnAitc1qFmNVKVwN6JTd+A/XcOCUVkgMJzI7veo3Co=@vger.kernel.org X-Gm-Message-State: AOJu0Yztu/SLLbx6XJiJr8KpWyYETsCCy47+ZcQVtcSSuf/WYZj1wisb F4hHVrl7zcvqPvY/lyzmFV9ohb1zAG8ehCBgWaTML9JWtzWj/P5exCYO X-Gm-Gg: AfdE7cmNBdoQ2R08IIruY9gDuZx3DM0D+Dnr5u/1EEK8uGKYA8a6EAim0dZGnBJHyAM 265zuhV5EnWbTcUMXSqKN8kF0hsGNUvPZbh3E8gfeMVbr9a3X9SOlRmsLJNkoYonEjLwnDjJy4P +vKsQCx5CTOlulRMvGlXWH4Dcb1jYfVDJtI6/5ZJVjKmdT7CZVtBtogiPaA79ND1azBKYITVA9D y59/o/xBIPRO3X6hWhcUizcsV7rqNS5OzHF3kdifRczqAf/RlBtC2bDF0FC9Np74mwGkR2hsJT8 dXePbBtDVHwU7ua0Qcwgwk1TFtnaqIrgm1Op6RMiQSoiHDIUqrcytnFuRTspqzHcHZs6350+unm MDjlakEhw/Sdsb3DclZrgrP7JA1nW3zwuzEsGwI7v+B9xtHCpnezvkKJxuo1y36dmLysaP2hT1a NFyaBL6l8MssHumJqq6UuIThOuzykHfwpEGNUoHAp6eFlVJyEqvgE5horhtuSzXfAxd4oYoWatm Usfd/b5dzj3 X-Received: by 2002:a05:6a00:2d03:b0:847:5ec6:3afe with SMTP id d2e1a72fcca58-84a5146e82dmr8476286b3a.31.1784161552958; Wed, 15 Jul 2026 17:25:52 -0700 (PDT) Received: from bloom.localdomain ([2604:3d09:178e:e100::9dab]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f6bf5ecsm3898485b3a.29.2026.07.15.17.25.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 17:25:52 -0700 (PDT) From: Ivy Lopez To: marius.cristea@microchip.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Ivy Lopez Subject: [PATCH] hwmon: emc1812: reject channel index 0 in device tree config Date: Wed, 15 Jul 2026 18:25:43 -0600 Message-ID: <20260716002543.26711-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Channel index 0 is reserved for the internal diode and is set unconditionally before parsing child nodes. If a child node specifies reg =3D 0, it silently overwrites the internal diode label Reject reg =3D 0 in child nodes and improve the error message to include the invalid index value. Signed-off-by: Ivy Lopez --- drivers/hwmon/emc1812.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/emc1812.c b/drivers/hwmon/emc1812.c index 68575c27d090..143c3c07dbaa 100644 --- a/drivers/hwmon/emc1812.c +++ b/drivers/hwmon/emc1812.c @@ -809,9 +809,10 @@ static int emc1812_parse_fw_config(struct emc1812_data= *data, struct device *dev =20 device_for_each_child_node_scoped(dev, child) { ret =3D fwnode_property_read_u32(child, "reg", ®_nr); - if (ret || reg_nr >=3D data->chip->phys_channels) + if (ret || reg_nr =3D=3D 0 || reg_nr >=3D data->chip->phys_channels) return dev_err_probe(dev, -EINVAL, - "The index is higher then the chip supports\n"); + "Invalid channel index %u\n", + reg_nr); /* Mark channel as active */ set_bit(reg_nr, &data->active_ch_mask); =20 --=20 2.55.0