From nobody Sat Jul 25 15:28:00 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D60C429BD8C for ; Thu, 16 Jul 2026 20:01:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784232099; cv=none; b=CnXCAc7yRc/6CmSI9dVKy+HzBX2XE8VYXTa/KJUvjOPOEL7L8EfXlObC7ITLstlpLF525X6gdaR/nD5ODOoouXJh46zL2lzEpl+yS84OAcNxVXyv3P7tAgkRrohdQ+BzJy/hnQ+GuR1qPwoIrjfolNHtc7pNL1XYOm4FcxN2XWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784232099; c=relaxed/simple; bh=AfgwtvLUNhoN8yxW0/rij6cUaoJlxhV+qfVXjrqYeyk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Gt9BxiM12IzC1LgF67m2xI7HgEpqKsNP4q8nYzzOOyxGY43sw0eMjbCFoaQgLzYMeAJNxWbtERwGU37WI0/5RiE8dcI8nMmxCFOtlgUoNctVOQIULcpm/9fwvaNJxEtZjzRDihsSDlYrGe1oaEUpRf/lZgjHW8LLiwkqLFHxs3U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RCABxmpk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ahsPWxqr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RCABxmpk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ahsPWxqr" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66GJodje3791898 for ; Thu, 16 Jul 2026 20:01:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=LJYuXI+l3H92FDVQZkdHpw i60M9fwa1cK5EJ/lFjmIA=; b=RCABxmpkxGxT2TEx6LfSYotaaCzJolgaG/ZtKL GcyYmgHfQH/8Eb+JJCpL+Cqr6M57URfwVO0a08ECyVjLuurLNOz7MmKwoNnlE8/f sOUAxGbO7Q+CF6uCSnVe6WUcA2l3O9M8HP+Jw/YXSi3Oach+sZ6KFsDLAuSH1smV M6qJ+kQE2DGLuKhsaV1gZuOjV3JVUwtFk/auIDf7ZcKWV/wr5oALnyDTEjSB1Ks+ jYVEiBdYgJeWTl1ecNg6cAZWmLNCO0vZFPFp6+z/2nOkCOSPBZ3WR7S7OlE6OkNG DoU2eReRsuHmUMbPqyFqYv5+OiKdnU6/iFxr+WnQoajgPkEw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4feve1twur-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 20:01:36 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c9667280edeso8289930a12.2 for ; Thu, 16 Jul 2026 13:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784232095; x=1784836895; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=LJYuXI+l3H92FDVQZkdHpwi60M9fwa1cK5EJ/lFjmIA=; b=ahsPWxqr6vSK/ccJ8Jsr0Ascne9z/7poaKTCZjKpcxSGZiMCfafQNCSDCdNCZWxx4o QtUDk+/eYJ0prjjfdWAacp+z/S6g/+fnvC7hjo3w6dRxRO3VBZSGvSj1/I7PissE6XZi cgEhPvUhc44XJVVe1pYEs6gjurex7gErda8bOLTZNRAcud8RGHMo7jiIHHPMy8enVr7b PKpE/ssACpHbZrhtEiF+MODL5F3puvH/l//b6mz1FirzuIZnM/sVONpAGYLA3oD9g2wI uyG09zqZ69bJZHb5qh6XukX4Eu6Fv49o21L/k8kXYg0Srd2/2XGTixogzhtL/NRkJOsE 1Nqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784232095; x=1784836895; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=LJYuXI+l3H92FDVQZkdHpwi60M9fwa1cK5EJ/lFjmIA=; b=b4wseOjaMjGVCRHVNP4r58ZFmitSXrLmqWcSaA1jDMXMqZhZEc7ZdiSVYwUxVe0map USCadAtGPqYgN/JONCJ9m56BkmEB+p7VE5NhM29LOenSqWnNM/0gBCxdmGjiLeorstvD kLcFgXBKOz1RVidWzHV5hPXJnx9/io1xiVE5XUazoUtck6aHyF4FWk18tFQff+dyuiZ9 KRnqlPXGznnJnjRTvq6A4nWZsyEdhBHPKlPU9uWtD7g75g004RgzH5FBIflrCuY2E38x rbzzf425y0I6spSAPOBUZ1xjjJ3/eXbWvARLgeiaR0Uz1K8vbEs8rSICqfdjO6oYP6eh hfKQ== X-Forwarded-Encrypted: i=1; AHgh+Ro1LzVcA1l1Uxu/PmkMVuP8LWr+/T9FKNmMqJFC/8pAvtrV7qnQRNZ7eiRFZz0PnE8voupZZoAULjpNd5U=@vger.kernel.org X-Gm-Message-State: AOJu0Yz33/47uJBxtZZVaTIRGwcGJr6+sxVFKLqmqOo5476VcIIiVj1I 5h0s6rZPrALbNI4R7AYI3PkCPBDUnwYRpBimuxpMB7NdjWAdfOxzT4kttXRKp+j5yrmoKeD/Fym +dAVCzm6uvaBttgKgNmLrnNwEW2rqdxTO/rAC046GTRR7ADnmIF1ALQs396S7e8p9l1s= X-Gm-Gg: AfdE7clDvt2ULOSvpnu2rmdIa9B9q0/Lm+ZUdX8+wM4l4vLq0V9b3zc2N4ReAjFdx6l LAZTOraJiF2A1IzQXQ3XKs0+wMVfGjqiul0Ia9OD65XoIiDso0jIveVtFib8KRlpoI094co4VPH lFBEvfxh3HyhdPwFoyQDeEq8VeCb9MpmVg/fRtB7hM5MwfyoWOFEFt2tIIBeaZpfBX8enWPRLvw DzPPoqDPkI0QWKvXiloFdaZLIjWjUxzFXiX8ym0iq5551QnzhIZ1vf7YDLbXm3+4bkVi4nDr7rF nnxixVcOrPVQGvO2QuognuelZl3G5lnFdo8Y+M9Qin6XCOxf4rdarhyrVMAHtdjMFWlrk33OqLf Al3JptXZOgOYcrSHdDmZln5vablFPQ1g0eJMhB/O5772KsZHWlj1BIuY= X-Received: by 2002:a05:6a21:4882:b0:3c3:7cf0:3874 with SMTP id adf61e73a8af0-3c37cf06741mr6718741637.7.1784232095451; Thu, 16 Jul 2026 13:01:35 -0700 (PDT) X-Received: by 2002:a05:6a21:4882:b0:3c3:7cf0:3874 with SMTP id adf61e73a8af0-3c37cf06741mr6718708637.7.1784232094986; Thu, 16 Jul 2026 13:01:34 -0700 (PDT) Received: from hu-jjohnson-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3140e6ec32bsm11998196eec.29.2026.07.16.13.01.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 13:01:34 -0700 (PDT) From: Jeff Johnson Date: Thu, 16 Jul 2026 13:01:31 -0700 Subject: [PATCH ath-next] wifi: ath11k: Avoid buffer overread in ath11k_wmi_tlv_op_rx() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260716-ath11k_wmi_tlv_op_rx-overread-v1-1-0b972b3f1368@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAJo4WWoC/42NUQ6CMBBEr0L225IuFjB+eQ9DmgqLbBSKba0Yw t1tOIE/k0xe5s0KnhyTh3O2gqPInu2UCh4yaAcz3UlwlzoUsqhkjaUwYUB86M/IOjyjtrN2i7C RnCPTCUKpjDRl1aKE5Jgd9bzs/iukqZhoCdAkMrAP1n3344g7//MjokChZHEzvTrW6oQX633+e ptna8cxTwHNtm0/+YW1edsAAAA= X-Change-ID: 20260715-ath11k_wmi_tlv_op_rx-overread-e104a0a56c10 To: Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, Jeff Johnson X-Mailer: b4 0.14.3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDIwNCBTYWx0ZWRfX1XhvtHed7E7z EHTj/eNIgKppiNNX7EIOOYO1JkLsHSKjyNBk69po0SO8NR8LZSBnsda8b/tLyXD4riQBeb/VlCK +AbdCXH/My3vqxkxTaz7ukiKefpmFPHPq886cjEZ6hJTvPpP1x4q6fsQ+QAJSEug0GFN91MuQWQ 6EFE5nT8Hdt0DoBh/pCjoM04SiVICuQLuwtxiY0NgGWAvU1Fu2W54svrbLxexE2uMnZTUyBfpVP QF5bnsZZtqGJCprA0mYt2Cw/i7hJFrBWr+KVsDggmPBSJ329zSkLJsPIkxGj3NUpqrkXJcEWl/U GzVx9ynYFCl/k9nSkNYFHEyyWZ8sNhQDa078Rf9A9cnYYYqyoH0CgjhA7FFtVnAgZdfUxnS7s1u 5gnSa5Y9AMrYGixDzNLRvRRHwwCAImahixhODParyRzP/erN1JRe15VN8ac0QgTPRzFxnDwWY73 3M+Zbau/iei1/RuN3LQ== X-Authority-Analysis: v=2.4 cv=DvpmPm/+ c=1 sm=1 tr=0 ts=6a5938a0 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=Tx--mz5Y_93-EySAq90A:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: EKWNxkVrSugXCx02SQkLWSVSq-O_zLNM X-Proofpoint-ORIG-GUID: EKWNxkVrSugXCx02SQkLWSVSq-O_zLNM X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDIwNCBTYWx0ZWRfX5kfKPqSBGPnA tHmPSndtGfsaRsFHY22d11vYkhxdsgmXAgmZJS22RLaksuiOqA6G1cJBThcTSSvUCIQEJ5VCBrf VZoho+9suazlpv8C/N4JnGRusVPUahw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_07,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160204 Currently, in ath11k_wmi_tlv_op_rx(), the firmware buffer is read without first verifying that the buffer has enough data to hold a header. This could result in a buffer overread. Add an upfront length check before dereferencing skb->data as a wmi_cmd_hdr. The check is placed before the trace_ath11k_wmi_event() call to preserve the existing trace semantics (tracing the full raw WMI event including the header), unlike the analogous ath12k fix which could use skb_pull_data() directly. Compile tested only. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Jeff Johnson Reviewed-by: Baochen Qiang Reviewed-by: Rameshkumar Sundaram --- drivers/net/wireless/ath/ath11k/wmi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/a= th/ath11k/wmi.c index dca6e011cc40..b10f0054c81e 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.c +++ b/drivers/net/wireless/ath/ath11k/wmi.c @@ -8895,13 +8895,15 @@ static void ath11k_wmi_tlv_op_rx(struct ath11k_base= *ab, struct sk_buff *skb) struct wmi_cmd_hdr *cmd_hdr; enum wmi_tlv_event_id id; =20 + if (skb->len < sizeof(*cmd_hdr)) + goto out; + cmd_hdr =3D (struct wmi_cmd_hdr *)skb->data; id =3D FIELD_GET(WMI_CMD_HDR_CMD_ID, (cmd_hdr->cmd_id)); =20 trace_ath11k_wmi_event(ab, id, skb->data, skb->len); =20 - if (skb_pull(skb, sizeof(struct wmi_cmd_hdr)) =3D=3D NULL) - goto out; + skb_pull(skb, sizeof(*cmd_hdr)); =20 switch (id) { /* Process all the WMI events here */ --- base-commit: 0ceb105245b5e57f803bdc0e79dc077fc06ff384 change-id: 20260715-ath11k_wmi_tlv_op_rx-overread-e104a0a56c10