From nobody Sat Jul 25 16:18:39 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE46C30EF63 for ; Thu, 16 Jul 2026 05:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784180598; cv=none; b=up/cCg5Pf9rAODgI0o7T8Yw86nq+j2/RqQNTjIMf0hjtLe9uSYXxWE7Qb6eO8RDAAwNo1iONiSMdIKRHTBfmaTNKNn38HIMKG2Z4R6PBQANCVcwVCJ9maU7ib8Qy0pssQdJy020jZSdD597SiEVvPqsFBIKMC+g8c1tqa8F5Bfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784180598; c=relaxed/simple; bh=2pMzY50Yewyh069zifH4G518lDVvi5A9FYRO0la5M2k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=cUIlE0zX8HSoRAIIUf6gXwSMk4Zbx1whKuRuAOyezA/FvpcE0PqZ/1Uzzrvlz+R1vh0+ctDsy1xPzzCYJC2aQyhhCj03tUYM4bIKmJGJjhQC/JclCUyEdz8Ml26mJ17Wd+ISKzATY9SdlKQJTwgkxhj0STvTt7XFEmWgbN5TU0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IShj5+QV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=i7bNGBg8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IShj5+QV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="i7bNGBg8" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66G3wPir1299437 for ; Thu, 16 Jul 2026 05:43:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=Ekaw4g3lu7lYnrfe0X7Vk1 KWzpL+GeT82kT0/uffDo4=; b=IShj5+QV+JDFjrDGKCHMbXI6GLSSICtEWjP6V2 5H70VcthtzFCkkXty7dsLq+nQ0V8AFA2XvvYBtTTjvBYWKsO1hpretdvoQZsIJlB 2q2misuEX1doRkpIjtrl0h7do92x+LUXj7ZiKypU1+J+s+0eaJv0y2K0COAsCNqM g6YCANcMQ2VcXBqHpoI10iNMGrDp2FoDZpNe2oZc8U7x3ZVm0re+iWFQWXI2/g7A Fg+861orX/TJ5d/B0NAB0EWctPrACyTPgf4LWwRJ2nbYhkBTTGg9mzQPZRMZ6SIO p8pYOKTIWIXDlDfujURZe7YxFzKgXhSJOeJ/5sfKK7V5aJ+g== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fed062sn5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 05:43:15 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-84842381150so11084068b3a.3 for ; Wed, 15 Jul 2026 22:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784180595; x=1784785395; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Ekaw4g3lu7lYnrfe0X7Vk1KWzpL+GeT82kT0/uffDo4=; b=i7bNGBg8xQ24oMpaOhalmGnk+NGUKsuEx+K1JRZT0SYHm6Fuc916ki3+ZC7YiZCcjx uR2rKboKa6dREaOUqdPCsS8JfnhNoudGvOLe5c9KxwXT5JQUtsbSTY57Xxwn05T8Ti+g wpej6uT5NH7nNf08LJ/suv4rpF9s9EQJtQb5p57Er+mOsQegvxdxutLD8JRsefCZMWo1 OSs5SBti9ooQRwZlwzI+lFDD0SClIXRYmAnMgieAxq5suvP949zJFYyEpqXIRkBQJivA p2zIY0Y7vw1aPqCInuFysLSENdfIBYY7B15QLxVGVY+X/U5pGo/X2tUFSQ+RvPo8T26X GVkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784180595; x=1784785395; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Ekaw4g3lu7lYnrfe0X7Vk1KWzpL+GeT82kT0/uffDo4=; b=HLD4WzxfNiK/Hv7jNBk+A5X1gDYuFRHMGKEHmNYh7zJKlcQSfxH9zX3EV7/QNWXQfM fA4An3Vsxw5f49Y3SgBMAOWl0ksBz5crbOiMN6kRE+BcBdRIkqkpL2jJEsYKVbdWRNUl oEz9iEcv5zWhrF69Cj50kj0yLCQXLXR8P34cK9OYYcGdJ8dUgtAwsLxtdoaSG56NARwf cwaatj56eIHmX8V1NNji+B7ZzlRk1BPPmNWfkIaPXQU9do2lK0q/kQVuvEEkviv2S9Uu Pe32AInEDKk/Oo0Y3cIxcBCp2UjsyFc2pd5NJrSZaUj3H4rXrbZyi0qDlAFBMB/EJqCC 0UdQ== X-Forwarded-Encrypted: i=1; AHgh+RrDJxzmGi05aj+KZ/gViDjoBfec9/QR2sDJsQ88PIE3XaFP+o8xruo4a2vEZA5XbuBIO5yf0YV+F6wUplc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywdl+8YppkyOxWPIoR93rqHxTvpTcE0sxut5xUl4kvnLJ/phZoG ou0ZDAkxk60+2bvYwg0TXPEeUBEdyFXzce1U4R1loww4aOSqloYuxLScGtyk10Z72+ytBLo0PsK N4D/tiUikaTe3cPE70f84iVj9MVZOmvg8V7QmoBWc2qXE+wAZmAEa2eD5A+pHBgvKr/8= X-Gm-Gg: AfdE7cmkJ2vwAqIHf1KeU/AxbhevwF9XuCi3lYG9lOXvypD/FnQzwmsex/th40VjzsG gs19+1F60f5hFkYl/+yuGChkrwdnVidqlC2JLifxU8pMXYSfbr3fYI33kdo+Whu+S7C/fF+s1+D H03t9/5/hCgKic2k+ydxzscCcjYRrwQhZzpQY5JNcRoJ+wk9oweFBpypHJyJ5lFMZyRJcpHZCk0 RHpqjp9GxyRooiqW+noeVYQBfmt/KhaN0gI3eIu9szH0DXqzL2wPKTrLvZOU15Ajpv264pmngnq AL8EdzdUlirB2YW3hmrq8rKg20ty+JWt5usf7nwsWrKhrVv/rilagLyCqbkBKxEKyz13VqrYhUg EC6/cRutDDgylTmV1sx3iThuC0fqof075B0vZkw2CXyDDRmSqDIuwMewmTSR2Y1Rt+SNzLChSp4 DudukV4Mteu8A= X-Received: by 2002:a05:6a20:20c3:b0:3c3:834e:89bc with SMTP id adf61e73a8af0-3c3834ef3f7mr2742146637.50.1784180595048; Wed, 15 Jul 2026 22:43:15 -0700 (PDT) X-Received: by 2002:a05:6a20:20c3:b0:3c3:834e:89bc with SMTP id adf61e73a8af0-3c3834ef3f7mr2742120637.50.1784180594589; Wed, 15 Jul 2026 22:43:14 -0700 (PDT) Received: from hu-mdalam-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3140e6f0dcdsm6407084eec.31.2026.07.15.22.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 22:43:14 -0700 (PDT) From: Md Sadre Alam Date: Thu, 16 Jul 2026 11:13:05 +0530 Subject: [PATCH] spi: spi-qpic-snand: Increase ECC strength for large OOB SPI-NAND devices Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260716-8bitecc-v1-1-6eef4bcc3a14@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAGhvWGoC/y3MwQqDMBCE4VcJe+5CTDFWX6V4MHHa7sHYJrEI4 rsbao//MHwbJURBok5tFPGVJHMoUV0U+dcQnmAZS5PRxuqmsnxzkuE9u9bhOho0ttVU3u+Ih6w /6d6fHfFZCpjPkdyQwH6eJsmdClgz/9Ga+n0/ANBbfYKKAAAA X-Change-ID: 20260716-8bitecc-b9be3d2e7690 To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Md Sadre Alam X-Mailer: b4 0.14.3 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDA1NiBTYWx0ZWRfX37C+lGHV9V8w hx7jE5KzI0Yt46kzzlNhH2JTEpLvGD6aGwAodavldLY5L01yWhxU2kZHrJeAs3lsFV2ZxP60FgH Hl7Q8CKEICgS0d8cRMFNSNa9bjItOCw= X-Proofpoint-GUID: Z7AGwjXtb02b38Q_xUmXbo_q2EjM2NBv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDA1NiBTYWx0ZWRfX4it4DVWSQ8u9 H/isoUYqTEuJnRojr5V1KEyaDBUfgpn8wS7IExAtgCQ0sS+1FO6D0zwVi3urAGpdy6I6oMntdTj bvQy3wU7KLXfp8iLbbBCu7i9u+VZmKWbJ4s/KBpQ4RDZY+I8RKBZdWPWH1SzOHb1Tk+meQ7/hzH N210pL2ZbPXZL+v6hD3yOsap3w8/YXJl9ARZE+XnY7WPOS1agwayGelzwSVwOycMd2jGqvp9z9l fwpZpNIiXlGS4OXYMaHXfUZ6TarYF/CBtptm5IgfiHeYjjv17A6qOzbFFBdS2BYbCJoqFF4MtyE QbCi3UyQRszsMiK0832I7BAgEP4ExPxdO32sNINMetem1XiBthsitRShPdOn0Xo38Wc1vbRY9Nv PC7+xjGdUJvMcDCtqLLwLTUBBxczXEOe56Ehd60GRnbkjoyDVTf9BV8kKhuv0p+hXFxYCuXV9m8 Z/tIAkMkWuK8ZuPPXWw== X-Authority-Analysis: v=2.4 cv=Xb25Co55 c=1 sm=1 tr=0 ts=6a586f73 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=-NaL9wa4eaIqG_6P2MEA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: Z7AGwjXtb02b38Q_xUmXbo_q2EjM2NBv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_02,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160056 Some SPI-NAND devices with large OOB areas require a stronger ECC configuration than the default one provided through firmware description. For example, Macronix devices with a 256-byte OOB area report that 4-bit ECC is insufficient and trigger: nand: WARNING: the ECC used on your system is too weak compared to the one required by the NAND chip The QPIC SPI-NAND controller supports both 4-bit and 8-bit BCH ECC modes. When a device exposes an OOB area of at least 128 bytes, there is sufficient space to accommodate 8-bit ECC without exceeding the OOB layout constraints. Automatically increase the ECC strength to 8 bits when the detected OOB size is 128 bytes or larger and the current configuration requests a weaker ECC level. This avoids ECC capability mismatches on devices that require stronger error correction and improves reliability. Signed-off-by: Md Sadre Alam --- drivers/spi/spi-qpic-snand.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c index 6cc53586b8a8..19812400124f 100644 --- a/drivers/spi/spi-qpic-snand.c +++ b/drivers/spi/spi-qpic-snand.c @@ -274,6 +274,19 @@ static int qcom_spi_ecc_init_ctx_pipelined(struct nand= _device *nand) ecc_cfg->strength =3D 4; } =20 + /* + * Override ECC strength based on OOB size to avoid weak ECC warning. + * If OOB size is more than 128 bytes, use 8-bit ECC for better + * error correction capability, which is required by chips with + * larger OOB areas like Macronix SPI NAND with 256 bytes OOB. + */ + if (mtd->oobsize >=3D 128 && ecc_cfg->strength < 8) { + dev_info(snandc->dev, + "Upgrading ECC strength from %d to 8 bits (OOB size: %d bytes)\n", + ecc_cfg->strength, mtd->oobsize); + ecc_cfg->strength =3D 8; + } + if (ecc_cfg->step_size !=3D NANDC_STEP_SIZE) { dev_err(snandc->dev, "only %u bytes ECC step size is supported\n", --- base-commit: 19827e7930a5511c68e12aac6e4522f3661a1709 change-id: 20260716-8bitecc-b9be3d2e7690 Best regards, --=20 Md Sadre Alam