From nobody Sat Jul 25 16:45:12 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2730F384CDD for ; Wed, 15 Jul 2026 14:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784126174; cv=none; b=GIzV1xQ1yEwtwT2hHc01geEBFm78veFjdtQuVxdheuo02BF6n1lo4DcZ/t4yqBtZvtLGIf1/wpF8554vvBoC/gpY36FC8/a+1fhatw4aUS6HaXo5SwA5ihZ3GPvVYfwdeup2/hCNVcaGrxsZjUSD6DM5sxChnTwg6MjRcgMYBUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784126174; c=relaxed/simple; bh=/BW9MGEOCrMpHQvNhautBMTcuKauENdAhZ9CjANN+2M=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Kvvfnf9QYC6jr/C60AnFBpTvncALMjyZ8mpZJd2BvTvfAE4Pz8jZN4SoqhbIIGzn4whtEyKFdNT0fkKOownWqUYuQCd75P5DeNEBBSsKWN9fN9bXEp9HPHT0i+K7LqkAm5rpY7gF5Zsktz0yJ99t6M750n6KhzXV/mlgmDURG4M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DcASMi1T; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DcASMi1T" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3810c5d691bso4335869a91.1 for ; Wed, 15 Jul 2026 07:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784126172; x=1784730972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MnEys3wW0UkOJWjz3Ha+uANv3CwPWTTT3M2E+EM5pUI=; b=DcASMi1TirMs+RNXzKm8CeLYbee7FdelpejtoVQzwaDmTVL5na5k/NsmGcrTYrArog HCsewxESdaZtCqSkSclqA0r5RVI21iBrEA2Ne9/QoQNsFMJfKPpMrY8eHioMLgPGzDG+ cTXrELr+XcNV5YJbktdHEgVvvTztrZtRAuQzShZmSgR6YWTs1+GLxpB/7v4onTNNLWfY gN8tKA/Ht0IvLJrTzaWU6dqROzOclk4q1sy3KAmDqnFMNPPs0Ze+YdRn+1j2xk0zBuqO VPXN3gAoPTBFBDolZSmoBcYQk8o7gsCq0saTErBNavT0iN3lr63ckhI1qad3A9tL++Uq ZTPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784126172; x=1784730972; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MnEys3wW0UkOJWjz3Ha+uANv3CwPWTTT3M2E+EM5pUI=; b=sepZLQ6YrhG+mWeM0Wd/0gQuZjmplDzGk9KUIR5Y9tPhkh8tZKsV8ZpCsZeymTMcns 6DNafwvpqXaLquTXdEgbTLvD0pQucXaDmNvcp/756iJ+OZlRVmOjdbNEHsvTOs1aHfPK UjZhySJHbUdDCQ/0VVuzEdiEwYvKc7MT9O7gjATqBoh4B0Jtg0RmtuJeYVeQPbDQmGeu qmDXP4XemPRdsILMgJHnL4pbsCmzkN3y6r6KKWILo6su0/xBpqfJBUy7M4Ux6QlSLkfE i3+pdsmjVudHe6mROCt3CnyCGcIqKGYjlmsZrlmjphL6qi55xvVjCR+pjAQAAwMcHeCy xIvg== X-Forwarded-Encrypted: i=1; AHgh+RrH85j75KwxWymZsvLpZaOnV4K7PAHRMkhHgb2KD2PMwnb+FZhLdIA/56btF9ZyQW+aGt9I7BODC9m2cUE=@vger.kernel.org X-Gm-Message-State: AOJu0YyeyZftLSfdkJdIsEGJdrhiv9o4m0Zqch3YMih5BZFJ+H7Aacb+ iP4TsQeMhMczWqHgOeJeUxhUiU7s44AFCN1LtyGf4k/z74JWZM88MMwu X-Gm-Gg: AfdE7ckA/gpgAlYWY9V+ETMosBvYgFb4qIkXq5aPNegY3noHVtJuI5ayWS754zxd3Cu y84VXJdd/I4HZ9hwGGNB/dZylNbUJEujXf3o3dV3IcoP0j0hRqCyuUyyG+0QAfa/2rQ5syUK6jf d7TprfpqEOTkQI4U3gmurR4pHSrd7o+d+Y1Zlfonk8RW2nvzMo1CSwHJDD8LBoKUaeqX5pspBYd o1nxPjkJydf+CFV46GQ8Bxibz8wSCG3tnkpjrP3+M23cQoHKnPLINU7ZzFZRog7nm1araeRZuLi ohv7F85UwMQ20cJOtdYopx4/NxJ8XIq+32J1KEhbSz4iALD9MiAGUdDUDxzEVKqKQ0dZQs8EnnR l5tM4sj6+//uQFMLEOZAuBIqxg2zM4GEF6nOEuydkmIyszPePPR2qifzcTNfzxpMgOGf8UrdouL yKa9nDCSB+sReGtJpgH+Z5X51uhQl4MExcaSsHddE/gdYOqWiseYQ= X-Received: by 2002:a17:90b:3b8b:b0:380:a568:cc4e with SMTP id 98e67ed59e1d1-38e1add8e69mr6031307a91.9.1784126172417; Wed, 15 Jul 2026 07:36:12 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:90:2db1:3066:c473:74d2:497d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3140e6c08eesm2510724eec.21.2026.07.15.07.36.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 07:36:11 -0700 (PDT) Sender: Deepak Rao Gaikwad From: deepakraog To: Steven Rostedt , Masami Hiramatsu , Pekka Paalanen , Mathieu Desnoyers , linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH] tracing/mmiotrace: fix resource leak on trace_pipe close Date: Wed, 15 Jul 2026 20:06:04 +0530 Message-ID: <20260715143604.14481-1-gaikwad.dcg@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mmio_pipe_open() allocates a header_iter and takes a pci_dev reference when trace_pipe is opened. mmio_close() frees them, but it was only wired to the tracer's .close callback. tracing_release_pipe() invokes .pipe_close, not .close, when the trace_pipe file is released. As a result, closing trace_pipe with the mmiotrace tracer active leaked the header_iter allocation and left a stale pci_dev reference. Set .pipe_close to mmio_close, matching how function_graph wires both callbacks to the same handler. Signed-off-by: deepakraog --- kernel/trace/trace_mmiotrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_mmiotrace.c b/kernel/trace/trace_mmiotrace.c index 226cf66e0..20812e7f9 100644 --- a/kernel/trace/trace_mmiotrace.c +++ b/kernel/trace/trace_mmiotrace.c @@ -109,7 +109,6 @@ static void mmio_pipe_open(struct trace_iterator *iter) iter->private =3D hiter; } =20 -/* XXX: This is not called when the pipe is closed! */ static void mmio_close(struct trace_iterator *iter) { struct header_iter *hiter =3D iter->private; @@ -279,6 +278,7 @@ static struct tracer mmio_tracer __read_mostly =3D .start =3D mmio_trace_start, .pipe_open =3D mmio_pipe_open, .close =3D mmio_close, + .pipe_close =3D mmio_close, .read =3D mmio_read, .print_line =3D mmio_print_line, .noboot =3D true, --=20 Deepak Rao Gaikwad