From nobody Sat Jul 25 17:33:34 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BACB4314AC for ; Wed, 15 Jul 2026 09:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109357; cv=none; b=JzsPzJ41zEXQycyugRSN5HZvNW+g3auwV2xM4HXBTlJz6rqpgbYu1TtCz3/c7MGfyEN7ns7JgSR/ny2w4Gcqnk4jrBb1ETh6O/AbwZ3YM/yrBe3mHMb2PbLYkGmocsgZXIDvEe8YUTiG/2NvfS4kGgBKjiNjcepzBmAhxH3OPBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109357; c=relaxed/simple; bh=k83hZbTKuOl//PgUx5fOIdMW+RR7uZ50uJTt+Avj9Nw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k2NWG368qd31bqUV/6rNz/KFSmM4AdYXVvHOtAM70NhjxN2lfqo8Ret2T4nCFh3yhYsM7ZYlxzTpG5+rbOrKTDQMQBowxLdssUbQoe0G6VMNQ1NC4EhtDQSGXShCW/7KIrKevw+uvG3LFFLxGolh8TKPxMPmQZHOIkEhAmFO3CA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X4uJBUmN; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X4uJBUmN" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ceaf8a1265so44214565ad.2 for ; Wed, 15 Jul 2026 02:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109355; x=1784714155; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7BpJzZu2JI6YrdHbblIuBNywzFxSYtVh1mg+KZtTDf0=; b=X4uJBUmNMXD3iuHG0quhAYPzFJCDozpxfH+PNt5XCLxgIRAknzY03QX9jV2hBjMr68 gH7JpdAxU9DqNIgwPQBr3GcTQRPtLkc9gvaudwgwZrurm35vI9dBNW2POKWEY4fRuit7 mhMSYTJvzYaRwEGCb2gpdfTOGUayZQET42SDUZ8srTo+hp/ExM6aeNHgrxsK2qYykk5t 4tIRPNuxALtu5sY0Mrce2Ab1O1zoDH0LKd1JqVoN4GfBG+cLfp/EOK6EfnATvVfGwFeR BN0oC9c+LXmTc78zL9kckl7jqH+6rK+R85sedN+Y1JC+KzITVv2MuoY7KD9JpH1aswkZ cctA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109355; x=1784714155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7BpJzZu2JI6YrdHbblIuBNywzFxSYtVh1mg+KZtTDf0=; b=EtSGaJzmkIJHs+osMHzxgJgxwPpiudXWRUfnYB0woXFxJmPMQyaSfT08HTLJoA9iqu j15rCb65ThmK5qKJOe97WKPk8s7oL6GLxkXFuVYg50FQwbmfIRZ00oRIXs44NlijOE1f GQf11Evgf6NgZ95XOeB0dwp96AWHGrPClQddypUk3+wHo6d1ywS5cH7xUdIKAh66fVM3 1wabnFjFpq1JpeWa4uFnhQ/KuNTmlYmFvXy9xpfBzKG2kI27c0Z/5fBRf7GkZwNsnC9K 5MDtreKMhKwFZtuQFmdLH7ePWtIpMHRT7gEx/ixOzqDH3+ziegR3puxXrNkRGqJUaIN+ 8y2A== X-Forwarded-Encrypted: i=1; AHgh+RpxcuW03Bgp2waIIlbqFN8skUtca5MurbJjQ0RP0Q/U3sUqE12tzObJAAvZbV0KP4xE36uTyVh8vMVeAA0=@vger.kernel.org X-Gm-Message-State: AOJu0YzChaQ4ulEelBtrVyXGYYHejuCFS9ZH6Zsi7PSLFVaLvZAa8ILt Oi0JNxrqKZSttqwIch6XI+bOP4xRWhLeDNA4loPiO2xPYu9Blp+k6Mjt X-Gm-Gg: AfdE7cnPmdwCi82whIame+WeYNXb8773VPjpSZU2t0tkVjU2W70Xr5pa7CcW5OKTnok Vl2rb1ryoAPn0dlF5O7vzOW2emv2e0BSudhBRazjadL/Az+o2tLar4ukfCr0dGZjdbQ54eBgsIE +54Kydpk+zGuS35rdD5wx+zuc+x0tEO39YIjv/QSMlk1fhfpKW8rJ6UCdJOBOr2p/KDshd0ptPC X4CUrXqWlOUpeCuF6DrRYPeo42LxEezUuwS9H1GZIwyGApuE3s0uAMAeY3Ac0vNtJdjKHVH2lY2 I+ZZLrx/Re3UeeSfNjz4k6idAVHTuB2RZvb7Ik43gayF88Ro7MtSPgrTu7pk4rKkab4XIynh4aG 9qN2szkOjQxFm37AGGQ5yQWaLZH8lEpQGKqfw1O2YBEdTx3RrWVJMgkSoSXFTvAL2D0PurfPPqj 9vfFbGc++PGv5CjqelCoG33/G8eOnqqvBgSCl2Tdx/Exuyl9I= X-Received: by 2002:a05:6a20:3d8b:b0:3b4:931c:3c7c with SMTP id adf61e73a8af0-3c357553dfcmr7448713637.44.1784109354620; Wed, 15 Jul 2026 02:55:54 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:55:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 1/6] ASoC: sunxi: sun4i-codec: Use dev_err_probe() for probe error handling Date: Wed, 15 Jul 2026 16:55:20 +0700 Message-ID: <20260715095525.40668-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Use dev_err_probe() for probe error handling to simplify the error paths and handle -EPROBE_DEFER correctly. Signed-off-by: bui duc phuc Reviewed-by: Chen-Yu Tsai --- sound/soc/sunxi/sun4i-codec.c | 70 ++++++++++++++--------------------- 1 file changed, 28 insertions(+), 42 deletions(-) diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index f4e22af594fa..05308df3ae5b 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -2316,67 +2316,54 @@ static int sun4i_codec_probe(struct platform_device= *pdev) =20 scodec->regmap =3D devm_regmap_init_mmio(&pdev->dev, base, quirks->regmap_config); - if (IS_ERR(scodec->regmap)) { - dev_err(&pdev->dev, "Failed to create our regmap\n"); - return PTR_ERR(scodec->regmap); - } + if (IS_ERR(scodec->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->regmap), + "Failed to create our regmap\n"); =20 /* Get the clocks from the DT */ scodec->clk_apb =3D devm_clk_get_enabled(&pdev->dev, "apb"); - if (IS_ERR(scodec->clk_apb)) { - dev_err(&pdev->dev, "Failed to get the APB clock\n"); - return PTR_ERR(scodec->clk_apb); - } + if (IS_ERR(scodec->clk_apb)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->clk_apb), + "Failed to get the APB clock\n"); =20 scodec->clk_module =3D devm_clk_get(&pdev->dev, "codec"); - if (IS_ERR(scodec->clk_module)) { - dev_err(&pdev->dev, "Failed to get the module clock\n"); - return PTR_ERR(scodec->clk_module); - } + if (IS_ERR(scodec->clk_module)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->clk_module), + "Failed to get the module clock\n"); =20 if (quirks->has_reset) { scodec->rst =3D devm_reset_control_get_exclusive_deasserted(&pdev->dev, = NULL); - if (IS_ERR(scodec->rst)) { - dev_err(&pdev->dev, "Failed to get reset control\n"); - return PTR_ERR(scodec->rst); - } + if (IS_ERR(scodec->rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->rst), + "Failed to get reset control\n"); } =20 scodec->gpio_pa =3D devm_gpiod_get_optional(&pdev->dev, "allwinner,pa", GPIOD_OUT_LOW); - if (IS_ERR(scodec->gpio_pa)) { - ret =3D PTR_ERR(scodec->gpio_pa); - dev_err_probe(&pdev->dev, ret, "Failed to get pa gpio\n"); - return ret; - } + if (IS_ERR(scodec->gpio_pa)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->gpio_pa), + "Failed to get pa gpio\n"); + =20 scodec->gpio_hp =3D devm_gpiod_get_optional(&pdev->dev, "hp-det", GPIOD_I= N); - if (IS_ERR(scodec->gpio_hp)) { - ret =3D PTR_ERR(scodec->gpio_hp); - dev_err_probe(&pdev->dev, ret, "Failed to get hp-det gpio\n"); - return ret; - } + if (IS_ERR(scodec->gpio_hp)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->gpio_hp), + "Failed to get hp-det gpio\n"); =20 /* reg_field setup */ scodec->reg_adc_fifoc =3D devm_regmap_field_alloc(&pdev->dev, scodec->regmap, quirks->reg_adc_fifoc); - if (IS_ERR(scodec->reg_adc_fifoc)) { - ret =3D PTR_ERR(scodec->reg_adc_fifoc); - dev_err(&pdev->dev, "Failed to create regmap fields: %d\n", - ret); - return ret; - } + if (IS_ERR(scodec->reg_adc_fifoc)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->reg_adc_fifoc), + "Failed to create regmap fields\n"); =20 scodec->reg_dac_fifoc =3D devm_regmap_field_alloc(&pdev->dev, scodec->regmap, quirks->reg_dac_fifoc); - if (IS_ERR(scodec->reg_dac_fifoc)) { - ret =3D PTR_ERR(scodec->reg_dac_fifoc); - dev_err(&pdev->dev, "Failed to create regmap fields: %d\n", - ret); - return ret; - } + if (IS_ERR(scodec->reg_dac_fifoc)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->reg_dac_fifoc), + "Failed to create regmap fields\n"); =20 /* DMA configuration for TX FIFO */ scodec->playback_dma_data.addr =3D res->start + quirks->reg_dac_txdata; @@ -2422,10 +2409,9 @@ static int sun4i_codec_probe(struct platform_device = *pdev) snd_soc_card_set_drvdata(card, scodec); =20 ret =3D snd_soc_register_card(card); - if (ret) { - dev_err_probe(&pdev->dev, ret, "Failed to register our card\n"); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to register our card\n"); =20 return 0; } --=20 2.43.0 From nobody Sat Jul 25 17:33:34 2026 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9F02931C2 for ; Wed, 15 Jul 2026 09:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109363; cv=none; b=sqqUjL/8Y9xwSVa+aopkOMPiZMW5897qWghqOeOg+G88BI4aY+NsZr/ivxHXuFlD9KKkTYDsHdARhfO+1uBW8DtL7UkOS2felnUllP9Sg+1SK5qR8nDTlE7TlIMtakCJoMyc84LPMGv3qp5OGOsqXBNLoNiLnI+6xg3xoLk8nxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109363; c=relaxed/simple; bh=JYpMe5xJN7tUQUFpfvpPUyELSznoJMPf/vIdMkvzM/k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KfCpP34thZcTAuGNHssNkcIEGV2C5rz9j2+H/sbf7oGujH/LU4xTGZ/y7ef0Tc4tbI8gKq3PNK/OfLGCU6ROluX1Mi4srThNL8oJuGSsVWs5rILKK3cFOhhcYNvRZZ3pm/9ppjKM6WYibj9C8YBJhrHgeeLHvWrpW8zwtIdSjMc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OqpdylBz; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OqpdylBz" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-ca965de53baso1103354a12.0 for ; Wed, 15 Jul 2026 02:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109361; x=1784714161; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PZY26nfH61F/ozoLH7Gi9fNecnPmd2NgxbQtVT0E040=; b=OqpdylBz0Gd7MSDiHzzVrVG9GmwJMNmpQB2fIfx69tpnx6THfL9RjqkP9MSAfS7E8W it2xlt2LJIomeQv1InE9P/KbisKipliCO68XolYg5LV6FSiBqs3UWUckW/65mHYA9AvT cFzPO21dRMyQYKZlGZlslRTP5KgXLe2MburAZKjcLeao8L+B0QCA1/LARZXIIZz/miai 6BY40TVR4q+OUzN5OozxlWY0CnphY56Lx2MyaFXAdrR5QY75mUHHeVGR6NGpxISdWmya WxXDG3h41E3Us6l4QDDFkw3KtJ4j/wu/Sg6gLjWFET6K+0acjbw6Z22ur8PMIKJr0t9/ TiVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109361; x=1784714161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PZY26nfH61F/ozoLH7Gi9fNecnPmd2NgxbQtVT0E040=; b=TviNRtlX+F2DZutzt5wXMOU2Cmioszn5/okyzK7pXoj2N09c+PxDLFY4P65EhKP6z6 3Yq6nsVwa8FxYk39k07KBwccVsFNdehSXdjJdM0WWLhQe0AJNfQVQNfilv0yiWEpWWSv txJNa/GEtdJADu4Z8T8fNg3tUKtGkCq47aBQzIE9UYhDjyd8hOMCfVtpodOV4xPJ2lo/ AVrPeXZxogGmIhCs/OVGbTBuAspq7xxrv2QkG2ekSfv/1z93N64903TvkM4NFqAvuYNA l7ey/bDnmJvjRJ2RQ1a+yIJZqhibbvXmD9P4VCX7UeXFTlM9jCba+g7g/qdKf+31OsPm TIBQ== X-Forwarded-Encrypted: i=1; AHgh+RrF7YQTvFrKrtAxn9AawfGAZccHkCURdjpMyXr2X70DAHU1z4/QSIYnWaL2XDzrH6lRdvcuDysKw7JfMKw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2Z6Gkz0Ev+9jrCXBqVUIBnJeHid9Gg4UfZDeGwHJYEQo0QfR+ VzIlANCwO44QHuwB2ZYu5ePFqB5x/pdBe/2P7KduYij4mUPLdqC+xPQQ X-Gm-Gg: AfdE7cmaaRiAje92L1kpMoX2BJH3iJ/HtQ5OcwpBHb6iMp8sLHDzmMmuVJgXcGal8/V k7EeLPyJeukpLuzstMJg+phLA3RNwk3GE0BPQpPMKk72YUz0/V6DKiM1YjzP0gSCdnXnNxIwUJl 26dBWeZ7129o6wx50Nzr9d44WEB8fsrUtxn3vj4oowHLXX1qqO96Rb0bFHXaMilMRujTrA5biRb PVs6/uGZ6T7gtDYXqI0k+567b8tGdFGRIbdeQ+7IuWyrP5fnvBnUIEGVpyCwfMwyfj6YQRlwhmP Pqf8rCszM2jxge0fdK1Tzlk+3lN8tvQsupYS6HzLsRDzz2aIqMBSurL7AYWq8dGl+gf38CPwi/K bNGngnCzEylQxvp8Q4v9NkQEZyyuhr25iA6uWOm+VYgE7h0GMsHF2z2+g/zz0RV/Tq8vqWMwFCV s0c/2z8QhBL7pk0k2xmoJS3qjQifROzgcQuZq1rsQnZx0Xfuc= X-Received: by 2002:a05:6a21:510:b0:3bf:6c08:2b2b with SMTP id adf61e73a8af0-3c110b6e0a7mr18474760637.51.1784109360730; Wed, 15 Jul 2026 02:56:00 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:56:00 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 2/6] ASoC: sunxi: sun4i-codec: Drop redundant error messages Date: Wed, 15 Jul 2026 16:55:21 +0700 Message-ID: <20260715095525.40668-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The called functions already log failures where appropriate. Return the original error directly and avoid duplicate error messages. Signed-off-by: bui duc phuc --- sound/soc/sunxi/sun4i-codec.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index 05308df3ae5b..71f7a1fedd88 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -2380,31 +2380,22 @@ static int sun4i_codec_probe(struct platform_device= *pdev) =20 ret =3D devm_snd_soc_register_component(&pdev->dev, quirks->codec, &sun4i_codec_dai, 1); - if (ret) { - dev_err(&pdev->dev, "Failed to register our codec\n"); + if (ret) return ret; - } =20 ret =3D devm_snd_soc_register_component(&pdev->dev, &sun4i_codec_component, &dummy_cpu_dai, 1); - if (ret) { - dev_err(&pdev->dev, "Failed to register our DAI\n"); + if (ret) return ret; - } =20 ret =3D devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); - if (ret) { - dev_err(&pdev->dev, "Failed to register against DMAEngine\n"); + if (ret) return ret; - } =20 card =3D quirks->create_card(&pdev->dev); - if (IS_ERR(card)) { - ret =3D PTR_ERR(card); - dev_err(&pdev->dev, "Failed to create our card\n"); - return ret; - } + if (IS_ERR(card)) + return PTR_ERR(card); =20 snd_soc_card_set_drvdata(card, scodec); =20 --=20 2.43.0 From nobody Sat Jul 25 17:33:34 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0940387361 for ; Wed, 15 Jul 2026 09:56:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109368; cv=none; b=BO7lp15vzI8EniBWaYnz2nt1vjLYzJ+VqdGxktBhFnrUTTyHEla5OQcBkSGMUPBdKs8jpot9q9FJWDNRiHL24KtmfXMryDm3bTyD2ziIK9QfE0rJSRm6myVdbnY5a+Akxlbp7kTzhwehrglNtUz0rXmVaiq2DgLb1INYDlvVAOc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109368; c=relaxed/simple; bh=vXMUV2NHdzO2bVhOLxgO//r4EwHkTLLI06VBSO1JtTM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TBtgufhVM75t8qKEkkjrI+Kx/mQagjW7z7NJAkl/FcGR0Hek8SUBCAKy5D6Hwb8IsHHHXcfxmb9nQhya956ppEJJtsdUOSn/nXLc0Wh5VBecN2mSTL2sa7fY5O4CPYmphMO+y64ruPqjC+whyNNlBPQsg5UOMUNECYEinFMI1Cw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p7bo524r; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p7bo524r" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c9cf07d2df6so3378687a12.2 for ; Wed, 15 Jul 2026 02:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109366; x=1784714166; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AbwPz53OQjxnJig2YQsbZ1pk7oPIkLRBw9/Vd+k0PqQ=; b=p7bo524rGWCDC1UT+Kpby5hQoViBYM2yeEEC5cJjlw1EOJVyyb3hrMh7zFqflsqkb6 mSzCEZVqjSIMKBvEwmO0Ysz/hPXJqEC5TejQnDzSYnY2dQjhjZ1lVI+mf2VLgJcnRF8q oubnKZorXkeJE6GHbbNl26sh2VCmv8BAqKtXhs61GAROy0Lvzf+J6hBbVJi4snS6dwHO 4rNMhjkXHKUjtne5OFT77+3uTLbqmgvB2N1//rgPIVnE4qXGRnhv8DQCGjtc5vV7FB8Z iswytiVIdsH9FCJb1cYWK66PdXJzk0NJoctYguQLjA3ysd4IpGSvG07oEHackqVp87l2 L/XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109366; x=1784714166; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AbwPz53OQjxnJig2YQsbZ1pk7oPIkLRBw9/Vd+k0PqQ=; b=m8jyjaY0w+8VIO/OVD4KnkO1ELhBugnEpkwcTcnLGCOWfUdGxpm1nTh+IsKi5LuXFH 9cK7YKcOkglKa4aulWLahmB7vOsOpr/6yTIIDv1b8uaIsHidHphsmOSwnm6aOVIqYT0u /Jv141QgfPrjCHKP7TveVEfjKjTZclFGBSkDeks7XGGyqihRf7MYgJ6HnhWUhCP8V2dm Mg/tbnELkH1QfR+pavT17zVGaHjHupmJXtz87htMqg22J6Ue4Zwe91h0eh1u/rSmtL3G /yCcDja9I09i0iYSfRjfqjKcIa8YopduZM0aR/77Bh9SiM6UtWKzpSOp+nvaou9OmHxt 5iFw== X-Forwarded-Encrypted: i=1; AHgh+RqhBiJhz6M/KNTC0cKhTZSjw+QwRoQI0uyqGTQm2rtP06x7/j1WibXxKZ9Qt8/Ys37JDC/cR5iXdKtZIaw=@vger.kernel.org X-Gm-Message-State: AOJu0YzmSyYGUxJ4J4Hm9v5kHjNJ62qlAV4C9yWW0rhmrYIpm3lzjfF2 10FZ58Mb9b+BUHIZf1yg1DuVjeIdB4I177s2KJie0udEOPkiQsPThxtY X-Gm-Gg: AfdE7ck3izZnfZ6fHvCAmi9HUADYjBA0rSMFKnxOFZqZalrKo0JdaMZLnDrzjpGtTFL omQNmePJC+uvpobukw/wOFFASyR94JYZZOMpfJyC3aLk6AOhANj7HBQAeTY7iAwcHRKCmjM++r9 jckzsF3u1vw6lDfQWpqm01DWhyIhNr73dA6DSUka1bCQ+gMRBv0+L2M29cOJvVOPp0njuV9FbDE NHSyLTVYYEVDojXz9Pu3EBJCCCXFWVwDK5qW6mAVm/BLY+3z1sw0tUE6YHcMB0r0zNHlEGn1Csl oz6gs2oKEXDWOMx7XHf2WDO+bNGFXxuqc167jVXqCFm+cCFgqNvxaLibe2Ki+vFtAn7byLrMEpa m/D/dK5yGjq1E/5pcj6UUI/pjVXvQSXVMuiR3vVw9uI7bxoVPpdchIGDoDQacc+ltnZpAiAmGgX C22gQxdNUhR62kIKlCC3AIx8hS3UcnKuypDZ3DoPI7FWVp98w= X-Received: by 2002:a05:6300:2787:20b0:3c3:7019:64ad with SMTP id adf61e73a8af0-3c370196776mr1215140637.66.1784109366301; Wed, 15 Jul 2026 02:56:06 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:56:06 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 3/6] ASoC: sunxi: sun4i-i2s: Use dev_err_probe() for probe error handling Date: Wed, 15 Jul 2026 16:55:22 +0700 Message-ID: <20260715095525.40668-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Use dev_err_probe() for probe error handling to simplify the error paths and handle -EPROBE_DEFER correctly. Signed-off-by: bui duc phuc Reviewed-by: Chen-Yu Tsai --- sound/soc/sunxi/sun4i-i2s.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c index 40de99a34bc3..716fa4d872ff 100644 --- a/sound/soc/sunxi/sun4i-i2s.c +++ b/sound/soc/sunxi/sun4i-i2s.c @@ -1550,30 +1550,26 @@ static int sun4i_i2s_probe(struct platform_device *= pdev) } =20 i2s->bus_clk =3D devm_clk_get(&pdev->dev, "apb"); - if (IS_ERR(i2s->bus_clk)) { - dev_err(&pdev->dev, "Can't get our bus clock\n"); - return PTR_ERR(i2s->bus_clk); - } + if (IS_ERR(i2s->bus_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2s->bus_clk), + "Can't get our bus clock\n"); =20 i2s->regmap =3D devm_regmap_init_mmio(&pdev->dev, regs, i2s->variant->sun4i_i2s_regmap); - if (IS_ERR(i2s->regmap)) { - dev_err(&pdev->dev, "Regmap initialisation failed\n"); - return PTR_ERR(i2s->regmap); - } + if (IS_ERR(i2s->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2s->regmap), + "Regmap initialisation failed\n"); =20 i2s->mod_clk =3D devm_clk_get(&pdev->dev, "mod"); - if (IS_ERR(i2s->mod_clk)) { - dev_err(&pdev->dev, "Can't get our mod clock\n"); - return PTR_ERR(i2s->mod_clk); - } + if (IS_ERR(i2s->mod_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2s->mod_clk), + "Can't get our mod clock\n"); =20 if (i2s->variant->has_reset) { i2s->rst =3D devm_reset_control_get_exclusive(&pdev->dev, NULL); - if (IS_ERR(i2s->rst)) { - dev_err(&pdev->dev, "Failed to get reset control\n"); - return PTR_ERR(i2s->rst); - } + if (IS_ERR(i2s->rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2s->rst), + "Failed to get reset control\n"); } =20 if (!IS_ERR(i2s->rst)) { --=20 2.43.0 From nobody Sat Jul 25 17:33:34 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9AE241A91D for ; Wed, 15 Jul 2026 09:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109374; cv=none; b=iJGur9ohmt7bBULzCFXBcrZdFikUNxKZl9juTy6Rz7kedkZ1kSzJNko0EMwmJOJkJ+Xq9F33O+t2pTth3z54TAB0FKV3KdklLdC8bpnY7p+AwUNCM7iEp/LNvSjj7csxsCp8vzx7M/BJ1o4xDQHtjQjS2m0xa0MRkNer/aWVPQ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109374; c=relaxed/simple; bh=jXeHXz0sgTqbPCpgE0Ek4FYcDSoYTpRTfMU644+qSc8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ptIOY+TsSOOAi4t6Y64WkmFET+qJ7CsnsEPIV/5L2oZorYnZEvVPlGC2/lnuucTX0xMUCfwfc+sh/GmnSUPqCZUC/8xn3GKcjqLqhVBSoO6j3ZV/7f36v6alDJdra+vtHDb5tJrn79ml8v1HNk0pSnohE4FJOG3dUCB9nLVoCf8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hIIXDXcf; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hIIXDXcf" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-84536ecfc5bso1781866b3a.2 for ; Wed, 15 Jul 2026 02:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109372; x=1784714172; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IG9ROgmPkgpOSWt5kVvQ2eBpCUOMrMqYLeguMnD/GAI=; b=hIIXDXcfmIJ8SBFTkbDtD4nLKnGKXBL3wqm1J+sw2y7vxfcJowhFNSMSAB7UtS7tpl u6457Drhaao0nc7y3d2GSERpDRctIzv4AEHF2WrV/eGEJfCXI1//uUm2SLkr2ax7d3uM pRVvDeLZ4lZi5H8p9Y6xbdKI1Pt2YUJcaxa9WdtbxpU4MFxiWgResEuoeOcNh2DVkB/m oungIojwcHZUkn/QGDCBBgf+a9rsUAxx0Eby+AyiN4PwUfbnopS2qhYnta2ACajRyInr 00AfnSHmgL7j9noa2gg2V9DFwyiMwSRfnrjko4x0uhNwHSfWijdA1V5B+zU4D26wkcM/ tddg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109372; x=1784714172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IG9ROgmPkgpOSWt5kVvQ2eBpCUOMrMqYLeguMnD/GAI=; b=MJGks8o9ahMgBNhF2/6OyzvI6W1ViPQJ/UwlDnV8PSHyjiotu2OVCQSTP4b4HTldXY UcqhiV36UIuIeADUA0BqOa9OuQB3+uzjiQd7BIYfpjjuozlfQLKrbfhcoioizIhDl8Cs pMfBjLTlXDBmBqCbIfWq4XhlPnhNG0z09joK1IxWAFd14x9phnpqTUplmZh5DwCb8b8s pDS403th9KkGKVuIEVrE063sskVk68uf+Z/YaswXI7/BQeA7LDykaTCEIydFNs5+gtuT c0fe20yOPV1rOHj5vUB7/isBcFzW9cVoPDocmTPG+6qMKnyeJL3jBs+muopaZ6Qak3H8 eNOQ== X-Forwarded-Encrypted: i=1; AHgh+RrGjIIqIGFeGh+z82lHQFK+FIK4d0JOC0IlyHss1TAowRI/1CPtCIWuU5V7pU97bjlhwTBe7FdVrAHz9gg=@vger.kernel.org X-Gm-Message-State: AOJu0YxevYknODevirOx2AvgJil2iF86qadRGM56YIu3zlFUJiZlQRuM z1jLrG9peYtSeONsuqltQhVxSQpVh1/xvOsRW1GlrIV8bovtKOdTNIUX X-Gm-Gg: AfdE7cmA2Zr9MKae4FYOaFqCb/0EDLlWu+QVJ0Tz/Pw5H5Z/deGWVS7+xBuLQ2azdvX inLUXv05R32h6SivMIP6WhAcPXPq/ZJBEQe76XjIhKjsDLSv+OCdxwoesnuV1KoMFIluPsER4gg u3nCEc9shF70juSIt1a0xrak/WhbUH3KTxiiqtqWTr8wEdgHVTYv5ahJAZVSqTN3l4iEY+WsUW7 gPz2oZ2cDaJP00owQ/3xs5ynLezjNopiLPVxbJv6f/YCc2uotsTys25SzKlNXSbOyuxkXUQ/+tY +WWBYgoRUwnoHpSkeTmxoa5UZBWvfw3C4+zYSB06uTCEvzhK+YsGmFv2Uk1vM58yyKA/rtkNFVA PeB1P4M2KV9pnv2pCGguRJKOlga2nOReFbdi3f2J4KilFwULTYxCDZslS6/iDnK+nzEyXtejAad kT0yCmOcbfmACpj61iMAlkGZdAXMrQVLudMCInziuck125ITQ= X-Received: by 2002:a05:6a00:10c9:b0:847:86b0:888c with SMTP id d2e1a72fcca58-84a6733bf25mr1897232b3a.48.1784109372039; Wed, 15 Jul 2026 02:56:12 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:56:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 4/6] ASoC: sunxi: sun4i-spdif: Use dev_err_probe() for probe error handling Date: Wed, 15 Jul 2026 16:55:23 +0700 Message-ID: <20260715095525.40668-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Use dev_err_probe() for probe error handling to simplify the error paths and handle -EPROBE_DEFER correctly. Signed-off-by: bui duc phuc Reviewed-by: Chen-Yu Tsai --- sound/soc/sunxi/sun4i-spdif.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c index c2ec19437cd7..d979bb00312f 100644 --- a/sound/soc/sunxi/sun4i-spdif.c +++ b/sound/soc/sunxi/sun4i-spdif.c @@ -684,26 +684,23 @@ static int sun4i_spdif_probe(struct platform_device *= pdev) =20 host->regmap =3D devm_regmap_init_mmio(&pdev->dev, base, &sun4i_spdif_regmap_config); - if (IS_ERR(host->regmap)) { - dev_err(&pdev->dev, "failed to initialise regmap.\n"); - return PTR_ERR(host->regmap); - } + if (IS_ERR(host->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->regmap), + "failed to initialise regmap.\n"); =20 /* Clocks */ host->apb_clk =3D devm_clk_get(&pdev->dev, "apb"); - if (IS_ERR(host->apb_clk)) { - dev_err(&pdev->dev, "failed to get a apb clock.\n"); - return PTR_ERR(host->apb_clk); - } + if (IS_ERR(host->apb_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->apb_clk), + "failed to get a apb clock.\n"); =20 if (quirks->tx_clk_name) tx_clk_name =3D quirks->tx_clk_name; host->spdif_clk =3D devm_clk_get(&pdev->dev, tx_clk_name); - if (IS_ERR(host->spdif_clk)) { - dev_err(&pdev->dev, "failed to get the \"%s\" clock.\n", - tx_clk_name); - return PTR_ERR(host->spdif_clk); - } + if (IS_ERR(host->spdif_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->spdif_clk), + "failed to get the \"%s\" clock.\n", + tx_clk_name); =20 host->dma_params_tx.addr =3D res->start + quirks->reg_dac_txdata; host->dma_params_tx.maxburst =3D 8; --=20 2.43.0 From nobody Sat Jul 25 17:33:34 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96AFE3C3450 for ; Wed, 15 Jul 2026 09:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109379; cv=none; b=LsZtbHN0a9kct+FaH9sL+VnX+r2B94NQ6pZ39cWHXuwIb2wsn/7DDxCmWtDG49hrKBWd9vFe2fjgGEDTVFhWVey3EJQY0EhxmuMVKJZyAyk3ExY6HlBT1/kiINcfvaJwa03Pp7Fy6qVuoLwoakZ1yxwmzjceXdXYoQiHtL0f4vw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109379; c=relaxed/simple; bh=rWAveW84L3R2k6Dr0kk7jzU9NyiQbaV6M5iGKNhBiKE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=beun6vS7cqLckoP0dkMF5tEziSmSW7tza/sRzTHbhhuGXDrjCcTSYHMn6JxTFEvmeGc6sOnUsbbe2eG88ppmxcoOEfIQ78wh/sMiPR4/0wuyFo+KE77mNxTpbDcJH6hwlYnOzkXfBCK1flDGvg1awW1lYAeS5/vMdK+E/lejkE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pZ5o6f/Q; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pZ5o6f/Q" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-84867f07d63so5953688b3a.2 for ; Wed, 15 Jul 2026 02:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109378; x=1784714178; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oH3dvIiif6Ezut/x+NGlXGEkxyluaoU8qD8m7W6CWsI=; b=pZ5o6f/QZSTQAKvdkHFJiSGFYev+BZnUKyp3NrDJaOB4ddaDTZLpClor3CyGkvpbgN 3KsYo6lAlR7GyOVYAZ9B7SjFzsBFWWDgH5yF1AwNuy69AuIjFKYHFfLaPJZx8WZes0V6 TLqQ+9I/6FVgPlZK5NDebdpf/AcUzQrbNI7ijWt1RJm5yUFhzx7bA7DZg4aa75myFxUX nxomHaAT12KVHjYOUpF8md2iZtQtNtFuIcAhVvELpiCvMJaURlNLVoEgxe1Jgyw7TFVt QaLYgGjV9SRW4ezTTbXQnDem5CgZiUDqbuggWwxFNR+5Z3KJfsOsxiryM/sLiTr1CdAT kMJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109378; x=1784714178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=oH3dvIiif6Ezut/x+NGlXGEkxyluaoU8qD8m7W6CWsI=; b=qcjVfncyMr27g0JdEi6tFY+YxpSnmVo58+w1UFkYUHzW2j5krE5Ftv7pqq6GxS7wA4 3mR5MNSFVLBduoZmZLvcN2QZLNaq1nXBpJWinnOU490+BP076yM39EQMZE4kmIY445P6 WQ6SbefFUS5AqxGqprHlPbS0FHE7bnIUtqYff7wjzF5xQiPGwbtjoa/eb0o7xcDRrckr r/nggCu1RisD8/yqNn2lFQ7uzDq+Z0np6OT+GEePjukkwQeTVqAUJU2kikGFeqLRLBh5 hkCLAqrPv9Mk9so93XbvRhc5pmbmTYyGkaVM94BcO6RmrFomPAcOQYIfklL7Jrco4Rs3 Vr2Q== X-Forwarded-Encrypted: i=1; AHgh+RqwpB8wc8nRnL0XWnX0E4kVdZKaq/pA18/UutuNID9fXGsGWgh/95TmNg0yR2ytn++yjCqTlFgWvbjACMw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0ZMag5OunahEZAXzEGEVHLe9MJYlyUrZaCSn7x0cYs9DeoGPe ciUPwMEKBu18MsHqZ2t88qfWtDLVrbHKP6SuVo5QPMIKu/2oy2/ioJE2 X-Gm-Gg: AfdE7clcIqT21yel1EApzpQmeXf58bs3VRMvcvuci2TH6FAyBZ185gSTd8+YJ5/snnp 5f4424kFMWVryZozc5q8r3kn3ZQz0fG28yMeRsOuzcEg65Z/JpInPORLeDz5G8eX0QdGrAjdBsl pgV0k6kv0Xj2XWv/KPRqHVpiGG2yMazfHn88Vd3XWx41q2dIDTyLqPw6Wq/KnYFaXSIkbXsfovS RIIMkqbptLm95/byfaikBY0dK59ZNSO1/pol0gxTKWZy743lXfN/mjFNFSbTgRIeAI11SnMdejc tPnkgn9gA2+cxv/B9YTxWi11NoJt4ooMEM25L2yQu+cnEEwwT1soKpG71GsDQPoWMHa+Pb1wPrC fn8K+OtjBm+rCXv4Q3/H5dafLTXXvzQU4ZwTgP4ZHD7f2HcVS01nBZVIQfhA8k+EJfTIyuemeT0 4k7xTk+5W3D4WO0JsEZAbE4oadgVqMDNI9hdKcZOXbjq3p/xQ= X-Received: by 2002:aa7:8891:0:b0:847:b2e4:9f68 with SMTP id d2e1a72fcca58-84a671da3aamr1648721b3a.9.1784109377872; Wed, 15 Jul 2026 02:56:17 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:56:17 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 5/6] ASoC: sunxi: sun50i-codec-analog: Improve probe error handling Date: Wed, 15 Jul 2026 16:55:24 +0700 Message-ID: <20260715095525.40668-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Drop the redundant error message after devm_platform_ioremap_resource(), which already reports failures, and use dev_err_probe() for regmap initialization errors. Signed-off-by: bui duc phuc Reviewed-by: Chen-Yu Tsai --- sound/soc/sunxi/sun50i-codec-analog.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/sunxi/sun50i-codec-analog.c b/sound/soc/sunxi/sun50i= -codec-analog.c index 9f5b067a8ccc..50c0dee8c433 100644 --- a/sound/soc/sunxi/sun50i-codec-analog.c +++ b/sound/soc/sunxi/sun50i-codec-analog.c @@ -551,16 +551,13 @@ static int sun50i_codec_analog_probe(struct platform_= device *pdev) bool enable; =20 base =3D devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(base)) { - dev_err(&pdev->dev, "Failed to map the registers\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } =20 regmap =3D sun8i_adda_pr_regmap_init(&pdev->dev, base); - if (IS_ERR(regmap)) { - dev_err(&pdev->dev, "Failed to create regmap\n"); - return PTR_ERR(regmap); - } + if (IS_ERR(regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(regmap), + "Failed to create regmap\n"); =20 enable =3D device_property_read_bool(&pdev->dev, "allwinner,internal-bias-resistor"); --=20 2.43.0 From nobody Sat Jul 25 17:33:34 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 594623CEBA6 for ; Wed, 15 Jul 2026 09:56:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109385; cv=none; b=pvkMDAImlmZ/Q8CkhWWmVfEO8uPNKnXdJKSdkTnuoBLPA/2im0tBb0etb7icqdgLcAF3WEQ5evs1txbZx3Q0uIYkxgM1VZwxenpVGqVk1lrnBE7aiQtM5kHjZFJ1BzQfBXs+hTHZha78spfdOl5kbF2gWr4/Uh4aqVJ4uC8PO6g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109385; c=relaxed/simple; bh=RVMpE/2zJngbP2l7dUgGImsnDYyJOJke9NWacK4SwV8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bBxhNtaBU6mNT5Z6j1RT9el/oQ1VtvUiWLNWDo/gIjoPpu99ZsZAP3yHrEGoV5pr5ss5BHPNyjOuNVd7C61wegW1DqxkgBW9cXPljaIbjG6dpQUL+CkVP+RzpAQysAcy8lx0UIZjW8xlNynmSTvTNFXsO0bbcGnEgJuj6u2mt14= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N3e0Qx/e; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N3e0Qx/e" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-84864086bfeso5495040b3a.1 for ; Wed, 15 Jul 2026 02:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109384; x=1784714184; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hMaB8cZfcOw4iICxwreQT8955W297Mz8pA/NoRorvZg=; b=N3e0Qx/eg80HoREkrlk2nkftyqd6pNcmin3ypP7kBE/9fxY0jfGdIdJMgs1N8+UGEb pdPSz5s+4eQCkeHj+dinLJemhKk1mH0qJQOBwmeeNSt6PTH0BSctdFFTT2xErPyKmTh/ blibOXIIrOFMe1OcDvYvRpNQNztDumzuZBWfLUH1HMA83cprygGdgmulJzriCGSpj2Tm 9MIjkyckSs33dzc7HYom5DHwJGFKNh9i363ccHdh9V60XpUHWfDvx2Op166vLaBE7M/5 bNhLOSDUNC5ylJ3laqdeikn7KDlTWpECoUtVQmsyIGnES3si9LOUGcZhivam3PuOhsaq w5SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109384; x=1784714184; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hMaB8cZfcOw4iICxwreQT8955W297Mz8pA/NoRorvZg=; b=HFOQm+Hb4d/fz7YXJuLTUnJvd9LOlADuGKsYe6DW5uEIadf30b772A+hILIUQl/piB LEVsOh8n4eTWyn6jO+TC0m+kOgVDwORggRh6zZHeV8uK0VNGaSAi/lP3tHpR4usZAqje 6lj0HAsKO40CVC6olV8eMQdrJySPGd+nOWq++KeI9DqdfJljhYXTzIBz4/9Ch3ZVkL6u SrEyc8DxXmJ9WNTMTPk3qQmhRwiU28a6J7720r77Q6swSzMuliV9GUeFEV+njZx8a+UA n70zD4F/4mQDrPcREdLspleL/v+6MxVGgPLWBRY4BvVWIgkAfezmlFPycth21EtL08q9 BVFA== X-Forwarded-Encrypted: i=1; AHgh+RoHmaTSDJzgcMHyhzJz5OuWNrhlxmbUlO9cofsAvbNviNAkqvteAA9Rg67iV3MR9m4WlGndy0l4ZuwqvqY=@vger.kernel.org X-Gm-Message-State: AOJu0YzfWoosJAeJzK4mAqvX8TAdNZjFDXjuGRPW1BFAALiCOnfSFkXK knQVukdq6uIevQHuT2ElD+knuVh06LXxOp8nJBtrCUhTA8bVYetw0Wau X-Gm-Gg: AfdE7cnyee61LCMJ+Pfv1e84flsc5rCS7ns73BFt3/svhKNEdG92h/rdJV2JwhQDW7m Nt8Hm2qk4RBa8hAHEyiVWUODu27vbvCzqnkNKbmfTR8dU7hlXvgs5FMWNpIaR6IPdOSOsxsrP0J CWKA9wQyn/0omNUqcTQktZ8IzyMCqt8IzOY3gOXfeCgN9lAPwixWbves4IShiqTYXI340PbhFme RhKHZgLejfLSx1fTMX2RZ2SBhw6K1oQkOCMeqEw/T5AwexICkkg++OlpzNj2aJvi7drhxCd2YeW WvuhIgHxM8ZLeqFummEKH+p6j4kTv5hneFFJ6T5TvWb6ehKwCnzeGork4gf286CBE01XImOo1Hs U/C42TniTVknP9s4wNFTE9/jw7ezuJBU+rU3JD4aoDsXZ35xhm7U4oioRHgyZOT6rro1ag4zpNr MmvinsReiLhU33HNyqB9ip2hy5K+mXNganyNHdGMFpWBw/3fE= X-Received: by 2002:a05:6a20:2584:b0:3c3:2e2b:29ef with SMTP id adf61e73a8af0-3c3575df9dfmr6494504637.51.1784109383732; Wed, 15 Jul 2026 02:56:23 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:56:23 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 6/6] ASoC: sunxi: sun8i-codec-analog: Improve probe error handling Date: Wed, 15 Jul 2026 16:55:25 +0700 Message-ID: <20260715095525.40668-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Drop the redundant error message after devm_platform_ioremap_resource(), which already reports failures, and use dev_err_probe() for regmap initialization errors. Signed-off-by: bui duc phuc Reviewed-by: Chen-Yu Tsai --- sound/soc/sunxi/sun8i-codec-analog.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/sunxi/sun8i-codec-analog.c b/sound/soc/sunxi/sun8i-c= odec-analog.c index 2024e2b2553e..3335855c6311 100644 --- a/sound/soc/sunxi/sun8i-codec-analog.c +++ b/sound/soc/sunxi/sun8i-codec-analog.c @@ -822,16 +822,13 @@ static int sun8i_codec_analog_probe(struct platform_d= evice *pdev) void __iomem *base; =20 base =3D devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(base)) { - dev_err(&pdev->dev, "Failed to map the registers\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } =20 regmap =3D sun8i_adda_pr_regmap_init(&pdev->dev, base); - if (IS_ERR(regmap)) { - dev_err(&pdev->dev, "Failed to create regmap\n"); - return PTR_ERR(regmap); - } + if (IS_ERR(regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(regmap), + "Failed to create regmap\n"); =20 return devm_snd_soc_register_component(&pdev->dev, &sun8i_codec_analog_cmpnt_drv, --=20 2.43.0