From nobody Sat Jul 25 18:09:01 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78A9D35202E for ; Wed, 15 Jul 2026 07:53:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784102013; cv=none; b=bEO5W1TiF9aGwcIAh08i9TENffLPunkQVmzAN01zy/HQhPV2k3vjUWf82CQ8Pd1JDdGMaTqiz3txr+PAGQPGYV+Cy5vSysjvteoMUqzcLb8jl6xnAUPH728mFwAVgwiOcj3aG3cg72GJ7hbH1P/E8w9rYXV1QqCm/63b8e4SD5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784102013; c=relaxed/simple; bh=D+xf8RfBWEGBNWwemwwvR7tBGeYaj/f0s31npwznyRA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=os+yWjDt6GYNdA0e25txcZQJCCsVq3XeEy5n0WHoc8DUw3CN7GntYxG2R97MzXbBIZesaEdhT+j9VA5p/ns4ZR1AQN4nin7n1M4gteMSLCN5GeickoqwfT8EI7wuGctY9AjIsBHdH44dCg+CnCg7AH/wKVevQUA127rxxgXy6tc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=imelOW7/; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="imelOW7/" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-ca7bea5e5b3so3760075a12.1 for ; Wed, 15 Jul 2026 00:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1784102008; x=1784706808; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=LjMpsWc2aaUxCad0LHR+quphAVljZgAmTIIlhxzZwXU=; b=imelOW7/60OJoHiWghOQHBKkK0GICW3Lq0m2vwhBSBX57hn+NsGMLujKNz2s/6BpyW lmpD3HcpE5hMT8WdZwiaeh4OXuvYPzYslEcuc7HhTm9aGp13SCPYDl3CAFol2ma2eImW vO0vi2Hb53Wya0S8511lHbK3YnZdAh1+dKqiaK3zHgE2hi0fzw6ft8oyPEAC7ULoy7o9 K5uREBhCBp9ZwZa5/7/9o/8dYxP7uB4cSf33S6/IJiC4T20ckXhTm8orBvg/KtUNl+7W sSUcq1p7gqY+JwIL2fv+yVM0eaEM0B0ObLEA/7ru4uWauR5nNDDxjMfYegpGc9u6fucU hhqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784102008; x=1784706808; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LjMpsWc2aaUxCad0LHR+quphAVljZgAmTIIlhxzZwXU=; b=nhMBTXOPLJwvl9aEpn6rkdaELPF5nXidJXZR7blMnmYGUeUgiyVJ1wev9vC31X9gF9 hbzz8MsgVyXMN3rpZtGHx0fUeOcaKsEx6Sn+znV3EGXGYvV93haI+W6M/i8EHL/F+Mtb DTh9jWpAjYvPzukhN5Bngh1+2qcLolF5RLpUeTZ9ZxPygmfnkP/dzVsRGt7QIYtJvSUI LXqoftma7R7KIQn9b0FsALTWfQoRmm2KrPvUn1ahpUmxUD1Vw2b/3KsiD8mvoD9ZlbHw 5EJIspZqIGYoUgwCKTCnFxrvLYVJNyAMtQP1ICB/0eMD8v4+biV1Kxg2QAn0QY2cGn/V eqMg== X-Forwarded-Encrypted: i=1; AHgh+RrIygxbF+jiokEvYhnXvidSrgSp9/HFeEP2DKdenpH8ts/yGCdCRW3HUPBqhADZ8hq8GjsvQ90ykaG5PMc=@vger.kernel.org X-Gm-Message-State: AOJu0YwCAW11TaULanEtxKbm3Nv3f/A1ZxA7MI5E7498VkSlHzzX9oCS 1p0PB6JRDw7KIxiRyyYHYgyz3P86tL9CLsLKrGK0QLlanoa/Fs4LGL1YS/DoibRAK3w= X-Gm-Gg: AfdE7clviAhS900vCS0KF9d1y3JBFdY0aq9L1zxjLq8slE9KDkOajI05i/scF68pfG2 ngP78NyidhrHeBJzppxT4hNGwZxuL7rK7uQzGHkOC/sxVbEAPhYfnDtRc2yozMXghlwUrHrEZjh 0ABbNEVFATI/T3zZ+pgoFFtAM7Wmr0ZaJp8gBfwqpttU7qPO5z14A3qOtlT4RwgBTihRyjfP7/V yQqBDOvaHFzw1MQhMM1hB4HIpSQLyn7AHs0dvJB2XRDDUEf0VWlkFuBkHs73yWYEwX3lOA1SMd6 OD6w7AGsKveCQSOvdX6Mn19yA+EdYOwy/FymVLsh/4oiIhZ6xEGSzMHYBzKFv1J+npHKA2+NIUM ogHktPfyrsV4VeUmtBivOfX2t7uKWeuu+XhBwTfWdbKqye68OQMI9QTStTzq5C9g7FdZWMW5D9b XccluDPwb2tjWn4XblQScx2oxZ4MKN0xL+FQEed+T674sOECez9EPX/3qvXIa9whYe8+4zi/Wy1 VHLN1ZWTL4cL7zWDIT7EgCXqrgLw9Y/vyyJpoGxg1Q= X-Received: by 2002:a05:6a21:6817:b0:398:7df5:2dae with SMTP id adf61e73a8af0-3c36c0f869amr2017583637.9.1784102008606; Wed, 15 Jul 2026 00:53:28 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id 5a478bee46e88-3118389d9bcsm75967633eec.20.2026.07.15.00.53.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 00:53:28 -0700 (PDT) From: Abdun Nihaal To: wsa+renesas@sang-engineering.com Cc: Abdun Nihaal , linusw@kernel.org, brgl@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] gpio: sloppy-logic-analyzer: Fix memory leak in gpio_la_poll_probe() Date: Wed, 15 Jul 2026 13:23:08 +0530 Message-ID: <20260715075311.527753-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for priv->blob.data is not freed in the error paths that follow the fops_buf_size_set() call in gpio_la_poll_probe(), as well as in the remove function. Fix that by using device managed action to free the memory on remove. Fixes: 7828b7bbbf20 ("gpio: add sloppy logic analyzer using polling") Signed-off-by: Abdun Nihaal Reviewed-by: Wolfram Sang --- Compile tested only. Issue found using static analysis. v1->v2: - Remove the return code check of fops_buf_size_set() to avoid confusion, since if that function fails, there is no memory leak. Link to v1: https://lore.kernel.org/linux-gpio/20260710064838.153528-1-niha= al@cse.iitm.ac.in/ drivers/gpio/gpio-sloppy-logic-analyzer.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpio/gpio-sloppy-logic-analyzer.c b/drivers/gpio/gpio-= sloppy-logic-analyzer.c index 2bbd308ca08e..aa23b5779802 100644 --- a/drivers/gpio/gpio-sloppy-logic-analyzer.c +++ b/drivers/gpio/gpio-sloppy-logic-analyzer.c @@ -160,6 +160,13 @@ static int fops_buf_size_get(void *data, u64 *val) return 0; } =20 +static void fops_buf_release(void *data) +{ + struct gpio_la_poll_priv *priv =3D data; + + vfree(priv->blob.data); +} + static int fops_buf_size_set(void *data, u64 val) { struct gpio_la_poll_priv *priv =3D data; @@ -238,6 +245,9 @@ static int gpio_la_poll_probe(struct platform_device *p= dev) return ret; =20 fops_buf_size_set(priv, GPIO_LA_DEFAULT_BUF_SIZE); + ret =3D devm_add_action_or_reset(dev, fops_buf_release, priv); + if (ret) + return ret; =20 priv->descs =3D devm_gpiod_get_array(dev, "probe", GPIOD_IN); if (IS_ERR(priv->descs)) --=20 2.43.0