From nobody Sat Jul 25 18:06:53 2026 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F3C33A759D for ; Wed, 15 Jul 2026 04:19:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784089153; cv=none; b=btrDtwcdXPCx0V7xOtM9VYdvpyn/Yx5tatn6aHnSgRaiUu4W4OtbL2inA1VsreZeE1i179TvttUa1evjxCeM6AmIqMhwfagCeAXHj4LjW6KFy7eNLG2cqgr6WSX8mPcK/JWfeBDplpc/gAS4KBGPNoux4s9M16nxzQ75iaX7Gxs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784089153; c=relaxed/simple; bh=ChXFU86zZXJSh07Rc24E3XkS6sKKwswF6XgMOwXS95c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sGSgRFR8wKEdgy0jm8xZo1eo32O5jIcXd+jOOAJXpt6zHZ4OO2+XalEUuVIo73Fk/oDFbz2UhxE7qLkPV6yTrCEdFDW2L7rXqqxxeBs2mWhaHfEpPx5fCFUx2cRr+dxmKa/7Mi37OeePTTQ90xbZjOnJDF8C/9O+tiSjJgEGD44= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=ox/xjLFi; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="ox/xjLFi" Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id B16573F57C for ; Wed, 15 Jul 2026 04:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1784089143; bh=EaZaratfNTF8DtKMxw1rXcF1pvNeOWsjlYC13qTOwzk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ox/xjLFinawCPY3QOXAVBZgjvamWUlsp6XwuM6vjcA+AfD/klCoTmVuIQfebP1wj4 uRPU0ezfStjkCDRtCN3Ka5eDtyY0RRYewpkAT+DDERAUFiLARXYnXqSQWkz2IOQVqh qZDtNCHnX1CNJGtHQSKmZr/WwFOoj7UuMhhcFSNmSXiFPY9ILUUQKCp9Gmtb8cKr+d NDokCPzg1jv+fQquurK9ePVxDbxQwHtckvH3KYAw8Stg7d5ZlN7XxjWZ0hlrAebGZU MNPjM3HIUptrx3pyWt57S1CpLxuU4nynmsXLzoFoCtKfphhdbDGxDTaa/Ixeefzbt5 eoXP1RrVWdRAGciWgAWHeXbYAeGISF1n787ruVQP/a/GUW+fyWtM7CuhHj9Ii/HywI R2RMY8TYo76ETo5motmwNUYKBxPDwHuWGB4daAIQymf3pGRmsOGh0BZrOwbaza+0KE YXkEly6snb6+JTaoB7nzOCuiZC7ezf1wsRFG3n2Kir93QugVMK+oNNydqlXaH5Gfd2 mMaFnhnSs5pLn6oFYfFQsOl1BuKOoEi5EcpRFyHC7bTHo6xsYmHvrYU9Jb1HFSzwcA GCdHsKkMqa5ImPH7EshoMXJ52sZ8KiPS/VDDReUDpwLatQVywXAiVOgksPyOweCZMq +2iUG5D/xSSNM5w5SBT33R+Y= Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84865f326efso5511168b3a.0 for ; Tue, 14 Jul 2026 21:19:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784089142; x=1784693942; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EaZaratfNTF8DtKMxw1rXcF1pvNeOWsjlYC13qTOwzk=; b=jcO8yfchajcxRq22AaIoK691sZEpwe9jI78S9hEQ6NH674ksHwIVBN7g3i5c38GIJb rQV3ttcwgggvClg1FYHgPiredbvqP87oDH9vPbYAWchj2qCXhMmsg4lPh7Q+R+e6aNc0 Fo+w45N6jyP2zCmifWvYAW+Cl5R3/IBjnD7Junua/M1PfeZYxr66mtEfpe8VR/n0sCtM ytZ94vHHEN3ImSgH/oae3wuMuU/snN612L+wqRoIPVs0EP0cZsRfO9xEd+dEwXMa+Nw7 lojA7H4gtq8tJrNourJDiiMWSGCIEA1zxrdGf5ot78ksH/oDoDw6jKyeFPlATIFIQMFk cbTw== X-Forwarded-Encrypted: i=1; AHgh+RqwtnhAdq/YW874jsw3s4LAaLhQ6D9qPEYFSx/JdMftrotQj+jdrxYxtKCEcS87VYaRDZzlnYmb09oc8Pc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4dJ5CpSo4ObnAIP62mhVGuDG1U+n22im+dXnwtxpeSottMYMg z89+id+uujsrOi+obMllePElUfXn7+3RYzknGV6snsfJaNqJIuvkVnpjb7HQQSVKZL3uzRpEoqM U2a58lLXUsteZX9WeAEwwvRTEEI2cFzDplfUDFP0Mua9WfRSw/0nj7yxmebMA15B5aMK2I62AUx Ep4/MgnMrkqWtfKQ== X-Gm-Gg: AfdE7cmhu+7Eo8KQhEbbneeBk02oTa4pdd5jp6YLKKGZJwLemDQbndxBhtDsdWHGir4 ZvAyWyOry6JpXseZ4TMfnCZQyftwcTmJTZFaVbFhFz85kcGBwlv7v4ol2FR/1HCbjVZUBJ9WhyH t5J49a3+88qPPKj9dWih5z2Zm9rQWh1lkMHcKNDSKzTh4WOTfCpqAayiSH28wE0051wW1yGr2pg QfbDcT9XSA98sC2RtIM5X/cnn3FAH3eMT9oIdTmdmpzA//IpA12UQn0omH0GqLiotW9+9h//SsR EmZbv1/If39XZyQAZv48y6vbxGsvyr2XAgc43q+rfEsbnAk5/U/xMpI5qaugRAhh6txqcr1mwHM Kbnwc514q+TtNn6FywwwAzV4tftqJqiaQT8PXs9cRig1ufGbv1fSE X-Received: by 2002:a05:6a00:92a7:b0:848:31fb:43d9 with SMTP id d2e1a72fcca58-84a673587f0mr1030128b3a.45.1784089141942; Tue, 14 Jul 2026 21:19:01 -0700 (PDT) X-Received: by 2002:a05:6a00:92a7:b0:848:31fb:43d9 with SMTP id d2e1a72fcca58-84a673587f0mr1030101b3a.45.1784089141332; Tue, 14 Jul 2026 21:19:01 -0700 (PDT) Received: from localhost.. (1-161-28-137.dynamic-ip.hinet.net. [1.161.28.137]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f23895bsm2405218b3a.2.2026.07.14.21.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 21:19:00 -0700 (PDT) From: Chris Chiu X-Google-Original-From: Chris Chiu To: tiwai@suse.com, kailang@realtek.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Chiu Subject: [PATCH v4] ALSA: hda/realtek: Add inverted LED quirk for HP ZBook 8 G2a Date: Wed, 15 Jul 2026 12:18:55 +0800 Message-ID: <20260715041855.63264-1-mingshuo.chiu@rakuten.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chris Chiu HP ZBook 8 G2a 14 and 16 (SSIDs 0x103c:0x8f94, 0x103c:0x8f95) use the Realtek ALC245 codec with a TAS2781 amplifier via I2C. They share the same hardware configuration as the existing 0x8f40/0x8f41/0x8f42/0x8f62 models but have inverted speaker mute LED polarity, so the existing ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED quirk drives the LED backwards: off when muted and on when unmuted. Add a dedicated quirk with inverted COEF values. These are speaker-only models without an HP pin, so the LED is driven directly through the vmaster_mute hook; there is no need to probe the HP pin at runtime since the configuration is static and known per SSID. Signed-off-by: Chris Chiu --- Changes from v3: - Drop the runtime HP pin detection; the ZBook 8 G2a 14/16 are speaker-only models with a static, known configuration, so the LED is driven directly via the vmaster_mute hook. This also fixes a latent issue where the hp_pin branch fell back to alc245_fixup_hp_mute_led_coefbit() with non-inverted polarity, which would have made the quirk a no-op. Changes from v2: - Corrected the fixup entry so both 0x8f94 and 0x8f95 use the new inverted quirk - Simplified the commit message sound/hda/codecs/realtek/alc269.c | 43 +++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/a= lc269.c index e809d838ff58..ee8cfacffb31 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -3495,6 +3495,15 @@ static void alc245_hp_spk_mute_led_update(void *priv= ate_data, int enabled) alc_update_coef_idx(codec, 0x0b, 0x0c, val); } =20 +static void alc245_hp_spk_mute_led_update_inverted(void *private_data, int= enabled) +{ + struct hda_codec *codec =3D private_data; + unsigned int val; + + val =3D enabled ? 0x04 : 0x08; /* inverted: 0x04 led off, 0x08 led on */ + alc_update_coef_idx(codec, 0x0b, 0x0c, val); +} + /* JD2: mute led GPIO3: micmute led */ static void alc245_tas2781_i2c_hp_fixup_muteled(struct hda_codec *codec, const struct hda_fixup *fix, int action) @@ -3523,6 +3532,33 @@ static void alc245_tas2781_i2c_hp_fixup_muteled(stru= ct hda_codec *codec, alc245_fixup_hp_mute_led_coefbit(codec, fix, action); alc285_fixup_hp_coef_micmute_led(codec, fix, action); } + +/* Same as alc245_tas2781_i2c_hp_fixup_muteled(), but with inverted speaker + * mute LED polarity. The HP ZBook 8 G2a 14/16 (0x103c:0x8f94, 0x103c:0x8f= 95) + * are speaker-only models without an HP pin, so the LED is driven directly + * through the vmaster_mute hook. + */ +static void alc245_tas2781_i2c_hp_fixup_muteled_inverted(struct hda_codec = *codec, + const struct hda_fixup *fix, int action) +{ + struct alc_spec *spec =3D codec->spec; + static const hda_nid_t conn[] =3D { 0x02 }; + + switch (action) { + case HDA_FIXUP_ACT_PRE_PROBE: + spec->gen.vmaster_mute.hook =3D alc245_hp_spk_mute_led_update_inverted; + spec->gen.vmaster_mute_led =3D 1; + spec->gen.auto_mute_via_amp =3D 1; + snd_hda_override_conn_list(codec, 0x17, ARRAY_SIZE(conn), conn); + break; + case HDA_FIXUP_ACT_INIT: + alc245_hp_spk_mute_led_update_inverted(codec, !spec->gen.master_mute); + break; + } + + tas2781_fixup_txnw_i2c(codec, fix, action); + alc285_fixup_hp_coef_micmute_led(codec, fix, action); +} /* * Clear COEF 0x0d (PCBEEP passthrough) bit 0x40 where BIOS sets it wrongly * at PM resume @@ -3857,6 +3893,7 @@ enum { ALC289_FIXUP_ASUS_ZEPHYRUS_DUAL_SPK, ALC245_FIXUP_HP_TAS2781_SPI_MUTE_LED, ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED, + ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED_INVERTED, ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO, ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY, }; @@ -6327,6 +6364,10 @@ static const struct hda_fixup alc269_fixups[] =3D { .type =3D HDA_FIXUP_FUNC, .v.func =3D alc245_tas2781_i2c_hp_fixup_muteled, }, + [ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED_INVERTED] =3D { + .type =3D HDA_FIXUP_FUNC, + .v.func =3D alc245_tas2781_i2c_hp_fixup_muteled_inverted, + }, [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] =3D { .type =3D HDA_FIXUP_FUNC, .v.func =3D alc233_fixup_lenovo_gpio2_mic_hotkey, @@ -6873,6 +6914,8 @@ static const struct hda_quirk alc269_fixup_tbl[] =3D { SND_PCI_QUIRK(0x103c, 0x8f41, "HP ZBook 8 G2a 16", ALC245_FIXUP_HP_TAS278= 1_I2C_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x8f42, "HP ZBook 8 G2a 14W", ALC245_FIXUP_HP_TAS27= 81_I2C_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x8f62, "HP ZBook 8 G2a 16W", ALC245_FIXUP_HP_TAS27= 81_I2C_MUTE_LED), + SND_PCI_QUIRK(0x103c, 0x8f94, "HP ZBook 8 G2a 14", ALC245_FIXUP_HP_TAS278= 1_I2C_MUTE_LED_INVERTED), + SND_PCI_QUIRK(0x103c, 0x8f95, "HP ZBook 8 G2a 16", ALC245_FIXUP_HP_TAS278= 1_I2C_MUTE_LED_INVERTED), SND_PCI_QUIRK(0x1043, 0x1032, "ASUS VivoBook X513EA", ALC256_FIXUP_ASUS_M= IC_NO_PRESENCE), SND_PCI_QUIRK(0x1043, 0x1034, "ASUS GU605C", ALC285_FIXUP_ASUS_GU605_SPI_= SPEAKER2_TO_DAC1), SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), --=20 2.43.0