From nobody Sat Jul 25 18:06:26 2026 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B141C35AC03 for ; Wed, 15 Jul 2026 03:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086722; cv=none; b=N5csvSnKfbocTc+WsYVdxSduyuhX2ullw8OG0UfpD5KlBVW3ne4l9CdX8dCHuTRs9+xUPDL0rIApYTHglk6iaRwJZKJOfkOPehuQlCd3o8QXvI+OcEDQvS4Jzb/kI60+TNzmkshF5ZDMHhht7b4qY0V25WShOUUzai3NfxZerbM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086722; c=relaxed/simple; bh=kTxcJHE6iVe6RfB49bXDbrA6ICjAjhcYetRvA3pBtHM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A9BDmQ3p7f7Km8oIxv2UyCopbEGV+xxisjLPa0BmvXNH8+8LjnCXAHavB0EDrXatlVyZR2Wx67Wn+IjjYdGffnizg5QNL7/c3L6VILGuT72GYVEBMcAs1e1lO+/K5/wYcihH9iqVIboZaHQxmyipu3f1QkxAygch5f076g8eD5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eM4XG/Dd; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eM4XG/Dd" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c96b08cdd1cso3358102a12.0 for ; Tue, 14 Jul 2026 20:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784086711; x=1784691511; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ctC2FHVouwwXy6nRKJZij8fpoFOJxlyQsKFiZ9amI48=; b=eM4XG/DdGe7oHi5H9Hm0gIE3o1of1KlMBb91W+35xPJgGJyBbCz5oVEl0ulZhEQAFh 36kX+UBv0VM5ccgbw7XbbYKqyNCPL6FDba2ZMApJX63fk/BOQ7KQ8RPuguiNf72tZZqq sQr4WTTf2aK7aA0kGkaoQNZ2H6MVEy/Ykfwk/J+rBHKIW6TaWsLHjlGK23k2om19L+vT K6cF9Xcuz/CWBIEJN4ud+O4SFlPvygOPtgyIk2t7pnpMryii0gu4mRMzBwnT5Nil1wwR MZLw+OT/+Et9l73Zso4bI+cpYBjCOmPvVUnHTThe0NzdV3ggzEMhOuZyTrsZaO91ed+d +eEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784086711; x=1784691511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ctC2FHVouwwXy6nRKJZij8fpoFOJxlyQsKFiZ9amI48=; b=MIOOVsESLdI3Z60kKjzny2k7DKazD7jyBEj+AJMLwUgkvUp2hE5TrM+ET/12HmbzH2 IqF7CGL20hwKMLxzhecGsd9vX6apM10wgqlrTFe/f7tn9yAU/RM3iOQZ2KJ6oerSdAei HUd4cFcrbf9b/Glw4ZTKmrJhtgvyIJmidhi7e6gU9/ETIY9fxBrlboZgGrST5iI/lyZ5 rrhEAaHfKPdgBt9KD89eg8zi+wooGyfREOE4QKQJZ33GFLcrtSF3v5rse5j3gHqblH0Y e59dDDTjqapwWRmBvIU+7nPtKRgqofHOa02ToUN9hLV7U41ybjbctg2TdKHUz6pVh2Vh lGzw== X-Forwarded-Encrypted: i=1; AHgh+Rrkw7dDatULSX6z+3v/YCIhszhpbJfe/0k96N+rq+7314wZhLKexATO7OPAA5U/qoa8DSj4gRh3fW/3GVA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywa8QUlHTHpAwKKvgiY9CoOjXgGMT9sOpufwHmzm4xPAPnHHoDt h32BJ/RahnnKSslNS0I+/Q+GuXpUW0k/lMnH09Ihr1NdyHfvj+2G5Qfh X-Gm-Gg: AfdE7clRgYsefp/wIA+j6VGQm3sEyACnDz+02AwPrMGNVxgnObMovius3kdqi2NQXvr cUmu/vv0AUPFKPg8iXGg08Sr8IXRAJtfx6AeCPU1DHQRhH+XEk0BcvAzT1be+xNjNkQN293KAyU We8tTEW4Noe5IVJVEm2gd5KlTOJ2kc+9oOIbAwEiKFjcWxBNmxTZ+lJuPzRRg9UsepP43GzS6hf h2dqLC7q+n92Rpkeb1elkJj06EkJSjLHtFwpnVh3bfT7/8MNciYrJ0uQ9Qu4v9dA6vjfiVv0YVb dulYU7AO2bDg72rhL9ghbJVWhhcEZqLLg0SrRhAADkTXztuoFUj3GSNijioA13lcp4JRgWzBKJN loKjZVvvv2694cjHvYUj/W0OP5NKbPJCtsm9bIPb9TxUb7158JpF++22y1Dg6rbxX+CrZG+KYKM dR6WDjnDwuRdnDmp1XH0xBSCEIWEQfwvwuKCWAQyvVr3Q= X-Received: by 2002:a05:6a21:101:b0:3c0:cb82:508c with SMTP id adf61e73a8af0-3c36c371b85mr1287451637.49.1784086710623; Tue, 14 Jul 2026 20:38:30 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174a583bcsm91977889eec.19.2026.07.14.20.38.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 14 Jul 2026 20:38:30 -0700 (PDT) From: Biren Pandya To: mchehab@kernel.org, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, =?UTF-8?q?Niklas=20S=C3=B6derlund?= , sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya Subject: [PATCH v2 1/5] media: i2c: cx25840-core: Add missing media_entity_cleanup() Date: Wed, 15 Jul 2026 09:08:20 +0530 Message-ID: <20260715033818.10967-8-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260715033818.10967-7-birenpandya@gmail.com> References: <20260715033818.10967-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The remove function is missing a call to media_entity_cleanup(). Add it. Signed-off-by: Biren Pandya --- drivers/media/i2c/cx25840/cx25840-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/cx25840/cx25840-core.c b/drivers/media/i2c/c= x25840/cx25840-core.c index 69d5cc648c0f..a3d7473854a3 100644 --- a/drivers/media/i2c/cx25840/cx25840-core.c +++ b/drivers/media/i2c/cx25840/cx25840-core.c @@ -3962,6 +3962,7 @@ static int cx25840_probe(struct i2c_client *client) int err =3D state->hdl.error; =20 v4l2_ctrl_handler_free(&state->hdl); + media_entity_cleanup(&sd->entity); return err; } if (!is_cx2583x(state)) @@ -3986,6 +3987,7 @@ static void cx25840_remove(struct i2c_client *client) cx25840_ir_remove(sd); v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(&state->hdl); + media_entity_cleanup(&sd->entity); } =20 static const struct i2c_device_id cx25840_id[] =3D { --=20 2.50.1 (Apple Git-155) From nobody Sat Jul 25 18:06:26 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C675A3B1ED7 for ; Wed, 15 Jul 2026 03:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086726; cv=none; b=mMDfJrpCgkDp/QoCAATaFEOjrgUh7ANemcHf0wkJ5ZjXFpE6kmcxLMywKZodRCX2cu9JmfphXdvST4ANAcYey0BOKuScFJbi7KIatC5+WUiN2dIjiRHAZQI6xDOaaGJjh4rIv0kdNWzy1G74xe28xq9cJbtD2LCMW6kDrUyl1Mg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086726; c=relaxed/simple; bh=JzjOso7/wwynAxHjmTNccaM/1TFx/LTbSs5RRtSmy/w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CgWb+5hOWw6g4nz/rYmIMzi0vXM9wGjb3Zzd4ZXBbQWg149mWTbvj/vBzgVSA3/gT+W2nxKeenJEZz6srNhDcuju4qPj5mY9m42TVs9U6Jtj8yXMyYVoDXg7ZZ3QqILe9Kciu04cxAP6ZmhMTFLSv9kK34EMW+0t5v+ODQj32BE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UCJeeoXZ; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UCJeeoXZ" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-384c94c9414so1409170a91.3 for ; Tue, 14 Jul 2026 20:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784086715; x=1784691515; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NC0uBNFhos9Xnquc35vsABLKrcnqiNY5ZuQAYS1JZAo=; b=UCJeeoXZulm7k2Vr0CmjdyLODF+j1B+eZUoPiEQtO2AcTB5/pw8FTcBDiiOgzEeY/U ySt9elHtO3yU0jKF1QNBtkG188kub93MpGgG6PO06NxlE2whonlX8y8aqT+T2pHTkEUx OCQY3bYMZcfr4gw56oJeC56ynSZz7vgmohpSTgxBC2QXrMEUVweWBkgsTrPCGmHi4qhJ s+dAvbL5IajU492goTTiZ9BHIjn4qlUzhh8b6KEDZ3O97b3BwkQozv5bFo8FR5ZLY3ob CtfxO+BMyE0CKPPexL/UUkHWFUiu1YrddmeHmm6dToGyp6V6EvY9SHfKW3pSAxE8gw5q PE4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784086715; x=1784691515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NC0uBNFhos9Xnquc35vsABLKrcnqiNY5ZuQAYS1JZAo=; b=ZVBA1BRjth+lnisTczE4YRvqzYIV57nJpnfCfUWJgZuKayC0Ej8fxEVE53ulqF3RNu wW9lN3q1o35ZzJLa04WN4+DRBxiDxzyirM+HJfzsodx6ZXMK9JoLdnKW0AwnJ3N6mwXY 2gfxpy9ms89dSNAX7yMkintSeRkhgTYMDESHR4WqkHHyRyIVZS2Cm7Oq13W+A/XiokEp HYaaOk6iVqZ5xBkY9aFLjimE9WI3VfQWH3vP85TmqzpOttx5asWZZtYme5opK2phZzM2 pNI9D9LKWJCUXJiPwM21P3CqtrDBKVFaGdVtgK6tbMWmh8W0x+MRhIXQl46O8p9NEmEo /aKg== X-Forwarded-Encrypted: i=1; AHgh+RrNrFNd3/9JAcDezAIB7wFOwVbk8EjSXJn0pYo4HlzFooHyhBi1xsL+hOTKDxAoVnxna2eRTfU76aNZNQk=@vger.kernel.org X-Gm-Message-State: AOJu0YzKwWZOzv3hTsXkXRvXS0hGUQTtM9HjkTNY54ewa39HDfk4i1yr 1e97LKW77pwhL8MNpZOf2NuL8NsSKSAD+r2rwIg9CLUbEtty5T1PE9uQ X-Gm-Gg: AfdE7cnGmEpf8xCd9DKekoGPQ/7/dKXHezB/kwaXYjblApijQ/xtBKzaSkklbSQ5Tx9 Vm/fuMgPr4eEtx5ycRIlVa8yaAwqoa9cy4zyUPmyDIDAF9OzdHir9JftjLIVzHUZvq3s8a0d6SL Beme+bCsv6rippTzxZztE20EInbONt1YMMMzSnYfveKwqYxy5fKGYa2zf8JYrG3HS1JXW3FOlCC UBKXBsdtRX/sSlth2pxTcUnzuL417L3Ds1J++kBEEK8lhZ7V6F2cx/LSUe1hhW2J0MyM7nXJLP6 qoLNLSXwXzCE3c1Qcif2fGvtXBn3TWo5OJpWBYQLpOnjZm/wQj9QuOhDGBd1qYy4wBkbHwLpfgu cfrCnI4+IU3oXRhIFUIPTUjAaashf0Bq6DYg59O8luPIL6hu/6j6v3bucM10aWKpNoKeOw8Sn90 LGT/CbA3Cw5fI+VHgmkLpmkBQOeEmvHsFQhRghUt+R8gE= X-Received: by 2002:a17:90b:1fc8:b0:37e:2005:6507 with SMTP id 98e67ed59e1d1-38dc75f4cf5mr14387980a91.15.1784086714915; Tue, 14 Jul 2026 20:38:34 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174a583bcsm91977889eec.19.2026.07.14.20.38.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 14 Jul 2026 20:38:34 -0700 (PDT) From: Biren Pandya To: mchehab@kernel.org, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, =?UTF-8?q?Niklas=20S=C3=B6derlund?= , sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya , Jacopo Mondi Subject: [PATCH v2 2/5] media: i2c: max9286: Add missing media_entity_cleanup() Date: Wed, 15 Jul 2026 09:08:21 +0530 Message-ID: <20260715033818.10967-9-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260715033818.10967-7-birenpandya@gmail.com> References: <20260715033818.10967-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The remove function is missing a call to media_entity_cleanup(). Add it. Reviewed-by: Jacopo Mondi Signed-off-by: Biren Pandya --- drivers/media/i2c/max9286.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index ac0712ce1e65..79eab9045e24 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -1062,7 +1062,7 @@ static int max9286_v4l2_register(struct max9286_priv = *priv) priv->sd.state_lock =3D priv->ctrls.lock; ret =3D v4l2_subdev_init_finalize(&priv->sd); if (ret) - goto err_async; + goto err_entity; =20 ret =3D v4l2_async_register_subdev(&priv->sd); if (ret < 0) { @@ -1074,6 +1074,8 @@ static int max9286_v4l2_register(struct max9286_priv = *priv) =20 err_subdev: v4l2_subdev_cleanup(&priv->sd); +err_entity: + media_entity_cleanup(&priv->sd.entity); err_async: v4l2_ctrl_handler_free(&priv->ctrls); max9286_v4l2_notifier_unregister(priv); @@ -1084,6 +1086,7 @@ static int max9286_v4l2_register(struct max9286_priv = *priv) static void max9286_v4l2_unregister(struct max9286_priv *priv) { v4l2_subdev_cleanup(&priv->sd); + media_entity_cleanup(&priv->sd.entity); v4l2_ctrl_handler_free(&priv->ctrls); v4l2_async_unregister_subdev(&priv->sd); max9286_v4l2_notifier_unregister(priv); --=20 2.50.1 (Apple Git-155) From nobody Sat Jul 25 18:06:26 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 105CD3B2FD0 for ; Wed, 15 Jul 2026 03:38:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086727; cv=none; b=R1fq1l6N3CeUfG7mqZri8BU6cN1Z53XgELdlL+AYEvdLVzNZVd+/fkTj2ZYc7CnZFFu8T+dQpTaSYAVAYq5Ol9nkowJlwk6SrHtl+PW01RRFFe0ZhqENSNuLDmcBmgyqJk9dDA7tV6/oAKVF+r2xt0pgr7ElXR6Gdq2tWYBcSBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086727; c=relaxed/simple; bh=bRZRmeuak8UGKeftukzPu9pf5prdsKVf2Hg9qG80Lio=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZYccAJSLjUBYjXDc3AuVjKAgyDBcGHOArWNhq2gISBeVFIYGvkhstBOyLqI3vWJnZy+lOGg/mJg2Zwcss0xgXkX8ZVcTK2t21S9Fwu3dwugF78/M5qxxQmYyvsNNlTc3qG6tAY0VGIj2Mp6JL505Lg51Lydm8cAi4fgz4SRXC34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JzQTd4Dx; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JzQTd4Dx" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cedda2ce6fso18754015ad.1 for ; Tue, 14 Jul 2026 20:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784086719; x=1784691519; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I4LF8M4ghb+YPtxRjEmX1qyfcwiqHlXNeKROLqcS8Yw=; b=JzQTd4DxuTApcV54AOKr4PfKm8P+l56qDtbM3IW62zd60nGx8WWeTjIqYIRYStJCis TDO/ow5hlubks3TNgQtYVcO7DfrROdudGEFAD7DSsnV78vYJYnSSEy3pEA/makPVfM/k jhtz5lSQgRHzg4QruHxAMIue56tHjBhlEhFlvQboaoiBJXKRDbHeGuN0ouhvQ1om9rHX MDAzoaNNjoaB9buOcjYXyN41bJof/Lli9WDlvTlDWfLe9E/1vq+K/o8L0OQeSW7HfzeR 7ggfNjfkpEOllpRWElvB93uH2zoViCzB7HlLgDh1Il+27G9JLA3OooREJ7KeyYiFRQ+a +KrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784086719; x=1784691519; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=I4LF8M4ghb+YPtxRjEmX1qyfcwiqHlXNeKROLqcS8Yw=; b=pxLPKqEPJEzXyb7UNXifsb4/eZL5r6e805ZzMcKa3UXpSkkljqiy4AK8yEn2EAo+5V c+Ilq3zxXN/CWGqs3M3E4IF8vX0785cgvNOqcjGBKJDOHecmXLo7oqFriZ2WTrcecTg5 70QfxQYp2j/CPlUYMsWv/RciMXlqNnedEW4l1Z/tTBNvH7BzKQdbmGuuDlyxU/CZ8KzI 1F/dkLOYk48xMZ8uaBUD1YG5rj7N0HbCG5eLJ2C3Orl1I5DqN0coUEF4ug2EdypqlmNi m2Hb/eQVGunHBpAl6Dp3b+4CWr8C1qu1dbSohH22Kx7A+yYgM7mfyxWr27zEODTfHeaG pNjw== X-Forwarded-Encrypted: i=1; AHgh+Rp1GJec653+JxQjIv7GZjb8cHFVK0riaJ1Ml/zgyfg9c08rPz2mwG1JYU/waw16I68PZKsvBmsrXHQXYWQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8R3r0spmMHJDDwxvae1/g/ZNtm71+WUO+ntwd3gvHDQRNVPEb sSIQZPyj46wpUhYfOr3z+Fk0zMonXKNCY6QuMNk6xwX9cVazv5z3Gw4M X-Gm-Gg: AfdE7cn76N7khEYxpe/LyB4Fq9rM2eLSACJR3SFJrHoKD2i3AIkZNCgV49fXMcMEy4b X4kTq4VQXVeIoJsWDbr/uj55lFWoO/YgkHBCQbgH7QQecvESVDXQ1PUVPkAGf1knXU4c8oaR5lf eXUuRN3JNYrqzGaNhmmlbnGJJyeV6935/c2yq/XfO7dMQS2rAnAoOVE0WZlKUDbaCvUxXgMQm7h WjYBHeZ9Qas8XZ3mHVVj9rW7IOrKBdq/QOa2HYkHgb6OvkRBC+EtakacIjglbybldGud0mOSYjc cD+IRVh62ozzLRz5P6hQ4wNobqFrv1vQhlzwcrawZaeSiD7aV46aDx5MZ0+di/jj1wlNBk7p9TN Wq2VksYNzwwZPDwaWQGOv+Ax2sUBB7dsnM4i+8pokivTww8hQbcKehuSntI+JrdRJ1A3G3r3/rg SqGzXpJCZIeGIG3je1JkExgi6me1wf/N/aFDdhIftmL0A= X-Received: by 2002:a05:6a20:e68b:b0:3b4:6f7e:d0f4 with SMTP id adf61e73a8af0-3c356f75ea9mr6242435637.15.1784086719025; Tue, 14 Jul 2026 20:38:39 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174a583bcsm91977889eec.19.2026.07.14.20.38.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 14 Jul 2026 20:38:38 -0700 (PDT) From: Biren Pandya To: mchehab@kernel.org, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, =?UTF-8?q?Niklas=20S=C3=B6derlund?= , sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya Subject: [PATCH v2 3/5] media: i2c: msp3400-driver: Add missing media_entity_cleanup() Date: Wed, 15 Jul 2026 09:08:22 +0530 Message-ID: <20260715033818.10967-10-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260715033818.10967-7-birenpandya@gmail.com> References: <20260715033818.10967-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The remove function and the probe error path are missing calls to media_entity_cleanup(). Add them. Signed-off-by: Biren Pandya --- drivers/media/i2c/msp3400-driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/i2c/msp3400-driver.c b/drivers/media/i2c/msp3400= -driver.c index 4c0b0ad68c08..48c60050c5d7 100644 --- a/drivers/media/i2c/msp3400-driver.c +++ b/drivers/media/i2c/msp3400-driver.c @@ -717,6 +717,7 @@ static int msp_probe(struct i2c_client *client) if (state->rev1 =3D=3D -1 || (state->rev1 =3D=3D 0 && state->rev2 =3D=3D = 0)) { dev_dbg_lvl(&client->dev, 1, msp_debug, "not an msp3400 (cannot read chip version)\n"); + media_entity_cleanup(&sd->entity); return -ENODEV; } =20 @@ -812,6 +813,7 @@ static int msp_probe(struct i2c_client *client) int err =3D hdl->error; =20 v4l2_ctrl_handler_free(hdl); + media_entity_cleanup(&sd->entity); return err; } =20 @@ -865,6 +867,7 @@ static void msp_remove(struct i2c_client *client) msp_reset(client); =20 v4l2_ctrl_handler_free(&state->hdl); + media_entity_cleanup(&state->sd.entity); } =20 /* -----------------------------------------------------------------------= */ --=20 2.50.1 (Apple Git-155) From nobody Sat Jul 25 18:06:26 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BBF13B47D5 for ; Wed, 15 Jul 2026 03:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086729; cv=none; b=iOKfM5lAQtY6lXChW4uy5ReF8DTP4PoOt5/x1pwhl09MfMFZVKj1XPmsfdaMrIUIIJRoiLFyOoxszjPY59q6sbPPnr7f2He6agwA2zBkHqevdDXlH6HUhk9ndSuPcrGJiQenlCzs4PmTv8gZ5ntRqtAHlir7/PWjtIUVlW1MQms= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086729; c=relaxed/simple; bh=uQpQFEgVQRMZl9ga6dV8oBi/I0Inhusd5je+kblypos=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KRg8awGsCwi87wjXFISUKjiTg/b7qrWvOdEr8dvt0hdnxhONArihzI51PdamAK+NS8QynMdgRlyMEDDxZa0BOZVm+/3VhrZ9ML4y36cInwxsoW/Bn9QeB0cXnTIZuJKNVm2H/bgHJ30o0VG/GUOKNKv9P9Y/vVuCxmvLcmw1tno= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L3OYEyRA; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L3OYEyRA" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2cc61541f8cso2698635ad.0 for ; Tue, 14 Jul 2026 20:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784086723; x=1784691523; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uVEg2i1Z7njPeqcdf/tSoRttZE7Mq1P1yGV0C9miEPg=; b=L3OYEyRAIVPVafkkMRy/GidjojTCAxG35oX3cHwrR5D7d4ypPvfGPz84A4oDZ3aH1q HQRS5M/XS6G2wkdwHMIS9to6+TOHub/Kft4IS/Q7PQjRvwkidl+A4v6DThayTFF8R5bD Fo4cks2oeDpHYs+K/dhmMsbbfmxGzIiC22Lx3v7det0B5ixXmPfSyRMtcst5fZFyPIys 6Jmh3ro2VlPM81iHVtTK0cJ44BkEgb/LCWVy5GE9O7r9qKlOYTaNbMSkjqJ9qIkO3s5n CWQlG9ty5mTShH76f07YjoX23mCyEUXDiiH9M2bDgk3Zd07vPyipzGMdEh8ypxN98+II xogg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784086723; x=1784691523; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=uVEg2i1Z7njPeqcdf/tSoRttZE7Mq1P1yGV0C9miEPg=; b=hiqftgHKBMix8bhDQ9ic6m6u9yYKAjRqamqi/qKlc6opMtgVfvRteccadKrh1PHddR zviwOgARn6DdDj17Y5rCwaMgGpvLwHn9/E6V5info0nQ5mcUNeeTE7Fw0Cvd0iuptQp0 siehqYZraK/NwKQXA4RM4aW5ZAbMr9quNYuIRyGtc6YmNyfTi0kPsRPLo0yosYsGvBk5 brsKQ8PVxC/vgSFhf5TjqJOfjD+WTGn8MMbLUpZlSC43aqvOket7JJUd1XWUZ6E0iBzA Rb+Nmu+gRxNztM4v5Vvn4WnF42uRBpaqPDxK9Et+wrdbRS0kh/I3sobi/c7KKRTB8ucs BWbA== X-Forwarded-Encrypted: i=1; AHgh+RofbenuUzlEOetFSjWa9voJ+++Lyyt+KkF8aWg7G+IqT7SQp2Mt4yIV3Y/ElOTPS83KpaERWzR72jmqf1M=@vger.kernel.org X-Gm-Message-State: AOJu0YyBLZv01xJAmdauT6RnCP0RHxrXK6tztd9/X+HvHSgrYG8OCk01 SzNaEVtCxpajR4KRYaLefP4pmU9CRBjfOpBMArEY66BJsA7Tsspn6KHHz5Uq2j8C X-Gm-Gg: AfdE7clJCnC60MmaYeQQNZkPcUKsLKM0kENAnDtSyDdfPcvI0XCMaBkv3cUlUWf4GML ruw+6wJgyNH3kEHmxymJMeb/18Uag7eDR4Se3O4lZfO72WP62Jz2WYDg/YjmDQHGyzrVUhcXxL1 z+vDLLh+P5yLAgOC42Y/nBR6TMA/nG8t7904pZD5gp3Dm/IxB1tWwC3on64Y3tNyvxEr+NtbHod dz42WJZtij6CDZTgTsRoKFJQPXzbkYp2KNHjCx5pdF532IW1Lb/Yp4usI5/bwJFaj7N4Q6jfEcI 6Ep/mH4WuXgfci+IJt+bIpRbTcW7W3hpmzytrpbEMBQOPV7jsj5YI4hPjvrFaggiCJlNt01Ppxo Xv7+nfXCMK2n7iE7NpsKeBBw/UGEWqzBjiZnyo0iWWNg/zTfWc247oVnDwfByLtiodtnGO6juL3 n+45EYk3SpMR+ZH8jXF0M6TqMnSBa1dSQCKFOBgviKGhr2j9nVhF8JNg== X-Received: by 2002:a05:6a20:d489:b0:3bd:1cfc:1b9b with SMTP id adf61e73a8af0-3c0f08f8997mr25664718637.10.1784086723094; Tue, 14 Jul 2026 20:38:43 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174a583bcsm91977889eec.19.2026.07.14.20.38.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 14 Jul 2026 20:38:42 -0700 (PDT) From: Biren Pandya To: mchehab@kernel.org, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, =?UTF-8?q?Niklas=20S=C3=B6derlund?= , sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya Subject: [PATCH v2 4/5] media: i2c: mt9v011: Add missing media_entity_cleanup() Date: Wed, 15 Jul 2026 09:08:23 +0530 Message-ID: <20260715033818.10967-11-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260715033818.10967-7-birenpandya@gmail.com> References: <20260715033818.10967-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The remove function is missing a call to media_entity_cleanup(). Add it. Signed-off-by: Biren Pandya --- drivers/media/i2c/mt9v011.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/i2c/mt9v011.c b/drivers/media/i2c/mt9v011.c index 055b7915260a..b7ef8bff727d 100644 --- a/drivers/media/i2c/mt9v011.c +++ b/drivers/media/i2c/mt9v011.c @@ -520,6 +520,7 @@ static int mt9v011_probe(struct i2c_client *c) (version !=3D MT9V011_REV_B_VERSION)) { v4l2_info(sd, "*** unknown micron chip detected (0x%04x).\n", version); + media_entity_cleanup(&sd->entity); return -EINVAL; } =20 @@ -542,6 +543,7 @@ static int mt9v011_probe(struct i2c_client *c) =20 v4l2_err(sd, "control initialization error %d\n", ret); v4l2_ctrl_handler_free(&core->ctrls); + media_entity_cleanup(&sd->entity); return ret; } core->sd.ctrl_handler =3D &core->ctrls; @@ -577,6 +579,7 @@ static void mt9v011_remove(struct i2c_client *c) =20 v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(&core->ctrls); + media_entity_cleanup(&sd->entity); } =20 /* -----------------------------------------------------------------------= */ --=20 2.50.1 (Apple Git-155) From nobody Sat Jul 25 18:06:26 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 771A43B0AD3 for ; Wed, 15 Jul 2026 03:38:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086740; cv=none; b=bS2LRTlxfkw+mbNSLbsBhCAs3FNlB3Nwz9jdqzOkEbBWaovl+gYcbG+HYgVUXYrGmiSs4bAmWYPajSghUsxlWf29PVXFjO1VkdqSYoBqqOG4HlDSEKbKDOI0WVXCp/ygniIot4RcjXRusBw7Qy8VUlgbhXfK1TQnu87dXXp1RpM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086740; c=relaxed/simple; bh=1OJ+icYvEUWlm8+gkxpBRGkF6MURV1kBnpa24faYVyg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W1DNKVghf4JvR6zWukusYAhT392X0ReQminjoYUXULVSK/Gn9Jtti9Nzcig2URLymfOIZ73To+TGcJu3BDpPg1PHE/f9tW6j0IRfsJGFyQM0o3msHCx8YgDpPDgWniSbL2UY0cogs3X3ZEXVIduvatPZdfY/8hMOG9Ln6eJKqQA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=muQJv+Fw; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="muQJv+Fw" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c9e607d81fcso1075772a12.2 for ; Tue, 14 Jul 2026 20:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784086727; x=1784691527; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EyiROYORTtKO75BwiwBGsAV70dzUHKAaS+4RZHI8OfY=; b=muQJv+FwmyEyf4CGxc6bvKPltLNf3UQVrcPU1cm2wAIjj3Q7uT6bNjwQKcr+7IVcLx mesGok9Hf29WPNHVZI11Rni3hzWW6SqTZCzY93ESHnOfD6wMb6+RfFPZjWZ94NuKo7hd VX84LH9BQwyM8misfB7NHZD3wHw7LikBFfbSUzJNfOXrK77Fj2/NGcqKjExtrXXADoLa tS3wtaf6va3KYzJs5Ifxin0mzP1C9iN+4HAGHqSGUNLYlcAQRpWqIZfs7MZ0AIJ35ldM 0nIb6lFymitpDAHRvWQmYkj6m7acmT20cXn+kxGoi9bIDJHrqx7T6T9Zik4jb3w0ifVq T1pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784086727; x=1784691527; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=EyiROYORTtKO75BwiwBGsAV70dzUHKAaS+4RZHI8OfY=; b=rqwodFTcynMeOLNVFkbWlJ81wwlPCHHj0JbwL4H/CrHY5C/lSFuUyTlYkptqTVkiIz hD5zlSR8L0VhPUvyhxJvNvDgm9apHWPA7gsNcir5/YnsHqk7KllXBEdfsjB2QFZG2TaR resxtMdORJljeew/yOtxtPBC+PpE/gRV7fl+5Sn/JLXZXbdT9hheAB42rv6N+sVjMXyj KPkHQWanLPn/367xYPjZfxDe8hxFTHJ6FkNkcjekXyiMBCjDejIOdYZfJBoWug4+zBSM LhSprgBU+73AHAukc3bEoO0vgcurcYtDYLIRgY+yTwTKL6xsUhpFFbVMpdE0RfiOIjdU 1yFg== X-Forwarded-Encrypted: i=1; AHgh+Rrx0AkKgZH/M7BoYfX1BCU4yxYqdX7LGtCIg/2HFm0itUkWJgbpw2jw0+GpIKXac6tHDS0AGkexqxk45/Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2NXw4AewPDF0upuTMSIxxHLp4QA1g6hrO79fExrOouR88DHxJ x/k5HNrG8msa1lN4hoklhL/Yiy2dhS7Xv4ifkWd+V1vvutndnLaJ8ZIX X-Gm-Gg: AfdE7cmPozVwUdk2kjC+YO4Bt2ZdRfDuVNEvy7+uvNFSyEPKKiQCspq9WMjY2knHPD5 8yfAg5hlKOa3LFi+5Y31ZMurPlPgtBVWXq9G3VdpAom2GbbQr6KVDYEt9bnEWLK9CDJOfNGN/tI 0ddcXoy/X6nU7XCD/n8gxqw4YfT5eCvH27+CMuKD8FWUlx/+//wVhy6lhPVLWYOBJvFngQ/M2Si 4OoPdCwDrnxb50pHns9CaoU8s34hADPRI94mYPMbWkKoLxpqIJj2MhE4nnXKST4p07Ofqt2OGsm usLEzTmXKzDmZdSUnWljeLlu+vauARDyfOmbYwTETVgPTGH52QJXOopQNPwmIryGT2HE4TR7dn7 oo4EKvIPREowdFYFNeSJb83fzL724QtMbzzAPnBHPYCJjnep0zfcycU9//xLz5Y9bBmA2/UJNY4 T7rBltadQvwrRLHwVeT0kr4LxMoUZ8gR2cQ0RpWor9hgE= X-Received: by 2002:a05:6a21:9d91:b0:3b3:241f:66c6 with SMTP id adf61e73a8af0-3c1108c1a5fmr15396434637.26.1784086727117; Tue, 14 Jul 2026 20:38:47 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174a583bcsm91977889eec.19.2026.07.14.20.38.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 14 Jul 2026 20:38:46 -0700 (PDT) From: Biren Pandya To: mchehab@kernel.org, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, =?UTF-8?q?Niklas=20S=C3=B6derlund?= , sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya Subject: [PATCH v2 5/5] media: i2c: saa7115: Add missing media_entity_cleanup() Date: Wed, 15 Jul 2026 09:08:24 +0530 Message-ID: <20260715033818.10967-12-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260715033818.10967-7-birenpandya@gmail.com> References: <20260715033818.10967-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The remove function is missing a call to media_entity_cleanup(). Add it. Signed-off-by: Biren Pandya --- drivers/media/i2c/saa7115.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c index 48d6730d9271..64adfff3001b 100644 --- a/drivers/media/i2c/saa7115.c +++ b/drivers/media/i2c/saa7115.c @@ -1867,6 +1867,7 @@ static int saa711x_probe(struct i2c_client *client) int err =3D hdl->error; =20 v4l2_ctrl_handler_free(hdl); + media_entity_cleanup(&sd->entity); return err; } v4l2_ctrl_auto_cluster(2, &state->agc, 0, true); @@ -1925,6 +1926,7 @@ static void saa711x_remove(struct i2c_client *client) =20 v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(sd->ctrl_handler); + media_entity_cleanup(&sd->entity); } =20 static const struct i2c_device_id saa711x_id[] =3D { --=20 2.50.1 (Apple Git-155)